@harness-engineering/eslint-plugin 0.3.0 → 0.3.1

package/dist/index.d.ts

@@ -99,6 +99,9 @@ declare const plugin: {
                 '@harness-engineering/no-forbidden-imports': string;
                 '@harness-engineering/require-boundary-schema': string;
                 '@harness-engineering/enforce-doc-exports': string;
+                '@harness-engineering/no-nested-loops-in-critical': string;
+                '@harness-engineering/no-sync-io-in-async': string;
+                '@harness-engineering/no-unbounded-array-chains': string;
                 '@harness-engineering/no-unix-shell-command': string;
                 '@harness-engineering/no-hardcoded-path-separator': string;
                 '@harness-engineering/no-process-env-in-spawn': string;
@@ -115,6 +118,9 @@ declare const plugin: {
                 '@harness-engineering/no-forbidden-imports': string;
                 '@harness-engineering/require-boundary-schema': string;
                 '@harness-engineering/enforce-doc-exports': string;
+                '@harness-engineering/no-nested-loops-in-critical': string;
+                '@harness-engineering/no-sync-io-in-async': string;
+                '@harness-engineering/no-unbounded-array-chains': string;
                 '@harness-engineering/no-unix-shell-command': string;
                 '@harness-engineering/no-hardcoded-path-separator': string;
                 '@harness-engineering/no-process-env-in-spawn': string;
@@ -182,6 +188,9 @@ declare const configs: {
             '@harness-engineering/no-forbidden-imports': string;
             '@harness-engineering/require-boundary-schema': string;
             '@harness-engineering/enforce-doc-exports': string;
+            '@harness-engineering/no-nested-loops-in-critical': string;
+            '@harness-engineering/no-sync-io-in-async': string;
+            '@harness-engineering/no-unbounded-array-chains': string;
             '@harness-engineering/no-unix-shell-command': string;
             '@harness-engineering/no-hardcoded-path-separator': string;
             '@harness-engineering/no-process-env-in-spawn': string;
@@ -245,6 +254,9 @@ declare const configs: {
             '@harness-engineering/no-forbidden-imports': string;
             '@harness-engineering/require-boundary-schema': string;
             '@harness-engineering/enforce-doc-exports': string;
+            '@harness-engineering/no-nested-loops-in-critical': string;
+            '@harness-engineering/no-sync-io-in-async': string;
+            '@harness-engineering/no-unbounded-array-chains': string;
             '@harness-engineering/no-unix-shell-command': string;
             '@harness-engineering/no-hardcoded-path-separator': string;
             '@harness-engineering/no-process-env-in-spawn': string;

package/dist/index.js

@@ -308,17 +308,27 @@ function getConfig(filePath) {
     return null;
   }
 }
+function getConfigRoot(filePath) {
+  const configPath = findConfigFile(path2.dirname(filePath));
+  return configPath ? path2.dirname(configPath) : null;
+}
 
 // src/utils/path-utils.ts
 import * as path3 from "path";
 import { minimatch } from "minimatch";
-function resolveImportPath(importPath, importingFile) {
+function resolveImportPath(importPath, importingFile, projectRoot) {
   if (!importPath.startsWith(".")) {
     return importPath;
   }
   const importingDir = path3.dirname(importingFile);
   const resolved = path3.resolve(importingDir, importPath);
   const normalized = resolved.replace(/\\/g, "/");
+  if (projectRoot) {
+    const root = projectRoot.replace(/\\/g, "/").replace(/\/$/, "");
+    if (normalized.startsWith(root + "/")) {
+      return normalized.slice(root.length + 1);
+    }
+  }
   const srcIndex = normalized.indexOf("/src/");
   if (srcIndex !== -1) {
     return normalized.slice(srcIndex + 1);
@@ -341,8 +351,14 @@ function getLayerForFile(filePath, layers) {
 function getLayerByName(name, layers) {
   return layers.find((l) => l.name === name);
 }
-function normalizePath2(filePath) {
+function normalizePath2(filePath, projectRoot) {
   const normalized = filePath.replace(/\\/g, "/");
+  if (projectRoot) {
+    const root = projectRoot.replace(/\\/g, "/").replace(/\/$/, "");
+    if (normalized.startsWith(root + "/")) {
+      return normalized.slice(root.length + 1);
+    }
+  }
   const srcIndex = normalized.indexOf("/src/");
   if (srcIndex !== -1) {
     return normalized.slice(srcIndex + 1);
@@ -370,9 +386,9 @@ function findViolatedRule(applicableRules, importPath, resolvedImport) {
 function buildForbiddenMessage(rule, importPath) {
   return rule.message ?? `Import "${importPath}" is forbidden in files matching "${rule.from}"`;
 }
-function checkImportDeclaration2(node, applicableRules, filename, report) {
+function checkImportDeclaration2(node, applicableRules, filename, projectRoot, report) {
   const importPath = node.source.value;
-  const resolvedImport = resolveImportPath(importPath, filename);
+  const resolvedImport = resolveImportPath(importPath, filename, projectRoot ?? void 0);
   const violatedRule = findViolatedRule(applicableRules, importPath, resolvedImport);
   if (violatedRule) {
     report({
@@ -400,7 +416,8 @@ var no_forbidden_imports_default = createRule3({
     if (!config?.forbiddenImports?.length) {
       return {};
     }
-    const filePath = normalizePath2(context.filename);
+    const projectRoot = getConfigRoot(context.filename);
+    const filePath = normalizePath2(context.filename, projectRoot ?? void 0);
     const applicableRules = config.forbiddenImports.filter(
       (rule) => matchesPattern(filePath, rule.from)
     );
@@ -410,7 +427,7 @@ var no_forbidden_imports_default = createRule3({
     const report = context.report.bind(context);
     return {
       ImportDeclaration(node) {
-        checkImportDeclaration2(node, applicableRules, context.filename, report);
+        checkImportDeclaration2(node, applicableRules, context.filename, projectRoot, report);
       }
     };
   }
@@ -424,13 +441,13 @@ var createRule4 = ESLintUtils4.RuleCreator(
 function isLayerViolation(importLayer, currentLayer, currentLayerDef) {
   return importLayer !== currentLayer && !currentLayerDef.allowedDependencies.includes(importLayer);
 }
-function resolveImportLayer(importPath, filename, layers) {
+function resolveImportLayer(importPath, filename, layers, projectRoot) {
   if (!importPath.startsWith(".")) return null;
-  const resolvedImport = resolveImportPath(importPath, filename);
+  const resolvedImport = resolveImportPath(importPath, filename, projectRoot ?? void 0);
   return getLayerForFile(resolvedImport, layers) ?? null;
 }
-function checkLayerImport(node, context, currentLayer, currentLayerDef, layers) {
-  const importLayer = resolveImportLayer(node.source.value, context.filename, layers);
+function checkLayerImport(node, context, currentLayer, currentLayerDef, layers, projectRoot) {
+  const importLayer = resolveImportLayer(node.source.value, context.filename, layers, projectRoot);
   if (!importLayer) return;
   if (isLayerViolation(importLayer, currentLayer, currentLayerDef)) {
     context.report({
@@ -458,7 +475,8 @@ var no_layer_violation_default = createRule4({
     if (!config?.layers?.length) {
       return {};
     }
-    const filePath = normalizePath2(context.filename);
+    const projectRoot = getConfigRoot(context.filename);
+    const filePath = normalizePath2(context.filename, projectRoot ?? void 0);
     const currentLayer = getLayerForFile(filePath, config.layers);
     if (!currentLayer) {
       return {};
@@ -470,7 +488,7 @@ var no_layer_violation_default = createRule4({
     const layers = config.layers;
     return {
       ImportDeclaration(node) {
-        checkLayerImport(node, context, currentLayer, currentLayerDef, layers);
+        checkLayerImport(node, context, currentLayer, currentLayerDef, layers, projectRoot);
       }
     };
   }
@@ -964,6 +982,14 @@ function hasProcessEnvProperty(node) {
   }
   return void 0;
 }
+function findEnvViolation(args) {
+  for (const arg of args) {
+    if (arg.type !== "ObjectExpression") continue;
+    const envProp = hasProcessEnvProperty(arg);
+    if (envProp) return envProp;
+  }
+  return void 0;
+}
 var no_process_env_in_spawn_default = createRule11({
   name: "no-process-env-in-spawn",
   meta: {
@@ -978,20 +1004,15 @@ var no_process_env_in_spawn_default = createRule11({
   },
   defaultOptions: [],
   create(context) {
-    return {
-      CallExpression(node) {
-        const name = getSpawnFunctionName(node);
-        if (!name) return;
-        for (const arg of node.arguments) {
-          if (arg.type === "ObjectExpression") {
-            const envProp = hasProcessEnvProperty(arg);
-            if (envProp) {
-              context.report({ node: envProp, messageId: "processEnvInSpawn", data: { name } });
-            }
-          }
-        }
+    function checkCall(node) {
+      const name = getSpawnFunctionName(node);
+      if (!name) return;
+      const violation = findEnvViolation(node.arguments);
+      if (violation) {
+        context.report({ node: violation, messageId: "processEnvInSpawn", data: { name } });
       }
-    };
+    }
+    return { CallExpression: checkCall };
   }
 });
 
@@ -1072,7 +1093,7 @@ var rules = {
 var plugin = {
   meta: {
     name: "@harness-engineering/eslint-plugin",
-    version: "0.2.4"
+    version: "0.3.0"
   },
   rules,
   configs: {
@@ -1088,6 +1109,9 @@ var plugin = {
         "@harness-engineering/no-forbidden-imports": "error",
         "@harness-engineering/require-boundary-schema": "warn",
         "@harness-engineering/enforce-doc-exports": "warn",
+        "@harness-engineering/no-nested-loops-in-critical": "warn",
+        "@harness-engineering/no-sync-io-in-async": "warn",
+        "@harness-engineering/no-unbounded-array-chains": "warn",
         "@harness-engineering/no-unix-shell-command": "warn",
         "@harness-engineering/no-hardcoded-path-separator": "warn",
         "@harness-engineering/no-process-env-in-spawn": "error",
@@ -1106,6 +1130,9 @@ var plugin = {
         "@harness-engineering/no-forbidden-imports": "error",
         "@harness-engineering/require-boundary-schema": "error",
         "@harness-engineering/enforce-doc-exports": "error",
+        "@harness-engineering/no-nested-loops-in-critical": "error",
+        "@harness-engineering/no-sync-io-in-async": "error",
+        "@harness-engineering/no-unbounded-array-chains": "error",
         "@harness-engineering/no-unix-shell-command": "error",
         "@harness-engineering/no-hardcoded-path-separator": "error",
         "@harness-engineering/no-process-env-in-spawn": "error",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@harness-engineering/eslint-plugin",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "ESLint plugin for harness engineering architectural constraints",
   "type": "module",
   "main": "./dist/index.js",