@harness-engineering/cli 2.6.1 → 2.7.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (156) hide show
  1. package/dist/agents/skills/claude-code/align-design-system/SKILL.md +174 -0
  2. package/dist/agents/skills/claude-code/align-design-system/skill.yaml +57 -0
  3. package/dist/agents/skills/claude-code/audit-brand-compliance/SKILL.md +189 -0
  4. package/dist/agents/skills/claude-code/audit-brand-compliance/skill.yaml +50 -0
  5. package/dist/agents/skills/claude-code/audit-component-anatomy/SKILL.md +181 -0
  6. package/dist/agents/skills/claude-code/audit-component-anatomy/skill.yaml +51 -0
  7. package/dist/agents/skills/claude-code/copy-craft/SKILL.md +192 -0
  8. package/dist/agents/skills/claude-code/copy-craft/skill.yaml +52 -0
  9. package/dist/agents/skills/claude-code/detect-design-drift/SKILL.md +139 -0
  10. package/dist/agents/skills/claude-code/detect-design-drift/skill.yaml +50 -0
  11. package/dist/agents/skills/claude-code/harness-accessibility/SKILL.md +10 -0
  12. package/dist/agents/skills/claude-code/harness-design-craft/SKILL.md +212 -0
  13. package/dist/agents/skills/claude-code/harness-design-craft/skill.yaml +57 -0
  14. package/dist/agents/skills/claude-code/harness-design-pipeline/SKILL.md +266 -0
  15. package/dist/agents/skills/claude-code/harness-design-pipeline/skill.yaml +70 -0
  16. package/dist/agents/skills/claude-code/knowledge-craft/SKILL.md +180 -0
  17. package/dist/agents/skills/claude-code/knowledge-craft/skill.yaml +49 -0
  18. package/dist/agents/skills/claude-code/naming-craft/SKILL.md +244 -0
  19. package/dist/agents/skills/claude-code/naming-craft/skill.yaml +51 -0
  20. package/dist/agents/skills/claude-code/security-craft/SKILL.md +205 -0
  21. package/dist/agents/skills/claude-code/security-craft/skill.yaml +58 -0
  22. package/dist/agents/skills/claude-code/spec-craft/SKILL.md +184 -0
  23. package/dist/agents/skills/claude-code/spec-craft/skill.yaml +55 -0
  24. package/dist/agents/skills/claude-code/test-craft/SKILL.md +212 -0
  25. package/dist/agents/skills/claude-code/test-craft/skill.yaml +58 -0
  26. package/dist/agents/skills/codex/align-design-system/SKILL.md +174 -0
  27. package/dist/agents/skills/codex/align-design-system/skill.yaml +57 -0
  28. package/dist/agents/skills/codex/audit-brand-compliance/SKILL.md +189 -0
  29. package/dist/agents/skills/codex/audit-brand-compliance/skill.yaml +50 -0
  30. package/dist/agents/skills/codex/audit-component-anatomy/SKILL.md +181 -0
  31. package/dist/agents/skills/codex/audit-component-anatomy/skill.yaml +51 -0
  32. package/dist/agents/skills/codex/copy-craft/SKILL.md +192 -0
  33. package/dist/agents/skills/codex/copy-craft/skill.yaml +52 -0
  34. package/dist/agents/skills/codex/detect-design-drift/SKILL.md +139 -0
  35. package/dist/agents/skills/codex/detect-design-drift/skill.yaml +50 -0
  36. package/dist/agents/skills/codex/harness-accessibility/SKILL.md +10 -0
  37. package/dist/agents/skills/codex/harness-design-craft/SKILL.md +212 -0
  38. package/dist/agents/skills/codex/harness-design-craft/skill.yaml +57 -0
  39. package/dist/agents/skills/codex/harness-design-pipeline/SKILL.md +266 -0
  40. package/dist/agents/skills/codex/harness-design-pipeline/skill.yaml +70 -0
  41. package/dist/agents/skills/codex/knowledge-craft/SKILL.md +180 -0
  42. package/dist/agents/skills/codex/knowledge-craft/skill.yaml +49 -0
  43. package/dist/agents/skills/codex/naming-craft/SKILL.md +244 -0
  44. package/dist/agents/skills/codex/naming-craft/skill.yaml +51 -0
  45. package/dist/agents/skills/codex/security-craft/SKILL.md +205 -0
  46. package/dist/agents/skills/codex/security-craft/skill.yaml +58 -0
  47. package/dist/agents/skills/codex/spec-craft/SKILL.md +184 -0
  48. package/dist/agents/skills/codex/spec-craft/skill.yaml +55 -0
  49. package/dist/agents/skills/codex/test-craft/SKILL.md +212 -0
  50. package/dist/agents/skills/codex/test-craft/skill.yaml +58 -0
  51. package/dist/agents/skills/cursor/align-design-system/SKILL.md +174 -0
  52. package/dist/agents/skills/cursor/align-design-system/skill.yaml +57 -0
  53. package/dist/agents/skills/cursor/audit-brand-compliance/SKILL.md +189 -0
  54. package/dist/agents/skills/cursor/audit-brand-compliance/skill.yaml +50 -0
  55. package/dist/agents/skills/cursor/audit-component-anatomy/SKILL.md +181 -0
  56. package/dist/agents/skills/cursor/audit-component-anatomy/skill.yaml +51 -0
  57. package/dist/agents/skills/cursor/copy-craft/SKILL.md +192 -0
  58. package/dist/agents/skills/cursor/copy-craft/skill.yaml +52 -0
  59. package/dist/agents/skills/cursor/detect-design-drift/SKILL.md +139 -0
  60. package/dist/agents/skills/cursor/detect-design-drift/skill.yaml +50 -0
  61. package/dist/agents/skills/cursor/harness-accessibility/SKILL.md +10 -0
  62. package/dist/agents/skills/cursor/harness-design-craft/SKILL.md +212 -0
  63. package/dist/agents/skills/cursor/harness-design-craft/skill.yaml +57 -0
  64. package/dist/agents/skills/cursor/harness-design-pipeline/SKILL.md +266 -0
  65. package/dist/agents/skills/cursor/harness-design-pipeline/skill.yaml +70 -0
  66. package/dist/agents/skills/cursor/knowledge-craft/SKILL.md +180 -0
  67. package/dist/agents/skills/cursor/knowledge-craft/skill.yaml +49 -0
  68. package/dist/agents/skills/cursor/naming-craft/SKILL.md +244 -0
  69. package/dist/agents/skills/cursor/naming-craft/skill.yaml +51 -0
  70. package/dist/agents/skills/cursor/security-craft/SKILL.md +205 -0
  71. package/dist/agents/skills/cursor/security-craft/skill.yaml +58 -0
  72. package/dist/agents/skills/cursor/spec-craft/SKILL.md +184 -0
  73. package/dist/agents/skills/cursor/spec-craft/skill.yaml +55 -0
  74. package/dist/agents/skills/cursor/test-craft/SKILL.md +212 -0
  75. package/dist/agents/skills/cursor/test-craft/skill.yaml +58 -0
  76. package/dist/agents/skills/gemini-cli/align-design-system/SKILL.md +174 -0
  77. package/dist/agents/skills/gemini-cli/align-design-system/skill.yaml +57 -0
  78. package/dist/agents/skills/gemini-cli/audit-brand-compliance/SKILL.md +189 -0
  79. package/dist/agents/skills/gemini-cli/audit-brand-compliance/skill.yaml +50 -0
  80. package/dist/agents/skills/gemini-cli/audit-component-anatomy/SKILL.md +181 -0
  81. package/dist/agents/skills/gemini-cli/audit-component-anatomy/skill.yaml +51 -0
  82. package/dist/agents/skills/gemini-cli/copy-craft/SKILL.md +192 -0
  83. package/dist/agents/skills/gemini-cli/copy-craft/skill.yaml +52 -0
  84. package/dist/agents/skills/gemini-cli/detect-design-drift/SKILL.md +139 -0
  85. package/dist/agents/skills/gemini-cli/detect-design-drift/skill.yaml +50 -0
  86. package/dist/agents/skills/gemini-cli/harness-accessibility/SKILL.md +10 -0
  87. package/dist/agents/skills/gemini-cli/harness-design-craft/SKILL.md +212 -0
  88. package/dist/agents/skills/gemini-cli/harness-design-craft/skill.yaml +57 -0
  89. package/dist/agents/skills/gemini-cli/harness-design-pipeline/SKILL.md +266 -0
  90. package/dist/agents/skills/gemini-cli/harness-design-pipeline/skill.yaml +70 -0
  91. package/dist/agents/skills/gemini-cli/knowledge-craft/SKILL.md +180 -0
  92. package/dist/agents/skills/gemini-cli/knowledge-craft/skill.yaml +49 -0
  93. package/dist/agents/skills/gemini-cli/naming-craft/SKILL.md +244 -0
  94. package/dist/agents/skills/gemini-cli/naming-craft/skill.yaml +51 -0
  95. package/dist/agents/skills/gemini-cli/security-craft/SKILL.md +205 -0
  96. package/dist/agents/skills/gemini-cli/security-craft/skill.yaml +58 -0
  97. package/dist/agents/skills/gemini-cli/spec-craft/SKILL.md +184 -0
  98. package/dist/agents/skills/gemini-cli/spec-craft/skill.yaml +55 -0
  99. package/dist/agents/skills/gemini-cli/test-craft/SKILL.md +212 -0
  100. package/dist/agents/skills/gemini-cli/test-craft/skill.yaml +58 -0
  101. package/dist/{agents-md-2JUQ4FE2.js → agents-md-FKMKH6ZF.js} +4 -4
  102. package/dist/{analyzer-VY6DJVOU-4AHIJLNS.js → analyzer-H3AHBFSL-KPOPJYRB.js} +8 -8
  103. package/dist/{architecture-CXAVNB5X.js → architecture-LUR2I67H.js} +6 -6
  104. package/dist/{assess-project-M626SSPN.js → assess-project-OJWECOP2.js} +2 -1
  105. package/dist/bin/harness-mcp.js +17 -17
  106. package/dist/bin/harness.js +27 -27
  107. package/dist/{check-phase-gate-XMU6LLUQ.js → check-phase-gate-HS5KYLRO.js} +5 -5
  108. package/dist/{chunk-5XLLIYYL.js → chunk-6UHDQP2N.js} +1 -1
  109. package/dist/{chunk-I6K43QQS.js → chunk-7AF6C5GE.js} +3 -3
  110. package/dist/{chunk-372MGNTI.js → chunk-7PLIWP7U.js} +6899 -133
  111. package/dist/{chunk-VUCGB2KH.js → chunk-B2VAYLYI.js} +1 -1
  112. package/dist/{chunk-HFOB2MPQ.js → chunk-CZPOPMMI.js} +3 -3
  113. package/dist/{chunk-43M3RLFQ.js → chunk-FC4JPM6W.js} +2 -2
  114. package/dist/{chunk-6AX6R3LM.js → chunk-FEKBXX2J.js} +9 -9
  115. package/dist/{chunk-VTTNIZJL.js → chunk-FXZI6NJ2.js} +131 -6
  116. package/dist/{chunk-5JNSFYZU.js → chunk-GGSNWH7P.js} +6 -6
  117. package/dist/{chunk-BCFDGOMA.js → chunk-H2ZJOJ7A.js} +81 -1
  118. package/dist/{chunk-PFZEADQM.js → chunk-INBTDBV2.js} +79 -2
  119. package/dist/{chunk-Q6ZR2L6Q.js → chunk-KN3EMDZ5.js} +2 -2
  120. package/dist/{chunk-JFZOWO7D.js → chunk-LECXPXS3.js} +1 -1
  121. package/dist/{chunk-CQOMVZDC.js → chunk-LGYXR2KZ.js} +2237 -604
  122. package/dist/{chunk-QOKMDDBJ.js → chunk-LYIPI2SJ.js} +6 -6
  123. package/dist/{chunk-L5BCZ5XS.js → chunk-N5NSSLMU.js} +1 -1
  124. package/dist/{chunk-GWE5LL3R.js → chunk-NIVWM7OW.js} +10 -10
  125. package/dist/{chunk-24KCOJJG.js → chunk-O2ASYKA6.js} +1 -1
  126. package/dist/{chunk-K246XQ2L.js → chunk-PTHX545Q.js} +1 -1
  127. package/dist/{chunk-EPUKTTJZ.js → chunk-RC3OI5NK.js} +5 -1
  128. package/dist/{chunk-YP7I25SL.js → chunk-RJ2WEES5.js} +1 -1
  129. package/dist/{chunk-5FDBXUFW.js → chunk-TIH53QXY.js} +1 -1
  130. package/dist/{chunk-OA6SWTU4.js → chunk-VI4IS55S.js} +11 -8
  131. package/dist/{chunk-GWF2OILZ.js → chunk-VSIRUZQP.js} +1 -1
  132. package/dist/{chunk-YYRQCQPZ.js → chunk-WZY5U6NS.js} +178 -109
  133. package/dist/{chunk-SZEFU6XC.js → chunk-Y4T6ENKQ.js} +9 -9
  134. package/dist/{chunk-HMW3VKUF.js → chunk-Z3TMCCZB.js} +10 -10
  135. package/dist/{ci-workflow-3JNDZQYD.js → ci-workflow-MDSTHJOY.js} +4 -4
  136. package/dist/{dist-OHDQBTSO.js → dist-72ID44UE.js} +3 -3
  137. package/dist/{dist-QPWXPCPL.js → dist-R3TOOPJ7.js} +1 -1
  138. package/dist/{docs-5RYMDHN3.js → docs-2RFOJ6XY.js} +6 -6
  139. package/dist/{engine-GKGT5ULT.js → engine-BSFKOGPN.js} +4 -4
  140. package/dist/{entropy-DQTAPSSE.js → entropy-3UX6644G.js} +5 -5
  141. package/dist/{feedback-WH6XPQJS.js → feedback-CVCFYND4.js} +2 -2
  142. package/dist/{generate-agent-definitions-SZA4QIHN.js → generate-agent-definitions-HZ3XENWO.js} +5 -5
  143. package/dist/{glob-helper-XE2UGEOV.js → glob-helper-EX4YZKZO.js} +1 -1
  144. package/dist/{graph-loader-EQBOIHFZ.js → graph-loader-EIFEOUVI.js} +1 -1
  145. package/dist/index.d.ts +1012 -12
  146. package/dist/index.js +27 -27
  147. package/dist/{loader-BNKGM23C.js → loader-6RHWU5FH.js} +4 -4
  148. package/dist/{mcp-YKKPWUMH.js → mcp-OYR26JDI.js} +17 -17
  149. package/dist/{performance-54TMJOEU.js → performance-JJMIRXCH.js} +6 -6
  150. package/dist/{review-pipeline-OTDDVPNY.js → review-pipeline-BHQZIXWZ.js} +4 -4
  151. package/dist/{runtime-W5THSNAL.js → runtime-DALTAVTN.js} +4 -4
  152. package/dist/{scan-4PPP6ZXT.js → scan-LYKLM4EQ.js} +1 -1
  153. package/dist/{security-27HW7CYT.js → security-RMLMYFPB.js} +1 -1
  154. package/dist/{validate-QRVCD4GP.js → validate-R7DZRDFK.js} +5 -5
  155. package/dist/{validate-cross-check-BUAGBAPO.js → validate-cross-check-AUUZFNVL.js} +4 -4
  156. package/package.json +8 -7
@@ -0,0 +1,180 @@
1
+ # Knowledge Craft
2
+
3
+ > LLM-judgment critique of knowledge-entry quality. Critiques `docs/knowledge/` entries (EXCLUDING `decisions/` — that's spec-craft's territory) against a curated rubric catalog: does this state a load-bearing FACT or paraphrase the code? Would deleting it lose specific signal? Does it earn its place in the knowledge graph as `business_fact` / `business_rule` / `business_concept` / `business_decision`? Fifth non-design member of the craft-pipeline initiative (#9 of 10). Emits 3-axis findings (tier × impact × confidence per ADR 0019).
4
+
5
+ ## When to Use
6
+
7
+ - During PR review on a new or substantially-rewritten knowledge entry
8
+ - After authoring a knowledge entry, before adding it to the index
9
+ - When onboarding a new contributor (audit entries they introduced)
10
+ - Periodically (per-sprint or per-release) to catch knowledge-entry rot
11
+ - As a quality gate before `harness-knowledge-pipeline` ingests an entry into the graph
12
+ - NOT for ADR / proposal critique (use `spec-craft` — `decisions/` is its territory)
13
+ - NOT for AGENTS.md critique (different shape: navigational manifest, not fact-bearing entry — v1.x)
14
+ - NOT for autofix / knowledge-entry rewriting (this is judgment-only; v1.x may add `align-knowledge` sibling)
15
+ - NOT for graph-membership checks (no graph reads at runtime — references the taxonomy in rubric prompts)
16
+ - NOT for source-code comment critique (use `code-craft` #4 or `docs-craft` #2)
17
+
18
+ ## Process
19
+
20
+ ### Phase 1: DISCOVER — Find knowledge entries
21
+
22
+ 1. **Read project configuration.** Check `harness.config.json` for:
23
+ - `craft.knowledge.enabled` — gate (default `true`)
24
+ - `craft.knowledge.maxFiles` — entry count cap (default 50)
25
+ - `craft.knowledge.excludeDirs` — extra subdirs to skip
26
+
27
+ 2. **Walk `docs/knowledge/` recursively:**
28
+ - Include `*.md` files (case-insensitive `README.md` excluded)
29
+ - EXCLUDE `decisions/` subdir entirely (spec-craft's territory)
30
+ - EXCLUDE any user-supplied extra dirs via `--exclude-dirs`
31
+ - Caller-supplied `--files` overrides discovery for explicit scoping
32
+
33
+ ### Phase 2: CRITIQUE — Per (file, rubric) loop
34
+
35
+ 7 seed rubrics:
36
+
37
+ | Rubric | Title |
38
+ | ----------- | ----------------------------------------------- |
39
+ | `KNOW-R001` | States a load-bearing fact (not paraphrase) |
40
+ | `KNOW-R002` | Truth a code reader could not derive |
41
+ | `KNOW-R003` | Earns a place in the knowledge graph taxonomy |
42
+ | `KNOW-R004` | Carries forward a decision that would erode |
43
+ | `KNOW-R005` | Deleting would lose specific knowledge |
44
+ | `KNOW-R006` | Concrete and operationally defined |
45
+ | `KNOW-R007` | A stranger could pick it up six months from now |
46
+
47
+ For each (file, rubric) pair:
48
+
49
+ 1. Build prompt with rubric description + file path + relative-to-knowledge-root path + entry contents (truncated to 4000 chars for cost).
50
+ 2. LLM returns fenced JSON: `null` (rubric doesn't apply / entry is fine) OR `{ tier, impact, confidence, message }`.
51
+ 3. On non-null: emit a `KnowledgeFinding` with `cite.rubricId` populated for ADR 0020 traceability.
52
+
53
+ `KNOW-R003` is the rubric that references the graph taxonomy (`business_fact`, `business_rule`, `business_concept`, `business_decision`) inside its description — the LLM critiques against the taxonomy without knowledge-craft ever reading the graph.
54
+
55
+ ### Phase 3: REPORT — Aggregate + cost telemetry
56
+
57
+ Emit `KnowledgeCraftOutput`:
58
+
59
+ ```ts
60
+ {
61
+ findings: KnowledgeFinding[];
62
+ summary: {
63
+ phaseRun: ['critique'];
64
+ mode: 'fast';
65
+ durationMs: number;
66
+ llmCalls: { provider, model, count, costUsd };
67
+ catalog: { rubricsApplied: string[] };
68
+ counts: { filesScanned, filesSkipped };
69
+ runId: string;
70
+ }
71
+ }
72
+ ```
73
+
74
+ ## Harness Integration
75
+
76
+ - **`harness knowledge-craft`** — CLI entry. `--files <glob>` / `--exclude-dirs <dirs...>` / `--max-files <n>` / `--json` / `--verbose`.
77
+ - **`mcp__harness__knowledge_craft`** — MCP tool. Same input/output. Consumed by agents.
78
+ - **Cross-cutting API:** `critiqueKnowledgeFile(file, opts)` exported from `packages/cli/src/knowledge-craft/index.ts`. Future craft skills (or `harness-knowledge-pipeline`) can call this on a single entry without re-walking the project.
79
+ - **Shared craft infrastructure:** `LlmProvider`, `MockLlmProvider`, `derivePriority`, 3-axis types all live in `packages/cli/src/shared/craft/`.
80
+
81
+ ## Success Criteria
82
+
83
+ See `docs/changes/craft-pipeline/knowledge-craft/proposal.md` for the full 25 success criteria. Highlights:
84
+
85
+ - 7 seed rubrics ship at `catalog/rubrics/<id>.ts` (file-per-rubric)
86
+ - 3-axis output preserved (tier × impact × confidence, never collapsed)
87
+ - `cite.rubricId` populated on every finding (ADR 0020)
88
+ - `decisions/` subdir is hard-excluded from discovery (spec-craft territory)
89
+ - `KNOW-R003` references graph node types in rubric prompt without graph imports at runtime
90
+ - `critiqueKnowledgeFile` cross-cutting API works on a single file without project walk
91
+
92
+ ## Examples
93
+
94
+ ### Example: Paraphrase entry
95
+
96
+ **Input:** `docs/knowledge/auth/email-validator.md`:
97
+
98
+ ```
99
+ # Email Validator
100
+
101
+ The user service validates emails via the EmailValidator class, which
102
+ applies the standard regex pattern and rejects malformed addresses.
103
+ ```
104
+
105
+ **Output (mock LLM):**
106
+
107
+ ```
108
+ KNOW-R001 [foundational/large/medium] auth/email-validator.md
109
+ This entry restates what a reader would learn from opening
110
+ EmailValidator.ts. It states no load-bearing fact about the domain:
111
+ no upstream constraint, no historical reason for the choice, no business
112
+ rule that necessitated validation. Either rewrite to capture the WHY
113
+ (e.g., "emails must round-trip through Postmark within 30s for
114
+ deliverability tracking") or delete — the code already speaks.
115
+ KNOW-R005 [polish/medium/medium] auth/email-validator.md
116
+ Deleting this entry would lose nothing the code doesn't already convey.
117
+ ```
118
+
119
+ ### Example: Decision-bearing entry
120
+
121
+ **Input:** `docs/knowledge/storage/postgres-over-dynamo.md`:
122
+
123
+ ```
124
+ # Why Postgres over DynamoDB
125
+
126
+ We chose Postgres over DynamoDB because our access patterns are
127
+ relational (frequent multi-table joins on tenant + user) and our team's
128
+ ops muscle is in SQL. DynamoDB's single-table design was rejected
129
+ because the modeling overhead of GSIs outweighs the latency win for
130
+ our request profile.
131
+ ```
132
+
133
+ **Output:**
134
+
135
+ ```
136
+ (no findings)
137
+ ```
138
+
139
+ This entry carries forward a decision with the alternative AND the reason — KNOW-R004 passes, KNOW-R001 passes (load-bearing fact: the rejected option + the WHY), KNOW-R005 passes (deleting loses knowledge a reader couldn't reconstruct from the schema alone).
140
+
141
+ ### Example: Empty project — no knowledge entries
142
+
143
+ **Input:** Project has no `docs/knowledge/` directory.
144
+
145
+ **Output:**
146
+
147
+ ```
148
+ No knowledge-entry findings.
149
+
150
+ Summary: 0 findings across 0 entries (0 skipped, 7 rubrics, 0 LLM calls, $0.0000, 2ms)
151
+ ```
152
+
153
+ ## Gates
154
+
155
+ - **No autofix.** Sibling `align-knowledge` deferred until signal warrants safe-to-apply rewrites.
156
+ - **No ADR critique.** `decisions/` is spec-craft's territory; double-critique on the same files produces noise.
157
+ - **No AGENTS.md critique.** Navigational manifests need a different rubric vocabulary; v1.x.
158
+ - **No graph reads.** v1 references graph node types in rubric prompts so the LLM critiques against the taxonomy without a runtime graph dependency.
159
+ - **No graph persistence of findings.** Phase 1 MVP.
160
+ - **No per-section / per-claim mode.** v1 is per-file (knowledge entries are typically focused single-topic).
161
+ - **No `.mdx` support.** Different parsing concerns; v1.x.
162
+ - **No B' bootstrap.** Same posture as the rest of the craft family.
163
+
164
+ ## Escalation
165
+
166
+ - **When LLM cost is too high:** drop `maxFiles` to 25, or scope explicitly with `--files`. Per-entry cost = rubrics × per-call; truncation already caps per-call cost at 4000 input chars.
167
+ - **When a rubric produces high false-positive rate:** v1 has no per-rubric disable; v1.x adds `craft.knowledge.disabledRubrics: ['KNOW-R007']`. Until then: filter findings by `cite.rubricId` in your consumer.
168
+ - **When an entry is intentionally scratchpad / in-progress:** low-confidence findings are de-emphasized per ADR 0019. v1.x adds per-entry opt-out via `<!-- knowledge-craft:skip -->` HTML comment.
169
+ - **When you want graph-aware critique (e.g., "this entry duplicates an existing business_fact node"):** v1.x opt-in mode will read the graph; v1 stays read-free.
170
+ - **When you want to critique an ADR:** use `harness spec-craft` — ADRs are its territory. Knowledge-craft will refuse to walk `decisions/`.
171
+
172
+ ## Status
173
+
174
+ **v1 — in implementation.** See:
175
+
176
+ - Spec: `docs/changes/craft-pipeline/knowledge-craft/proposal.md`
177
+ - Roadmap entry: `craft-pipeline sub-project #9`
178
+ - Sibling craft skills: `naming-craft` (#1), `spec-craft` (#6), `copy-craft` (#5), `test-craft` (#3), `harness-design-craft` (design-pipeline #6)
179
+ - Shared infrastructure: `packages/cli/src/shared/craft/`
180
+ - Future: `align-knowledge` (FIX side), AGENTS.md / `.mdx` support, graph-aware mode, composition with `harness-knowledge-pipeline` at ingest time.
@@ -0,0 +1,49 @@
1
+ name: knowledge-craft
2
+ version: "0.1.0"
3
+ description: LLM-judgment critique of knowledge-entry quality (docs/knowledge/, excluding decisions/ which is spec-craft territory). Per-file critique against 7 seed rubrics that ask whether the entry states a load-bearing fact, earns a place in the graph taxonomy, carries forward a decision that would otherwise erode. Fifth non-design craft-pipeline ceiling skill.
4
+ stability: draft
5
+ cognitive_mode: constructive-architect
6
+ triggers:
7
+ - manual
8
+ - on_pr
9
+ - on_new_feature
10
+ platforms:
11
+ - claude-code
12
+ tools:
13
+ - Bash
14
+ - Read
15
+ - Glob
16
+ - Grep
17
+ cli:
18
+ command: harness knowledge-craft
19
+ args:
20
+ - name: path
21
+ description: Project root path
22
+ required: false
23
+ - name: files
24
+ description: Optional file scope (overrides discovery)
25
+ required: false
26
+ - name: exclude-dirs
27
+ description: Extra subdir names to skip under docs/knowledge/ (decisions is always excluded)
28
+ required: false
29
+ mcp:
30
+ tool: knowledge_craft
31
+ input:
32
+ path: string
33
+ type: rigid
34
+ tier: 2
35
+ phases:
36
+ - name: discover
37
+ description: Walk docs/knowledge/ recursively, exclude decisions/ + user-supplied dirs
38
+ required: true
39
+ - name: critique
40
+ description: LLM-rubric loop per (file, rubric) — 7 seed rubrics
41
+ required: true
42
+ - name: report
43
+ description: Aggregate findings + cost telemetry + entry counts
44
+ required: true
45
+ state:
46
+ persistent: false
47
+ depends_on:
48
+ - harness-soundness-review
49
+ - spec-craft
@@ -0,0 +1,244 @@
1
+ # Naming Craft
2
+
3
+ > LLM-judgment skill that critiques identifier names — variables, functions, types, and files — for clarity, concreteness, weight, and predictive power. First member of the craft-pipeline initiative (sub-project #1 of 10). Uses a curated rubric catalog seeded from Martin / Beck / Karlton. Emits 3-axis findings (tier × impact × confidence per ADR 0019).
4
+
5
+ ## When to Use
6
+
7
+ - During PR review on code that adds or renames identifiers
8
+ - When onboarding a new contributor (audit names they introduced)
9
+ - When refactoring a module (verify renamed names earn their letters)
10
+ - As the cross-cutting naming critic for other craft skills (docs-craft, test-craft, code-craft will call into this)
11
+ - NOT for code-convention enforcement (use ESLint rules — this is ceiling, those are floor)
12
+ - NOT for autofix / rename codemod (this is judgment-only; the v2 sibling `align-naming` ships the fix path)
13
+ - NOT for module / branch / commit-subject naming (v1.x — different infrastructure)
14
+ - NOT for languages beyond TS/JS in v1 (Python/Go/Rust idiom catalogs are v1.x)
15
+
16
+ ## Process
17
+
18
+ ### Phase 1: EXTRACT — Identifier walk
19
+
20
+ 1. **Read project configuration.** Check `harness.config.json` for:
21
+ - `craft.naming.enabled` — gate (default `true`)
22
+ - `craft.naming.maxFiles` — file count cap (default 100)
23
+ - `craft.naming.maxIdentifiersPerFile` — per-file sampling cap (default 15)
24
+
25
+ 2. **Walk project files** (.ts / .tsx / .js / .jsx). Skip `node_modules`, `dist`, `build`, `coverage`, dotdirs.
26
+
27
+ 3. **Extract identifiers per file** via TS Compiler API:
28
+ - **variable** — `const x =`, `let x =`, destructuring binders
29
+ - **function** — `function x()`, `const x = () =>`, class methods, arrow functions assigned to a name
30
+ - **type** — `type X`, `interface X`, `class X`
31
+ - For each: capture file, line, exported status, scope size (`short` = body ≤10 lines; `long` = otherwise), and ±2 context lines for LLM prompt construction.
32
+
33
+ ### Phase 2: SAMPLE — Convention inference
34
+
35
+ For each identifier kind, sample up to N=500 identifiers across the project and infer the dominant convention via majority-rule:
36
+
37
+ - **variables / functions** — camelCase / snake_case / PascalCase
38
+ - **types** — PascalCase / camelCase
39
+ - **files** — kebab-case / camelCase / PascalCase (basenames sans extension)
40
+
41
+ `>50%` majority threshold per kind. Below threshold → `null` (no dominant convention) and the convention-conformance rubric silently skips.
42
+
43
+ ### Phase 3: CRITIQUE — Per-rubric LLM loop
44
+
45
+ For each file:
46
+
47
+ 1. **Sample identifiers** weighted by importance:
48
+ - Exported identifiers first
49
+ - Then long-scope (file-level, methods on long classes)
50
+ - Then short-scope random fill
51
+ - Cap at `maxIdentifiersPerFile` per file (default 15).
52
+
53
+ 2. **For each (identifier, rubric)** in the cross-product:
54
+ - Build a prompt with rubric description + identifier + context lines + project convention.
55
+ - LLM returns fenced JSON: either `null` (rubric doesn't apply / name is fine) or `{ tier, impact, confidence, message }`.
56
+ - On non-null: emit a `NamingFinding` with `cite.rubricId` populated for ADR 0020 traceability.
57
+
58
+ 3. **v1 rubric catalog (6 seed rubrics):**
59
+ - `NAME-R001` **predictive power** (Martin) — does the name predict the contract?
60
+ - `NAME-R002` **concreteness** (Martin / Beck) — concrete > vague
61
+ - `NAME-R003` **verb/noun honesty** (Beck) — verb for functions; noun for types; questions for booleans
62
+ - `NAME-R004` **convention conformance** (Karlton) — matches project convention
63
+ - `NAME-R005` **scope match** (Beck) — length proportional to scope
64
+ - `NAME-R006` **encoded measure** (Pragmatic Programmer) — silent units cause real bugs
65
+
66
+ ### Phase 4: REPORT — Aggregate + cost telemetry
67
+
68
+ Emit `NamingCraftOutput`:
69
+
70
+ ```ts
71
+ {
72
+ findings: NamingFinding[];
73
+ summary: {
74
+ phaseRun: ['critique'];
75
+ durationMs: number;
76
+ llmCalls: { provider, model, count, costUsd };
77
+ catalog: { rubricsApplied: string[] };
78
+ convention: { variables, functions, types, files };
79
+ runId: string;
80
+ }
81
+ }
82
+ ```
83
+
84
+ ## Harness Integration
85
+
86
+ - **`harness naming-craft`** — CLI entry. `--files <glob>` / `--kinds <variable|function|type|file>` / `--max-files <n>` / `--max-identifiers-per-file <n>` / `--json` / `--verbose`.
87
+ - **`mcp__harness__naming_craft`** — MCP tool. Two modes (see "In-session flow" below).
88
+ - **`mcp__harness__naming_craft_finalize`** — MCP tool that completes the in-session flow.
89
+ - **Cross-cutting API:** `critiqueNamesInFile(file, opts)` exported from `packages/cli/src/naming-craft/index.ts`. Future craft skills (docs-craft, test-craft, code-craft) import and invoke this when they want naming critique on a file they're already processing — no project re-walk needed.
90
+ - **LLM provider:** configured in `harness.config.json`. The shared selector in `packages/cli/src/shared/craft/llm/provider.ts` reads two blocks:
91
+ - **`agent.backends`** — named backend definitions, shared with the orchestrator. Supported types: `claude`, `anthropic`, `openai`, `local`, `pi`, `mock`. (`local` and `pi` are OpenAI-compatible — point them at Ollama / LM Studio / vLLM / LiteLLM / any compliant server.)
92
+ - **`craft.llm`** — either `{ "backend": "<name>" }` to route through one of the entries above, or `{ "mode": "in-session" | "mock" }` for the non-backend modes. Default when nothing is set: `in-session` (host chat answers prompts via the two-step MCP flow).
93
+ - **`HARNESS_CRAFT_LLM`** env var overrides the file. Accepts `in-session`, `mock`, or the name of any entry in `agent.backends`.
94
+
95
+ ### Migration from `harness.orchestrator.md`
96
+
97
+ If you already declared `agent.backends` in `harness.orchestrator.md`, the craft selector reads from it as a fallback and emits a one-time warning on first run. Run `harness migrate backends` (preview with `--dry-run`) to copy the entries into `harness.config.json` so both files share a single source of truth.
98
+
99
+ ### Example
100
+
101
+ Example config snippet for routing craft skills to a local Ollama:
102
+
103
+ ```jsonc
104
+ {
105
+ "agent": {
106
+ "backends": {
107
+ "ollama": {
108
+ "type": "local",
109
+ "endpoint": "http://localhost:11434/v1",
110
+ "model": ["deepseek-coder-v2", "qwen3:8b"],
111
+ },
112
+ },
113
+ },
114
+ "craft": { "llm": { "backend": "ollama" } },
115
+ }
116
+ ```
117
+
118
+ ## In-session flow (default)
119
+
120
+ When `HARNESS_CRAFT_LLM` is unset (or set to `in-session`), the MCP tool does **not** call any LLM. Instead it returns a list of prompts for the calling agent to answer with its own model. This is a two-step protocol:
121
+
122
+ **Step 1 — `mcp__harness__naming_craft({ path, ... })`** returns:
123
+
124
+ ```json
125
+ {
126
+ "status": "collected",
127
+ "runId": "<uuid>",
128
+ "pendingPrompts": [
129
+ { "promptId": "p1", "systemPrompt": "...", "userPrompt": "..." },
130
+ ...
131
+ ],
132
+ "projection": { "promptCount": N, "budget": 100 }
133
+ }
134
+ ```
135
+
136
+ If `projection.promptCount > budget`, `status` is `"budget-exceeded"` and `pendingPrompts` is empty — re-invoke with smaller `maxFiles` / `maxIdentifiersPerFile`, or pass `promptBudget` to raise the ceiling.
137
+
138
+ **Step 2** — for each pending prompt, generate the fenced-JSON response as if you were a senior engineer applying the rubric to the identifier. The required response shape (per prompt) is:
139
+
140
+ ````
141
+ ```json
142
+ null
143
+ ```
144
+ ````
145
+
146
+ if the rubric does not apply or the name is fine, OR:
147
+
148
+ ````
149
+ ```json
150
+ {
151
+ "tier": "foundational|polish|aspirational",
152
+ "impact": "small|medium|large",
153
+ "confidence": "high|medium|low",
154
+ "message": "<critique with suggested rename when possible>"
155
+ }
156
+ ```
157
+ ````
158
+
159
+ **Step 3 — `mcp__harness__naming_craft_finalize({ path, runId, responses: [{ promptId, raw }, ...] })`** parses the responses, applies the same validation the inline path uses, and returns the standard `NamingCraftOutput`.
160
+
161
+ If you want the inline behavior (skill calls an LLM directly), pass `mode: 'inline'` to step 1 and set `HARNESS_CRAFT_LLM` to a non-`in-session` provider.
162
+
163
+ ## Success Criteria
164
+
165
+ See `docs/changes/craft-pipeline/naming-craft/proposal.md` for the full 34 success criteria. Highlights:
166
+
167
+ - 6 seed rubrics ship in `catalog/rubrics/<id>.ts` (file-per-rubric matches design-craft pattern)
168
+ - 3-axis output preserved (tier × impact × confidence, never collapsed) per ADR 0019
169
+ - `cite.rubricId` populated on every finding per ADR 0020
170
+ - Convention sampler returns `null` when no dominant convention (>50% threshold)
171
+ - Cross-cutting `critiqueNamesInFile` API exported for future craft skills
172
+ - LlmProvider / MockLlmProvider IMPORTED from design-craft (no duplication)
173
+ - MCP tool count bumps (running total maintained by parallel PRs)
174
+
175
+ ## Examples
176
+
177
+ ### Example: Vague function name
178
+
179
+ **Input:** `src/orders/processor.ts`:
180
+
181
+ ```ts
182
+ export function processData(orders: Order[]) { ... }
183
+ ```
184
+
185
+ **Output (mock LLM):**
186
+
187
+ ```
188
+ NAME-R002 [polish/medium/low] function processData:14
189
+ "processData" is a vague verb-pair where the operation and subject
190
+ are both unstated. Consider `applyDiscountsToOrders` or
191
+ `convertOrdersToInvoices` depending on the actual transform.
192
+ NAME-R001 [polish/medium/medium] function processData:14
193
+ The name predicts neither the input shape (orders) nor the operation.
194
+ ```
195
+
196
+ (Real LLM responses vary; mock provider returns deterministic low-confidence findings for test determinism.)
197
+
198
+ ### Example: Silent unit
199
+
200
+ **Input:**
201
+
202
+ ```ts
203
+ const timeout = 5000;
204
+ ```
205
+
206
+ **Output:**
207
+
208
+ ```
209
+ NAME-R006 [foundational/medium/high] variable timeout:1
210
+ "timeout" implies a time measure but the unit is silent. Use
211
+ `timeoutMs` so the call site can't be misread as seconds.
212
+ ```
213
+
214
+ ### Example: Mixed-convention project — convention sampler returns null
215
+
216
+ **Input:** A project with 60% camelCase, 30% snake_case, 10% PascalCase variables. No >50% camelCase majority (60% IS >50%, so convention=camelCase). But with 45/40/15 split: no convention.
217
+
218
+ **Output:** convention-conformance rubric (NAME-R004) silently skips for the variables kind. Other rubrics still run.
219
+
220
+ ## Gates
221
+
222
+ - **No autofix.** This is ceiling-judgment. v2's `align-naming` may add safe-rename codemods.
223
+ - **No NAMING.md authoring.** v1 derives convention from sampling.
224
+ - **No language support beyond TS/JS.** v1.x.
225
+ - **No modules / branches / commit subjects.** v1.x (and commit subjects go to copy-craft #5).
226
+ - **No graph persistence.** Phase 1 MVP posture (matches design-craft).
227
+ - **No deep/vision mode.** Naming is text-only.
228
+
229
+ ## Escalation
230
+
231
+ - **When LLM cost is too high on a large project:** drop `maxIdentifiersPerFile` to 10 or `maxFiles` to 50. Cost = files × identifiers × rubrics × per-call cost.
232
+ - **When a rubric produces high false-positive rate:** v1 has no per-rubric disable; v1.x adds `craft.naming.disabledRubrics: ['NAME-R005']`. Until then: filter findings by `cite.rubricId` in your consumer.
233
+ - **When the convention sampler misidentifies a mid-migration project:** below 50% threshold returns null and convention rubric skips. Better silent skip than wrong findings. Wait until migration completes; until then disable NAME-R004 in v1.x or filter findings.
234
+ - **When you want naming critique for a single file (e.g. in CI on changed files):** use `--files <glob>` or call `critiqueNamesInFile()` via the cross-cutting API.
235
+ - **When you want module / branch / commit-subject naming today:** manual review. v1.x adds these surfaces.
236
+
237
+ ## Status
238
+
239
+ **v1 — in implementation.** See:
240
+
241
+ - Spec: `docs/changes/craft-pipeline/naming-craft/proposal.md`
242
+ - Roadmap entry: `craft-pipeline sub-project #1` (the first member)
243
+ - Sibling: `harness-design-craft` (design-pipeline #6 — the LLM-judgment template this follows)
244
+ - Future cross-cutters: docs-craft (#2), test-craft (#3), code-craft (#4) will call into naming-craft's `critiqueNamesInFile()` for their domain-specific naming critique.
@@ -0,0 +1,51 @@
1
+ name: naming-craft
2
+ version: "0.1.0"
3
+ description: LLM-judgment skill that critiques identifier names (variables, functions, types, files) against a curated rubric catalog seeded from Martin / Beck / Karlton. First craft-pipeline ceiling skill; cross-cutting (other craft skills call into it for domain-specific naming).
4
+ stability: draft
5
+ cognitive_mode: constructive-architect
6
+ triggers:
7
+ - manual
8
+ - on_pr
9
+ - on_new_feature
10
+ platforms:
11
+ - claude-code
12
+ tools:
13
+ - Bash
14
+ - Read
15
+ - Glob
16
+ - Grep
17
+ cli:
18
+ command: harness naming-craft
19
+ args:
20
+ - name: path
21
+ description: Project root path
22
+ required: false
23
+ - name: files
24
+ description: Optional file/glob scope
25
+ required: false
26
+ - name: kinds
27
+ description: Restrict to variable / function / type / file
28
+ required: false
29
+ mcp:
30
+ tool: naming_craft
31
+ input:
32
+ path: string
33
+ type: rigid
34
+ tier: 2
35
+ phases:
36
+ - name: extract
37
+ description: TS Compiler API walk; gather identifiers + scope metadata + context lines
38
+ required: true
39
+ - name: sample
40
+ description: Derive project naming convention via majority-rule sampling
41
+ required: true
42
+ - name: critique
43
+ description: LLM-rubric loop per (identifier, rubric) pair; emit 3-axis findings
44
+ required: true
45
+ - name: report
46
+ description: Aggregate findings + LLM cost + convention summary
47
+ required: true
48
+ state:
49
+ persistent: false
50
+ depends_on:
51
+ - harness-design-craft