@harborppm/cli 0.93.0 → 0.95.0

package/dist/app.mjs

@@ -2879,9 +2879,10 @@ function tideForecast(project, tasks, now, opts = {}) {
 	};
 	const weekly = weeklyFinished(tasks, project.startDate, now);
 	const finished = weekly.reduce((a, b) => a + b, 0);
-	if (finished === 0) return {
+	if (finished < 3) return {
 		kind: "no-pace",
-		remaining
+		remaining,
+		finished
 	};
 	const today = todayISO(now);
 	const base = noon$3(today);
@@ -2947,11 +2948,11 @@ function tideQuiet(tide) {
 		case "empty": return "No tasks yet, so there's nothing to forecast.";
 		case "done": return "Every task is done.";
 		case "paused": return "Paused, so its pace says nothing about when it ends.";
-		case "no-pace": return `Nothing finished in the last ${6} weeks, so there's no pace to forecast from yet.`;
+		case "no-pace": return tide.finished === 0 ? `Nothing finished in the last ${6} weeks, so there's no pace to forecast from yet.` : `${tide.finished === 1 ? "One task has" : `${tide.finished} tasks have`} finished so far. Dates come once ${3} have, so they rest on a real pace.`;
 		default: return null;
 	}
 }
-var TIDE_WEEKS, TRIALS, MAX_WEEKS, ROUGH_BELOW, noon$3;
+var TIDE_WEEKS, TRIALS, MAX_WEEKS, ROUGH_BELOW, TIDE_MIN_FINISHED, noon$3;
 var init_tide = __esmMin((() => {
 	init_date_fns();
 	init_format();
@@ -2961,6 +2962,7 @@ var init_tide = __esmMin((() => {
 	TRIALS = 1e3;
 	MAX_WEEKS = 104;
 	ROUGH_BELOW = 5;
+	TIDE_MIN_FINISHED = 3;
 	noon$3 = (iso) => /* @__PURE__ */ new Date(`${iso.slice(0, 10)}T12:00:00`);
 }));
 
@@ -5777,7 +5779,7 @@ function matches$1(row, f) {
 	if (f.hideDone && row.health === "done") return false;
 	return true;
 }
-function milestoneOf(m, today) {
+function milestoneOf$1(m, today) {
 	return {
 		id: m.id,
 		name: m.name,
@@ -5816,7 +5818,7 @@ function roadmapRows(data, portfolioId, filter, collapsed, today) {
 			baselineEnd: null,
 			slip: null,
 			waitsOn: blockerIds(program).filter((id) => programIds.has(id)),
-			milestones: data.milestones.filter((m) => m.programId === program.id && !(filter.hideDone && m.done)).sort((a, b) => a.dueDate.localeCompare(b.dueDate)).map((m) => milestoneOf(m, today)),
+			milestones: data.milestones.filter((m) => m.programId === program.id && !(filter.hideDone && m.done)).sort((a, b) => a.dueDate.localeCompare(b.dueDate)).map((m) => milestoneOf$1(m, today)),
 			projectCount: projects.length
 		});
 		if (collapsed.has(program.id)) continue;
@@ -6293,7 +6295,7 @@ function tideLine(data, project, today) {
 	const tasks = tasksOf(data.tasks, project.id);
 	const tide = tideForecast(project, tasks, parseIso(`${today}T12:00:00`), tideOptions(data));
 	if (tide.kind === "no-pace") return {
-		text: "No forecast yet: nothing finished in the last few weeks",
+		text: tide.finished === 0 ? "No forecast yet: nothing finished in the last few weeks" : `No forecast yet: ${tide.finished} finished, dates come at 3`,
 		late: false
 	};
 	if (tide.kind !== "forecast") return null;
@@ -10028,19 +10030,21 @@ function mayChangeMessage(message, personId, role, action) {
 * What a person's Inbox says about project messages since `since`: each
 * message that @mentions them, and for each project they've written in, the
 * messages others posted after their last one (a mention among them is
-* already its own line). Projects that are finished are left out.
+* already its own line). A finished project's replies are left out, but a
+* mention there still reaches you: a wrap-up "thanks @Dana" is meant to.
 */
 function messageLines(data, personId, since) {
 	const done = new Set(data.projects.filter((p) => p.health === "done").map((p) => p.id));
 	const byProject = /* @__PURE__ */ new Map();
 	for (const r of data.reflections ?? []) {
-		if (!isMessage(r) || done.has(r.projectId)) continue;
+		if (!isMessage(r)) continue;
 		const list = byProject.get(r.projectId);
 		if (list) list.push(r);
 		else byProject.set(r.projectId, [r]);
 	}
 	const out = [];
-	for (const list of byProject.values()) {
+	for (const [projectId, list] of byProject) {
+		const finished = done.has(projectId);
 		list.sort((a, b) => a.createdAt.localeCompare(b.createdAt) || a.id.localeCompare(b.id));
 		let joined = false;
 		let replies = [];
@@ -10059,7 +10063,7 @@ function messageLines(data, personId, since) {
 				});
 				continue;
 			}
-			if (joined) replies.push(m);
+			if (joined && !finished) replies.push(m);
 		}
 		const latest = replies.at(-1);
 		if (latest) out.push({
@@ -14117,6 +14121,107 @@ function applyDock(actions, projectId, changes) {
 	return made;
 }
 
+// src/lib/task-milestones.ts
+/** The milestone a task is tied to, or null when it isn't (or the tie no longer holds). */
+function milestoneOf(task, milestones, projects) {
+	if (!task.milestoneId) return null;
+	const m = byId(milestones).get(task.milestoneId);
+	if (!m) return null;
+	const project = byId(projects).get(task.projectId);
+	return project && project.programId === m.programId ? m : null;
+}
+/** For each milestone with tasks tied to it, how many there are and how many are done. One pass. */
+function milestoneProgress(doc) {
+	const out = /* @__PURE__ */ new Map();
+	if (doc.milestones.length === 0) return out;
+	for (const t of doc.tasks) {
+		if (!t.milestoneId) continue;
+		const m = milestoneOf(t, doc.milestones, doc.projects);
+		if (!m) continue;
+		const p = out.get(m.id) ?? {
+			done: 0,
+			total: 0
+		};
+		p.total++;
+		if (t.status === "done") p.done++;
+		out.set(m.id, p);
+	}
+	return out;
+}
+/** Every project it waits on is done (no waits, or a project gone, count as clear). */
+function waitsClear(m, projects) {
+	const index = byId(projects);
+	return blockerIds(m).every((id) => {
+		const p = index.get(id);
+		return !p || p.health === "done";
+	});
+}
+/**
+* The document after a write, with milestones moved by what happened to their
+* tasks: a milestone that lost an open task (finished, deleted, untied or
+* moved away) and now has all its tasks done is reached; a reached one that
+* gained an open task (reopened, tied, added or moved in) is open again. The
+* same document back when nothing moved. Only tasks this write changed are
+* looked at, then one pass counts the milestones they touch.
+*/
+function followMilestones(before, after) {
+	if (after.tasks === before.tasks || after.milestones.length === 0) return after;
+	const was = byId(before.tasks);
+	const tie = (t, doc) => milestoneOf(t, doc.milestones, doc.projects)?.id ?? null;
+	const lost = /* @__PURE__ */ new Set();
+	const gained = /* @__PURE__ */ new Set();
+	const seen = /* @__PURE__ */ new Set();
+	for (const t of after.tasks) {
+		const old = was.get(t.id);
+		if (old) seen.add(t.id);
+		if (old === t) continue;
+		const from = old ? tie(old, before) : null;
+		const to = tie(t, after);
+		const wasOpen = old ? old.status !== "done" : false;
+		const isOpen = t.status !== "done";
+		if (from && wasOpen && (from !== to || !isOpen)) lost.add(from);
+		if (to && isOpen && (from !== to || !wasOpen)) gained.add(to);
+	}
+	if (seen.size < before.tasks.length) for (const old of before.tasks) {
+		if (seen.has(old.id) || old.status === "done") continue;
+		const from = tie(old, before);
+		if (from) lost.add(from);
+	}
+	if (lost.size === 0 && gained.size === 0) return after;
+	const progress = milestoneProgress(after);
+	let changed = false;
+	const milestones = after.milestones.map((m) => {
+		if (!follows(m)) return m;
+		const p = progress.get(m.id);
+		if (!m.done && lost.has(m.id) && p && p.total > 0 && p.done === p.total) {
+			if (!waitsClear(m, after.projects)) return m;
+			changed = true;
+			return {
+				...m,
+				done: true
+			};
+		}
+		if (m.done && gained.has(m.id)) {
+			changed = true;
+			return {
+				...m,
+				done: false
+			};
+		}
+		return m;
+	});
+	return changed ? {
+		...after,
+		milestones
+	} : after;
+}
+var follows;
+var init_task_milestones = __esmMin((() => {
+	init_blockers();
+	init_indexes();
+	follows = (m) => !m.approverId;
+}));
+
 // src/lib/time-limits.ts
 var MAX_ENTRY_MINUTES;
 var init_time_limits = __esmMin((() => {
@@ -14124,6 +14229,7 @@ var init_time_limits = __esmMin((() => {
 }));
 
 // src/lib/time-log.ts
+init_task_milestones();
 /** "1h 30m", "45m", "12h". */
 function formatMinutes(total) {
 	const n = Math.max(0, Math.round(total));
@@ -21943,7 +22049,7 @@ const HARBOR_TOOLS = [
 	tool({
 		name: "get_task",
 		title: "Task details",
-		description: "One task: its owner (assignee) and anyone also on it (alsoOn), notes, checklist, its files, what it waits on, what waits on it, its latest comments, the earliest due date its owner's queue suggests (pilotDue: fits says whether the due date holds; absent with no owner, an agent owner, or once done), its place in its board column (`position`, from 1 at the top), time logged on it (timeLogged: the total and the latest entries, when there is any), its values for the project's own fields by name (fields, when it has any; set them with set_field), its subtasks or the task it's a subtask of (subtaskOf), and its url on the website." + DATA_NOTE,
+		description: "One task: its owner (assignee) and anyone also on it (alsoOn), notes, checklist, its files, what it waits on, what waits on it, its latest comments, the earliest due date its owner's queue suggests (pilotDue: fits says whether the due date holds; absent with no owner, an agent owner, or once done), its place in its board column (`position`, from 1 at the top), time logged on it (timeLogged: the total and the latest entries, when there is any), its values for the project's own fields by name (fields, when it has any; set them with set_field), its subtasks or the task it's a subtask of (subtaskOf), the milestone it's tied to (milestone: its due day, whether it's reached, and how many of its tasks are done of all tied to it), and its url on the website." + DATA_NOTE,
 		input: object({
 			harbor: harborArg,
 			task: string().min(1).max(100).describe("Task id or key (\"RR-42\"), from search_tasks or my_work.")
@@ -21997,6 +22103,12 @@ const HARBOR_TOOLS = [
 				waitingOn: blockersOf(t, data.tasks).map(brief),
 				waitedOnBy: waiters.map(brief),
 				...((parent) => parent ? { subtaskOf: brief(parent) } : {})(parentOf(t, data.tasks)),
+				...((m) => m ? { milestone: {
+					name: m.name,
+					due: dayOf(m.dueDate),
+					reached: m.done,
+					...milestoneProgress(data).get(m.id)
+				} } : {})(milestoneOf(t, data.milestones, data.projects)),
 				...((subs) => subs.length ? { subtasks: subs.map((x) => ({
 					...brief(x),
 					assignee: nameOf$2(people, x.assigneeId),
@@ -24507,6 +24619,7 @@ function nextOccurrence(task, id, today, createdAt, siblings = []) {
 		id,
 		status: "todo",
 		dueDate,
+		milestoneId: null,
 		...task.startDate ? { startDate: lead != null && lead >= 0 ? format(addDays(/* @__PURE__ */ new Date(`${dueDate}T12:00:00`), -lead), "yyyy-MM-dd") : null } : {},
 		createdAt,
 		completedAt: null,
@@ -25958,10 +26071,10 @@ function createAppStore(onNotice = () => {}) {
 		};
 		const write = (partial) => {
 			const before = get();
-			guardedSet((s) => stampHealth(numberNewTasks(s, {
+			guardedSet((s) => stampHealth(followMilestones(s, numberNewTasks(s, {
 				...s,
 				...partial
-			})));
+			}))));
 			undo = nextStep(undo, before, get(), Date.now());
 		};
 		const api = {
@@ -26027,6 +26140,7 @@ var init_store = __esmMin((() => {
 	init_vanilla();
 	init_derived_health();
 	init_task_keys();
+	init_task_milestones();
 	init_payload();
 	init_undo();
 	init_view_only();
@@ -31307,6 +31421,7 @@ init_recurrence();
 init_task_people();
 init_search();
 init_swatches();
+init_task_milestones();
 const FIELDS = [
 	{
 		field: "title",
@@ -31356,6 +31471,7 @@ function TaskPanel({ taskId, width, height, go, active = true, onClose }) {
 	const { store, today } = useDeps();
 	const tasks = useHarbor((s) => s.tasks);
 	const projects = useHarbor((s) => s.projects);
+	const milestones = useHarbor((s) => s.milestones);
 	const people = useHarbor((s) => s.people);
 	const comments = useHarbor((s) => s.comments);
 	const reflections = useHarbor((s) => s.reflections);
@@ -31422,6 +31538,12 @@ function TaskPanel({ taskId, width, height, go, active = true, onClose }) {
 	const mine = comments.filter((c) => c.taskId === task.id && c.authorId === me);
 	const blockers = blockersOf(task, tasks);
 	const subtaskOf = parentOf(task, tasks);
+	const milestone = milestoneOf(task, milestones, projects);
+	const toward = milestone ? milestoneProgress({
+		tasks,
+		milestones,
+		projects
+	}).get(milestone.id) : void 0;
 	const subs = subtasksOf(task, tasks);
 	const done = () => setEditing(null);
 	const nameOf = (id) => people.find((p) => p.id === id)?.name;
@@ -31786,6 +31908,20 @@ function TaskPanel({ taskId, width, height, go, active = true, onClose }) {
 					subtaskOf.title
 				]
 			}) : null,
+			milestone ? /* @__PURE__ */ jsxs(Text, {
+				color: theme.muted,
+				wrap: "truncate-end",
+				children: [
+					"  ",
+					"Toward ",
+					milestone.name,
+					" (",
+					milestone.dueDate.slice(0, 10),
+					"):",
+					" ",
+					milestone.done ? "reached" : `${toward?.done ?? 0}/${toward?.total ?? 0} of its tasks done`
+				]
+			}) : null,
 			subs.length > 0 ? /* @__PURE__ */ jsxs(Text, {
 				color: theme.muted,
 				children: [

package/lib/cli.mjs

@@ -170,6 +170,7 @@ export const HELP = `harbor: Harbor from the terminal
                      [--priority low|medium|high|urgent]
                      [--status S] [--comment TEXT] [--over-limit] [--dry-run]
                      [--literal] [--template NAME] [--parent TASK]
+                     [--milestone NAME]
                                               reads plain words in TITLE as the
                                               website does: @name, by friday,
                                               !high, #project (--literal: keep
@@ -186,7 +187,7 @@ export const HELP = `harbor: Harbor from the terminal
                    [--priority P] [--status S] [--notes TEXT]
                    [--repeat weekly|biweekly|monthly|never]
                    [--waits-on TASK,TASK|none] [--parent TASK|none]
-                   [--confirm] [--over-limit]
+                   [--milestone NAME|none] [--confirm] [--over-limit]
   harbor limit PROJECT [COLUMN N|none]        how many tasks a board column
                                               takes at once; the owner sets it
   harbor week [--next|--last|--week DATE] [--review]
@@ -710,7 +711,7 @@ export function hint(message, project) {
     )
     .replace(
       /^Nothing to change: pass a field to update\.$/,
-      "Nothing to change. Say what with --title, --assignee, --also, --due, --starts, --priority, --status, --notes, --repeat, --waits-on or --parent.",
+      "Nothing to change. Say what with --title, --assignee, --also, --due, --starts, --priority, --status, --notes, --repeat, --waits-on, --parent or --milestone.",
     )
     .replace(
       /^This connection was allowed to read only\..*$/s,
@@ -795,6 +796,11 @@ const DETAIL = {
     "  own owner and date, shown in the parent's details rather than on the",
     "  board. It goes in the parent's project; subtasks go one level deep.",
     "",
+    "  --milestone NAME ties it to one of the program's milestones: the milestone",
+    "  is reached once its tasks are done, and opens again when one reopens. The",
+    "  project's timeline shows each milestone under its tasks. harbor edit TASK",
+    "  --milestone NAME|none changes or clears it.",
+    "",
     "  --starts DATE gives it a start day as well as a due day, so the project's",
     "  timeline draws it as a bar from one to the other; a start after the due",
     "  day comes to the due day. harbor edit TASK --starts DATE|none moves it.",
@@ -2312,6 +2318,10 @@ export async function run(argv, io = {}) {
         if (t.alsoOn?.length) lines.push(`Also on it: ${t.alsoOn.join(", ")}.`);
         if (t.starts) lines.push(`Starts ${t.starts}${t.due ? `, due ${t.due}` : ""}.`);
         if (t.subtaskOf) lines.push(`Subtask of ${t.subtaskOf.key ?? t.subtaskOf.id}  ${t.subtaskOf.title}.`);
+        if (t.milestone)
+          lines.push(
+            `Toward the milestone ${t.milestone.name} (${t.milestone.due}): ${t.milestone.reached ? "reached" : `${t.milestone.done} of ${t.milestone.total} of its tasks done`}.`,
+          );
         if (t.repeats) lines.push(`Repeats ${REPEAT_WORD[t.repeats] ?? t.repeats}.`);
         for (const [name, v] of Object.entries(t.fields ?? {}))
           lines.push(`${name}: ${Array.isArray(v) ? v.join(", ") : v === true ? "yes" : v}`);
@@ -2564,7 +2574,7 @@ export async function run(argv, io = {}) {
       const { positionals, values, harbor } = parse(
         spec(
           ["over-limit", "dry-run", "literal"],
-          ["project", "assignee", "also", "due", "starts", "priority", "status", "comment", "template", "parent"],
+          ["project", "assignee", "also", "due", "starts", "priority", "status", "comment", "template", "parent", "milestone"],
         ),
       );
       // A subtask goes in its parent's project.
@@ -2674,6 +2684,7 @@ export async function run(argv, io = {}) {
             priority: values.priority ?? words.priority?.value,
             status: values.status === undefined ? undefined : statusWord(values.status),
             parent: values.parent,
+            milestone: values.milestone,
             overLimit: values["over-limit"] || undefined,
           })
           .catch((err) => {
@@ -2712,6 +2723,8 @@ export async function run(argv, io = {}) {
                   ...(dueWords(values.due) ? [`--due ${values.due}: ${dayWithWeekday(dueDate(values.due))}.`] : []),
                   // Pilot speaks up only when a date was given that the queue says won't hold.
                   ...(values.due ? pilotLines(r, r.created) : []),
+                  ...(r.created.milestone ? [`Toward the milestone ${r.created.milestone}.`] : []),
+                  ...(r.milestoneReopened ? [`${r.milestoneReopened} is open again: it has an open task now.`] : []),
                 ].join("\n"),
               )
               .join("\n"),
@@ -2777,6 +2790,8 @@ export async function run(argv, io = {}) {
           [
             `${r.updated.title}: ${r.reopened ? "reopened, " : ""}${{ doing: "started", review: "in review", done: "done" }[status]}.`,
             r.queuedNext ? `Next one: ${taskLine(r.queuedNext, opts)}` : "",
+            r.milestoneReached ? `That was the last of its tasks: ${r.milestoneReached} is reached.` : "",
+            r.milestoneReopened ? `${r.milestoneReopened} is open again: one of its tasks is open.` : "",
             r.projectFinished
               ? `That was the last open task in ${r.projectFinished}. Mark the project Done in the app (harbor) or on the website.`
               : "",
@@ -2801,6 +2816,7 @@ export async function run(argv, io = {}) {
             "repeat",
             "waits-on",
             "parent",
+            "milestone",
           ],
         ),
       );
@@ -2833,6 +2849,7 @@ export async function run(argv, io = {}) {
                     .map((x) => x.trim())
                     .filter(Boolean),
           parent: values.parent,
+          milestone: values.milestone,
           confirmed: values.confirm || undefined,
           overLimit: values["over-limit"] || undefined,
         },
@@ -2849,6 +2866,13 @@ export async function run(argv, io = {}) {
                 ? `A subtask of ${r.updated.subtaskOf}.`
                 : "A task of its own now."
               : null,
+            values.milestone !== undefined
+              ? r.updated.milestone
+                ? `Toward the milestone ${r.updated.milestone}.`
+                : "Not tied to a milestone now."
+              : null,
+            r.milestoneReached ? `That was the last of its tasks: ${r.milestoneReached} is reached.` : null,
+            r.milestoneReopened ? `${r.milestoneReopened} is open again: one of its tasks is open.` : null,
             values.also !== undefined
               ? r.updated.alsoOn?.length
                 ? `Also on it: ${r.updated.alsoOn.join(", ")}.`

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@harborppm/cli",
-  "version": "0.93.0",
+  "version": "0.95.0",
   "description": "Harbor from the terminal: a full-screen app with everything, plus commands for scripts and agents.",
   "keywords": [
     "harbor",