@harborppm/cli 0.81.0 → 0.82.0

package/dist/app.mjs

@@ -10009,6 +10009,39 @@ function inboxOf(data, personId, now = clockNow()) {
 			href: `/projects/${task.projectId}`
 		});
 	}
+	for (const task of data.tasks) {
+		const a = task.approval;
+		if (!a) continue;
+		const project = projectOf(data, task);
+		const where = `“${task.title}”${project ? ` · ${project.name}` : ""}`;
+		if (a.approverId === personId && a.askedById !== personId && a.status === "pending" && task.status !== "done") {
+			const by = data.people.find((p) => p.id === a.askedById);
+			pings.push({
+				id: `task-approve:${task.id}:${shortHash(a.askedAt)}`,
+				kind: "approval",
+				title: `${by ? firstName$3(by.name) : "Someone"} asked for your approval`,
+				detail: `${where} · approve it, or ask for changes`,
+				at: a.askedAt,
+				taskId: task.id,
+				personId: a.askedById,
+				href: `/projects/${task.projectId}`
+			});
+		} else if (a.askedById === personId && a.approverId !== personId && a.status !== "pending" && a.decidedAt && a.decidedAt >= since) {
+			const who = data.people.find((p) => p.id === a.approverId);
+			const name = who ? firstName$3(who.name) : "The approver";
+			const note = (a.note ?? "").trim();
+			pings.push({
+				id: `task-decided:${task.id}:${shortHash(a.decidedAt)}`,
+				kind: "approval",
+				title: a.status === "approved" ? `${name} approved “${task.title}”` : `${name} asked for changes to “${task.title}”`,
+				detail: note ? excerpt(note) : project?.name ?? "",
+				at: a.decidedAt,
+				taskId: task.id,
+				personId: a.approverId,
+				href: `/projects/${task.projectId}`
+			});
+		}
+	}
 	for (const comment of mentionsFor(data.comments, personId)) {
 		const task = data.tasks.find((t) => t.id === comment.taskId);
 		if (!task || task.status === "done") continue;
@@ -20237,6 +20270,17 @@ var init_fog = __esmMin((() => {
 	fileCache = /* @__PURE__ */ new WeakMap();
 }));
 
+// src/lib/task-approval.ts
+init_fog();
+/** Waits on its approver now: asked, not yet answered, and not done. */
+function awaitingApproval(task) {
+	return Boolean(task?.approval && task.approval.status === "pending" && task.status !== "done");
+}
+/** Open tasks waiting on this person's approval, oldest ask first. */
+function approvalsWaitingOn(tasks, personId) {
+	return tasks.filter((t) => awaitingApproval(t) && t.approval.approverId === personId).sort((a, b) => a.approval.askedAt.localeCompare(b.approval.askedAt));
+}
+
 // src/lib/mcp/tools.ts
 /**
 * What an agent can read about a harbor, as MCP tools. Each tool is a pure
@@ -20272,7 +20316,6 @@ init_handover();
 init_agents();
 init_work();
 init_task_people();
-init_fog();
 init_passage();
 init_board();
 init_holidays();
@@ -20518,6 +20561,18 @@ function soundingOut(data, t, meId, now) {
 	};
 }
 const dayOf = (iso) => iso ? iso.slice(0, 10) : null;
+/** A task's approval (src/lib/task-approval.ts), as an agent reads it. */
+function approvalOut(data, a) {
+	const people = byId(data.people);
+	return {
+		approver: nameOf$2(people, a.approverId) ?? "someone no longer here",
+		askedBy: nameOf$2(people, a.askedById) ?? "someone no longer here",
+		asked: dayOf(a.askedAt),
+		status: a.status === "changes_requested" ? "changes requested" : a.status,
+		...a.note ? { note: a.note } : {},
+		...a.decidedAt ? { decided: dayOf(a.decidedAt) } : {}
+	};
+}
 function overdue(t, today) {
 	const due = dayOf(t.dueDate);
 	return isOpen(t) && due != null && due < today;
@@ -21043,6 +21098,7 @@ const HARBOR_TOOLS = [
 				waitingOn: blockersOf(t, data.tasks).map(brief),
 				waitedOnBy: waiters.map(brief),
 				...t.sounding ? { sounding: soundingOut(data, t, me(ctx)?.id ?? null, ctx.now) } : {},
+				...t.approval ? { approval: approvalOut(data, t.approval) } : {},
 				...pilot ? { pilotDue: {
 					earliest: pilot.earliest,
 					fits: pilot.fits,
@@ -21096,7 +21152,7 @@ const HARBOR_TOOLS = [
 	tool({
 		name: "my_work",
 		title: "My work",
-		description: "What's yours in a harbor: your open tasks (late first), open tasks others own that you're also on (alsoOn), what others are waiting on you for, and the risks you own." + DATA_NOTE,
+		description: "What's yours in a harbor: your open tasks (late first), open tasks others own that you're also on (alsoOn), what others are waiting on you for, the risks you own, and tasks waiting on your approval (approvalsToGive; answer with decide_approval)." + DATA_NOTE,
 		input: object({
 			harbor: harborArg,
 			limit: limitArg(50, 25)
@@ -21143,6 +21199,13 @@ const HARBOR_TOOLS = [
 					...taskKey(t, projects.get(t.projectId)) ? { key: taskKey(t, projects.get(t.projectId)) } : {},
 					title: t.title,
 					askedBy: nameOf$2(people, t.sounding.askedById)
+				})),
+				approvalsToGive: approvalsWaitingOn(data.tasks, mine.id).map((t) => ({
+					id: t.id,
+					...taskKey(t, projects.get(t.projectId)) ? { key: taskKey(t, projects.get(t.projectId)) } : {},
+					title: t.title,
+					askedBy: nameOf$2(people, t.approval.askedById),
+					asked: dayOf(t.approval.askedAt)
 				}))
 			};
 		}

package/lib/cli.mjs

@@ -41,6 +41,7 @@ import {
   soundingsText,
   goalsText,
   templatesText,
+  approvalsText,
   thanksText,
   ashoreText,
   voyageText,
@@ -268,6 +269,10 @@ export const HELP = `harbor: Harbor from the terminal
                                               start from (harbor add --template)
   harbor template TASK [--name NAME]          save a task as a template in its
                                               project
+  harbor approve TASK [--ask NAME|--changes NOTE] [--note TEXT]
+                                              approve a task (finishes it), send
+                                              it back, or ask someone to approve
+  harbor approvals                            tasks waiting on your approval
   harbor ashore [--weeks N] [--country CODES|none] [--person NAME]
                                               public holidays and time away
                                               coming up, and whose holidays
@@ -1046,6 +1051,22 @@ const DETAIL = {
     "  harbor add --project P --template NAME starts a task from one: its title,",
     "  notes, priority, owner, others on it, checklist and due offset.",
   ],
+  approve: [
+    "  harbor approve TASK                    writes: approves a task you were asked",
+    "                                         to approve, which finishes it",
+    '  harbor approve TASK --changes "NOTE"   writes: sends it back, saying what',
+    "                                         should change",
+    "  harbor approve TASK --ask NAME         writes: asks someone to approve it",
+    "                                         (again, after changes)",
+    "  harbor approvals                       reads: tasks waiting on your approval",
+    "",
+    "  --note TEXT adds a word to an approval. Whoever asked hears the answer.",
+  ],
+  approvals: [
+    "  harbor approvals                       reads: tasks waiting on your approval,",
+    "                                         oldest ask first",
+    "  harbor approve TASK [--changes NOTE]   writes: approve it or send it back",
+  ],
   goals: [
     "  harbor goals [PORTFOLIO]               reads: each portfolio's goals (all when",
     "                                         left out), off track first, with how far",
@@ -3216,6 +3237,43 @@ export async function run(argv, io = {}) {
         soundingsText(r),
       );
     }
+    case "approve": {
+      const { positionals, values, harbor } = parse(spec([], ["ask", "changes", "note"]));
+      const task = positionals[0];
+      if (!task) throw new HarborError("Give a task's key, like harbor approve RR-4.");
+      if (positionals.length > 1)
+        throw new HarborError(`Unexpected "${positionals.slice(1).join(" ")}".`);
+      if (values.ask !== undefined && values.changes !== undefined)
+        throw new HarborError("Ask or send back: one at a time.");
+      const said = (r) => {
+        const a = r.approval ?? {};
+        const name = r.key ?? r.title;
+        if (a.status === "pending") return `Asked ${a.approver} to approve ${name}.`;
+        if (a.status === "approved")
+          return `Approved ${name}. It's done${a.askedBy ? `, and ${a.askedBy} will hear` : ""}.`;
+        return `Sent ${name} back to ${a.askedBy}: “${a.note}”.`;
+      };
+      if (values.ask !== undefined)
+        return call("ask_approval", { harbor, task, approver: values.ask }, (r) => said(r.asked));
+      const changes = values.changes !== undefined;
+      if (changes && !values.changes.trim())
+        throw new HarborError('Say what should change: harbor approve TASK --changes "NOTE".');
+      return call(
+        "decide_approval",
+        {
+          harbor,
+          task,
+          decision: changes ? "changes" : "approve",
+          ...(changes ? { note: values.changes } : values.note ? { note: values.note } : {}),
+        },
+        (r) => said(r.decided),
+      );
+    }
+    case "approvals": {
+      const { positionals, harbor } = parse(spec());
+      if (positionals.length) throw new HarborError(`Unexpected "${positionals.join(" ")}".`);
+      return call("my_work", { harbor, limit: 1 }, (r) => approvalsText(r));
+    }
     case "templates": {
       const { positionals, harbor } = parse(spec());
       const project = positionals.join(" ").trim();

package/lib/format.mjs

@@ -1255,6 +1255,16 @@ export function templatesText(r) {
   return lines.join("\n");
 }
 
+export function approvalsText(r) {
+  const list = r.approvalsToGive ?? [];
+  if (!list.length) return "Nothing is waiting on your approval.";
+  const lines = [`Waiting on your approval (${list.length}):`];
+  for (const t of list)
+    lines.push(`  ${t.key ?? t.id}  ${t.title}  (asked by ${t.askedBy ?? "someone"}${t.asked ? `, ${t.asked}` : ""})`);
+  lines.push("", "harbor approve TASK approves one; --changes \"NOTE\" sends it back.");
+  return lines.join("\n");
+}
+
 export function goalsText(r) {
   const order = ["off-track", "at-risk", "not-started", "on-track", "achieved"];
   const withGoals = (r.portfolios ?? []).filter((p) => p.goals?.length);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@harborppm/cli",
-  "version": "0.81.0",
+  "version": "0.82.0",
   "description": "Harbor from the terminal: a full-screen app with everything, plus commands for scripts and agents.",
   "keywords": [
     "harbor",