@harborppm/cli 0.44.0 → 0.45.0

package/lib/cli.mjs

@@ -115,7 +115,9 @@ export const HELP = `harbor: Harbor from the terminal
   harbor add "TITLE" --project P [--assignee me|none|NAME] [--due DATE]
                      [--priority low|medium|high|urgent] [--status S]
                      [--over-limit]
-  harbor start TASK | review TASK | done TASK [--confirm] [--over-limit]
+  harbor start TASK | submit TASK | done TASK [--confirm] [--over-limit]
+                                              move a task to In play, In review
+                                              or Done
   harbor edit TASK [--title T] [--assignee me|none|NAME] [--due DATE|none]
                    [--priority P] [--status S] [--notes TEXT]
                    [--repeat weekly|biweekly|monthly|never]
@@ -139,9 +141,10 @@ export const HELP = `harbor: Harbor from the terminal
                      [--notes T]
                                               one risk, issue or decision in
                                               full, or change it
-  harbor review [--mine|--owner NAME] [--portfolio P] [--done]
+  harbor review [WORDS] [--mine|--owner NAME] [--portfolio P] [--done]
                                               the review: programs worst first,
-                                              each with its next move
+                                              each with its next move (reads
+                                              only; harbor submit moves a task)
   harbor next-move PROGRAM "TEXT"             write a program's next move
   harbor health --program P|--project P|--portfolio P STATE [--note WHY]
                                               set its health by hand, or auto
@@ -658,8 +661,10 @@ const DETAIL = {
     "                                         project in or hold a task in",
     "  harbor review --owner NAME             the same for someone else",
     "  harbor review --portfolio P            one portfolio's",
-    "  harbor review TASK                     writes: moves a task to In review",
+    '  harbor review "WORDS"                  only programs whose name has them',
     "",
+    "  The review only reads. To move a task to In review, run harbor submit",
+    "  TASK (harbor review TASK did that before 0.45.0, and now says so).",
     '  Write a next move with harbor next-move PROGRAM "TEXT"; set a health by',
     "  hand with harbor health. harbor export review prints it as CSV.",
   ],
@@ -789,6 +794,13 @@ async function harborNamed(client, key) {
 
 const TASK_KEY = /^[A-Za-z][A-Za-z0-9]{0,9}-\d+$/;
 
+/** True when every word of `words` is somewhere in `name`, any case. */
+const nameHas = (name, words) =>
+  words
+    .toLowerCase()
+    .split(/\s+/)
+    .every((w) => name.toLowerCase().includes(w));
+
 /**
  * A task by its key, else a project by name, else a task by id: its web
  * link and what to call it. Harbor's own refusal when nothing matches.
@@ -919,6 +931,7 @@ export async function run(argv, io = {}) {
         await writeCredentials({ ...now, harbor: h.id, harborName: h.name }, env);
       },
       theme: (await readSettings(env)).theme,
+      browse: io.browse ?? openBrowser,
     });
     return 0;
   }
@@ -1581,6 +1594,7 @@ export async function run(argv, io = {}) {
       );
     }
     case "start":
+    case "submit":
     case "review":
     case "done": {
       const { positionals, values, harbor } = parse(
@@ -1588,7 +1602,17 @@ export async function run(argv, io = {}) {
           ? spec(["confirm", "over-limit", "mine", "done"], ["owner", "portfolio"])
           : spec(["confirm", "over-limit"]),
       );
-      if (command === "review" && positionals.length === 0) {
+      if (command === "review") {
+        // The review only reads: a task key here once moved the task, so it says where that went.
+        const words = positionals.join(" ").trim();
+        if (TASK_KEY.test(words)) {
+          throw new HarborError(
+            `harbor review only reads the review now. To move ${words} to In review, run harbor submit ${words}.`,
+          );
+        }
+        if (values.confirm || values["over-limit"]) {
+          throw new HarborError("--confirm and --over-limit are for moving a task: harbor submit TASK.");
+        }
         if (values.mine && values.owner) throw new HarborError("Say --mine or --owner, not both.");
         return call(
           "program_review",
@@ -1598,15 +1622,14 @@ export async function run(argv, io = {}) {
             portfolio: values.portfolio,
             includeDone: Boolean(values.done),
           },
-          reviewList,
-        );
-      }
-      if (values.mine || values.done || values.owner || values.portfolio) {
-        throw new HarborError(
-          "--mine, --owner, --portfolio and --done are for the review: harbor review on its own.",
+          (r) =>
+            words && r.programs.length === 0
+              ? `No program in the review matches "${words}".`
+              : reviewList(r),
+          (r) => (words ? { ...r, programs: r.programs.filter((p) => nameHas(p.name, words)) } : r),
         );
       }
-      const status = { start: "doing", review: "review", done: "done" }[command];
+      const status = { start: "doing", submit: "review", done: "done" }[command];
       return call(
         "update_task",
         {
@@ -2005,7 +2028,8 @@ export async function run(argv, io = {}) {
         ([k, v]) => !["harbor", "item"].includes(k) && v !== undefined,
       );
       if (!changes.length) {
-        return call("get_raid", { harbor, item }, (r) => raidDetail(r.item));
+        // --json gives the item itself, as harbor show does a task.
+        return call("get_raid", { harbor, item }, raidDetail, (r) => r.item ?? r);
       }
       return call("update_raid", args, (r) => `Updated.\n\n${raidDetail(r.updated)}`);
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@harborppm/cli",
-  "version": "0.44.0",
+  "version": "0.45.0",
   "description": "Harbor from the terminal: a full-screen app with everything, plus commands for scripts and agents.",
   "keywords": [
     "harbor",