@happyvertical/smrt-ui 0.51.39 → 0.52.0

package/dist/components/forms/__tests__/StagedControlReview.test.js

@@ -3,6 +3,7 @@ import userEvent from '@testing-library/user-event';
 import { describe, expect, it, vi } from 'vitest';
 import { expectNoA11yViolations } from '../../../test-support/a11y';
 import { createControlInteractionRegistry, executeLocalControlBatch, executeLocalControlCommand, } from '../control-interaction.js';
+import StagedControlReview from '../StagedControlReview.svelte';
 import CompositeUserEditFixture from './composite-user-edit.fixture.svelte';
 import SelectFixture from './select-interaction.fixture.svelte';
 import Fixture from './staged-review.fixture.svelte';
@@ -77,7 +78,8 @@ describe('StagedControlReview', () => {
         await waitFor(() => expect(field).toHaveAttribute('data-smrt-staged', 'true'));
         expect(screen.getByRole('region', { name: 'Review proposed changes' })).toBeInTheDocument();
         expect(screen.getByText(/Proposed by assistant/)).toBeInTheDocument();
-        expect(screen.getByText('profile/display-name')).toBeInTheDocument();
+        // Plain field labels only: registry addressing never shows (#forms-qa).
+        expect(screen.queryByText(/profile\/display-name/)).not.toBeInTheDocument();
         const proposal = screen.getByRole('textbox', {
             name: 'Edit proposed value for Display name',
         });
@@ -93,6 +95,38 @@ describe('StagedControlReview', () => {
         expect(field).toHaveFocus();
         await expectNoA11yViolations(container);
     });
+    it('shows plain field labels, never registry ids, for unlabeled controls', async () => {
+        const registry = createReviewRegistry();
+        let town = '';
+        registry.register({
+            identity: {
+                formId: 'setup-network',
+                controlId: 'setup-network/town_name',
+                subject: { type: 'site', id: 'site-1', label: 'Lacombe News' },
+            },
+            metadata: { kind: 'text' },
+            getValue: () => town,
+            setValue: (next) => {
+                town = String(next);
+            },
+        });
+        render(StagedControlReview, {
+            props: { registry, formId: 'setup-network' },
+        });
+        await registry.execute({
+            action: 'stage',
+            identity: {
+                formId: 'setup-network',
+                controlId: 'setup-network/town_name',
+                subject: { type: 'site', id: 'site-1' },
+            },
+            value: 'Lacombe',
+        }, { source: 'agent' });
+        await waitFor(() => expect(screen.getByText('Town name')).toBeVisible());
+        expect(screen.getByText('Lacombe News')).toBeVisible();
+        expect(screen.queryByText(/setup-network/)).not.toBeInTheDocument();
+        expect(screen.queryByText(/site-1/)).not.toBeInTheDocument();
+    });
     it('keeps Enter in the proposal editor from submitting the form', async () => {
         const registry = createReviewRegistry();
         render(Fixture, { props: { registry } });
@@ -594,8 +628,8 @@ describe('StagedControlReview', () => {
             value: 'Grace',
         }, { source: 'agent' });
         await waitFor(() => expect(renderedFirst).toHaveAttribute('data-smrt-staged', 'true'));
-        expect(screen.getByText('profile/display-name · record:one')).toBeVisible();
-        expect(screen.getByText('profile/display-name · record:two')).toBeVisible();
+        expect(screen.queryByText(/profile\/display-name/)).not.toBeInTheDocument();
+        expect(screen.queryByText(/record:one/)).not.toBeInTheDocument();
         for (const subjectId of ['one', 'two']) {
             const actionName = `Display name record:${subjectId} [identity:["profile","display-name","record","${subjectId}"]]`;
             expect(screen.getByRole('textbox', {

package/dist/components/forms/__tests__/combobox-labels.fixture.svelte

@@ -0,0 +1,19 @@
+<script lang="ts">
+import Combobox from '../Combobox.svelte';
+import type { ControlOption } from '../control-interaction.js';
+
+let {
+  options = [],
+  value = $bindable(''),
+  valueLabel = undefined,
+  required = false,
+}: {
+  options?: ControlOption[];
+  value?: string;
+  valueLabel?: string;
+  required?: boolean;
+} = $props();
+</script>
+
+<Combobox label="Town" name="town" {options} {valueLabel} {required} bind:value />
+<p data-testid="value">{value}</p>

package/dist/components/forms/__tests__/combobox-labels.fixture.svelte.d.ts

@@ -0,0 +1,11 @@
+import type { ControlOption } from '../control-interaction.js';
+type $$ComponentProps = {
+    options?: ControlOption[];
+    value?: string;
+    valueLabel?: string;
+    required?: boolean;
+};
+declare const ComboboxLabels: import("svelte").Component<$$ComponentProps, {}, "value">;
+type ComboboxLabels = ReturnType<typeof ComboboxLabels>;
+export default ComboboxLabels;
+//# sourceMappingURL=combobox-labels.fixture.svelte.d.ts.map

package/dist/components/forms/__tests__/combobox-labels.fixture.svelte.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"combobox-labels.fixture.svelte.d.ts","sourceRoot":"","sources":["../../../../src/components/forms/__tests__/combobox-labels.fixture.svelte.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,2BAA2B,CAAC;AAE9D,KAAK,gBAAgB,GAAI;IACxB,OAAO,CAAC,EAAE,aAAa,EAAE,CAAC;IAC1B,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,QAAQ,CAAC,EAAE,OAAO,CAAC;CACpB,CAAC;AAkBF,QAAA,MAAM,cAAc,2DAAwC,CAAC;AAC7D,KAAK,cAAc,GAAG,UAAU,CAAC,OAAO,cAAc,CAAC,CAAC;AACxD,eAAe,cAAc,CAAC"}

package/dist/components/forms/__tests__/composite-registration.fixture.svelte

@@ -0,0 +1,29 @@
+<script lang="ts">
+import type { ControlInteractionRegistry } from '../control-interaction.js';
+import Form from '../Form.svelte';
+import FormGroup from '../FormGroup.svelte';
+import Input from '../Input.svelte';
+import PlacePicker from './place-picker.fixture.svelte';
+
+interface Props {
+  registry: ControlInteractionRegistry;
+}
+let { registry }: Props = $props();
+let name = $state('');
+let place = $state<{
+  name: string;
+  latitude: number;
+  longitude: number;
+} | null>(null);
+</script>
+
+<Form formId="new-site" interactionRegistry={registry} aria-label="New site">
+  <FormGroup label="Site name" id="site-name">
+    <Input name="name" bind:value={name} />
+  </FormGroup>
+  <PlacePicker bind:value={place} />
+  <FormGroup label="Password" id="site-password">
+    <Input name="password" type="password" value="" />
+  </FormGroup>
+</Form>
+<p data-testid="place">{place ? place.name : 'none'}</p>

package/dist/components/forms/__tests__/composite-registration.fixture.svelte.d.ts

@@ -0,0 +1,8 @@
+import type { ControlInteractionRegistry } from '../control-interaction.js';
+interface Props {
+    registry: ControlInteractionRegistry;
+}
+declare const CompositeRegistration: import("svelte").Component<Props, {}, "">;
+type CompositeRegistration = ReturnType<typeof CompositeRegistration>;
+export default CompositeRegistration;
+//# sourceMappingURL=composite-registration.fixture.svelte.d.ts.map

package/dist/components/forms/__tests__/composite-registration.fixture.svelte.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"composite-registration.fixture.svelte.d.ts","sourceRoot":"","sources":["../../../../src/components/forms/__tests__/composite-registration.fixture.svelte.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,0BAA0B,EAAE,MAAM,2BAA2B,CAAC;AAO5E,UAAU,KAAK;IACb,QAAQ,EAAE,0BAA0B,CAAC;CACtC;AA8BD,QAAA,MAAM,qBAAqB,2CAAwC,CAAC;AACpE,KAAK,qBAAqB,GAAG,UAAU,CAAC,OAAO,qBAAqB,CAAC,CAAC;AACtE,eAAe,qBAAqB,CAAC"}

package/dist/components/forms/__tests__/control-interaction.test.js

@@ -2610,13 +2610,31 @@ describe('control interaction registry', () => {
             reveal,
             highlight,
         });
-        await registry.execute({ action: 'focus', identity });
+        await registry.execute({ action: 'focus', identity }, { source: 'user' });
         await registry.execute({ action: 'reveal', identity });
         await registry.execute({ action: 'highlight', identity, durationMs: 400 });
         expect(focus).toHaveBeenCalledOnce();
         expect(reveal).toHaveBeenCalledOnce();
         expect(highlight).toHaveBeenCalledWith(400);
     });
+    it('never moves keyboard focus for an agent: focus reveals and highlights instead', async () => {
+        const focus = vi.fn();
+        const reveal = vi.fn();
+        const highlight = vi.fn();
+        const registry = createControlInteractionRegistry();
+        registry.register({
+            identity,
+            metadata: { kind: 'text' },
+            focus,
+            reveal,
+            highlight,
+        });
+        const result = await registry.execute({ action: 'focus', identity }, { source: 'agent' });
+        expect(result.ok).toBe(true);
+        expect(focus).not.toHaveBeenCalled();
+        expect(reveal).toHaveBeenCalledOnce();
+        expect(highlight).toHaveBeenCalledOnce();
+    });
     it('rejects a recognized factory event retained beyond its dispatch', async () => {
         let captured;
         let value = 'Ada';

package/dist/components/forms/__tests__/control-proposals.test.js

@@ -0,0 +1,63 @@
+import { render, screen } from '@testing-library/svelte';
+import { tick } from 'svelte';
+import { describe, expect, it } from 'vitest';
+import { createControlInteractionRegistry } from '../control-interaction.js';
+import { controlProposalInputSchema, controlProposalToolName, stageControlProposals, } from '../control-proposals.js';
+import Fixture from './composite-registration.fixture.svelte';
+describe('useControlRegistration (public) and control proposals', () => {
+    it('registers a composite as one control with its declared value schema', async () => {
+        const registry = createControlInteractionRegistry();
+        render(Fixture, { props: { registry } });
+        await tick();
+        const ids = registry
+            .list('new-site')
+            .map((snapshot) => snapshot.identity.controlId);
+        expect(ids).toEqual(expect.arrayContaining(['name', 'place', 'password']));
+        const place = registry.get({ formId: 'new-site', controlId: 'place' });
+        expect(place?.metadata.label).toBe('Town location');
+        expect(place?.metadata.valueSchema).toMatchObject({ type: 'object' });
+    });
+    it('builds a proposal schema from every proposable control, never secrets', async () => {
+        const registry = createControlInteractionRegistry();
+        render(Fixture, { props: { registry } });
+        await tick();
+        const schema = controlProposalInputSchema(registry, 'new-site');
+        expect(Object.keys(schema.properties).sort()).toEqual(['name', 'place']);
+        expect(schema.properties.name).toEqual({
+            type: 'string',
+            title: 'Site name',
+        });
+        expect(schema.properties.place).toMatchObject({
+            type: 'object',
+            title: 'Town location',
+        });
+        expect(controlProposalInputSchema(registry, 'new-site', { exclude: ['name'] })).toMatchObject({ properties: { place: expect.any(Object) } });
+    });
+    it('stages proposals for review without changing values', async () => {
+        const registry = createControlInteractionRegistry();
+        render(Fixture, { props: { registry } });
+        await tick();
+        const result = await stageControlProposals(registry, 'new-site', {
+            name: 'Lacombe',
+            place: { name: 'Lacombe', latitude: 52.46, longitude: -113.73 },
+            password: 'hunter2',
+            nope: 1,
+        }, { actorId: 'assistant' });
+        expect(result).toEqual({
+            ok: true,
+            staged: 2,
+            rejected: [],
+            skipped: ['password', 'nope'],
+        });
+        expect(screen.getByTestId('place')).toHaveTextContent('none');
+        const staged = registry.get({ formId: 'new-site', controlId: 'place' });
+        expect(staged?.state.staged?.provenance).toMatchObject({
+            source: 'agent',
+            actorId: 'assistant',
+        });
+    });
+    it('names the tool with tool-safe characters', () => {
+        expect(controlProposalToolName('setup-network')).toBe('setup_network_stage_changes');
+        expect(controlProposalToolName('--')).toBe('form_stage_changes');
+    });
+});