@happyvertical/smrt-svelte 0.53.1 → 0.53.3

package/dist/web/__tests__/activity-feed.svelte.test.js

@@ -1,235 +0,0 @@
-/**
- * Unit tests for the AdminShell activity feed adapter's reconciliation core
- * (#1779).
- *
- * These exercise {@link ActivityFeedReconciler} — the pure diff between a set of
- * live rows and the shell activity registry — against a REAL {@link ShellState}.
- * Per repo policy nothing here is mocked: the shell, its activity events, and
- * the mapping are all real; the reconciler is fed plain row arrays that stand in
- * for successive live-collection ticks (`liveCollection`'s engine is exercised
- * separately in `activity-feed.integration.svelte.test.ts`). This isolates the
- * mapping / create-update-remove / ownership behavior the adapter guarantees.
- */
-import { afterEach, describe, expect, it } from 'vitest';
-import { createShellState } from '../../components/workspace/admin-shell/state.svelte.js';
-import { ActivityFeedReconciler, } from '../activity-feed.svelte.js';
-/** Editorial map: a job row → focus-scope activity, or `null` for a draft. */
-const mapJob = (row) => {
-    if (row.draft)
-        return null;
-    return {
-        kind: 'render-job',
-        scope: 'focus',
-        label: row.title,
-        status: row.state,
-        progress: row.progress ?? null,
-    };
-};
-/** Record every activity event the shell emits, for sequence assertions. */
-function recordEvents(shell) {
-    const events = [];
-    const stop = shell.watchActivities((event) => events.push(event));
-    return { events, stop };
-}
-describe('ActivityFeedReconciler', () => {
-    const teardown = [];
-    afterEach(() => {
-        for (const fn of teardown.splice(0))
-            fn();
-    });
-    function setup() {
-        const shell = createShellState();
-        const recorded = recordEvents(shell);
-        teardown.push(recorded.stop);
-        const reconciler = new ActivityFeedReconciler(shell, mapJob);
-        return { shell, reconciler, events: recorded.events };
-    }
-    it('upserts a shell activity when a row first appears', () => {
-        const { shell, reconciler, events } = setup();
-        reconciler.reconcile([
-            { id: 'job-1', title: 'Render intro', state: 'running', progress: 20 },
-        ]);
-        const activities = shell.listActivities();
-        expect(activities).toHaveLength(1);
-        expect(activities[0]).toMatchObject({
-            id: 'job-1',
-            kind: 'render-job',
-            scope: 'focus',
-            label: 'Render intro',
-            status: 'running',
-            progress: 20,
-        });
-        // The activity id defaults to the row id, and the shell stamped createdAt.
-        expect(activities[0].createdAt).toBeTruthy();
-        // A single create event (upsert), no transition/remove.
-        expect(events.map((e) => e.type)).toEqual(['upsert']);
-    });
-    it('updates the activity in place when a row changes (status transition)', () => {
-        const { shell, reconciler, events } = setup();
-        reconciler.reconcile([
-            { id: 'job-1', title: 'Render intro', state: 'running', progress: 20 },
-        ]);
-        const createdAt = shell.listActivities()[0].createdAt;
-        // Same row id, advanced progress + status flip → an UPDATE, not a second
-        // create, and the shell reports it as a `transition` (status changed).
-        reconciler.reconcile([
-            { id: 'job-1', title: 'Render intro', state: 'completed', progress: 100 },
-        ]);
-        const activities = shell.listActivities();
-        expect(activities).toHaveLength(1);
-        expect(activities[0]).toMatchObject({
-            id: 'job-1',
-            status: 'completed',
-            progress: 100,
-        });
-        // createdAt preserved across the update (update went through updateActivity,
-        // not a fresh upsert that would re-stamp it).
-        expect(activities[0].createdAt).toBe(createdAt);
-        expect(events.map((e) => e.type)).toEqual(['upsert', 'transition']);
-    });
-    it('performs no shell mutation when a reconcile tick is unchanged', () => {
-        const { reconciler, events } = setup();
-        const rows = [
-            { id: 'job-1', title: 'Render intro', state: 'running', progress: 20 },
-        ];
-        reconciler.reconcile(rows);
-        // Re-feed identical content (a common no-op reactive tick): a new array with
-        // an equal-but-distinct row object. Must not emit a second event.
-        reconciler.reconcile([{ ...rows[0] }]);
-        expect(events.map((e) => e.type)).toEqual(['upsert']);
-    });
-    it('removes the activity when its row vanishes from the collection', () => {
-        const { shell, reconciler, events } = setup();
-        reconciler.reconcile([
-            { id: 'job-1', title: 'Render intro', state: 'running' },
-            { id: 'job-2', title: 'Render outro', state: 'queued' },
-        ]);
-        expect(shell.listActivities()).toHaveLength(2);
-        // job-1 gone from the next tick → removed; job-2 unchanged → left alone.
-        reconciler.reconcile([
-            { id: 'job-2', title: 'Render outro', state: 'queued' },
-        ]);
-        const remaining = shell.listActivities();
-        expect(remaining).toHaveLength(1);
-        expect(remaining[0].id).toBe('job-2');
-        expect(events.map((e) => e.type)).toEqual([
-            'upsert', // job-1 create
-            'upsert', // job-2 create
-            'remove', // job-1 removed
-        ]);
-    });
-    it('treats a row that maps to null as absent (excluded, then removed when it flips)', () => {
-        const { shell, reconciler } = setup();
-        // A draft row maps to null → never becomes an activity.
-        reconciler.reconcile([
-            { id: 'job-1', title: 'Draft', state: 'queued', draft: true },
-        ]);
-        expect(shell.listActivities()).toHaveLength(0);
-        // It leaves draft → now an activity appears.
-        reconciler.reconcile([
-            { id: 'job-1', title: 'Published', state: 'running' },
-        ]);
-        expect(shell.listActivities()).toHaveLength(1);
-        // It goes back to draft (maps to null again) → activity is removed.
-        reconciler.reconcile([
-            { id: 'job-1', title: 'Published', state: 'running', draft: true },
-        ]);
-        expect(shell.listActivities()).toHaveLength(0);
-    });
-    it('lets the map decouple the activity id from the row id', () => {
-        const shell = createShellState();
-        const reconciler = new ActivityFeedReconciler(shell, (row) => ({
-            id: `activity:${row.id}`,
-            kind: 'render-job',
-            scope: 'system',
-            label: row.title,
-            status: row.state,
-        }));
-        reconciler.reconcile([{ id: 'job-1', title: 'Job', state: 'running' }]);
-        const activities = shell.listActivities();
-        expect(activities).toHaveLength(1);
-        expect(activities[0].id).toBe('activity:job-1');
-    });
-    it('routes an activity to the shell edge for its scope', () => {
-        const { shell, reconciler } = setup();
-        reconciler.reconcile([{ id: 'job-1', title: 'Job', state: 'running' }]);
-        // scope 'focus' homes to the right edge (SCOPE_EDGES.focus === 'right').
-        expect(shell.listActivities({ edge: 'right' })).toHaveLength(1);
-    });
-    it('re-homes the activity to the new edge when its scope changes (no explicit edge)', () => {
-        const shell = createShellState();
-        // Map keys scope off the row so a later tick can change it; no `edge` set.
-        const reconciler = new ActivityFeedReconciler(shell, (row) => ({
-            kind: 'render-job',
-            // Reuse the unused `draft` flag as a cheap "move to system scope" toggle.
-            scope: row.draft ? 'system' : 'focus',
-            label: row.title,
-            status: row.state,
-        }));
-        reconciler.reconcile([{ id: 'job-1', title: 'Job', state: 'running' }]);
-        // Focus → right edge.
-        expect(shell.listActivities({ edge: 'right' })).toHaveLength(1);
-        expect(shell.listActivities({ edge: 'bottom' })).toHaveLength(0);
-        // Scope flips to system; the map still sets no explicit edge. The activity
-        // must RE-DERIVE its edge from the new scope (system → bottom), not stay
-        // pinned to the old right edge.
-        reconciler.reconcile([
-            { id: 'job-1', title: 'Job', state: 'running', draft: true },
-        ]);
-        expect(shell.listActivities({ edge: 'right' })).toHaveLength(0);
-        expect(shell.listActivities({ edge: 'bottom' })).toHaveLength(1);
-        expect(shell.listActivities()[0].scope).toBe('system');
-    });
-    it('clears a previously-set optional field when a later mapping drops it', () => {
-        const shell = createShellState();
-        // Map emits `message`/`detailHref` only while the job is running.
-        const reconciler = new ActivityFeedReconciler(shell, (row) => ({
-            kind: 'render-job',
-            scope: 'focus',
-            label: row.title,
-            status: row.state,
-            ...(row.state === 'running'
-                ? { message: 'Rendering frames', detailHref: '/jobs/job-1' }
-                : {}),
-        }));
-        reconciler.reconcile([{ id: 'job-1', title: 'Job', state: 'running' }]);
-        let activity = shell.listActivities()[0];
-        expect(activity.message).toBe('Rendering frames');
-        expect(activity.detailHref).toBe('/jobs/job-1');
-        // The job completes → the map no longer emits message/detailHref. Those
-        // stale values must be CLEARED, not retained from the previous mapping.
-        reconciler.reconcile([{ id: 'job-1', title: 'Job', state: 'completed' }]);
-        activity = shell.listActivities()[0];
-        expect(activity.status).toBe('completed');
-        expect(activity.message).toBeUndefined();
-        expect(activity.detailHref).toBeUndefined();
-    });
-    it('dispose() removes exactly the feed activities and stops reconciling', () => {
-        const { shell, reconciler, events } = setup();
-        // An activity from ANOTHER source the feed must never touch.
-        shell.upsertActivity({
-            id: 'external-1',
-            label: 'External',
-            kind: 'other',
-            scope: 'app',
-            status: 'running',
-        });
-        reconciler.reconcile([
-            { id: 'job-1', title: 'Render intro', state: 'running' },
-        ]);
-        expect(shell.listActivities()).toHaveLength(2);
-        reconciler.dispose();
-        // Only the feed's own activity was retracted; the external one survives.
-        const remaining = shell.listActivities();
-        expect(remaining).toHaveLength(1);
-        expect(remaining[0].id).toBe('external-1');
-        expect(reconciler.isDisposed).toBe(true);
-        // Reconciling after dispose is a no-op (no new activities, no events).
-        const eventsBefore = events.length;
-        reconciler.reconcile([
-            { id: 'job-2', title: 'Late job', state: 'running' },
-        ]);
-        expect(shell.listActivities()).toHaveLength(1);
-        expect(events.length).toBe(eventsBefore);
-    });
-});

package/dist/web/__tests__/assistant-dock.integration.svelte.test.js

@@ -1,204 +0,0 @@
-// @vitest-environment jsdom
-/**
- * AssistantDock conformance-style integration test (#2904).
- *
- * Mirrors `data-surface-conformance.integration.svelte.test.ts` in this
- * directory: a real `DataSurfaceRegistry` and a real
- * `createAssistantDockController`/`AssistantDock` are composed together;
- * only the chat transport and the action client are in-process test doubles
- * (`createInMemoryAssistantTransport`, and a thin `actionClient` adapter over
- * the registry's own `execute()`), matching that file's stated scope of
- * faking only the transport boundary.
- *
- * Scope note (disclosed deviation from the original test plan): the action
- * preview/apply path here is driven directly through
- * `createAssistantDockController` rather than by having a fake model reply
- * trigger it through the rendered `AssistantDock` DOM — `AssistantDock` has
- * no built-in "parse this assistant message as an action proposal" step (no
- * such parsing is specified anywhere in #2904's binding decisions), so the
- * host application is expected to call `controller.previewAction(...)` from
- * its own message-rendering logic. This test still exercises the full
- * dock (registry discovery, rendering, send/poll) through the DOM, and
- * separately proves the action pathway (preview → confirm → apply → registry
- * "command" event) end-to-end against the real registry.
- */
-import { AssistantDock, createAssistantDockController, createInMemoryAssistantTransport, } from '@happyvertical/smrt-chat/svelte';
-import { createDataSurfaceRegistry, } from '@happyvertical/smrt-ui/data-surface';
-import { render, screen, waitFor } from '@testing-library/svelte';
-import { describe, expect, it } from 'vitest';
-const identity = {
-    surfaceId: 'assistant-dock-orders',
-    kind: 'table',
-    subject: { type: 'tenant', id: 'tenant-a' },
-};
-const descriptor = {
-    version: 1,
-    identity,
-    schemaVersion: 1,
-    label: 'Orders',
-    rowKey: 'id',
-    columns: [
-        {
-            id: 'id',
-            label: 'ID',
-            capabilities: ['read', 'project'],
-            role: 'row-key',
-        },
-    ],
-    query: {
-        modes: ['rows'],
-        projectableColumnIds: ['id'],
-        searchableColumnIds: [],
-        filterableColumnIds: [],
-        sortableColumnIds: [],
-    },
-    actions: [
-        {
-            id: 'archive',
-            label: 'Archive',
-            selectionScopes: ['explicit-ids'],
-            requiresConfirmation: true,
-        },
-    ],
-    controls: [{ id: 'data-surface.action.archive', label: 'Archive' }],
-    limits: { maxQueryRows: 100, maxQueryBytes: 100_000, maxSelectionSize: 100 },
-};
-function mountRegistryWithOneSurface() {
-    const registry = createDataSurfaceRegistry();
-    let revision = 1;
-    const state = { archived: false };
-    const unregister = registry.register({
-        descriptor,
-        getSnapshot: () => ({
-            version: 1,
-            descriptor,
-            revision,
-            state: { archived: state.archived },
-        }),
-        execute: async (command) => {
-            // A minimal real mutation: the "archive" action flips `archived` and
-            // bumps the snapshot revision, which is what makes the registry emit a
-            // 'command' event other mounted UI can react to.
-            state.archived = true;
-            revision += 1;
-            return {
-                version: 1,
-                commandId: command.commandId,
-                identity: command.identity,
-                ok: true,
-                revision,
-            };
-        },
-    });
-    return { registry, unregister, state: () => state.archived };
-}
-describe('AssistantDock integration (#2904)', () => {
-    it('fails closed and shows the no-surfaces notice with an empty registry', async () => {
-        const registry = createDataSurfaceRegistry();
-        const transport = createInMemoryAssistantTransport();
-        render(AssistantDock, { props: { transport, registry } });
-        await waitFor(() => {
-            expect(screen.getByText(/Nothing on this page can be changed from the chat/i)).toBeInTheDocument();
-        });
-    });
-    it('discovers a mounted surface via the registry and renders a sent conversation', async () => {
-        const { registry } = mountRegistryWithOneSurface();
-        const transport = createInMemoryAssistantTransport({
-            respond: (_threadId, userMessage) => ({
-                id: 'assistant-1',
-                threadId: userMessage.threadId,
-                content: 'Archived the order.',
-                role: 'assistant',
-                createdAt: new Date(),
-            }),
-        });
-        render(AssistantDock, { props: { transport, registry } });
-        await waitFor(() => {
-            expect(screen.queryByText(/Nothing on this page can be changed from the chat/i)).not.toBeInTheDocument();
-        });
-        const thread = await transport.createThread('Order question');
-        // Drive the same controller the component owns internally by exercising
-        // the transport directly (the composer's own send() path is covered at
-        // the unit level in packages/chat); here we assert the descriptor is
-        // visible to a controller built against this exact registry instance.
-        const controller = createAssistantDockController({ transport, registry });
-        await controller.openThread(thread.id);
-        // Cycle-3 second final finding 1: an attached file must round-trip onto
-        // the sent message, not just the message text — this is the surface
-        // that previously rendered nothing for message.attachments.
-        await controller.send('please archive this order', [
-            { id: 'att-1', name: 'order-details.pdf' },
-        ]);
-        await waitFor(() => {
-            expect(controller.messages.some((m) => m.content === 'Archived the order.')).toBe(true);
-        });
-        const sentMessage = controller.messages.find((m) => m.content === 'please archive this order');
-        expect(sentMessage?.attachments).toEqual([
-            { id: 'att-1', name: 'order-details.pdf' },
-        ]);
-        expect(controller.surfaces).toHaveLength(1);
-        expect(controller.surfaces[0].surfaceId).toBe('assistant-dock-orders');
-        controller.dispose();
-    });
-    it('drives preview → confirm → apply through the real registry and fires its "command" event', async () => {
-        const { registry, state } = mountRegistryWithOneSurface();
-        const events = [];
-        registry.subscribe((event) => events.push(event));
-        const actionClient = {
-            async preview(request) {
-                // A preview never mutates: assert the surface is untouched.
-                expect(state()).toBe(false);
-                return {
-                    version: 1,
-                    requestId: request.requestId,
-                    identity: request.identity,
-                    actionId: request.actionId,
-                    phase: 'preview',
-                    ok: true,
-                    confirmationToken: 'token-1',
-                };
-            },
-            async apply(request) {
-                const result = await registry.execute({
-                    version: 1,
-                    commandId: request.requestId,
-                    identity: request.identity,
-                    expectedRevision: 1,
-                    controlId: `data-surface.action.${request.actionId}`,
-                });
-                return {
-                    version: 1,
-                    requestId: request.requestId,
-                    identity: request.identity,
-                    actionId: request.actionId,
-                    phase: 'apply',
-                    ok: result.ok,
-                    reason: result.ok ? undefined : result.reason,
-                };
-            },
-        };
-        const controller = createAssistantDockController({
-            transport: createInMemoryAssistantTransport(),
-            registry,
-            actionClient,
-        });
-        const requestId = 'archive-req-1';
-        await controller.previewAction({
-            version: 1,
-            requestId,
-            identity,
-            actionId: 'archive',
-            phase: 'preview',
-            selection: { scope: 'explicit-ids', rowIds: ['order-1'] },
-        });
-        expect(controller.actions.get(requestId)?.status).toBe('previewed');
-        expect(state()).toBe(false); // preview never mutated the surface
-        // applyAction now takes only requestId — it reuses the idempotencyKey
-        // minted once by previewAction (binding decision #2904, build phase 2).
-        await controller.applyAction(requestId);
-        expect(controller.actions.get(requestId)?.status).toBe('applied');
-        expect(state()).toBe(true);
-        expect(events.some((e) => e.type === 'command')).toBe(true);
-        controller.dispose();
-    });
-});