@happyvertical/smrt-scanner 0.40.69 → 0.41.0

package/AGENTS.md

@@ -18,6 +18,18 @@ executes the source.
 - `parseFile` / `parseSource` — parse a single file or a source string to a
   `FileScanResult` (classes, errors, type aliases, SMRT imports).
 - `extractSmrtImports` — pull SMRT-related imports from a parsed file.
+- `lintNumericPrecision(classes, sourceText?)` — flags persisted `number` fields
+  whose declared precision contradicts their name (#2361), returning a `kind`
+  per finding. **Money is exact** and stored as integer minor units, so
+  `subtotal = 0.0` is a `money` finding; **rates are fractional**, so
+  `taxRate = 0` is a `rate` finding. `classifyNumericFieldName` does head-noun
+  matching and lets a rate word win outright, so `taxRate` is a rate even though
+  `tax` is money, while `amountCents` and `totalTokensUsed` classify as neither.
+  `weight`/`score`/`factor`/`percent` are deliberately unclassified — they are
+  commonly whole numbers. Explicit `@field({ type })`, `@meta`/`Meta<T>`,
+  transient, relationship, and static fields are exempt.
+  `sourceMayContainNumericPrecisionIssue(source)` is the cheap pre-filter
+  callers use to avoid parsing every file; `dev:knowledge-check` drives both.
 - `verifyManifestCompleteness({ packageDir })` — publish guard: re-scans `src/`
   and asserts every `@smrt()` object reached `dist/manifest.json` (issue #1483).
   Returns `ok` / `incomplete` / `missing-manifest` / `scan-error` / `skipped`.
@@ -89,9 +101,13 @@ exhausts the heap when the scanner is pointed at an application root (#2275):
 - **`ManifestBuilder` / `discoverBaseClasses` live in `@happyvertical/smrt-core`,
   not here.** This package is the lower-level AST layer; core orchestrates
   manifest generation and base-class discovery on top of it.
-- **0 vs 0.0 heuristic**: `count = 0` → integer, `price = 0.0` → decimal; the
+- **0 vs 0.0 heuristic**: `count = 0` → integer, `ratio = 0.0` → decimal; the
   raw initializer text (not the parsed value) decides, and negative defaults are
-  unwrapped from their `UnaryExpression` before the check.
+  unwrapped from their `UnaryExpression` before the check. The rule is silent
+  and SQLite's affinity masks the consequence, so money- and rate-shaped fields
+  are gated by `lintNumericPrecision` rather than left to review (#2361).
+- **`RawFieldDefinition.line` is `0`**: the OXC AST nodes reaching this package
+  carry no `loc`. Pass the source text to a consumer that needs a real line.
 - **Static property capture**: captures `uiSlots` and `adminRoutes` for agent
   manifest generation.
 - **`@smrt()` config spreads resolve only against unescaped same-file `const`s** (issue
@@ -112,3 +128,11 @@ exhausts the heap when the scanner is pointed at an application root (#2275):
   but its taint replays into the diagnostics of every decorator that spreads
   it, transitively through constant chains. Without that the silent drop simply
   moves one level up. An unused tainted constant reports nothing.
+- **Relationship targets are resolved, not copied**: `@foreignKey`,
+  `@oneToMany` and `@manyToMany` arguments arrive as raw source text.
+  `'Target'`/`Target` pass through and a forward-reference thunk
+  (`() => Target`, including the dotted `() => Target.column` form) is unwrapped
+  to its target, matching the runtime decorator, which resolves the thunk by
+  invoking it. Any other expression (a call, a computed reference) yields
+  `related: undefined` — writing the raw source through produced a garbage FK
+  table name and, once FK columns are indexed, a garbage index (#2379).

package/dist/chunks/{scanner-LeMvLJ6X.js → scanner-jUIN438d.js}

@@ -1261,6 +1261,18 @@ function stripQuotes(value) {
 	const match = value.match(/^(['"`])(.+)\1$/);
 	return match ? match[2] : value;
 }
+var QUOTED_LITERAL_PATTERN = /^(['"`])(.*)\1$/s;
+var RELATED_TARGET_PATTERN = /^[A-Za-z_$][\w$]*(?:\.[A-Za-z_$][\w$]*)*$/;
+var RELATED_THUNK_PATTERN = /^\(\s*\)\s*=>\s*(?:([A-Za-z_$][\w$]*(?:\.[A-Za-z_$][\w$]*)*)|\{\s*return\s+([A-Za-z_$][\w$]*(?:\.[A-Za-z_$][\w$]*)*)\s*;?\s*\})$/;
+function resolveRelatedArgument(raw) {
+	const value = raw?.trim();
+	if (!value) return void 0;
+	const quoted = value.match(QUOTED_LITERAL_PATTERN);
+	if (quoted) return quoted[2].trim() || void 0;
+	if (RELATED_TARGET_PATTERN.test(value)) return value;
+	const thunk = value.match(RELATED_THUNK_PATTERN);
+	return thunk ? thunk[1] ?? thunk[2] : void 0;
+}
 function createQualifiedName(packageName, className) {
 	return `${packageName}:${className}`;
 }
@@ -1569,7 +1581,7 @@ var ManifestAdapter = class ManifestAdapter {
 			};
 		}
 		if (decorator.name === "foreignKey") {
-			const relatedClass = stripQuotes(decorator.arguments[0]?.trim());
+			const relatedClass = resolveRelatedArgument(decorator.arguments[0]);
 			const parsedOptions = this.parseFieldDecoratorOptions(decorator.arguments[1]);
 			const meta = {};
 			const META_KEYS = [
@@ -1640,7 +1652,7 @@ var ManifestAdapter = class ManifestAdapter {
 			};
 		}
 		if (decorator.name === "oneToMany") {
-			const relatedClass = stripQuotes(decorator.arguments[0]?.trim());
+			const relatedClass = resolveRelatedArgument(decorator.arguments[0]);
 			const parsedOptions = this.parseFieldDecoratorOptions(decorator.arguments[1]);
 			const meta = {};
 			if (parsedOptions?.foreignKey !== void 0) meta.foreignKey = parsedOptions.foreignKey;
@@ -1653,7 +1665,7 @@ var ManifestAdapter = class ManifestAdapter {
 			};
 		}
 		if (decorator.name === "manyToMany") {
-			const relatedClass = stripQuotes(decorator.arguments[0]?.trim());
+			const relatedClass = resolveRelatedArgument(decorator.arguments[0]);
 			const parsedOptions = this.parseFieldDecoratorOptions(decorator.arguments[1]);
 			const meta = {};
 			if (parsedOptions?.through !== void 0) meta.through = parsedOptions.through;
@@ -2168,4 +2180,4 @@ var OxcScanner = class {
 //#endregion
 export { parseSource as a, normalizeGlobSeparators as c, parseFile as i, relativeGlobToCwd as l, ManifestAdapter as n, InheritanceResolver as o, extractSmrtImports as r, discoverSourceFiles as s, OxcScanner as t };
 
-//# sourceMappingURL=scanner-LeMvLJ6X.js.map
+//# sourceMappingURL=scanner-jUIN438d.js.map