@happyvertical/smrt-projects 0.52.0 → 0.53.0

package/AGENTS.md

@@ -29,13 +29,20 @@ request/delivery projections.
 - `ManagedProjectClient` deliberately exposes no repository or board client;
   delivery and assistance use separate capability-gated service facades.
 
-## Shared Professional Service evidence (#1955)
+## Shared Professional Service evidence (#1955, #3288)
 
-`ServiceTimeEntry` is canonical here on the existing `service_time_entries`
-table. Planning, development, and support use the same immutable evidence and
-correction chain. `SubscriptionServiceCommercialResolver` prices client work
-through `smrt-subscriptions` (#1925); provider compensation remains a separate
-resolver and snapshot. See `SERVICE_TIME_MIGRATION.md`.
+`ServiceTimeEntry`, `ServiceChargeSnapshot`, `ServiceCompensationSnapshot`,
+their collections, and `ServiceEvidenceService` are owned by
+`@happyvertical/smrt-timesheets` (#3288) and **re-exported** here unchanged,
+on the unchanged `service_time_entries` / snapshot tables. Do not reintroduce
+a projects subclass: a third same-named class on the table breaks the
+single-table-family resolution (see `packages/timesheets/AGENTS.md`).
+`caseId` / `specialistId` exist only on smrt-support's subtype;
+`SubscriptionServiceCommercialResolver` reads them duck-typed when a support
+entry is priced. It prices client work through `smrt-subscriptions` (#1925);
+provider compensation remains a separate resolver and snapshot. The
+time-entry Svelte components are re-exported from smrt-timesheets too. See
+`SERVICE_TIME_MIGRATION.md`.
 
 ## Models
 
@@ -63,13 +70,17 @@ All collections provide: `discover({ repository, filters })`, `findByRepository(
 
 - **Money is integer minor units** (cents) — `$19.99` is `1999`.
   `ServiceChargeSnapshot.amount` and `ServiceCompensationSnapshot.amount`
+  (declared in smrt-timesheets)
   initialize `= 0`, never `= 0.0`: the integer literal is what maps them to
   INTEGER columns (BIGINT on fresh PostgreSQL/DuckDB databases; #2401, #2373). The two convert as a pair — the delivery margin is
   `charge - compensation`, an exact integer subtraction with no tolerance —
   and both are fed verbatim by `CommercialSnapshot.amount`, so a resolver that
-  returns major units corrupts the snapshot silently on SQLite and fails with
-  `22P02` on PostgreSQL. `pnpm --filter @happyvertical/smrt-projects
-  test:postgres` is the lane that holds the line.
+  returns major units is wrong on every engine: snapshot `save()` refuses a
+  fractional value (`19.99`) on SQLite and PostgreSQL alike, but a whole
+  major-unit value (`150` for $150.00) is a valid integer and is stored
+  100× too small. `pnpm --filter @happyvertical/smrt-timesheets
+  test:postgres` is the lane that holds the line (moved with the snapshots in
+  #3288).
 - **UI formats by dividing, never by `toFixed`**: `formatCurrency()` and
   `ServiceEvidenceList`'s `money()` scale back to major units using the
   currency's own minor-unit exponent, so zero-decimal currencies (JPY, KRW) are

package/README.md

@@ -5,9 +5,21 @@ Provider-agnostic project management models for the s-m-r-t framework. Manages r
 ## Installation
 
 ```bash
-pnpm add @happyvertical/smrt-projects
+pnpm add @happyvertical/smrt-projects @happyvertical/smrt-timesheets
 ```
 
+Time entries and their commercial snapshots live in
+[`smrt-timesheets`](../timesheets/README.md) (#3288); smrt-projects re-exports
+them. Under pnpm, declare `@happyvertical/smrt-timesheets` directly: the CLI's
+manifest discovery reads only top-level packages, so without it `smrt
+db:migrate` / `db:status` stop planning `service_time_entries`,
+`service_charge_snapshots`, and `service_compensation_snapshots`. Their old
+`@happyvertical/smrt-projects:*` class names keep resolving as deprecated
+aliases; move source references to `@happyvertical/smrt-timesheets:*` (for
+`ServiceTimeEntry` in an app with smrt-support installed, to
+`@happyvertical/smrt-support:ServiceTimeEntry`). See
+[SERVICE_TIME_MIGRATION.md](./SERVICE_TIME_MIGRATION.md).
+
 ## Usage
 
 ```typescript

package/SERVICE_TIME_MIGRATION.md

@@ -1,7 +1,46 @@
 # Service Time Entry migration
 
 `ServiceTimeEntry` moved from `@happyvertical/smrt-support` to
-`@happyvertical/smrt-projects` in issue #1955.
+`@happyvertical/smrt-projects` in issue #1955, and from there to
+`@happyvertical/smrt-timesheets` in issue #3288. smrt-projects re-exports the
+entry, its snapshots, their collections, and `ServiceEvidenceService`
+unchanged; `caseId` / `specialistId` now exist only on smrt-support's subtype.
+Consumers holding `service_time_entries` rows need no schema change — see the
+smrt-timesheets README ("Migrating from smrt-projects / smrt-support").
+
+**pnpm consumers must add a direct `@happyvertical/smrt-timesheets`
+dependency.** The CLI's manifest discovery (`smrt db:migrate`, `db:status`,
+`db:diff`) reads only top-level `node_modules` packages, and smrt-projects'
+own manifest no longer declares the moved models. Without the direct
+dependency, `service_time_entries`, `service_charge_snapshots`, and
+`service_compensation_snapshots` drop out of the planned schema: a fresh
+database never gets them (so `ServiceEvidenceService` fails the runtime table
+check), and an existing database reports them as orphan tables. npm and Yarn
+hoist the package and are unaffected.
+
+```bash
+pnpm add @happyvertical/smrt-timesheets
+```
+
+**Old class names keep resolving as deprecated aliases.** The moved classes
+declare `previousQualifiedNames` (#3338), so stored or declared
+`@happyvertical/smrt-projects:ServiceTimeEntry`, `:ServiceChargeSnapshot`, and
+`:ServiceCompensationSnapshot` references — polymorphic `meta_type` rows,
+`@crossPackageRef` and relationship targets, playbook `model:` names — resolve
+to the `@happyvertical/smrt-timesheets:*` classes with a one-time deprecation
+warning, and new association writes store the current name. `smrt doctor --db`
+counts remaining stored references; `smrt db:migrate-qualified-names` is the
+opt-in backfill. Move source references to the name of the class your
+application registers before the aliases are removed in a later breaking
+release: `@happyvertical/smrt-timesheets:*`, except
+`@happyvertical/smrt-support:ServiceTimeEntry` when smrt-support is installed
+(its subtype replaces the timesheets entry, whose name then does not resolve)
+or your own closing subclass's name. A same-named subtype that replaces a
+moved class also drops its alias for now — with smrt-support installed the
+`ServiceTimeEntry` alias does not resolve; see the smrt-timesheets README for
+the workaround.
+
+The #1955 notes below still describe the support side.
 
 There is no data migration and no duplicate table. The support import is a
 compatibility subtype over the shared class; it restates the schema so an
@@ -9,10 +48,13 @@ isolated support manifest remains self-contained, while both paths map to the
 existing `service_time_entries` table:
 
 ```ts
-// Preferred shared import
+// Preferred shared import (#3288)
+import { ServiceTimeEntry, ServiceEvidenceService } from '@happyvertical/smrt-timesheets';
+
+// Still supported: the same classes, re-exported
 import { ServiceTimeEntry, ServiceEvidenceService } from '@happyvertical/smrt-projects';
 
-// Supported compatibility import
+// Support subtype with caseId / specialistId
 import { ServiceTimeEntry } from '@happyvertical/smrt-support';
 ```