@happyvertical/smrt-ingestion 0.57.45 → 0.57.47

package/dist/svelte/argument-fields.d.ts

@@ -0,0 +1,48 @@
+import type { ProposalCatalogEntry } from '../proposal-dto.js';
+/** One top-level handler argument the review screen can edit as a field. */
+export type ArgumentField = {
+    name: string;
+    title: string;
+    required: boolean;
+    kind: 'text' | 'date' | 'date-time';
+    maxLength?: number;
+} | {
+    name: string;
+    title: string;
+    required: boolean;
+    kind: 'number' | 'integer';
+    minimum?: number;
+    maximum?: number;
+} | {
+    name: string;
+    title: string;
+    required: boolean;
+    kind: 'boolean';
+} | {
+    name: string;
+    title: string;
+    required: boolean;
+    kind: 'enum';
+    options: Array<string | number>;
+} | {
+    name: string;
+    title: string;
+    required: boolean;
+    kind: 'candidate';
+    model: string;
+} | {
+    name: string;
+    title: string;
+    required: boolean;
+    kind: 'evidence';
+};
+/**
+ * Top-level arguments drawn as fields (#4503): strings (plain, `date`,
+ * `date-time`), numbers, integers, booleans, enums of strings or numbers, and
+ * declared candidate/evidence references. Anything else (objects, arrays,
+ * unions) is edited only as JSON under "Advanced".
+ */
+export declare function argumentFields(schema: Record<string, unknown> | undefined, references?: ProposalCatalogEntry['references']): ArgumentField[];
+/** `YYYY-MM-DDTHH:mm` in local time for a `datetime-local` input; '' when unparsable. */
+export declare function localDateTime(value: unknown): string;
+//# sourceMappingURL=argument-fields.d.ts.map

package/dist/svelte/argument-fields.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"argument-fields.d.ts","sourceRoot":"","sources":["../../src/svelte/argument-fields.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,oBAAoB,EAAE,MAAM,oBAAoB,CAAC;AAE/D,4EAA4E;AAC5E,MAAM,MAAM,aAAa,GACrB;IACE,IAAI,EAAE,MAAM,CAAC;IACb,KAAK,EAAE,MAAM,CAAC;IACd,QAAQ,EAAE,OAAO,CAAC;IAClB,IAAI,EAAE,MAAM,GAAG,MAAM,GAAG,WAAW,CAAC;IACpC,SAAS,CAAC,EAAE,MAAM,CAAC;CACpB,GACD;IACE,IAAI,EAAE,MAAM,CAAC;IACb,KAAK,EAAE,MAAM,CAAC;IACd,QAAQ,EAAE,OAAO,CAAC;IAClB,IAAI,EAAE,QAAQ,GAAG,SAAS,CAAC;IAC3B,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,OAAO,CAAC,EAAE,MAAM,CAAC;CAClB,GACD;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,KAAK,EAAE,MAAM,CAAC;IAAC,QAAQ,EAAE,OAAO,CAAC;IAAC,IAAI,EAAE,SAAS,CAAA;CAAE,GACnE;IACE,IAAI,EAAE,MAAM,CAAC;IACb,KAAK,EAAE,MAAM,CAAC;IACd,QAAQ,EAAE,OAAO,CAAC;IAClB,IAAI,EAAE,MAAM,CAAC;IACb,OAAO,EAAE,KAAK,CAAC,MAAM,GAAG,MAAM,CAAC,CAAC;CACjC,GACD;IACE,IAAI,EAAE,MAAM,CAAC;IACb,KAAK,EAAE,MAAM,CAAC;IACd,QAAQ,EAAE,OAAO,CAAC;IAClB,IAAI,EAAE,WAAW,CAAC;IAClB,KAAK,EAAE,MAAM,CAAC;CACf,GACD;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,KAAK,EAAE,MAAM,CAAC;IAAC,QAAQ,EAAE,OAAO,CAAC;IAAC,IAAI,EAAE,UAAU,CAAA;CAAE,CAAC;AAkBzE;;;;;GAKG;AACH,wBAAgB,cAAc,CAC5B,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,SAAS,EAC3C,UAAU,GAAE,oBAAoB,CAAC,YAAY,CAAM,GAClD,aAAa,EAAE,CAsEjB;AACD,yFAAyF;AACzF,wBAAgB,aAAa,CAAC,KAAK,EAAE,OAAO,GAAG,MAAM,CAMpD"}

package/dist/svelte/argument-fields.js

@@ -0,0 +1,96 @@
+const record = (value) => value && typeof value === 'object' && !Array.isArray(value)
+    ? value
+    : {};
+/** The single non-null JSON type a property declares, if any. */
+function typeOf(schema) {
+    const declared = schema.type;
+    if (typeof declared === 'string')
+        return declared;
+    if (Array.isArray(declared)) {
+        const types = declared.filter((type) => type !== 'null');
+        return types.length === 1 && typeof types[0] === 'string'
+            ? types[0]
+            : undefined;
+    }
+    return undefined;
+}
+/**
+ * Top-level arguments drawn as fields (#4503): strings (plain, `date`,
+ * `date-time`), numbers, integers, booleans, enums of strings or numbers, and
+ * declared candidate/evidence references. Anything else (objects, arrays,
+ * unions) is edited only as JSON under "Advanced".
+ */
+export function argumentFields(schema, references = {}) {
+    const root = record(schema);
+    const properties = record(root.properties);
+    const required = new Set(Array.isArray(root.required)
+        ? root.required.filter((name) => typeof name === 'string')
+        : []);
+    const fields = [];
+    for (const [name, value] of Object.entries(properties)) {
+        const property = record(value);
+        const base = {
+            name,
+            title: typeof property.title === 'string' && property.title.trim()
+                ? property.title.trim()
+                : name,
+            required: required.has(name),
+        };
+        const reference = references[name];
+        if (reference?.kind === 'candidate') {
+            fields.push({ ...base, kind: 'candidate', model: reference.model });
+            continue;
+        }
+        if (reference?.kind === 'evidence') {
+            fields.push({ ...base, kind: 'evidence' });
+            continue;
+        }
+        const type = typeOf(property);
+        if (Array.isArray(property.enum) &&
+            property.enum.length &&
+            property.enum.every((option) => typeof option === 'string' || typeof option === 'number')) {
+            fields.push({
+                ...base,
+                kind: 'enum',
+                options: property.enum,
+            });
+            continue;
+        }
+        if (type === 'string')
+            fields.push({
+                ...base,
+                kind: property.format === 'date'
+                    ? 'date'
+                    : property.format === 'date-time'
+                        ? 'date-time'
+                        : 'text',
+                ...(Number.isSafeInteger(property.maxLength)
+                    ? { maxLength: property.maxLength }
+                    : {}),
+            });
+        else if (type === 'number' || type === 'integer')
+            fields.push({
+                ...base,
+                kind: type,
+                ...(typeof property.minimum === 'number'
+                    ? { minimum: property.minimum }
+                    : {}),
+                ...(typeof property.maximum === 'number'
+                    ? { maximum: property.maximum }
+                    : {}),
+            });
+        else if (type === 'boolean')
+            fields.push({ ...base, kind: 'boolean' });
+    }
+    return fields;
+}
+/** `YYYY-MM-DDTHH:mm` in local time for a `datetime-local` input; '' when unparsable. */
+export function localDateTime(value) {
+    if (typeof value !== 'string' || !value)
+        return '';
+    const date = new Date(value);
+    if (Number.isNaN(date.getTime()))
+        return '';
+    const pad = (part) => String(part).padStart(2, '0');
+    return `${date.getFullYear()}-${pad(date.getMonth() + 1)}-${pad(date.getDate())}T${pad(date.getHours())}:${pad(date.getMinutes())}`;
+}

package/dist/svelte/components/ActionReview.svelte

@@ -8,10 +8,19 @@ import { useI18n } from '@happyvertical/smrt-ui/i18n';
 import { Button } from '@happyvertical/smrt-ui/ui';
 import { onDestroy, untrack } from 'svelte';
 import type { ReviewInput } from '../../execution-dto.js';
-import type { ProposalCatalogEntry } from '../../proposal-dto.js';
+import type {
+  ProposalCandidate,
+  ProposalCatalogEntry,
+} from '../../proposal-dto.js';
 import type { IntakeReviewHost, ReviewAction } from '../../review-dto.js';
-import { M } from '../i18n.js';
-import { argumentsObject, missingRequired } from '../view-utils.js';
+import { argumentFields } from '../argument-fields.js';
+import { M, messageKey } from '../i18n.js';
+import {
+  argumentsObject,
+  displayEntries,
+  missingRequired,
+} from '../view-utils.js';
+import ArgumentFields from './ArgumentFields.svelte';
 import CandidatePicker from './CandidatePicker.svelte';
 export interface Props {
   host: IntakeReviewHost;
@@ -29,6 +38,26 @@ export interface Props {
   deny: () => void;
   /** Whether this editor holds unsent input (arguments, reason, comment). */
   ondirty?: (dirty: boolean) => void;
+  /** The handler's display label (#4503); the handler id is drawn when absent. */
+  label?: string;
+  /**
+   * The handler whose `argsSchema` draws the arguments as fields (#4503),
+   * the offered or reviewer catalog entry; the raw JSON stays under
+   * "Advanced". Without it (or a schema without properties) JSON only.
+   */
+  fields?: ProposalCatalogEntry;
+  /** Candidates already known for reference labels (the generation's offer). */
+  candidates?: readonly ProposalCandidate[];
+  /** Originals an evidence reference may name. */
+  evidence?: ReadonlyArray<{ id: string; label: string }>;
+  /**
+   * The judgment this reviewer sent for the action in this view (kept by the
+   * parent across the reload that follows), with the receipt id when the
+   * host returned one.
+   */
+  sent?: { judgment: 'correct' | 'incorrect'; id?: string };
+  /** Told about a judgment once the host accepted it. */
+  onjudged?: (judged: { judgment: 'correct' | 'incorrect'; id?: string }) => void;
 }
 let {
   host,
@@ -40,6 +69,12 @@ let {
   run,
   deny,
   ondirty,
+  label,
+  fields,
+  candidates,
+  evidence,
+  sent,
+  onjudged,
 }: Props = $props();
 const { t } = useI18n();
 // ReviewView keys this editor by action/revision/reviewVersion; edits are local to that binding.
@@ -50,6 +85,41 @@ let args = $state(untrack(() => JSON.stringify(action.args, null, 2) ?? '')),
   planArgs = $state(
     untrack(() => JSON.stringify(action.plan?.args, null, 2) ?? ''),
   );
+// Fields replace the destination picker when the schema draws any.
+const drawsFields = $derived(
+  !!fields && argumentFields(fields.argsSchema, fields.references).length > 0,
+);
+const stateKey = $derived(
+  messageKey('ingestion.reviewState.', action.review.state),
+);
+// The handler's preview fields, then non-empty framework metadata.
+const effects = $derived(displayEntries(action.review.display));
+// The current judgment: the loaded one, else the one sent from this view.
+const judged = $derived(action.feedback ?? sent);
+function judge(judgment: 'correct' | 'incorrect') {
+  const send = host.feedback;
+  if (!send) return;
+  const previous = action.feedback?.id ?? sent?.id;
+  const input = {
+    itemId,
+    actionId: action.review.actionId,
+    expectedRevision: action.review.revision,
+    expectedReviewVersion: action.review.reviewVersion,
+    bindingHash: action.review.bindingHash,
+    judgment,
+    comment,
+    requestId: crypto.randomUUID(),
+    // A second judgment replaces the reviewer's current one.
+    ...(previous ? { supersedesId: previous } : {}),
+  };
+  return run(async () => {
+    const receipt = await send(input);
+    onjudged?.({
+      judgment,
+      ...(receipt && typeof receipt.id === 'string' ? { id: receipt.id } : {}),
+    });
+  });
+}
 let alive = true;
 onDestroy(() => {
   alive = false;
@@ -189,16 +259,16 @@ function choose(field: string, id: string) {
 }
 </script>
 <article data-testid={`action-${action.review.actionId}`}>
-<h3>{action.handlerId ?? action.review.actionId}</h3>
+<h3>{label ?? action.handlerId ?? action.review.actionId}</h3>
 {#if action.origin === 'reviewer-selected'}<p>{t(M['ingestion.reviewerSelected'])}</p>{/if}
-<p>{t(M['ingestion.state'])}: {action.review.state}</p>
+<p data-testid="review-state">{t(M['ingestion.state'])}: {stateKey ? t(M[stateKey]) : action.review.state}</p>
 {#if action.args !== undefined}
-<h4>{t(M['ingestion.effects'])}</h4><pre>{JSON.stringify(action.review.display,null,2)}</pre>
-<Textarea aria-label={t(M['ingestion.args'])} bind:value={args} readonly={!editable || !!action.plan} rows={8} />
+<h4>{t(M['ingestion.effects'])}</h4>{#if effects.length}<dl class="effects" data-testid="effects">{#each effects as [name, value] (name)}<dt>{name}</dt><dd>{value}</dd>{/each}</dl>{/if}
+<ArgumentFields bind:value={args} label={t(M['ingestion.args'])} catalog={fields} {candidates} {evidence} readonly={!editable || !!action.plan} {host} {itemId} {deny} />
 {#if editable}
 {#if missing.length}<h4>{t(M['ingestion.missing'])}</h4><ul>{#each missing as name (name)}<li>{name}</li>{/each}</ul>{/if}
 <Input aria-label={t(M['ingestion.reason'])} bind:value={reason} />
-{#if !action.plan && catalog}<CandidatePicker {host} {itemId} {catalog} {deny} onchoose={choose} />{/if}
+{#if !action.plan && catalog && !drawsFields}<CandidatePicker {host} {itemId} {catalog} {deny} onchoose={choose} />{/if}
 {#if dirty}<p>{t(M['ingestion.reviewAgain'])}</p>{/if}
 {#if invalid}<p role="alert">{t(M['ingestion.invalid'])}</p>{/if}
 <div class="controls">{#if waiting && !resolved}<Button disabled={dirty} onclick={() => decide('approve')}>{t(M['ingestion.approve'])}</Button>{/if}{#if !action.plan && !resolved}<Button disabled={!dirty} onclick={saveEdits}>{t(M['ingestion.correct'])}</Button>{/if}{#if waiting}<Button onclick={() => decide('reject')}>{t(M['ingestion.reject'])}</Button>{#if !resolved}<Button onclick={() => decide('defer')}>{t(M['ingestion.defer'])}</Button>{/if}{/if}</div>
@@ -213,7 +283,7 @@ function choose(field: string, id: string) {
 {/if}
 {#if action.review.state === 'stale' && !action.stalePlan && action.attemptId && host.editAction && !resolved}
 <p>{t(M['ingestion.reviewAgain'])}</p>
-<Textarea aria-label={t(M['ingestion.args'])} bind:value={args} rows={8} />
+<ArgumentFields bind:value={args} label={t(M['ingestion.args'])} catalog={fields} {candidates} {evidence} {host} {itemId} {deny} />
 {#if invalid}<p role="alert">{t(M['ingestion.invalid'])}</p>{/if}
 <Button onclick={saveEdits}>{t(M['ingestion.correct'])}</Button>
 {/if}
@@ -224,11 +294,11 @@ function choose(field: string, id: string) {
 <Button onclick={editPlan}>{t(M['ingestion.editPlan'])}</Button>
 {/if}
 {#if action.result}<h4>{t(M['ingestion.result'])}</h4><pre>{JSON.stringify(action.result,null,2)}</pre>{/if}
-{#if host.feedback && action.args !== undefined && action.origin !== 'reviewer-selected'}<fieldset><legend>{t(M['ingestion.feedback'])}</legend><Textarea aria-label={t(M['ingestion.comment'])} bind:value={comment} /><Button disabled={dirty} onclick={() => run(() => host.feedback?.({itemId,actionId:action.review.actionId,expectedRevision:action.review.revision,expectedReviewVersion:action.review.reviewVersion,bindingHash:action.review.bindingHash,judgment:'correct',comment,requestId:crypto.randomUUID()}) ?? Promise.resolve())}>{t(M['ingestion.correctJudgment'])}</Button><Button disabled={dirty} onclick={() => run(() => host.feedback?.({itemId,actionId:action.review.actionId,expectedRevision:action.review.revision,expectedReviewVersion:action.review.reviewVersion,bindingHash:action.review.bindingHash,judgment:'incorrect',comment,requestId:crypto.randomUUID()}) ?? Promise.resolve())}>{t(M['ingestion.incorrectJudgment'])}</Button></fieldset>{/if}
+{#if host.feedback && action.args !== undefined && action.origin !== 'reviewer-selected'}<fieldset><legend>{t(M['ingestion.feedback'])}</legend><Textarea aria-label={t(M['ingestion.comment'])} bind:value={comment} /><Button disabled={dirty} aria-pressed={judged?.judgment === 'correct'} onclick={() => judge('correct')}>{t(M['ingestion.correctJudgment'])}</Button><Button disabled={dirty} aria-pressed={judged?.judgment === 'incorrect'} onclick={() => judge('incorrect')}>{t(M['ingestion.incorrectJudgment'])}</Button>{#if sent}<p role="status" data-testid="feedback-sent">{t(M['ingestion.feedbackSent'])}</p>{/if}</fieldset>{/if}
 </article>
 <style>
 @layer smrt.reset, smrt.structure, smrt.theme;
 @layer smrt.theme {
-article{min-width:0;overflow-wrap:anywhere;border-block-start:var(--smrt-hairline);padding-block:1rem}.controls{display:flex;flex-wrap:wrap;gap:.5rem;margin-block:.75rem}pre{white-space:pre-wrap;overflow-wrap:anywhere}fieldset{margin-block:1rem;min-width:0}
+article{min-width:0;overflow-wrap:anywhere;border-block-start:var(--smrt-hairline);padding-block:1rem}.controls{display:flex;flex-wrap:wrap;gap:.5rem;margin-block:.75rem}pre{white-space:pre-wrap;overflow-wrap:anywhere}fieldset{margin-block:1rem;min-width:0}.effects{display:grid;grid-template-columns:minmax(0,max-content) minmax(0,1fr);gap:.25rem 1rem;margin-block:.5rem}.effects dt{font-weight:600}.effects dd{margin:0}
 }
 </style>

package/dist/svelte/components/ActionReview.svelte.d.ts

@@ -1,6 +1,6 @@
 /** A reviewer operation whose result may finish the item for this reviewer. */
 export type ReviewOutcome = 'approve' | 'apply' | 'resolve';
-import type { ProposalCatalogEntry } from '../../proposal-dto.js';
+import type { ProposalCandidate, ProposalCatalogEntry } from '../../proposal-dto.js';
 import type { IntakeReviewHost, ReviewAction } from '../../review-dto.js';
 export interface Props {
     host: IntakeReviewHost;
@@ -15,6 +15,35 @@ export interface Props {
     deny: () => void;
     /** Whether this editor holds unsent input (arguments, reason, comment). */
     ondirty?: (dirty: boolean) => void;
+    /** The handler's display label (#4503); the handler id is drawn when absent. */
+    label?: string;
+    /**
+     * The handler whose `argsSchema` draws the arguments as fields (#4503),
+     * the offered or reviewer catalog entry; the raw JSON stays under
+     * "Advanced". Without it (or a schema without properties) JSON only.
+     */
+    fields?: ProposalCatalogEntry;
+    /** Candidates already known for reference labels (the generation's offer). */
+    candidates?: readonly ProposalCandidate[];
+    /** Originals an evidence reference may name. */
+    evidence?: ReadonlyArray<{
+        id: string;
+        label: string;
+    }>;
+    /**
+     * The judgment this reviewer sent for the action in this view (kept by the
+     * parent across the reload that follows), with the receipt id when the
+     * host returned one.
+     */
+    sent?: {
+        judgment: 'correct' | 'incorrect';
+        id?: string;
+    };
+    /** Told about a judgment once the host accepted it. */
+    onjudged?: (judged: {
+        judgment: 'correct' | 'incorrect';
+        id?: string;
+    }) => void;
 }
 declare const ActionReview: import("svelte").Component<Props, {}, "">;
 type ActionReview = ReturnType<typeof ActionReview>;

package/dist/svelte/components/ActionReview.svelte.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ActionReview.svelte.d.ts","sourceRoot":"","sources":["../../../src/svelte/components/ActionReview.svelte.ts"],"names":[],"mappings":"AAGA,+EAA+E;AAC/E,MAAM,MAAM,aAAa,GAAG,SAAS,GAAG,OAAO,GAAG,SAAS,CAAC;AAQ5D,OAAO,KAAK,EAAE,oBAAoB,EAAE,MAAM,uBAAuB,CAAC;AAClE,OAAO,KAAK,EAAE,gBAAgB,EAAE,YAAY,EAAE,MAAM,qBAAqB,CAAC;AAK1E,MAAM,WAAW,KAAK;IACpB,IAAI,EAAE,gBAAgB,CAAC;IACvB,MAAM,EAAE,MAAM,CAAC;IACf,MAAM,EAAE,YAAY,CAAC;IACrB,OAAO,CAAC,EAAE,oBAAoB,CAAC;IAC/B,gBAAgB,CAAC,EAAE,MAAM,CAAC;IAC1B,0GAA0G;IAC1G,QAAQ,CAAC,EAAE,OAAO,CAAC;IACnB,wFAAwF;IACxF,GAAG,EAAE,CACH,SAAS,EAAE,MAAM,OAAO,CAAC,OAAO,CAAC,EACjC,OAAO,CAAC,EAAE,aAAa,KACpB,OAAO,CAAC,IAAI,CAAC,CAAC;IACnB,IAAI,EAAE,MAAM,IAAI,CAAC;IACjB,2EAA2E;IAC3E,OAAO,CAAC,EAAE,CAAC,KAAK,EAAE,OAAO,KAAK,IAAI,CAAC;CACpC;AAsND,QAAA,MAAM,YAAY,2CAAwC,CAAC;AAC3D,KAAK,YAAY,GAAG,UAAU,CAAC,OAAO,YAAY,CAAC,CAAC;AACpD,eAAe,YAAY,CAAC"}
+{"version":3,"file":"ActionReview.svelte.d.ts","sourceRoot":"","sources":["../../../src/svelte/components/ActionReview.svelte.ts"],"names":[],"mappings":"AAGA,+EAA+E;AAC/E,MAAM,MAAM,aAAa,GAAG,SAAS,GAAG,OAAO,GAAG,SAAS,CAAC;AAQ5D,OAAO,KAAK,EACV,iBAAiB,EACjB,oBAAoB,EACrB,MAAM,uBAAuB,CAAC;AAC/B,OAAO,KAAK,EAAE,gBAAgB,EAAE,YAAY,EAAE,MAAM,qBAAqB,CAAC;AAW1E,MAAM,WAAW,KAAK;IACpB,IAAI,EAAE,gBAAgB,CAAC;IACvB,MAAM,EAAE,MAAM,CAAC;IACf,MAAM,EAAE,YAAY,CAAC;IACrB,OAAO,CAAC,EAAE,oBAAoB,CAAC;IAC/B,gBAAgB,CAAC,EAAE,MAAM,CAAC;IAC1B,0GAA0G;IAC1G,QAAQ,CAAC,EAAE,OAAO,CAAC;IACnB,wFAAwF;IACxF,GAAG,EAAE,CACH,SAAS,EAAE,MAAM,OAAO,CAAC,OAAO,CAAC,EACjC,OAAO,CAAC,EAAE,aAAa,KACpB,OAAO,CAAC,IAAI,CAAC,CAAC;IACnB,IAAI,EAAE,MAAM,IAAI,CAAC;IACjB,2EAA2E;IAC3E,OAAO,CAAC,EAAE,CAAC,KAAK,EAAE,OAAO,KAAK,IAAI,CAAC;IACnC,gFAAgF;IAChF,KAAK,CAAC,EAAE,MAAM,CAAC;IACf;;;;OAIG;IACH,MAAM,CAAC,EAAE,oBAAoB,CAAC;IAC9B,8EAA8E;IAC9E,UAAU,CAAC,EAAE,SAAS,iBAAiB,EAAE,CAAC;IAC1C,gDAAgD;IAChD,QAAQ,CAAC,EAAE,aAAa,CAAC;QAAE,EAAE,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IACxD;;;;OAIG;IACH,IAAI,CAAC,EAAE;QAAE,QAAQ,EAAE,SAAS,GAAG,WAAW,CAAC;QAAC,EAAE,CAAC,EAAE,MAAM,CAAA;KAAE,CAAC;IAC1D,uDAAuD;IACvD,QAAQ,CAAC,EAAE,CAAC,MAAM,EAAE;QAAE,QAAQ,EAAE,SAAS,GAAG,WAAW,CAAC;QAAC,EAAE,CAAC,EAAE,MAAM,CAAA;KAAE,KAAK,IAAI,CAAC;CACjF;AAiQD,QAAA,MAAM,YAAY,2CAAwC,CAAC;AAC3D,KAAK,YAAY,GAAG,UAAU,CAAC,OAAO,YAAY,CAAC,CAAC;AACpD,eAAe,YAAY,CAAC"}

package/dist/svelte/components/ArgumentFields.svelte

@@ -0,0 +1,176 @@
+<script lang="ts">
+import {
+  Checkbox,
+  Combobox,
+  Input,
+  Select,
+  Textarea,
+} from '@happyvertical/smrt-ui/forms';
+import { useI18n } from '@happyvertical/smrt-ui/i18n';
+import { onDestroy } from 'svelte';
+import type {
+  ProposalCandidate,
+  ProposalCatalogEntry,
+} from '../../proposal-dto.js';
+import type { IntakeReviewHost } from '../../review-dto.js';
+import {
+  type ArgumentField,
+  argumentFields,
+  localDateTime,
+} from '../argument-fields.js';
+import { M } from '../i18n.js';
+import { argumentsObject } from '../view-utils.js';
+export interface Props {
+  /** The arguments draft as JSON text (bindable); the fields edit it in place. */
+  value: string;
+  /** Accessible name of the JSON textarea. */
+  label: string;
+  /** The handler whose `argsSchema`/`references` shape the fields; JSON only when absent. */
+  catalog?: ProposalCatalogEntry;
+  /** Candidates already known (the generation's offer), for reference labels. */
+  candidates?: readonly ProposalCandidate[];
+  /** Originals an evidence reference may name. */
+  evidence?: ReadonlyArray<{ id: string; label: string }>;
+  readonly?: boolean;
+  rows?: number;
+  host: IntakeReviewHost;
+  itemId: string;
+  /** A failed candidate search fails closed: the owning view discards its payloads. */
+  deny: () => void;
+}
+let {
+  value = $bindable(),
+  label,
+  catalog,
+  candidates = [],
+  evidence = [],
+  readonly = false,
+  rows = 8,
+  host,
+  itemId,
+  deny,
+}: Props = $props();
+const { t } = useI18n();
+const fields = $derived(
+  catalog ? argumentFields(catalog.argsSchema, catalog.references) : [],
+);
+const parsed = $derived.by((): Record<string, unknown> | undefined => {
+  try {
+    return argumentsObject(value);
+  } catch {
+    return undefined;
+  }
+});
+// Labels of candidates seen in this editor (searched or offered), by model and id.
+let found = $state<Record<string, ProposalCandidate[]>>({}),
+  known = $state<Record<string, string>>({}),
+  searching = $state<Record<string, boolean>>({});
+let alive = true;
+// Newest search per field; an older answer is dropped.
+const searches: Record<string, number> = {};
+onDestroy(() => {
+  alive = false;
+});
+function candidateLabel(model: string, id: unknown): string | undefined {
+  if (typeof id !== 'string' || !id) return undefined;
+  return (
+    known[`${model}:${id}`] ??
+    candidates.find((entry) => entry.model === model && entry.id === id)?.label
+  );
+}
+function set(name: string, next: unknown) {
+  if (!parsed) return;
+  const draft = { ...parsed };
+  if (next === undefined) delete draft[name];
+  else draft[name] = next;
+  value = JSON.stringify(draft, null, 2);
+}
+async function search(
+  field: ArgumentField & { kind: 'candidate' },
+  query: string,
+) {
+  if (!catalog) return;
+  const ticket = (searches[field.name] ?? 0) + 1;
+  searches[field.name] = ticket;
+  searching[field.name] = true;
+  try {
+    const page = await host.candidates({
+      itemId,
+      handlerId: catalog.id,
+      handlerVersion: catalog.version,
+      query,
+    });
+    if (!alive || ticket !== searches[field.name]) return;
+    const matches = page.items.filter((entry) => entry.model === field.model);
+    found[field.name] = matches;
+    for (const entry of matches)
+      known[`${entry.model}:${entry.id}`] = entry.label;
+  } catch {
+    if (alive) deny();
+  } finally {
+    if (alive && ticket === searches[field.name]) searching[field.name] = false;
+  }
+}
+function choose(field: ArgumentField & { kind: 'candidate' }, id: string) {
+  // Only an id from the authorized page (or the current value) is accepted.
+  if (!id) return set(field.name, undefined);
+  if (
+    found[field.name]?.some((entry) => entry.id === id) ||
+    candidates.some((entry) => entry.model === field.model && entry.id === id)
+  )
+    set(field.name, id);
+}
+function number(field: ArgumentField, text: string) {
+  if (!text.trim()) return set(field.name, undefined);
+  const next = Number(text);
+  if (!Number.isFinite(next)) return;
+  if (field.kind === 'integer' && !Number.isSafeInteger(next)) return;
+  set(field.name, next);
+}
+function text(input: unknown): string {
+  return typeof input === 'string' || typeof input === 'number'
+    ? String(input)
+    : '';
+}
+</script>
+{#if fields.length}
+<fieldset class="argument-fields" data-testid="argument-fields" disabled={readonly}>
+<legend>{t(M['ingestion.fields'])}</legend>
+{#if !parsed}<p role="status">{t(M['ingestion.fieldsUnavailable'])}</p>{/if}
+{#each fields as field (field.name)}
+{@const current = parsed?.[field.name]}
+{@const name = field.required ? `${field.title} *` : field.title}
+<div class="field" data-field={field.name}>
+{#if field.kind === 'candidate'}
+{@const options = (found[field.name] ?? []).map((entry) => ({ value: entry.id, label: entry.label }))}
+<Combobox label={name} {options} value={text(current)} valueLabel={candidateLabel(field.model, current) ?? text(current)} filter={false} disabled={readonly || !parsed} busy={!!searching[field.name]} status={searching[field.name] ? t(M['ingestion.searching']) : options.length ? undefined : t(M['ingestion.noMatches'])} onquery={(query) => search(field, query)} onvaluechange={(id) => choose(field, id)} />
+{:else if field.kind === 'boolean'}
+<Checkbox label={name} checked={current === true} disabled={readonly || !parsed} onchange={(event) => set(field.name, (event.currentTarget as HTMLInputElement).checked)} />
+{:else if field.kind === 'enum'}
+<Select aria-label={name} value={text(current)} disabled={readonly || !parsed} onchange={(event) => { const chosen = (event.currentTarget as HTMLSelectElement).value; set(field.name, chosen === '' ? undefined : field.options.find((option) => String(option) === chosen)); }}><option value="">{t(M['ingestion.unset'])}</option>{#each field.options as option (option)}<option value={String(option)}>{option}</option>{/each}</Select>
+{:else if field.kind === 'evidence' && evidence.length}
+<Select aria-label={name} value={text(current)} disabled={readonly || !parsed} onchange={(event) => { const chosen = (event.currentTarget as HTMLSelectElement).value; set(field.name, chosen || undefined); }}><option value="">{t(M['ingestion.unset'])}</option>{#each evidence as part (part.id)}<option value={part.id}>{part.label}</option>{/each}</Select>
+{:else if field.kind === 'number' || field.kind === 'integer'}
+<Input type="number" aria-label={name} value={text(current)} step={field.kind === 'integer' ? 1 : 'any'} min={field.minimum} max={field.maximum} disabled={readonly || !parsed} oninput={(event) => number(field, (event.currentTarget as HTMLInputElement).value)} />
+{:else if field.kind === 'date'}
+<Input type="date" aria-label={name} value={text(current)} disabled={readonly || !parsed} oninput={(event) => { const chosen = (event.currentTarget as HTMLInputElement).value; set(field.name, chosen || undefined); }} />
+{:else if field.kind === 'date-time'}
+<Input type="datetime-local" aria-label={name} value={localDateTime(current)} disabled={readonly || !parsed} oninput={(event) => { const chosen = (event.currentTarget as HTMLInputElement).value; const at = chosen ? new Date(chosen) : undefined; if (at && Number.isNaN(at.getTime())) return; set(field.name, at?.toISOString()); }} />
+{:else}
+<Input aria-label={name} value={text(current)} maxlength={field.kind === 'text' ? field.maxLength : undefined} disabled={readonly || !parsed} oninput={(event) => { const chosen = (event.currentTarget as HTMLInputElement).value; set(field.name, chosen === '' ? undefined : chosen); }} />
+{/if}
+</div>
+{/each}
+</fieldset>
+<details class="advanced" data-testid="advanced-arguments"><summary>{t(M['ingestion.advanced'])}</summary>
+<Textarea aria-label={label} bind:value {readonly} {rows} />
+</details>
+{:else}
+<Textarea aria-label={label} bind:value {readonly} {rows} />
+{/if}
+<style>
+@layer smrt.reset, smrt.structure, smrt.theme;
+@layer smrt.theme {
+.argument-fields{display:grid;gap:.75rem;min-width:0;margin-block:.5rem}.field{min-width:0}.advanced{margin-block:.5rem}
+}
+</style>

package/dist/svelte/components/ArgumentFields.svelte.d.ts

@@ -0,0 +1,27 @@
+import type { ProposalCandidate, ProposalCatalogEntry } from '../../proposal-dto.js';
+import type { IntakeReviewHost } from '../../review-dto.js';
+export interface Props {
+    /** The arguments draft as JSON text (bindable); the fields edit it in place. */
+    value: string;
+    /** Accessible name of the JSON textarea. */
+    label: string;
+    /** The handler whose `argsSchema`/`references` shape the fields; JSON only when absent. */
+    catalog?: ProposalCatalogEntry;
+    /** Candidates already known (the generation's offer), for reference labels. */
+    candidates?: readonly ProposalCandidate[];
+    /** Originals an evidence reference may name. */
+    evidence?: ReadonlyArray<{
+        id: string;
+        label: string;
+    }>;
+    readonly?: boolean;
+    rows?: number;
+    host: IntakeReviewHost;
+    itemId: string;
+    /** A failed candidate search fails closed: the owning view discards its payloads. */
+    deny: () => void;
+}
+declare const ArgumentFields: import("svelte").Component<Props, {}, "value">;
+type ArgumentFields = ReturnType<typeof ArgumentFields>;
+export default ArgumentFields;
+//# sourceMappingURL=ArgumentFields.svelte.d.ts.map

package/dist/svelte/components/ArgumentFields.svelte.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"ArgumentFields.svelte.d.ts","sourceRoot":"","sources":["../../../src/svelte/components/ArgumentFields.svelte.ts"],"names":[],"mappings":"AAYA,OAAO,KAAK,EACV,iBAAiB,EACjB,oBAAoB,EACrB,MAAM,uBAAuB,CAAC;AAC/B,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,qBAAqB,CAAC;AAS5D,MAAM,WAAW,KAAK;IACpB,gFAAgF;IAChF,KAAK,EAAE,MAAM,CAAC;IACd,4CAA4C;IAC5C,KAAK,EAAE,MAAM,CAAC;IACd,2FAA2F;IAC3F,OAAO,CAAC,EAAE,oBAAoB,CAAC;IAC/B,+EAA+E;IAC/E,UAAU,CAAC,EAAE,SAAS,iBAAiB,EAAE,CAAC;IAC1C,gDAAgD;IAChD,QAAQ,CAAC,EAAE,aAAa,CAAC;QAAE,EAAE,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IACxD,QAAQ,CAAC,EAAE,OAAO,CAAC;IACnB,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,IAAI,EAAE,gBAAgB,CAAC;IACvB,MAAM,EAAE,MAAM,CAAC;IACf,qFAAqF;IACrF,IAAI,EAAE,MAAM,IAAI,CAAC;CAClB;AAiJD,QAAA,MAAM,cAAc,gDAAwC,CAAC;AAC7D,KAAK,cAAc,GAAG,UAAU,CAAC,OAAO,cAAc,CAAC,CAAC;AACxD,eAAe,cAAc,CAAC"}