@happyvertical/smrt-dev-mcp 0.60.9 → 0.60.11

package/dist/index.js

@@ -1,49 +1,14 @@
 #!/usr/bin/env node
 import { f as redactConnectionString, m as ProjectRuntimeResolutionError } from "./tools-B0uaPTz0.js";
-import { i as SERVER_VERSION, n as startRuntimeHttpHost, r as SERVER_NAME } from "./http-CCiO7qQW.js";
-import { n as TOOLS, t as REVIEW_SKILL_NAME } from "./tool-catalog-RHq7nyCm.js";
-import { a as buildReviewContext, c as compactContextResult, i as buildPackageSpecialistContext, n as buildContext, o as checkKnowledgeFreshness, r as buildKnowledgeIndex, s as checkKnowledgeFreshnessFromIndex, t as buildArchitectureContext } from "./knowledge-DqoDX-lZ.js";
-import { existsSync, readFileSync, realpathSync } from "node:fs";
-import { dirname, join, relative, resolve, sep } from "node:path";
+import { getAgentSkill, listAgentSkills } from "./agent-skills.js";
+import { i as SERVER_VERSION, n as startRuntimeHttpHost, r as SERVER_NAME } from "./http-BqKiyqgN.js";
+import { n as TOOLS, t as REVIEW_SKILL_NAME } from "./tool-catalog-BhnSCF8g.js";
+import { a as buildReviewContext, c as compactContextResult, i as buildPackageSpecialistContext, n as buildContext, o as checkKnowledgeFreshness, r as buildKnowledgeIndex, s as checkKnowledgeFreshnessFromIndex, t as buildArchitectureContext } from "./knowledge-DUiMUjEg.js";
+import { t as reviewSmrtProject } from "./review-smrt-project-ByEwPcor.js";
+import { realpathSync } from "node:fs";
 import { fileURLToPath, pathToFileURL } from "node:url";
 import { ProtocolError, ProtocolErrorCode, Server } from "@modelcontextprotocol/server";
 import { serveStdio } from "@modelcontextprotocol/server/stdio";
-import { access, readFile, readdir } from "node:fs/promises";
-//#region src/agent-skills.ts
-var AGENT_SKILLS = [{
-	name: "smrt-code-review",
-	description: "Harness-agnostic downstream SMRT code review workflow using smrt-dev-mcp deterministic context and prompt bundles.",
-	path: "skills/smrt-code-review/SKILL.md",
-	skillFile: "skills/smrt-code-review/SKILL.md",
-	references: ["skills/smrt-code-review/references/review-output.md"]
-}];
-function listAgentSkills() {
-	return AGENT_SKILLS.map(({ skillFile: _skillFile, ...skill }) => skill);
-}
-function getAgentSkill(options) {
-	const skill = AGENT_SKILLS.find((item) => item.name === options.name);
-	if (!skill) throw new Error(`Unknown agent skill: ${options.name}`);
-	return {
-		name: skill.name,
-		description: skill.description,
-		path: skill.path,
-		references: skill.references,
-		skillMarkdown: readPackageFile(skill.skillFile),
-		referenceFiles: options.includeReferences === false ? [] : skill.references.map((path) => ({
-			path,
-			content: readPackageFile(path)
-		}))
-	};
-}
-function readPackageFile(relativePath) {
-	return readFileSync(join(resolvePackageRoot(), relativePath), "utf8");
-}
-function resolvePackageRoot() {
-	const packageRoot = dirname(dirname(fileURLToPath(import.meta.url)));
-	if (!existsSync(join(packageRoot, "package.json"))) throw new Error(`Unable to resolve smrt-dev-mcp package root from ${import.meta.url}`);
-	return packageRoot;
-}
-//#endregion
 //#region src/tools/generate-smrt-class.ts
 var TYPE_MAPPING = {
 	text: {
@@ -232,409 +197,6 @@ function compactObject(value) {
 	return Object.fromEntries(Object.entries(value).filter(([, entry]) => entry !== void 0));
 }
 //#endregion
-//#region src/tools/review-smrt-project.ts
-/**
-* Ecosystem-aware downstream project review.
-* Advisory only: scans manifests and source files, then reports alignment risks.
-*/
-var SOURCE_EXTENSIONS = /\.(tsx?|jsx?|svelte)$/;
-var SKIP_DIRS = /* @__PURE__ */ new Set([
-	"node_modules",
-	"dist",
-	"build",
-	".git",
-	".smrt",
-	".svelte-kit",
-	"coverage"
-]);
-var DEPENDENCY_SECTIONS = [
-	"dependencies",
-	"devDependencies",
-	"peerDependencies",
-	"optionalDependencies"
-];
-var SMRT_PACKAGE_PREFIX = "@happyvertical/smrt-";
-var HAPPYVERTICAL_PACKAGE_PREFIX = "@happyvertical/";
-async function reviewSmrtProject(args) {
-	const projectPath = resolve(args.directory ?? args.rootDir ?? process.cwd());
-	if (!await pathExists(projectPath)) return JSON.stringify({
-		projectPath,
-		packageCount: 0,
-		packages: [],
-		findings: [],
-		summary: {
-			high: 0,
-			medium: 0,
-			low: 0
-		},
-		diagnostics: [{
-			severity: "warning",
-			message: `Project directory does not exist: ${projectPath}`
-		}]
-	}, null, 2);
-	const packageContexts = await buildPackageContexts(projectPath);
-	const sourceFiles = await listSourceFiles(projectPath, packageContexts);
-	await attachSourceFiles(sourceFiles, packageContexts, projectPath);
-	const findings = limitFindings([
-		...findMissingHappyVerticalDependencies(packageContexts),
-		...findCustomManifestGeneration(sourceFiles, projectPath),
-		...findDirectStorageBypasses(sourceFiles, packageContexts, projectPath),
-		...findCustomHttpShells(sourceFiles, packageContexts, projectPath),
-		...findLocalAuthTenancy(sourceFiles, packageContexts, projectPath),
-		...findUiShellDrift(packageContexts, projectPath),
-		...findMissingManifestArtifacts(sourceFiles, packageContexts, projectPath)
-	], args.maxFindings);
-	const packages = packageContexts.map(packageInventory).sort((left, right) => left.path.localeCompare(right.path));
-	const summary = summarizeFindings(findings);
-	return JSON.stringify({
-		projectPath,
-		packageCount: packages.length,
-		packages,
-		findings: args.includeSourceEvidence === false ? findings.map(({ evidence: _evidence, ...finding }) => finding) : findings,
-		summary,
-		referenceChecks: [
-			"Prefer SMRT scanner/runtime manifests over custom manifest builders.",
-			"Prefer SvelteKit plus @happyvertical/smrt-svelte for app shells.",
-			"Prefer @happyvertical/sql and @happyvertical/files/assets/content over direct durable node:fs storage.",
-			"Prefer smrt-users, smrt-tenancy, and profile/audit packages over local static auth seams."
-		],
-		suggestedFollowUpIssues: findings.map((finding) => ({
-			title: finding.suggestedIssueTitle,
-			severity: finding.severity,
-			area: finding.area
-		}))
-	}, null, 2);
-}
-async function buildPackageContexts(projectPath) {
-	const packageJsonPaths = await listPackageJsonFiles(projectPath);
-	const contexts = await Promise.all(packageJsonPaths.map(async (packageJsonPath) => {
-		const json = JSON.parse(await readFile(packageJsonPath, "utf-8"));
-		const directory = dirname(packageJsonPath);
-		return {
-			directory,
-			relativePath: relative(projectPath, directory) || ".",
-			packageJsonPath,
-			json,
-			dependencies: collectDependencies(json),
-			scripts: isRecord$1(json.scripts) ? json.scripts : {},
-			imports: /* @__PURE__ */ new Map(),
-			sourceFiles: []
-		};
-	}));
-	if (contexts.length === 0) contexts.push({
-		directory: projectPath,
-		relativePath: ".",
-		packageJsonPath: join(projectPath, "package.json"),
-		json: {},
-		dependencies: /* @__PURE__ */ new Set(),
-		scripts: {},
-		imports: /* @__PURE__ */ new Map(),
-		sourceFiles: []
-	});
-	return contexts.sort((left, right) => left.directory.length - right.directory.length);
-}
-async function listPackageJsonFiles(projectPath) {
-	const files = [];
-	await visit(projectPath, async (filePath, entryName) => {
-		if (entryName === "package.json") files.push(filePath);
-	});
-	return files;
-}
-async function listSourceFiles(projectPath, packages) {
-	const files = [];
-	await visit(projectPath, async (filePath, entryName) => {
-		if (!SOURCE_EXTENSIONS.test(entryName)) return;
-		if (entryName.endsWith(".d.ts") || entryName.endsWith(".test.ts") || entryName.endsWith(".spec.ts")) return;
-		const packageDir = findOwningPackage(filePath, packages).directory;
-		const content = await readFile(filePath, "utf-8");
-		files.push({
-			path: filePath,
-			packageDir,
-			content
-		});
-	});
-	return files;
-}
-async function attachSourceFiles(sourceFiles, packages, projectPath) {
-	for (const sourceFile of sourceFiles) {
-		const owner = packages.find((pkg) => pkg.directory === sourceFile.packageDir);
-		if (!owner) continue;
-		owner.sourceFiles.push(sourceFile);
-		for (const importedPackage of extractImports(sourceFile.content)) {
-			if (!importedPackage.startsWith(HAPPYVERTICAL_PACKAGE_PREFIX)) continue;
-			const evidence = {
-				filePath: relative(projectPath, sourceFile.path),
-				line: lineNumber(sourceFile.content, importedPackage),
-				detail: `Imports ${importedPackage}`
-			};
-			const existing = owner.imports.get(importedPackage) ?? [];
-			existing.push(evidence);
-			owner.imports.set(importedPackage, existing);
-		}
-	}
-}
-function findMissingHappyVerticalDependencies(packages) {
-	return packages.flatMap((pkg) => {
-		const ownName = typeof pkg.json.name === "string" ? pkg.json.name : void 0;
-		const missing = Array.from(pkg.imports.keys()).filter((importedPackage) => importedPackage !== ownName && !pkg.dependencies.has(importedPackage));
-		if (missing.length === 0) return [];
-		return [{
-			severity: missing.some((name) => name.startsWith(SMRT_PACKAGE_PREFIX)) ? "high" : "medium",
-			area: "dependencies",
-			code: "missing-happyvertical-dependencies",
-			title: `${packageLabel(pkg)} imports HappyVertical packages that package.json does not declare`,
-			evidence: missing.flatMap((name) => pkg.imports.get(name) ?? []),
-			recommendation: "Declare every imported @happyvertical package in the owning package manifest so downstream installs and generated knowledge stay reproducible.",
-			suggestedIssueTitle: `Declare missing HappyVertical dependencies in ${packageLabel(pkg)}`
-		}];
-	});
-}
-function findCustomManifestGeneration(sourceFiles, projectPath) {
-	return sourceFiles.filter((file) => /manifest\.json/.test(file.content) && /objects\s*:/.test(file.content) && /\b(writeFile|writeFileSync)\b/.test(file.content) && !/@happyvertical\/smrt-scanner/.test(file.content)).map((file) => ({
-		severity: "high",
-		area: "manifest",
-		code: "custom-object-manifest-generation",
-		title: "Custom SMRT object manifest generation detected",
-		evidence: [{
-			filePath: relative(projectPath, file.path),
-			line: lineNumber(file.content, "manifest.json"),
-			detail: "Writes a manifest.json object inventory outside the SMRT scanner/runtime path."
-		}],
-		recommendation: "Use the SMRT scanner/runtime manifest path so defaults, relationships, schemas, tenant fields, and cross-package references match framework behavior.",
-		suggestedIssueTitle: "Replace custom object manifest generation with SMRT scanner/runtime manifest generation"
-	}));
-}
-function findDirectStorageBypasses(sourceFiles, packages, projectPath) {
-	return sourceFiles.flatMap((file) => {
-		const owner = findOwningPackage(file.path, packages);
-		const usesFs = /from\s+['"](?:node:fs|node:fs\/promises|fs|fs\/promises)['"]|require\(['"](?:node:fs|node:fs\/promises|fs|fs\/promises)['"]\)/.test(file.content);
-		const writesDurableData = /\b(writeFile|appendFile|mkdir|rm|rename)\b/.test(file.content) && /(\.json|data|storage|persist|cache|db)/i.test(file.content);
-		const usesDirectSql = /from\s+['"](?:better-sqlite3|sqlite3|pg|mysql2?|knex|drizzle-orm)['"]/.test(file.content);
-		if ((!usesFs || !writesDurableData) && !usesDirectSql) return [];
-		if (owner.dependencies.has("@happyvertical/sql") || owner.dependencies.has("@happyvertical/files") || owner.dependencies.has("@happyvertical/smrt-assets") || owner.dependencies.has("@happyvertical/smrt-content")) return [];
-		return [{
-			severity: "medium",
-			area: "storage",
-			code: "direct-storage-bypass",
-			title: `${packageLabel(owner)} appears to bypass HappyVertical storage packages`,
-			evidence: [{
-				filePath: relative(projectPath, file.path),
-				line: lineNumber(file.content, usesDirectSql ? "sqlite" : "writeFile"),
-				detail: usesDirectSql ? "Imports a direct SQL/storage library without @happyvertical/sql." : "Uses node:fs-style durable writes without @happyvertical/files/assets/content."
-			}],
-			recommendation: "Route durable data through @happyvertical/sql, @happyvertical/files, SMRT assets, or SMRT content unless this is explicitly build-only tooling.",
-			suggestedIssueTitle: `Review direct storage usage in ${packageLabel(owner)}`
-		}];
-	});
-}
-function findCustomHttpShells(sourceFiles, packages, projectPath) {
-	const evidenceByPackage = /* @__PURE__ */ new Map();
-	for (const pkg of packages) {
-		if (pkg.dependencies.has("@sveltejs/kit")) continue;
-		const routerDependencies = [
-			"express",
-			"fastify",
-			"hono",
-			"koa"
-		].filter((dep) => pkg.dependencies.has(dep));
-		if (routerDependencies.length === 0) continue;
-		appendEvidence(evidenceByPackage, pkg, {
-			filePath: relative(projectPath, pkg.packageJsonPath),
-			detail: `Declares custom router package(s): ${routerDependencies.join(", ")}.`
-		});
-	}
-	for (const file of sourceFiles) {
-		const owner = findOwningPackage(file.path, packages);
-		if (owner.dependencies.has("@sveltejs/kit")) continue;
-		if (!/from\s+['"](?:node:http|http|node:https|https)['"]|createServer\s*\(/.test(file.content)) continue;
-		appendEvidence(evidenceByPackage, owner, {
-			filePath: relative(projectPath, file.path),
-			line: lineNumber(file.content, "createServer"),
-			detail: "Custom HTTP routing found without the SvelteKit/SMRT app-shell dependency pattern."
-		});
-	}
-	return Array.from(evidenceByPackage.entries()).map(([owner, evidence]) => ({
-		severity: "medium",
-		area: "api-shell",
-		code: "custom-http-shell",
-		title: `${packageLabel(owner)} uses a custom HTTP shell`,
-		evidence,
-		recommendation: "Compare the app shell against the Anytown/Ergot SvelteKit + SMRT shell pattern before adding custom HTTP infrastructure.",
-		suggestedIssueTitle: `Align ${packageLabel(owner)} app shell with SMRT/SvelteKit conventions`
-	}));
-}
-function appendEvidence(evidenceByPackage, pkg, evidence) {
-	const existing = evidenceByPackage.get(pkg);
-	if (existing) {
-		existing.push(evidence);
-		return;
-	}
-	evidenceByPackage.set(pkg, [evidence]);
-}
-function findLocalAuthTenancy(sourceFiles, packages, projectPath) {
-	return sourceFiles.flatMap((file) => {
-		const owner = findOwningPackage(file.path, packages);
-		const pathSignal = /(auth|tenant|audit|session|rbac|user)/i.test(file.path);
-		const codeSignal = /\b(tenantId|tenant|role|permission|session|auditLog|apiKey)\b/.test(file.content);
-		if (!pathSignal || !codeSignal) return [];
-		if (owner.dependencies.has("@happyvertical/smrt-users") || owner.dependencies.has("@happyvertical/smrt-tenancy") || owner.dependencies.has("@happyvertical/smrt-profiles")) return [];
-		return [{
-			severity: "medium",
-			area: "auth-tenancy",
-			code: "local-auth-tenancy",
-			title: `${packageLabel(owner)} contains local auth/tenancy/audit logic`,
-			evidence: [{
-				filePath: relative(projectPath, file.path),
-				line: lineNumber(file.content, "tenant"),
-				detail: "Auth, tenancy, session, role, or audit terminology appears without smrt-users/smrt-tenancy/smrt-profiles dependencies."
-			}],
-			recommendation: "Add explicit adapters to smrt-users, smrt-tenancy, and profile/audit models or document why this local implementation is intentionally isolated.",
-			suggestedIssueTitle: `Review auth and tenancy adapters in ${packageLabel(owner)}`
-		}];
-	});
-}
-function findUiShellDrift(packages, projectPath) {
-	return packages.flatMap((pkg) => {
-		if (!(pkg.sourceFiles.some((file) => file.path.endsWith(".svelte")) || /(?:web|ui|app|site|frontend)/i.test(packageLabel(pkg)) || pkg.dependencies.has("svelte") || pkg.dependencies.has("vite"))) return [];
-		if (pkg.dependencies.has("@happyvertical/smrt-svelte")) return [];
-		return [{
-			severity: "low",
-			area: "ui-shell",
-			code: "missing-smrt-svelte-shell",
-			title: `${packageLabel(pkg)} looks like UI work without @happyvertical/smrt-svelte`,
-			evidence: [{
-				filePath: relative(projectPath, pkg.packageJsonPath),
-				detail: "UI-facing package does not declare @happyvertical/smrt-svelte."
-			}],
-			recommendation: "Use @happyvertical/smrt-svelte and the SvelteKit shell pattern for downstream app UI unless this package is intentionally framework-agnostic.",
-			suggestedIssueTitle: `Check SMRT Svelte shell alignment for ${packageLabel(pkg)}`
-		}];
-	});
-}
-function findMissingManifestArtifacts(sourceFiles, packages, projectPath) {
-	return packages.flatMap((pkg) => {
-		if (!pkg.sourceFiles.some((file) => /@smrt\s*\(/.test(file.content))) return [];
-		if (sourceFiles.some((file) => file.packageDir === pkg.directory && /@happyvertical\/smrt-scanner/.test(file.content)) || pathExistsSyncHint(join(pkg.directory, ".smrt", "manifest.json")) || pathExistsSyncHint(join(pkg.directory, "dist", "manifest.json"))) return [];
-		return [{
-			severity: "low",
-			area: "manifest",
-			code: "missing-generated-manifest-artifact",
-			title: `${packageLabel(pkg)} has @smrt objects but no generated manifest artifact was found`,
-			evidence: [{
-				filePath: relative(projectPath, pkg.packageJsonPath),
-				detail: "No .smrt/manifest.json or dist/manifest.json was visible during review."
-			}],
-			recommendation: "Run the package build/test manifest generation path and verify it uses the SMRT scanner/runtime manifest pipeline.",
-			suggestedIssueTitle: `Verify SMRT manifest generation for ${packageLabel(pkg)}`
-		}];
-	});
-}
-async function visit(dir, onFile) {
-	let entries;
-	try {
-		entries = await readdir(dir, { withFileTypes: true });
-	} catch {
-		return;
-	}
-	for (const entry of entries) {
-		const fullPath = join(dir, entry.name);
-		if (entry.isDirectory()) {
-			if (SKIP_DIRS.has(entry.name)) continue;
-			await visit(fullPath, onFile);
-			continue;
-		}
-		if (entry.isFile()) await onFile(fullPath, entry.name);
-	}
-}
-function collectDependencies(packageJson) {
-	const dependencies = /* @__PURE__ */ new Set();
-	for (const sectionName of DEPENDENCY_SECTIONS) {
-		const section = packageJson[sectionName];
-		if (!isRecord$1(section)) continue;
-		for (const dependencyName of Object.keys(section)) dependencies.add(dependencyName);
-	}
-	return dependencies;
-}
-function extractImports(content) {
-	const imports = /* @__PURE__ */ new Set();
-	for (const pattern of [
-		/(?:import|export)\s+(?:type\s+)?(?:[^'"]+\s+from\s+)?['"]([^'"]+)['"]/g,
-		/\bimport\s*\(\s*['"]([^'"]+)['"]\s*\)/g,
-		/\brequire\s*\(\s*['"]([^'"]+)['"]\s*\)/g
-	]) for (const match of content.matchAll(pattern)) {
-		const imported = normalizePackageImport(match[1]);
-		if (imported) imports.add(imported);
-	}
-	return Array.from(imports);
-}
-function normalizePackageImport(value) {
-	if (!value || value.startsWith(".") || value.startsWith("/")) return void 0;
-	if (value.startsWith("@")) {
-		const [scope, name] = value.split("/");
-		return scope && name ? `${scope}/${name}` : value;
-	}
-	return value.split("/")[0];
-}
-function findOwningPackage(filePath, packages) {
-	const normalized = resolve(filePath);
-	return packages.filter((pkg) => normalized === pkg.directory || normalized.startsWith(`${pkg.directory}${sep}`)).sort((left, right) => right.directory.length - left.directory.length)[0] ?? packages[0];
-}
-function packageInventory(pkg) {
-	const declaredHappyVerticalDependencies = Array.from(pkg.dependencies).filter((dependency) => dependency.startsWith(HAPPYVERTICAL_PACKAGE_PREFIX)).sort();
-	const importedHappyVerticalPackages = Array.from(pkg.imports.keys()).sort();
-	const ownName = typeof pkg.json.name === "string" ? pkg.json.name : void 0;
-	return {
-		name: packageLabel(pkg),
-		path: pkg.relativePath,
-		private: typeof pkg.json.private === "boolean" ? pkg.json.private : void 0,
-		scripts: Object.keys(pkg.scripts).sort(),
-		declaredHappyVerticalDependencies,
-		importedHappyVerticalPackages,
-		missingHappyVerticalDependencies: importedHappyVerticalPackages.filter((name) => name !== ownName && !pkg.dependencies.has(name)),
-		hasSvelteKit: pkg.dependencies.has("@sveltejs/kit"),
-		hasSmrtSvelte: pkg.dependencies.has("@happyvertical/smrt-svelte")
-	};
-}
-function summarizeFindings(findings) {
-	return findings.reduce((summary, finding) => {
-		summary[finding.severity]++;
-		return summary;
-	}, {
-		high: 0,
-		medium: 0,
-		low: 0
-	});
-}
-function limitFindings(findings, maxFindings) {
-	const sorted = findings.sort((left, right) => severityRank(left.severity) - severityRank(right.severity) || left.area.localeCompare(right.area) || left.title.localeCompare(right.title));
-	return maxFindings && maxFindings > 0 ? sorted.slice(0, maxFindings) : sorted;
-}
-function severityRank(severity) {
-	return severity === "high" ? 0 : severity === "medium" ? 1 : 2;
-}
-function packageLabel(pkg) {
-	return typeof pkg.json.name === "string" ? pkg.json.name : pkg.relativePath;
-}
-function lineNumber(content, needle) {
-	const index = content.indexOf(needle);
-	if (index < 0) return void 0;
-	return content.slice(0, index).split("\n").length;
-}
-function isRecord$1(value) {
-	return !!value && typeof value === "object" && !Array.isArray(value);
-}
-async function pathExists(path) {
-	try {
-		await access(path);
-		return true;
-	} catch {
-		return false;
-	}
-}
-function pathExistsSyncHint(path) {
-	return existsSync(path);
-}
-//#endregion
 //#region src/index.ts
 /**
 * SMRT Development MCP Server
@@ -1227,7 +789,13 @@ async function mainHttp(cli) {
 	process.on("SIGINT", shutdown);
 	process.on("SIGTERM", shutdown);
 }
-if (isEntrypoint()) {
+if (isEntrypoint()) if (process.argv[2] === "review") import("./review-cli-DJIWUlFp.js").then(({ runReviewCli }) => runReviewCli(process.argv.slice(3))).then((code) => {
+	process.exitCode = code;
+}).catch((error) => {
+	console.error(`[${SERVER_NAME}] review failed:`, error);
+	process.exit(1);
+});
+else {
 	const cli = parseHttpCliArgs(process.argv.slice(2));
 	(cli.http ? mainHttp(cli) : main()).catch((error) => {
 		console.error(`[${SERVER_NAME}] Fatal error:`, error);