@happyvertical/smrt-core 0.47.0 → 0.47.2

package/dist/vite-plugin/index.js

@@ -1,6 +1,6 @@
 import { DETERMINISTIC_GENERATED_AT } from "../scanner/types.js";
 import { findCliApiCoherenceViolations, generateSvelteKitRoutes, methodNameToKebab, resolveApiActionRouteConfig, resolveApiActionSet, validateCliIncludeAgainstApi } from "./sveltekit-generator.js";
-import { buildWebCollectionDefinition, buildWebMcpToolDefinitions, buildWebToolDescriptors, computeWebManifestHash, selectWebCollectionEntries } from "./web-collections.js";
+import { buildWebCollectionDefinition, buildWebMcpToolDefinitions, buildWebToolDescriptors, compareText, computeWebManifestHash, selectWebCollectionEntries } from "./web-collections.js";
 import { buildDomainKnowledgeManifest } from "../knowledge.js";
 import { importWorkspaceModule } from "../utils/import-workspace-module.js";
 import { discoverSmrtPackages } from "../manifest/discover-smrt-packages.js";
@@ -68,6 +68,70 @@ function reportAgentSurfaceDiagnostics(surface) {
 		console.warn(`  ${where} — ${diagnostic.message}`);
 	}
 }
+/**
+* Compare the emitted intents against the tool names this build will really
+* register, and project the result into the knowledge-artifact shape (#2725).
+*
+* The rule lives in the scanner, which owns the tool-name derivation. The INPUT
+* lives here, because only core resolves the exposure policy:
+* {@link buildWebMcpToolDefinitions} is the function that emits the runtime
+* `webMcpToolDefinitions`, so its output is the set that actually registers.
+* Handing the scanner every verb a class COULD expose would report collisions
+* with tools nobody mounts.
+*
+* The check is passed in rather than imported: core reaches the scanner through
+* {@link importScanner}, which resolves src or dist depending on how core itself
+* was built, and a static import here would defeat that.
+*
+* `declaredBy` is `Class.action` — the same identity `smrt doctor` prints beside
+* a generated model tool — so a reader can find the other side of the collision
+* without cross-referencing anything.
+*/
+function collectAgentSurfaceToolNameCollisions(input) {
+	return input.checkAgentSurfaceToolNames(input.surface, {
+		generatedToolNames: buildWebMcpToolDefinitions(input.manifest, { kebabRoutes: input.kebabRoutes ?? false }).map((definition) => ({
+			name: definition.name,
+			declaredBy: `${definition.className}.${definition.action}`
+		})),
+		...input.uiToolPrefixes ? { uiToolPrefixes: input.uiToolPrefixes } : {}
+	}).map(({ filePath, ...rest }) => ({
+		...rest,
+		sourceFile: filePath
+	}));
+}
+/**
+* Print every emitted intent whose WebMCP tool name something else also claims
+* (#2725).
+*
+* "Also claims", not "is already taken", for the same reason `smrt doctor`'s
+* header says so: a build cannot see the provider's WebMCP `namespace` or
+* `effects` policy, either of which separates the pair outright. This line runs
+* on every build and every watch rebuild, so it is the surface an author sees
+* most; each message beneath states the condition, and the header must not
+* assert past it.
+*
+* Separate from {@link reportAgentSurfaceDiagnostics} because it says
+* something different: those declarations were EXCLUDED, these are emitted and
+* merely at risk. Folding them into that header would tell an author their
+* intent had been dropped when it had not.
+*/
+function reportAgentSurfaceToolNameCollisions(diagnostics) {
+	if (diagnostics.length === 0) return;
+	console.warn(`[smrt] ⚠️  ${diagnostics.length} declared intent(s) derive a WebMCP tool name something else also claims:`);
+	for (const diagnostic of diagnostics) {
+		const where = diagnostic.line ? `${diagnostic.sourceFile}:${diagnostic.line}` : diagnostic.sourceFile;
+		console.warn(`  ${where} — ${diagnostic.message}`);
+	}
+}
+/**
+* Order the emitted diagnostics the way the scanner's own merge does, so
+* appending the manifest-derived collisions cannot make the artifact depend on
+* when they were computed.
+*/
+function sortKnowledgeAgentSurfaceDiagnostics(diagnostics) {
+	const compare = (a, b) => a < b ? -1 : a > b ? 1 : 0;
+	return [...diagnostics].sort((a, b) => compare(a.sourceFile, b.sourceFile) || (a.line ?? 0) - (b.line ?? 0) || (a.column ?? 0) - (b.column ?? 0) || compare(a.code, b.code) || compare(a.message, b.message));
+}
 async function importScanner() {
 	return importWorkspaceModule({
 		packageName: "@happyvertical/smrt-scanner",
@@ -578,7 +642,8 @@ function smrtPlugin(options = {}) {
 	async function scanWithOxc(rootDir) {
 		const startTime = performance.now();
 		try {
-			const { OxcScanner, ManifestAdapter } = await importScanner();
+			const scannerModule = await importScanner();
+			const { OxcScanner, ManifestAdapter } = scannerModule;
 			console.log(`[smrt] Using experimental OXC scanner for faster builds`);
 			const safeExclude = [...exclude || [], "**/*.svelte"];
 			const { results, resolved } = await new OxcScanner({
@@ -626,6 +691,20 @@ function smrtPlugin(options = {}) {
 				packageName,
 				packageJson
 			});
+			if (agentSurface && results.agentSurface) try {
+				const collisions = collectAgentSurfaceToolNameCollisions({
+					surface: results.agentSurface,
+					manifest: newManifest,
+					checkAgentSurfaceToolNames: scannerModule.checkAgentSurfaceToolNames,
+					kebabRoutes: svelteKit.kebabRoutes ?? false
+				});
+				if (collisions.length > 0) {
+					reportAgentSurfaceToolNameCollisions(collisions);
+					agentSurface.diagnostics = sortKnowledgeAgentSurfaceDiagnostics([...agentSurface.diagnostics, ...collisions]);
+				}
+			} catch (error) {
+				console.warn("[smrt] Skipped the agent-surface tool-name collision check:", error);
+			}
 			const elapsed = performance.now() - startTime;
 			const objectCount = Object.keys(newManifest.objects).length;
 			if (objectCount > 0) {
@@ -809,7 +888,8 @@ export function createMCPServer(options = {}) {
 */
 function generateClientModeTypes(manifest) {
 	const typeDefinitions = [];
-	for (const objectMeta of Object.values(manifest.objects)) {
+	const sortedClientModeObjects = Object.entries(manifest.objects).sort(([leftKey, left], [rightKey, right]) => compareText(left.qualifiedName || leftKey, right.qualifiedName || rightKey) || compareText(leftKey, rightKey)).map(([, obj]) => obj);
+	for (const objectMeta of sortedClientModeObjects) {
 		const interfaceName = objectMeta.className;
 		const fields = objectMeta.fields || {};
 		const propertyLines = [];
@@ -918,7 +998,7 @@ async function generateTypeDeclarationFile(manifest, projectRoot, typeDeclaratio
 		const declarationsDir = join(projectRoot, typeDeclarationsPath);
 		const declarationsFile = join(declarationsDir, "virtual-modules.d.ts");
 		if (!existsSync(declarationsDir)) mkdirSync(declarationsDir, { recursive: true });
-		const objectInterfaces = Object.entries(manifest.objects).map(([_name, obj]) => {
+		const objectInterfaces = Object.entries(manifest.objects).sort(([leftKey, left], [rightKey, right]) => compareText(left.qualifiedName || leftKey, right.qualifiedName || rightKey) || compareText(leftKey, rightKey)).map(([_name, obj]) => {
 			return `  export interface ${`${obj.className}Data`} {
     id?: string;
 ${Object.entries(obj.fields).map(([fieldName, field]) => {
@@ -1296,6 +1376,6 @@ async function loadDefaultUI() {
 	return getDefaultUIModule();
 }
 //#endregion
-export { buildWebMcpToolDefinitions, findCliApiCoherenceViolations, generateInlineRegisterModule, generateSvelteKitRoutes, generateTypeDeclarationFile, isRegisterShimModuleId, loadVerifiedSmrtGenerationSnapshot, methodNameToKebab, resolveApiActionRouteConfig, resolveApiActionSet, serializeSmrtGenerationSnapshot, sha256SmrtGenerationSnapshot, smrtPlugin, toKnowledgeAgentSurface, validateCliIncludeAgainstApi };
+export { buildWebMcpToolDefinitions, collectAgentSurfaceToolNameCollisions, findCliApiCoherenceViolations, generateInlineRegisterModule, generateSvelteKitRoutes, generateTypeDeclarationFile, isRegisterShimModuleId, loadVerifiedSmrtGenerationSnapshot, methodNameToKebab, resolveApiActionRouteConfig, resolveApiActionSet, serializeSmrtGenerationSnapshot, sha256SmrtGenerationSnapshot, smrtPlugin, toKnowledgeAgentSurface, validateCliIncludeAgainstApi };
 
 //# sourceMappingURL=index.js.map