@happyvertical/smrt-core 0.45.2 → 0.46.0

package/dist/vite-plugin/sveltekit-generator.js

@@ -1,5 +1,5 @@
 import { MAX_LIST_LIMIT, buildDefaultListOrderBy } from "../query-bounds.js";
-import { resolveCustomActionMetadata, resolveCustomActionNames } from "../generators/custom-action.js";
+import { CRUD_OPERATIONS, isCrudOperation, resolveCustomActionMetadata, resolveCustomActionNames } from "../generators/custom-action.js";
 import { isFrameworkBaseClass } from "../registry/framework-base-classes.js";
 import { generateConditionalGetRouteHelper } from "../generators/conditional-get.js";
 import { AUTO_GENERATED_ROUTE_HEADER } from "./route-header.js";
@@ -16,13 +16,6 @@ import { isAbsolute, join, relative, sep } from "node:path";
 * Generates real TypeScript files in src/routes/api/ based on discovered SMRT objects
 */
 var BIOME_LINE_WIDTH = 80;
-var STANDARD_API_ACTIONS = [
-	"list",
-	"get",
-	"create",
-	"update",
-	"delete"
-];
 var GITIGNORE_MANAGED_BLOCK_START = "# BEGIN SMRT auto-generated routes (Vite plugin)";
 var GITIGNORE_MANAGED_BLOCK_END = "# END SMRT auto-generated routes (Vite plugin)";
 var LEGACY_GITIGNORE_HEADER = "# SMRT auto-generated routes (from Vite plugin)";
@@ -1169,7 +1162,7 @@ async function generateRoutesForObject(projectRoot, className, objectDef, manife
 		const itemRoute = generateItemRouteTemplate(projectRoot, className, objectDef, manifest, includedActions, options, join(routeDir, "[id]"));
 		generatedRoutePaths.push(writeRoute(join(routeDir, "[id]"), "+server.ts", itemRoute));
 	}
-	const customActions = Object.entries(objectDef.methods).filter(([name, method]) => !STANDARD_API_ACTIONS.includes(name) && method.isPublic && shouldIncludeInApi(name, apiConfig));
+	const customActions = Object.entries(objectDef.methods).filter(([name, method]) => !isCrudOperation(name) && method.isPublic && shouldIncludeInApi(name, apiConfig));
 	const actionSpecs = [];
 	for (const [actionName, actionDef] of customActions) {
 		const routeConfig = resolveApiActionRouteConfig(actionName, actionDef, apiConfig, { kebabRoutes: options.kebabRoutes });
@@ -1207,7 +1200,7 @@ async function generateCollectionRoutesForObject(projectRoot, className, objectD
 	const routeDir = join(projectRoot, options.routesDir, objectDef.collection);
 	const lookupClassName = findItemClassRegistryKey(className, objectDef, manifest);
 	const lookupObjectDef = findObjectDefByRegistryKey(manifest, lookupClassName);
-	const customActions = Object.entries(objectDef.methods).filter(([name, method]) => !STANDARD_API_ACTIONS.includes(name) && method.isPublic && shouldIncludeInApi(name, apiConfig));
+	const customActions = Object.entries(objectDef.methods).filter(([name, method]) => !isCrudOperation(name) && method.isPublic && shouldIncludeInApi(name, apiConfig));
 	if (customActions.length === 0) return generatedRoutePaths;
 	const actionSpecs = [];
 	for (const [actionName, actionDef] of customActions) {
@@ -1242,10 +1235,10 @@ async function generateCollectionRoutesForObject(projectRoot, className, objectD
 */
 function resolveStandardCrudActions(apiConfig) {
 	if (apiConfig === false) return [];
-	if (apiConfig === true || apiConfig === void 0) return [...STANDARD_API_ACTIONS];
-	if (typeof apiConfig !== "object") return [...STANDARD_API_ACTIONS];
+	if (apiConfig === true || apiConfig === void 0) return [...CRUD_OPERATIONS];
+	if (typeof apiConfig !== "object" || apiConfig === null) return [...CRUD_OPERATIONS];
 	const config = apiConfig;
-	let crud = config.include ? config.include.filter((a) => STANDARD_API_ACTIONS.includes(a)) : [...STANDARD_API_ACTIONS];
+	let crud = Array.isArray(config.include) ? config.include.filter((a) => isCrudOperation(a)) : [...CRUD_OPERATIONS];
 	if (Array.isArray(config.exclude)) {
 		const exclude = config.exclude;
 		crud = crud.filter((a) => !exclude.includes(a));
@@ -1282,7 +1275,7 @@ function resolveApiActionSet(objectDef, manifest) {
 	const objectIsCollectionClass = manifest ? isCollectionManifestClass(manifest, objectDef) : isCollectionClass(objectDef);
 	const actions = objectIsCollectionClass ? /* @__PURE__ */ new Set() : new Set(resolveStandardCrudActions(apiConfig));
 	for (const [name, method] of Object.entries(objectDef.methods || {})) {
-		if (STANDARD_API_ACTIONS.includes(name)) continue;
+		if (isCrudOperation(name)) continue;
 		if (!method.isPublic) continue;
 		if (!shouldIncludeInApi(name, apiConfig)) continue;
 		const scope = resolveCustomActionMetadata({
@@ -1317,9 +1310,11 @@ function resolveApiActionSet(objectDef, manifest) {
 *
 * **Bare `cli: true`/`cli: {}`** (#2638, the new case this lint now
 * inspects): every public custom method minus exclude, exactly the "every
-* public method minus exclude" resolution `CLIGenerator.listCommands()`
-* already applies (via `resolveCustomActionNames`, reused not
-* reimplemented) -- lifecycle methods excluded, same as everywhere else.
+* public method minus exclude" resolution this function shares with
+* `packages/core/src/generators/custom-action.ts`'s `resolveCustomActionNames`
+* -- lifecycle methods excluded, same as everywhere else. (Pre-#2664, core's
+* now-retired `CLIGenerator.listCommands()` applied the same resolution via
+* that helper too.)
 * CRUD verbs are NOT checked in this branch: a class that closes its API
 * entirely (`api: false`) while keeping a default-open, CLI/MCP-only admin
 * surface (`cli: true`/omitted) is a common, intentional combination (see
@@ -1332,13 +1327,13 @@ function resolveApiActionSet(objectDef, manifest) {
 function resolveCliActionSet(objectDef) {
 	const cliConfig = objectDef.decoratorConfig?.cli;
 	if (cliConfig === false) return /* @__PURE__ */ new Set();
-	const included = typeof cliConfig === "object" ? cliConfig.include : void 0;
-	const excluded = typeof cliConfig === "object" && Array.isArray(cliConfig.exclude) ? cliConfig.exclude : [];
+	const included = typeof cliConfig === "object" && cliConfig !== null ? cliConfig.include : void 0;
+	const excluded = typeof cliConfig === "object" && cliConfig !== null && Array.isArray(cliConfig.exclude) ? cliConfig.exclude : [];
 	if (included) return new Set(included.filter((cmd) => !excluded.includes(cmd)));
 	return resolveCustomActionNames(Object.entries(objectDef.methods || {}), {
 		include: void 0,
 		exclude: excluded
-	}, STANDARD_API_ACTIONS);
+	}, CRUD_OPERATIONS);
 }
 /**
 * Inspect a manifest and return classes whose effective CLI command set —
@@ -1356,7 +1351,7 @@ function findCliApiCoherenceViolations(manifest) {
 	for (const [className, objectDef] of Object.entries(manifest.objects)) {
 		const cliConfig = objectDef.decoratorConfig?.cli;
 		if (cliConfig === false) continue;
-		if (typeof cliConfig === "object" && cliConfig.skipApiCheck) continue;
+		if (typeof cliConfig === "object" && cliConfig !== null && cliConfig.skipApiCheck) continue;
 		const effectiveCliCommands = resolveCliActionSet(objectDef);
 		if (effectiveCliCommands.size === 0) continue;
 		const apiActionSet = resolveApiActionSet(objectDef, manifest);
@@ -1377,8 +1372,9 @@ function findCliApiCoherenceViolations(manifest) {
 * This is deliberately narrower than `findCliApiCoherenceViolations` above.
 * That function is now fully correct for the broader `cli: true`/`cli: {}`
 * default surface too (#2638: same "every public method minus exclude"
-* resolution `listCommands()` uses, so a bare `cli: true` is inspected the
-* same as an explicit `include`). But `smrtPlugin()`'s default
+* resolution core's now-retired `CLIGenerator.listCommands()` used (#2664),
+* so a bare `cli: true` is inspected the same as an explicit `include`).
+* But `smrtPlugin()`'s default
 * `validateCliApiCoherence: true` calls this THROWING gate unconditionally
 * from every consuming package's own build (`configResolved`,
 * `vite-plugin/index.ts`) -- and a full-monorepo build during #2638
@@ -1400,7 +1396,7 @@ function findCliApiCoherenceViolations(manifest) {
 function validateCliIncludeAgainstApi(manifest) {
 	const violations = findCliApiCoherenceViolations(manifest).filter(({ className }) => {
 		const cliConfig = manifest.objects[className]?.decoratorConfig?.cli;
-		return typeof cliConfig === "object" && Array.isArray(cliConfig.include) && cliConfig.include.length > 0;
+		return typeof cliConfig === "object" && cliConfig !== null && Array.isArray(cliConfig.include) && cliConfig.include.length > 0;
 	});
 	if (violations.length === 0) return;
 	const messages = violations.flatMap(({ className, unreachable }) => unreachable.map((action) => `[smrt] ${className}.${action} is exposed as a CLI command but is not exposed via the api.\n  Either:\n    - Add '${action}' to api.include, or\n    - Remove '${action}' from cli.include / add it to cli.exclude.\n  The CLI invokes methods over HTTP; methods without API routes are unreachable.\n  If this CLI is intentionally invoked in-process (no HTTP), set\n  \`cli: { skipApiCheck: true }\` on the @smrt() decorator to acknowledge.`));