@happyvertical/smrt-core 0.44.0 → 0.45.0

package/dist/vite-plugin/sveltekit-generator.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"sveltekit-generator.d.ts","sourceRoot":"","sources":["../../src/vite-plugin/sveltekit-generator.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAWH,OAAO,KAAK,EAAE,qBAAqB,EAAE,MAAM,2BAA2B,CAAC;AAQvE,OAAO,KAAK,EAGV,aAAa,EAEd,MAAM,sBAAsB,CAAC;AAC9B,OAAO,KAAK,EAEV,qBAAqB,EACrB,mBAAmB,EACpB,MAAM,kBAAkB,CAAC;AAY1B,MAAM,WAAW,gBAAgB;IAC/B,OAAO,EAAE,OAAO,CAAC;IACjB,SAAS,EAAE,MAAM,CAAC;IAClB,UAAU,EAAE,MAAM,CAAC;IACnB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB;;;;OAIG;IACH,WAAW,CAAC,EAAE,OAAO,CAAC;IACtB,iFAAiF;IACjF,SAAS,CAAC,EAAE,qBAAqB,CAAC;IAClC;;;OAGG;IACH,YAAY,CAAC,EAAE;QAAE,OAAO,CAAC,EAAE,OAAO,CAAA;KAAE,CAAC;IACrC;;;;;;;;;;;;;;OAcG;IACH,WAAW,CAAC,EAAE;QACZ,OAAO,CAAC,EAAE,OAAO,CAAC;QAClB,cAAc,CAAC,EAAE,MAAM,CAAC;QACxB,cAAc,CAAC,EAAE,MAAM,EAAE,CAAC;QAC1B,gBAAgB,CAAC,EAAE,OAAO,CAAC;KAC5B,CAAC;CACH;AAYD,MAAM,WAAW,4BAA4B;IAC3C,KAAK,EAAE,MAAM,GAAG,YAAY,CAAC;IAC7B,MAAM,EAAE,aAAa,CAAC;IACtB,YAAY,EAAE,MAAM,EAAE,CAAC;IACvB,cAAc,EAAE,MAAM,EAAE,CAAC;CAC1B;AAqxBD;;;;;;;;;;;;GAYG;AACH,wBAAgB,iBAAiB,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM,CAKtD;AA+BD,wBAAgB,2BAA2B,CACzC,UAAU,EAAE,MAAM,EAClB,SAAS,EAAE;IAAE,QAAQ,CAAC,EAAE,OAAO,CAAA;CAAE,EACjC,SAAS,EAAE,OAAO,EAClB,YAAY,GAAE;IAAE,WAAW,CAAC,EAAE,OAAO,CAAA;CAAO,EAC5C,YAAY,GAAE,MAAM,GAAG,YAEb,GACT,4BAA4B,CAwB9B;AAiUD;;GAEG;AACH,wBAAsB,uBAAuB,CAC3C,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,mBAAmB,EAC7B,OAAO,EAAE,gBAAgB,GACxB,OAAO,CAAC,IAAI,CAAC,CAuFf;AAy0BD;;;;;GAKG;AACH,wBAAgB,mBAAmB,CACjC,SAAS,EAAE,qBAAqB,EAChC,QAAQ,CAAC,EAAE,mBAAmB,GAC7B,GAAG,CAAC,MAAM,CAAC,CA6Cb;AAED;;GAEG;AACH,MAAM,WAAW,wBAAwB;IACvC,SAAS,EAAE,MAAM,CAAC;IAClB,WAAW,EAAE,MAAM,EAAE,CAAC;CACvB;AAED;;;;;;;GAOG;AACH,wBAAgB,6BAA6B,CAC3C,QAAQ,EAAE,mBAAmB,GAC5B,wBAAwB,EAAE,CA+B5B;AAED;;;;;GAKG;AACH,wBAAgB,4BAA4B,CAC1C,QAAQ,EAAE,mBAAmB,GAC5B,IAAI,CAkBN"}
+{"version":3,"file":"sveltekit-generator.d.ts","sourceRoot":"","sources":["../../src/vite-plugin/sveltekit-generator.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAWH,OAAO,KAAK,EAAE,qBAAqB,EAAE,MAAM,2BAA2B,CAAC;AAYvE,OAAO,KAAK,EAGV,aAAa,EAEd,MAAM,sBAAsB,CAAC;AAC9B,OAAO,KAAK,EAEV,qBAAqB,EACrB,mBAAmB,EACpB,MAAM,kBAAkB,CAAC;AAY1B,MAAM,WAAW,gBAAgB;IAC/B,OAAO,EAAE,OAAO,CAAC;IACjB,SAAS,EAAE,MAAM,CAAC;IAClB,UAAU,EAAE,MAAM,CAAC;IACnB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB;;;;OAIG;IACH,WAAW,CAAC,EAAE,OAAO,CAAC;IACtB,iFAAiF;IACjF,SAAS,CAAC,EAAE,qBAAqB,CAAC;IAClC;;;OAGG;IACH,YAAY,CAAC,EAAE;QAAE,OAAO,CAAC,EAAE,OAAO,CAAA;KAAE,CAAC;IACrC;;;;;;;;;;;;;;OAcG;IACH,WAAW,CAAC,EAAE;QACZ,OAAO,CAAC,EAAE,OAAO,CAAC;QAClB,cAAc,CAAC,EAAE,MAAM,CAAC;QACxB,cAAc,CAAC,EAAE,MAAM,EAAE,CAAC;QAC1B,gBAAgB,CAAC,EAAE,OAAO,CAAC;KAC5B,CAAC;CACH;AAYD,MAAM,WAAW,4BAA4B;IAC3C,KAAK,EAAE,MAAM,GAAG,YAAY,CAAC;IAC7B,MAAM,EAAE,aAAa,CAAC;IACtB,YAAY,EAAE,MAAM,EAAE,CAAC;IACvB,cAAc,EAAE,MAAM,EAAE,CAAC;CAC1B;AAqxBD;;;;;;;;;;;;GAYG;AACH,wBAAgB,iBAAiB,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM,CAKtD;AA+BD,wBAAgB,2BAA2B,CACzC,UAAU,EAAE,MAAM,EAClB,SAAS,EAAE;IAAE,QAAQ,CAAC,EAAE,OAAO,CAAA;CAAE,EACjC,SAAS,EAAE,OAAO,EAClB,YAAY,GAAE;IAAE,WAAW,CAAC,EAAE,OAAO,CAAA;CAAO,EAC5C,YAAY,GAAE,MAAM,GAAG,YAEb,GACT,4BAA4B,CAwB9B;AAiUD;;GAEG;AACH,wBAAsB,uBAAuB,CAC3C,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,mBAAmB,EAC7B,OAAO,EAAE,gBAAgB,GACxB,OAAO,CAAC,IAAI,CAAC,CA6Ff;AAy0BD;;;;;GAKG;AACH,wBAAgB,mBAAmB,CACjC,SAAS,EAAE,qBAAqB,EAChC,QAAQ,CAAC,EAAE,mBAAmB,GAC7B,GAAG,CAAC,MAAM,CAAC,CA6Cb;AAED;;GAEG;AACH,MAAM,WAAW,wBAAwB;IACvC,SAAS,EAAE,MAAM,CAAC;IAClB,WAAW,EAAE,MAAM,EAAE,CAAC;CACvB;AAuDD;;;;;;;;;;GAUG;AACH,wBAAgB,6BAA6B,CAC3C,QAAQ,EAAE,mBAAmB,GAC5B,wBAAwB,EAAE,CAsB5B;AAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA4BG;AACH,wBAAgB,4BAA4B,CAC1C,QAAQ,EAAE,mBAAmB,GAC5B,IAAI,CA2BN"}

package/dist/vite-plugin/sveltekit-generator.js

@@ -1,5 +1,6 @@
 import { MAX_LIST_LIMIT, buildDefaultListOrderBy } from "../query-bounds.js";
-import { resolveCustomActionMetadata } from "../generators/custom-action.js";
+import { resolveCustomActionMetadata, resolveCustomActionNames } from "../generators/custom-action.js";
+import { isFrameworkBaseClass } from "../registry/framework-base-classes.js";
 import { generateConditionalGetRouteHelper } from "../generators/conditional-get.js";
 import { AUTO_GENERATED_ROUTE_HEADER } from "./route-header.js";
 import { generateChangesRoute } from "./changes-route.js";
@@ -764,6 +765,7 @@ async function generateSvelteKitRoutes(projectRoot, manifest, options) {
 	let generatedCount = 0;
 	let skippedCollections = 0;
 	for (const [className, objectDef] of Object.entries(manifest.objects)) {
+		if (isFrameworkBaseClass(objectDef.className, objectDef.packageName)) continue;
 		if (isCollectionManifestClass(manifest, objectDef)) {
 			const collectionRoutePaths = await generateCollectionRoutesForObject(projectRoot, className, objectDef, manifest, options);
 			generatedRoutePaths.push(...collectionRoutePaths);
@@ -1295,9 +1297,54 @@ function resolveApiActionSet(objectDef, manifest) {
 	return actions;
 }
 /**
-* Inspect a manifest and return classes whose `cli.include` references
-* methods not exposed via the API. Classes that opt out via
-* `cli: { skipApiCheck: true }` are skipped.
+* Resolve the effective CLI command set for an object, for the cli↔api
+* coherence lint. Two distinct resolutions, chosen by whether `cli.include`
+* is spelled out:
+*
+* **Explicit `cli.include`** (preserves the lint's exact pre-#2638
+* algorithm): the literal `include − exclude`, verbatim, whether or not an
+* entry resolves to a real CRUD verb or a scanned public method. This is
+* deliberate, not an oversight -- an `include` entry that names a typo, a
+* getter (never in the manifest's `methods` map), or a private/protected
+* method (the scanner drops these rather than recording `isPublic: false`,
+* so nothing else catches it) must still surface as "unreachable" so the
+* build fails loudly on the config mistake, the same way it always has.
+* Resolving it instead through `resolveCustomActionNames` -- which only
+* iterates real scanned methods -- would silently drop such an entry with no
+* error at all (final review, #2638).
+*
+* **Bare `cli: true`/`cli: {}`** (#2638, the new case this lint now
+* inspects): every public custom method minus exclude, exactly the "every
+* public method minus exclude" resolution `CLIGenerator.listCommands()`
+* already applies (via `resolveCustomActionNames`, reused not
+* reimplemented) -- lifecycle methods excluded, same as everywhere else.
+* CRUD verbs are NOT checked in this branch: a class that closes its API
+* entirely (`api: false`) while keeping a default-open, CLI/MCP-only admin
+* surface (`cli: true`/omitted) is a common, intentional combination (see
+* `cli.skipApiCheck`'s own "in-process, no HTTP" doc comment); blanket-
+* checking CRUD reachability for every such class would flag that existing,
+* legitimate pattern across the whole codebase, not just the #2638 defect
+* (confirmed by running this against the full monorepo build during
+* development — it did exactly that).
+*/
+function resolveCliActionSet(objectDef) {
+	const cliConfig = objectDef.decoratorConfig?.cli;
+	if (cliConfig === false) return /* @__PURE__ */ new Set();
+	const included = typeof cliConfig === "object" ? cliConfig.include : void 0;
+	const excluded = typeof cliConfig === "object" && Array.isArray(cliConfig.exclude) ? cliConfig.exclude : [];
+	if (included) return new Set(included.filter((cmd) => !excluded.includes(cmd)));
+	return resolveCustomActionNames(Object.entries(objectDef.methods || {}), {
+		include: void 0,
+		exclude: excluded
+	}, STANDARD_API_ACTIONS);
+}
+/**
+* Inspect a manifest and return classes whose effective CLI command set —
+* `cli.include`/`cli.exclude` when spelled out, or (#2638) the same "every
+* public method minus exclude" default `cli: true`/`cli: {}` resolves to —
+* references a command not exposed via the API. Classes that opt out via
+* `cli: { skipApiCheck: true }` are skipped, and so is a class with
+* `cli: false` (no CLI surface at all).
 *
 * Throws nothing; returns the violation list so callers can choose to throw
 * or warn.
@@ -1306,14 +1353,12 @@ function findCliApiCoherenceViolations(manifest) {
 	const violations = [];
 	for (const [className, objectDef] of Object.entries(manifest.objects)) {
 		const cliConfig = objectDef.decoratorConfig?.cli;
-		if (!cliConfig || typeof cliConfig !== "object") continue;
-		if (cliConfig.skipApiCheck) continue;
-		if (!cliConfig.include || cliConfig.include.length === 0) continue;
-		const cliExclude = Array.isArray(cliConfig.exclude) ? cliConfig.exclude : [];
-		const effectiveCliCommands = cliConfig.include.filter((cmd) => !cliExclude.includes(cmd));
-		if (effectiveCliCommands.length === 0) continue;
+		if (cliConfig === false) continue;
+		if (typeof cliConfig === "object" && cliConfig.skipApiCheck) continue;
+		const effectiveCliCommands = resolveCliActionSet(objectDef);
+		if (effectiveCliCommands.size === 0) continue;
 		const apiActionSet = resolveApiActionSet(objectDef, manifest);
-		const unreachable = effectiveCliCommands.filter((action) => !apiActionSet.has(action));
+		const unreachable = [...effectiveCliCommands].filter((action) => !apiActionSet.has(action)).sort();
 		if (unreachable.length > 0) violations.push({
 			className,
 			unreachable
@@ -1322,15 +1367,41 @@ function findCliApiCoherenceViolations(manifest) {
 	return violations;
 }
 /**
-* Throw if any class in the manifest has `cli.include` methods that aren't
-* reachable via the API. Default build-time gate; opt-out per-class via
-* `cli: { skipApiCheck: true }` (or globally via the vite plugin option
-* `validateCliApiCoherence: false`).
+* Throw if any class in the manifest has an EXPLICIT `cli.include` command
+* that isn't reachable via the API. Default build-time gate; opt-out
+* per-class via `cli: { skipApiCheck: true }` (or globally via the vite
+* plugin option `validateCliApiCoherence: false`).
+*
+* This is deliberately narrower than `findCliApiCoherenceViolations` above.
+* That function is now fully correct for the broader `cli: true`/`cli: {}`
+* default surface too (#2638: same "every public method minus exclude"
+* resolution `listCommands()` uses, so a bare `cli: true` is inspected the
+* same as an explicit `include`). But `smrtPlugin()`'s default
+* `validateCliApiCoherence: true` calls this THROWING gate unconditionally
+* from every consuming package's own build (`configResolved`,
+* `vite-plugin/index.ts`) -- and a full-monorepo build during #2638
+* development showed that broader surface has thousands of pre-existing
+* public getters/business-logic methods (e.g.
+* `@happyvertical/smrt-ads:AdGroup.hasStarted`,
+* `@happyvertical/smrt-tags:Tag.getParent`) across ~28 packages that were
+* never meant to be REST-reachable and have no API route today. That
+* over-exposure is real, pre-existing, and unrelated to #2638's framework-
+* lifecycle-method defect -- flipping this gate to enforce it unconditionally
+* would break every one of those packages' builds today, which is a
+* repo-wide triage effort (add routes, or an explicit `cli.exclude`/
+* `skipApiCheck` per owner) this PR did not undertake and is out of its
+* file boundary. So the gate keeps its pre-#2638 blast radius -- classes
+* that spell out a non-empty `cli.include` -- while `findCliApiCoherenceViolations`
+* is complete and available (and covered by its own tests) for the broader
+* check once that pre-existing surface is triaged.
 */
 function validateCliIncludeAgainstApi(manifest) {
-	const violations = findCliApiCoherenceViolations(manifest);
+	const violations = findCliApiCoherenceViolations(manifest).filter(({ className }) => {
+		const cliConfig = manifest.objects[className]?.decoratorConfig?.cli;
+		return typeof cliConfig === "object" && Array.isArray(cliConfig.include) && cliConfig.include.length > 0;
+	});
 	if (violations.length === 0) return;
-	const messages = violations.flatMap(({ className, unreachable }) => unreachable.map((action) => `[smrt] ${className}.${action} is declared in cli.include but is not exposed via the api.\n  Either:\n    - Add '${action}' to api.include, or\n    - Remove '${action}' from cli.include.\n  The CLI invokes methods over HTTP; methods without API routes are unreachable.\n  If this CLI is intentionally invoked in-process (no HTTP), set\n  \`cli: { skipApiCheck: true }\` on the @smrt() decorator to acknowledge.`));
+	const messages = violations.flatMap(({ className, unreachable }) => unreachable.map((action) => `[smrt] ${className}.${action} is exposed as a CLI command but is not exposed via the api.\n  Either:\n    - Add '${action}' to api.include, or\n    - Remove '${action}' from cli.include / add it to cli.exclude.\n  The CLI invokes methods over HTTP; methods without API routes are unreachable.\n  If this CLI is intentionally invoked in-process (no HTTP), set\n  \`cli: { skipApiCheck: true }\` on the @smrt() decorator to acknowledge.`));
 	throw new Error(messages.join("\n\n"));
 }
 /**