@happyvertical/smrt-core 0.40.69 → 0.40.70

package/dist/migrations/generator.js

@@ -1,8 +1,10 @@
 import { renderIndexTarget } from "../schema/index-utils.js";
 import { getDDLStrategy } from "../schema/ddl/index.js";
 import { materializeManifestDDLForEngine } from "../schema/ddl/materialize-manifest.js";
+import { cachedDdlTableConstraints } from "../schema/manifest-schema.js";
 import "../schema/utils.js";
 import { computeChecksum } from "./checksum.js";
+import { createLogger } from "@happyvertical/logger";
 //#region src/migrations/generator.ts
 /**
 * Migration Generator
@@ -10,6 +12,7 @@ import { computeChecksum } from "./checksum.js";
 * Generates migration files from schema diffs.
 * Supports both SQL and TypeScript formats.
 */
+var logger = createLogger({ level: "info" });
 /**
 * MigrationGenerator class for creating migration files
 */
@@ -24,7 +27,7 @@ var MigrationGenerator = class {
 		this.format = options.format || "sql";
 		this.includeDown = options.includeDown ?? true;
 		this.packageName = options.packageName;
-		this.materializeStructuredSchema = options.materializeStructuredSchema ?? false;
+		this.materializeStructuredSchema = options.materializeStructuredSchema ?? true;
 	}
 	/**
 	* Generate a migration from a schema diff
@@ -34,6 +37,8 @@ var MigrationGenerator = class {
 		const downStatements = [];
 		for (const schema of diff.added_tables) {
 			upStatements.push(this.generateCreateTable(schema));
+			upStatements.push(...this.generateTableIndexes(schema));
+			upStatements.push(...this.generateTableTriggers(schema));
 			if (this.includeDown || options.includeDown) downStatements.push(this.generateDropTable(schema.tableName));
 		}
 		for (const change of diff.changes) {
@@ -90,11 +95,11 @@ var MigrationGenerator = class {
 		lines.push("");
 		lines.push("-- @up");
 		if (upStatements.length === 0) lines.push("-- Add your UP statements here");
-		else for (const stmt of upStatements) lines.push(`${stmt};`);
+		else for (const stmt of upStatements) lines.push(this.terminateStatement(stmt));
 		lines.push("");
 		lines.push("-- @down");
 		if (downStatements.length === 0) lines.push("-- Add your DOWN statements here");
-		else for (const stmt of downStatements) lines.push(`${stmt};`);
+		else for (const stmt of downStatements) lines.push(this.terminateStatement(stmt));
 		lines.push("");
 		return lines.join("\n");
 	}
@@ -134,9 +139,27 @@ ${downStatementsStr}
 	generateCreateTable(schema) {
 		if (Object.keys(schema.columns).length === 0 && schema.ddl?.trim()) return materializeManifestDDLForEngine(schema.ddl, this.engine);
 		if (!this.materializeStructuredSchema && schema.ddl?.trim()) return materializeManifestDDLForEngine(schema.ddl, this.engine);
+		if (schema.ddl?.trim()) {
+			const constraints = cachedDdlTableConstraints(schema.ddl);
+			if (constraints.length > 0) logger.warn(`[MigrationGenerator] cached ddl for table "${schema.tableName}" declares ${constraints.length} table constraint(s) that structured columns cannot carry (${constraints.join("; ")}); the structured schema is authoritative and they are not rendered (#2358).`);
+		}
 		return getDDLStrategy(this.engine).generateCreateTable(schema);
 	}
 	/**
+	* Generate the CREATE INDEX statements for a new table through the engine
+	* strategy (partial `WHERE`, JSON-path targets, inline-UNIQUE engines).
+	*/
+	generateTableIndexes(schema) {
+		return getDDLStrategy(this.engine).generateIndexes(schema);
+	}
+	/**
+	* Generate the CREATE TRIGGER statements for a new table (engines without
+	* trigger support return none).
+	*/
+	generateTableTriggers(schema) {
+		return getDDLStrategy(this.engine).generateTriggers(schema);
+	}
+	/**
 	* Generate DROP TABLE SQL
 	*/
 	generateDropTable(tableName) {
@@ -177,6 +200,16 @@ ${downStatementsStr}
 				up.push(`-- Expected: ${change.mismatch?.expected}, Actual: ${change.mismatch?.actual}`);
 				up.push(`-- Manual migration required`);
 				break;
+			case "alter_column":
+				if (change.advisory && sqlStatements.length === 0) break;
+				for (const sql of sqlStatements) up.push(sql);
+				break;
+			case "orphan_column":
+			case "orphan_index":
+				up.push(`-- ${change.advisory?.severity === "warning" ? "WARNING" : "NOTE"}: ${change.type === "orphan_column" ? "Orphan column" : "Orphan unique constraint"} ${change.table}.${change.name} (${change.mismatch?.actual ?? "unknown shape"})`);
+				if (change.advisory?.message) up.push(`-- ${change.advisory.message}`);
+				for (const suggestion of change.advisory?.suggestedSql ?? []) up.push(`-- suggested: ${suggestion}`);
+				break;
 			default: break;
 		}
 		return {
@@ -206,8 +239,9 @@ ${downStatementsStr}
 	generateAddIndex(tableName, index) {
 		const uniqueStr = index.unique ? "UNIQUE " : "";
 		const target = renderIndexTarget(index, this.engine);
-		if (this.engine === "postgres") return `CREATE ${uniqueStr}INDEX CONCURRENTLY IF NOT EXISTS ${this.quoteIdentifier(index.name)} ON ${this.quoteIdentifier(tableName)} (${target})`;
-		return `CREATE ${uniqueStr}INDEX IF NOT EXISTS ${this.quoteIdentifier(index.name)} ON ${this.quoteIdentifier(tableName)} (${target})`;
+		const whereClause = this.engine !== "duckdb" && index.where ? ` WHERE ${index.where}` : "";
+		if (this.engine === "postgres") return `CREATE ${uniqueStr}INDEX CONCURRENTLY IF NOT EXISTS ${this.quoteIdentifier(index.name)} ON ${this.quoteIdentifier(tableName)} (${target})${whereClause}`;
+		return `CREATE ${uniqueStr}INDEX IF NOT EXISTS ${this.quoteIdentifier(index.name)} ON ${this.quoteIdentifier(tableName)} (${target})${whereClause}`;
 	}
 	/**
 	* Generate DROP INDEX SQL
@@ -233,6 +267,16 @@ ${downStatementsStr}
 		return String(value);
 	}
 	/**
+	* Terminate a statement with exactly one `;` for the SQL file format.
+	*
+	* Strategy-rendered statements (`generateCreateTable`, `generateIndexes`,
+	* `generateTriggers`) already end with `;`, while differ-produced ALTERs do
+	* not — appending unconditionally wrote `;;` (#2406 review).
+	*/
+	terminateStatement(stmt) {
+		return stmt.trimEnd().endsWith(";") ? stmt : `${stmt};`;
+	}
+	/**
 	* Escape template literal content
 	*/
 	escapeTemplate(str) {

package/dist/migrations/generator.js.map

@@ -1 +1 @@
-{"version":3,"file":"generator.js","names":[],"sources":["../../src/migrations/generator.ts"],"sourcesContent":["/**\n * Migration Generator\n *\n * Generates migration files from schema diffs.\n * Supports both SQL and TypeScript formats.\n */\n\nimport { getDDLStrategy } from '../schema/ddl/index.js';\nimport { materializeManifestDDLForEngine } from '../schema/ddl/materialize-manifest.js';\nimport type {\n  MigrationDefinition,\n  SchemaChange,\n  SchemaDefinition,\n  SchemaDiff,\n} from '../schema/types.js';\nimport { renderIndexTarget } from '../schema/utils.js';\nimport { computeChecksum } from './checksum.js';\nimport type { DatabaseEngine } from './types.js';\n\n/**\n * Options for migration generation\n */\nexport interface GenerateMigrationOptions {\n  /** Migration name (without sequence number) */\n  name: string;\n  /** Output format */\n  format?: 'sql' | 'typescript';\n  /** Database engine for engine-specific SQL */\n  engine?: DatabaseEngine;\n  /** Include generated DOWN statements */\n  includeDown?: boolean;\n  /** Package name for metadata */\n  packageName?: string;\n  /** Description for the migration */\n  description?: string;\n}\n\n/**\n * Result of migration generation\n */\nexport interface GeneratedMigration {\n  /** Full migration ID (e.g., '0001_add_users') */\n  id: string;\n  /** Filename (e.g., '0001_add_users.sql') */\n  filename: string;\n  /** File content */\n  content: string;\n  /** UP SQL statements */\n  up: string[];\n  /** DOWN SQL statements (if includeDown is true) */\n  down: string[];\n  /** Checksum of the migration */\n  checksum: string;\n}\n\n/**\n * MigrationGenerator class for creating migration files\n */\nexport class MigrationGenerator {\n  private engine: DatabaseEngine;\n  private format: 'sql' | 'typescript';\n  private includeDown: boolean;\n  private packageName?: string;\n  private materializeStructuredSchema: boolean;\n\n  constructor(\n    options: {\n      engine?: DatabaseEngine;\n      format?: 'sql' | 'typescript';\n      includeDown?: boolean;\n      packageName?: string;\n      /**\n       * Ignore cached manifest DDL and materialize structured columns for the\n       * selected engine. Framework-owned executable paths should enable this;\n       * the default preserves the published custom-DDL contract while still\n       * materializing bare PostgreSQL TIMESTAMP columns as TIMESTAMPTZ.\n       */\n      materializeStructuredSchema?: boolean;\n    } = {},\n  ) {\n    this.engine = options.engine || 'sqlite';\n    this.format = options.format || 'sql';\n    this.includeDown = options.includeDown ?? true;\n    this.packageName = options.packageName;\n    this.materializeStructuredSchema =\n      options.materializeStructuredSchema ?? false;\n  }\n\n  /**\n   * Generate a migration from a schema diff\n   */\n  generateFromDiff(\n    diff: SchemaDiff,\n    options: GenerateMigrationOptions,\n  ): GeneratedMigration {\n    const upStatements: string[] = [];\n    const downStatements: string[] = [];\n\n    // Handle new tables\n    for (const schema of diff.added_tables) {\n      upStatements.push(this.generateCreateTable(schema));\n      if (this.includeDown || options.includeDown) {\n        downStatements.push(this.generateDropTable(schema.tableName));\n      }\n    }\n\n    // Handle column and index changes\n    for (const change of diff.changes) {\n      const { up, down } = this.generateChangeSQL(change);\n      upStatements.push(...up);\n      if ((this.includeDown || options.includeDown) && down.length > 0) {\n        downStatements.push(...down);\n      }\n    }\n\n    // Handle dropped tables (already in SQL form if present)\n    for (const tableName of diff.dropped_tables) {\n      upStatements.push(this.generateDropTable(tableName));\n      // No automatic DOWN for drops - too dangerous\n    }\n\n    return this.generateMigration(upStatements, downStatements, options);\n  }\n\n  /**\n   * Generate a migration from explicit SQL statements\n   */\n  generateFromSQL(\n    upStatements: string[],\n    downStatements: string[],\n    options: GenerateMigrationOptions,\n  ): GeneratedMigration {\n    return this.generateMigration(upStatements, downStatements, options);\n  }\n\n  /**\n   * Generate an empty migration template\n   */\n  generateEmpty(options: GenerateMigrationOptions): GeneratedMigration {\n    return this.generateMigration([], [], options);\n  }\n\n  /**\n   * Core migration generation logic\n   */\n  private generateMigration(\n    upStatements: string[],\n    downStatements: string[],\n    options: GenerateMigrationOptions,\n  ): GeneratedMigration {\n    const id = options.name;\n    const description = options.description || `Migration: ${options.name}`;\n    const format = options.format || this.format;\n    const filename = `${id}.${format === 'sql' ? 'sql' : 'ts'}`;\n    const checksum = computeChecksum(upStatements);\n\n    let content: string;\n    if (format === 'sql') {\n      content = this.generateSQLFile(\n        id,\n        description,\n        upStatements,\n        downStatements,\n      );\n    } else {\n      content = this.generateTypeScriptFile(\n        id,\n        description,\n        upStatements,\n        downStatements,\n      );\n    }\n\n    return {\n      id,\n      filename,\n      content,\n      up: upStatements,\n      down: downStatements,\n      checksum,\n    };\n  }\n\n  /**\n   * Generate SQL migration file content\n   */\n  private generateSQLFile(\n    id: string,\n    description: string,\n    upStatements: string[],\n    downStatements: string[],\n  ): string {\n    const lines: string[] = [\n      `-- @id: ${id}`,\n      `-- @description: ${description}`,\n      `-- @generated: ${new Date().toISOString()}`,\n    ];\n\n    if (this.packageName) {\n      lines.push(`-- @package: ${this.packageName}`);\n    }\n\n    lines.push('');\n    lines.push('-- @up');\n\n    if (upStatements.length === 0) {\n      lines.push('-- Add your UP statements here');\n    } else {\n      for (const stmt of upStatements) {\n        lines.push(`${stmt};`);\n      }\n    }\n\n    lines.push('');\n    lines.push('-- @down');\n\n    if (downStatements.length === 0) {\n      lines.push('-- Add your DOWN statements here');\n    } else {\n      for (const stmt of downStatements) {\n        lines.push(`${stmt};`);\n      }\n    }\n\n    lines.push('');\n    return lines.join('\\n');\n  }\n\n  /**\n   * Generate TypeScript migration file content\n   */\n  private generateTypeScriptFile(\n    id: string,\n    description: string,\n    upStatements: string[],\n    downStatements: string[],\n  ): string {\n    const upStatementsStr =\n      upStatements.length > 0\n        ? upStatements\n            .map((s) => `      await db.query(\\`${this.escapeTemplate(s)}\\`);`)\n            .join('\\n')\n        : '      // Add your UP statements here';\n\n    const downStatementsStr =\n      downStatements.length > 0\n        ? downStatements\n            .map((s) => `      await db.query(\\`${this.escapeTemplate(s)}\\`);`)\n            .join('\\n')\n        : '      // Add your DOWN statements here';\n\n    return `/**\n * Migration: ${id}\n * ${description}\n *\n * Generated: ${new Date().toISOString()}\n */\n\nimport type { Migration } from '@happyvertical/smrt-core';\n\nexport default {\n  id: '${id}',\n  description: '${description.replace(/'/g, \"\\\\'\")}',\n  version: '1.0.0',\n\n  up: async (db) => {\n${upStatementsStr}\n  },\n\n  down: async (db) => {\n${downStatementsStr}\n  },\n} satisfies Migration;\n`;\n  }\n\n  /**\n   * Generate CREATE TABLE SQL from schema definition\n   */\n  private generateCreateTable(schema: SchemaDefinition): string {\n    if (Object.keys(schema.columns).length === 0 && schema.ddl?.trim()) {\n      // Structured materialization cannot preserve constraints or vendor SQL\n      // when an older/custom manifest exposes only executable DDL. Retain the\n      // only valid representation even when materialization was requested.\n      return materializeManifestDDLForEngine(schema.ddl, this.engine);\n    }\n\n    if (!this.materializeStructuredSchema && schema.ddl?.trim()) {\n      // Preserve the documented custom-DDL contract by default, including\n      // table-level constraints that structured ColumnDefinition cannot\n      // represent. Engine-aware framework callers explicitly opt into the\n      // structured materialization path below.\n      return materializeManifestDDLForEngine(schema.ddl, this.engine);\n    }\n\n    // The manifest's pre-generated `ddl` is deliberately engine-neutral and\n    // may contain abstract TIMESTAMP/JSON/UUID types. Always materialize the\n    // structured columns through the selected engine strategy; executing the\n    // cached string on PostgreSQL would otherwise bypass TIMESTAMPTZ and lose\n    // JavaScript Date offsets (#2069). This matches the migration orchestrator\n    // and also prevents JSON/REAL/UUID drift after a create.\n    return getDDLStrategy(this.engine).generateCreateTable(schema);\n  }\n\n  /**\n   * Generate DROP TABLE SQL\n   */\n  private generateDropTable(tableName: string): string {\n    return `DROP TABLE IF EXISTS ${this.quoteIdentifier(tableName)}`;\n  }\n\n  /**\n   * Generate SQL for a schema change\n   */\n  private generateChangeSQL(change: SchemaChange): {\n    up: string[];\n    down: string[];\n  } {\n    const up: string[] = [];\n    const down: string[] = [];\n    const sqlStatements =\n      change.sqlStatements ?? (change.sql ? [change.sql] : []);\n\n    switch (change.type) {\n      case 'add_column':\n        if (sqlStatements.length > 0) {\n          up.push(...sqlStatements);\n        } else if (change.column && change.name) {\n          up.push(\n            this.generateAddColumn(change.table, change.name, change.column),\n          );\n        }\n        if (change.name) {\n          down.push(this.generateDropColumn(change.table, change.name));\n        }\n        break;\n\n      case 'drop_column':\n        if (sqlStatements.length > 0) {\n          up.push(...sqlStatements);\n        } else if (change.name) {\n          up.push(this.generateDropColumn(change.table, change.name));\n        }\n        // No automatic DOWN for drops\n        break;\n\n      case 'add_index':\n        if (sqlStatements.length > 0) {\n          up.push(...sqlStatements);\n        } else if (change.index) {\n          up.push(this.generateAddIndex(change.table, change.index));\n        }\n        if (change.name) {\n          down.push(this.generateDropIndex(change.name));\n        }\n        break;\n\n      case 'drop_index':\n        if (change.name) {\n          up.push(this.generateDropIndex(change.name));\n        }\n        // No automatic DOWN for index drops\n        break;\n\n      case 'type_upgrade':\n        // Type upgrades are safe conversions that SMRT can handle automatically\n        // The SQL is generated by the differ based on engine-specific requirements\n        if (sqlStatements.length > 0) {\n          for (const sql of sqlStatements) {\n            // Skip comment-only SQL (indicates a no-op migration)\n            if (!sql.startsWith('--')) {\n              up.push(sql);\n            }\n          }\n        }\n        // No automatic DOWN for type changes - could lose data\n        break;\n\n      case 'type_mismatch':\n        // Type mismatches require manual intervention\n        up.push(`-- WARNING: Type mismatch for ${change.table}.${change.name}`);\n        up.push(\n          `-- Expected: ${change.mismatch?.expected}, Actual: ${change.mismatch?.actual}`,\n        );\n        up.push(`-- Manual migration required`);\n        break;\n\n      default:\n        // Unknown change type\n        break;\n    }\n\n    return { up, down };\n  }\n\n  /**\n   * Generate ADD COLUMN SQL\n   */\n  private generateAddColumn(\n    tableName: string,\n    colName: string,\n    colDef: import('../schema/types.js').ColumnDefinition,\n  ): string {\n    const parts: string[] = [this.quoteIdentifier(colName), colDef.type];\n\n    if (colDef.notNull) {\n      parts.push('NOT NULL');\n    }\n    if (colDef.unique) {\n      parts.push('UNIQUE');\n    }\n    if (colDef.defaultValue !== undefined) {\n      parts.push(`DEFAULT ${this.formatDefaultValue(colDef.defaultValue)}`);\n    }\n\n    return `ALTER TABLE ${this.quoteIdentifier(tableName)} ADD COLUMN ${parts.join(' ')}`;\n  }\n\n  /**\n   * Generate DROP COLUMN SQL\n   */\n  private generateDropColumn(tableName: string, colName: string): string {\n    return `ALTER TABLE ${this.quoteIdentifier(tableName)} DROP COLUMN ${this.quoteIdentifier(colName)}`;\n  }\n\n  /**\n   * Generate ADD INDEX SQL\n   */\n  private generateAddIndex(\n    tableName: string,\n    index: import('../schema/types.js').IndexDefinition,\n  ): string {\n    const uniqueStr = index.unique ? 'UNIQUE ' : '';\n    const target = renderIndexTarget(index, this.engine);\n\n    if (this.engine === 'postgres') {\n      // PostgreSQL: use CONCURRENTLY for production safety\n      return `CREATE ${uniqueStr}INDEX CONCURRENTLY IF NOT EXISTS ${this.quoteIdentifier(index.name)} ON ${this.quoteIdentifier(tableName)} (${target})`;\n    }\n\n    return `CREATE ${uniqueStr}INDEX IF NOT EXISTS ${this.quoteIdentifier(index.name)} ON ${this.quoteIdentifier(tableName)} (${target})`;\n  }\n\n  /**\n   * Generate DROP INDEX SQL\n   */\n  private generateDropIndex(indexName: string): string {\n    if (this.engine === 'postgres') {\n      return `DROP INDEX CONCURRENTLY IF EXISTS ${this.quoteIdentifier(indexName)}`;\n    }\n    return `DROP INDEX IF EXISTS ${this.quoteIdentifier(indexName)}`;\n  }\n\n  /**\n   * Quote a SQL identifier\n   */\n  private quoteIdentifier(name: string): string {\n    return `\"${name.replace(/\"/g, '\"\"')}\"`;\n  }\n\n  /**\n   * Format a default value for SQL\n   */\n  private formatDefaultValue(value: unknown): string {\n    if (value === null) return 'NULL';\n    if (typeof value === 'string') return `'${value.replace(/'/g, \"''\")}'`;\n    if (typeof value === 'boolean') return value ? '1' : '0';\n    if (typeof value === 'number') return String(value);\n    return String(value);\n  }\n\n  /**\n   * Escape template literal content\n   */\n  private escapeTemplate(str: string): string {\n    return str.replace(/`/g, '\\\\`').replace(/\\$/g, '\\\\$');\n  }\n}\n\n/**\n * Generate a migration definition from UP and DOWN statements\n */\nexport function createMigrationDefinition(\n  id: string,\n  upStatements: string[],\n  downStatements: string[] = [],\n  options: {\n    description?: string;\n    version?: string;\n    packageName?: string;\n    sourceFile?: string;\n  } = {},\n): MigrationDefinition {\n  return {\n    id,\n    description: options.description || `Migration: ${id}`,\n    version: options.version || '1.0.0',\n    up: upStatements,\n    down: downStatements,\n    package_name: options.packageName,\n    source_file: options.sourceFile,\n  };\n}\n\n/**\n * Generate a sequence number for a new migration\n */\nexport function generateMigrationSequence(existingIds: string[]): string {\n  const sequences = existingIds\n    .map((id) => {\n      const match = id.match(/^(\\d+)_/);\n      return match ? parseInt(match[1], 10) : 0;\n    })\n    .filter((n) => !Number.isNaN(n));\n\n  const maxSequence = sequences.length > 0 ? Math.max(...sequences) : 0;\n  return String(maxSequence + 1).padStart(4, '0');\n}\n\n/**\n * Generate a timestamp-based migration ID\n */\nexport function generateMigrationTimestamp(): string {\n  const now = new Date();\n  return [\n    now.getFullYear(),\n    String(now.getMonth() + 1).padStart(2, '0'),\n    String(now.getDate()).padStart(2, '0'),\n    String(now.getHours()).padStart(2, '0'),\n    String(now.getMinutes()).padStart(2, '0'),\n    String(now.getSeconds()).padStart(2, '0'),\n  ].join('');\n}\n"],"mappings":";;;;;;;;;;;;;;;AA0DA,IAAa,qBAAb,MAAgC;CAC9B;CACA;CACA;CACA;CACA;CAEA,YACE,UAYI,CAAC,GACL;EACA,KAAK,SAAS,QAAQ,UAAU;EAChC,KAAK,SAAS,QAAQ,UAAU;EAChC,KAAK,cAAc,QAAQ,eAAe;EAC1C,KAAK,cAAc,QAAQ;EAC3B,KAAK,8BACH,QAAQ,+BAA+B;CAC3C;;;;CAKA,iBACE,MACA,SACoB;EACpB,MAAM,eAAyB,CAAC;EAChC,MAAM,iBAA2B,CAAC;EAGlC,KAAK,MAAM,UAAU,KAAK,cAAc;GACtC,aAAa,KAAK,KAAK,oBAAoB,MAAM,CAAC;GAClD,IAAI,KAAK,eAAe,QAAQ,aAC9B,eAAe,KAAK,KAAK,kBAAkB,OAAO,SAAS,CAAC;EAEhE;EAGA,KAAK,MAAM,UAAU,KAAK,SAAS;GACjC,MAAM,EAAE,IAAI,SAAS,KAAK,kBAAkB,MAAM;GAClD,aAAa,KAAK,GAAG,EAAE;GACvB,KAAK,KAAK,eAAe,QAAQ,gBAAgB,KAAK,SAAS,GAC7D,eAAe,KAAK,GAAG,IAAI;EAE/B;EAGA,KAAK,MAAM,aAAa,KAAK,gBAC3B,aAAa,KAAK,KAAK,kBAAkB,SAAS,CAAC;EAIrD,OAAO,KAAK,kBAAkB,cAAc,gBAAgB,OAAO;CACrE;;;;CAKA,gBACE,cACA,gBACA,SACoB;EACpB,OAAO,KAAK,kBAAkB,cAAc,gBAAgB,OAAO;CACrE;;;;CAKA,cAAc,SAAuD;EACnE,OAAO,KAAK,kBAAkB,CAAC,GAAG,CAAC,GAAG,OAAO;CAC/C;;;;CAKA,kBACE,cACA,gBACA,SACoB;EACpB,MAAM,KAAK,QAAQ;EACnB,MAAM,cAAc,QAAQ,eAAe,cAAc,QAAQ;EACjE,MAAM,SAAS,QAAQ,UAAU,KAAK;EACtC,MAAM,WAAW,GAAG,GAAG,GAAG,WAAW,QAAQ,QAAQ;EACrD,MAAM,WAAW,gBAAgB,YAAY;EAE7C,IAAI;EACJ,IAAI,WAAW,OACb,UAAU,KAAK,gBACb,IACA,aACA,cACA,cACF;OAEA,UAAU,KAAK,uBACb,IACA,aACA,cACA,cACF;EAGF,OAAO;GACL;GACA;GACA;GACA,IAAI;GACJ,MAAM;GACN;EACF;CACF;;;;CAKA,gBACE,IACA,aACA,cACA,gBACQ;EACR,MAAM,QAAkB;GACtB,WAAW;GACX,oBAAoB;GACpB,mCAAkB,IAAI,KAAK,EAAA,CAAE,YAAY;EAC3C;EAEA,IAAI,KAAK,aACP,MAAM,KAAK,gBAAgB,KAAK,aAAa;EAG/C,MAAM,KAAK,EAAE;EACb,MAAM,KAAK,QAAQ;EAEnB,IAAI,aAAa,WAAW,GAC1B,MAAM,KAAK,gCAAgC;OAE3C,KAAK,MAAM,QAAQ,cACjB,MAAM,KAAK,GAAG,KAAK,EAAE;EAIzB,MAAM,KAAK,EAAE;EACb,MAAM,KAAK,UAAU;EAErB,IAAI,eAAe,WAAW,GAC5B,MAAM,KAAK,kCAAkC;OAE7C,KAAK,MAAM,QAAQ,gBACjB,MAAM,KAAK,GAAG,KAAK,EAAE;EAIzB,MAAM,KAAK,EAAE;EACb,OAAO,MAAM,KAAK,IAAI;CACxB;;;;CAKA,uBACE,IACA,aACA,cACA,gBACQ;EACR,MAAM,kBACJ,aAAa,SAAS,IAClB,aACG,KAAK,MAAM,0BAA0B,KAAK,eAAe,CAAC,EAAE,KAAK,CAAC,CAClE,KAAK,IAAI,IACZ;EAEN,MAAM,oBACJ,eAAe,SAAS,IACpB,eACG,KAAK,MAAM,0BAA0B,KAAK,eAAe,CAAC,EAAE,KAAK,CAAC,CAClE,KAAK,IAAI,IACZ;EAEN,OAAO;gBACK,GAAG;KACd,YAAY;;iCAED,IAAI,KAAK,EAAA,CAAE,YAAY,EAAE;;;;;;SAMhC,GAAG;kBACM,YAAY,QAAQ,MAAM,KAAK,EAAE;;;;EAIjD,gBAAgB;;;;EAIhB,kBAAkB;;;;CAIlB;;;;CAKA,oBAA4B,QAAkC;EAC5D,IAAI,OAAO,KAAK,OAAO,OAAO,CAAC,CAAC,WAAW,KAAK,OAAO,KAAK,KAAK,GAI/D,OAAO,gCAAgC,OAAO,KAAK,KAAK,MAAM;EAGhE,IAAI,CAAC,KAAK,+BAA+B,OAAO,KAAK,KAAK,GAKxD,OAAO,gCAAgC,OAAO,KAAK,KAAK,MAAM;EAShE,OAAO,eAAe,KAAK,MAAM,CAAC,CAAC,oBAAoB,MAAM;CAC/D;;;;CAKA,kBAA0B,WAA2B;EACnD,OAAO,wBAAwB,KAAK,gBAAgB,SAAS;CAC/D;;;;CAKA,kBAA0B,QAGxB;EACA,MAAM,KAAe,CAAC;EACtB,MAAM,OAAiB,CAAC;EACxB,MAAM,gBACJ,OAAO,kBAAkB,OAAO,MAAM,CAAC,OAAO,GAAG,IAAI,CAAC;EAExD,QAAQ,OAAO,MAAf;GACE,KAAK;IACH,IAAI,cAAc,SAAS,GACzB,GAAG,KAAK,GAAG,aAAa;SACnB,IAAI,OAAO,UAAU,OAAO,MACjC,GAAG,KACD,KAAK,kBAAkB,OAAO,OAAO,OAAO,MAAM,OAAO,MAAM,CACjE;IAEF,IAAI,OAAO,MACT,KAAK,KAAK,KAAK,mBAAmB,OAAO,OAAO,OAAO,IAAI,CAAC;IAE9D;GAEF,KAAK;IACH,IAAI,cAAc,SAAS,GACzB,GAAG,KAAK,GAAG,aAAa;SACnB,IAAI,OAAO,MAChB,GAAG,KAAK,KAAK,mBAAmB,OAAO,OAAO,OAAO,IAAI,CAAC;IAG5D;GAEF,KAAK;IACH,IAAI,cAAc,SAAS,GACzB,GAAG,KAAK,GAAG,aAAa;SACnB,IAAI,OAAO,OAChB,GAAG,KAAK,KAAK,iBAAiB,OAAO,OAAO,OAAO,KAAK,CAAC;IAE3D,IAAI,OAAO,MACT,KAAK,KAAK,KAAK,kBAAkB,OAAO,IAAI,CAAC;IAE/C;GAEF,KAAK;IACH,IAAI,OAAO,MACT,GAAG,KAAK,KAAK,kBAAkB,OAAO,IAAI,CAAC;IAG7C;GAEF,KAAK;IAGH,IAAI,cAAc,SAAS;UACpB,MAAM,OAAO,eAEhB,IAAI,CAAC,IAAI,WAAW,IAAI,GACtB,GAAG,KAAK,GAAG;IAAA;IAKjB;GAEF,KAAK;IAEH,GAAG,KAAK,iCAAiC,OAAO,MAAM,GAAG,OAAO,MAAM;IACtE,GAAG,KACD,gBAAgB,OAAO,UAAU,SAAS,YAAY,OAAO,UAAU,QACzE;IACA,GAAG,KAAK,8BAA8B;IACtC;GAEF,SAEE;EACJ;EAEA,OAAO;GAAE;GAAI;EAAK;CACpB;;;;CAKA,kBACE,WACA,SACA,QACQ;EACR,MAAM,QAAkB,CAAC,KAAK,gBAAgB,OAAO,GAAG,OAAO,IAAI;EAEnE,IAAI,OAAO,SACT,MAAM,KAAK,UAAU;EAEvB,IAAI,OAAO,QACT,MAAM,KAAK,QAAQ;EAErB,IAAI,OAAO,iBAAiB,KAAA,GAC1B,MAAM,KAAK,WAAW,KAAK,mBAAmB,OAAO,YAAY,GAAG;EAGtE,OAAO,eAAe,KAAK,gBAAgB,SAAS,EAAE,cAAc,MAAM,KAAK,GAAG;CACpF;;;;CAKA,mBAA2B,WAAmB,SAAyB;EACrE,OAAO,eAAe,KAAK,gBAAgB,SAAS,EAAE,eAAe,KAAK,gBAAgB,OAAO;CACnG;;;;CAKA,iBACE,WACA,OACQ;EACR,MAAM,YAAY,MAAM,SAAS,YAAY;EAC7C,MAAM,SAAS,kBAAkB,OAAO,KAAK,MAAM;EAEnD,IAAI,KAAK,WAAW,YAElB,OAAO,UAAU,UAAU,mCAAmC,KAAK,gBAAgB,MAAM,IAAI,EAAE,MAAM,KAAK,gBAAgB,SAAS,EAAE,IAAI,OAAO;EAGlJ,OAAO,UAAU,UAAU,sBAAsB,KAAK,gBAAgB,MAAM,IAAI,EAAE,MAAM,KAAK,gBAAgB,SAAS,EAAE,IAAI,OAAO;CACrI;;;;CAKA,kBAA0B,WAA2B;EACnD,IAAI,KAAK,WAAW,YAClB,OAAO,qCAAqC,KAAK,gBAAgB,SAAS;EAE5E,OAAO,wBAAwB,KAAK,gBAAgB,SAAS;CAC/D;;;;CAKA,gBAAwB,MAAsB;EAC5C,OAAO,IAAI,KAAK,QAAQ,MAAM,MAAI,EAAE;CACtC;;;;CAKA,mBAA2B,OAAwB;EACjD,IAAI,UAAU,MAAM,OAAO;EAC3B,IAAI,OAAO,UAAU,UAAU,OAAO,IAAI,MAAM,QAAQ,MAAM,IAAI,EAAE;EACpE,IAAI,OAAO,UAAU,WAAW,OAAO,QAAQ,MAAM;EACrD,IAAI,OAAO,UAAU,UAAU,OAAO,OAAO,KAAK;EAClD,OAAO,OAAO,KAAK;CACrB;;;;CAKA,eAAuB,KAAqB;EAC1C,OAAO,IAAI,QAAQ,MAAM,KAAK,CAAC,CAAC,QAAQ,OAAO,KAAK;CACtD;AACF;;;;AAKA,SAAgB,0BACd,IACA,cACA,iBAA2B,CAAC,GAC5B,UAKI,CAAC,GACgB;CACrB,OAAO;EACL;EACA,aAAa,QAAQ,eAAe,cAAc;EAClD,SAAS,QAAQ,WAAW;EAC5B,IAAI;EACJ,MAAM;EACN,cAAc,QAAQ;EACtB,aAAa,QAAQ;CACvB;AACF;;;;AAKA,SAAgB,0BAA0B,aAA+B;CACvE,MAAM,YAAY,YACf,KAAK,OAAO;EACX,MAAM,QAAQ,GAAG,MAAM,SAAS;EAChC,OAAO,QAAQ,SAAS,MAAM,IAAI,EAAE,IAAI;CAC1C,CAAC,CAAC,CACD,QAAQ,MAAM,CAAC,OAAO,MAAM,CAAC,CAAC;CAEjC,MAAM,cAAc,UAAU,SAAS,IAAI,KAAK,IAAI,GAAG,SAAS,IAAI;CACpE,OAAO,OAAO,cAAc,CAAC,CAAC,CAAC,SAAS,GAAG,GAAG;AAChD;;;;AAKA,SAAgB,6BAAqC;CACnD,MAAM,sBAAM,IAAI,KAAK;CACrB,OAAO;EACL,IAAI,YAAY;EAChB,OAAO,IAAI,SAAS,IAAI,CAAC,CAAC,CAAC,SAAS,GAAG,GAAG;EAC1C,OAAO,IAAI,QAAQ,CAAC,CAAC,CAAC,SAAS,GAAG,GAAG;EACrC,OAAO,IAAI,SAAS,CAAC,CAAC,CAAC,SAAS,GAAG,GAAG;EACtC,OAAO,IAAI,WAAW,CAAC,CAAC,CAAC,SAAS,GAAG,GAAG;EACxC,OAAO,IAAI,WAAW,CAAC,CAAC,CAAC,SAAS,GAAG,GAAG;CAC1C,CAAC,CAAC,KAAK,EAAE;AACX"}
+{"version":3,"file":"generator.js","names":[],"sources":["../../src/migrations/generator.ts"],"sourcesContent":["/**\n * Migration Generator\n *\n * Generates migration files from schema diffs.\n * Supports both SQL and TypeScript formats.\n */\n\nimport { createLogger } from '@happyvertical/logger';\nimport { getDDLStrategy } from '../schema/ddl/index.js';\nimport { materializeManifestDDLForEngine } from '../schema/ddl/materialize-manifest.js';\nimport { cachedDdlTableConstraints } from '../schema/manifest-schema.js';\nimport type {\n  MigrationDefinition,\n  SchemaChange,\n  SchemaDefinition,\n  SchemaDiff,\n} from '../schema/types.js';\nimport { renderIndexTarget } from '../schema/utils.js';\nimport { computeChecksum } from './checksum.js';\nimport type { DatabaseEngine } from './types.js';\n\nconst logger = createLogger({ level: 'info' });\n\n/**\n * Options for migration generation\n */\nexport interface GenerateMigrationOptions {\n  /** Migration name (without sequence number) */\n  name: string;\n  /** Output format */\n  format?: 'sql' | 'typescript';\n  /** Database engine for engine-specific SQL */\n  engine?: DatabaseEngine;\n  /** Include generated DOWN statements */\n  includeDown?: boolean;\n  /** Package name for metadata */\n  packageName?: string;\n  /** Description for the migration */\n  description?: string;\n}\n\n/**\n * Result of migration generation\n */\nexport interface GeneratedMigration {\n  /** Full migration ID (e.g., '0001_add_users') */\n  id: string;\n  /** Filename (e.g., '0001_add_users.sql') */\n  filename: string;\n  /** File content */\n  content: string;\n  /** UP SQL statements */\n  up: string[];\n  /** DOWN SQL statements (if includeDown is true) */\n  down: string[];\n  /** Checksum of the migration */\n  checksum: string;\n}\n\n/**\n * MigrationGenerator class for creating migration files\n */\nexport class MigrationGenerator {\n  private engine: DatabaseEngine;\n  private format: 'sql' | 'typescript';\n  private includeDown: boolean;\n  private packageName?: string;\n  private materializeStructuredSchema: boolean;\n\n  constructor(\n    options: {\n      engine?: DatabaseEngine;\n      format?: 'sql' | 'typescript';\n      includeDown?: boolean;\n      packageName?: string;\n      /**\n       * Render new tables from their structured columns through the engine's\n       * DDL strategy (default, `true`) — the same renderer `db:migrate` uses,\n       * so column types, indexes and triggers match what the differ expects\n       * on the next run.\n       *\n       * @deprecated Passing `false` re-enables the retired cached-`ddl` string\n       * path for the CREATE TABLE only (#2358): it emits the manifest's\n       * engine-neutral CREATE TABLE with only bare PostgreSQL `TIMESTAMP`\n       * rewritten, so `REAL`/`JSON` drift on PostgreSQL. The table's indexes\n       * and triggers are still rendered through the engine strategy either\n       * way — the flag never suppresses them. Schemas that expose no\n       * structured columns always fall back to their cached `ddl` regardless\n       * of this flag.\n       */\n      materializeStructuredSchema?: boolean;\n    } = {},\n  ) {\n    this.engine = options.engine || 'sqlite';\n    this.format = options.format || 'sql';\n    this.includeDown = options.includeDown ?? true;\n    this.packageName = options.packageName;\n    this.materializeStructuredSchema =\n      options.materializeStructuredSchema ?? true;\n  }\n\n  /**\n   * Generate a migration from a schema diff\n   */\n  generateFromDiff(\n    diff: SchemaDiff,\n    options: GenerateMigrationOptions,\n  ): GeneratedMigration {\n    const upStatements: string[] = [];\n    const downStatements: string[] = [];\n\n    // Handle new tables: CREATE TABLE plus the table's indexes and triggers,\n    // exactly as the migration orchestrator emits them (#2358). The differ\n    // only produces `add_index` changes for tables that already exist, so\n    // there is no double emission against `diff.changes`.\n    for (const schema of diff.added_tables) {\n      upStatements.push(this.generateCreateTable(schema));\n      upStatements.push(...this.generateTableIndexes(schema));\n      upStatements.push(...this.generateTableTriggers(schema));\n      if (this.includeDown || options.includeDown) {\n        downStatements.push(this.generateDropTable(schema.tableName));\n      }\n    }\n\n    // Handle column and index changes\n    for (const change of diff.changes) {\n      const { up, down } = this.generateChangeSQL(change);\n      upStatements.push(...up);\n      if ((this.includeDown || options.includeDown) && down.length > 0) {\n        downStatements.push(...down);\n      }\n    }\n\n    // Handle dropped tables (already in SQL form if present)\n    for (const tableName of diff.dropped_tables) {\n      upStatements.push(this.generateDropTable(tableName));\n      // No automatic DOWN for drops - too dangerous\n    }\n\n    return this.generateMigration(upStatements, downStatements, options);\n  }\n\n  /**\n   * Generate a migration from explicit SQL statements\n   */\n  generateFromSQL(\n    upStatements: string[],\n    downStatements: string[],\n    options: GenerateMigrationOptions,\n  ): GeneratedMigration {\n    return this.generateMigration(upStatements, downStatements, options);\n  }\n\n  /**\n   * Generate an empty migration template\n   */\n  generateEmpty(options: GenerateMigrationOptions): GeneratedMigration {\n    return this.generateMigration([], [], options);\n  }\n\n  /**\n   * Core migration generation logic\n   */\n  private generateMigration(\n    upStatements: string[],\n    downStatements: string[],\n    options: GenerateMigrationOptions,\n  ): GeneratedMigration {\n    const id = options.name;\n    const description = options.description || `Migration: ${options.name}`;\n    const format = options.format || this.format;\n    const filename = `${id}.${format === 'sql' ? 'sql' : 'ts'}`;\n    const checksum = computeChecksum(upStatements);\n\n    let content: string;\n    if (format === 'sql') {\n      content = this.generateSQLFile(\n        id,\n        description,\n        upStatements,\n        downStatements,\n      );\n    } else {\n      content = this.generateTypeScriptFile(\n        id,\n        description,\n        upStatements,\n        downStatements,\n      );\n    }\n\n    return {\n      id,\n      filename,\n      content,\n      up: upStatements,\n      down: downStatements,\n      checksum,\n    };\n  }\n\n  /**\n   * Generate SQL migration file content\n   */\n  private generateSQLFile(\n    id: string,\n    description: string,\n    upStatements: string[],\n    downStatements: string[],\n  ): string {\n    const lines: string[] = [\n      `-- @id: ${id}`,\n      `-- @description: ${description}`,\n      `-- @generated: ${new Date().toISOString()}`,\n    ];\n\n    if (this.packageName) {\n      lines.push(`-- @package: ${this.packageName}`);\n    }\n\n    lines.push('');\n    lines.push('-- @up');\n\n    if (upStatements.length === 0) {\n      lines.push('-- Add your UP statements here');\n    } else {\n      for (const stmt of upStatements) {\n        lines.push(this.terminateStatement(stmt));\n      }\n    }\n\n    lines.push('');\n    lines.push('-- @down');\n\n    if (downStatements.length === 0) {\n      lines.push('-- Add your DOWN statements here');\n    } else {\n      for (const stmt of downStatements) {\n        lines.push(this.terminateStatement(stmt));\n      }\n    }\n\n    lines.push('');\n    return lines.join('\\n');\n  }\n\n  /**\n   * Generate TypeScript migration file content\n   */\n  private generateTypeScriptFile(\n    id: string,\n    description: string,\n    upStatements: string[],\n    downStatements: string[],\n  ): string {\n    const upStatementsStr =\n      upStatements.length > 0\n        ? upStatements\n            .map((s) => `      await db.query(\\`${this.escapeTemplate(s)}\\`);`)\n            .join('\\n')\n        : '      // Add your UP statements here';\n\n    const downStatementsStr =\n      downStatements.length > 0\n        ? downStatements\n            .map((s) => `      await db.query(\\`${this.escapeTemplate(s)}\\`);`)\n            .join('\\n')\n        : '      // Add your DOWN statements here';\n\n    return `/**\n * Migration: ${id}\n * ${description}\n *\n * Generated: ${new Date().toISOString()}\n */\n\nimport type { Migration } from '@happyvertical/smrt-core';\n\nexport default {\n  id: '${id}',\n  description: '${description.replace(/'/g, \"\\\\'\")}',\n  version: '1.0.0',\n\n  up: async (db) => {\n${upStatementsStr}\n  },\n\n  down: async (db) => {\n${downStatementsStr}\n  },\n} satisfies Migration;\n`;\n  }\n\n  /**\n   * Generate CREATE TABLE SQL from schema definition\n   */\n  private generateCreateTable(schema: SchemaDefinition): string {\n    if (Object.keys(schema.columns).length === 0 && schema.ddl?.trim()) {\n      // Structured materialization cannot preserve constraints or vendor SQL\n      // when an older/custom manifest exposes only executable DDL. Retain the\n      // only valid representation even when materialization was requested.\n      return materializeManifestDDLForEngine(schema.ddl, this.engine);\n    }\n\n    if (!this.materializeStructuredSchema && schema.ddl?.trim()) {\n      // Deprecated opt-out (#2358): the cached string is engine-neutral and\n      // index-less; only bare PostgreSQL TIMESTAMP is rewritten.\n      return materializeManifestDDLForEngine(schema.ddl, this.engine);\n    }\n\n    // The manifest's pre-generated `ddl` is deliberately engine-neutral and\n    // may contain abstract TIMESTAMP/JSON/UUID types. Materialize the\n    // structured columns through the selected engine strategy; executing the\n    // cached string on PostgreSQL would otherwise bypass TIMESTAMPTZ and lose\n    // JavaScript Date offsets (#2069). This matches the migration orchestrator\n    // and also prevents JSON/REAL/UUID drift after a create.\n    if (schema.ddl?.trim()) {\n      // Table-level constraints that live only in a hand-authored cached\n      // string cannot be represented structurally and are dropped — as\n      // `db:migrate` already drops them. Say so instead of losing them\n      // silently (#2358).\n      const constraints = cachedDdlTableConstraints(schema.ddl);\n      if (constraints.length > 0) {\n        logger.warn(\n          `[MigrationGenerator] cached ddl for table \"${schema.tableName}\" declares ` +\n            `${constraints.length} table constraint(s) that structured columns cannot ` +\n            `carry (${constraints.join('; ')}); the structured schema is authoritative ` +\n            `and they are not rendered (#2358).`,\n        );\n      }\n    }\n    return getDDLStrategy(this.engine).generateCreateTable(schema);\n  }\n\n  /**\n   * Generate the CREATE INDEX statements for a new table through the engine\n   * strategy (partial `WHERE`, JSON-path targets, inline-UNIQUE engines).\n   */\n  private generateTableIndexes(schema: SchemaDefinition): string[] {\n    return getDDLStrategy(this.engine).generateIndexes(schema);\n  }\n\n  /**\n   * Generate the CREATE TRIGGER statements for a new table (engines without\n   * trigger support return none).\n   */\n  private generateTableTriggers(schema: SchemaDefinition): string[] {\n    return getDDLStrategy(this.engine).generateTriggers(schema);\n  }\n\n  /**\n   * Generate DROP TABLE SQL\n   */\n  private generateDropTable(tableName: string): string {\n    return `DROP TABLE IF EXISTS ${this.quoteIdentifier(tableName)}`;\n  }\n\n  /**\n   * Generate SQL for a schema change\n   */\n  private generateChangeSQL(change: SchemaChange): {\n    up: string[];\n    down: string[];\n  } {\n    const up: string[] = [];\n    const down: string[] = [];\n    const sqlStatements =\n      change.sqlStatements ?? (change.sql ? [change.sql] : []);\n\n    switch (change.type) {\n      case 'add_column':\n        if (sqlStatements.length > 0) {\n          up.push(...sqlStatements);\n        } else if (change.column && change.name) {\n          up.push(\n            this.generateAddColumn(change.table, change.name, change.column),\n          );\n        }\n        if (change.name) {\n          down.push(this.generateDropColumn(change.table, change.name));\n        }\n        break;\n\n      case 'drop_column':\n        if (sqlStatements.length > 0) {\n          up.push(...sqlStatements);\n        } else if (change.name) {\n          up.push(this.generateDropColumn(change.table, change.name));\n        }\n        // No automatic DOWN for drops\n        break;\n\n      case 'add_index':\n        if (sqlStatements.length > 0) {\n          up.push(...sqlStatements);\n        } else if (change.index) {\n          up.push(this.generateAddIndex(change.table, change.index));\n        }\n        if (change.name) {\n          down.push(this.generateDropIndex(change.name));\n        }\n        break;\n\n      case 'drop_index':\n        if (change.name) {\n          up.push(this.generateDropIndex(change.name));\n        }\n        // No automatic DOWN for index drops\n        break;\n\n      case 'type_upgrade':\n        // Type upgrades are safe conversions that SMRT can handle automatically\n        // The SQL is generated by the differ based on engine-specific requirements\n        if (sqlStatements.length > 0) {\n          for (const sql of sqlStatements) {\n            // Skip comment-only SQL (indicates a no-op migration)\n            if (!sql.startsWith('--')) {\n              up.push(sql);\n            }\n          }\n        }\n        // No automatic DOWN for type changes - could lose data\n        break;\n\n      case 'type_mismatch':\n        // Type mismatches require manual intervention\n        up.push(`-- WARNING: Type mismatch for ${change.table}.${change.name}`);\n        up.push(\n          `-- Expected: ${change.mismatch?.expected}, Actual: ${change.mismatch?.actual}`,\n        );\n        up.push(`-- Manual migration required`);\n        break;\n\n      case 'alter_column':\n        // Nullability/default repairs (#2369). Executable statements come\n        // from the differ (backfill + ALTER COLUMN); comment-only SQL marks\n        // an in-place limitation (SQLite) and is surfaced as a note. Report-\n        // only advisories (relaxations not opted into) are not emitted.\n        if (change.advisory && sqlStatements.length === 0) {\n          break;\n        }\n        for (const sql of sqlStatements) {\n          up.push(sql);\n        }\n        // No automatic DOWN: the previous nullability/default is not\n        // captured with enough fidelity to restore it safely.\n        break;\n\n      case 'orphan_column':\n      case 'orphan_index':\n        // Report-only: surface the advisory as comments so a generated\n        // migration file documents the drift without acting on it.\n        up.push(\n          `-- ${change.advisory?.severity === 'warning' ? 'WARNING' : 'NOTE'}: ${change.type === 'orphan_column' ? 'Orphan column' : 'Orphan unique constraint'} ${change.table}.${change.name} (${change.mismatch?.actual ?? 'unknown shape'})`,\n        );\n        if (change.advisory?.message) {\n          up.push(`-- ${change.advisory.message}`);\n        }\n        for (const suggestion of change.advisory?.suggestedSql ?? []) {\n          up.push(`-- suggested: ${suggestion}`);\n        }\n        break;\n\n      default:\n        // Unknown change type\n        break;\n    }\n\n    return { up, down };\n  }\n\n  /**\n   * Generate ADD COLUMN SQL\n   */\n  private generateAddColumn(\n    tableName: string,\n    colName: string,\n    colDef: import('../schema/types.js').ColumnDefinition,\n  ): string {\n    const parts: string[] = [this.quoteIdentifier(colName), colDef.type];\n\n    if (colDef.notNull) {\n      parts.push('NOT NULL');\n    }\n    if (colDef.unique) {\n      parts.push('UNIQUE');\n    }\n    if (colDef.defaultValue !== undefined) {\n      parts.push(`DEFAULT ${this.formatDefaultValue(colDef.defaultValue)}`);\n    }\n\n    return `ALTER TABLE ${this.quoteIdentifier(tableName)} ADD COLUMN ${parts.join(' ')}`;\n  }\n\n  /**\n   * Generate DROP COLUMN SQL\n   */\n  private generateDropColumn(tableName: string, colName: string): string {\n    return `ALTER TABLE ${this.quoteIdentifier(tableName)} DROP COLUMN ${this.quoteIdentifier(colName)}`;\n  }\n\n  /**\n   * Generate ADD INDEX SQL\n   */\n  private generateAddIndex(\n    tableName: string,\n    index: import('../schema/types.js').IndexDefinition,\n  ): string {\n    const uniqueStr = index.unique ? 'UNIQUE ' : '';\n    const target = renderIndexTarget(index, this.engine);\n    // Partial-index predicate. DuckDB (and the JSON adapter backed by it)\n    // rejects partial indexes, so the declaration degrades to a full index\n    // there — matching the differ and the DuckDB DDL strategy.\n    const whereClause =\n      this.engine !== 'duckdb' && index.where ? ` WHERE ${index.where}` : '';\n\n    if (this.engine === 'postgres') {\n      // PostgreSQL: use CONCURRENTLY for production safety\n      return `CREATE ${uniqueStr}INDEX CONCURRENTLY IF NOT EXISTS ${this.quoteIdentifier(index.name)} ON ${this.quoteIdentifier(tableName)} (${target})${whereClause}`;\n    }\n\n    return `CREATE ${uniqueStr}INDEX IF NOT EXISTS ${this.quoteIdentifier(index.name)} ON ${this.quoteIdentifier(tableName)} (${target})${whereClause}`;\n  }\n\n  /**\n   * Generate DROP INDEX SQL\n   */\n  private generateDropIndex(indexName: string): string {\n    if (this.engine === 'postgres') {\n      return `DROP INDEX CONCURRENTLY IF EXISTS ${this.quoteIdentifier(indexName)}`;\n    }\n    return `DROP INDEX IF EXISTS ${this.quoteIdentifier(indexName)}`;\n  }\n\n  /**\n   * Quote a SQL identifier\n   */\n  private quoteIdentifier(name: string): string {\n    return `\"${name.replace(/\"/g, '\"\"')}\"`;\n  }\n\n  /**\n   * Format a default value for SQL\n   */\n  private formatDefaultValue(value: unknown): string {\n    if (value === null) return 'NULL';\n    if (typeof value === 'string') return `'${value.replace(/'/g, \"''\")}'`;\n    if (typeof value === 'boolean') return value ? '1' : '0';\n    if (typeof value === 'number') return String(value);\n    return String(value);\n  }\n\n  /**\n   * Terminate a statement with exactly one `;` for the SQL file format.\n   *\n   * Strategy-rendered statements (`generateCreateTable`, `generateIndexes`,\n   * `generateTriggers`) already end with `;`, while differ-produced ALTERs do\n   * not — appending unconditionally wrote `;;` (#2406 review).\n   */\n  private terminateStatement(stmt: string): string {\n    return stmt.trimEnd().endsWith(';') ? stmt : `${stmt};`;\n  }\n\n  /**\n   * Escape template literal content\n   */\n  private escapeTemplate(str: string): string {\n    return str.replace(/`/g, '\\\\`').replace(/\\$/g, '\\\\$');\n  }\n}\n\n/**\n * Generate a migration definition from UP and DOWN statements\n */\nexport function createMigrationDefinition(\n  id: string,\n  upStatements: string[],\n  downStatements: string[] = [],\n  options: {\n    description?: string;\n    version?: string;\n    packageName?: string;\n    sourceFile?: string;\n  } = {},\n): MigrationDefinition {\n  return {\n    id,\n    description: options.description || `Migration: ${id}`,\n    version: options.version || '1.0.0',\n    up: upStatements,\n    down: downStatements,\n    package_name: options.packageName,\n    source_file: options.sourceFile,\n  };\n}\n\n/**\n * Generate a sequence number for a new migration\n */\nexport function generateMigrationSequence(existingIds: string[]): string {\n  const sequences = existingIds\n    .map((id) => {\n      const match = id.match(/^(\\d+)_/);\n      return match ? parseInt(match[1], 10) : 0;\n    })\n    .filter((n) => !Number.isNaN(n));\n\n  const maxSequence = sequences.length > 0 ? Math.max(...sequences) : 0;\n  return String(maxSequence + 1).padStart(4, '0');\n}\n\n/**\n * Generate a timestamp-based migration ID\n */\nexport function generateMigrationTimestamp(): string {\n  const now = new Date();\n  return [\n    now.getFullYear(),\n    String(now.getMonth() + 1).padStart(2, '0'),\n    String(now.getDate()).padStart(2, '0'),\n    String(now.getHours()).padStart(2, '0'),\n    String(now.getMinutes()).padStart(2, '0'),\n    String(now.getSeconds()).padStart(2, '0'),\n  ].join('');\n}\n"],"mappings":";;;;;;;;;;;;;;AAqBA,IAAM,SAAS,aAAa,EAAE,OAAO,OAAO,CAAC;;;;AAyC7C,IAAa,qBAAb,MAAgC;CAC9B;CACA;CACA;CACA;CACA;CAEA,YACE,UAqBI,CAAC,GACL;EACA,KAAK,SAAS,QAAQ,UAAU;EAChC,KAAK,SAAS,QAAQ,UAAU;EAChC,KAAK,cAAc,QAAQ,eAAe;EAC1C,KAAK,cAAc,QAAQ;EAC3B,KAAK,8BACH,QAAQ,+BAA+B;CAC3C;;;;CAKA,iBACE,MACA,SACoB;EACpB,MAAM,eAAyB,CAAC;EAChC,MAAM,iBAA2B,CAAC;EAMlC,KAAK,MAAM,UAAU,KAAK,cAAc;GACtC,aAAa,KAAK,KAAK,oBAAoB,MAAM,CAAC;GAClD,aAAa,KAAK,GAAG,KAAK,qBAAqB,MAAM,CAAC;GACtD,aAAa,KAAK,GAAG,KAAK,sBAAsB,MAAM,CAAC;GACvD,IAAI,KAAK,eAAe,QAAQ,aAC9B,eAAe,KAAK,KAAK,kBAAkB,OAAO,SAAS,CAAC;EAEhE;EAGA,KAAK,MAAM,UAAU,KAAK,SAAS;GACjC,MAAM,EAAE,IAAI,SAAS,KAAK,kBAAkB,MAAM;GAClD,aAAa,KAAK,GAAG,EAAE;GACvB,KAAK,KAAK,eAAe,QAAQ,gBAAgB,KAAK,SAAS,GAC7D,eAAe,KAAK,GAAG,IAAI;EAE/B;EAGA,KAAK,MAAM,aAAa,KAAK,gBAC3B,aAAa,KAAK,KAAK,kBAAkB,SAAS,CAAC;EAIrD,OAAO,KAAK,kBAAkB,cAAc,gBAAgB,OAAO;CACrE;;;;CAKA,gBACE,cACA,gBACA,SACoB;EACpB,OAAO,KAAK,kBAAkB,cAAc,gBAAgB,OAAO;CACrE;;;;CAKA,cAAc,SAAuD;EACnE,OAAO,KAAK,kBAAkB,CAAC,GAAG,CAAC,GAAG,OAAO;CAC/C;;;;CAKA,kBACE,cACA,gBACA,SACoB;EACpB,MAAM,KAAK,QAAQ;EACnB,MAAM,cAAc,QAAQ,eAAe,cAAc,QAAQ;EACjE,MAAM,SAAS,QAAQ,UAAU,KAAK;EACtC,MAAM,WAAW,GAAG,GAAG,GAAG,WAAW,QAAQ,QAAQ;EACrD,MAAM,WAAW,gBAAgB,YAAY;EAE7C,IAAI;EACJ,IAAI,WAAW,OACb,UAAU,KAAK,gBACb,IACA,aACA,cACA,cACF;OAEA,UAAU,KAAK,uBACb,IACA,aACA,cACA,cACF;EAGF,OAAO;GACL;GACA;GACA;GACA,IAAI;GACJ,MAAM;GACN;EACF;CACF;;;;CAKA,gBACE,IACA,aACA,cACA,gBACQ;EACR,MAAM,QAAkB;GACtB,WAAW;GACX,oBAAoB;GACpB,mCAAkB,IAAI,KAAK,EAAA,CAAE,YAAY;EAC3C;EAEA,IAAI,KAAK,aACP,MAAM,KAAK,gBAAgB,KAAK,aAAa;EAG/C,MAAM,KAAK,EAAE;EACb,MAAM,KAAK,QAAQ;EAEnB,IAAI,aAAa,WAAW,GAC1B,MAAM,KAAK,gCAAgC;OAE3C,KAAK,MAAM,QAAQ,cACjB,MAAM,KAAK,KAAK,mBAAmB,IAAI,CAAC;EAI5C,MAAM,KAAK,EAAE;EACb,MAAM,KAAK,UAAU;EAErB,IAAI,eAAe,WAAW,GAC5B,MAAM,KAAK,kCAAkC;OAE7C,KAAK,MAAM,QAAQ,gBACjB,MAAM,KAAK,KAAK,mBAAmB,IAAI,CAAC;EAI5C,MAAM,KAAK,EAAE;EACb,OAAO,MAAM,KAAK,IAAI;CACxB;;;;CAKA,uBACE,IACA,aACA,cACA,gBACQ;EACR,MAAM,kBACJ,aAAa,SAAS,IAClB,aACG,KAAK,MAAM,0BAA0B,KAAK,eAAe,CAAC,EAAE,KAAK,CAAC,CAClE,KAAK,IAAI,IACZ;EAEN,MAAM,oBACJ,eAAe,SAAS,IACpB,eACG,KAAK,MAAM,0BAA0B,KAAK,eAAe,CAAC,EAAE,KAAK,CAAC,CAClE,KAAK,IAAI,IACZ;EAEN,OAAO;gBACK,GAAG;KACd,YAAY;;iCAED,IAAI,KAAK,EAAA,CAAE,YAAY,EAAE;;;;;;SAMhC,GAAG;kBACM,YAAY,QAAQ,MAAM,KAAK,EAAE;;;;EAIjD,gBAAgB;;;;EAIhB,kBAAkB;;;;CAIlB;;;;CAKA,oBAA4B,QAAkC;EAC5D,IAAI,OAAO,KAAK,OAAO,OAAO,CAAC,CAAC,WAAW,KAAK,OAAO,KAAK,KAAK,GAI/D,OAAO,gCAAgC,OAAO,KAAK,KAAK,MAAM;EAGhE,IAAI,CAAC,KAAK,+BAA+B,OAAO,KAAK,KAAK,GAGxD,OAAO,gCAAgC,OAAO,KAAK,KAAK,MAAM;EAShE,IAAI,OAAO,KAAK,KAAK,GAAG;GAKtB,MAAM,cAAc,0BAA0B,OAAO,GAAG;GACxD,IAAI,YAAY,SAAS,GACvB,OAAO,KACL,8CAA8C,OAAO,UAAU,aAC1D,YAAY,OAAO,6DACZ,YAAY,KAAK,IAAI,EAAE,6EAErC;EAEJ;EACA,OAAO,eAAe,KAAK,MAAM,CAAC,CAAC,oBAAoB,MAAM;CAC/D;;;;;CAMA,qBAA6B,QAAoC;EAC/D,OAAO,eAAe,KAAK,MAAM,CAAC,CAAC,gBAAgB,MAAM;CAC3D;;;;;CAMA,sBAA8B,QAAoC;EAChE,OAAO,eAAe,KAAK,MAAM,CAAC,CAAC,iBAAiB,MAAM;CAC5D;;;;CAKA,kBAA0B,WAA2B;EACnD,OAAO,wBAAwB,KAAK,gBAAgB,SAAS;CAC/D;;;;CAKA,kBAA0B,QAGxB;EACA,MAAM,KAAe,CAAC;EACtB,MAAM,OAAiB,CAAC;EACxB,MAAM,gBACJ,OAAO,kBAAkB,OAAO,MAAM,CAAC,OAAO,GAAG,IAAI,CAAC;EAExD,QAAQ,OAAO,MAAf;GACE,KAAK;IACH,IAAI,cAAc,SAAS,GACzB,GAAG,KAAK,GAAG,aAAa;SACnB,IAAI,OAAO,UAAU,OAAO,MACjC,GAAG,KACD,KAAK,kBAAkB,OAAO,OAAO,OAAO,MAAM,OAAO,MAAM,CACjE;IAEF,IAAI,OAAO,MACT,KAAK,KAAK,KAAK,mBAAmB,OAAO,OAAO,OAAO,IAAI,CAAC;IAE9D;GAEF,KAAK;IACH,IAAI,cAAc,SAAS,GACzB,GAAG,KAAK,GAAG,aAAa;SACnB,IAAI,OAAO,MAChB,GAAG,KAAK,KAAK,mBAAmB,OAAO,OAAO,OAAO,IAAI,CAAC;IAG5D;GAEF,KAAK;IACH,IAAI,cAAc,SAAS,GACzB,GAAG,KAAK,GAAG,aAAa;SACnB,IAAI,OAAO,OAChB,GAAG,KAAK,KAAK,iBAAiB,OAAO,OAAO,OAAO,KAAK,CAAC;IAE3D,IAAI,OAAO,MACT,KAAK,KAAK,KAAK,kBAAkB,OAAO,IAAI,CAAC;IAE/C;GAEF,KAAK;IACH,IAAI,OAAO,MACT,GAAG,KAAK,KAAK,kBAAkB,OAAO,IAAI,CAAC;IAG7C;GAEF,KAAK;IAGH,IAAI,cAAc,SAAS;UACpB,MAAM,OAAO,eAEhB,IAAI,CAAC,IAAI,WAAW,IAAI,GACtB,GAAG,KAAK,GAAG;IAAA;IAKjB;GAEF,KAAK;IAEH,GAAG,KAAK,iCAAiC,OAAO,MAAM,GAAG,OAAO,MAAM;IACtE,GAAG,KACD,gBAAgB,OAAO,UAAU,SAAS,YAAY,OAAO,UAAU,QACzE;IACA,GAAG,KAAK,8BAA8B;IACtC;GAEF,KAAK;IAKH,IAAI,OAAO,YAAY,cAAc,WAAW,GAC9C;IAEF,KAAK,MAAM,OAAO,eAChB,GAAG,KAAK,GAAG;IAIb;GAEF,KAAK;GACL,KAAK;IAGH,GAAG,KACD,MAAM,OAAO,UAAU,aAAa,YAAY,YAAY,OAAO,IAAI,OAAO,SAAS,kBAAkB,kBAAkB,2BAA2B,GAAG,OAAO,MAAM,GAAG,OAAO,KAAK,IAAI,OAAO,UAAU,UAAU,gBAAgB,EACtO;IACA,IAAI,OAAO,UAAU,SACnB,GAAG,KAAK,MAAM,OAAO,SAAS,SAAS;IAEzC,KAAK,MAAM,cAAc,OAAO,UAAU,gBAAgB,CAAC,GACzD,GAAG,KAAK,iBAAiB,YAAY;IAEvC;GAEF,SAEE;EACJ;EAEA,OAAO;GAAE;GAAI;EAAK;CACpB;;;;CAKA,kBACE,WACA,SACA,QACQ;EACR,MAAM,QAAkB,CAAC,KAAK,gBAAgB,OAAO,GAAG,OAAO,IAAI;EAEnE,IAAI,OAAO,SACT,MAAM,KAAK,UAAU;EAEvB,IAAI,OAAO,QACT,MAAM,KAAK,QAAQ;EAErB,IAAI,OAAO,iBAAiB,KAAA,GAC1B,MAAM,KAAK,WAAW,KAAK,mBAAmB,OAAO,YAAY,GAAG;EAGtE,OAAO,eAAe,KAAK,gBAAgB,SAAS,EAAE,cAAc,MAAM,KAAK,GAAG;CACpF;;;;CAKA,mBAA2B,WAAmB,SAAyB;EACrE,OAAO,eAAe,KAAK,gBAAgB,SAAS,EAAE,eAAe,KAAK,gBAAgB,OAAO;CACnG;;;;CAKA,iBACE,WACA,OACQ;EACR,MAAM,YAAY,MAAM,SAAS,YAAY;EAC7C,MAAM,SAAS,kBAAkB,OAAO,KAAK,MAAM;EAInD,MAAM,cACJ,KAAK,WAAW,YAAY,MAAM,QAAQ,UAAU,MAAM,UAAU;EAEtE,IAAI,KAAK,WAAW,YAElB,OAAO,UAAU,UAAU,mCAAmC,KAAK,gBAAgB,MAAM,IAAI,EAAE,MAAM,KAAK,gBAAgB,SAAS,EAAE,IAAI,OAAO,GAAG;EAGrJ,OAAO,UAAU,UAAU,sBAAsB,KAAK,gBAAgB,MAAM,IAAI,EAAE,MAAM,KAAK,gBAAgB,SAAS,EAAE,IAAI,OAAO,GAAG;CACxI;;;;CAKA,kBAA0B,WAA2B;EACnD,IAAI,KAAK,WAAW,YAClB,OAAO,qCAAqC,KAAK,gBAAgB,SAAS;EAE5E,OAAO,wBAAwB,KAAK,gBAAgB,SAAS;CAC/D;;;;CAKA,gBAAwB,MAAsB;EAC5C,OAAO,IAAI,KAAK,QAAQ,MAAM,MAAI,EAAE;CACtC;;;;CAKA,mBAA2B,OAAwB;EACjD,IAAI,UAAU,MAAM,OAAO;EAC3B,IAAI,OAAO,UAAU,UAAU,OAAO,IAAI,MAAM,QAAQ,MAAM,IAAI,EAAE;EACpE,IAAI,OAAO,UAAU,WAAW,OAAO,QAAQ,MAAM;EACrD,IAAI,OAAO,UAAU,UAAU,OAAO,OAAO,KAAK;EAClD,OAAO,OAAO,KAAK;CACrB;;;;;;;;CASA,mBAA2B,MAAsB;EAC/C,OAAO,KAAK,QAAQ,CAAC,CAAC,SAAS,GAAG,IAAI,OAAO,GAAG,KAAK;CACvD;;;;CAKA,eAAuB,KAAqB;EAC1C,OAAO,IAAI,QAAQ,MAAM,KAAK,CAAC,CAAC,QAAQ,OAAO,KAAK;CACtD;AACF;;;;AAKA,SAAgB,0BACd,IACA,cACA,iBAA2B,CAAC,GAC5B,UAKI,CAAC,GACgB;CACrB,OAAO;EACL;EACA,aAAa,QAAQ,eAAe,cAAc;EAClD,SAAS,QAAQ,WAAW;EAC5B,IAAI;EACJ,MAAM;EACN,cAAc,QAAQ;EACtB,aAAa,QAAQ;CACvB;AACF;;;;AAKA,SAAgB,0BAA0B,aAA+B;CACvE,MAAM,YAAY,YACf,KAAK,OAAO;EACX,MAAM,QAAQ,GAAG,MAAM,SAAS;EAChC,OAAO,QAAQ,SAAS,MAAM,IAAI,EAAE,IAAI;CAC1C,CAAC,CAAC,CACD,QAAQ,MAAM,CAAC,OAAO,MAAM,CAAC,CAAC;CAEjC,MAAM,cAAc,UAAU,SAAS,IAAI,KAAK,IAAI,GAAG,SAAS,IAAI;CACpE,OAAO,OAAO,cAAc,CAAC,CAAC,CAAC,SAAS,GAAG,GAAG;AAChD;;;;AAKA,SAAgB,6BAAqC;CACnD,MAAM,sBAAM,IAAI,KAAK;CACrB,OAAO;EACL,IAAI,YAAY;EAChB,OAAO,IAAI,SAAS,IAAI,CAAC,CAAC,CAAC,SAAS,GAAG,GAAG;EAC1C,OAAO,IAAI,QAAQ,CAAC,CAAC,CAAC,SAAS,GAAG,GAAG;EACrC,OAAO,IAAI,SAAS,CAAC,CAAC,CAAC,SAAS,GAAG,GAAG;EACtC,OAAO,IAAI,WAAW,CAAC,CAAC,CAAC,SAAS,GAAG,GAAG;EACxC,OAAO,IAAI,WAAW,CAAC,CAAC,CAAC,SAAS,GAAG,GAAG;CAC1C,CAAC,CAAC,KAAK,EAAE;AACX"}

package/dist/migrations/index.d.ts

@@ -11,10 +11,11 @@
 export { type BackfillRecord, BackfillTableUnavailableError, BackfillTracker, type BackfillTrackerOptions, } from './backfill-tracker.js';
 export { computeChecksum, normalizeSQL, shortChecksum, verifyChecksum, } from './checksum.js';
 export type { DiffOptions } from './differ.js';
-export { generateSchemaDiff, getSQLFromDiff, hasActionableChanges, SchemaComparer, } from './differ.js';
+export { canonicalizeDefault, generateSchemaDiff, getSQLFromDiff, hasActionableChanges, isAdvisoryOnlyChange, isInfoOnlyChange, isManualOrAdvisoryChange, SchemaComparer, uniqueColumnIndexName, } from './differ.js';
 export type { GeneratedMigration, GenerateMigrationOptions, } from './generator.js';
 export { createMigrationDefinition, generateMigrationSequence, generateMigrationTimestamp, MigrationGenerator, } from './generator.js';
 export { getPendingSchemaStatements, type MigrateSmrtSchemasOptions, type MigrateSmrtSchemasResult, migrateSmrtSchemas, type PendingSchemaStatementsResult, } from './orchestrate.js';
-export { MigrationTracker, planPostgresStatements } from './tracker.js';
+export { type BuildSqliteRebuildStatementsInput, buildSqliteRebuildStatements, isSqliteRebuildPlaceholder, type PlanSqliteTableRebuildsOptions, planSqliteTableRebuilds, rewriteSqliteCreateTable, SQLITE_REBUILD_TABLE_PREFIX, type SqliteTableRebuildPlan, sqliteRebuildPlaceholderSql, } from './sqlite-rebuild.js';
+export { buildConcurrentIndexPlan, extractCreatedIndexName, MigrationTracker, parsePostgresTimeoutMs, planPostgresStatements, } from './tracker.js';
 export type { ApplyMigrationsOptions, ColumnDefinitionWithName, ColumnInfo, DatabaseEngine, DatabaseInterface, DataMigration, DataMigrationResult, DataMigrationStatement, DriftReport, ForeignKeyInfo, IndexDefinition, IndexInfo, MigrationDefinition, MigrationMode, MigrationResult, MigrationStatus, MigrationsConfig, MigrationTrackerOptions, ParsedMigrationFile, ParseMigrationOptions, RollbackOptions, SchemaChange, SchemaDiff, SchemaMigrationRecord, StiDiscriminatorMigration, TableSchemaInfo, } from './types.js';
 //# sourceMappingURL=index.d.ts.map

package/dist/migrations/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/migrations/index.ts"],"names":[],"mappings":"AAAA;;;;;;;;;GASG;AAGH,OAAO,EACL,KAAK,cAAc,EACnB,6BAA6B,EAC7B,eAAe,EACf,KAAK,sBAAsB,GAC5B,MAAM,uBAAuB,CAAC;AAE/B,OAAO,EACL,eAAe,EACf,YAAY,EACZ,aAAa,EACb,cAAc,GACf,MAAM,eAAe,CAAC;AACvB,YAAY,EAAE,WAAW,EAAE,MAAM,aAAa,CAAC;AAE/C,OAAO,EACL,kBAAkB,EAClB,cAAc,EACd,oBAAoB,EACpB,cAAc,GACf,MAAM,aAAa,CAAC;AACrB,YAAY,EACV,kBAAkB,EAClB,wBAAwB,GACzB,MAAM,gBAAgB,CAAC;AAExB,OAAO,EACL,yBAAyB,EACzB,yBAAyB,EACzB,0BAA0B,EAC1B,kBAAkB,GACnB,MAAM,gBAAgB,CAAC;AAExB,OAAO,EACL,0BAA0B,EAC1B,KAAK,yBAAyB,EAC9B,KAAK,wBAAwB,EAC7B,kBAAkB,EAClB,KAAK,6BAA6B,GACnC,MAAM,kBAAkB,CAAC;AAE1B,OAAO,EAAE,gBAAgB,EAAE,sBAAsB,EAAE,MAAM,cAAc,CAAC;AAGxE,YAAY,EACV,sBAAsB,EACtB,wBAAwB,EACxB,UAAU,EACV,cAAc,EACd,iBAAiB,EAEjB,aAAa,EACb,mBAAmB,EACnB,sBAAsB,EACtB,WAAW,EACX,cAAc,EACd,eAAe,EACf,SAAS,EACT,mBAAmB,EACnB,aAAa,EACb,eAAe,EAEf,eAAe,EACf,gBAAgB,EAEhB,uBAAuB,EACvB,mBAAmB,EACnB,qBAAqB,EACrB,eAAe,EACf,YAAY,EACZ,UAAU,EACV,qBAAqB,EACrB,yBAAyB,EACzB,eAAe,GAChB,MAAM,YAAY,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/migrations/index.ts"],"names":[],"mappings":"AAAA;;;;;;;;;GASG;AAGH,OAAO,EACL,KAAK,cAAc,EACnB,6BAA6B,EAC7B,eAAe,EACf,KAAK,sBAAsB,GAC5B,MAAM,uBAAuB,CAAC;AAE/B,OAAO,EACL,eAAe,EACf,YAAY,EACZ,aAAa,EACb,cAAc,GACf,MAAM,eAAe,CAAC;AACvB,YAAY,EAAE,WAAW,EAAE,MAAM,aAAa,CAAC;AAE/C,OAAO,EACL,mBAAmB,EACnB,kBAAkB,EAClB,cAAc,EACd,oBAAoB,EACpB,oBAAoB,EACpB,gBAAgB,EAChB,wBAAwB,EACxB,cAAc,EACd,qBAAqB,GACtB,MAAM,aAAa,CAAC;AACrB,YAAY,EACV,kBAAkB,EAClB,wBAAwB,GACzB,MAAM,gBAAgB,CAAC;AAExB,OAAO,EACL,yBAAyB,EACzB,yBAAyB,EACzB,0BAA0B,EAC1B,kBAAkB,GACnB,MAAM,gBAAgB,CAAC;AAExB,OAAO,EACL,0BAA0B,EAC1B,KAAK,yBAAyB,EAC9B,KAAK,wBAAwB,EAC7B,kBAAkB,EAClB,KAAK,6BAA6B,GACnC,MAAM,kBAAkB,CAAC;AAE1B,OAAO,EACL,KAAK,iCAAiC,EACtC,4BAA4B,EAC5B,0BAA0B,EAC1B,KAAK,8BAA8B,EACnC,uBAAuB,EACvB,wBAAwB,EACxB,2BAA2B,EAC3B,KAAK,sBAAsB,EAC3B,2BAA2B,GAC5B,MAAM,qBAAqB,CAAC;AAE7B,OAAO,EACL,wBAAwB,EACxB,uBAAuB,EACvB,gBAAgB,EAChB,sBAAsB,EACtB,sBAAsB,GACvB,MAAM,cAAc,CAAC;AAGtB,YAAY,EACV,sBAAsB,EACtB,wBAAwB,EACxB,UAAU,EACV,cAAc,EACd,iBAAiB,EAEjB,aAAa,EACb,mBAAmB,EACnB,sBAAsB,EACtB,WAAW,EACX,cAAc,EACd,eAAe,EACf,SAAS,EACT,mBAAmB,EACnB,aAAa,EACb,eAAe,EAEf,eAAe,EACf,gBAAgB,EAEhB,uBAAuB,EACvB,mBAAmB,EACnB,qBAAqB,EACrB,eAAe,EACf,YAAY,EACZ,UAAU,EACV,qBAAqB,EACrB,yBAAyB,EACzB,eAAe,GAChB,MAAM,YAAY,CAAC"}

package/dist/migrations/index.js

@@ -1,7 +1,9 @@
-import { SchemaComparer, generateSchemaDiff, getSQLFromDiff, hasActionableChanges } from "./differ.js";
+import { parsePostgresTimeoutMs } from "../postgres-timeouts.js";
+import { SQLITE_REBUILD_TABLE_PREFIX, buildSqliteRebuildStatements, isSqliteRebuildPlaceholder, planSqliteTableRebuilds, rewriteSqliteCreateTable, sqliteRebuildPlaceholderSql } from "./sqlite-rebuild.js";
+import { SchemaComparer, canonicalizeDefault, generateSchemaDiff, getSQLFromDiff, hasActionableChanges, isAdvisoryOnlyChange, isInfoOnlyChange, isManualOrAdvisoryChange, uniqueColumnIndexName } from "./differ.js";
 import { BackfillTableUnavailableError, BackfillTracker } from "./backfill-tracker.js";
 import { computeChecksum, normalizeSQL, shortChecksum, verifyChecksum } from "./checksum.js";
 import { MigrationGenerator, createMigrationDefinition, generateMigrationSequence, generateMigrationTimestamp } from "./generator.js";
-import { MigrationTracker, planPostgresStatements } from "./tracker.js";
+import { MigrationTracker, buildConcurrentIndexPlan, extractCreatedIndexName, planPostgresStatements } from "./tracker.js";
 import { getPendingSchemaStatements, migrateSmrtSchemas } from "./orchestrate.js";
-export { BackfillTableUnavailableError, BackfillTracker, MigrationGenerator, MigrationTracker, SchemaComparer, computeChecksum, createMigrationDefinition, generateMigrationSequence, generateMigrationTimestamp, generateSchemaDiff, getPendingSchemaStatements, getSQLFromDiff, hasActionableChanges, migrateSmrtSchemas, normalizeSQL, planPostgresStatements, shortChecksum, verifyChecksum };
+export { BackfillTableUnavailableError, BackfillTracker, MigrationGenerator, MigrationTracker, SQLITE_REBUILD_TABLE_PREFIX, SchemaComparer, buildConcurrentIndexPlan, buildSqliteRebuildStatements, canonicalizeDefault, computeChecksum, createMigrationDefinition, extractCreatedIndexName, generateMigrationSequence, generateMigrationTimestamp, generateSchemaDiff, getPendingSchemaStatements, getSQLFromDiff, hasActionableChanges, isAdvisoryOnlyChange, isInfoOnlyChange, isManualOrAdvisoryChange, isSqliteRebuildPlaceholder, migrateSmrtSchemas, normalizeSQL, parsePostgresTimeoutMs, planPostgresStatements, planSqliteTableRebuilds, rewriteSqliteCreateTable, shortChecksum, sqliteRebuildPlaceholderSql, uniqueColumnIndexName, verifyChecksum };

package/dist/migrations/orchestrate.js

@@ -164,12 +164,37 @@ function isCommentOnlySql(sql) {
 	return lines.every((line) => line.startsWith("--"));
 }
 /**
+* True if `sql` is an advisory comment that says *nothing needs to happen* —
+* as opposed to one that says a human has to act.
+*
+* The differ emits both kinds. "This SQLite column already stores JSON as
+* TEXT" and "#2370: this column is rebuilt together with its sibling" are
+* no-ops; "requires table recreation" / "blocked: …" are real manual drift.
+* Treating the first kind as drift makes a fully auto-repairable migration
+* report `hasManualDrift: true`.
+*
+* Keep in sync with `classifyTypeUpgradeSql`'s `noop` arm in
+* `@happyvertical/smrt-cli` (`src/commands/db-migrate-actions.ts`), which
+* applies the same rule on the CLI side.
+*/
+function isNoOpAdvisorySql(sql) {
+	const trimmed = sql.trim();
+	return /no change needed/i.test(trimmed) || /already stores .* as /i.test(trimmed);
+}
+/**
 * Surface changes the differ produced but that the migrator cannot apply
-* automatically — either `type_mismatch` entries (the differ explicitly
-* gives up on these) or `type_upgrade` entries whose generated SQL is
-* advisory-comment-only (SQLite table-recreation cases, etc.). Callers
-* use this to distinguish "schema is in sync" from "schema is drifted but
-* we can't fix it from here."
+* automatically — `type_mismatch` entries (the differ explicitly gives up on
+* these), `type_upgrade`/`alter_column` entries whose generated SQL is
+* advisory-comment-only (a SQLite rebuild that would be unsafe, an in-place
+* constraint change SQLite cannot perform), and warning-level report-only
+* advisories (an orphan NOT NULL column that will break inserts, a required
+* column that could not be enforced, a stale unique constraint, a relaxation
+* the caller has not opted into). Info-level advisories (a harmless orphan
+* column, a stale default) and comments that mean "already handled" (the
+* no-op advisories a table rebuild leaves on covered siblings, #2370) are
+* deliberately excluded so `hasManualDrift` keeps meaning "something needs
+* an operator". Callers use this to distinguish "schema is in sync" from
+* "schema is drifted but we can't fix it from here".
 */
 function collectUnactionableChanges(diff) {
 	const unactionable = [];
@@ -179,7 +204,11 @@ function collectUnactionableChanges(diff) {
 			continue;
 		}
 		const statements = change.sqlStatements ?? (change.sql ? [change.sql] : []);
-		if (statements.length > 0 && statements.every((stmt) => isCommentOnlySql(stmt.trim()))) unactionable.push(change);
+		if (statements.length === 0) {
+			if (change.advisory?.severity === "warning") unactionable.push(change);
+			continue;
+		}
+		if (statements.every((stmt) => isCommentOnlySql(stmt.trim())) && !statements.every((stmt) => isNoOpAdvisorySql(stmt))) unactionable.push(change);
 	}
 	return unactionable;
 }

package/dist/migrations/orchestrate.js.map

@@ -1 +1 @@
-{"version":3,"file":"orchestrate.js","names":[],"sources":["../../src/migrations/orchestrate.ts"],"sourcesContent":["/**\n * High-level \"make my SMRT app's schema match its database\" orchestration.\n *\n * Wraps `ObjectRegistry.getAllSchemasAsDefinitions()` → `generateSchemaDiff`\n * → `MigrationTracker.applyAll`. Apps that just want to run pending\n * schema changes call `migrateSmrtSchemas({ db, packageName, version })`\n * and don't have to assemble the migration definition by hand.\n *\n * The migration name is timestamped, so re-running on an up-to-date\n * database is a no-op (the diff is empty, no statements are generated,\n * `applied: false` is returned).\n */\nimport type { DatabaseInterface } from '@happyvertical/sql';\nimport { ObjectRegistry } from '../registry.js';\nimport { detectEngine, getDDLStrategy } from '../schema/ddl/index.js';\nimport type { DatabaseEngine } from '../schema/ddl/types.js';\nimport type { MigrationResult, SchemaChange } from '../schema/types.js';\nimport {\n  generateSchemaDiff,\n  getSQLFromDiff,\n  hasActionableChanges,\n} from './differ.js';\nimport {\n  createMigrationDefinition,\n  generateMigrationTimestamp,\n} from './generator.js';\nimport { MigrationTracker } from './tracker.js';\n\nexport interface MigrateSmrtSchemasOptions {\n  db: DatabaseInterface;\n  /** Stored on the migration record so the audit log shows which app applied it. */\n  packageName: string;\n  /**\n   * Stored on the migration record. Typically the app's package.json\n   * version. Optional because most apps don't have a runtime-readable\n   * version handy and would hardcode a stale string if forced to supply\n   * one — `'unknown'` is honest. Pass an explicit value when you can\n   * (e.g. `version: process.env.APP_VERSION`).\n   */\n  version?: string;\n  /** Override the description on the synthetic migration definition. */\n  description?: string;\n  /** Override the migration name (default: `<timestamp>_smrt_schema_sync`). */\n  name?: string;\n  /** Forwarded to MigrationTracker — defaults to true for pg-safe runs. */\n  postgresSafe?: boolean;\n  /** Forwarded to MigrationTracker — defaults to true. */\n  reconcile?: boolean;\n  /** Forwarded to MigrationTracker — defaults to true for `CREATE INDEX CONCURRENTLY`. */\n  useConcurrentIndexes?: boolean;\n  /**\n   * Forwarded to MigrationTracker (Postgres lock timeout, milliseconds).\n   * Lets apps that customize tracker timeouts directly preserve their\n   * tuning when going through the orchestrator. Falls back to the\n   * tracker's default (30000ms) when omitted.\n   */\n  lockTimeout?: number;\n  /**\n   * Forwarded to MigrationTracker (Postgres statement timeout, ms). Falls\n   * back to the tracker's default (60000ms) when omitted.\n   */\n  statementTimeout?: number;\n  /**\n   * Explicit engine hint forwarded to `detectEngine`, `SchemaComparer`, and\n   * `MigrationTracker`. Useful when `db.url` doesn't unambiguously identify\n   * the engine (e.g. the JSON adapter, which uses DuckDB internally and may\n   * not be recognizable by URL alone). All three layers honor the same hint\n   * so the generated DDL, drift comparison, and execution path stay\n   * consistent — without it, an empty-URL connection could produce\n   * Postgres-flavored DDL but run through the SQLite tracker path.\n   *\n   * Typed as `DatabaseEngine` so unsupported values (e.g. `'mysql'`) fail at\n   * compile time rather than silently falling back to `'sqlite'` at runtime.\n   */\n  engineHint?: DatabaseEngine;\n  /**\n   * Confirm that historical PostgreSQL Date writers used UTC wall times before\n   * reinterpreting legacy TIMESTAMP/TEXT/JSON columns as TIMESTAMPTZ.\n   */\n  postgresTimestampMigration?: { legacyTimezone: 'UTC' };\n}\n\nexport interface MigrateSmrtSchemasResult {\n  applied: boolean;\n  results: MigrationResult[];\n  statements: string[];\n  schemaCount: number;\n  /**\n   * Schema changes the orchestrator detected but cannot apply automatically\n   * (incompatible type mismatches, SQLite type upgrades that require table\n   * recreation, etc.). Empty when the schema is fully reconciled. Inspect\n   * this to surface a \"manual migration required\" warning in CLI output.\n   */\n  unactionableChanges: SchemaChange[];\n  /**\n   * Convenience: `unactionableChanges.length > 0`. Lets a caller write\n   * `if (result.hasManualDrift) ...` without iterating the array first,\n   * and makes the case visible to anyone scanning the result shape (the\n   * full array is easy to gloss over when `applied: false`).\n   */\n  hasManualDrift: boolean;\n}\n\nexport interface PendingSchemaStatementsResult {\n  diff: Awaited<ReturnType<typeof generateSchemaDiff>>;\n  statements: string[];\n  schemaCount: number;\n  hasChanges: boolean;\n  /**\n   * Schema changes the differ detected but that have no executable SQL\n   * (incompatible `type_mismatch` entries, or `type_upgrade` entries whose\n   * only generated SQL is an advisory comment because the engine cannot\n   * upgrade the column in place — e.g. SQLite type widening). Surfacing\n   * these lets status commands distinguish \"no drift\" from \"drift the\n   * orchestrator can't fix on its own.\"\n   */\n  unactionableChanges: SchemaChange[];\n  /**\n   * Convenience: `unactionableChanges.length > 0`. Mirrors the\n   * `MigrateSmrtSchemasResult.hasManualDrift` shortcut.\n   */\n  hasManualDrift: boolean;\n}\n\n/**\n * Compute the SQL statements needed to bring `db` in sync with the\n * currently-registered SMRT object schemas. Pure inspection — no writes.\n *\n * Useful for status commands (\"how far behind is the schema?\") and as the\n * inner step of `migrateSmrtSchemas`.\n *\n * **Note on the returned `statements`:** these are the engine-correct DDL\n * statements as the differ + DDL strategy produce them, *prior to* any\n * Postgres-specific rewrites the `MigrationTracker` applies at execution\n * time (e.g. rewriting `CREATE INDEX` → `CREATE INDEX CONCURRENTLY` and\n * moving CONCURRENTLY statements outside the surrounding transaction).\n * The list is suitable for preview/status/\"what would change?\" use cases.\n * For the exact byte-for-byte SQL the tracker ran, inspect the\n * `MigrationResult`s from `migrateSmrtSchemas` or the tracker's own logs.\n */\nexport async function getPendingSchemaStatements(\n  db: DatabaseInterface,\n  options: {\n    engineHint?: DatabaseEngine;\n    postgresTimestampMigration?: { legacyTimezone: 'UTC' };\n  } = {},\n): Promise<PendingSchemaStatementsResult> {\n  const schemas = ObjectRegistry.getAllSchemasAsDefinitions();\n  // Forward engineHint into the diff itself so the SchemaComparer's\n  // existing-table SQL (ALTER/index drift) uses the same DDL strategy\n  // we use for newly-added tables — otherwise the two halves of the\n  // statement list can land on different engines (split-brain) when\n  // `db.url` is empty or ambiguous.\n  const diff = await generateSchemaDiff(db, schemas, {\n    engineHint: options.engineHint,\n    postgresTimestampMigration: options.postgresTimestampMigration,\n  });\n  const statements = collectStatementsFromDiff(diff, db, options.engineHint);\n  const unactionableChanges = collectUnactionableChanges(diff);\n  return {\n    diff,\n    schemaCount: Object.keys(schemas).length,\n    statements,\n    hasChanges: hasActionableChanges(diff),\n    unactionableChanges,\n    hasManualDrift: unactionableChanges.length > 0,\n  };\n}\n\n/**\n * Apply any pending schema changes from `ObjectRegistry` to `db`.\n *\n * Returns `applied: false` (with no error) if the database is already in\n * sync. Throws on the first migration failure with the underlying error\n * preserved (callers should let it propagate to the CLI).\n *\n * **Note on the returned `statements`:** mirrors `getPendingSchemaStatements`\n * — the list is the planned DDL, prior to Postgres-specific tracker rewrites\n * (CONCURRENTLY, transaction reordering). The actual executed SQL is\n * tracked in the returned `results`.\n *\n * **Note on `applied` semantics under `reconcile: true` (the default):**\n * the tracker may re-execute a migration that is already in `completed`\n * state when the checksum matches — that counts as `applied: true` in the\n * returned `MigrationResult`. So `result.applied === true` means \"the\n * tracker ran the migration\", not specifically \"the database changed for\n * the first time.\" Pass `reconcile: false` if you need to distinguish a\n * fresh apply from a reconcile-replay over an existing completed record.\n *\n * **Note on repeated failures:** the migration name defaults to a fresh\n * timestamp on every call, so a sequence of failed runs leaves one\n * `failed` row in `_smrt_schema_migrations` per attempt. Pass an explicit\n * `name` if you want to overwrite the same record across retries.\n *\n * **Note on `unactionableChanges`:** the differ can detect schema drift\n * the migration step can't auto-resolve — incompatible type mismatches,\n * SQLite type widening that needs table recreation, etc. Those changes\n * appear in `result.unactionableChanges` and are NOT applied (the\n * statements list is filtered to executable DDL only). When the diff\n * contains *only* unactionable changes, the function returns\n * `applied: false` with a populated `unactionableChanges` so callers can\n * surface a \"manual migration required\" signal. Without inspecting that\n * field, the result would look indistinguishable from \"already in sync.\"\n */\nexport async function migrateSmrtSchemas(\n  options: MigrateSmrtSchemasOptions,\n): Promise<MigrateSmrtSchemasResult> {\n  const pending = await getPendingSchemaStatements(options.db, {\n    engineHint: options.engineHint,\n    postgresTimestampMigration: options.postgresTimestampMigration,\n  });\n  if (!pending.hasChanges || pending.statements.length === 0) {\n    return {\n      applied: false,\n      results: [],\n      statements: [],\n      schemaCount: pending.schemaCount,\n      unactionableChanges: pending.unactionableChanges,\n      hasManualDrift: pending.hasManualDrift,\n    };\n  }\n\n  const tracker = new MigrationTracker({\n    db: options.db,\n    engineHint: options.engineHint,\n    lockTimeout: options.lockTimeout,\n    statementTimeout: options.statementTimeout,\n    useConcurrentIndexes: options.useConcurrentIndexes ?? true,\n  });\n  const migration = createMigrationDefinition(\n    options.name ?? `${generateMigrationTimestamp()}_smrt_schema_sync`,\n    pending.statements,\n    [],\n    {\n      description: options.description ?? 'Synchronize SMRT object schemas',\n      packageName: options.packageName,\n      version: options.version ?? 'unknown',\n    },\n  );\n\n  const results = await tracker.applyAll([migration], {\n    postgresSafe: options.postgresSafe ?? true,\n    reconcile: options.reconcile ?? true,\n  });\n\n  const failed = results.find((result) => !result.success);\n  if (failed) {\n    throw failed.error instanceof Error\n      ? failed.error\n      : new Error(String(failed.error ?? `Migration ${failed.name} failed`));\n  }\n\n  const applied = results.some(\n    (result) => result.applied !== false && result.skipped !== true,\n  );\n\n  return {\n    applied,\n    results,\n    statements: pending.statements,\n    schemaCount: pending.schemaCount,\n    unactionableChanges: pending.unactionableChanges,\n    hasManualDrift: pending.hasManualDrift,\n  };\n}\n\n/** Mirror of the `getDatabaseUrl` helper in class.ts — some adapters\n * (JSON, certain in-memory wrappers) leave `db.url` undefined and expose\n * the URL on `db.config?.url` instead. Detecting the engine from a raw\n * `db.url` would throw or silently fall through to the sqlite default.\n */\nfunction resolveDatabaseUrl(db: DatabaseInterface): string {\n  const dbWithConfig = db as DatabaseInterface & {\n    config?: { url?: string };\n  };\n  return db.url || dbWithConfig.config?.url || '';\n}\n\n/**\n * Materialize the diff into the engine-correct SQL statements.\n *\n * For new tables we delegate to the engine's `DDLStrategy` so column types\n * (`REAL` → `DOUBLE PRECISION` on Postgres, `JSON` → `JSONB`, etc.),\n * partial-index `WHERE` clauses, and trigger syntax all match what the\n * SchemaComparer would expect on subsequent runs. Emitting the raw\n * abstract `SchemaDefinition.ddl` here would cause immediate type-drift\n * migrations on Postgres/DuckDB.\n *\n * Column/index/trigger changes for existing tables continue to come from\n * `getSQLFromDiff`, which is already engine-aware via the differ's per-\n * change `sqlStatements`.\n */\nfunction collectStatementsFromDiff(\n  diff: Awaited<ReturnType<typeof generateSchemaDiff>>,\n  db: DatabaseInterface,\n  engineHint?: DatabaseEngine,\n): string[] {\n  const strategy = getDDLStrategy(\n    detectEngine(resolveDatabaseUrl(db), engineHint),\n  );\n  const statements: string[] = [];\n  for (const schema of diff.added_tables) {\n    statements.push(strategy.generateCreateTable(schema));\n    statements.push(...strategy.generateIndexes(schema));\n    statements.push(...strategy.generateTriggers(schema));\n  }\n  statements.push(...getSQLFromDiff(diff));\n  // Drop empty and comment-only entries. SQLite type-widening upgrades\n  // surface as `-- SQLite: Type upgrade for X requires table recreation`\n  // — passing those through to the tracker records a successful migration\n  // without actually fixing the column, so the same drift re-appears on\n  // every subsequent run. Those changes are surfaced separately via\n  // `unactionableChanges` so callers can prompt for manual remediation.\n  return statements.filter((statement) => {\n    const trimmed = statement.trim();\n    if (trimmed.length === 0) return false;\n    return !isCommentOnlySql(trimmed);\n  });\n}\n\n/**\n * True if `sql` contains no executable DDL — only line comments (`--`)\n * and/or block comments (`/* … *​/`). Used to discard advisory comments\n * the differ emits when a column upgrade can't be performed in place\n * (e.g. SQLite type widening). Defensive: strips block comments first so\n * a future differ that emits `/* type_upgrade: no-op *​/` doesn't slip\n * through.\n */\nfunction isCommentOnlySql(sql: string): boolean {\n  // Strip /* ... */ block comments (non-greedy, spans newlines).\n  const withoutBlockComments = sql.replace(/\\/\\*[\\s\\S]*?\\*\\//g, '');\n  const lines = withoutBlockComments\n    .split('\\n')\n    .map((line) => line.trim())\n    .filter((line) => line.length > 0);\n  if (lines.length === 0) return sql.trim().length > 0;\n  return lines.every((line) => line.startsWith('--'));\n}\n\n/**\n * Surface changes the differ produced but that the migrator cannot apply\n * automatically — either `type_mismatch` entries (the differ explicitly\n * gives up on these) or `type_upgrade` entries whose generated SQL is\n * advisory-comment-only (SQLite table-recreation cases, etc.). Callers\n * use this to distinguish \"schema is in sync\" from \"schema is drifted but\n * we can't fix it from here.\"\n */\nfunction collectUnactionableChanges(\n  diff: Awaited<ReturnType<typeof generateSchemaDiff>>,\n): SchemaChange[] {\n  const unactionable: SchemaChange[] = [];\n  for (const change of diff.changes) {\n    if (change.type === 'type_mismatch') {\n      unactionable.push(change);\n      continue;\n    }\n    const statements = change.sqlStatements ?? (change.sql ? [change.sql] : []);\n    if (\n      statements.length > 0 &&\n      statements.every((stmt) => isCommentOnlySql(stmt.trim()))\n    ) {\n      unactionable.push(change);\n    }\n  }\n  return unactionable;\n}\n"],"mappings":";;;;;;;;;;;;;;;;;;;;;;AA4IA,eAAsB,2BACpB,IACA,UAGI,CAAC,GACmC;CACxC,MAAM,UAAU,eAAe,2BAA2B;CAM1D,MAAM,OAAO,MAAM,mBAAmB,IAAI,SAAS;EACjD,YAAY,QAAQ;EACpB,4BAA4B,QAAQ;CACtC,CAAC;CACD,MAAM,aAAa,0BAA0B,MAAM,IAAI,QAAQ,UAAU;CACzE,MAAM,sBAAsB,2BAA2B,IAAI;CAC3D,OAAO;EACL;EACA,aAAa,OAAO,KAAK,OAAO,CAAC,CAAC;EAClC;EACA,YAAY,qBAAqB,IAAI;EACrC;EACA,gBAAgB,oBAAoB,SAAS;CAC/C;AACF;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAqCA,eAAsB,mBACpB,SACmC;CACnC,MAAM,UAAU,MAAM,2BAA2B,QAAQ,IAAI;EAC3D,YAAY,QAAQ;EACpB,4BAA4B,QAAQ;CACtC,CAAC;CACD,IAAI,CAAC,QAAQ,cAAc,QAAQ,WAAW,WAAW,GACvD,OAAO;EACL,SAAS;EACT,SAAS,CAAC;EACV,YAAY,CAAC;EACb,aAAa,QAAQ;EACrB,qBAAqB,QAAQ;EAC7B,gBAAgB,QAAQ;CAC1B;CAGF,MAAM,UAAU,IAAI,iBAAiB;EACnC,IAAI,QAAQ;EACZ,YAAY,QAAQ;EACpB,aAAa,QAAQ;EACrB,kBAAkB,QAAQ;EAC1B,sBAAsB,QAAQ,wBAAwB;CACxD,CAAC;CACD,MAAM,YAAY,0BAChB,QAAQ,QAAQ,GAAG,2BAA2B,EAAE,oBAChD,QAAQ,YACR,CAAC,GACD;EACE,aAAa,QAAQ,eAAe;EACpC,aAAa,QAAQ;EACrB,SAAS,QAAQ,WAAW;CAC9B,CACF;CAEA,MAAM,UAAU,MAAM,QAAQ,SAAS,CAAC,SAAS,GAAG;EAClD,cAAc,QAAQ,gBAAgB;EACtC,WAAW,QAAQ,aAAa;CAClC,CAAC;CAED,MAAM,SAAS,QAAQ,MAAM,WAAW,CAAC,OAAO,OAAO;CACvD,IAAI,QACF,MAAM,OAAO,iBAAiB,QAC1B,OAAO,QACP,IAAI,MAAM,OAAO,OAAO,SAAS,aAAa,OAAO,KAAK,QAAQ,CAAC;CAOzE,OAAO;EACL,SALc,QAAQ,MACrB,WAAW,OAAO,YAAY,SAAS,OAAO,YAAY,IAI3D;EACA;EACA,YAAY,QAAQ;EACpB,aAAa,QAAQ;EACrB,qBAAqB,QAAQ;EAC7B,gBAAgB,QAAQ;CAC1B;AACF;;;;;;AAOA,SAAS,mBAAmB,IAA+B;CACzD,MAAM,eAAe;CAGrB,OAAO,GAAG,OAAO,aAAa,QAAQ,OAAO;AAC/C;;;;;;;;;;;;;;;AAgBA,SAAS,0BACP,MACA,IACA,YACU;CACV,MAAM,WAAW,eACf,aAAa,mBAAmB,EAAE,GAAG,UAAU,CACjD;CACA,MAAM,aAAuB,CAAC;CAC9B,KAAK,MAAM,UAAU,KAAK,cAAc;EACtC,WAAW,KAAK,SAAS,oBAAoB,MAAM,CAAC;EACpD,WAAW,KAAK,GAAG,SAAS,gBAAgB,MAAM,CAAC;EACnD,WAAW,KAAK,GAAG,SAAS,iBAAiB,MAAM,CAAC;CACtD;CACA,WAAW,KAAK,GAAG,eAAe,IAAI,CAAC;CAOvC,OAAO,WAAW,QAAQ,cAAc;EACtC,MAAM,UAAU,UAAU,KAAK;EAC/B,IAAI,QAAQ,WAAW,GAAG,OAAO;EACjC,OAAO,CAAC,iBAAiB,OAAO;CAClC,CAAC;AACH;;;;;;;;;AAUA,SAAS,iBAAiB,KAAsB;CAG9C,MAAM,QADuB,IAAI,QAAQ,qBAAqB,EAChD,CAAA,CACX,MAAM,IAAI,CAAC,CACX,KAAK,SAAS,KAAK,KAAK,CAAC,CAAC,CAC1B,QAAQ,SAAS,KAAK,SAAS,CAAC;CACnC,IAAI,MAAM,WAAW,GAAG,OAAO,IAAI,KAAK,CAAC,CAAC,SAAS;CACnD,OAAO,MAAM,OAAO,SAAS,KAAK,WAAW,IAAI,CAAC;AACpD;;;;;;;;;AAUA,SAAS,2BACP,MACgB;CAChB,MAAM,eAA+B,CAAC;CACtC,KAAK,MAAM,UAAU,KAAK,SAAS;EACjC,IAAI,OAAO,SAAS,iBAAiB;GACnC,aAAa,KAAK,MAAM;GACxB;EACF;EACA,MAAM,aAAa,OAAO,kBAAkB,OAAO,MAAM,CAAC,OAAO,GAAG,IAAI,CAAC;EACzE,IACE,WAAW,SAAS,KACpB,WAAW,OAAO,SAAS,iBAAiB,KAAK,KAAK,CAAC,CAAC,GAExD,aAAa,KAAK,MAAM;CAE5B;CACA,OAAO;AACT"}
+{"version":3,"file":"orchestrate.js","names":[],"sources":["../../src/migrations/orchestrate.ts"],"sourcesContent":["/**\n * High-level \"make my SMRT app's schema match its database\" orchestration.\n *\n * Wraps `ObjectRegistry.getAllSchemasAsDefinitions()` → `generateSchemaDiff`\n * → `MigrationTracker.applyAll`. Apps that just want to run pending\n * schema changes call `migrateSmrtSchemas({ db, packageName, version })`\n * and don't have to assemble the migration definition by hand.\n *\n * The migration name is timestamped, so re-running on an up-to-date\n * database is a no-op (the diff is empty, no statements are generated,\n * `applied: false` is returned).\n */\nimport type { DatabaseInterface } from '@happyvertical/sql';\nimport { ObjectRegistry } from '../registry.js';\nimport { detectEngine, getDDLStrategy } from '../schema/ddl/index.js';\nimport type { DatabaseEngine } from '../schema/ddl/types.js';\nimport type { MigrationResult, SchemaChange } from '../schema/types.js';\nimport {\n  generateSchemaDiff,\n  getSQLFromDiff,\n  hasActionableChanges,\n} from './differ.js';\nimport {\n  createMigrationDefinition,\n  generateMigrationTimestamp,\n} from './generator.js';\nimport { MigrationTracker } from './tracker.js';\n\nexport interface MigrateSmrtSchemasOptions {\n  db: DatabaseInterface;\n  /** Stored on the migration record so the audit log shows which app applied it. */\n  packageName: string;\n  /**\n   * Stored on the migration record. Typically the app's package.json\n   * version. Optional because most apps don't have a runtime-readable\n   * version handy and would hardcode a stale string if forced to supply\n   * one — `'unknown'` is honest. Pass an explicit value when you can\n   * (e.g. `version: process.env.APP_VERSION`).\n   */\n  version?: string;\n  /** Override the description on the synthetic migration definition. */\n  description?: string;\n  /** Override the migration name (default: `<timestamp>_smrt_schema_sync`). */\n  name?: string;\n  /** Forwarded to MigrationTracker — defaults to true for pg-safe runs. */\n  postgresSafe?: boolean;\n  /** Forwarded to MigrationTracker — defaults to true. */\n  reconcile?: boolean;\n  /** Forwarded to MigrationTracker — defaults to true for `CREATE INDEX CONCURRENTLY`. */\n  useConcurrentIndexes?: boolean;\n  /**\n   * Forwarded to MigrationTracker (Postgres lock timeout, milliseconds).\n   * Lets apps that customize tracker timeouts directly preserve their\n   * tuning when going through the orchestrator. Falls back to the\n   * tracker's default (30000ms) when omitted.\n   */\n  lockTimeout?: number;\n  /**\n   * Forwarded to MigrationTracker (Postgres statement timeout, ms). Falls\n   * back to the tracker's default (60000ms) when omitted.\n   */\n  statementTimeout?: number;\n  /**\n   * Explicit engine hint forwarded to `detectEngine`, `SchemaComparer`, and\n   * `MigrationTracker`. Useful when `db.url` doesn't unambiguously identify\n   * the engine (e.g. the JSON adapter, which uses DuckDB internally and may\n   * not be recognizable by URL alone). All three layers honor the same hint\n   * so the generated DDL, drift comparison, and execution path stay\n   * consistent — without it, an empty-URL connection could produce\n   * Postgres-flavored DDL but run through the SQLite tracker path.\n   *\n   * Typed as `DatabaseEngine` so unsupported values (e.g. `'mysql'`) fail at\n   * compile time rather than silently falling back to `'sqlite'` at runtime.\n   */\n  engineHint?: DatabaseEngine;\n  /**\n   * Confirm that historical PostgreSQL Date writers used UTC wall times before\n   * reinterpreting legacy TIMESTAMP/TEXT/JSON columns as TIMESTAMPTZ.\n   */\n  postgresTimestampMigration?: { legacyTimezone: 'UTC' };\n}\n\nexport interface MigrateSmrtSchemasResult {\n  applied: boolean;\n  results: MigrationResult[];\n  statements: string[];\n  schemaCount: number;\n  /**\n   * Schema changes the orchestrator detected but cannot apply automatically\n   * (incompatible type mismatches, SQLite type upgrades that require table\n   * recreation, etc.). Empty when the schema is fully reconciled. Inspect\n   * this to surface a \"manual migration required\" warning in CLI output.\n   */\n  unactionableChanges: SchemaChange[];\n  /**\n   * Convenience: `unactionableChanges.length > 0`. Lets a caller write\n   * `if (result.hasManualDrift) ...` without iterating the array first,\n   * and makes the case visible to anyone scanning the result shape (the\n   * full array is easy to gloss over when `applied: false`).\n   */\n  hasManualDrift: boolean;\n}\n\nexport interface PendingSchemaStatementsResult {\n  diff: Awaited<ReturnType<typeof generateSchemaDiff>>;\n  statements: string[];\n  schemaCount: number;\n  hasChanges: boolean;\n  /**\n   * Schema changes the differ detected but that have no executable SQL\n   * (incompatible `type_mismatch` entries, or `type_upgrade` entries whose\n   * only generated SQL is an advisory comment because the engine cannot\n   * upgrade the column in place — e.g. SQLite type widening). Surfacing\n   * these lets status commands distinguish \"no drift\" from \"drift the\n   * orchestrator can't fix on its own.\"\n   */\n  unactionableChanges: SchemaChange[];\n  /**\n   * Convenience: `unactionableChanges.length > 0`. Mirrors the\n   * `MigrateSmrtSchemasResult.hasManualDrift` shortcut.\n   */\n  hasManualDrift: boolean;\n}\n\n/**\n * Compute the SQL statements needed to bring `db` in sync with the\n * currently-registered SMRT object schemas. Pure inspection — no writes.\n *\n * Useful for status commands (\"how far behind is the schema?\") and as the\n * inner step of `migrateSmrtSchemas`.\n *\n * **Note on the returned `statements`:** these are the engine-correct DDL\n * statements as the differ + DDL strategy produce them, *prior to* any\n * Postgres-specific rewrites the `MigrationTracker` applies at execution\n * time (e.g. rewriting `CREATE INDEX` → `CREATE INDEX CONCURRENTLY` and\n * moving CONCURRENTLY statements outside the surrounding transaction).\n * The list is suitable for preview/status/\"what would change?\" use cases.\n * For the exact byte-for-byte SQL the tracker ran, inspect the\n * `MigrationResult`s from `migrateSmrtSchemas` or the tracker's own logs.\n */\nexport async function getPendingSchemaStatements(\n  db: DatabaseInterface,\n  options: {\n    engineHint?: DatabaseEngine;\n    postgresTimestampMigration?: { legacyTimezone: 'UTC' };\n  } = {},\n): Promise<PendingSchemaStatementsResult> {\n  const schemas = ObjectRegistry.getAllSchemasAsDefinitions();\n  // Forward engineHint into the diff itself so the SchemaComparer's\n  // existing-table SQL (ALTER/index drift) uses the same DDL strategy\n  // we use for newly-added tables — otherwise the two halves of the\n  // statement list can land on different engines (split-brain) when\n  // `db.url` is empty or ambiguous.\n  const diff = await generateSchemaDiff(db, schemas, {\n    engineHint: options.engineHint,\n    postgresTimestampMigration: options.postgresTimestampMigration,\n  });\n  const statements = collectStatementsFromDiff(diff, db, options.engineHint);\n  const unactionableChanges = collectUnactionableChanges(diff);\n  return {\n    diff,\n    schemaCount: Object.keys(schemas).length,\n    statements,\n    hasChanges: hasActionableChanges(diff),\n    unactionableChanges,\n    hasManualDrift: unactionableChanges.length > 0,\n  };\n}\n\n/**\n * Apply any pending schema changes from `ObjectRegistry` to `db`.\n *\n * Returns `applied: false` (with no error) if the database is already in\n * sync. Throws on the first migration failure with the underlying error\n * preserved (callers should let it propagate to the CLI).\n *\n * **Note on the returned `statements`:** mirrors `getPendingSchemaStatements`\n * — the list is the planned DDL, prior to Postgres-specific tracker rewrites\n * (CONCURRENTLY, transaction reordering). The actual executed SQL is\n * tracked in the returned `results`.\n *\n * **Note on `applied` semantics under `reconcile: true` (the default):**\n * the tracker may re-execute a migration that is already in `completed`\n * state when the checksum matches — that counts as `applied: true` in the\n * returned `MigrationResult`. So `result.applied === true` means \"the\n * tracker ran the migration\", not specifically \"the database changed for\n * the first time.\" Pass `reconcile: false` if you need to distinguish a\n * fresh apply from a reconcile-replay over an existing completed record.\n *\n * **Note on repeated failures:** the migration name defaults to a fresh\n * timestamp on every call, so a sequence of failed runs leaves one\n * `failed` row in `_smrt_schema_migrations` per attempt. Pass an explicit\n * `name` if you want to overwrite the same record across retries.\n *\n * **Note on `unactionableChanges`:** the differ can detect schema drift\n * the migration step can't auto-resolve — incompatible type mismatches,\n * SQLite type widening that needs table recreation, etc. Those changes\n * appear in `result.unactionableChanges` and are NOT applied (the\n * statements list is filtered to executable DDL only). When the diff\n * contains *only* unactionable changes, the function returns\n * `applied: false` with a populated `unactionableChanges` so callers can\n * surface a \"manual migration required\" signal. Without inspecting that\n * field, the result would look indistinguishable from \"already in sync.\"\n */\nexport async function migrateSmrtSchemas(\n  options: MigrateSmrtSchemasOptions,\n): Promise<MigrateSmrtSchemasResult> {\n  const pending = await getPendingSchemaStatements(options.db, {\n    engineHint: options.engineHint,\n    postgresTimestampMigration: options.postgresTimestampMigration,\n  });\n  if (!pending.hasChanges || pending.statements.length === 0) {\n    return {\n      applied: false,\n      results: [],\n      statements: [],\n      schemaCount: pending.schemaCount,\n      unactionableChanges: pending.unactionableChanges,\n      hasManualDrift: pending.hasManualDrift,\n    };\n  }\n\n  const tracker = new MigrationTracker({\n    db: options.db,\n    engineHint: options.engineHint,\n    lockTimeout: options.lockTimeout,\n    statementTimeout: options.statementTimeout,\n    useConcurrentIndexes: options.useConcurrentIndexes ?? true,\n  });\n  const migration = createMigrationDefinition(\n    options.name ?? `${generateMigrationTimestamp()}_smrt_schema_sync`,\n    pending.statements,\n    [],\n    {\n      description: options.description ?? 'Synchronize SMRT object schemas',\n      packageName: options.packageName,\n      version: options.version ?? 'unknown',\n    },\n  );\n\n  const results = await tracker.applyAll([migration], {\n    postgresSafe: options.postgresSafe ?? true,\n    reconcile: options.reconcile ?? true,\n  });\n\n  const failed = results.find((result) => !result.success);\n  if (failed) {\n    throw failed.error instanceof Error\n      ? failed.error\n      : new Error(String(failed.error ?? `Migration ${failed.name} failed`));\n  }\n\n  const applied = results.some(\n    (result) => result.applied !== false && result.skipped !== true,\n  );\n\n  return {\n    applied,\n    results,\n    statements: pending.statements,\n    schemaCount: pending.schemaCount,\n    unactionableChanges: pending.unactionableChanges,\n    hasManualDrift: pending.hasManualDrift,\n  };\n}\n\n/** Mirror of the `getDatabaseUrl` helper in class.ts — some adapters\n * (JSON, certain in-memory wrappers) leave `db.url` undefined and expose\n * the URL on `db.config?.url` instead. Detecting the engine from a raw\n * `db.url` would throw or silently fall through to the sqlite default.\n */\nfunction resolveDatabaseUrl(db: DatabaseInterface): string {\n  const dbWithConfig = db as DatabaseInterface & {\n    config?: { url?: string };\n  };\n  return db.url || dbWithConfig.config?.url || '';\n}\n\n/**\n * Materialize the diff into the engine-correct SQL statements.\n *\n * For new tables we delegate to the engine's `DDLStrategy` so column types\n * (`REAL` → `DOUBLE PRECISION` on Postgres, `JSON` → `JSONB`, etc.),\n * partial-index `WHERE` clauses, and trigger syntax all match what the\n * SchemaComparer would expect on subsequent runs. Emitting the raw\n * abstract `SchemaDefinition.ddl` here would cause immediate type-drift\n * migrations on Postgres/DuckDB.\n *\n * Column/index/trigger changes for existing tables continue to come from\n * `getSQLFromDiff`, which is already engine-aware via the differ's per-\n * change `sqlStatements`.\n */\nfunction collectStatementsFromDiff(\n  diff: Awaited<ReturnType<typeof generateSchemaDiff>>,\n  db: DatabaseInterface,\n  engineHint?: DatabaseEngine,\n): string[] {\n  const strategy = getDDLStrategy(\n    detectEngine(resolveDatabaseUrl(db), engineHint),\n  );\n  const statements: string[] = [];\n  for (const schema of diff.added_tables) {\n    statements.push(strategy.generateCreateTable(schema));\n    statements.push(...strategy.generateIndexes(schema));\n    statements.push(...strategy.generateTriggers(schema));\n  }\n  statements.push(...getSQLFromDiff(diff));\n  // Drop empty and comment-only entries. SQLite type-widening upgrades\n  // surface as `-- SQLite: Type upgrade for X requires table recreation`\n  // — passing those through to the tracker records a successful migration\n  // without actually fixing the column, so the same drift re-appears on\n  // every subsequent run. Those changes are surfaced separately via\n  // `unactionableChanges` so callers can prompt for manual remediation.\n  return statements.filter((statement) => {\n    const trimmed = statement.trim();\n    if (trimmed.length === 0) return false;\n    return !isCommentOnlySql(trimmed);\n  });\n}\n\n/**\n * True if `sql` contains no executable DDL — only line comments (`--`)\n * and/or block comments (`/* … *​/`). Used to discard advisory comments\n * the differ emits when a column upgrade can't be performed in place\n * (e.g. SQLite type widening). Defensive: strips block comments first so\n * a future differ that emits `/* type_upgrade: no-op *​/` doesn't slip\n * through.\n */\nfunction isCommentOnlySql(sql: string): boolean {\n  // Strip /* ... */ block comments (non-greedy, spans newlines).\n  const withoutBlockComments = sql.replace(/\\/\\*[\\s\\S]*?\\*\\//g, '');\n  const lines = withoutBlockComments\n    .split('\\n')\n    .map((line) => line.trim())\n    .filter((line) => line.length > 0);\n  if (lines.length === 0) return sql.trim().length > 0;\n  return lines.every((line) => line.startsWith('--'));\n}\n\n/**\n * True if `sql` is an advisory comment that says *nothing needs to happen* —\n * as opposed to one that says a human has to act.\n *\n * The differ emits both kinds. \"This SQLite column already stores JSON as\n * TEXT\" and \"#2370: this column is rebuilt together with its sibling\" are\n * no-ops; \"requires table recreation\" / \"blocked: …\" are real manual drift.\n * Treating the first kind as drift makes a fully auto-repairable migration\n * report `hasManualDrift: true`.\n *\n * Keep in sync with `classifyTypeUpgradeSql`'s `noop` arm in\n * `@happyvertical/smrt-cli` (`src/commands/db-migrate-actions.ts`), which\n * applies the same rule on the CLI side.\n */\nfunction isNoOpAdvisorySql(sql: string): boolean {\n  const trimmed = sql.trim();\n  return (\n    /no change needed/i.test(trimmed) || /already stores .* as /i.test(trimmed)\n  );\n}\n\n/**\n * Surface changes the differ produced but that the migrator cannot apply\n * automatically — `type_mismatch` entries (the differ explicitly gives up on\n * these), `type_upgrade`/`alter_column` entries whose generated SQL is\n * advisory-comment-only (a SQLite rebuild that would be unsafe, an in-place\n * constraint change SQLite cannot perform), and warning-level report-only\n * advisories (an orphan NOT NULL column that will break inserts, a required\n * column that could not be enforced, a stale unique constraint, a relaxation\n * the caller has not opted into). Info-level advisories (a harmless orphan\n * column, a stale default) and comments that mean \"already handled\" (the\n * no-op advisories a table rebuild leaves on covered siblings, #2370) are\n * deliberately excluded so `hasManualDrift` keeps meaning \"something needs\n * an operator\". Callers use this to distinguish \"schema is in sync\" from\n * \"schema is drifted but we can't fix it from here\".\n */\nfunction collectUnactionableChanges(\n  diff: Awaited<ReturnType<typeof generateSchemaDiff>>,\n): SchemaChange[] {\n  const unactionable: SchemaChange[] = [];\n  for (const change of diff.changes) {\n    if (change.type === 'type_mismatch') {\n      unactionable.push(change);\n      continue;\n    }\n    const statements = change.sqlStatements ?? (change.sql ? [change.sql] : []);\n    if (statements.length === 0) {\n      if (change.advisory?.severity === 'warning') {\n        unactionable.push(change);\n      }\n      continue;\n    }\n    if (\n      statements.every((stmt) => isCommentOnlySql(stmt.trim())) &&\n      !statements.every((stmt) => isNoOpAdvisorySql(stmt))\n    ) {\n      unactionable.push(change);\n    }\n  }\n  return unactionable;\n}\n"],"mappings":";;;;;;;;;;;;;;;;;;;;;;AA4IA,eAAsB,2BACpB,IACA,UAGI,CAAC,GACmC;CACxC,MAAM,UAAU,eAAe,2BAA2B;CAM1D,MAAM,OAAO,MAAM,mBAAmB,IAAI,SAAS;EACjD,YAAY,QAAQ;EACpB,4BAA4B,QAAQ;CACtC,CAAC;CACD,MAAM,aAAa,0BAA0B,MAAM,IAAI,QAAQ,UAAU;CACzE,MAAM,sBAAsB,2BAA2B,IAAI;CAC3D,OAAO;EACL;EACA,aAAa,OAAO,KAAK,OAAO,CAAC,CAAC;EAClC;EACA,YAAY,qBAAqB,IAAI;EACrC;EACA,gBAAgB,oBAAoB,SAAS;CAC/C;AACF;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAqCA,eAAsB,mBACpB,SACmC;CACnC,MAAM,UAAU,MAAM,2BAA2B,QAAQ,IAAI;EAC3D,YAAY,QAAQ;EACpB,4BAA4B,QAAQ;CACtC,CAAC;CACD,IAAI,CAAC,QAAQ,cAAc,QAAQ,WAAW,WAAW,GACvD,OAAO;EACL,SAAS;EACT,SAAS,CAAC;EACV,YAAY,CAAC;EACb,aAAa,QAAQ;EACrB,qBAAqB,QAAQ;EAC7B,gBAAgB,QAAQ;CAC1B;CAGF,MAAM,UAAU,IAAI,iBAAiB;EACnC,IAAI,QAAQ;EACZ,YAAY,QAAQ;EACpB,aAAa,QAAQ;EACrB,kBAAkB,QAAQ;EAC1B,sBAAsB,QAAQ,wBAAwB;CACxD,CAAC;CACD,MAAM,YAAY,0BAChB,QAAQ,QAAQ,GAAG,2BAA2B,EAAE,oBAChD,QAAQ,YACR,CAAC,GACD;EACE,aAAa,QAAQ,eAAe;EACpC,aAAa,QAAQ;EACrB,SAAS,QAAQ,WAAW;CAC9B,CACF;CAEA,MAAM,UAAU,MAAM,QAAQ,SAAS,CAAC,SAAS,GAAG;EAClD,cAAc,QAAQ,gBAAgB;EACtC,WAAW,QAAQ,aAAa;CAClC,CAAC;CAED,MAAM,SAAS,QAAQ,MAAM,WAAW,CAAC,OAAO,OAAO;CACvD,IAAI,QACF,MAAM,OAAO,iBAAiB,QAC1B,OAAO,QACP,IAAI,MAAM,OAAO,OAAO,SAAS,aAAa,OAAO,KAAK,QAAQ,CAAC;CAOzE,OAAO;EACL,SALc,QAAQ,MACrB,WAAW,OAAO,YAAY,SAAS,OAAO,YAAY,IAI3D;EACA;EACA,YAAY,QAAQ;EACpB,aAAa,QAAQ;EACrB,qBAAqB,QAAQ;EAC7B,gBAAgB,QAAQ;CAC1B;AACF;;;;;;AAOA,SAAS,mBAAmB,IAA+B;CACzD,MAAM,eAAe;CAGrB,OAAO,GAAG,OAAO,aAAa,QAAQ,OAAO;AAC/C;;;;;;;;;;;;;;;AAgBA,SAAS,0BACP,MACA,IACA,YACU;CACV,MAAM,WAAW,eACf,aAAa,mBAAmB,EAAE,GAAG,UAAU,CACjD;CACA,MAAM,aAAuB,CAAC;CAC9B,KAAK,MAAM,UAAU,KAAK,cAAc;EACtC,WAAW,KAAK,SAAS,oBAAoB,MAAM,CAAC;EACpD,WAAW,KAAK,GAAG,SAAS,gBAAgB,MAAM,CAAC;EACnD,WAAW,KAAK,GAAG,SAAS,iBAAiB,MAAM,CAAC;CACtD;CACA,WAAW,KAAK,GAAG,eAAe,IAAI,CAAC;CAOvC,OAAO,WAAW,QAAQ,cAAc;EACtC,MAAM,UAAU,UAAU,KAAK;EAC/B,IAAI,QAAQ,WAAW,GAAG,OAAO;EACjC,OAAO,CAAC,iBAAiB,OAAO;CAClC,CAAC;AACH;;;;;;;;;AAUA,SAAS,iBAAiB,KAAsB;CAG9C,MAAM,QADuB,IAAI,QAAQ,qBAAqB,EAChD,CAAA,CACX,MAAM,IAAI,CAAC,CACX,KAAK,SAAS,KAAK,KAAK,CAAC,CAAC,CAC1B,QAAQ,SAAS,KAAK,SAAS,CAAC;CACnC,IAAI,MAAM,WAAW,GAAG,OAAO,IAAI,KAAK,CAAC,CAAC,SAAS;CACnD,OAAO,MAAM,OAAO,SAAS,KAAK,WAAW,IAAI,CAAC;AACpD;;;;;;;;;;;;;;;AAgBA,SAAS,kBAAkB,KAAsB;CAC/C,MAAM,UAAU,IAAI,KAAK;CACzB,OACE,oBAAoB,KAAK,OAAO,KAAK,yBAAyB,KAAK,OAAO;AAE9E;;;;;;;;;;;;;;;;AAiBA,SAAS,2BACP,MACgB;CAChB,MAAM,eAA+B,CAAC;CACtC,KAAK,MAAM,UAAU,KAAK,SAAS;EACjC,IAAI,OAAO,SAAS,iBAAiB;GACnC,aAAa,KAAK,MAAM;GACxB;EACF;EACA,MAAM,aAAa,OAAO,kBAAkB,OAAO,MAAM,CAAC,OAAO,GAAG,IAAI,CAAC;EACzE,IAAI,WAAW,WAAW,GAAG;GAC3B,IAAI,OAAO,UAAU,aAAa,WAChC,aAAa,KAAK,MAAM;GAE1B;EACF;EACA,IACE,WAAW,OAAO,SAAS,iBAAiB,KAAK,KAAK,CAAC,CAAC,KACxD,CAAC,WAAW,OAAO,SAAS,kBAAkB,IAAI,CAAC,GAEnD,aAAa,KAAK,MAAM;CAE5B;CACA,OAAO;AACT"}

package/dist/migrations/sqlite-rebuild.d.ts

@@ -0,0 +1,142 @@
+import { SchemaChange, SQLDataType } from '../schema/types.js';
+import { DatabaseInterface } from './types.js';
+/**
+ * Prefix of the reserved staging table a rebuild creates. `_smrt_`-prefixed
+ * names are SMRT system tables, which the differ's dropped-table sweep skips,
+ * so a staging table left behind by a non-transactional adapter cannot be
+ * mistaken for user data.
+ */
+export declare const SQLITE_REBUILD_TABLE_PREFIX = "_smrt_rebuild_";
+/**
+ * The advisory SQL the differ emits for a SQLite type upgrade it cannot
+ * perform with an `ALTER TABLE`. `planSqliteTableRebuilds` replaces it with an
+ * executable plan; when it cannot, the comment survives and `db:migrate`
+ * reports the column as manual drift exactly as it did before #2370.
+ */
+export declare function sqliteRebuildPlaceholderSql(columnName: string): string;
+/**
+ * True when `sql` is the differ's "requires table recreation" placeholder —
+ * i.e. a type upgrade waiting for this module to turn it into a rebuild.
+ */
+export declare function isSqliteRebuildPlaceholder(sql: string | undefined): boolean;
+/** A rebuild plan: the ordered statements plus what they touch. */
+export interface SqliteTableRebuildPlan {
+    /** Ordered, executable statements. Run them in one transaction. */
+    statements: string[];
+    /** Columns copied from the old table into the new one, in table order. */
+    copiedColumns: string[];
+    /** Names of the indexes and triggers recreated after the swap. */
+    recreatedObjects: string[];
+}
+export interface PlanSqliteTableRebuildsOptions {
+    db: DatabaseInterface;
+    tableName: string;
+    /** The table's changes, as produced by the differ's column comparison. */
+    changes: SchemaChange[];
+    /** Abstract → SQLite type mapping (the engine's DDL strategy `mapType`). */
+    mapType: (type: SQLDataType) => string;
+}
+/**
+ * Replace every "requires table recreation" placeholder for `tableName` with
+ * one executable rebuild.
+ *
+ * All of the table's drifted columns are retyped by a *single* rebuild, so the
+ * first placeholder carries the plan and the rest become no-ops that reference
+ * it. Returns the changes unchanged when there is nothing to rebuild, and
+ * leaves the placeholders in place (annotated with the reason) when the
+ * rebuild cannot be planned safely — the pre-#2370 manual-intervention
+ * behavior.
+ *
+ * When a plan is produced, the rebuild is hoisted to the front of the table's
+ * changes. The plan's staging DDL and copy list are captured from the live
+ * schema *at diff time*, so a same-batch `ALTER TABLE ... ADD COLUMN` that ran
+ * first would be silently undone by the rebuild — both statements succeed, the
+ * transaction commits, and the new column is simply gone. The differ emits
+ * changes in manifest field order, which puts an `add_column` first whenever
+ * the new field is declared above the retyped one, so the order has to be
+ * imposed here rather than assumed. Rebuild first, then add columns to the
+ * rebuilt table.
+ */
+export declare function planSqliteTableRebuilds(options: PlanSqliteTableRebuildsOptions): Promise<SchemaChange[]>;
+export interface BuildSqliteRebuildStatementsInput {
+    tableName: string;
+    /** The live `sqlite_master.sql` CREATE TABLE text. */
+    createTableSql: string;
+    /** Column name → target SQLite type, for the columns being retyped. */
+    columnTypes: Map<string, string>;
+    /** Every column of the live table, in `PRAGMA table_info` order. */
+    columns: string[];
+    /** Indexes and triggers to replay after the swap. */
+    objects: {
+        name: string;
+        sql: string;
+    }[];
+    /** Current `PRAGMA legacy_alter_table` value, restored after the rename. */
+    legacyAlterTable: boolean;
+}
+/**
+ * Build the ordered statement list for one table rebuild.
+ *
+ * Returns `null` when the live `CREATE TABLE` text cannot be rewritten (an
+ * unparsable statement, or a requested column that is not in it) — the caller
+ * then leaves the change as manual drift rather than emitting SQL that would
+ * "succeed" without fixing the column, which would re-diff forever.
+ *
+ * `PRAGMA legacy_alter_table` brackets the rename because SQLite ≥ 3.25
+ * re-parses the whole schema on `ALTER TABLE ... RENAME`: a view left
+ * referencing the just-dropped table makes the rename fail outright
+ * ("error in view … no such table"). Legacy mode renames the table without
+ * that reference rewriting, which is exactly what a rebuild wants — the name
+ * the views refer to is about to exist again. It is restored to its previous
+ * value immediately afterwards; a rolled-back batch leaves it set, which is
+ * inert for SMRT (nothing else in the toolchain renames a table) but is
+ * documented in `packages/core/agents/schema-paths.md`.
+ */
+export declare function buildSqliteRebuildStatements(input: BuildSqliteRebuildStatementsInput): SqliteTableRebuildPlan | null;
+/**
+ * Rewrite a live `CREATE TABLE` statement into the rebuild's target shape:
+ * the same body under a new table name, with the declared type of each column
+ * in `columnTypes` replaced.
+ *
+ * Everything else is preserved verbatim — other columns, their defaults,
+ * `NOT NULL`/`PRIMARY KEY`/`CHECK`/`COLLATE` clauses, table-level
+ * constraints, and trailing table options (`WITHOUT ROWID`, `STRICT`).
+ *
+ * Returns `null` if the statement cannot be parsed or if any requested column
+ * is not present in it.
+ */
+export declare function rewriteSqliteCreateTable(createTableSql: string, target: {
+    tableName: string;
+    columnTypes: Map<string, string>;
+}): string | null;
+interface ParsedCreateTable {
+    /** Top-level, comma-separated column and constraint definitions. */
+    items: string[];
+    /** Table options after the closing paren (`WITHOUT ROWID`, `STRICT`). */
+    tail: string;
+}
+/**
+ * Split a `CREATE TABLE` statement into its top-level definition items plus
+ * any trailing table options, honoring SQLite's quoting (`'…'`, `"…"`,
+ * `` `…` ``, `[…]`) and comments so a quoted comma or paren cannot split the
+ * body.
+ *
+ * @internal exported for testing
+ */
+export declare function parseCreateTableBody(sql: string): ParsedCreateTable | null;
+/**
+ * The column name of a body item, or `null` when the item is a table-level
+ * constraint rather than a column definition.
+ *
+ * @internal exported for testing
+ */
+export declare function readColumnDefinitionName(item: string): string | null;
+/**
+ * Replace the declared type of a column definition, keeping its name and every
+ * constraint that follows. A column declared without a type gets one inserted.
+ *
+ * @internal exported for testing
+ */
+export declare function replaceColumnType(item: string, newType: string): string | null;
+export {};
+//# sourceMappingURL=sqlite-rebuild.d.ts.map

package/dist/migrations/sqlite-rebuild.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"sqlite-rebuild.d.ts","sourceRoot":"","sources":["../../src/migrations/sqlite-rebuild.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAgEG;AAIH,OAAO,KAAK,EAAE,YAAY,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAC;AACpE,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,YAAY,CAAC;AAIpD;;;;;GAKG;AACH,eAAO,MAAM,2BAA2B,mBAAmB,CAAC;AAE5D;;;;;GAKG;AACH,wBAAgB,2BAA2B,CAAC,UAAU,EAAE,MAAM,GAAG,MAAM,CAEtE;AAED;;;GAGG;AACH,wBAAgB,0BAA0B,CAAC,GAAG,EAAE,MAAM,GAAG,SAAS,GAAG,OAAO,CAE3E;AAcD,mEAAmE;AACnE,MAAM,WAAW,sBAAsB;IACrC,mEAAmE;IACnE,UAAU,EAAE,MAAM,EAAE,CAAC;IACrB,0EAA0E;IAC1E,aAAa,EAAE,MAAM,EAAE,CAAC;IACxB,kEAAkE;IAClE,gBAAgB,EAAE,MAAM,EAAE,CAAC;CAC5B;AAsBD,MAAM,WAAW,8BAA8B;IAC7C,EAAE,EAAE,iBAAiB,CAAC;IACtB,SAAS,EAAE,MAAM,CAAC;IAClB,0EAA0E;IAC1E,OAAO,EAAE,YAAY,EAAE,CAAC;IACxB,4EAA4E;IAC5E,OAAO,EAAE,CAAC,IAAI,EAAE,WAAW,KAAK,MAAM,CAAC;CACxC;AAED;;;;;;;;;;;;;;;;;;;;GAoBG;AACH,wBAAsB,uBAAuB,CAC3C,OAAO,EAAE,8BAA8B,GACtC,OAAO,CAAC,YAAY,EAAE,CAAC,CAyGzB;AAqHD,MAAM,WAAW,iCAAiC;IAChD,SAAS,EAAE,MAAM,CAAC;IAClB,sDAAsD;IACtD,cAAc,EAAE,MAAM,CAAC;IACvB,uEAAuE;IACvE,WAAW,EAAE,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IACjC,oEAAoE;IACpE,OAAO,EAAE,MAAM,EAAE,CAAC;IAClB,qDAAqD;IACrD,OAAO,EAAE;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,GAAG,EAAE,MAAM,CAAA;KAAE,EAAE,CAAC;IACzC,4EAA4E;IAC5E,gBAAgB,EAAE,OAAO,CAAC;CAC3B;AAED;;;;;;;;;;;;;;;;;GAiBG;AACH,wBAAgB,4BAA4B,CAC1C,KAAK,EAAE,iCAAiC,GACvC,sBAAsB,GAAG,IAAI,CAgD/B;AAED;;;;;;;;;;;GAWG;AACH,wBAAgB,wBAAwB,CACtC,cAAc,EAAE,MAAM,EACtB,MAAM,EAAE;IAAE,SAAS,EAAE,MAAM,CAAC;IAAC,WAAW,EAAE,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;CAAE,GAC9D,MAAM,GAAG,IAAI,CAqCf;AAED,UAAU,iBAAiB;IACzB,oEAAoE;IACpE,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,yEAAyE;IACzE,IAAI,EAAE,MAAM,CAAC;CACd;AAED;;;;;;;GAOG;AACH,wBAAgB,oBAAoB,CAAC,GAAG,EAAE,MAAM,GAAG,iBAAiB,GAAG,IAAI,CAgE1E;AAoGD;;;;;GAKG;AACH,wBAAgB,wBAAwB,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM,GAAG,IAAI,CAYpE;AAED;;;;;GAKG;AACH,wBAAgB,iBAAiB,CAC/B,IAAI,EAAE,MAAM,EACZ,OAAO,EAAE,MAAM,GACd,MAAM,GAAG,IAAI,CAgDf"}