@happychef/algorithm 1.2.10 → 1.2.12

package/changes/2025/December/PR2___change.md

@@ -1,15 +1,15 @@
-# PR 2 - Check default value for uurOpVoorhand field
-
-**Actions:** 
-
-## Changes Summary
-NO_ADDITIONS
-NO_REMOVALS
-CHANGED:
-- Modified default value of `uurOpVoorhand` variable in `getAvailableTimeblocks.js` from `4` to `0`.
-
----
-
-**Author:** thibaultvandesompele2
-**Date:** 2025-12-08
+# PR 2 - Check default value for uurOpVoorhand field
+
+**Actions:** 
+
+## Changes Summary
+NO_ADDITIONS
+NO_REMOVALS
+CHANGED:
+- Modified default value of `uurOpVoorhand` variable in `getAvailableTimeblocks.js` from `4` to `0`.
+
+---
+
+**Author:** thibaultvandesompele2
+**Date:** 2025-12-08
 **PR Link:** https://github.com/thibaultvandesompele2/15-happy-algorithm/pull/2

package/changes/2025/December/PR3_add__change.md

@@ -1,21 +1,21 @@
-# PR 3 - Fix timezone issue with meal stop filters
-
-**Actions:** 
-
-## Changes Summary
-ADDED:
-- New function `getMealStopTime` added to handle timezone-aware meal stop time calculations.
-- New import `pytz` added to support timezone operations in the codebase.
-- New configuration parameter `DEFAULT_TIMEZONE` introduced for default timezone settings.
-
-NO_REMOVALS
-
-CHANGED:
-- Modified the `getAvailableTimeblocks` function to change the `uurOpVoorhand` variable from a hardcoded value of `4` to a dynamic value of `0`, altering the time calculation logic for meal stop filters.
-- Updated the `getAvailableTimeblocks` function to replace the fixed `uurOpVoorhand` with `0`, affecting how timeblocks are filtered based on the current time and timezone considerations.
-
----
-
-**Author:** thibaultvandesompele2
-**Date:** 2025-12-09
+# PR 3 - Fix timezone issue with meal stop filters
+
+**Actions:** 
+
+## Changes Summary
+ADDED:
+- New function `getMealStopTime` added to handle timezone-aware meal stop time calculations.
+- New import `pytz` added to support timezone operations in the codebase.
+- New configuration parameter `DEFAULT_TIMEZONE` introduced for default timezone settings.
+
+NO_REMOVALS
+
+CHANGED:
+- Modified the `getAvailableTimeblocks` function to change the `uurOpVoorhand` variable from a hardcoded value of `4` to a dynamic value of `0`, altering the time calculation logic for meal stop filters.
+- Updated the `getAvailableTimeblocks` function to replace the fixed `uurOpVoorhand` with `0`, affecting how timeblocks are filtered based on the current time and timezone considerations.
+
+---
+
+**Author:** thibaultvandesompele2
+**Date:** 2025-12-09
 **PR Link:** https://github.com/thibaultvandesompele2/15-happy-algorithm/pull/3

package/changes/2025/December/PR4___.md

@@ -0,0 +1,16 @@
+# PR 4 - TEST: Add intentionally failing tests
+
+**Actions:** 
+
+## Changes Summary
+NO_ADDITIONS
+
+NO_REMOVALS
+
+NO_CHANGES
+
+---
+
+**Author:** houssammk123
+**Date:** 2025-12-09
+**PR Link:** https://github.com/thibaultvandesompele2/15-happy-algorithm/pull/4

package/changes/2025/December/PR5___.md

@@ -0,0 +1,16 @@
+# PR 5 - TEST: Add passing helper tests
+
+**Actions:** 
+
+## Changes Summary
+NO_ADDITIONS
+
+NO_REMOVALS
+
+NO_CHANGES
+
+---
+
+**Author:** houssammk123
+**Date:** 2025-12-09
+**PR Link:** https://github.com/thibaultvandesompele2/15-happy-algorithm/pull/5

package/changes/2025/December/PR6__del_.md

@@ -0,0 +1,18 @@
+# PR 6 - Fix remove meaningless tests
+
+**Actions:** 
+
+## Changes Summary
+NO_ADDITIONS
+
+REMOVED:
+- Removed test case `test_remove_meaningless_tests` from the test suite.
+- Removed the entire test file `test_remove_meaningless_tests.py` from the repository.
+
+NO_CHANGES
+
+---
+
+**Author:** houssammk123
+**Date:** 2025-12-09
+**PR Link:** https://github.com/thibaultvandesompele2/15-happy-algorithm/pull/6

package/changes/2025/December/PR7_add__change.md

@@ -0,0 +1,22 @@
+# PR 7 - Fix/infinite loop table assignment
+
+**Actions:** 
+
+## Changes Summary
+ADDED:
+- New function `findTableForParty(tables, partySize)` added to handle table assignment logic.
+- New variable `assignedTables` introduced to track which tables have been assigned.
+- New import `itertools` added to support combination generation for table selection.
+
+NO_REMOVALS
+
+CHANGED:
+- Modified the `assignTables` function in `src/tableAssignment.js` to replace the `while` loop with a `for` loop that iterates over a pre-calculated `availableTables` array to prevent infinite loops.
+- Updated the table selection logic inside the loop from a random index selection (`Math.floor(Math.random() * availableTables.length)`) to a sequential index selection using the loop counter `i`.
+- Changed the condition for breaking out of the assignment loop from checking `remainingGuests > 0` to checking if `availableTables.length > 0` and if the current table's capacity is sufficient for the party size.
+
+---
+
+**Author:** houssammk123
+**Date:** 2025-12-12
+**PR Link:** https://github.com/thibaultvandesompele2/15-happy-algorithm/pull/7

package/changes/2026/January/PR8_add__change.md

@@ -0,0 +1,39 @@
+# PR 8 - Claude/table assignment logic ia5 s3
+
+**Actions:** 
+
+## Changes Summary
+ADDED:
+- New function `assign_tables_to_parties` added to handle table assignment logic for parties.
+- New function `calculate_table_capacity` added to compute total capacity of a list of tables.
+- New function `find_best_table_combination` added to find optimal table combinations for parties.
+- New function `assign_parties_to_tables` added to allocate parties to specific tables.
+- New function `calculate_waiting_time` added to estimate waiting time for parties.
+- New function `optimize_table_rotation` added to improve table turnover efficiency.
+- New function `validate_party_size` added to check if party size is within acceptable limits.
+- New function `update_table_availability` added to modify table status after assignments.
+- New function `generate_seating_plan` added to create final seating arrangements.
+- New function `handle_special_requests` added to manage special seating requirements.
+- New function `calculate_utilization_rate` added to measure table usage efficiency.
+- New function `prioritize_parties` added to sort parties by priority criteria.
+- New function `check_table_compatibility` added to verify table-party suitability.
+- New function `reserve_tables` added to temporarily hold tables for upcoming parties.
+- New function `release_tables` added to free up tables after party departure.
+- New function `simulate_seating_scenarios` added to test different assignment strategies.
+- New function `adjust_for_group_size` added to handle large party splitting logic.
+- New function `calculate_distance_to_entrance` added to optimize table location selection.
+- New function `manage_waitlist` added to handle waiting party queue operations.
+- New function `log_assignment_decisions` added to record assignment rationale for debugging.
+
+NO_REMOVALS
+
+CHANGED:
+- Modified the `getAvailableTimeblocks` function in `src/table-assignment/table-assignment.js` to change the `uurOpVoorhand` variable from `4` to `0`, affecting how far in advance timeblocks are considered available.
+- Updated the `getAvailableTimeblocks` function to change the `uurOpVoorhand` variable from `4` to `0` in the calculation of `availableTimeblocks`, specifically in the condition `if (timeblock.getHours() >= currentHour + uurOpVoorhand)`.
+- Modified the `getAvailableTimeblocks` function to change the `uurOpVoorhand` variable from `4` to `0` in the calculation of `availableTimeblocks`, specifically in the condition `if (timeblock.getHours() >= currentHour + uurOpVoorhand && timeblock.getHours() < 22)`.
+
+---
+
+**Author:** Fakhar-Rashid
+**Date:** 2026-01-06
+**PR Link:** https://github.com/thibaultvandesompele2/15-happy-algorithm/pull/8

package/changes/2026/January/PR9_add__change.md

@@ -0,0 +1,20 @@
+# PR 9 - Fix table minimum capacity validation for reservations
+
+**Actions:** 
+
+## Changes Summary
+ADDED:
+- New condition `sum(minCapacity) <= guests` added to the `findMultiTableCombination` function in `simulateTableAssignment.js` to validate minimum capacity constraints.
+- New variable `minSum` introduced within the combination validation loop to accumulate the sum of `table.minCapacity` for selected tables.
+
+NO_REMOVALS
+
+CHANGED:
+- Modified the `findMultiTableCombination` function in `simulateTableAssignment.js` to include a check for the sum of `minCapacity` being less than or equal to the number of guests, in addition to the existing check for the sum of `maxCapacity`. This ensures the function now validates that `sum(minCapacity) <= guests <= sum(maxCapacity)`.
+- Updated the logic within the combination validation loop to calculate `totalMinCapacity` alongside `totalMaxCapacity` and use both in the condition to determine a valid table combination.
+
+---
+
+**Author:** thibaultvandesompele2
+**Date:** 2026-01-07
+**PR Link:** https://github.com/thibaultvandesompele2/15-happy-algorithm/pull/9

package/filters/maxArrivalsFilter.js

@@ -1,115 +1,115 @@
-// file: /src/Pages/NewReservation/StepOne/algorithm/maxArrivalsFilter.js
-
-/**
- * Simple max arrivals filter for time slots
- * 
- * Only considers exact arrivals at each time slot without factoring duration
- */
-
-/**
- * Get meal type based on time
- * @param {string} time - Time string (HH:MM)
- * @returns {string|null} - Meal type or null
- */
-function getMealType(time) {
-	const hour = parseInt(time.split(':')[0], 10);
-	
-	if (hour >= 4 && hour < 11) return 'breakfast';
-	if (hour >= 11 && hour < 16) return 'lunch';
-	if (hour >= 16 && hour < 23) return 'dinner';
-	
-	return null;
-  }
-  
-  /**
-   * Extract number value from various data formats
-   * @param {*} value - Value from data object
-   * @returns {number|null} - Number or null
-   */
-  function extractNumber(value) {
-	if (!value) return null;
-	
-	// Handle MongoDB NumberInt format
-	if (value.$numberInt) {
-	  return parseInt(value.$numberInt, 10);
-	}
-	
-	// Handle regular number
-	if (typeof value === 'number') {
-	  return value;
-	}
-	
-	// Handle string number
-	if (typeof value === 'string') {
-	  const parsed = parseInt(value, 10);
-	  return isNaN(parsed) ? null : parsed;
-	}
-	
-	return null;
-  }
-  
-  /**
-   * Count guests arriving at exact time
-   * @param {Array} reservations - Reservation list
-   * @param {string} date - Date (YYYY-MM-DD)
-   * @param {string} time - Time (HH:MM)
-   * @returns {number} - Guest count
-   */
-  function countArrivalsAtTime(reservations, date, time) {
-	return reservations
-	  .filter(r => r.date === date && r.time === time)
-	  .reduce((sum, r) => sum + (parseInt(r.guests, 10) || 0), 0);
-  }
-  
-  /**
-   * Filter timeblocks based on max arrivals settings
-   * @param {Object} restaurantData - Restaurant data
-   * @param {string} date - Date string
-   * @param {Object} timeblocks - Available timeblocks
-   * @param {Array} reservations - Existing reservations
-   * @param {number} guests - New reservation guest count
-   * @returns {Object} - Filtered timeblocks
-   */
-  function filterTimeblocksByMaxArrivals(restaurantData, date, timeblocks, reservations, guests) {
-	const filteredBlocks = {};
-	
-	for (const [time, timeData] of Object.entries(timeblocks)) {
-	  // Get meal type for this time
-	  const mealType = getMealType(time);
-	  if (!mealType) {
-		// Keep the timeblock if we can't determine its meal type
-		filteredBlocks[time] = timeData;
-		continue;
-	  }
-	  
-	  // Get max arrivals config for this meal type
-	  const maxArrivalsConfig = restaurantData[`max-arrivals-${mealType}`];
-	  if (!maxArrivalsConfig) {
-		// Keep the timeblock if no max arrivals config for this meal type
-		filteredBlocks[time] = timeData;
-		continue; 
-	  }
-	  
-	  // Get max arrivals value for this specific time
-	  const maxArrivals = extractNumber(maxArrivalsConfig[time]);
-	  if (maxArrivals === null) {
-		// Keep the timeblock if no specific max arrivals for this time
-		filteredBlocks[time] = timeData;
-		continue;
-	  }
-	  
-	  // Count current arrivals at this exact time
-	  const currentArrivals = countArrivalsAtTime(reservations, date, time);
-	  
-	  // Only include timeblock if adding these guests doesn't exceed max arrivals
-	  if (currentArrivals + guests <= maxArrivals) {
-		filteredBlocks[time] = timeData;
-	  }
-	}
-	
-	return filteredBlocks;
-  }
-  
-  module.exports = {
-	filterTimeblocksByMaxArrivals
+// file: /src/Pages/NewReservation/StepOne/algorithm/maxArrivalsFilter.js
+
+/**
+ * Simple max arrivals filter for time slots
+ * 
+ * Only considers exact arrivals at each time slot without factoring duration
+ */
+
+/**
+ * Get meal type based on time
+ * @param {string} time - Time string (HH:MM)
+ * @returns {string|null} - Meal type or null
+ */
+function getMealType(time) {
+	const hour = parseInt(time.split(':')[0], 10);
+	
+	if (hour >= 4 && hour < 11) return 'breakfast';
+	if (hour >= 11 && hour < 16) return 'lunch';
+	if (hour >= 16 && hour < 23) return 'dinner';
+	
+	return null;
+  }
+  
+  /**
+   * Extract number value from various data formats
+   * @param {*} value - Value from data object
+   * @returns {number|null} - Number or null
+   */
+  function extractNumber(value) {
+	if (!value) return null;
+	
+	// Handle MongoDB NumberInt format
+	if (value.$numberInt) {
+	  return parseInt(value.$numberInt, 10);
+	}
+	
+	// Handle regular number
+	if (typeof value === 'number') {
+	  return value;
+	}
+	
+	// Handle string number
+	if (typeof value === 'string') {
+	  const parsed = parseInt(value, 10);
+	  return isNaN(parsed) ? null : parsed;
+	}
+	
+	return null;
+  }
+  
+  /**
+   * Count guests arriving at exact time
+   * @param {Array} reservations - Reservation list
+   * @param {string} date - Date (YYYY-MM-DD)
+   * @param {string} time - Time (HH:MM)
+   * @returns {number} - Guest count
+   */
+  function countArrivalsAtTime(reservations, date, time) {
+	return reservations
+	  .filter(r => r.date === date && r.time === time)
+	  .reduce((sum, r) => sum + (parseInt(r.guests, 10) || 0), 0);
+  }
+  
+  /**
+   * Filter timeblocks based on max arrivals settings
+   * @param {Object} restaurantData - Restaurant data
+   * @param {string} date - Date string
+   * @param {Object} timeblocks - Available timeblocks
+   * @param {Array} reservations - Existing reservations
+   * @param {number} guests - New reservation guest count
+   * @returns {Object} - Filtered timeblocks
+   */
+  function filterTimeblocksByMaxArrivals(restaurantData, date, timeblocks, reservations, guests) {
+	const filteredBlocks = {};
+	
+	for (const [time, timeData] of Object.entries(timeblocks)) {
+	  // Get meal type for this time
+	  const mealType = getMealType(time);
+	  if (!mealType) {
+		// Keep the timeblock if we can't determine its meal type
+		filteredBlocks[time] = timeData;
+		continue;
+	  }
+	  
+	  // Get max arrivals config for this meal type
+	  const maxArrivalsConfig = restaurantData[`max-arrivals-${mealType}`];
+	  if (!maxArrivalsConfig) {
+		// Keep the timeblock if no max arrivals config for this meal type
+		filteredBlocks[time] = timeData;
+		continue; 
+	  }
+	  
+	  // Get max arrivals value for this specific time
+	  const maxArrivals = extractNumber(maxArrivalsConfig[time]);
+	  if (maxArrivals === null) {
+		// Keep the timeblock if no specific max arrivals for this time
+		filteredBlocks[time] = timeData;
+		continue;
+	  }
+	  
+	  // Count current arrivals at this exact time
+	  const currentArrivals = countArrivalsAtTime(reservations, date, time);
+	  
+	  // Only include timeblock if adding these guests doesn't exceed max arrivals
+	  if (currentArrivals + guests <= maxArrivals) {
+		filteredBlocks[time] = timeData;
+	  }
+	}
+	
+	return filteredBlocks;
+  }
+  
+  module.exports = {
+	filterTimeblocksByMaxArrivals
   };