@happier-dev/stack 0.2.11 → 0.2.12

package/scripts/dev_external_server_flags.test.mjs

@@ -24,11 +24,29 @@ test('dev --json reports local server mode by default', async () => {
   const repoRoot = dirname(dirname(packageRoot)); // repo root
   const devScript = join(packageRoot, 'scripts', 'dev.mjs');
 
-  const res = await runNode([devScript, '--json'], { cwd: repoRoot, env: process.env });
-  assert.equal(res.code, 0, `expected exit 0, got ${res.code}\nstdout:\n${res.stdout}\nstderr:\n${res.stderr}`);
-  const parsed = JSON.parse(res.stdout);
-  assert.equal(parsed.startServer, true);
-  assert.equal(parsed.serverConnectionSource, 'local');
+  const storageDir = await mkdtemp(join(tmpdir(), 'hstack-dev-local-default-'));
+  try {
+    const res = await runNode([devScript, '--json'], {
+      cwd: repoRoot,
+      env: {
+        ...process.env,
+        HAPPIER_SERVER_URL: '',
+        HAPPIER_STACK_STACK: 'repo-local-default',
+        HAPPIER_STACK_HOME_DIR: join(storageDir, 'home'),
+        HAPPIER_STACK_STORAGE_DIR: storageDir,
+        HAPPIER_STACK_SANDBOX_DIR: join(storageDir, 'sandbox'),
+        HAPPIER_STACK_REPO_DIR: '',
+        HAPPIER_STACK_ENV_FILE: '',
+        HAPPIER_STACK_DISABLE_STACK_ENV_AUTOLOAD: '1',
+      },
+    });
+    assert.equal(res.code, 0, `expected exit 0, got ${res.code}\nstdout:\n${res.stdout}\nstderr:\n${res.stderr}`);
+    const parsed = JSON.parse(res.stdout);
+    assert.equal(parsed.startServer, true);
+    assert.equal(parsed.serverConnectionSource, 'local');
+  } finally {
+    await rm(storageDir, { recursive: true, force: true });
+  }
 });
 
 test('dev --no-server --json fails without an external server URL', async () => {

package/scripts/ghops.test.mjs

@@ -305,7 +305,9 @@ test('fails closed when token is missing', () => {
   assert.match(res.stderr, /HAPPIER_GITHUB_BOT_TOKEN/);
 });
 
-test('uses the execution-host credential broker when the VM has no environment token', () => {
+test('uses the execution-host credential broker when the VM has no environment token', {
+  skip: process.platform !== 'linux' ? 'execution-host credential brokering is Linux-VM-only' : false,
+}, () => {
   const dir = mkdtempSync(join(tmpdir(), 'ghops-mac-host-token-test-'));
   const { fakeGh } = createFakeBotAuthTools(dir);
   const fixture = createMacHostCredentialFixture(dir);
@@ -328,7 +330,9 @@ test('uses the execution-host credential broker when the VM has no environment t
   assert.deepEqual(JSON.parse(input), { version: 1, operation: 'read-ghops-credential' });
 });
 
-test('keeps an explicit bot push on the authoritative checkout when the credential comes from mac-host', () => {
+test('keeps an explicit bot push on the authoritative checkout when the credential comes from mac-host', {
+  skip: process.platform !== 'linux' ? 'execution-host credential brokering is Linux-VM-only' : false,
+}, () => {
   const dir = mkdtempSync(join(tmpdir(), 'ghops-mac-host-git-push-test-'));
   const { fakeGh } = createFakeBotAuthTools(dir);
   const { fakeGit, gitLog } = createFakeGitPushTool(dir);
@@ -359,7 +363,9 @@ test('keeps an explicit bot push on the authoritative checkout when the credenti
   assert.equal(readFileSync(fixture.sshLog, 'utf8').trim().split('\n').length, 1);
 });
 
-test('fails closed when the configured mac-host credential route is unavailable', () => {
+test('fails closed when the configured mac-host credential route is unavailable', {
+  skip: process.platform !== 'linux' ? 'execution-host credential brokering is Linux-VM-only' : false,
+}, () => {
   const dir = mkdtempSync(join(tmpdir(), 'ghops-mac-host-unavailable-test-'));
   const { fakeGh } = createFakeBotAuthTools(dir);
   const fixture = createMacHostCredentialFixture(dir);

package/scripts/provision/linux-ubuntu-provision.sh

@@ -126,6 +126,10 @@ Description=Happier session jobs
 [Slice]
 CPUWeight=50
 IOWeight=50
+# Reclaim and throttle disposable session work before it can starve the guest
+# OS and the protected Happier control plane. This is deliberately soft: jobs
+# can exceed it under pressure and are never OOM-killed by this policy.
+MemoryHigh=80%
 EOF
   chmod 0644 "${unit_dir}/happier-jobs.slice"
 
@@ -141,6 +145,7 @@ as_root apt-get install -y --no-install-recommends \
   ca-certificates \
   curl \
   git \
+  gh \
   gnupg \
   jq \
   xz-utils \

package/scripts/provision/linux-ubuntu-provision.test.mjs

@@ -113,7 +113,8 @@ test('linux provision (happier profile) runs corepack enable as root', async ()
   assert.match(happierJobsSliceUnit, /^\[Slice\]$/m);
   assert.match(happierJobsSliceUnit, /^CPUWeight=50$/m);
   assert.match(happierJobsSliceUnit, /^IOWeight=50$/m);
-  assert.doesNotMatch(happierJobsSliceUnit, /MemoryMax|MemoryHigh|TasksMax|OOM/u);
+  assert.match(happierJobsSliceUnit, /^MemoryHigh=80%$/m);
+  assert.doesNotMatch(happierJobsSliceUnit, /^(?:MemoryMax|TasksMax|OOM\w*)=/mu);
 
   const corepackOut = await readIfExists(corepackLog);
   assert.match(corepackOut, /corepack enable root=1/, 'expected corepack enable to be invoked via sudo/as_root');
@@ -122,6 +123,7 @@ test('linux provision (happier profile) runs corepack enable as root', async ()
   const aptOut = await readIfExists(aptLog);
   assert.match(aptOut, /apt-get update/, 'expected apt-get update to run');
   assert.match(aptOut, /apt-get install/, 'expected apt-get install to run');
+  assert.match(aptOut, /(?:^|\s)gh(?:\s|$)/, 'expected the GitHub CLI to be installed');
 
   const secondResult = spawnSync('bash', [scriptPath, '--profile=happier'], {
     cwd: root,

package/scripts/self_host_launchd.real.integration.test.mjs

@@ -6,6 +6,8 @@ import test from 'node:test';
 import { fileURLToPath } from 'node:url';
 
 const SELF_HOST_INSTALL_TIMEOUT_MS = 420_000;
+const SELF_HOST_ARTIFACT_BUILD_TIMEOUT_MS = 12 * 60_000;
+const SELF_HOST_TEST_TIMEOUT_MS = 30 * 60_000;
 
 import { commandExists, extractBinaryFromArtifact, reserveLocalhostPort, run, waitForHealth } from './self_host_service_e2e_harness.mjs';
 
@@ -23,7 +25,7 @@ function launchctlPrintTarget(label) {
 
 test(
   'compiled hstack self-host install/uninstall works on macOS launchd host without repo checkout',
-  { timeout: 15 * 60_000 },
+  { timeout: SELF_HOST_TEST_TIMEOUT_MS },
   async (t) => {
     if (process.platform !== 'darwin') {
       t.skip(`macos-only test (current: ${process.platform})`);
@@ -58,7 +60,7 @@ test(
         label: 'self-host-launchd',
         cwd: repoRoot,
         env: { ...process.env },
-        timeoutMs: 8 * 60_000,
+        timeoutMs: SELF_HOST_ARTIFACT_BUILD_TIMEOUT_MS,
       }
     );
     run(
@@ -73,7 +75,7 @@ test(
         label: 'self-host-launchd',
         cwd: repoRoot,
         env: { ...process.env },
-        timeoutMs: 8 * 60_000,
+        timeoutMs: SELF_HOST_ARTIFACT_BUILD_TIMEOUT_MS,
       }
     );
 

package/scripts/self_host_runtime.mjs

@@ -43,6 +43,7 @@ import {
   resolveConfiguredRelayRuntimeBinaryOverride,
   resolveConfiguredRelayRuntimePaths,
 } from '@happier-dev/cli-common/firstPartyRuntime/relayRuntime';
+import { removeRuntimePayloadPath } from '@happier-dev/cli-common/firstPartyRuntime';
 import {
   mergeSelfHostServerEnvText,
   parseEnvText as parseEnvTextShared,
@@ -2364,18 +2365,18 @@ async function cmdUninstall({ channel, mode, argv, json }) {
     homeDir: homedir(),
     spec: serviceSpec,
     persistent: true,
-  }).catch(() => {});
+  });
 
-  await rm(config.serverBinaryPath, { force: true });
-  await rm(config.serverPreviousBinaryPath, { force: true });
-  await rm(join(config.binDir, config.serverBinaryName), { force: true });
-  await rm(config.statePath, { force: true });
+  await removeRuntimePayloadPath(config.serverBinaryPath, config.platform);
+  await removeRuntimePayloadPath(config.serverPreviousBinaryPath, config.platform);
+  await removeRuntimePayloadPath(join(config.binDir, config.serverBinaryName), config.platform);
+  await removeRuntimePayloadPath(config.statePath, config.platform);
 
   if (purgeData) {
-    await rm(config.installRoot, { recursive: true, force: true });
-    await rm(config.configDir, { recursive: true, force: true });
-    await rm(config.dataDir, { recursive: true, force: true });
-    await rm(config.logDir, { recursive: true, force: true });
+    await removeRuntimePayloadPath(config.installRoot, config.platform);
+    await removeRuntimePayloadPath(config.configDir, config.platform);
+    await removeRuntimePayloadPath(config.dataDir, config.platform);
+    await removeRuntimePayloadPath(config.logDir, config.platform);
   }
 
   printResult({

package/scripts/self_host_runtime.test.mjs

@@ -1631,7 +1631,7 @@ test('renderServerEnvFile emits sqlite/local defaults for self-host mode', () =>
   assert.match(envText, /PORT=3005/);
   assert.match(envText, /METRICS_ENABLED=false/);
   assert.match(envText, /HAPPIER_DB_PROVIDER=sqlite/);
-  assert.match(envText, /DATABASE_URL=file:\/\/\/var\/lib\/happier\/happier-server-light\.sqlite/);
+  assert.match(envText, /DATABASE_URL=file:\/var\/lib\/happier\/happier-server-light\.sqlite/);
   assert.match(envText, /HAPPIER_FILES_BACKEND=local/);
   assert.match(envText, /HAPPIER_SQLITE_AUTO_MIGRATE=1/);
   assert.match(envText, /HAPPIER_SQLITE_MIGRATIONS_DIR=\/var\/lib\/happier\/migrations\/sqlite/);
@@ -1703,7 +1703,7 @@ test('renderServerEnvFile uses Prisma-compatible sqlite DATABASE_URL semantics o
     filesDir: 'C:\\\\Users\\\\me\\\\Happier QA\\\\self-host\\\\data\\\\files',
     dbDir: 'C:\\\\Users\\\\me\\\\Happier QA\\\\self-host\\\\data\\\\pglite',
   });
-  assert.match(envText, /DATABASE_URL=file:C:\/Users\/me\/Happier%20QA\/self-host\/data\/happier-server-light\.sqlite/);
+  assert.match(envText, /DATABASE_URL=file:C:\\Users\\me\\Happier QA\\self-host\\data\\happier-server-light\.sqlite/);
 });
 
 test('resolveSelfHostHealthTimeoutMs defaults to a safe health timeout', () => {

package/scripts/utils/dev/expo_dev.buildEnv.test.mjs

@@ -74,6 +74,20 @@ test('buildExpoDevEnv uses the Tailscale IP for dev-client local API URLs when p
   assert.equal(env.EXPO_PUBLIC_SERVER_URL, 'http://100.64.0.10:3013');
 });
 
+test('buildExpoDevEnv publishes a remote target through its stable outer Expo port', () => {
+  const env = buildExpoDevEnv({
+    baseEnv: { HAPPIER_STACK_EXPO_PUBLIC_PORT: '18829' },
+    apiServerUrl: 'http://localhost:52753',
+    wantDevClient: true,
+    wantWeb: true,
+    stackMode: true,
+    stackName: 'qa-agent-remote',
+    expoPublicHost: '100.79.179.31',
+  });
+
+  assert.equal(env.EXPO_PACKAGER_PROXY_URL, 'http://100.79.179.31:18829');
+});
+
 test('buildExpoDevEnv does not set EXPO_APP_SLUG in dev-client mode (slug must match EAS project)', () => {
   const baseEnv = {
     ...process.env,

package/scripts/utils/dev/expo_dev.mjs

@@ -347,6 +347,7 @@ export function buildExpoDevEnv({
   stackMode,
   stackName,
   expoTailscaleIp = '',
+  expoPublicHost = '',
 } = {}) {
   const env = { ...(baseEnv || process.env) };
   delete env.CI;
@@ -370,6 +371,23 @@ export function buildExpoDevEnv({
   env.EXPO_PUBLIC_HAPPIER_SERVER_URL = effectiveApiServerUrl;
   env.EXPO_PUBLIC_HAPPY_SERVER_URL = effectiveApiServerUrl;
   env.EXPO_PUBLIC_SERVER_URL = effectiveApiServerUrl;
+  const publicExpoPort = Number(env.HAPPIER_STACK_EXPO_PUBLIC_PORT);
+  if (
+    wantDevClient
+    && !String(env.EXPO_PACKAGER_PROXY_URL ?? '').trim()
+    && Number.isInteger(publicExpoPort)
+    && publicExpoPort > 0
+  ) {
+    const localPublicUrl = `http://localhost:${publicExpoPort}`;
+    const reachablePublicUrl = resolveMobileReachableServerUrl({
+      env,
+      serverUrl: localPublicUrl,
+      preferredHost: expoPublicHost,
+    });
+    if (reachablePublicUrl && reachablePublicUrl !== localPublicUrl) {
+      env.EXPO_PACKAGER_PROXY_URL = reachablePublicUrl;
+    }
+  }
   if (stackMode) {
     env.EXPO_PUBLIC_HAPPY_SERVER_CONTEXT = 'stack';
   }
@@ -434,7 +452,11 @@ export async function ensureDevExpoServer({
   }
 
   const wantTailscale = resolveExpoTailscaleEnabled({ env: baseEnv, expoTailscale });
-  const tailscaleStatus = wantTailscale ? await getTailscaleStatus({ env: baseEnv }) : null;
+  const publicExpoPort = Number(baseEnv?.HAPPIER_STACK_EXPO_PUBLIC_PORT);
+  const needsPublicExpoHost = wantDevClient && Number.isInteger(publicExpoPort) && publicExpoPort > 0;
+  const tailscaleStatus = wantTailscale || needsPublicExpoHost
+    ? await getTailscaleStatus({ env: baseEnv })
+    : null;
   const expoTailscaleIp = tailscaleStatus?.available && tailscaleStatus?.ip ? tailscaleStatus.ip : '';
 
   const env = buildExpoDevEnv({
@@ -445,6 +467,7 @@ export async function ensureDevExpoServer({
     stackMode,
     stackName,
     expoTailscaleIp,
+    expoPublicHost: expoTailscaleIp,
   });
 
   // Mobile config is needed for `--scheme` and for the app's environment.

package/scripts/utils/dev_targets/mutagen_project.mjs

@@ -11,6 +11,7 @@ const DEFAULT_IGNORES = [
   '.*.__sync_backup__.*',
   '.tmp.*',
   '.backup.*',
+  'packages/plugin-sdk/.example-builds',
   '.project',
   '.happier',
   '.happier-stack',
@@ -36,7 +37,9 @@ const DEFAULT_IGNORES = [
   '.restore.*',
   '.dist.hstack-*',
   '.cxx',
-  'apps/ui/ios/build',
+  // Expo prebuild generates this entire Git-ignored tree for the target's
+  // native identity and toolchain. Replication would undo its Info.plist.
+  'apps/ui/ios',
   'apps/ui/android/app/build',
   'apps/ui/android/build',
   'apps/ui/android/.gradle',

package/scripts/utils/dev_targets/mutagen_project.test.mjs

@@ -51,6 +51,7 @@ test('renderMutagenProject creates one-way source replicas while retaining targe
     '.*.__sync_backup__.*',
     '.tmp.*',
     '.backup.*',
+    'packages/plugin-sdk/.example-builds',
     '.project',
     '.happier',
     'coverage',
@@ -75,7 +76,7 @@ test('renderMutagenProject creates one-way source replicas while retaining targe
     '.restore.*',
     '.dist.hstack-*',
     '.cxx',
-    'apps/ui/ios/build',
+    'apps/ui/ios',
     'apps/ui/android/app/build',
     'apps/ui/android/build',
     'apps/ui/android/.gradle',

package/scripts/utils/dev_targets/remote_commands.mjs

@@ -237,8 +237,6 @@ function buildRemoteDevArgs({ services, serverUrl, publicServerUrl, startMobile
   args.push('--no-browser', '--no-dev-targets', '--watch');
   if (services.expo && startMobile) args.push('--mobile');
   if (services.server) {
-    // The target's SSH forward owns the stable endpoint, so bind the server to its configured port.
-    args.push('--no-proxy');
     if (publicServerUrl) args.push(`--server-public-url=${publicServerUrl}`);
   } else {
     args.push(`--server-url=${serverUrl}`);
@@ -255,6 +253,7 @@ function resolveRemoteStackInvocation(target, {
   stackName,
   remoteServerPort = null,
   remoteExpoPort = null,
+  expoPublicPort = null,
   expoPublicUrl = '',
   startMobile = false,
   resolveServerPublicUrlOnTarget = false,
@@ -276,6 +275,9 @@ function resolveRemoteStackInvocation(target, {
   const expoPort = normalizedServices.expo
     ? requireServicePort(remoteExpoPort, 'remote Expo port')
     : null;
+  const stablePublicExpoPort = normalizedServices.expo && resolveExpoPublicUrlOnTarget
+    ? requireServicePort(expoPublicPort, 'public Expo port')
+    : null;
   const serverRuntimeConfig = normalizedServices.server
     ? normalizeRemoteServerRuntimeConfig(remoteServerRuntimeConfig)
     : null;
@@ -295,6 +297,7 @@ function resolveRemoteStackInvocation(target, {
       'HAPPIER_STACK_EXPO_DEV_PORT_STRATEGY=stable',
       'HAPPIER_STACK_EXPO_HOST=localhost',
     ]),
+    ...(stablePublicExpoPort == null ? [] : [`HAPPIER_STACK_EXPO_PUBLIC_PORT=${stablePublicExpoPort}`]),
     ...(expoPublicUrl && !resolveExpoPublicUrlOnTarget ? [`EXPO_PACKAGER_PROXY_URL=${expoPublicUrl}`] : []),
     'HAPPIER_CLI_PKGROLL_TIMEOUT_MS=1800000',
     ...(normalizedServices.daemon && deferDaemonStartUntilCredentials

package/scripts/utils/dev_targets/remote_commands.test.mjs

@@ -194,7 +194,7 @@ test('remote server command pins stable public URL and exact target-local SQLite
   assert.match(command, /HAPPIER_STACK_SERVER_PORT=43005/);
   assert.match(command, /HAPPIER_SERVER_RETENTION__SESSION_SIDECHAIN_MESSAGES__DAYS=7/);
   assert.match(command, /--server-public-url=.*127\.0\.0\.1:52753/);
-  assert.match(command, /--no-proxy/);
+  assert.doesNotMatch(command, /--no-proxy/);
   assert.doesNotMatch(command, /--no-server|--no-daemon/);
   assert.doesNotMatch(command, /guest\/data-must-not-leak|DATABASE_URL/);
   assert.match(stopCommand, /stack stop .*repo-local-dev.* --yes --no-docker --preserve-daemon/);
@@ -241,7 +241,8 @@ test('remote target resolves automatically detected mobile public addresses at i
     activeServerId: 'stack_repo__id_default',
     stackName: 'repo-local-dev',
     remoteServerPort: 52753,
-    remoteExpoPort: 18829,
+    remoteExpoPort: 30685,
+    expoPublicPort: 18829,
     expoPublicUrl: 'http://192.168.5.15:18829',
     startMobile: true,
     resolveServerPublicUrlOnTarget: true,
@@ -258,6 +259,8 @@ test('remote target resolves automatically detected mobile public addresses at i
 
   assert.match(command, /--mobile/);
   assert.match(command, /HAPPIER_STACK_EXPO_HOST=localhost/);
+  assert.match(command, /HAPPIER_STACK_EXPO_PUBLIC_PORT=18829/);
+  assert.match(command, /HAPPIER_STACK_EXPO_DEV_PORT=30685/);
   assert.doesNotMatch(command, /EXPO_PACKAGER_PROXY_URL=/);
   assert.doesNotMatch(command, /--server-public-url=/);
   assert.doesNotMatch(command, /192\.168\.5\.15/);

package/scripts/utils/dev_targets/supervisor.mjs

@@ -476,6 +476,7 @@ export async function startStackDevTargets(
           stackName,
           remoteServerPort,
           remoteExpoPort,
+          expoPublicPort: localExpoPort,
           expoPublicUrl,
           resolveServerPublicUrlOnTarget: Boolean(resolveMobilePublicUrlsOnTarget && services.server),
           resolveExpoPublicUrlOnTarget: Boolean(resolveMobilePublicUrlsOnTarget && services.expo),

package/scripts/utils/dev_targets/supervisor.test.mjs

@@ -259,6 +259,11 @@ test('authoritative Mac server forwards its target-owned Expo through the guest
     assert.ok(tunnel?.args.some((arg) => String(arg).startsWith('*:18081:localhost:')));
     const worker = calls.find((call) => call.kind === 'spawn' && call.command === 'ssh' && !call.args.includes('-N'));
     assert.match(worker?.args.at(-1) ?? '', /HAPPIER_STACK_EXPO_DEV_PORT=/);
+    assert.match(
+      worker?.args.at(-1) ?? '',
+      /HAPPIER_STACK_EXPO_PUBLIC_PORT=18081/,
+      'the target must publish the stable outer port while resolving its own reachable host',
+    );
     assert.doesNotMatch(
       worker?.args.at(-1) ?? '',
       /EXPO_PACKAGER_PROXY_URL=|--server-public-url=|192\.168\.1\.20/,

package/scripts/utils/server/apply_runtime_server_sqlite_env.test.mjs

@@ -13,7 +13,7 @@ test('applyRuntimeServerSqliteEnv uses the bounded local pool by default', () =>
 
   assert.equal(
     env.DATABASE_URL,
-    'file:///tmp/happier-data/happier-server-light.sqlite?socket_timeout=30&connection_limit=1',
+    'file:/tmp/happier-data/happier-server-light.sqlite?socket_timeout=30&connection_limit=1',
   );
 });
 
@@ -28,7 +28,7 @@ test('applyRuntimeServerSqliteEnv applies sqlite URL params from env when genera
 
   assert.equal(
     env.DATABASE_URL,
-    'file:///tmp/happier-data/happier-server-light.sqlite?socket_timeout=1&connection_limit=1',
+    'file:/tmp/happier-data/happier-server-light.sqlite?socket_timeout=1&connection_limit=1',
   );
 });
 

package/scripts/utils/server/resolve_stack_server_port.test.mjs

@@ -683,7 +683,7 @@ test('non-main stack does not reuse runtime port with only a live pid and non-ha
       runtimeStatePath,
       defaultPort: 3005,
       listenerObservationScope,
-      waitForTcpPortFreeImpl: async () => ({ status: 'occupied' }),
+      waitForTcpPortFreeImpl: async () => ({ status: 'occupied', reason: 'address-in-use' }),
     });
 
     assert.notEqual(out, port);
@@ -709,7 +709,7 @@ test('non-main stack errors when pinned server port is occupied by a non-happier
           runtimeStatePath: null,
           defaultPort: 3005,
           listenerObservationScope,
-          waitForTcpPortFreeImpl: async () => ({ status: 'occupied' }),
+          waitForTcpPortFreeImpl: async () => ({ status: 'occupied', reason: 'address-in-use' }),
         }),
       /HAPPIER_STACK_SERVER_PORT/
     );
@@ -734,7 +734,7 @@ test('non-main stack errors when pinned server port health responds 200 for anot
           runtimeStatePath: null,
           defaultPort: 3005,
           listenerObservationScope,
-          waitForTcpPortFreeImpl: async () => ({ status: 'occupied' }),
+          waitForTcpPortFreeImpl: async () => ({ status: 'occupied', reason: 'address-in-use' }),
         }),
       /HAPPIER_STACK_SERVER_PORT/
     );