@haposoft/cafekit 0.18.2 → 0.18.3

package/src/codex/scripts/setup-agents.cjs

@@ -0,0 +1,124 @@
+#!/usr/bin/env node
+'use strict';
+
+/**
+ * Install the CafeKit agents shipped in the Codex plugin into the user's Codex agents
+ * directory ($CODEX_HOME/agents, default ~/.codex/agents). Codex loads no agents from a
+ * plugin, so this runs once after the plugin is installed or updated.
+ *
+ * Every shipped file starts with a marker naming the plugin, its version and the sha256
+ * of the body below it. A file counts as CafeKit's own only when its marker hash still
+ * matches its body; only those are replaced. Anything else stays byte for byte:
+ * a missing marker, an edited body, or a symlink.
+ *
+ * A file it cannot read is kept and reported, and the other agents still install.
+ * Takes no arguments: the target is never chosen by the caller.
+ * Exit: 0 done, 1 failure, 2 usage.
+ */
+
+const fs = require('fs');
+const os = require('os');
+const path = require('path');
+const crypto = require('crypto');
+const { spawnSync } = require('child_process');
+
+const MARKER = /^# CafeKit agent: plugin=(\S+) version=(\S+) sha256=([0-9a-f]{64})\n/;
+
+const sha256 = (text) => crypto.createHash('sha256').update(text).digest('hex');
+
+/** 'absent' | 'symlink' | 'foreign' | 'modified' | 'own' */
+function ownership(file) {
+  let stat;
+  try {
+    stat = fs.lstatSync(file);
+  } catch (error) {
+    if (error.code === 'ENOENT') return 'absent';
+    throw error;
+  }
+  if (stat.isSymbolicLink()) return 'symlink';
+  if (!stat.isFile()) return 'foreign';
+  const text = fs.readFileSync(file, 'utf8');
+  const marker = text.match(MARKER);
+  if (!marker) return 'foreign';
+  return sha256(text.slice(marker[0].length)) === marker[3] ? 'own' : 'modified';
+}
+
+// Write beside the target and rename over it, so a reader never sees half a file.
+function writeAtomic(file, data, mode) {
+  const temp = path.join(path.dirname(file), `.${path.basename(file)}.${process.pid}.${crypto.randomBytes(6).toString('hex')}.tmp`);
+  try {
+    fs.writeFileSync(temp, data, { mode, flag: 'wx' });
+    fs.chmodSync(temp, mode);
+    fs.renameSync(temp, file);
+  } catch (error) {
+    fs.rmSync(temp, { force: true });
+    throw error;
+  }
+}
+
+// Codex reads agents from its home, so a session started with CODEX_HOME installs there.
+// A relative CODEX_HOME is refused rather than guessed, so it never falls back to ~/.codex.
+function codexHome() {
+  const configured = process.env.CODEX_HOME;
+  if (!configured) return path.join(os.homedir(), '.codex');
+  if (!path.isAbsolute(configured)) throw new Error(`CODEX_HOME must be an absolute path: ${configured}`);
+  return configured;
+}
+
+function repositoryRoot() {
+  const result = spawnSync('git', ['rev-parse', '--show-toplevel'], { encoding: 'utf8', timeout: 5000 });
+  return result.status === 0 && result.stdout.trim() ? result.stdout.trim() : process.cwd();
+}
+
+function main(argv) {
+  if (argv.length > 0) {
+    process.stderr.write('setup-agents takes no arguments; it installs into $CODEX_HOME/agents (default ~/.codex/agents).\n');
+    return 2;
+  }
+  const sourceDir = path.join(__dirname, '..', 'agents');
+  const targetDir = path.join(codexHome(), 'agents');
+  const repoAgents = path.join(repositoryRoot(), '.codex', 'agents');
+  const files = fs.readdirSync(sourceDir).filter((name) => name.endsWith('.toml')).sort();
+  fs.mkdirSync(targetDir, { recursive: true });
+
+  const counts = {};
+  for (const name of files) {
+    const shipped = fs.readFileSync(path.join(sourceDir, name), 'utf8');
+    const target = path.join(targetDir, name);
+    let state;
+    try {
+      state = ownership(target);
+    } catch {
+      state = 'unreadable';
+    }
+    let action;
+    if (state === 'absent') {
+      writeAtomic(target, shipped, 0o644);
+      action = 'written';
+    } else if (state === 'own') {
+      if (fs.readFileSync(target, 'utf8') === shipped) {
+        action = 'unchanged';
+      } else {
+        writeAtomic(target, shipped, fs.statSync(target).mode & 0o777);
+        action = 'replaced';
+      }
+    } else {
+      action = { symlink: 'kept (symlink)', foreign: 'kept (not installed by CafeKit)', modified: 'kept (modified)', unreadable: 'kept (unreadable)' }[state];
+    }
+    counts[action] = (counts[action] || 0) + 1;
+    process.stdout.write(`${action}: ${target}\n`);
+    if (fs.existsSync(path.join(repoAgents, name))) {
+      process.stdout.write(`collision: ${path.join(repoAgents, name)} has the same agent name in this repository\n`);
+    }
+  }
+  const summary = Object.entries(counts).map(([action, count]) => `${count} ${action}`).join(', ');
+  process.stdout.write(`CafeKit agents in ${targetDir}: ${summary}\n`);
+  return 0;
+}
+
+try {
+  process.exitCode = main(process.argv.slice(2));
+} catch (error) {
+  process.stderr.write(`setup-agents failed: ${error.message}\n`);
+  process.exitCode = 1;
+}

package/src/common/AGENTS.md

@@ -8,7 +8,7 @@
   keeps canonical execution proof in its final inline `## Receipt`.
 - Specs uses three user decisions: GATE-SCOPE for scope, GATE-REVIEW for adversarial findings,
   and GATE-DONE for completion. Planning never starts implementation; implementation
-  requires a new explicit user invocation.
+  requires a new explicit user invocation. A vibe run the user invokes delegates these gates as the state-sync rule's vibe-run exception states.
 - Synchronize only observed task state with surgical edits. Never invent proof,
   readiness, approval, review independence, or completed work.
 - `NO_TESTS` and `0 tests + exit 0` do not pass when the task requires automated tests.

package/src/omp/extensions/{cafekit-bridge.mjs → cafekit-bridge.js}

@@ -9,7 +9,11 @@
  * payload the scripts read, runs the scripts as child processes, and translates their
  * verdicts back into omp's contract.
  *
- * Three facts read from the installed omp binary drive the design:
+ * Facts read from the installed omp binary drive the design:
+ *  - omp auto-loads only `<name>.{ts,js}` and `<dir>/index.{ts,js}` from `.omp/extensions/`, so this
+ *    file is `.js`; an `.mjs` bridge is never loaded and every gate is silently off.
+ *  - omp is a Bun binary: `process.execPath` is omp itself, not node, so the hooks are run
+ *    with a `node` found on PATH (see hookRunner).
  *  - omp fails CLOSED at `tool_call`: a handler that throws or exceeds
  *    `extensionHandlers.toolCallTimeoutMs` (default 30000) is replaced by omp's own
  *    `{ block: true, reason: "Extension … timed out" }`. The bridge therefore keeps a
@@ -26,7 +30,7 @@
 
 import { spawn } from 'node:child_process';
 import { randomUUID } from 'node:crypto';
-import { existsSync } from 'node:fs';
+import { accessSync, constants, existsSync, realpathSync, statSync } from 'node:fs';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
 
@@ -62,6 +66,22 @@ function sessionIdFrom(ctx) {
   } catch { return null; }
 }
 
+/**
+ * Only the file paths of a tool result's details. An edit's details also carry the old and
+ * new text of every file it changed, which no hook needs on stdin.
+ */
+function resultPaths(details) {
+  if (!details || typeof details !== 'object') return {};
+  const paths = (list) => (Array.isArray(list) ? list.filter((entry) => typeof entry?.path === 'string').map((entry) => ({ path: entry.path })) : undefined);
+  const out = {};
+  if (typeof details.path === 'string') out.path = details.path;
+  const perFile = paths(details.perFileResults);
+  if (perFile) out.perFileResults = perFile;
+  const changes = paths(details.fileChanges);
+  if (changes) out.fileChanges = changes;
+  return out;
+}
+
 /** Build the Claude-shaped payload a CafeKit hook reads on stdin. */
 export function shapePayload(kind, event, ctx) {
   const entry = DISPATCH[kind];
@@ -93,7 +113,7 @@ export function shapePayload(kind, event, ctx) {
     case 'tool_result':
       payload.tool_name = event?.toolName ?? event?.tool_name ?? '';
       payload.tool_input = event?.input ?? {};
-      payload.tool_response = { content: event?.content ?? [], isError: event?.isError === true };
+      payload.tool_response = { content: event?.content ?? [], isError: event?.isError === true, details: resultPaths(event?.details) };
       payload.tool_use_id = event?.toolCallId ?? null;
       break;
     case 'session_stop':
@@ -143,12 +163,54 @@ export function interpretVerdict({ code, stdout = '', stderr = '' }, hookName) {
   return { block: Boolean(block), reason: block?.reason, inject: inject.join('\n').trim() };
 }
 
+function isInside(root, target) {
+  const rel = path.relative(root, target);
+  return rel === '' || (!rel.startsWith('..') && !path.isAbsolute(rel));
+}
+
+function realOrSelf(target) {
+  try { return realpathSync(target); } catch { return path.resolve(target); }
+}
+
+/**
+ * The executable that runs a hook. Under node that is `process.execPath`. Under Bun (omp)
+ * it is the first `node` on PATH that sits in an absolute PATH entry outside the project,
+ * so a repository cannot plant its own `node` (`.`, `node_modules/.bin`) in front of the
+ * gates. Returns `{ command }` or `{ error }`; never throws.
+ */
+export function hookRunner({ cwd = process.cwd(), env = process.env, bun = process.versions?.bun, platform = process.platform } = {}) {
+  if (!bun) return { command: process.execPath };
+  const project = realOrSelf(cwd);
+  const names = platform === 'win32'
+    ? String(env.PATHEXT || '.EXE;.CMD;.BAT;.COM').split(';').filter(Boolean).map((ext) => `node${ext.toLowerCase()}`)
+    : ['node'];
+  const delimiter = platform === 'win32' ? ';' : ':';
+  for (const dir of String(env.PATH || env.Path || '').split(delimiter)) {
+    if (!dir || !path.isAbsolute(dir)) continue;
+    for (const name of names) {
+      const candidate = path.join(dir, name);
+      try {
+        if (!statSync(candidate).isFile()) continue;
+        if (platform !== 'win32') accessSync(candidate, constants.X_OK);
+      } catch { continue; }
+      if (isInside(project, realOrSelf(candidate))) continue;
+      return { command: candidate };
+    }
+  }
+  return { error: 'node was not found on PATH outside the project' };
+}
+
 /** Run one hook as a child process with a hard budget. Never throws. */
 export function dispatchHook(hookPath, payload, { cwd, timeoutMs = BRIDGE_TIMEOUT_MS } = {}) {
   return new Promise((resolve) => {
+    const runner = hookRunner({ cwd });
+    if (runner.error) {
+      resolve({ code: null, signal: null, stdout: '', stderr: runner.error, timedOut: false, failed: true });
+      return;
+    }
     let child;
     try {
-      child = spawn(process.execPath, [hookPath], {
+      child = spawn(runner.command, [hookPath], {
         cwd,
         env: { ...process.env, PROJECT_ROOT: cwd },
         stdio: ['pipe', 'pipe', 'pipe'],
@@ -167,7 +229,7 @@ export function dispatchHook(hookPath, payload, { cwd, timeoutMs = BRIDGE_TIMEOU
     child.stdout.on('data', (c) => out.push(c));
     child.stderr.on('data', (c) => err.push(c));
     child.on('error', (error) => { clearTimeout(timer); finish({ code: null, stdout: '', stderr: String(error?.message || error), timedOut: false, failed: true }); });
-    child.on('close', (code) => { clearTimeout(timer); finish({ code, stdout: Buffer.concat(out).toString('utf8'), stderr: Buffer.concat(err).toString('utf8'), timedOut: false, failed: false }); });
+    child.on('close', (code, signal) => { clearTimeout(timer); finish({ code, signal, stdout: Buffer.concat(out).toString('utf8'), stderr: Buffer.concat(err).toString('utf8'), timedOut: false, failed: false }); });
     try { child.stdin.write(JSON.stringify(payload)); child.stdin.end(); } catch { /* close handler still runs */ }
   });
 }
@@ -206,6 +268,12 @@ export async function runEvent(kind, event, ctx, { timeoutMs = BRIDGE_TIMEOUT_MS
     }
     const verdict = interpretVerdict(result, hookName);
     if (verdict.block) return { block: true, reason: verdict.reason, hook: hookName };
+    // A gate that dies without a verdict (a broken node shim, a crash, a kill) must not
+    // read as an allow: only 0 and 2 are answers a gate gives on purpose.
+    if (gating && result.code !== 0 && result.code !== 2) {
+      const how = result.signal ? `was killed by ${result.signal}` : `exited with code ${result.code}`;
+      return { block: true, reason: `CafeKit gate ${hookName} ${how}`, hook: hookName };
+    }
     if (verdict.inject) injections.push(verdict.inject);
   }
   return { block: false, inject: injections.join('\n\n') };

package/src/omp/hooks/privacy-block.cjs

@@ -56,7 +56,8 @@ try {
   const projectRoot = resolveProjectRoot(data);
   const runtime = readRuntime(projectRoot);
 
-  if (runtime.privacyBlock === false) process.exit(0);
+  // A plugin is trusted once for every repository, so a repository cannot switch it off.
+  if (runtime.privacyBlock === false && !require('./lib/plugin-options.cjs').isPlugin()) process.exit(0);
 
   const paths = sensitivePaths(toolName, toolInput, cwd);
   if (paths.length) askForPermission(`Sensitive file access requires approval: ${displayNames(paths)}`);