@haposoft/cafekit 0.18.0 → 0.18.1

package/bin/__tests__/codex-native.test.js

@@ -182,12 +182,7 @@ const V3_SPECS_BUNDLE = [
   'SKILL.md',
   'references/review.md',
   'references/templates.md',
-  'templates/design.md',
-  'templates/requirements-init.md',
-  'templates/requirements.md',
-  'templates/research.md',
-  'templates/spec-state.json',
-  'templates/task.md'
+  'templates/research.md'
 ];
 const OBSOLETE_SPECS_FILES = [
   'references/archive-workflow.md',
@@ -272,64 +267,6 @@ function replaceGeneratedTomlString(content, key, value) {
   return content.replace(pattern, `${key} = ${JSON.stringify(value)}`);
 }
 
-function renderCanonicalVerificationExample(template) {
-  const values = new Map([
-    ['SUBJECT_REQ', '1'],
-    ['X', '1'],
-    ['PROOF_REQ', '1'],
-    ['Y', '2'],
-    ['exact command', 'node --test test/installed.test.js'],
-    ['exact anchored target', 'src/installed.js#entry'],
-    ['exact/repository/entrypoint', 'src/installed.js'],
-    ['observable result', 'the subject behavior and verifier proof both pass'],
-    ['concrete observable result and proof', 'the subject behavior and verifier proof both pass'],
-    ['concrete rejected or recovery case', 'invalid input remains rejected and observable'],
-    ['real entrypoint/caller and grounded anchor expectation', 'the installed entrypoint reaches A-D-01'],
-  ]);
-  return template.replace(/\{\{([^}]+)\}\}/g, (placeholder, name) => (
-    values.has(name) ? values.get(name) : placeholder
-  ));
-}
-
-function assertInstalledVerificationModel(grounderPath, designTemplate) {
-  const { parseVerificationDefinitions } = require(grounderPath);
-  assert.equal(typeof parseVerificationDefinitions, 'function');
-  const concreteDesign = renderCanonicalVerificationExample(designTemplate);
-  const errors = [];
-  const definitions = parseVerificationDefinitions(concreteDesign, errors);
-  assert.deepEqual(errors, []);
-  assert.equal(definitions.size, 1);
-  const definition = definitions.get('V1');
-  assert.ok(definition);
-  assert.deepEqual(definition.subject_criteria, ['R1.1']);
-  assert.deepEqual(definition.proof_criteria, []);
-  assert.equal(definition.proof_owner, null);
-  assert.equal(definition.evidence_anchor, null);
-  assert.deepEqual(definition.decision_refs, ['D1', 'I1', 'C1']);
-  for (const field of [
-    'subject_criteria', 'subject_owner', 'decision_refs', 'method', 'expected',
-    'negative', 'reachability'
-  ]) {
-    const value = definition[field];
-    assert.ok(
-      Array.isArray(value)
-        ? value.length > 0
-        : (typeof value === 'string' ? value.trim() !== '' : value && Object.keys(value).length > 0)
-    );
-  }
-  for (const mutation of [
-    concreteDesign.replace('- **V1**:', '### V1 —'),
-    concreteDesign.replace('- **V1**:', '| V1 |'),
-    concreteDesign.replace('; Expected ', '\nExpected '),
-    concreteDesign.replace('Decision refs ', 'Decisions '),
-  ]) {
-    const mutationErrors = [];
-    const mutated = parseVerificationDefinitions(mutation, mutationErrors);
-    assert.ok(mutationErrors.length > 0);
-    assert.equal(mutated.has('V1'), false);
-  }
-}
-
 function markdownSection(content, heading) {
   const lines = String(content).split('\n');
   const start = lines.findIndex((line) => line.trim() === `## ${heading}`);
@@ -2160,22 +2097,12 @@ test('Codex installed Specs and spec-maker reject adaptive coverage mutations',
       '.codex/rules/state-sync.md',
       '.codex/rules/review-audit-self-decision.md',
       '.codex/rules/process-management.md',
-      '.codex/scripts/spec-ground.cjs',
-      '.codex/scripts/validate-spec-output.cjs',
       '.agents/.gitignore',
       ...V3_SPECS_BUNDLE.map((file) => `.agents/skills/specs/${file}`)
     ]) {
       assert.equal(fs.existsSync(path.join(root, relative)), true, `missing ${relative}`);
     }
 
-    const installedDesign = fs.readFileSync(
-      path.join(root, '.agents/skills/specs/templates/design.md'), 'utf8'
-    );
-    assert.equal((installedDesign.match(/^## Verification Definitions$/gm) || []).length, 1);
-    assertInstalledVerificationModel(
-      path.join(root, '.codex/scripts/spec-ground.cjs'),
-      installedDesign
-    );
     const installedSpecsRoot = path.join(root, '.agents/skills/specs');
     assert.throws(
       () => installedAuthoringProjectionIssues(root, '.agents/skills/specs'),
@@ -2191,22 +2118,6 @@ test('Codex installed Specs and spec-maker reject adaptive coverage mutations',
     );
     assertInstalledAuthoringProjection(root, installedSpecsRoot);
 
-    const installedTask = fs.readFileSync(
-      path.join(root, '.agents/skills/specs/templates/task.md'), 'utf8'
-    );
-    assert.deepEqual(
-      [...installedTask.matchAll(/^## (.+)$/gm)].map((match) => match[1]),
-      ['Outcome', 'Scope', 'Anchors and Ownership', 'Changes', 'Acceptance', 'Dependencies', 'Verification Plan']
-    );
-    assert.match(installedTask, /^- \*\*Task role:\*\*/m);
-
-    const installedState = JSON.parse(fs.readFileSync(
-      path.join(root, '.agents/skills/specs/templates/spec-state.json'), 'utf8'
-    ));
-    assert.deepEqual(Object.keys(installedState.workflow_policy).sort(), [
-      'assurance_level', 'classified_minimum', 'planning_depth', 'risks', 'version'
-    ]);
-
     const agentsGitignore = fs.readFileSync(
       path.join(root, '.agents', '.gitignore'),
       'utf8'
@@ -2217,7 +2128,6 @@ test('Codex installed Specs and spec-maker reject adaptive coverage mutations',
 
     if (process.platform !== 'win32') {
       for (const [sourceRelative, installedRelative] of [
-        ['src/claude/scripts/validate-spec-output.cjs', '.codex/scripts/validate-spec-output.cjs'],
         ['src/claude/skills/chrome-devtools/scripts/install.sh', '.agents/skills/chrome-devtools/scripts/install.sh'],
         ['src/claude/skills/ai-multimodal/scripts/check_setup.py', '.agents/skills/ai-multimodal/scripts/check_setup.py']
       ]) {
@@ -2338,7 +2248,7 @@ test('Codex installed Specs and spec-maker reject adaptive coverage mutations',
     const questionSkill = path.join(root, '.agents', 'skills', 'ask', 'SKILL.md');
     fs.appendFileSync(questionSkill, '\nUSER-CODEX-SENTINEL\n');
     // Fresh installs are exact. Refresh/upgrade intentionally documents the
-    // current Codex limitation: removed skill paths are not pruned.
+    // A skill file the manifest lists as obsolete is removed on refresh; edited skills stay.
     const obsoleteSpecsRule = path.join(
       root, '.agents', 'skills', 'specs', 'rules', 'design-principles.md'
     );
@@ -2351,14 +2261,15 @@ test('Codex installed Specs and spec-maker reject adaptive coverage mutations',
     assert.match(fs.readFileSync(questionSkill, 'utf8'), /USER-CODEX-SENTINEL/);
     assert.equal(
       fs.existsSync(obsoleteSpecsRule),
-      true,
-      'known limitation: Codex refresh does not prune obsolete skill files'
+      false,
+      'Codex refresh removes obsolete skill files'
     );
 
     const metadataPath = path.join(root, '.codex', 'cafekit.json');
     const metadata = JSON.parse(fs.readFileSync(metadataPath, 'utf8'));
     metadata.version = '0.14.1';
     fs.writeFileSync(metadataPath, `${JSON.stringify(metadata, null, 2)}\n`);
+    fs.writeFileSync(obsoleteSpecsRule, 'LEGACY-CODEX-ORPHAN\n');
 
     const upgrade = install(root);
     assert.equal(upgrade.status, 0, `${upgrade.stdout}\n${upgrade.stderr}`);
@@ -2366,8 +2277,8 @@ test('Codex installed Specs and spec-maker reject adaptive coverage mutations',
     assert.match(fs.readFileSync(questionSkill, 'utf8'), /USER-CODEX-SENTINEL/);
     assert.equal(
       fs.existsSync(obsoleteSpecsRule),
-      true,
-      'known limitation: Codex upgrade does not prune obsolete skill files'
+      false,
+      'Codex upgrade removes obsolete skill files'
     );
     assert.ok(fs.readFileSync(path.join(root, 'AGENTS.md'), 'utf8').startsWith(userInstructions));
 
@@ -3136,8 +3047,6 @@ test('Codex install on top of existing Claude installation preserves content and
     assert.equal(fs.existsSync(path.join(root, '.codex', 'runtime.json')), true, '.codex/runtime.json should exist');
     assert.equal(fs.existsSync(path.join(root, '.codex', 'hooks', 'privacy-block.cjs')), true, '.codex/hooks/privacy-block.cjs should exist');
     assert.equal(fs.existsSync(path.join(root, '.codex', 'rules', 'workflow.md')), true, '.codex/rules/workflow.md should exist');
-    assert.equal(fs.existsSync(path.join(root, '.codex', 'scripts', 'spec-ground.cjs')), true, '.codex/scripts/spec-ground.cjs should exist');
-    assert.equal(fs.existsSync(path.join(root, '.codex', 'scripts', 'validate-spec-output.cjs')), true, '.codex/scripts/validate-spec-output.cjs should exist');
     assert.equal(fs.existsSync(path.join(root, '.agents', '.gitignore')), true, '.agents/.gitignore should exist');
     assert.equal(fs.existsSync(path.join(root, '.agents', 'skills', 'specs', 'SKILL.md')), true, '.agents/skills/specs/SKILL.md should exist');
 
@@ -3170,23 +3079,54 @@ test('Codex installed code_auditor carries no Strict attestation marker', () =>
   });
 });
 
-test('Codex scaffold resolver rejects symlink template', () => {
+test('reinstall removes obsolete scripts and skill files from Codex and omp installs', () => {
   inTempProject((root) => {
-    const result = install(root);
-    assert.equal(result.status, 0);
-    const template = path.join(root, '.agents', 'skills', 'specs', 'templates', 'task.md');
-    const target = path.join(root, 'outside.md');
-    fs.writeFileSync(target, 'evil');
-    const original = fs.readFileSync(template);
-    fs.unlinkSync(template);
-    fs.symlinkSync(target, template);
-    const scaffold = path.join(root, '.codex', 'scripts', 'spec-scaffold.cjs');
-    const out = spawnSync(process.execPath, [scaffold, 'symlink-test', '--tasks', 'R1-01-foo,R1-02-bar', '--boundaries', '[{"id":"B-OWN","type":"ownership","tasks":["R1-01","R1-02"],"write_sets":{"R1-01":["src/a.js"],"R1-02":["src/b.js"]}}]'], { cwd: root, encoding: 'utf8' });
-    // Should fail because template is symlink and resolver rejects it
-    assert.notEqual(out.status, 0, 'scaffold should reject symlink template');
-    assert.match(`${out.stdout}\n${out.stderr}`, /template not found|symlink/i);
-    fs.unlinkSync(template);
-    fs.writeFileSync(template, original);
+    const first = installPlatforms(root, ['codex', 'omp']);
+    assert.equal(first.status, 0, `${first.stdout}\n${first.stderr}`);
+    const retired = ['change-firewall.cjs', 'spec-final-state.cjs'];
+    for (const runtime of ['.codex', '.omp']) {
+      for (const name of retired) fs.writeFileSync(path.join(root, runtime, 'scripts', name), 'legacy\n');
+    }
+    const retiredSkillFiles = ['code-review/references/verification-gate.md', 'specs/references/archive-workflow.md'];
+    for (const rel of retiredSkillFiles) fs.writeFileSync(path.join(root, '.agents', 'skills', rel), 'legacy\n');
+    const again = installPlatforms(root, ['codex', 'omp'], ['--force-overwrite']);
+    assert.equal(again.status, 0, `${again.stdout}\n${again.stderr}`);
+    for (const rel of retiredSkillFiles) {
+      assert.equal(fs.existsSync(path.join(root, '.agents', 'skills', rel)), false, `.agents/skills/${rel} must be removed`);
+    }
+    assert.equal(fs.existsSync(path.join(root, '.agents', 'skills', 'code-review', 'SKILL.md')), true, 'the code-review skill stays');
+    for (const runtime of ['.codex', '.omp']) {
+      for (const name of retired) {
+        assert.equal(fs.existsSync(path.join(root, runtime, 'scripts', name)), false, `${runtime}/scripts/${name} must be removed`);
+      }
+      assert.equal(fs.existsSync(path.join(root, runtime, 'scripts', 'spec-resolver.cjs')), true, `${runtime} keeps the resolver`);
+    }
+  });
+});
+
+test('reinstall removes the retired spec.json templates from Claude and Codex but a dry run keeps them', () => {
+  inTempProject((root) => {
+    const first = installPlatforms(root, ['claude', 'codex']);
+    assert.equal(first.status, 0, `${first.stdout}\n${first.stderr}`);
+    const templateDirs = ['.claude/skills/specs/templates', '.agents/skills/specs/templates'];
+    const retired = ['design.md', 'task.md', 'requirements.md', 'requirements-init.md', 'spec-state.json'];
+    for (const dir of templateDirs) {
+      for (const name of retired) fs.writeFileSync(path.join(root, dir, name), 'legacy\n');
+    }
+
+    const dry = installPlatforms(root, ['claude', 'codex'], ['--force-overwrite', '--dry-run']);
+    assert.equal(dry.status, 0, `${dry.stdout}\n${dry.stderr}`);
+    for (const dir of templateDirs) {
+      for (const name of retired) {
+        assert.equal(fs.existsSync(path.join(root, dir, name)), true, `dry run removed ${dir}/${name}`);
+      }
+    }
+
+    const again = installPlatforms(root, ['claude', 'codex'], ['--force-overwrite']);
+    assert.equal(again.status, 0, `${again.stdout}\n${again.stderr}`);
+    for (const dir of templateDirs) {
+      assert.deepEqual(fs.readdirSync(path.join(root, dir)), ['research.md'], `${dir} keeps only research.md`);
+    }
   });
 });