@hanzlaa/rcode 4.14.0 → 4.15.1

package/cli/install.js

@@ -723,9 +723,17 @@ function getPathsForIde(ide, target) {
       // claude/vscode install paths). We install agent + command files to .claude/
       // so multi-IDE installs share files, and the rcode workflow bridge gives
       // Codex access to lifecycle workflows via `rcode workflow show <name>` (#883).
-      // NOTE: Codex surfaces native /slash commands ONLY from ~/.codex/prompts/*.md
-      // (home, startup-loaded) — installed separately by installNativeHomeSlashCommands()
-      // under the opt-in --global flag, since .claude/commands is invisible to Codex.
+      //
+      // What Codex actually reads — verified live against Codex CLI 0.150.1:
+      //   AGENTS.md              → project instructions  ✅ written here
+      //   ~/.codex/prompts/*.md  → /slash commands       (--global only)
+      //   ~/.codex/skills/<n>/   → skills                (--global only)
+      //   (no agents surface)    → Codex has NO subagent concept at all
+      //
+      // The agentsDir below is therefore written for MULTI-IDE SHARING ONLY.
+      // Codex itself never reads it, and rcode's agents cannot appear in Codex
+      // in any form — not a bug to fix, an absent surface. Skills are the only
+      // place rcode's capabilities can surface there.
       return {
         agentsDir: path.join(target, '.claude', 'agents'),
         commandsDir: path.join(target, '.claude', 'commands'),
@@ -994,6 +1002,10 @@ function ensureRcodeGitignore(target, options = {}) {
     '.rcode/brain/rcode-docs/',
     '.rcode/brain/best-practices/',
     '',
+    '# Personal customization layer — team overrides (.rcode/custom/<name>.md)',
+    '# ARE committed; the .user.md layer is per-developer and is not.',
+    '.rcode/custom/*.user.md',
+    '',
     '# Runtime noise',
     'node_modules/',
     '.rcode/state.json.lock',
@@ -1361,12 +1373,29 @@ function installSkills(packageRoot, target, options = {}) {
   let skippedGlobal = 0;
 
   const _internalSkillCache = new Map();
+  // `user-invocable: true` WINS over `internal: true`.
+  //
+  // These two flags contradict each other and 36 of the 38 internal skills
+  // declared both. The installer read only `internal`, so every one of those
+  // skills went to .rcode/skills/ instead of .claude/skills/ — which means the
+  // model never saw their descriptions and they could never auto-activate. They
+  // worked only if the user typed the exact slash command.
+  //
+  // That is how "review this PR <url>" reached the built-in code-review skill
+  // instead of rcode's: rcode's reviewer was invisible, not out-competed.
+  //
+  // A skill that declares user-invocable, writes its description for activation
+  // ("Activates when the user says..."), and lists trigger phrases is user-facing
+  // by every signal it gives. `internal` is for genuine utility libraries that
+  // other skills call — and those do not claim to be user-invocable.
   function isInternalSkill(skillDir) {
     if (_internalSkillCache.has(skillDir)) return _internalSkillCache.get(skillDir);
     const skillMd = path.join(skillDir, 'SKILL.md');
     if (!fs.existsSync(skillMd)) { _internalSkillCache.set(skillDir, false); return false; }
     const text = fs.readFileSync(skillMd, 'utf8');
-    const result = /^internal:\s*true\s*$/m.test(text);
+    const internal = /^internal:\s*true\s*$/m.test(text);
+    const userInvocable = /^user-invocable:\s*true\s*$/m.test(text);
+    const result = internal && !userInvocable;
     _internalSkillCache.set(skillDir, result);
     return result;
   }
@@ -1558,6 +1587,20 @@ function buildInstallPlan(ide = 'claude', target = process.cwd()) {
     plan.push({ src: f, rel: path.join('.rcode', 'data', rel) });
   }
 
+  // .rcode/templates/ — every template, not just the starter projects.
+  //
+  // Only `templates/projects/` was ever copied, so a fresh install had NO
+  // .md templates at all while workflows went on reading them:
+  // plan-research-validation.md and validate-phase.md both read
+  // `.rcode/templates/VALIDATION.md`, which never existed. Any templates found
+  // in an older project were leftovers from a version that did copy them, which
+  // is why this stayed invisible — it only broke on FRESH installs.
+  for (const f of walkFiles(path.join(SOURCE_ROOT, 'templates'))) {
+    const rel = path.relative(path.join(SOURCE_ROOT, 'templates'), f);
+    if (rel.startsWith('projects' + path.sep) || rel === 'projects') continue; // handled below
+    plan.push({ src: f, rel: path.join('.rcode', 'templates', rel) });
+  }
+
   // .rcode/templates/projects/  — starter templates consumed by /rcode-from-template
   const projectTemplatesSrc = path.join(SOURCE_ROOT, 'templates', 'projects');
   const relProjectTemplates = path.relative(target, path.join(target, '.rcode', 'templates', 'projects'));
@@ -2272,6 +2315,50 @@ function mergeSlashRouterHook(jsonPath, eventKey, command, label) {
   return true;
 }
 
+// Codex reads SKILLS from ~/.codex/skills/<name>/SKILL.md — verified live against
+// Codex CLI 0.150.1, which prints the paths it loads on boot and lists them under
+// `/skills`. Entries there are commonly symlinks into a shared ~/.agents/skills.
+//
+// This is a DIFFERENT surface from ~/.codex/prompts (slash commands) and from
+// AGENTS.md (instructions), and rcode targeted neither of the first two for
+// skills — so none of rcode's skills appeared in Codex at all. Codex has no
+// subagent concept, so rcode's agents cannot surface there in any form; skills
+// are the only place its capabilities can show up.
+function installCodexSkills(opts) {
+  const home = homedir();
+  const destRoot = path.join(home, '.codex', 'skills');
+  ensureDir(destRoot);
+
+  // Source: every SKILL.md under rcode/skills/, installed as rcode-<name>/ to
+  // stay inside rcode's namespace and never collide with a user's own skills.
+  const srcRoot = path.join(SOURCE_ROOT, 'skills');
+  if (!fs.existsSync(srcRoot)) return 0;
+
+  let written = 0;
+  for (const skillFile of walkFiles(srcRoot)) {
+    if (path.basename(skillFile) !== 'SKILL.md') continue;
+    const skillDir = path.dirname(skillFile);
+    const bare = path.basename(skillDir);
+    const name = bare.startsWith('rcode-') ? bare : `rcode-${bare}`;
+    const destDir = path.join(destRoot, name);
+    ensureDir(destDir);
+    // Copy the whole skill folder — references/, steps/, templates/ and the
+    // like are part of the contract, not decoration.
+    for (const f of walkFiles(skillDir)) {
+      const rel = path.relative(skillDir, f);
+      const out = path.join(destDir, rel);
+      ensureDir(path.dirname(out));
+      fs.copyFileSync(f, out);
+    }
+    written++;
+  }
+
+  if (opts && opts.global !== 'silent') {
+    console.log('  ' + ok(`Codex skills: ${written} → ~/.codex/skills/rcode-*/`));
+  }
+  return written;
+}
+
 // Codex: ~/.codex/hooks.json, event UserPromptSubmit.
 function installCodexSlashRouterHook(opts) {
   installSlashRouterCommands(opts);
@@ -2291,7 +2378,7 @@ function installNativeHomeSlashCommands(opts) {
   const ides = Array.isArray(opts.ides) ? opts.ides : [opts.ide].filter(Boolean);
   for (const ide of ides) {
     switch (ide) {
-      case 'codex': installCodexSlashRouterHook(opts); break;
+      case 'codex': installCodexSlashRouterHook(opts); installCodexSkills(opts); break;
       case 'antigravity': installAntigravitySlashRouterHook(opts); break;
       default:
         break;
@@ -2378,7 +2465,7 @@ async function installInner(opts) {
     // writes on a GLOBAL install. A project-local install silently leaves Codex
     // with no working slash commands — warn instead of implying success.
     if (!opts.global) {
-      console.log('  ' + warn('Codex /rcode-* slash commands need a GLOBAL install — re-run with `--global` to wire the ~/.codex/hooks.json router. This project-local install does NOT enable them.'));
+      console.log('  ' + warn('Codex needs a GLOBAL install — re-run with `--global` to wire the ~/.codex/hooks.json router AND copy rcode skills to ~/.codex/skills/. This project-local install enables NEITHER: Codex reads slash commands and skills only from its home dir, and has no agents surface at all.'));
     }
   }
 

package/cli/uninstall.js

@@ -791,6 +791,19 @@ async function runUninstall(args) {
   if (editors.includes('codex')) {
     const r = removeSlashRouterHook(path.join(os.homedir(), '.codex', 'hooks.json'), 'UserPromptSubmit');
     if (r === 'removed') console.log(`   ✓ removed rcode slash-router hook from ~/.codex/hooks.json`);
+    // Skills installed to ~/.codex/skills/rcode-*/ by installCodexSkills().
+    // Only rcode-prefixed entries — the user's own skills and their symlinks
+    // into ~/.agents/skills live in the same directory and are not ours.
+    const codexSkills = path.join(os.homedir(), '.codex', 'skills');
+    let removedSkills = 0;
+    try {
+      for (const entry of fs.readdirSync(codexSkills)) {
+        if (!entry.startsWith('rcode-')) continue;
+        fs.rmSync(path.join(codexSkills, entry), { recursive: true, force: true });
+        removedSkills++;
+      }
+    } catch { /* directory absent — nothing installed */ }
+    if (removedSkills > 0) console.log(`   ✓ removed ${removedSkills} rcode skill(s) from ~/.codex/skills/`);
   }
   if (editors.includes('antigravity')) {
     const r = removeSlashRouterHook(path.join(os.homedir(), '.gemini', 'antigravity', 'settings.json'), 'UserPrompt');