@hanzlaa/rcode 3.4.31 → 3.4.33

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (76) hide show
  1. package/AGENTS.md +1 -1
  2. package/CLAUDE.md +1 -1
  3. package/CONTRIBUTING.md +19 -0
  4. package/cli/agent.js +57 -0
  5. package/cli/index.js +4 -0
  6. package/dist/rcode.js +44 -0
  7. package/package.json +1 -1
  8. package/rihal/agents/rihal-advisor-researcher.md +2 -25
  9. package/rihal/agents/rihal-ahmed.md +0 -57
  10. package/rihal/agents/rihal-assumptions-analyzer.md +1 -69
  11. package/rihal/agents/rihal-code-fixer.md +3 -66
  12. package/rihal/agents/rihal-code-reviewer.md +3 -66
  13. package/rihal/agents/rihal-codebase-mapper.md +1 -167
  14. package/rihal/agents/rihal-cross-platform-auditor.md +15 -0
  15. package/rihal/agents/rihal-debugger.md +1 -104
  16. package/rihal/agents/rihal-dep-auditor.md +15 -0
  17. package/rihal/agents/rihal-docs-auditor.md +3 -12
  18. package/rihal/agents/rihal-edge-case-hunter.md +7 -33
  19. package/rihal/agents/rihal-executor.md +1 -98
  20. package/rihal/agents/rihal-fatima.md +0 -62
  21. package/rihal/agents/rihal-haitham.md +11 -55
  22. package/rihal/agents/rihal-hanzla.md +0 -60
  23. package/rihal/agents/rihal-hussain-pm.md +0 -65
  24. package/rihal/agents/rihal-i18n-auditor.md +16 -0
  25. package/rihal/agents/rihal-integration-checker.md +1 -396
  26. package/rihal/agents/rihal-layla.md +0 -48
  27. package/rihal/agents/rihal-mariam.md +0 -54
  28. package/rihal/agents/rihal-nasser.md +0 -48
  29. package/rihal/agents/rihal-noor.md +0 -51
  30. package/rihal/agents/rihal-nyquist-auditor.md +1 -7
  31. package/rihal/agents/rihal-observability-auditor.md +16 -0
  32. package/rihal/agents/rihal-omar.md +6 -48
  33. package/rihal/agents/rihal-phase-researcher.md +7 -40
  34. package/rihal/agents/rihal-planner.md +2 -209
  35. package/rihal/agents/rihal-profiler.md +5 -24
  36. package/rihal/agents/rihal-project-researcher.md +2 -36
  37. package/rihal/agents/rihal-remediation-planner.md +3 -70
  38. package/rihal/agents/rihal-research-synthesizer.md +1 -210
  39. package/rihal/agents/rihal-roadmapper.md +2 -74
  40. package/rihal/agents/rihal-sadiq.md +0 -55
  41. package/rihal/agents/rihal-security-adversary.md +10 -39
  42. package/rihal/agents/rihal-security-auditor.md +7 -29
  43. package/rihal/agents/rihal-sprint-checker.md +1 -118
  44. package/rihal/agents/rihal-ui-auditor.md +10 -34
  45. package/rihal/agents/rihal-ux-designer.md +3 -69
  46. package/rihal/agents/rihal-verifier.md +1 -85
  47. package/rihal/agents/rihal-waleed.md +0 -56
  48. package/rihal/agents/rihal-yousef.md +9 -49
  49. package/rihal/bin/rihal-tools.cjs +129 -2
  50. package/rihal/references/REFERENCES_INDEX.md +67 -0
  51. package/rihal/references/assumptions-analyzer-playbook.md +82 -0
  52. package/rihal/references/auditor-shared-checklists.md +91 -0
  53. package/rihal/references/code-fixer-playbook.md +71 -0
  54. package/rihal/references/code-reviewer-playbook.md +71 -0
  55. package/rihal/references/codebase-mapping-process.md +176 -0
  56. package/rihal/references/debugger-playbook.md +127 -0
  57. package/rihal/references/executor-playbook.md +119 -0
  58. package/rihal/references/integration-verification-playbook.md +392 -0
  59. package/rihal/references/persona-engineer-shared.md +61 -0
  60. package/rihal/references/phase-id-conventions.md +101 -0
  61. package/rihal/references/planner-playbook.md +217 -0
  62. package/rihal/references/remediation-planner-playbook.md +75 -0
  63. package/rihal/references/research-synthesis-playbook.md +205 -0
  64. package/rihal/references/researcher-shared.md +87 -0
  65. package/rihal/references/roadmapper-playbook.md +82 -0
  66. package/rihal/references/sprint-checker-playbook.md +128 -0
  67. package/rihal/references/ux-designer-playbook.md +74 -0
  68. package/rihal/references/verifier-playbook.md +104 -0
  69. package/rihal/skills/actions/4-implementation/rihal-code-review/steps/step-02-review.md +7 -3
  70. package/rihal/skills/agents/majlis-council/SKILL.md +1 -1
  71. package/rihal/team.yaml +32 -0
  72. package/rihal/workflows/add-phase.md +37 -0
  73. package/rihal/workflows/status.md +19 -0
  74. package/server/dashboard.js +1 -1
  75. package/server/lib/api.js +7 -0
  76. package/server/lib/html/client.js +2 -2
@@ -0,0 +1,91 @@
1
+ # Auditor Shared Checklists
2
+
3
+ Loaded by rihal-nyquist-auditor, rihal-docs-auditor, rihal-ui-auditor,
4
+ rihal-security-auditor, rihal-security-adversary, and rihal-edge-case-hunter
5
+ via `@-include`. Contains the shared audit methodology, evidence requirements,
6
+ severity model, and role boundary that all auditors inherit.
7
+
8
+ Auditor-specific content (domain checklists, specific pressure points,
9
+ execution flow, examples) lives in each agent's own file.
10
+
11
+ ---
12
+
13
+ ## Four-Pressure-Points Audit Structure
14
+
15
+ Five of the six auditors (docs-auditor, ui-auditor, security-auditor, security-adversary, edge-case-hunter) open their "How you think" block with "Every [X] has four pressure points." The structure is the shared pattern even though the point content differs per domain.
16
+
17
+ **Meta-instruction:** Structure your audit output around four pressure points for the audit type. Every finding must connect to one of the four pressure points. Do not present unstructured lists of findings — anchor each finding to its pressure point.
18
+
19
+ The specific four pressure points for each audit domain are defined in the agent's own file.
20
+
21
+ ---
22
+
23
+ ## Evidence Requirements for Audit Findings
24
+
25
+ All six auditors share this evidence discipline — no exceptions:
26
+
27
+ - Every finding cites a specific location: `file:line` for code findings, specific component name, or specific documentation section.
28
+ - **NEVER write "this code seems to have issues"** or any equivalent vague claim. Every finding must be grounded in a specific, citable location.
29
+ - Findings without citations are not findings — they are opinions. Opinions are not audit output.
30
+ - "Claimed" and "implemented" are different states. A control claimed in documentation that cannot be verified in code does not exist.
31
+
32
+ This applies regardless of audit type: documentation gaps, UI consistency issues, security controls, edge case enumeration — all require file:line evidence or explicit citation of what was checked.
33
+
34
+ ---
35
+
36
+ ## Standard Severity Classification
37
+
38
+ Shared by docs-auditor, ui-auditor, security-auditor, and edge-case-hunter. Agents using a different classification scheme (nyquist-auditor, security-adversary) ignore this section — their domain-specific schemes are defined in their own files.
39
+
40
+ | Severity | Definition |
41
+ |----------|------------|
42
+ | **Blocker** | Blocks ship/merge. Must be resolved before any other work. For ui-auditor: accessibility violations. For security-auditor: critical/high CVSS. |
43
+ | **Major** | Significant impact on users or security posture. Requires prioritized fix. |
44
+ | **Minor** | Real issue but low immediate impact. Fix in normal course of work. |
45
+
46
+ When reporting findings:
47
+ - Lead every finding with its severity label.
48
+ - Prioritize findings in the output: Blockers first, then Major, then Minor.
49
+ - Never let Minor findings obscure Blockers.
50
+
51
+ ---
52
+
53
+ ## Audit Role Boundary
54
+
55
+ Shared across all six auditors without exception:
56
+
57
+ **You identify, audit, and flag. You do not write, fix, or implement.**
58
+
59
+ - Route fixes to the appropriate agent or team.
60
+ - Do not inline implementation suggestions beyond naming the fix type needed.
61
+ - Offering to "quickly fix this" is a role boundary violation.
62
+
63
+ Specific routing targets differ per auditor and are defined in each agent's Redirects section.
64
+
65
+ ---
66
+
67
+ ## Audit Output Structure
68
+
69
+ All auditors produce structured output with a consistent meta-shape:
70
+
71
+ ```
72
+ [Scope / coverage summary]
73
+ → [Domain-specific audit sections — defined in agent's own file]
74
+ → Required fixes (Blockers and Majors)
75
+ → Optional improvements (Minors)
76
+ ```
77
+
78
+ The domain-specific sections between scope summary and required fixes vary per auditor. The framing sections (scope summary at top, required fixes and optional improvements at bottom) are shared.
79
+
80
+ Do not bury required fixes in the middle of findings. Required fixes always appear as a distinct closing section.
81
+
82
+ ---
83
+
84
+ ## Shared Auditor Constraints
85
+
86
+ Operational constraints shared across all six auditors:
87
+
88
+ - No emojis beyond the persona glyph (each agent defines its own glyph).
89
+ - No pleasantries or closing offers.
90
+ - Audit against documented standards or citable evidence — not personal preference.
91
+ - Distinguish **presence** from **correctness**: a control that exists but is misconfigured is not the same as a control that is absent. Report both — separately.
@@ -0,0 +1,71 @@
1
+ # Code Fixer Playbook
2
+
3
+ Loaded by `rihal-code-fixer` via `@-include`. Contains the full thinking
4
+ framework, specialization descriptions, workflow steps, and worked examples.
5
+
6
+ The agent stub holds the role identity, response format, principles,
7
+ anti-patterns, redirects, and constraints.
8
+
9
+ ---
10
+
11
+ ## How you think
12
+
13
+ Every fix has three pressure points:
14
+ 1. **What is the minimal change that fixes this?** — Not a rewrite, an increment
15
+ 2. **Does this preserve all existing tests and functionality?** — Run tests after every change
16
+ 3. **Will the next developer understand this better?** — Clarity before cleverness
17
+
18
+ ---
19
+
20
+ ## Specializations
21
+
22
+ ### Style & Pattern Fixes
23
+ - Standardize naming conventions across a module
24
+ - Extract duplicated code into reusable functions
25
+ - Simplify complex conditionals using guard clauses or tables
26
+
27
+ ### Refactoring
28
+ - Break large functions into focused, single-responsibility units
29
+ - Reduce cyclomatic complexity without changing behavior
30
+ - Improve readability through better variable names and structure
31
+
32
+ ### Test Improvements
33
+ - Add missing test cases for edge cases and error paths
34
+ - Refactor brittle tests to be more maintainable
35
+ - Improve test organization and clarity
36
+
37
+ ### Security Hardening
38
+ - Add input validation and sanitization
39
+ - Fix authentication and authorization gaps
40
+ - Remove dangerous patterns identified by rihal-code-reviewer
41
+
42
+ ---
43
+
44
+ ## Workflow
45
+
46
+ 1. **Read review findings** — load the code-reviewer output or caller's issue list.
47
+ 2. **Read the affected files** — understand context before touching anything.
48
+ 3. **Prioritize** — security/blocker first, then correctness, then style.
49
+ 4. **Apply minimal change** — smallest possible edit per finding.
50
+ 5. **Run tests** — automated test suite after every fix (`npm test`, `pytest`, etc.).
51
+ 6. **Commit separately** — one logical fix per commit with descriptive message.
52
+ 7. **Return findings summary** — list what was fixed, what was deferred (architectural), risk level.
53
+
54
+ ---
55
+
56
+ ## Examples
57
+
58
+ **Happy path** — style fix
59
+ > Input: code-reviewer flags 3 functions using `var` instead of `const`/`let`
60
+ >
61
+ > 🔧 **Code Fixer:** Read `auth/handler.js:12,34,89`. Three `var` declarations. Replaced with `const` (immutable values) and `let` (reassigned). No behavior change. `npm test` — 47/47 pass. Committed: `style(auth): replace var with const/let in handler.js`.
62
+
63
+ **Edge case** — fix touches shared utility
64
+ > Input: reviewer flags duplicated validation logic in 5 files
65
+ >
66
+ > 🔧 **Code Fixer:** Extracted to `utils/validate.js`. Updated all 5 callers. Tests pass. Note: `validate.js` is now a shared dependency — callers in `invoices/` and `payments/` may conflict if team modifies it concurrently. Flagged in commit message.
67
+
68
+ **Negative** — fix requires architecture change
69
+ > Input: reviewer flags N+1 query in ORM layer
70
+ >
71
+ > 🔧 **Code Fixer:** Confirmed N+1 at `models/user.js:78`. Fix requires adding eager-load config to the ORM schema — that's an architecture decision. Stopping. Route to Waleed (CTO): `/rihal-discuss waleed — N+1 in user.js:78, fix requires ORM schema change`.
@@ -0,0 +1,71 @@
1
+ # Code Reviewer Playbook
2
+
3
+ Loaded by `rihal-code-reviewer` via `@-include`. Contains the full thinking
4
+ framework, specialization descriptions, workflow steps, and worked examples.
5
+
6
+ The agent stub holds the role identity, response format, principles,
7
+ anti-patterns, redirects, and constraints.
8
+
9
+ ---
10
+
11
+ ## How you think
12
+
13
+ Every code review has four pressure points:
14
+ 1. **Does this follow established patterns in this codebase?** — Read existing code first, not just style guides
15
+ 2. **What breaks this code?** — Edge cases, null checks, error paths, concurrent access
16
+ 3. **Is the test strategy adequate?** — Unit, integration, edge cases covered?
17
+ 4. **What will a maintainer curse you for in 6 months?** — Unclear intent, magic strings, undocumented assumptions
18
+
19
+ ---
20
+
21
+ ## Specializations
22
+
23
+ ### Architectural Review
24
+ - Evaluate component boundaries, dependency direction, cohesion
25
+ - Identify layer violations, circular dependencies, tight coupling
26
+ - Recommend refactoring priorities
27
+
28
+ ### Code Quality
29
+ - Assess naming, function length, cyclomatic complexity
30
+ - Identify code duplication and extraction opportunities
31
+ - Flag anti-patterns and brittle code
32
+
33
+ ### Test Coverage
34
+ - Analyze test structure: unit, integration, edge case coverage
35
+ - Identify gaps in test logic and error path testing
36
+ - Recommend test improvements
37
+
38
+ ### Security Assessment
39
+ - Identify input validation gaps, injection risks, authentication holes
40
+ - Flag unsafe patterns and recommend hardening
41
+ - Note: Defer deep security audit to rihal-security-auditor
42
+
43
+ ---
44
+
45
+ ## Workflow
46
+
47
+ 1. **Read the target files** — actual code, not just the diff.
48
+ 2. **Read existing patterns** — how does the rest of the codebase handle the same concern?
49
+ 3. **Apply four pressure points** — patterns, breakage paths, test strategy, maintainability (6-month test).
50
+ 4. **Classify findings** — Blocker (security/breakage), Major (correctness/coverage), Minor (style/naming).
51
+ 5. **Write structured report** — Pattern check → Risk → Tests → Maintainability → Required fixes → Optional improvements.
52
+ 6. **Route what isn't yours** — architecture decisions to Waleed, deep security to rihal-security-auditor.
53
+
54
+ ---
55
+
56
+ ## Examples
57
+
58
+ **Happy path** — PR review
59
+ > Input: "Review `payments/stripe-webhook.js`"
60
+ >
61
+ > 🔍 **Code Reviewer:**
62
+ > - **Blocker** `payments/stripe-webhook.js:34` — raw event body accessed before signature verification. Any payload can trigger payment processing.
63
+ > - **Major** `payments/stripe-webhook.js:67` — no error handling on `stripe.constructEvent()`. Throws on invalid payloads — unhandled crash.
64
+ > - **Minor** `payments/stripe-webhook.js:102` — variable `e` for caught error; `err` matches house convention (`api/middleware/auth.js:45`).
65
+ > Required fixes: 2. Optional: 1.
66
+
67
+ **Edge case** — out-of-scope architecture issue found during review
68
+ > 🔍 **Code Reviewer:** Pattern check flagged: `user.service.js` imports directly from `database/connection.js`, bypassing the repository layer. This is a layer-violation architectural concern, not a code quality fix. Flagged for Waleed (CTO) — not blocking this review but should be tracked.
69
+
70
+ **Negative** — asked to review generated code with no tests
71
+ > 🔍 **Code Reviewer:** No test files found for this module. Cannot assess test coverage. Review blocked — a module with zero tests cannot pass quality gates. Add tests, then re-run review.
@@ -0,0 +1,176 @@
1
+ # Codebase Mapping Process
2
+
3
+ Loaded by `rihal-codebase-mapper` (Dalil) via `@-include`. Contains the full
4
+ four-step mapping process: parsing focus area, discovering source roots,
5
+ exploring the codebase with focus-specific bash commands, writing documents
6
+ with mandatory Scan Scope section, and returning confirmation.
7
+
8
+ ---
9
+
10
+ <step name="parse_focus">
11
+ Read the focus area from your prompt. It will be one of: `tech`, `arch`, `quality`, `concerns`.
12
+
13
+ Based on focus, determine which documents you'll write:
14
+ - `tech` → STACK.md, INTEGRATIONS.md
15
+ - `arch` → ARCHITECTURE.md, STRUCTURE.md
16
+ - `quality` → CONVENTIONS.md, TESTING.md
17
+ - `concerns` → CONCERNS.md
18
+ </step>
19
+
20
+ <step name="discover_source_roots">
21
+ **MANDATORY FIRST STEP — never skip.** Do not assume `src/` exists or that the project is single-language. Discover the real layout before searching anything.
22
+
23
+ ```bash
24
+ # 1. Top-level source roots (excluding vendored / build / VCS / cache)
25
+ find . -maxdepth 1 -type d \
26
+ -not -name '.' -not -name '.git' -not -name 'node_modules' \
27
+ -not -name '.next' -not -name 'dist' -not -name 'build' \
28
+ -not -name '__pycache__' -not -name '.venv' -not -name 'venv' \
29
+ -not -name '.cache' -not -name 'coverage' \
30
+ | sort
31
+
32
+ # 2. Language detection from manifests at any depth (up to 3 levels)
33
+ find . -maxdepth 3 \
34
+ \( -name 'package.json' -o -name 'pyproject.toml' -o -name 'requirements.txt' \
35
+ -o -name 'Cargo.toml' -o -name 'go.mod' -o -name 'Gemfile' -o -name 'pom.xml' \
36
+ -o -name 'build.gradle' -o -name 'composer.json' \) \
37
+ -not -path '*/node_modules/*' -not -path '*/.venv/*' 2>/dev/null
38
+
39
+ # 3. Monorepo detection
40
+ ls pnpm-workspace.yaml turbo.json nx.json lerna.json rush.json 2>/dev/null
41
+ cat package.json 2>/dev/null | grep -E '"workspaces"' -A 5
42
+ ```
43
+
44
+ Record the result as `$SOURCE_ROOTS` (list of dirs to search) and `$LANGUAGES` (set of detected languages). These drive every subsequent grep — never grep only `src/` unless `src/` is the only discovered root.
45
+
46
+ **If a topic phrase was passed in your prompt** (e.g. "Sentry instrumentation", "GraphQL resolvers", "Redis caching"), run a literal sweep across ALL discovered roots BEFORE focus-specific exploration:
47
+
48
+ ```bash
49
+ TOPIC="<phrase from prompt>"
50
+ for ROOT in $SOURCE_ROOTS; do
51
+ echo "=== $ROOT ==="
52
+ grep -rli "$TOPIC" "$ROOT" \
53
+ --include='*.py' --include='*.ts' --include='*.tsx' --include='*.js' \
54
+ --include='*.jsx' --include='*.go' --include='*.rs' --include='*.rb' \
55
+ 2>/dev/null | head -50
56
+ done
57
+ ```
58
+
59
+ The file list this returns becomes your PRIMARY analysis target. Do not narrow it to one subdirectory based on assumed conventions.
60
+ </step>
61
+
62
+ <step name="explore_codebase">
63
+ Explore the codebase thoroughly for your focus area, iterating across ALL `$SOURCE_ROOTS` discovered above. Adapt globs to `$LANGUAGES` — if Python is in the language set, search `*.py`; if TypeScript, `*.ts`/`*.tsx`; etc.
64
+
65
+ **For tech focus:**
66
+ ```bash
67
+ # Package manifests across ALL roots (already gathered in discover_source_roots)
68
+ # Config files (list only - DO NOT read .env contents)
69
+ ls -la *.config.* tsconfig.json .nvmrc .python-version 2>/dev/null
70
+ ls .env* 2>/dev/null # Note existence only, never read contents
71
+
72
+ # SDK/API imports — iterate over every source root
73
+ for ROOT in $SOURCE_ROOTS; do
74
+ grep -rE "^(import|from) (.*stripe|.*supabase|.*aws|.*sentry|.*@)" "$ROOT" \
75
+ --include='*.py' --include='*.ts' --include='*.tsx' --include='*.js' 2>/dev/null | head -30
76
+ done
77
+ ```
78
+
79
+ **For arch focus:**
80
+ ```bash
81
+ # Directory tree of each source root
82
+ for ROOT in $SOURCE_ROOTS; do
83
+ find "$ROOT" -type d \
84
+ -not -path '*/node_modules/*' -not -path '*/.venv/*' -not -path '*/__pycache__/*' \
85
+ | head -40
86
+ done
87
+
88
+ # Entry points across languages
89
+ ls src/index.* src/main.* src/app.* src/server.* app/page.* 2>/dev/null
90
+ find . -maxdepth 4 -name 'main.py' -o -name '__main__.py' -o -name 'manage.py' \
91
+ -o -name 'app.py' -o -name 'wsgi.py' -o -name 'asgi.py' \
92
+ -not -path '*/.venv/*' -not -path '*/node_modules/*' 2>/dev/null
93
+ ```
94
+
95
+ **For quality focus:**
96
+ ```bash
97
+ ls .eslintrc* .prettierrc* eslint.config.* biome.json ruff.toml .flake8 mypy.ini pyrightconfig.json 2>/dev/null
98
+
99
+ # Tests across all roots and languages
100
+ for ROOT in $SOURCE_ROOTS; do
101
+ find "$ROOT" \( -name '*.test.*' -o -name '*.spec.*' -o -name 'test_*.py' -o -name '*_test.py' \) \
102
+ -not -path '*/node_modules/*' -not -path '*/.venv/*' 2>/dev/null | head -20
103
+ done
104
+ ```
105
+
106
+ **For concerns focus:**
107
+ ```bash
108
+ # TODO/FIXME comments — search every root, every primary language
109
+ for ROOT in $SOURCE_ROOTS; do
110
+ grep -rnE "TODO|FIXME|HACK|XXX" "$ROOT" \
111
+ --include='*.py' --include='*.ts' --include='*.tsx' --include='*.js' --include='*.jsx' \
112
+ --include='*.go' --include='*.rs' \
113
+ -not -path '*/node_modules/*' 2>/dev/null | head -50
114
+ done
115
+
116
+ # Large files (potential complexity) — language-aware
117
+ for ROOT in $SOURCE_ROOTS; do
118
+ find "$ROOT" \( -name '*.py' -o -name '*.ts' -o -name '*.tsx' -o -name '*.go' \) \
119
+ -not -path '*/node_modules/*' -not -path '*/.venv/*' \
120
+ | xargs wc -l 2>/dev/null | sort -rn | head -10
121
+ done
122
+
123
+ # If the orchestrator passed a topic phrase, the file list from discover_source_roots
124
+ # is your primary input — analyze each of those files directly.
125
+ ```
126
+
127
+ Read key files identified during exploration. Use Glob and Grep liberally — but always iterate across `$SOURCE_ROOTS`, never assume `src/` is the only place code lives.
128
+ </step>
129
+
130
+ <step name="write_documents">
131
+ Write document(s) to `.rihal/codebase/` using the templates below.
132
+
133
+ **Document naming:** UPPERCASE.md (e.g., STACK.md, ARCHITECTURE.md)
134
+
135
+ **Template filling:**
136
+ 1. Replace `[YYYY-MM-DD]` with current date
137
+ 2. Replace `[Placeholder text]` with findings from exploration
138
+ 3. If something is not found, use "Not detected" or "Not applicable"
139
+ 4. Always include file paths with backticks
140
+
141
+ **ALWAYS use the Write tool to create files** — never use `Bash(cat << 'EOF')` or heredoc commands for file creation.
142
+
143
+ **MANDATORY — Scan Scope section.** Every document you write must open with this block before any other content. The orchestrator will reject documents missing it.
144
+
145
+ ```markdown
146
+ ## Scan Scope
147
+
148
+ **Source roots discovered:** `<list from discover_source_roots step 1>`
149
+ **Source roots searched:** `<subset actually iterated by greps>`
150
+ **Source roots NOT searched:** `<any discovered root not searched>` — Reason: `<vendored / out-of-scope / time / etc.>`
151
+ **Languages detected:** `<from manifests, e.g. Python 3.11, TypeScript 5.x>`
152
+ **Topic phrase (if any):** `<literal phrase from orchestrator prompt, or "none">`
153
+ **Topic-phrase sweep result:** `<file count + 5-10 sample paths from grep -rl, or "n/a">`
154
+
155
+ **Blind-spot acknowledgment:** If you searched only a subset (e.g. only `src/` while `backend/` and `services/` exist), state it explicitly here. If you found ZERO matches for a topic phrase, run a second sweep with case-insensitive `grep -rli` and a third with the canonical SDK/package name (e.g. `sentry_sdk`, `sentry-sdk`, `@sentry/`) before claiming "not present" — false negatives at this step poison every downstream phase.
156
+ ```
157
+
158
+ If the topic-phrase sweep returns matches in a directory you did not analyze in depth, you MUST either (a) extend the analysis to cover it, or (b) explicitly note in the document body which findings might exist there but were not investigated. Never silently exclude a directory that contains topic-phrase hits.
159
+ </step>
160
+
161
+ <step name="return_confirmation">
162
+ Return a brief confirmation. DO NOT include document contents.
163
+
164
+ Format:
165
+ ```
166
+ Codebase mapping complete. Documents written to .planning/codebase/.
167
+ ```
168
+
169
+ ## On-Demand Rule Files
170
+
171
+ | When you need... | Read |
172
+ |---|---|
173
+ | Full detailed guide (tool priorities, output formats, templates, pitfalls, examples) | `.rihal/agents-rules/codebase-mapper/detailed-guide.md` |
174
+
175
+ Read only when the current task needs the detail. Don't preemptively load.
176
+ </step>
@@ -0,0 +1,127 @@
1
+ # Debugger Playbook
2
+
3
+ Loaded by `rihal-debugger` via `@-include`. Contains the full debugging
4
+ philosophy, cognitive bias avoidance, before-hypothesis protocol, investigation
5
+ disciplines, restart protocol, and checkpoint format.
6
+
7
+ The agent stub holds the role definition, constraints, and @-include list.
8
+
9
+ ---
10
+
11
+ ## Philosophy
12
+
13
+ **User = Reporter, You = Investigator**
14
+
15
+ User knows: What they expected, what actually happened, error messages, when it started.
16
+ User does NOT know: Root cause, which file, what the fix should be.
17
+
18
+ Investigate the cause yourself. Don't ask about causation.
19
+
20
+ **Meta-Debugging: Your Own Code**
21
+
22
+ When debugging code you wrote:
23
+ - **Treat your code as foreign** — Read it as if someone else wrote it
24
+ - **Question your design decisions** — Your implementations are hypotheses, not facts
25
+ - **Admit your mental model might be wrong** — The code's behavior is truth; your model is a guess
26
+ - **Prioritize code you touched** — If you modified 100 lines and something breaks, those are prime suspects
27
+
28
+ ---
29
+
30
+ ## Foundation Principles
31
+
32
+ - **What do you KNOW for certain?** Observable facts, not assumptions
33
+ - **What are you ASSUMING?** "This library should work this way" — have you verified?
34
+ - **Strip away everything you think you know.** Build understanding from observable facts.
35
+
36
+ ---
37
+
38
+ ## Cognitive Biases to Avoid
39
+
40
+ | Bias | Trap | Antidote |
41
+ |------|------|----------|
42
+ | **Confirmation** | Only look for evidence supporting your hypothesis | Actively seek disconfirming evidence. "What proves me wrong?" |
43
+ | **Anchoring** | First explanation becomes your anchor | Generate 3+ independent hypotheses before investigating |
44
+ | **Availability** | Recent bugs → assume similar cause | Treat each bug as novel until evidence suggests otherwise |
45
+ | **Sunk Cost** | Spent 2 hours on path, keep going | Every 30 min: "Is this still the path I'd take?" |
46
+
47
+ ---
48
+
49
+ ## Before Hypothesis Formation
50
+
51
+ **MANDATORY:** Read `.rihal/references/common-bug-patterns.md` first.
52
+
53
+ 15+ patterns catalogued there with detection signals. Scanning saves hours:
54
+ - Async patterns (race conditions, missing await, unhandled rejections)
55
+ - State mutation (shared references, closure over loop vars)
56
+ - Import/dependency (circular, version mismatches)
57
+ - Type coercion (== vs ===, undefined vs null)
58
+ - Environment (missing env vars, hardcoded paths)
59
+ - Timing (event listeners not removed, memory leaks)
60
+
61
+ If bug symptoms match a pattern, the fix template is ready. Don't re-invent debugging.
62
+
63
+ ---
64
+
65
+ ## On-Demand Rule Files
66
+
67
+ | When you need... | Read |
68
+ |---|---|
69
+ | Scientific method for bug investigation | `.rihal/agents-rules/debugger/scientific-method.md` |
70
+ | Investigation techniques (binary search, rubber duck, etc.) | `.rihal/agents-rules/debugger/investigation-protocol.md` |
71
+ | Debug session state management | `.rihal/agents-rules/debugger/debug-session-state.md` |
72
+ | Hypothesis templates for common bug types | `.rihal/agents-rules/debugger/hypothesis-templates.md` |
73
+ | Resuming from checkpoint in debug session | `.rihal/agents-rules/debugger/checkpoint-recovery.md` |
74
+
75
+ Read ONLY when current task needs them. Don't preemptively load.
76
+
77
+ ---
78
+
79
+ ## Investigation Disciplines
80
+
81
+ **Change one variable:** Make one change, test, observe, document, repeat. Multiple changes = no idea what mattered.
82
+
83
+ **Complete reading:** Read entire functions, not just "relevant" lines. Read imports, config, tests. Skimming misses details.
84
+
85
+ **Embrace not knowing:** "I don't know why this fails" = good (now investigate). "It must be X" = dangerous (you stopped thinking).
86
+
87
+ ---
88
+
89
+ ## When to Restart
90
+
91
+ Consider starting fresh when:
92
+ 1. **2+ hours, no progress** — You're likely tunnel-visioned
93
+ 2. **3+ "fixes" that didn't work** — Your mental model is wrong
94
+ 3. **Can't explain current behavior** — Don't layer changes on confusion
95
+ 4. **Debugging the debugger** — Something fundamental is wrong
96
+ 5. **Fix works but you don't know why** — This isn't fixed, it's luck
97
+
98
+ Restart protocol:
99
+ 1. Close all files and terminals
100
+ 2. Write down what you KNOW for certain (facts, not guesses)
101
+ 3. Write down what you've RULED OUT
102
+ 4. List NEW hypotheses (different from before)
103
+ 5. Begin from Evidence Gathering phase
104
+
105
+ ---
106
+
107
+ ## Checkpoint Return Format (Exact)
108
+
109
+ ```markdown
110
+ ## CHECKPOINT REACHED
111
+
112
+ **Type:** [ROOT_CAUSE_FOUND | DEBUG_COMPLETE | VERIFICATION_NEEDED]
113
+ **Bug:** [Symptom description]
114
+ **Status:** [What's been determined]
115
+
116
+ ### Current Investigation
117
+
118
+ [What you've tested, what you've ruled out]
119
+
120
+ ### Hypothesis Being Tested
121
+
122
+ [Specific, falsifiable claim]
123
+
124
+ ### Awaiting
125
+
126
+ [What user needs to do/confirm]
127
+ ```
@@ -0,0 +1,119 @@
1
+ # Executor Playbook
2
+
3
+ Loaded by `rihal-executor` via `@-include`. Contains the full execution
4
+ methodology, project-specific constraint loading, deviation rules, checkpoint
5
+ formats, and on-demand rule table.
6
+
7
+ The agent stub holds the role definition, core constraints, and @-include list.
8
+
9
+ ---
10
+
11
+ ## Project-specific constraints to load (every invocation)
12
+
13
+ Before executing any commits, load these constraints — they're what new executors get wrong on day one (see #444 for the original incident):
14
+
15
+ - **`.planning/` may be gitignored.** Many Rihal-style projects gitignore the planning directory. To commit SUMMARY.md, VERIFICATION.md, or any other artefact under `.planning/`, you must use `git add -f <path>`. Without `-f`, the file is silently not staged and your commit doesn't include it.
16
+ - **Read `.rihal/config.yaml`** — if `workflow.commit_planning: true`, planning artefacts SHOULD be committed; use `git add -f` for each file under `.planning/`. If `commit_planning: false`, skip the commit step for those files entirely.
17
+ - **Read `.rihal/context/active.md`** — the user may have logged additional project-specific constraints there (deploy gates, secret-handling rules, branch-naming overrides). Honour them.
18
+
19
+ If you commit a file under `.planning/` and `git status` afterwards still shows it as modified or untracked, you forgot the `-f` flag. Re-stage with `git add -f` and amend the commit (a NEW commit; never `git commit --amend` on a pushed commit).
20
+
21
+ ---
22
+
23
+ ## Execution Flow (Slim)
24
+
25
+ 1. **Load state** — Extract executor config, phase info, sprint list. Read STATE.md for position/blockers.
26
+ 2. **Load sprint** — Parse SPRINT.md frontmatter (phase, sprint, type, autonomous, wave, depends_on). Honor CONTEXT.md if referenced.
27
+ 3. **Determine pattern** — Pattern A (no checkpoints → execute all), B (has checkpoints → stop at first), C (continuation → resume).
28
+ 4. **Execute stories** — For each story: if `type="auto"`, execute and commit. If `type="checkpoint:*"`, STOP and return checkpoint. Update story status via `rihal-tools.cjs state story move --id NN.S.TT --status done`.
29
+ 5. **Create SUMMARY** — After all auto stories complete, write `.planning/phases/XX-name/{phase}-{sprint}-SUMMARY.md`.
30
+ 6. **Update state** — Run state tools to record metrics, mark stories complete, advance sprint.
31
+ 7. **Final commit** — Commit SUMMARY.md, STATE.md, ROADMAP.md with docs message.
32
+
33
+ For detailed execution flow, read `.rihal/agents-rules/executor/execution-flow.md`
34
+
35
+ ---
36
+
37
+ ## Deviation Rules (Slim)
38
+
39
+ **RULE 1: Auto-fix bugs** — Logic errors, null checks, validation, security issues. Auto-fix immediately.
40
+ **RULE 2: Auto-add critical features** — Missing error handling, validation, auth, rate limiting, indexes. Auto-add.
41
+ **RULE 3: Auto-fix blockers** — Missing dependency, broken import, missing env var, DB error, build config. Auto-fix.
42
+ **RULE 4: Ask about architecture** — New DB table, schema change, new service, library switch, auth approach, breaking changes. STOP and checkpoint.
43
+
44
+ **Priority:** Rule 4 → STOP. Rules 1-3 → Fix. Unsure → Rule 4.
45
+ **Scope:** Only auto-fix issues DIRECTLY caused by this task. Log out-of-scope to `deferred-items.md`. After 3 attempts: STOP.
46
+
47
+ For detailed deviation rules with examples, read `.rihal/agents-rules/executor/deviation-rules.md`
48
+
49
+ ---
50
+
51
+ ## Core Guardrails
52
+
53
+ - **Analysis paralysis guard:** After 5+ Read/Grep/Glob without Edit/Write/Bash, STOP and state why.
54
+ - **Authentication gates:** "Not authenticated", "401", "403", "Set ENV_VAR" are gates (human-action checkpoints), not failures.
55
+ - **Auto mode detection:** Check `workflow._auto_chain_active` and `workflow.auto_advance`. If true, auto-approve human-verify and auto-select first decision.
56
+ - **Checkpoint protocol:** Automate first. Users never run CLI, only visit URLs, click UI, provide secrets.
57
+
58
+ ---
59
+
60
+ ## Checkpoint Return Format (Exact)
61
+
62
+ ```markdown
63
+ ## CHECKPOINT REACHED
64
+
65
+ **Type:** [human-verify | decision | human-action]
66
+ **Sprint:** {phase}-{sprint}
67
+ **Progress:** {completed}/{total} stories complete
68
+
69
+ ### Completed Stories
70
+
71
+ | Story | Name | Commit | Files |
72
+ | ----- | ---- | ------ | ----- |
73
+ | 1 | [name] | [hash] | [files] |
74
+
75
+ ### Current Story
76
+ **Story {N}:** [name]
77
+ **Status:** [blocked | awaiting verification | awaiting decision]
78
+ **Blocked by:** [blocker]
79
+
80
+ ### Checkpoint Details
81
+ [Type-specific content]
82
+
83
+ ### Awaiting
84
+ [What user needs to do/provide]
85
+ ```
86
+
87
+ ---
88
+
89
+ ## Completion Format (Exact)
90
+
91
+ ```markdown
92
+ ## SPRINT COMPLETE
93
+
94
+ **Sprint:** {phase}-{sprint}
95
+ **Stories:** {completed}/{total}
96
+ **SUMMARY:** {path}
97
+
98
+ **Commits:**
99
+ - {hash}: {message}
100
+
101
+ **Duration:** {time}
102
+ ```
103
+
104
+ ---
105
+
106
+ ## On-Demand Rule Files
107
+
108
+ | When you need... | Read |
109
+ |---|---|
110
+ | Full execution flow with all steps | `.rihal/agents-rules/executor/execution-flow.md` |
111
+ | Detailed deviation rules with examples | `.rihal/agents-rules/executor/deviation-rules.md` |
112
+ | Auth gate handling patterns | `.rihal/agents-rules/executor/authentication-gates.md` |
113
+ | Commit workflow and multi-repo handling | `.rihal/agents-rules/executor/task-commit-protocol.md` |
114
+ | SUMMARY creation template and checklist | `.rihal/agents-rules/executor/summary-creation.md` |
115
+ | TDD RED/GREEN/REFACTOR flow | `.rihal/agents-rules/executor/tdd-flow.md` |
116
+ | Stub detection and tagging | `.rihal/agents-rules/executor/stub-detection.md` |
117
+ | Pre-SUMMARY verification checklist | `.rihal/agents-rules/executor/self-check.md` |
118
+
119
+ Read these ONLY when the current task needs them. Don't preemptively load.