@hanzlaa/rcode 3.4.27 → 3.4.28

package/AGENTS.md

@@ -24,7 +24,7 @@ If a user says "just keep going" or "don't stop until done", that authorization
 
 - Follow [Conventional Commits](https://www.conventionalcommits.org/) format: `type(scope): subject`
 - Types allowed: `feat`, `fix`, `docs`, `style`, `refactor`, `test`, `chore`, `perf`, `revert`
-- Scopes allowed: `agents`, `skills`, `workflows`, `templates`, `dashboard`, `docs`, `config`, `github`, `commands`, `memory`, `brand`, `cli`, `ci`, `release`, `meta`, `tasks`, `migrations`, `refs`, `state`, `hooks`, `install`, `parity`, `triggers`, `dogfood`, `namespace`, `planning`, `insights`, `help`, `roadmap`, `session`, `audits`, `execute`, `executor`, `plan`, `planner`, `readme`, `sync`, `sprint`, `agent-exp`, `extensibility`, `lens-audit`, `tiers`, plus numeric phase/sprint scopes (e.g. `docs(15)`, `feat(8.3)`)
+- Scopes allowed: `agents`, `skills`, `workflows`, `templates`, `dashboard`, `docs`, `config`, `github`, `commands`, `memory`, `brand`, `cli`, `ci`, `release`, `meta`, `tasks`, `migrations`, `refs`, `state`, `hooks`, `install`, `parity`, `triggers`, `dogfood`, `namespace`, `planning`, `insights`, `help`, `roadmap`, `session`, `audits`, `execute`, `executor`, `plan`, `planner`, `readme`, `sync`, `sprint`, `agent-exp`, `extensibility`, `lens-audit`, `tiers`, `build`, `council`, `doctor`, `postinstall`, `progress`, `security`, `tools`, `uninstall`, `test`, plus numeric phase/sprint scopes (e.g. `docs(15)`, `feat(8.3)`)
 - Subject: lowercase first letter, imperative mood, no trailing period, under 72 chars
 - **NEVER add Claude/AI attribution to commit messages.** No "Generated with Claude Code", no "Co-Authored-By: Claude", no "🤖 Generated". The user does not want this.
 - **NEVER use `--no-verify`** to bypass hooks. If hooks fail, fix the underlying issue.

package/CONTRIBUTING.md

@@ -298,6 +298,15 @@ We use [Conventional Commits](https://www.conventionalcommits.org/) format. The
 - `extensibility` — extensibility and plugin hooks
 - `lens-audit` — 15-lens audit system and lenses
 - `tiers` — TIERS.md and tier-related documentation
+- `build` — `scripts/build.cjs`, esbuild config, bundle artifacts
+- `council` — `/rihal-council` workflow + spawning logic
+- `doctor` — `cli/doctor.js` health checks
+- `postinstall` — `cli/postinstall.js` lifecycle hook
+- `progress` — `/rihal-progress` workflow
+- `security` — security guardrails (symlink guards, integrity checks)
+- `test` — test files under `test/` (test-only changes)
+- `tools` — `rihal/bin/rihal-tools.cjs` subcommands
+- `uninstall` — `cli/uninstall.js` flow
 - `<phase-id>` — numeric phase scope when committing inside a phase (e.g. `docs(15)`, `feat(8.3)`)
 - `<sprint-id>` — numeric sprint scope inside a phase (e.g. `feat(15.1)`)
 

package/cli/lib/manifest.cjs

@@ -109,7 +109,12 @@ function diffSet(editor, kind, expected, installed) {
  * makes doctor report drift like "agents 119/23" when nothing is wrong.
  * That's why the agent count comes from .claude/agents/, not .claude/skills/.
  */
-function verifyClaudeInstall(cwd, packageRoot) {
+function verifyClaudeInstall(cwd, packageRoot, options = {}) {
+  // Issue #698: tests assert against an isolated tempdir cwd. The global
+  // fallback (#664) makes that impossible because it reads the contributor's
+  // real ~/.claude/. Tests can pass { globalFallback: false } to disable it.
+  // Default remains true to preserve the runtime behavior introduced in #664.
+  const globalFallback = options.globalFallback !== false;
   const pkg = readPackageManifest(packageRoot);
   const agentsDir = path.join(cwd, '.claude/agents');
   const skillsDir = path.join(cwd, '.claude/skills');
@@ -129,7 +134,7 @@ function verifyClaudeInstall(cwd, packageRoot) {
   // level .claude/agents/rihal-*.md when the user's ~/.claude/ already has
   // them, to avoid duplicate commands. Without this fallback the verifier
   // reports 0 agents on every successful install in that scenario.
-  if (installedAgents.size === 0) {
+  if (installedAgents.size === 0 && globalFallback) {
     try {
       const os = require('os');
       const globalAgentsDir = path.join(os.homedir(), '.claude/agents');
@@ -143,12 +148,13 @@ function verifyClaudeInstall(cwd, packageRoot) {
     } catch { /* non-fatal — permission errors etc. */ }
   }
 
-  // Actions: .claude/skills/<bare-name>/ — exclude rihal-* dirs (those are
-  // either agent stubs or command stubs, never action skills).
+  // Actions: .claude/skills/rihal-<name>/. installSkills (cli/install.js)
+  // prefixes every action with rihal-, and readPackageManifest does the
+  // same — so both sides are normalized. The previous version filtered OUT
+  // rihal-* dirs which excluded ALL real actions and made the diff always
+  // report "everything missing." Compare directly against the prefixed set.
   const allInstalled = readInstalledDirs(skillsDir);
-  const actionsInstalled = new Set(
-    [...allInstalled].filter((n) => !n.startsWith('rihal-'))
-  );
+  const actionsInstalled = new Set([...allInstalled].filter((n) => pkg.actions.has(n)));
 
   return [
     diffSet('claude', 'agents', pkg.agents, installedAgents),

package/dist/rcode.js

@@ -15073,7 +15073,8 @@ var require_manifest = __commonJS({
         extra
       };
     }
-    function verifyClaudeInstall(cwd, packageRoot) {
+    function verifyClaudeInstall(cwd, packageRoot, options = {}) {
+      const globalFallback = options.globalFallback !== false;
       const pkg = readPackageManifest(packageRoot);
       const agentsDir = path2.join(cwd, ".claude/agents");
       const skillsDir = path2.join(cwd, ".claude/skills");
@@ -15085,7 +15086,7 @@ var require_manifest = __commonJS({
           }
         }
       }
-      if (installedAgents.size === 0) {
+      if (installedAgents.size === 0 && globalFallback) {
         try {
           const os = require("os");
           const globalAgentsDir = path2.join(os.homedir(), ".claude/agents");
@@ -15100,9 +15101,7 @@ var require_manifest = __commonJS({
         }
       }
       const allInstalled = readInstalledDirs(skillsDir);
-      const actionsInstalled = new Set(
-        [...allInstalled].filter((n) => !n.startsWith("rihal-"))
-      );
+      const actionsInstalled = new Set([...allInstalled].filter((n) => pkg.actions.has(n)));
       return [
         diffSet("claude", "agents", pkg.agents, installedAgents),
         diffSet("claude", "actions", pkg.actions, actionsInstalled)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hanzlaa/rcode",
-  "version": "3.4.27",
+  "version": "3.4.28",
   "description": "rcode — the memory bank for AI-driven SaaS teams. Persistent project context, distinctive engineering personas, and phase-based workflows. Built by Rihal. Works in Claude Code, Cursor, Gemini, VS Code, and Antigravity.",
   "main": "cli/index.js",
   "bin": {