@hanna84/mcp-writing 3.7.0 → 3.8.0

package/src/tools/review-bundles.js

@@ -27,8 +27,9 @@ export function registerReviewBundleTools(s, {
       project_id: z.string().describe("Project ID to scope the review bundle (e.g. 'test-novel')."),
       profile: z.enum(REVIEW_BUNDLE_PROFILES).describe("Bundle profile: outline_discussion, editor_detailed, or beta_reader_personalized."),
       part: z.number().int().optional().describe("Optional part filter."),
-      chapter: z.number().int().optional().describe("Optional chapter filter."),
-      chapters: z.array(z.number().int()).min(1).optional().describe("Optional chapter-set filter. Use this for one/few specific chapters. Do not combine with chapter."),
+      chapter: z.number().int().optional().describe("Optional compatibility chapter filter."),
+      chapter_id: z.string().optional().describe("Optional canonical chapter identifier."),
+      chapters: z.array(z.number().int()).min(1).optional().describe("Optional chapter-set filter. Use this for one/few specific chapters. Do not combine with chapter or chapter_id."),
       tag: z.string().optional().describe("Optional tag filter (exact match)."),
       scene_ids: z.array(z.string()).optional().describe("Optional explicit scene_id allowlist. Intersects with other filters."),
       strictness: z.enum(REVIEW_BUNDLE_STRICTNESS).optional().describe("Strictness mode: warn (default) or fail."),
@@ -47,6 +48,7 @@ export function registerReviewBundleTools(s, {
       profile,
       part,
       chapter,
+      chapter_id,
       chapters,
       tag,
       scene_ids,
@@ -72,6 +74,7 @@ export function registerReviewBundleTools(s, {
           profile,
           part,
           chapter,
+          chapter_id,
           chapters,
           tag,
           scene_ids,
@@ -121,8 +124,9 @@ export function registerReviewBundleTools(s, {
       profile: z.enum(REVIEW_BUNDLE_PROFILES).describe("Bundle profile: outline_discussion, editor_detailed, or beta_reader_personalized."),
       output_dir: z.string().describe("Directory path to write bundle artifacts into."),
       part: z.number().int().optional().describe("Optional part filter."),
-      chapter: z.number().int().optional().describe("Optional chapter filter."),
-      chapters: z.array(z.number().int()).min(1).optional().describe("Optional chapter-set filter. Use this for one/few specific chapters. Do not combine with chapter."),
+      chapter: z.number().int().optional().describe("Optional compatibility chapter filter."),
+      chapter_id: z.string().optional().describe("Optional canonical chapter identifier."),
+      chapters: z.array(z.number().int()).min(1).optional().describe("Optional chapter-set filter. Use this for one/few specific chapters. Do not combine with chapter or chapter_id."),
       tag: z.string().optional().describe("Optional tag filter (exact match)."),
       scene_ids: z.array(z.string()).optional().describe("Optional explicit scene_id allowlist. Intersects with other filters."),
       strictness: z.enum(REVIEW_BUNDLE_STRICTNESS).optional().describe("Strictness mode: warn (default) or fail."),
@@ -143,6 +147,7 @@ export function registerReviewBundleTools(s, {
       output_dir,
       part,
       chapter,
+      chapter_id,
       chapters,
       tag,
       scene_ids,
@@ -182,6 +187,7 @@ export function registerReviewBundleTools(s, {
           profile,
           part,
           chapter,
+          chapter_id,
           chapters,
           tag,
           scene_ids,

package/src/tools/search.js

@@ -39,6 +39,67 @@ function readSceneEntityIdsFromMetadata({ scenePath, syncDir }) {
   };
 }
 
+function resolveChapterByCompatibilityKey(db, { projectId, chapterNumber, chapterId }) {
+  if (!projectId) return null;
+  if (chapterId) {
+    return db.prepare(`
+      SELECT chapter_id, project_id, title, sort_index, logline, metadata_stale
+      FROM chapters
+      WHERE project_id = ? AND chapter_id = ?
+    `).get(projectId, chapterId);
+  }
+  if (chapterNumber == null) return null;
+  const canonicalChapter = db.prepare(`
+    SELECT chapter_id, project_id, title, sort_index, logline, metadata_stale
+    FROM chapters
+    WHERE project_id = ? AND sort_index = ?
+  `).get(projectId, chapterNumber);
+  if (canonicalChapter) return canonicalChapter;
+
+  return db.prepare(`
+    SELECT chapter_id, project_id, chapter_title AS title, chapter AS sort_index, NULL AS logline, MAX(metadata_stale) AS metadata_stale
+    FROM scenes
+    WHERE project_id = ? AND chapter = ? AND chapter_id IS NOT NULL
+    GROUP BY chapter_id, project_id, chapter_title, chapter
+    ORDER BY chapter_id
+    LIMIT 1
+  `).get(projectId, chapterNumber);
+}
+
+function resolveValidatedChapterFilter(db, { projectId, chapterNumber, chapterId }) {
+  if (!projectId) return { chapter: null };
+  if (!chapterId && chapterNumber == null) return { chapter: null };
+
+  const resolvedById = chapterId
+    ? resolveChapterByCompatibilityKey(db, { projectId, chapterId })
+    : null;
+  const resolvedByNumber = chapterNumber != null
+    ? resolveChapterByCompatibilityKey(db, { projectId, chapterNumber })
+    : null;
+
+  if (chapterId && chapterNumber != null) {
+    if (!resolvedById || !resolvedByNumber) {
+      return {
+        error: {
+          code: "NOT_FOUND",
+          message: "Chapter not found for the provided project and identifier.",
+        },
+      };
+    }
+    if (resolvedById.chapter_id !== resolvedByNumber.chapter_id) {
+      return {
+        error: {
+          code: "VALIDATION_ERROR",
+          message: "chapter_id and chapter must refer to the same canonical chapter when both are provided.",
+        },
+      };
+    }
+    return { chapter: resolvedById };
+  }
+
+  return { chapter: resolvedById ?? resolvedByNumber ?? null };
+}
+
 function selectApplyCandidates(enrichedCandidates, selectedDocIds, maxApply) {
   const selectedSet = selectedDocIds ? new Set(selectedDocIds) : null;
   const chosenByDocId = new Map();
@@ -70,21 +131,43 @@ export function registerSearchTools(s, {
   // ---- find_scenes ---------------------------------------------------------
   s.tool(
     "find_scenes",
-    "Find scenes by filtering on character, Save the Cat beat, tags, part, chapter, or POV. Returns ordered scene metadata only — no prose. All filters are optional and combinable. Supports pagination via page/page_size and auto-paginates large result sets with total_count. Warns if any matching scenes have stale metadata. Response shape note: always returns a structured envelope (`results`, `total_count`, with pagination fields when paging is active).",
+    "Find scenes by filtering on character, Save the Cat beat, tags, chapter identity, numeric compatibility chapter, or POV. Returns ordered scene metadata only — no prose. Most filters are optional and combinable. `chapter_id` requires `project_id`, and mixed `chapter_id`/`chapter` filters must resolve to the same canonical chapter. Supports pagination via page/page_size and auto-paginates large result sets with total_count. Warns if any matching scenes have stale metadata. Response shape note: always returns a structured envelope (`results`, `total_count`, with pagination fields when paging is active).",
     {
       project_id: z.string().optional().describe("Project ID (e.g. 'the-lamb'). Use to scope results to one project."),
       character:  z.string().optional().describe("A character_id (e.g. 'char-mira-nystrom'). Returns only scenes that character appears in. Use list_characters first to find valid IDs."),
       beat:       z.string().optional().describe("Save the Cat beat name (e.g. 'Opening Image'). Exact match."),
       tag:        z.string().optional().describe("Scene tag to filter by. Exact match."),
       part:       z.number().int().optional().describe("Part number (integer, e.g. 1). Chapters are numbered globally across the whole project."),
-      chapter:    z.number().int().optional().describe("Chapter number (integer, e.g. 3). Chapters are numbered globally across the whole project — do not reset per part."),
+      chapter:    z.number().int().optional().describe("Compatibility chapter number resolved from canonical chapter sort order."),
+      chapter_id: z.string().optional().describe("Canonical chapter identifier. Requires project_id. Use list_chapters to find valid values."),
       pov:        z.string().optional().describe("POV character_id. Use list_characters first to find valid IDs."),
       page:       z.number().int().min(1).optional().describe("Optional page number for paginated responses (1-based)."),
       page_size:  z.number().int().min(1).max(200).optional().describe("Optional page size for paginated responses (default: 20, max: 200)."),
     },
-    async ({ project_id, character, beat, tag, part, chapter, pov, page, page_size }) => {
+    async ({ project_id, character, beat, tag, part, chapter, chapter_id, pov, page, page_size }) => {
+      if (chapter_id && !project_id) {
+        return errorResponse(
+          "VALIDATION_ERROR",
+          "Provide project_id when filtering by chapter_id.",
+          { chapter_id }
+        );
+      }
+      const resolvedChapterFilter = project_id && (chapter_id || chapter != null)
+        ? resolveValidatedChapterFilter(db, { projectId: project_id, chapterNumber: chapter, chapterId: chapter_id })
+        : { chapter: null };
+      if (resolvedChapterFilter.error) {
+        return errorResponse(
+          resolvedChapterFilter.error.code,
+          resolvedChapterFilter.error.message,
+          {
+            project_id: project_id ?? null,
+            chapter_id: chapter_id ?? null,
+            chapter: chapter ?? null,
+          }
+        );
+      }
       let query = `
-        SELECT DISTINCT s.scene_id, s.project_id, s.title, s.part, s.chapter, s.chapter_title, s.pov,
+        SELECT DISTINCT s.scene_id, s.project_id, s.chapter_id, s.title, s.part, s.chapter, s.chapter_title, s.pov,
                s.logline, s.scene_change, s.causality, s.stakes, s.scene_functions,
                s.save_the_cat_beat, s.timeline_position, s.story_time,
                s.word_count, s.metadata_stale
@@ -105,12 +188,16 @@ export function registerSearchTools(s, {
       if (project_id)  { conditions.push(`s.project_id = ?`);        params.push(project_id); }
       if (beat)        { conditions.push(`s.save_the_cat_beat = ?`);  params.push(beat); }
       if (part)        { conditions.push(`s.part = ?`);               params.push(part); }
-      if (chapter)     { conditions.push(`s.chapter = ?`);            params.push(chapter); }
+      if (resolvedChapterFilter.chapter) {
+        conditions.push(`s.chapter_id = ?`);
+        params.push(resolvedChapterFilter.chapter.chapter_id);
+      } else if (chapter_id)  { conditions.push(`s.chapter_id = ?`);         params.push(chapter_id); }
+      else if (chapter) { conditions.push(`s.chapter = ?`);           params.push(chapter); }
       if (pov)         { conditions.push(`s.pov = ?`);                params.push(pov); }
 
       if (joins.length)      query += " " + joins.join(" ");
       if (conditions.length) query += " WHERE " + conditions.join(" AND ");
-      query += " ORDER BY s.part, s.chapter, s.timeline_position";
+      query += " ORDER BY s.part, s.chapter, s.timeline_position, s.scene_id";
 
       const rows = db.prepare(query).all(...params);
       if (rows.length === 0) {
@@ -229,21 +316,48 @@ export function registerSearchTools(s, {
   // ---- get_chapter_prose ---------------------------------------------------
   s.tool(
     "get_chapter_prose",
-    `Load the full prose for every scene in a chapter, concatenated in order. Expensive — only use when you need to read an entire chapter. Capped at ${MAX_CHAPTER_SCENES} scenes. Use find_scenes first to confirm the chapter exists.`,
+    `Load the full prose for every scene in a chapter, concatenated in order. Provide chapter_id or chapter, plus project_id. Canonical targeting uses chapter_id; numeric chapter remains available as a compatibility alias resolved from canonical sort order. Expensive — only use when you need to read an entire chapter. Capped at ${MAX_CHAPTER_SCENES} scenes. Use find_scenes first to confirm the chapter exists.`,
     {
       project_id: z.string().describe("Project ID (e.g. 'the-lamb')."),
-      part:       z.number().int().describe("Part number (integer)."),
-      chapter:    z.number().int().describe("Chapter number (integer, globally numbered across the whole project)."),
+      chapter_id: z.string().optional().describe("Canonical chapter identifier."),
+      chapter:    z.number().int().optional().describe("Compatibility chapter number resolved from canonical sort order."),
     },
-    async ({ project_id, part, chapter }) => {
+    async ({ project_id, chapter_id, chapter }) => {
+      if (!chapter_id && chapter == null) {
+        return errorResponse("VALIDATION_ERROR", "Provide chapter_id or chapter.");
+      }
+      const resolvedChapterFilter = resolveValidatedChapterFilter(db, {
+        projectId: project_id,
+        chapterNumber: chapter,
+        chapterId: chapter_id,
+      });
+      if (resolvedChapterFilter.error) {
+        return errorResponse(
+          resolvedChapterFilter.error.code,
+          resolvedChapterFilter.error.message,
+          {
+            project_id,
+            chapter_id: chapter_id ?? null,
+            chapter: chapter ?? null,
+          }
+        );
+      }
+      const resolvedChapter = resolvedChapterFilter.chapter;
+      if (!resolvedChapter) {
+        return errorResponse("NOT_FOUND", "Chapter not found for the provided project and identifier.", {
+          project_id,
+          chapter_id: chapter_id ?? null,
+          chapter: chapter ?? null,
+        });
+      }
       const allScenes = db.prepare(`
         SELECT scene_id, title, file_path FROM scenes
-        WHERE project_id = ? AND part = ? AND chapter = ?
-        ORDER BY timeline_position
-      `).all(project_id, part, chapter);
+        WHERE project_id = ? AND chapter_id = ?
+        ORDER BY timeline_position, scene_id
+      `).all(project_id, resolvedChapter.chapter_id);
 
       if (allScenes.length === 0) {
-        return errorResponse("NO_RESULTS", `No scenes found for Part ${part}, Chapter ${chapter}.`);
+        return errorResponse("NO_RESULTS", `No scenes found for chapter '${resolvedChapter.title}'.`);
       }
 
       const truncated = allScenes.length > MAX_CHAPTER_SCENES;
@@ -266,6 +380,7 @@ export function registerSearchTools(s, {
           ...(truncated
             ? { warning: `Chapter has ${allScenes.length} scenes — only the first ${MAX_CHAPTER_SCENES} were loaded. Set MAX_CHAPTER_SCENES to increase this limit.` }
             : {}),
+          chapter: resolvedChapter,
           next_step: truncated
             ? "Narrow with find_scenes and inspect key scenes individually with get_scene_prose before expanding chapter scope."
             : "If you only need a subset, switch to find_scenes + get_scene_prose for tighter context control.",
@@ -274,6 +389,96 @@ export function registerSearchTools(s, {
     }
   );
 
+  // ---- list_chapters ------------------------------------------------------
+  s.tool(
+    "list_chapters",
+    "List canonical chapters for a project. Returns chapter_id plus compatibility sort order so callers can migrate from numeric chapter targeting without losing orientation.",
+    {
+      project_id: z.string().describe("Project ID."),
+    },
+    async ({ project_id }) => {
+      const rows = db.prepare(`
+        SELECT chapter_id, project_id, title, sort_index, logline, metadata_stale
+        FROM chapters
+        WHERE project_id = ?
+        ORDER BY sort_index, chapter_id
+      `).all(project_id);
+
+      if (rows.length === 0) {
+        return errorResponse("NO_RESULTS", `No chapters found for project '${project_id}'.`);
+      }
+
+      return {
+        content: [{
+          type: "text",
+          text: JSON.stringify({
+            results: rows,
+            total_count: rows.length,
+          }, null, 2),
+        }],
+      };
+    }
+  );
+
+  // ---- find_epigraphs -----------------------------------------------------
+  s.tool(
+    "find_epigraphs",
+    "List canonical epigraphs for a project, optionally narrowed to a canonical chapter_id or compatibility chapter number.",
+    {
+      project_id: z.string().describe("Project ID."),
+      chapter_id: z.string().optional().describe("Canonical chapter identifier."),
+      chapter: z.number().int().optional().describe("Compatibility chapter number resolved from canonical sort order."),
+    },
+    async ({ project_id, chapter_id, chapter }) => {
+      const resolvedChapterFilter = (chapter_id || chapter != null)
+        ? resolveValidatedChapterFilter(db, { projectId: project_id, chapterNumber: chapter, chapterId: chapter_id })
+        : { chapter: null };
+      if (resolvedChapterFilter.error) {
+        return errorResponse(
+          resolvedChapterFilter.error.code,
+          resolvedChapterFilter.error.message,
+          {
+            project_id,
+            chapter_id: chapter_id ?? null,
+            chapter: chapter ?? null,
+          }
+        );
+      }
+      const resolvedChapter = resolvedChapterFilter.chapter;
+      if ((chapter_id || chapter != null) && !resolvedChapter) {
+        return errorResponse("NOT_FOUND", "Chapter not found for the provided epigraph filter.", {
+          project_id,
+          chapter_id: chapter_id ?? null,
+          chapter: chapter ?? null,
+        });
+      }
+
+      const rows = db.prepare(`
+        SELECT e.epigraph_id, e.project_id, e.chapter_id, c.title AS chapter_title, c.sort_index AS chapter,
+               e.body, e.metadata_stale
+        FROM epigraphs e
+        JOIN chapters c ON c.chapter_id = e.chapter_id AND c.project_id = e.project_id
+        WHERE e.project_id = ?
+          AND (? IS NULL OR e.chapter_id = ?)
+        ORDER BY c.sort_index, e.epigraph_id
+      `).all(project_id, resolvedChapter?.chapter_id ?? null, resolvedChapter?.chapter_id ?? null);
+
+      if (rows.length === 0) {
+        return errorResponse("NO_RESULTS", `No epigraphs found for project '${project_id}'.`);
+      }
+
+      return {
+        content: [{
+          type: "text",
+          text: JSON.stringify({
+            results: rows,
+            total_count: rows.length,
+          }, null, 2),
+        }],
+      };
+    }
+  );
+
   // ---- get_arc -------------------------------------------------------------
   s.tool(
     "get_arc",
@@ -532,7 +737,7 @@ export function registerSearchTools(s, {
 
       if (!shouldPaginate) {
         const rows = db.prepare(`
-          SELECT f.scene_id, f.project_id, s.title, s.logline, s.part, s.chapter, s.chapter_title, s.metadata_stale
+          SELECT f.scene_id, f.project_id, s.chapter_id, s.title, s.logline, s.part, s.chapter, s.chapter_title, s.metadata_stale
           FROM scenes_fts f
           JOIN scenes s ON s.scene_id = f.scene_id AND s.project_id = f.project_id
           WHERE scenes_fts MATCH ?
@@ -557,7 +762,7 @@ export function registerSearchTools(s, {
       const offset = (normalizedPage - 1) * safePageSize;
 
       const rows = db.prepare(`
-        SELECT f.scene_id, f.project_id, s.title, s.logline, s.part, s.chapter, s.chapter_title, s.metadata_stale
+        SELECT f.scene_id, f.project_id, s.chapter_id, s.title, s.logline, s.part, s.chapter, s.chapter_title, s.metadata_stale
         FROM scenes_fts f
         JOIN scenes s ON s.scene_id = f.scene_id AND s.project_id = f.project_id
         WHERE scenes_fts MATCH ?
@@ -853,7 +1058,7 @@ export function registerSearchTools(s, {
                st.beat AS thread_beat, s.timeline_position, s.story_time, s.metadata_stale
         FROM scenes s
         JOIN scene_threads st ON st.scene_id = s.scene_id AND st.project_id = s.project_id AND st.thread_id = ?
-        ORDER BY s.part, s.chapter, s.timeline_position
+        ORDER BY s.part, s.chapter, s.timeline_position, s.scene_id
       `).all(thread_id);
       const staleCount = rows.filter(r => r.metadata_stale).length;
       const warning = staleCount > 0 ? `${staleCount} scene(s) have stale metadata.` : undefined;
@@ -899,11 +1104,12 @@ export function registerSearchTools(s, {
                s.part, s.chapter, s.chapter_title, s.timeline_position, s.title AS scene_title
         FROM character_relationships r
         LEFT JOIN scenes s ON s.scene_id = r.scene_id
+          AND (r.scene_id IS NULL OR s.project_id = COALESCE(?, s.project_id))
         WHERE r.from_character = ? AND r.to_character = ?
       `;
-      const params = [from_character, to_character];
+      const params = [project_id ?? null, from_character, to_character];
       if (project_id) { query += ` AND (s.project_id = ? OR r.scene_id IS NULL)`; params.push(project_id); }
-      query += ` ORDER BY s.part, s.chapter, s.timeline_position`;
+      query += ` ORDER BY s.part, s.chapter, s.timeline_position, s.scene_id`;
 
       const rows = db.prepare(query).all(...params);
       if (rows.length === 0) {

package/src/tools/styleguide.js

@@ -383,6 +383,7 @@ export function registerStyleguideTools(s, {
       scene_ids: z.array(z.string()).optional().describe("Optional scene_id allowlist to analyze."),
       part: z.number().int().optional().describe("Optional part filter."),
       chapter: z.number().int().optional().describe("Optional chapter filter."),
+      chapter_id: z.string().optional().describe("Optional canonical chapter identifier."),
       max_scenes: z.number().int().positive().optional().describe("Maximum number of scenes to analyze (default: 50)."),
       min_agreement: z.number().min(0).max(1).optional().describe("Minimum agreement ratio for suggested fields (default: 0.6)."),
       min_evidence: z.number().int().positive().optional().describe("Minimum number of observed scenes per field before suggesting it (default: 3)."),
@@ -393,6 +394,7 @@ export function registerStyleguideTools(s, {
       scene_ids,
       part,
       chapter,
+      chapter_id,
       max_scenes = 50,
       min_agreement = 0.6,
       min_evidence = 3,
@@ -408,6 +410,7 @@ export function registerStyleguideTools(s, {
         sceneIds: scene_ids,
         part,
         chapter,
+        chapterId: chapter_id,
         onlyStale: false,
       });
       if (!targetResolution.ok) {
@@ -419,7 +422,7 @@ export function registerStyleguideTools(s, {
         return errorResponse(
           "NOT_FOUND",
           `No scenes were found for project '${project_id}' with the requested filters.`,
-          { project_id, scene_ids: scene_ids ?? null, part: part ?? null, chapter: chapter ?? null }
+          { project_id, scene_ids: scene_ids ?? null, part: part ?? null, chapter: chapter ?? null, chapter_id: chapter_id ?? null }
         );
       }
 
@@ -630,6 +633,7 @@ export function registerStyleguideTools(s, {
       scene_ids: z.array(z.string()).optional().describe("Optional scene_id allowlist to analyze."),
       part: z.number().int().optional().describe("Optional part filter."),
       chapter: z.number().int().optional().describe("Optional chapter filter."),
+      chapter_id: z.string().optional().describe("Optional canonical chapter identifier."),
       max_scenes: z.number().int().positive().optional().describe("Maximum number of scenes to analyze (default: 50)."),
       min_agreement: z.number().min(0).max(1).optional().describe("Minimum agreement ratio for suggested updates (default: 0.6)."),
       include_clean_scenes: z.boolean().optional().describe("If true, include scenes with no detected drift in scene_results."),
@@ -639,6 +643,7 @@ export function registerStyleguideTools(s, {
       scene_ids,
       part,
       chapter,
+      chapter_id,
       max_scenes = 50,
       min_agreement = 0.6,
       include_clean_scenes = false,
@@ -675,6 +680,7 @@ export function registerStyleguideTools(s, {
         sceneIds: scene_ids,
         part,
         chapter,
+        chapterId: chapter_id,
         onlyStale: false,
       });
       if (!targetResolution.ok) {

package/src/tools/sync.js

@@ -334,6 +334,7 @@ export function registerSyncTools(s, {
       scene_ids: z.array(z.string()).optional().describe("Optional allowlist of scene IDs to process before other filters are applied."),
       part: z.number().int().optional().describe("Optional part number filter."),
       chapter: z.number().int().optional().describe("Optional chapter number filter."),
+      chapter_id: z.string().optional().describe("Optional canonical chapter identifier."),
       only_stale: z.boolean().optional().describe("If true, only process scenes currently marked metadata_stale."),
       dry_run: z.boolean().optional().describe("If true (default), returns preview results without writing sidecars."),
       replace_mode: z.enum(["merge", "replace"]).optional().describe("merge (default): add inferred IDs; replace: overwrite characters with inferred IDs."),
@@ -346,6 +347,7 @@ export function registerSyncTools(s, {
       scene_ids,
       part,
       chapter,
+      chapter_id,
       only_stale = false,
       dry_run = true,
       replace_mode = "merge",
@@ -386,6 +388,7 @@ export function registerSyncTools(s, {
         sceneIds: scene_ids,
         part,
         chapter,
+        chapterId: chapter_id,
         onlyStale: Boolean(only_stale),
       });
       if (!targetResolution.ok) {