@hanna84/mcp-writing 2.12.3 → 2.12.4

package/CHANGELOG.md

@@ -4,11 +4,21 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
+#### [v2.12.4](https://github.com/hannasdev/mcp-writing.git
+/compare/v2.12.3...v2.12.4)
+
+- fix: detect no-op commit_edit proposals [`#117`](https://github.com/hannasdev/mcp-writing.git
+/pull/117)
+
 #### [v2.12.3](https://github.com/hannasdev/mcp-writing.git
 /compare/v2.12.2...v2.12.3)
 
+> 27 April 2026
+
 - docs: refine landing page copy and visuals [`#116`](https://github.com/hannasdev/mcp-writing.git
 /pull/116)
+- Release 2.12.3 [`97ed1f6`](https://github.com/hannasdev/mcp-writing.git
+/commit/97ed1f69fa2419dc0875792e048886d96e054cba)
 
 #### [v2.12.2](https://github.com/hannasdev/mcp-writing.git
 /compare/v2.12.1...v2.12.2)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hanna84/mcp-writing",
-  "version": "2.12.3",
+  "version": "2.12.4",
   "description": "MCP service for AI-assisted reasoning and editing on long-form fiction projects",
   "homepage": "https://hannasdev.github.io/mcp-writing/",
   "type": "module",

package/tools/editing.js

@@ -5,6 +5,14 @@ import yaml from "js-yaml";
 import { createSnapshot, listSnapshots } from "../git.js";
 import { getFileWriteDiagnostics, readMeta, indexSceneFile } from "../sync.js";
 
+function renderSceneContent(metadata, revisedProse) {
+  const hasFrontmatter = metadata && Object.keys(metadata).length > 0;
+  const normalizedProse = revisedProse.replace(/\r?\n$/, "");
+  return hasFrontmatter
+    ? `---\n${yaml.dump(metadata)}---\n\n${normalizedProse}\n`
+    : `${normalizedProse}\n`;
+}
+
 export function registerEditingTools(s, {
   db,
   SYNC_DIR,
@@ -36,6 +44,7 @@ export function registerEditingTools(s, {
       try {
         const raw = fs.readFileSync(scene.file_path, "utf8");
         const { data: metadata, content: currentProse } = matter(raw);
+        const renderedContent = renderSceneContent(metadata, revised_prose);
 
         const currentLines = currentProse.trim().split("\n");
         const revisedLines = revised_prose.trim().split("\n");
@@ -60,17 +69,28 @@ export function registerEditingTools(s, {
           scene_file_path: scene.file_path,
           instruction,
           revised_prose,
+          rendered_content: renderedContent,
           original_prose: currentProse,
           metadata,
           created_at: new Date().toISOString(),
         });
 
+        const noop = renderedContent === raw;
+        const diffPreview = noop
+          ? "(no changes)"
+          : diffLines.length > 0
+            ? diffLines.join("\n")
+            : "(file changes are not visible in the prose preview; they may be due to frontmatter or whitespace/newline formatting)";
+
         return jsonResponse({
           proposal_id: proposalId,
           scene_id,
           instruction,
-          diff_preview: diffLines.join("\n"),
-          note: "Review the diff above. Call commit_edit with this proposal_id to apply the change.",
+          diff_preview: diffPreview,
+          noop,
+          note: noop
+            ? "This proposal matches the current scene file. Calling commit_edit will be a no-op."
+            : "Review the diff above. Call commit_edit with this proposal_id to apply the change.",
         });
       } catch (err) {
         if (err.code === "ENOENT") {
@@ -152,10 +172,24 @@ export function registerEditingTools(s, {
           );
         }
 
-        const hasFrontmatter = proposal.metadata && Object.keys(proposal.metadata).length > 0;
-        const content = hasFrontmatter
-          ? `---\n${yaml.dump(proposal.metadata)}---\n\n${proposal.revised_prose}\n`
-          : `${proposal.revised_prose}\n`;
+        const content = proposal.rendered_content ?? renderSceneContent(proposal.metadata, proposal.revised_prose);
+        const currentRaw = fs.readFileSync(proposal.scene_file_path, "utf8");
+
+        if (currentRaw === content) {
+          const { meta: canonicalMeta } = readMeta(proposal.scene_file_path, SYNC_DIR, { writable: false });
+          const { content: currentProse } = matter(currentRaw);
+          indexSceneFile(db, SYNC_DIR, proposal.scene_file_path, canonicalMeta, currentProse);
+          pendingProposals.delete(proposal_id);
+
+          return jsonResponse({
+            ok: true,
+            scene_id,
+            proposal_id,
+            snapshot_commit: null,
+            noop: true,
+            message: `Proposal for scene '${scene_id}' matches the current file. Nothing was written.`,
+          });
+        }
 
         const snapshot = createSnapshot(SYNC_DIR, proposal.scene_file_path, scene_id, proposal.instruction);
 
@@ -172,7 +206,8 @@ export function registerEditingTools(s, {
           scene_id,
           proposal_id,
           snapshot_commit: snapshot.commit_hash,
-          message: `Committed edit for scene '${scene_id}'${snapshot.commit_hash ? ` (snapshot: ${snapshot.commit_hash.substring(0, 7)})` : " (no changes to snapshot)"}`,
+          noop: false,
+          message: `Applied edit to scene '${scene_id}'${snapshot.commit_hash ? ` (snapshot: ${snapshot.commit_hash.substring(0, 7)})` : " (no pre-edit snapshot needed)"}`,
         });
       } catch (err) {
         if (err.code === "ENOENT") {