@hank-warren/pi-auto-permissions 0.5.1 → 0.6.1

package/CHANGELOG.md

@@ -0,0 +1,30 @@
+# @hank-warren/pi-auto-permissions
+
+## 0.6.1
+
+### Patch Changes
+
+- cf12677: ship CHANGELOG.md in the published tarball
+- Updated dependencies [cf12677]
+  - @hank-warren/pi-permission-selector@1.0.1
+
+## 0.6.0
+
+### Minor Changes
+
+- 500fe67: Remove the `ExtensionSelectorComponent` monkey patch; compose `OptionSelector` explicitly (spec §9.4).
+
+  `pi-permission-selector` is now a **pure library**: it no longer registers an extension, patches nothing, and standalone installs do nothing — the reason for the major bump. `selector-patch.ts` and `index.ts` are deleted; `keys.ts` and `selector.ts` remain the frozen cross-package surface. Dialogs this repo does not own (pi's model/theme/session pickers, third-party extensions) revert to stock arrows+Enter, an accepted trade-off (spec §9.3): nothing here breaks when a pi upgrade changes selector internals.
+
+  `pi-auto-permissions` renders both of its prompts — the guardian approval prompt and the `request_override` prompt — through `ctx.ui.custom()` with the shared `OptionSelector` from `@hank-warren/pi-permission-selector` (a new plain dependency), instead of `ctx.ui.select` plus the global patch. Behavior is preserved: numbered options with `1`–`9` hotkeys, Tab-to-comment on the approval prompt (the note is still delivered as a steering user message, now by pi-auto-permissions itself), exact legacy option strings for `classifyPromptChoice`, and Herdr blocked-state bracketing. Cancellation semantics match `ctx.ui.select`: Esc, abort of the prompt signal, and a host that cannot render custom UI all resolve `undefined`, which every caller treats as deny/cancel — never allow.
+
+### Patch Changes
+
+- Updated dependencies [500fe67]
+  - @hank-warren/pi-permission-selector@1.0.0
+
+## 0.5.1
+
+### Patch Changes
+
+- 67abcf5: document the optional `HERDR_ENV` herdr pane blocked indicator

package/README.md

@@ -143,7 +143,7 @@ The guardian must return one of three decisions:
 
 - `approve`: execute the command
 - `revise`: block it and tell the main agent what to correct
-- `ask_user`: open Pi's normal confirmation prompt
+- `ask_user`: open an approval prompt (rendered with [`@hank-warren/pi-permission-selector`](../pi-permission-selector)'s `OptionSelector`): numbered options with `1`–`9` hotkeys, Tab to attach a note that is delivered to the agent as a steering user message, Esc to cancel — which blocks the command
 
 ## Conversation context and caching
 

package/index.ts

@@ -37,6 +37,7 @@ import {
   type ReviewEvidenceRecord,
 } from "./review.js";
 import { mergeOverrideEvidence, type PermissionOverride } from "./override-evidence.js";
+import { OptionSelector } from "@hank-warren/pi-permission-selector/selector.ts";
 
 const WIDGET_KEY = "auto-permissions";
 const PROJECT_CONFIG_DIR_NAME = (PiCodingAgent as { CONFIG_DIR_NAME?: string }).CONFIG_DIR_NAME ?? ".pi";
@@ -653,6 +654,61 @@ export default function autoPermissionsExtension(pi: ExtensionAPI) {
     }
   }
 
+  /**
+   * Render an approval prompt with the shared `OptionSelector` through
+   * `ctx.ui.custom()` (non-overlay, so it swaps into the editor area exactly
+   * where `ctx.ui.select` used to render).
+   *
+   * Cancellation parity with `ctx.ui.select` — all of these resolve
+   * `undefined`, which every caller must treat as deny/cancel, never allow:
+   * - Esc (`OptionSelector.onCancel`)
+   * - `signal` abort (listener calls `done(undefined)`; pi's `done` is
+   *   idempotent and performs its own teardown, so nothing else is needed)
+   * - a host that reports `hasUI` but cannot render custom components
+   *
+   * A Tab-typed note is delivered to the agent as a steering user message,
+   * matching what the retired `ExtensionSelectorComponent` monkey patch in
+   * pi-permission-selector did.
+   */
+  function promptSelect(
+    ctx: ExtensionContext,
+    title: string,
+    values: string[],
+    signal: AbortSignal,
+    opts: { allowComment: boolean },
+  ): Promise<string | undefined> {
+    return ctx.ui.custom<string | undefined>((tui, theme, _keybindings, done) => {
+      const onAbort = () => finish(undefined);
+      const finish = (result: string | undefined) => {
+        signal.removeEventListener("abort", onAbort);
+        done(result);
+      };
+      const selector = new OptionSelector({
+        title,
+        options: values.map((value) => ({ value, label: value })),
+        allowComment: opts.allowComment,
+        theme,
+        onSelect: (option, comment) => {
+          if (comment) {
+            try {
+              pi.sendUserMessage(comment, { deliverAs: "steer" });
+            } catch {
+              // Never let note delivery break the approval flow.
+            }
+          }
+          finish(option.value);
+        },
+        onCancel: () => finish(undefined),
+        requestRender: () => tui.requestRender(),
+      });
+      // `done` before the factory resolves is safe: pi marks the dialog closed
+      // and never mounts the component.
+      if (signal.aborted) onAbort();
+      else signal.addEventListener("abort", onAbort, { once: true });
+      return selector;
+    });
+  }
+
   async function askUser(
     gate: Gate,
     command: string,
@@ -695,10 +751,12 @@ export default function autoPermissionsExtension(pi: ExtensionAPI) {
     try {
       let choice: string | undefined;
       try {
-        choice = await ctx.ui.select(
+        choice = await promptSelect(
+          ctx,
           `${gate.label} — Auto Permissions needs approval\n\n${detail}\n\n${command}`,
           permissionPromptOptions(config.evaluationLog.enabled),
-          { signal: promptSignal },
+          promptSignal,
+          { allowComment: true },
         );
       } catch (error) {
         if (!lifecycleStale() && !reviewCancelled(signal)) throw error;
@@ -879,10 +937,14 @@ export default function autoPermissionsExtension(pi: ExtensionAPI) {
       try {
         let choice: string | undefined;
         try {
-          choice = await ctx.ui.select(
+          // The override prompt never had Tab-to-comment (the monkey patch only
+          // enabled it on titles matching /needs approval/i), so keep parity.
+          choice = await promptSelect(
+            ctx,
             `Convention override: ${gate.label}\n\n${params.reason}\n\n${params.command}`,
             ["Allow for this session", "Keep blocked"],
-            { signal: promptSignal },
+            promptSignal,
+            { allowComment: false },
           );
         } catch (error) {
           if (!lifecycleStale() && !reviewCancelled(signal)) throw error;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hank-warren/pi-auto-permissions",
-  "version": "0.5.1",
+  "version": "0.6.1",
   "description": "Fork of @ogulcancelik/pi-auto-permissions with dialog-answer user evidence: context-aware Bash permissions for Pi with automated guardian review.",
   "type": "module",
   "keywords": [
@@ -49,8 +49,12 @@
     "usage-log.ts",
     "widget-status.ts",
     "README.md",
-    "LICENSE"
+    "LICENSE",
+    "CHANGELOG.md"
   ],
+  "dependencies": {
+    "@hank-warren/pi-permission-selector": "^1.0.1"
+  },
   "peerDependencies": {
     "@earendil-works/pi-ai": "*",
     "@earendil-works/pi-coding-agent": "*",