@hank-warren/pi-auto-permissions 0.5.0 → 0.6.0

package/README.md

@@ -143,7 +143,7 @@ The guardian must return one of three decisions:
 
 - `approve`: execute the command
 - `revise`: block it and tell the main agent what to correct
-- `ask_user`: open Pi's normal confirmation prompt
+- `ask_user`: open an approval prompt (rendered with [`@hank-warren/pi-permission-selector`](../pi-permission-selector)'s `OptionSelector`): numbered options with `1`–`9` hotkeys, Tab to attach a note that is delivered to the agent as a steering user message, Esc to cancel — which blocks the command
 
 ## Conversation context and caching
 
@@ -264,6 +264,12 @@ $ git commit --dry-run -m "fix auth"
 
 Set `ui.enabled` to `false` to hide review state without disabling enforcement.
 
+### Herdr pane indicator
+
+When the environment variable `HERDR_ENV` is set to exactly `1`, the extension additionally emits a `herdr:blocked` event whenever a command is waiting on your approval, and a matching cleared event once the review resolves. [Herdr](https://herdr.dev), a terminal multiplexer for coding agents, sets this variable for the panes it manages and uses the event to flag the pane that needs attention — useful when a review is blocking in a pane you are not currently looking at. The blocked event carries the gate label so the indicator can name the operation.
+
+This is an optional integration and nothing needs to be configured to use it. Outside Herdr the variable is unset, the emit is skipped entirely, and every other feature behaves identically; the extension has no dependency on Herdr being installed.
+
 ## Trusted groups
 
 In a trusted project, create `.pi/trusted-ops` to bypass selected rule groups:

package/index.ts

@@ -37,6 +37,7 @@ import {
   type ReviewEvidenceRecord,
 } from "./review.js";
 import { mergeOverrideEvidence, type PermissionOverride } from "./override-evidence.js";
+import { OptionSelector } from "@hank-warren/pi-permission-selector/selector.ts";
 
 const WIDGET_KEY = "auto-permissions";
 const PROJECT_CONFIG_DIR_NAME = (PiCodingAgent as { CONFIG_DIR_NAME?: string }).CONFIG_DIR_NAME ?? ".pi";
@@ -653,6 +654,61 @@ export default function autoPermissionsExtension(pi: ExtensionAPI) {
     }
   }
 
+  /**
+   * Render an approval prompt with the shared `OptionSelector` through
+   * `ctx.ui.custom()` (non-overlay, so it swaps into the editor area exactly
+   * where `ctx.ui.select` used to render).
+   *
+   * Cancellation parity with `ctx.ui.select` — all of these resolve
+   * `undefined`, which every caller must treat as deny/cancel, never allow:
+   * - Esc (`OptionSelector.onCancel`)
+   * - `signal` abort (listener calls `done(undefined)`; pi's `done` is
+   *   idempotent and performs its own teardown, so nothing else is needed)
+   * - a host that reports `hasUI` but cannot render custom components
+   *
+   * A Tab-typed note is delivered to the agent as a steering user message,
+   * matching what the retired `ExtensionSelectorComponent` monkey patch in
+   * pi-permission-selector did.
+   */
+  function promptSelect(
+    ctx: ExtensionContext,
+    title: string,
+    values: string[],
+    signal: AbortSignal,
+    opts: { allowComment: boolean },
+  ): Promise<string | undefined> {
+    return ctx.ui.custom<string | undefined>((tui, theme, _keybindings, done) => {
+      const onAbort = () => finish(undefined);
+      const finish = (result: string | undefined) => {
+        signal.removeEventListener("abort", onAbort);
+        done(result);
+      };
+      const selector = new OptionSelector({
+        title,
+        options: values.map((value) => ({ value, label: value })),
+        allowComment: opts.allowComment,
+        theme,
+        onSelect: (option, comment) => {
+          if (comment) {
+            try {
+              pi.sendUserMessage(comment, { deliverAs: "steer" });
+            } catch {
+              // Never let note delivery break the approval flow.
+            }
+          }
+          finish(option.value);
+        },
+        onCancel: () => finish(undefined),
+        requestRender: () => tui.requestRender(),
+      });
+      // `done` before the factory resolves is safe: pi marks the dialog closed
+      // and never mounts the component.
+      if (signal.aborted) onAbort();
+      else signal.addEventListener("abort", onAbort, { once: true });
+      return selector;
+    });
+  }
+
   async function askUser(
     gate: Gate,
     command: string,
@@ -695,10 +751,12 @@ export default function autoPermissionsExtension(pi: ExtensionAPI) {
     try {
       let choice: string | undefined;
       try {
-        choice = await ctx.ui.select(
+        choice = await promptSelect(
+          ctx,
           `${gate.label} — Auto Permissions needs approval\n\n${detail}\n\n${command}`,
           permissionPromptOptions(config.evaluationLog.enabled),
-          { signal: promptSignal },
+          promptSignal,
+          { allowComment: true },
         );
       } catch (error) {
         if (!lifecycleStale() && !reviewCancelled(signal)) throw error;
@@ -879,10 +937,14 @@ export default function autoPermissionsExtension(pi: ExtensionAPI) {
       try {
         let choice: string | undefined;
         try {
-          choice = await ctx.ui.select(
+          // The override prompt never had Tab-to-comment (the monkey patch only
+          // enabled it on titles matching /needs approval/i), so keep parity.
+          choice = await promptSelect(
+            ctx,
             `Convention override: ${gate.label}\n\n${params.reason}\n\n${params.command}`,
             ["Allow for this session", "Keep blocked"],
-            { signal: promptSignal },
+            promptSignal,
+            { allowComment: false },
           );
         } catch (error) {
           if (!lifecycleStale() && !reviewCancelled(signal)) throw error;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hank-warren/pi-auto-permissions",
-  "version": "0.5.0",
+  "version": "0.6.0",
   "description": "Fork of @ogulcancelik/pi-auto-permissions with dialog-answer user evidence: context-aware Bash permissions for Pi with automated guardian review.",
   "type": "module",
   "keywords": [
@@ -51,6 +51,9 @@
     "README.md",
     "LICENSE"
   ],
+  "dependencies": {
+    "@hank-warren/pi-permission-selector": "^1.0.0"
+  },
   "peerDependencies": {
     "@earendil-works/pi-ai": "*",
     "@earendil-works/pi-coding-agent": "*",