@hank-warren/pi-auto-permissions 0.17.0 → 0.19.0

package/settings-command.ts

@@ -40,8 +40,8 @@ export function registerSettingsCommand(
   { overrides, reviewer }: { overrides: SessionOverrides; reviewer: GuardianReviewer },
 ): void {
   /**
-   * `/auto-permissions`: edit the reviewer model, thinking level, timeout and
-   * the enabled flag without hand-editing config.json.
+   * `/auto-permissions`: edit the reviewer model, thinking level, timeout,
+   * parallel reviews and the enabled flag without hand-editing config.json.
    *
    * There is no live-apply step: every tool call re-reads the config through
    * currentConfig(), so a saved edit is in force immediately -- in this session
@@ -76,6 +76,7 @@ export function registerSettingsCommand(
         settings = {
           enabled: config.enabled,
           reviewer: config.reviewer,
+          reviewConcurrency: config.reviewConcurrency,
           systemPromptSource: config.systemPromptSource,
         };
         denialLog = config.denialLog;
@@ -97,7 +98,14 @@ export function registerSettingsCommand(
         const previous = settings;
         settings = change.settings;
         try {
-          patchAutoPermissionsConfig(path, { enabled: settings.enabled, reviewer: settings.reviewer });
+          patchAutoPermissionsConfig(path, {
+            enabled: settings.enabled,
+            reviewer: settings.reviewer,
+            // Only when this edit changed it, so a hand-written value is never rewritten by an unrelated save.
+            ...(settings.reviewConcurrency !== previous.reviewConcurrency
+              ? { reviewConcurrency: settings.reviewConcurrency }
+              : {}),
+          });
         } catch (error) {
           settings = previous;
           const message = error instanceof Error ? error.message : String(error);
@@ -128,7 +136,7 @@ export function registerSettingsCommand(
             ts: record.ts,
             gateLabel: record.gate.label,
             command: record.command,
-            verdict: record.verdict,
+            verdict: record.reviseFirst ? "revise first" : record.verdict,
             reason: record.reason,
           }));
         } catch {

package/settings-menu.ts

@@ -20,6 +20,7 @@ import {
 import {
   DEFAULT_REVIEWER_REASONING_EFFORT,
   DEFAULT_REVIEWER_TIMEOUT_MS,
+  MAX_REVIEW_CONCURRENCY,
   MAX_REVIEWER_TIMEOUT_MS,
   MIN_REVIEWER_TIMEOUT_MS,
   REASONING_EFFORTS,
@@ -32,6 +33,7 @@ const ENABLED_ID = "enabled";
 const REVIEWER_MODEL_ID = "reviewerModel";
 const THINKING_LEVEL_ID = "reasoningEffort";
 const TIMEOUT_ID = "timeoutMs";
+const REVIEW_CONCURRENCY_ID = "reviewConcurrency";
 const SYSTEM_PROMPT_ID = "systemPrompt";
 export const RECENT_DENIALS_ID = "recentDenials";
 
@@ -47,9 +49,20 @@ const NO_REVIEWER_MESSAGE = "Select a reviewer model first";
 export interface ReviewerSettings {
   enabled: boolean;
   reviewer?: ReviewerConfig;
+  reviewConcurrency: number;
   systemPromptSource: SystemPromptSource;
 }
 
+const CONCURRENCY_PRESETS = [1, 2, 4, 8, 16];
+
+/**
+ * The values the parallel-reviews row cycles through. A hand-written value
+ * outside the presets is kept in the cycle, so opening the menu never moves it.
+ */
+export function concurrencyValues(current: number): string[] {
+  return [...new Set([...CONCURRENCY_PRESETS, current])].sort((a, b) => a - b).map(String);
+}
+
 /** The subset of a pi model the menu needs; keeps tests free of pi-ai types. */
 export interface MenuModel {
   provider: string;
@@ -177,6 +190,13 @@ export function buildSettingItems(
       currentValue: formatTimeout(timeoutValue(settings)),
       ...(submenus.timeout ? { submenu: submenus.timeout } : {}),
     },
+    {
+      id: REVIEW_CONCURRENCY_ID,
+      label: "Parallel reviews",
+      description: "How many guardian reviews may run at once. 1 reviews one command at a time, none ahead of its turn.",
+      currentValue: String(settings.reviewConcurrency),
+      values: concurrencyValues(settings.reviewConcurrency),
+    },
     {
       id: SYSTEM_PROMPT_ID,
       label: "System prompt",
@@ -241,6 +261,15 @@ export function applySettingChange(
     return { kind: "settings", settings: next };
   }
 
+  if (id === REVIEW_CONCURRENCY_ID) {
+    const reviewConcurrency = Number(value);
+    if (!Number.isInteger(reviewConcurrency) || reviewConcurrency < 1 || reviewConcurrency > MAX_REVIEW_CONCURRENCY) {
+      return { kind: "error", message: `Parallel reviews must be a whole number from 1 to ${MAX_REVIEW_CONCURRENCY}` };
+    }
+    if (reviewConcurrency === settings.reviewConcurrency) return { kind: "ignored" };
+    return { kind: "settings", settings: { ...settings, reviewConcurrency } };
+  }
+
   // The model and timeout submenus commit their own edit and hand back display
   // text, so there is nothing left to map here.
   return { kind: "ignored" };

package/subagent-context.ts

@@ -4,16 +4,16 @@ import { isAbsolute, join } from "node:path";
 /**
  * Runtime facts about a subagent child session, forwarded to the guardian as
  * evidence. Facts only — the guardian judges what they imply; see
- * SUBAGENT_CONTEXT_SYSTEM_PROMPT in review.ts.
+ * subagentContextSystemPrompt() in review.ts.
  *
- * Detection is based on the environment contract of `pi-subagents`
- * (nicobailon/pi-subagents), which spawns children with `PI_SUBAGENT_CHILD=1`
- * plus run id and nesting depth. Absent that env, sessions are treated as
- * ordinary sessions and review behavior is unchanged.
+ * Detection is based on the environment contract that `@hank-warren/pi-agents`
+ * and `pi-subagents` (nicobailon/pi-subagents) both use: children are spawned
+ * with `PI_SUBAGENT_CHILD=1` plus run id and nesting depth. Absent that env,
+ * sessions are treated as ordinary sessions and review behavior is unchanged.
  */
 export interface SubagentExecutionContext {
   subagent: true;
-  /** pi-subagents run id (PI_SUBAGENT_RUN_ID), when present. */
+  /** The subagent's run id (PI_SUBAGENT_RUN_ID), when present. */
   runId?: string;
   /** Nesting depth for nested subagents (PI_SUBAGENT_DEPTH), when > 0. */
   depth?: number;

package/widget-status.ts

@@ -30,10 +30,10 @@ export function reviewStatusFrame(
 ): ReviewStatusFrame {
   const index = Math.max(0, Math.floor(frameIndex));
   switch (state) {
-    // Static rather than animated: the row is replaced by `waiting` the moment
-    // the queue hands over, so a spinner here would promise progress the
-    // command is not making. It exists so a second guarded command in one turn
-    // renders *something* instead of a blank gap while it waits its turn.
+    // Static rather than animated: the row is replaced the moment the command
+    // gets its slot, so a spinner here would promise progress the command is
+    // not making. It exists so a guarded command waiting for a review slot or
+    // for another command's decision renders *something* instead of a blank gap.
     case "queued":
       return {
         glyph: "⋯",
@@ -61,6 +61,19 @@ export function reviewFrameIntervalMs(state: ReviewDisplayState): number | undef
   return state === "waiting" ? WAITING_FRAME_INTERVAL_MS : undefined;
 }
 
+/** The states a review is still in while it has not settled. */
+export type ActiveReviewState = Extract<ReviewDisplayState, "queued" | "waiting" | "ask_user">;
+
+export function isActiveReviewState(state: ReviewDisplayState): state is ActiveReviewState {
+  return state === "queued" || state === "waiting" || state === "ask_user";
+}
+
+export interface ReviewSummaryCounts {
+  waiting: number;
+  queued: number;
+  askUser: number;
+}
+
 export interface ReviewLinePalette {
   header: (text: string) => string;
   muted: (text: string) => string;
@@ -91,3 +104,27 @@ export function reviewStatusLines(
   if (detail) lines.push(palette.muted(detail));
   return lines;
 }
+
+/**
+ * One line for several unsettled reviews at once. Per-command detail is left
+ * out: each command is visible in its own tool box, and an approval prompt
+ * carries its own reason.
+ */
+export function reviewSummaryLines(
+  counts: ReviewSummaryCounts,
+  reviewer: string,
+  frameIndex: number,
+  palette: ReviewLinePalette,
+): string[] {
+  const total = counts.waiting + counts.queued + counts.askUser;
+  const parts: string[] = [];
+  if (counts.waiting > 0) {
+    const frame = reviewStatusFrame("waiting", reviewer, frameIndex);
+    parts.push(palette.warning(`${frame.glyph} ${counts.waiting} ${frame.label}`));
+  }
+  if (counts.queued > 0) parts.push(palette.muted(`⋯ ${counts.queued} queued`));
+  if (counts.askUser > 0) parts.push(palette.accent(`? ${counts.askUser} waiting for your approval`));
+  return [
+    `${palette.header("auto permissions")} ${palette.muted(`· ${total} commands ·`)} ${parts.join(palette.muted(" · "))}`,
+  ];
+}