@hank-warren/pi-ask-user-question 0.5.1 → 0.5.3

package/CHANGELOG.md

@@ -1,5 +1,36 @@
 # @hank-warren/pi-ask-user-question
 
+## 0.5.3
+
+### Patch Changes
+
+- 36230c0: Let option labels grow, and wrap descriptions instead of cutting them off.
+
+  `ask_user_question` no longer rejects a questionnaire because an option label
+  is longer than 60 characters. The renderer already wraps label rows and clamps
+  every line to the box's inner width, so the cap could only ever discard a
+  questionnaire that would have rendered fine. Label length is now guidance in
+  the schema description rather than a gate; an empty or whitespace-only label
+  takes its place as the fatal case, and `header`'s 16-character cap is
+  unchanged.
+
+  The shared `OptionSelector` now wraps long option descriptions at the row's
+  continuation indent instead of truncating them with an ellipsis.
+
+- Updated dependencies [36230c0]
+  - @hank-warren/pi-permission-selector@1.4.0
+
+## 0.5.2
+
+### Patch Changes
+
+- 3fbf632: Make backspace delete a whole character rather than half a surrogate pair. Both text-entry surfaces sliced UTF-16 code units, so one backspace after an emoji left a lone surrogate — an ill-formed string that was then submitted as an approval note or a free-text answer.
+
+  `pi-permission-selector` adds a code-point-aware `removeLastCharacter` export (additive; the frozen shared surface gains a name and loses none), and `pi-ask-user-question` uses it for the custom-answer field.
+
+- Updated dependencies [3fbf632]
+  - @hank-warren/pi-permission-selector@1.3.0
+
 ## 0.5.1
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hank-warren/pi-ask-user-question",
-  "version": "0.5.1",
+  "version": "0.5.3",
   "description": "Structured questionnaire tool for Pi with numbered options, digit hotkeys and Tab-to-comment, composed from the shared permission-selector component.",
   "type": "module",
   "keywords": [
@@ -46,7 +46,7 @@
     "CHANGELOG.md"
   ],
   "dependencies": {
-    "@hank-warren/pi-permission-selector": "^1.2.0"
+    "@hank-warren/pi-permission-selector": "^1.4.0"
   },
   "peerDependencies": {
     "@earendil-works/pi-coding-agent": "*",

package/tool/schema.ts

@@ -27,7 +27,6 @@ export const maxOptionsFor = (multiSelect?: boolean): number =>
 	multiSelect ? MAX_MULTI_OPTIONS : MAX_OPTIONS;
 
 export const MAX_HEADER_LENGTH = 16;
-export const MAX_LABEL_LENGTH = 60;
 
 /**
  * Labels the model may not author, because the dialog appends its own
@@ -46,7 +45,7 @@ export const MULTI_SELECT_JOIN = ", ";
 export const OptionSchema = Type.Object({
 	label: Type.String({
 		description:
-			"MAX 60 CHARACTERS — hard limit, requests over the limit are rejected. The display text for this option that the user will see and select. Should be concise (1-5 words) and clearly describe the choice.",
+			"The display text for this option that the user will see and select. Aim for 1-5 words, but there is no hard limit: a longer label is fine when it genuinely helps, and long labels wrap in the dialog rather than being rejected.",
 	}),
 	description: Type.String({
 		description:

package/tool/validate.ts

@@ -2,8 +2,12 @@
  * Parameter validation for `ask_user_question`. Pure — no pi imports, no I/O.
  *
  * typebox enforces structure (array bounds, required fields, types). This
- * module enforces the semantic rules typebox cannot express: length caps that
- * the model routinely overshoots, reserved sentinel labels, and duplicates.
+ * module enforces the semantic rules typebox cannot express: the header chip's
+ * length cap, non-empty text, reserved sentinel labels, and duplicates.
+ *
+ * Option labels are deliberately uncapped: the renderer wraps them and clamps
+ * its own lines, so a length rule could only ever discard a questionnaire that
+ * would have rendered fine.
  *
  * Violations return a structured error that becomes a normal tool error the
  * model can read and retry against — never a thrown exception, which would
@@ -13,7 +17,6 @@
 import {
 	type AskUserParams,
 	MAX_HEADER_LENGTH,
-	MAX_LABEL_LENGTH,
 	MAX_QUESTIONS,
 	maxOptionsFor,
 	MIN_OPTIONS,
@@ -25,7 +28,7 @@ export type ValidationCode =
 	| "bad_question_count"
 	| "bad_option_count"
 	| "header_too_long"
-	| "label_too_long"
+	| "empty_label"
 	| "reserved_label"
 	| "duplicate_label"
 	| "empty_question";
@@ -84,11 +87,8 @@ export function validateParams(params: AskUserParams): ValidationError | undefin
 		for (let j = 0; j < q.options.length; j++) {
 			const option = q.options[j];
 			const at = `${where}.options[${j}]`;
-			if (option.label.length > MAX_LABEL_LENGTH) {
-				return {
-					code: "label_too_long",
-					message: `${at}.label is ${option.label.length} characters; the hard limit is ${MAX_LABEL_LENGTH}.`,
-				};
+			if (!option.label?.trim()) {
+				return { code: "empty_label", message: `${at}.label must not be empty.` };
 			}
 			if (isReserved(option.label)) {
 				return {

package/view/dialog.ts

@@ -49,6 +49,7 @@ import {
 	isRightKey,
 	isShiftTabKey,
 	isTabKey,
+	removeLastCharacter,
 } from "@hank-warren/pi-permission-selector/keys.ts";
 import { OptionSelector, type SelectorOption } from "@hank-warren/pi-permission-selector/selector.ts";
 import {
@@ -426,7 +427,9 @@ export class QuestionnaireDialog {
 			return;
 		}
 		if (isBackspaceKey(keyData)) {
-			tab.customText = tab.customText.slice(0, -1);
+			// Code-point aware: a UTF-16 slice would split a surrogate pair and
+			// leave a lone surrogate in the answer that reaches the model.
+			tab.customText = removeLastCharacter(tab.customText);
 			this.repaint();
 			return;
 		}