@handlewithcare/react-prosemirror 3.1.0-tiptap.40 → 3.1.0-tiptap.41

package/README.md

@@ -35,7 +35,7 @@ npm install @handlewithcare/react-prosemirror \
     react@^19.1.0 \
     react-dom@^19.1.0 \
     react-reconciler@0.32.0 \
-    prosemirror-view@1.39.2 \
+    prosemirror-view@1.41.7 \
     prosemirror-state \
     prosemirror-model
 ```
@@ -47,7 +47,7 @@ yarn add @handlewithcare/react-prosemirror \
     react@^19.1.0 \
     react-dom@^19.1.0 \
     react-reconciler@0.32.0 \
-    prosemirror-view@1.39.2 \
+    prosemirror-view@1.41.7 \
     prosemirror-state \
     prosemirror-model
 ```

package/dist/cjs/ReactEditorView.js

@@ -129,7 +129,7 @@ let ReactEditorView = class ReactEditorView extends _prosemirrorview.EditorView
             return undefined;
         }
         const prop = this.props[propName];
-        if (prop) {
+        if (prop != null) {
             const result = f ? f(prop) : prop;
             if (result) {
                 return result;
@@ -137,7 +137,7 @@ let ReactEditorView = class ReactEditorView extends _prosemirrorview.EditorView
         }
         for (const plugin of this.props.plugins ?? []){
             const prop = plugin.props[propName];
-            if (prop) {
+            if (prop != null) {
                 const result = f ? f(prop) : prop;
                 if (result) {
                     return result;
@@ -146,7 +146,7 @@ let ReactEditorView = class ReactEditorView extends _prosemirrorview.EditorView
         }
         for (const plugin of this.state.plugins){
             const prop = plugin.props[propName];
-            if (prop) {
+            if (prop != null) {
                 const result = f ? f(prop) : prop;
                 if (result) {
                     return result;

package/dist/cjs/StaticEditorView.js

@@ -46,7 +46,7 @@ let StaticEditorView = class StaticEditorView {
     }
     someProp(propName, f) {
         const prop = this.props[propName];
-        if (prop) {
+        if (prop != null) {
             const result = f ? f(prop) : prop;
             if (result) {
                 return result;
@@ -54,7 +54,7 @@ let StaticEditorView = class StaticEditorView {
         }
         for (const plugin of this.props.plugins ?? []){
             const prop = plugin.props[propName];
-            if (prop) {
+            if (prop != null) {
                 const result = f ? f(prop) : prop;
                 if (result) {
                     return result;
@@ -63,7 +63,7 @@ let StaticEditorView = class StaticEditorView {
         }
         for (const plugin of this.state.plugins){
             const prop = plugin.props[propName];
-            if (prop) {
+            if (prop != null) {
                 const result = f ? f(prop) : prop;
                 if (result) {
                     return result;

package/dist/cjs/components/SeparatorHackView.js

@@ -76,7 +76,8 @@ function SeparatorHackView(param) {
     // we call setShouldRender conditionally
     // eslint-disable-next-line react-hooks/exhaustive-deps
     (0, _useClientLayoutEffect.useClientLayoutEffect)(()=>{
-        const lastSibling = siblingsRef.current[siblingsRef.current.length - 1];
+        const nonHackSiblings = siblingsRef.current.filter((viewdesc)=>!(viewdesc instanceof _viewdesc.TrailingHackViewDesc));
+        const lastSibling = nonHackSiblings[nonHackSiblings.length - 1];
         if ((_browser.browser.safari || _browser.browser.chrome) && lastSibling?.dom?.contentEditable == "false") {
             setShouldRender(true);
             return;
@@ -95,6 +96,7 @@ function SeparatorHackView(param) {
     });
     return shouldRender ? /*#__PURE__*/ _react.default.createElement("img", {
         ref: ref,
-        className: "ProseMirror-separator"
+        className: "ProseMirror-separator",
+        alt: ""
     }) : null;
 }

package/dist/cjs/hooks/useNodeViewDescription.js

@@ -121,7 +121,21 @@ function useNodeViewDescription(getDOM, getContentDOM, constructor, props) {
         if (!siblings.includes(viewDesc)) {
             siblings.push(viewDesc);
         }
+        // In strict/concurrent mode, a node can sometimes re-render
+        // entirely on its own, without even its parent re-rendering.
+        // In this case, we will have added our view descriptions to
+        // our parent's children, but our parent has no opportunity
+        // to sort its children, because it never renders. So
+        // we always sort our siblings, too.
         siblings.sort(_viewdesc.sortViewDescs);
+        // If a child updates, usually it will re-render and sort
+        // our children for us. But it's possible to reorder
+        // child nodes without changing their keys or node
+        // instances, in which case our children _won't_
+        // rerender. As a fallback, we do one last pass through
+        // our own child view descriptions and make sure
+        // they're ordered. This should be a cheap no-op in most cases.
+        children.sort(_viewdesc.sortViewDescs);
         for (const child of children){
             child.parent = viewDesc;
             // Because TextNodeViews can't locate the DOM nodes

package/dist/esm/ReactEditorView.js

@@ -129,7 +129,7 @@ function changedNodeViews(a, b) {
             return undefined;
         }
         const prop = this.props[propName];
-        if (prop) {
+        if (prop != null) {
             const result = f ? f(prop) : prop;
             if (result) {
                 return result;
@@ -137,7 +137,7 @@ function changedNodeViews(a, b) {
         }
         for (const plugin of this.props.plugins ?? []){
             const prop = plugin.props[propName];
-            if (prop) {
+            if (prop != null) {
                 const result = f ? f(prop) : prop;
                 if (result) {
                     return result;
@@ -146,7 +146,7 @@ function changedNodeViews(a, b) {
         }
         for (const plugin of this.state.plugins){
             const prop = plugin.props[propName];
-            if (prop) {
+            if (prop != null) {
                 const result = f ? f(prop) : prop;
                 if (result) {
                     return result;

package/dist/esm/StaticEditorView.js

@@ -36,7 +36,7 @@ export class StaticEditorView {
     }
     someProp(propName, f) {
         const prop = this.props[propName];
-        if (prop) {
+        if (prop != null) {
             const result = f ? f(prop) : prop;
             if (result) {
                 return result;
@@ -44,7 +44,7 @@ export class StaticEditorView {
         }
         for (const plugin of this.props.plugins ?? []){
             const prop = plugin.props[propName];
-            if (prop) {
+            if (prop != null) {
                 const result = f ? f(prop) : prop;
                 if (result) {
                     return result;
@@ -53,7 +53,7 @@ export class StaticEditorView {
         }
         for (const plugin of this.state.plugins){
             const prop = plugin.props[propName];
-            if (prop) {
+            if (prop != null) {
                 const result = f ? f(prop) : prop;
                 if (result) {
                     return result;

package/dist/esm/components/SeparatorHackView.js

@@ -25,7 +25,8 @@ export function SeparatorHackView(param) {
     // we call setShouldRender conditionally
     // eslint-disable-next-line react-hooks/exhaustive-deps
     useClientLayoutEffect(()=>{
-        const lastSibling = siblingsRef.current[siblingsRef.current.length - 1];
+        const nonHackSiblings = siblingsRef.current.filter((viewdesc)=>!(viewdesc instanceof TrailingHackViewDesc));
+        const lastSibling = nonHackSiblings[nonHackSiblings.length - 1];
         if ((browser.safari || browser.chrome) && lastSibling?.dom?.contentEditable == "false") {
             setShouldRender(true);
             return;
@@ -44,6 +45,7 @@ export function SeparatorHackView(param) {
     });
     return shouldRender ? /*#__PURE__*/ React.createElement("img", {
         ref: ref,
-        className: "ProseMirror-separator"
+        className: "ProseMirror-separator",
+        alt: ""
     }) : null;
 }

package/dist/esm/hooks/useNodeViewDescription.js

@@ -111,7 +111,21 @@ export function useNodeViewDescription(getDOM, getContentDOM, constructor, props
         if (!siblings.includes(viewDesc)) {
             siblings.push(viewDesc);
         }
+        // In strict/concurrent mode, a node can sometimes re-render
+        // entirely on its own, without even its parent re-rendering.
+        // In this case, we will have added our view descriptions to
+        // our parent's children, but our parent has no opportunity
+        // to sort its children, because it never renders. So
+        // we always sort our siblings, too.
         siblings.sort(sortViewDescs);
+        // If a child updates, usually it will re-render and sort
+        // our children for us. But it's possible to reorder
+        // child nodes without changing their keys or node
+        // instances, in which case our children _won't_
+        // rerender. As a fallback, we do one last pass through
+        // our own child view descriptions and make sure
+        // they're ordered. This should be a cheap no-op in most cases.
+        children.sort(sortViewDescs);
         for (const child of children){
             child.parent = viewDesc;
             // Because TextNodeViews can't locate the DOM nodes