@hamp10/agentforge 0.2.46 → 0.2.48

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hamp10/agentforge",
-  "version": "0.2.46",
+  "version": "0.2.48",
   "description": "AgentForge worker — connect your machine to agentforge.ai",
   "type": "module",
   "bin": {

package/scripts/check-task-semantics.js

@@ -522,6 +522,33 @@ try {
     /Requested scoped UI targets: alpha, beta/i,
     'multi-target UI quality retries should preserve the full scoped target set'
   );
+  const originalFindIncompleteScopedUiTargets = worker._findIncompleteScopedUiTargets;
+  worker._findIncompleteScopedUiTargets = () => [{
+    repo: fixture.repo,
+    missingSlugs: ['beta-ai'],
+    touchedSlugs: ['alpha-ai'],
+    changedFiles: ['public_html/domains/alpha-ai.html'],
+  }];
+  const incompleteRepairLead = worker._formatIncompleteScopedUiRepairLead(
+    baseline,
+    'Work on the Example.com listing pages for Alpha.ai and Beta.ai. Delete and rebuild both listing pages from a clean start.'
+  );
+  worker._findIncompleteScopedUiTargets = originalFindIncompleteScopedUiTargets;
+  assert.match(
+    incompleteRepairLead,
+    /missing-target pass for target page\(s\) not yet changed in the current diff: beta-ai/i,
+    'missing-target retries should name only the targets not yet addressed'
+  );
+  assert.match(
+    incompleteRepairLead,
+    /Do not delete, rewrite, or restart target page\(s\) already changed[\s\S]*alpha-ai/i,
+    'missing-target retries should avoid replaying earlier work on targets already touched in the diff'
+  );
+  assert.doesNotMatch(
+    incompleteRepairLead,
+    /The task is:|Delete and rebuild both/i,
+    'missing-target retries should not put the original reset-heavy task text at the top of the retry prompt'
+  );
   assert.equal(
     worker._formatRepeatedVisualRepairNudge(2),
     '',
@@ -540,6 +567,25 @@ try {
     /Keep other requested target page\(s\) intact[\s\S]*alpha-ai, beta-ai/i,
     'visual-warning retries should focus on the failing target instead of recreating unrelated completed targets'
   );
+  const focusedRepairLead = worker._formatVisualRepairTaskLead(
+    'Work on the Example.com listing pages for Alpha.ai, Beta.ai, and Gamma.ai. Delete and rebuild Alpha.ai and Beta.ai from a clean start, and fix Gamma.ai so all three are visually polished.',
+    'gamma-ai: Visual warning: target hero text is clipped.'
+  );
+  assert.match(
+    focusedRepairLead,
+    /visual repair pass for currently failing target page\(s\): gamma-ai/i,
+    'focused visual repair retries should name the failing target set'
+  );
+  assert.match(
+    focusedRepairLead,
+    /Do not repeat initial delete\/rebuild\/reset\/setup work[\s\S]*alpha-ai, beta-ai/i,
+    'focused visual repair retries should not replay clean-start work for already-built non-failing targets'
+  );
+  assert.doesNotMatch(
+    focusedRepairLead,
+    /The task is:|Delete and rebuild Alpha\.ai/i,
+    'focused visual repair retries should not put the original reset-heavy task text at the top of the retry prompt'
+  );
   assert.match(
     worker._buildScopedUiTargetSetNudge(baseline, message),
     /one delivery set/i,

package/src/worker.js

@@ -1491,6 +1491,23 @@ export class AgentForgeWorker extends EventEmitter {
     ].filter(Boolean).join('\n');
   }
 
+  _formatVisualRepairTaskLead(userMessage, output) {
+    const { slugs: allSlugs } = this._extractExplicitScope(userMessage);
+    const failedSlugs = this._extractUiVerificationFailureSlugs(output, userMessage);
+    if (allSlugs.length >= 2 && failedSlugs.length > 0 && failedSlugs.length < allSlugs.length) {
+      const preservedSlugs = allSlugs.filter(slug => !failedSlugs.includes(slug));
+      return [
+        `Original scoped UI target set: ${allSlugs.join(', ')}.`,
+        `This retry is a visual repair pass for currently failing target page(s): ${failedSlugs.join(', ')}.`,
+        preservedSlugs.length > 0
+          ? `Do not repeat initial delete/rebuild/reset/setup work for target page(s) not currently failing: ${preservedSlugs.join(', ')}.`
+          : '',
+        'Continue from the current repo state and change only files needed to repair the failing target page(s), then re-verify every requested target page locally before completion or delivery.',
+      ].filter(Boolean).join('\n');
+    }
+    return `The task is: "${userMessage}"`;
+  }
+
   _formatUiVerificationFailureLogSummary(nudge) {
     const lines = String(nudge || '')
       .split('\n')
@@ -1715,6 +1732,23 @@ export class AgentForgeWorker extends EventEmitter {
     return warnings.length > 0 ? this._formatIncompleteScopedUiTargetsNudge(warnings) : '';
   }
 
+  _formatIncompleteScopedUiRepairLead(repoBaselines, userMessage) {
+    const warnings = this._findIncompleteScopedUiTargets(repoBaselines, userMessage);
+    if (warnings.length === 0) return `The task is: "${userMessage}"`;
+    const { slugs: allSlugs } = this._extractExplicitScope(userMessage);
+    const missingSlugs = [...new Set(warnings.flatMap(w => w.missingSlugs || []))];
+    if (allSlugs.length < 2 || missingSlugs.length === 0) return `The task is: "${userMessage}"`;
+    const alreadyTouchedSlugs = allSlugs.filter(slug => !missingSlugs.includes(slug));
+    return [
+      `Original scoped UI target set: ${allSlugs.join(', ')}.`,
+      `This retry is a missing-target pass for target page(s) not yet changed in the current diff: ${missingSlugs.join(', ')}.`,
+      alreadyTouchedSlugs.length > 0
+        ? `Do not delete, rewrite, or restart target page(s) already changed in this diff just to repeat earlier work: ${alreadyTouchedSlugs.join(', ')}.`
+        : '',
+      'Continue from the current repo state, edit the missing target page(s) directly, then verify every requested target page locally before completion or delivery.',
+    ].filter(Boolean).join('\n');
+  }
+
   _formatScopedUiTargetSetReminder(userMessage) {
     if (!this._isBroadUiQualityTask(userMessage)) return '';
     const { slugs: allowedSlugs, pageOnly } = this._extractExplicitScope(userMessage);
@@ -4304,7 +4338,8 @@ export class AgentForgeWorker extends EventEmitter {
             nudgeCount++;
             if (nudgeCount < MAX_NUDGES) {
               console.log(`[${taskId}] Iteration missed scoped UI target(s) — continuing (${nudgeCount}/${MAX_NUDGES}, total UI repairs ${uiRepairNudgeCount}/${UI_REPAIR_NUDGE_LIMIT})`);
-              iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${interimIncompleteScopedUiTargetsNudge}\n\nContinue from the current changed files. Do not restart from scratch; address the missing target page(s), then verify each edited target screen after the final edit.`);
+              const incompleteScopedRepairLead = this._formatIncompleteScopedUiRepairLead(repoBaselines, scopeAwareUserMessage);
+              iterationMessage = withTaskContext(`${incompleteScopedRepairLead}\n\n${interimIncompleteScopedUiTargetsNudge}\n\nContinue from the current changed files. Do not restart from scratch; address the missing target page(s), then verify each edited target screen after the final edit.`);
               continue;
             }
             throw new Error('Task missed scoped UI target pages after repeated retries');
@@ -4425,13 +4460,14 @@ export class AgentForgeWorker extends EventEmitter {
               const scopedTargetSetNudge = this._formatScopedUiTargetSetReminder(scopeAwareUserMessage);
               const repeatedVisualRepairNudge = this._formatRepeatedVisualRepairNudge(uiRepairNudgeCount);
               const visualFailureFocusNudge = this._formatVisualFailureFocusNudge(output, scopeAwareUserMessage);
+              const visualRepairTaskLead = this._formatVisualRepairTaskLead(scopeAwareUserMessage, output);
               const visualFailureSummary = this._formatUiVerificationFailureLogSummary(uiVerificationFailureNudge);
               if (nudgeCount < MAX_NUDGES) {
                 console.log(`[${taskId}] UI completion still had visual verification warnings — nudging (${nudgeCount}/${MAX_NUDGES}, total UI repairs ${repairBudget})`);
                 if (visualFailureSummary) {
                   console.log(`[${taskId}] UI visual verification issue(s): ${visualFailureSummary}`);
                 }
-                iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${[uiVerificationFailureNudge, visualFailureFocusNudge, scopedTargetSetNudge, repeatedVisualRepairNudge].filter(Boolean).join('\n\n')}\n\nFix the visible UI issues, verify again with the browser, and only then end with ✓ TASK_COMPLETE.`);
+                iterationMessage = withTaskContext(`${visualRepairTaskLead}\n\n${[uiVerificationFailureNudge, visualFailureFocusNudge, scopedTargetSetNudge, repeatedVisualRepairNudge].filter(Boolean).join('\n\n')}\n\nFix the visible UI issues, verify again with the browser, and only then end with ✓ TASK_COMPLETE.`);
                 continue;
               }
               throw new Error('UI task claimed completion while visual verification still reported issues');
@@ -4472,7 +4508,8 @@ export class AgentForgeWorker extends EventEmitter {
               nudgeCount++;
               if (nudgeCount < MAX_NUDGES) {
                 console.log(`[${taskId}] UI completion missed scoped target(s) — nudging (${nudgeCount}/${MAX_NUDGES}, total UI repairs ${uiRepairNudgeCount}/${UI_REPAIR_NUDGE_LIMIT})`);
-                iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${incompleteScopedUiTargetsNudge}\n\nDo not mark complete until every named target page has been addressed directly and visually verified.`);
+                const incompleteScopedRepairLead = this._formatIncompleteScopedUiRepairLead(repoBaselines, scopeAwareUserMessage);
+                iterationMessage = withTaskContext(`${incompleteScopedRepairLead}\n\n${incompleteScopedUiTargetsNudge}\n\nDo not mark complete until every named target page has been addressed directly and visually verified.`);
                 continue;
               }
               throw new Error('UI task claimed completion while missing scoped target pages after repeated retries');
@@ -4698,13 +4735,14 @@ export class AgentForgeWorker extends EventEmitter {
                 const scopedTargetSetNudge = this._formatScopedUiTargetSetReminder(scopeAwareUserMessage);
                 const repeatedVisualRepairNudge = this._formatRepeatedVisualRepairNudge(uiRepairNudgeCount);
                 const visualFailureFocusNudge = this._formatVisualFailureFocusNudge(output, scopeAwareUserMessage);
+                const visualRepairTaskLead = this._formatVisualRepairTaskLead(scopeAwareUserMessage, output);
                 const visualFailureSummary = this._formatUiVerificationFailureLogSummary(uiVerificationFailureNudge);
                 if (nudgeCount < MAX_NUDGES) {
                   console.log(`[${taskId}] Publish evidence still had visual verification warnings — continuing (${nudgeCount}/${MAX_NUDGES}, total UI repairs ${repairBudget})`);
                   if (visualFailureSummary) {
                     console.log(`[${taskId}] UI visual verification issue(s): ${visualFailureSummary}`);
                   }
-                  iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${[uiVerificationFailureNudge, visualFailureFocusNudge, scopedTargetSetNudge, repeatedVisualRepairNudge].filter(Boolean).join('\n\n')}\n\nContinue from the current repo state, fix the visible UI issues, verify again, then commit/push any additional changes before reporting delivery complete.`);
+                  iterationMessage = withTaskContext(`${visualRepairTaskLead}\n\n${[uiVerificationFailureNudge, visualFailureFocusNudge, scopedTargetSetNudge, repeatedVisualRepairNudge].filter(Boolean).join('\n\n')}\n\nContinue from the current repo state, fix the visible UI issues, verify again, then commit/push any additional changes before reporting delivery complete.`);
                   continue;
                 }
                 throw new Error('Publish task still had visual verification issues after repeated retries');
@@ -4745,7 +4783,8 @@ export class AgentForgeWorker extends EventEmitter {
                 nudgeCount++;
                 if (nudgeCount < MAX_NUDGES) {
                   console.log(`[${taskId}] Publish evidence missed scoped target(s) — continuing (${nudgeCount}/${MAX_NUDGES}, total UI repairs ${uiRepairNudgeCount}/${UI_REPAIR_NUDGE_LIMIT})`);
-                  iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${incompleteScopedUiTargetsNudge}\n\nContinue from the current repo state, address the missing target page(s), verify all edited target screens, then commit/push any additional changes before reporting delivery complete.`);
+                  const incompleteScopedRepairLead = this._formatIncompleteScopedUiRepairLead(repoBaselines, scopeAwareUserMessage);
+                  iterationMessage = withTaskContext(`${incompleteScopedRepairLead}\n\n${incompleteScopedUiTargetsNudge}\n\nContinue from the current repo state, address the missing target page(s), verify all edited target screens, then commit/push any additional changes before reporting delivery complete.`);
                   continue;
                 }
                 throw new Error('Publish task missed scoped target pages after repeated retries');
@@ -4843,6 +4882,7 @@ export class AgentForgeWorker extends EventEmitter {
             const scopedTargetSetNudge = this._formatScopedUiTargetSetReminder(scopeAwareUserMessage);
             const repeatedVisualRepairNudge = this._formatRepeatedVisualRepairNudge(uiVerificationRetryCount);
             const visualFailureFocusNudge = this._formatVisualFailureFocusNudge(output, scopeAwareUserMessage);
+            const visualRepairTaskLead = this._formatVisualRepairTaskLead(scopeAwareUserMessage, output);
             const visualFailureSummary = this._formatUiVerificationFailureLogSummary(visualVerificationFailureNudge);
             nudgeCount = 0;
             console.log(`[${taskId}] UI task visual verification still reported visible issues — retrying (${uiVerificationRetryCount}/${UI_REPAIR_NUDGE_LIMIT}, total UI repairs ${repairBudget})`);
@@ -4852,7 +4892,7 @@ export class AgentForgeWorker extends EventEmitter {
             const retryInstruction = generatedResetNudge
               ? 'Rebuild the removed target page file(s) from already-inspected project context and comparable existing pages. Do not reuse the rejected generated page as the basis for the next attempt. Address every requested target that is currently missing or changed in one coherent pass, fix the visible issues reported by local browser verification, reopen each edited target screen locally after the final edit, and only then end with ✓ TASK_COMPLETE.'
               : 'Continue from the current changed files and latest browser evidence. Fix the visible issues reported by the local browser verification, reopen each edited target screen locally after the final edit, and only then end with ✓ TASK_COMPLETE.';
-            iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${[visualVerificationFailureNudge, visualFailureFocusNudge, generatedResetNudge, scopedTargetSetNudge, repeatedVisualRepairNudge].filter(Boolean).join('\n\n')}\n\n${retryInstruction}`);
+            iterationMessage = withTaskContext(`${visualRepairTaskLead}\n\n${[visualVerificationFailureNudge, visualFailureFocusNudge, generatedResetNudge, scopedTargetSetNudge, repeatedVisualRepairNudge].filter(Boolean).join('\n\n')}\n\n${retryInstruction}`);
           } else if (hasMissingLocalUiVerification) {
             uiVerificationRetryCount++;
             const uiVerificationFailureDetails = this._extractUiVerificationFailureDetails(output);