@hamp10/agentforge 0.2.41 → 0.2.42

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hamp10/agentforge",
-  "version": "0.2.41",
+  "version": "0.2.42",
   "description": "AgentForge worker — connect your machine to agentforge.ai",
   "type": "module",
   "bin": {

package/scripts/check-task-semantics.js

@@ -504,6 +504,16 @@ try {
     /Requested scoped UI targets: alpha, beta/i,
     'multi-target UI quality retries should preserve the full scoped target set'
   );
+  assert.equal(
+    worker._formatRepeatedVisualRepairNudge(2),
+    '',
+    'early visual repair retries should stay concise before escalation'
+  );
+  assert.match(
+    worker._formatRepeatedVisualRepairNudge(3),
+    /current repair strategy is not converging/i,
+    'repeated visual failures should force a strategy change instead of another micro-edit loop'
+  );
   assert.match(
     worker._buildScopedUiTargetSetNudge(baseline, message),
     /one delivery set/i,
@@ -1119,11 +1129,31 @@ assert.match(
     /UI_QUALITY_NUDGE_LIMIT\s*=\s*isVisualUiTask\s*\?\s*Math\.min\(MAX_NUDGES,\s*3\)/,
     'visual UI quality repair loops should use the UI repair budget, not the smaller generic nudge limit'
   );
-  assert.match(
-    workerSource,
-    /UI_REPAIR_NUDGE_LIMIT[\s\S]*consumeUiRepairNudge[\s\S]*reached \$\{UI_REPAIR_NUDGE_LIMIT\} total repair retries/i,
+assert.match(
+  workerSource,
+  /UI_REPAIR_NUDGE_LIMIT[\s\S]*consumeUiRepairNudge[\s\S]*reached \$\{UI_REPAIR_NUDGE_LIMIT\} total repair retries/i,
   'visual UI retries need a global repair budget across rejection types'
 );
+assert.doesNotMatch(
+  workerSource,
+  /consumeUiRepairNudge\('(?:completion |publish )?missed scoped UI target'/,
+  'missing scoped target recovery should not spend the visual QA budget that may have been consumed by prior screenshot failures'
+);
+assert.match(
+  workerSource,
+  /_formatRepeatedVisualRepairNudge[\s\S]*current repair strategy is not converging/i,
+  'repeated visual failures should inject a generic strategy-change nudge'
+);
+assert.match(
+  workerSource,
+  /_formatUiVerificationFailureLogSummary[\s\S]*UI visual verification issue\(s\)/i,
+  'worker logs should expose concise visual verification issues for operators'
+);
+assert.match(
+  workerSource,
+  /Address every requested target that is currently missing or changed in one coherent pass/i,
+  'generated-page visual retries should preserve the full delivery set after selective resets'
+);
 assert.match(
   workerSource,
   /AGENTFORGE_UI_REPAIR_BUDGET \|\| '12'/,

package/src/worker.js

@@ -1453,10 +1453,30 @@ export class AgentForgeWorker extends EventEmitter {
     return [
       'AgentForge removed the rejected generated target file(s) before this retry.',
       ...lines,
-      'Treat those removed files as failed output, not source material. Rebuild the requested target page-owned file(s) from inspected project context and comparable existing pages, then verify the rebuilt pages visually.',
+      'Treat those removed files as failed output, not source material. Rebuild the requested target page-owned file(s) from inspected project context and comparable existing pages before optional refinements to other targets.',
+      'If the task names multiple target pages, keep them as one delivery set: every named target must exist, be materially addressed, and be visually verified before completion.',
     ].join('\n');
   }
 
+  _formatRepeatedVisualRepairNudge(attempt = 1) {
+    if (Number(attempt || 1) < 3) return '';
+    return [
+      'Repeated visual verification is still failing, so the current repair strategy is not converging.',
+      'Switch strategy before the next verification pass: make a coherent page-owned structural pass instead of isolated warning fixes, stale-string edits, color tweaks, or hero-only adjustments.',
+      'Inspect the screenshots as whole screens across top, middle, and lower viewports. Resolve the underlying composition, readability, spacing, section balance, and content-depth problems in the target-owned files, then verify every requested target page again.',
+    ].join('\n');
+  }
+
+  _formatUiVerificationFailureLogSummary(nudge) {
+    const lines = String(nudge || '')
+      .split('\n')
+      .map(line => line.trim())
+      .filter(line => /(?:^|[\s:])(Visual warning|Style warning):/i.test(line))
+      .slice(0, 3)
+      .map(line => line.replace(/\s+/g, ' ').slice(0, 240));
+    return lines.join(' | ');
+  }
+
   _findUiImplementationArtifactChanges(repoBaselines, userMessage) {
     if (!this._isBroadUiQualityTask(userMessage)) return [];
     if (!Array.isArray(repoBaselines) || repoBaselines.length === 0) return [];
@@ -4253,9 +4273,8 @@ export class AgentForgeWorker extends EventEmitter {
           const interimIncompleteScopedUiTargetsNudge = this._buildIncompleteScopedUiTargetsNudge(repoBaselines, scopeAwareUserMessage);
           if (interimIncompleteScopedUiTargetsNudge) {
             nudgeCount++;
-            const repairBudget = consumeUiRepairNudge('missed scoped UI target', interimIncompleteScopedUiTargetsNudge);
             if (nudgeCount < MAX_NUDGES) {
-              console.log(`[${taskId}] Iteration missed scoped UI target(s) — continuing (${nudgeCount}/${MAX_NUDGES}, total UI repairs ${repairBudget})`);
+              console.log(`[${taskId}] Iteration missed scoped UI target(s) — continuing (${nudgeCount}/${MAX_NUDGES}, total UI repairs ${uiRepairNudgeCount}/${UI_REPAIR_NUDGE_LIMIT})`);
               iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${interimIncompleteScopedUiTargetsNudge}\n\nContinue from the current changed files. Do not restart from scratch; address the missing target page(s), then verify each edited target screen after the final edit.`);
               continue;
             }
@@ -4374,9 +4393,15 @@ export class AgentForgeWorker extends EventEmitter {
             if (uiVerificationFailureNudge) {
               nudgeCount++;
               const repairBudget = consumeUiRepairNudge('visual verification warnings', uiVerificationFailureNudge);
+              const scopedTargetSetNudge = this._formatScopedUiTargetSetReminder(scopeAwareUserMessage);
+              const repeatedVisualRepairNudge = this._formatRepeatedVisualRepairNudge(uiRepairNudgeCount);
+              const visualFailureSummary = this._formatUiVerificationFailureLogSummary(uiVerificationFailureNudge);
               if (nudgeCount < MAX_NUDGES) {
                 console.log(`[${taskId}] UI completion still had visual verification warnings — nudging (${nudgeCount}/${MAX_NUDGES}, total UI repairs ${repairBudget})`);
-                iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${uiVerificationFailureNudge}\n\nFix the visible UI issues, verify again with the browser, and only then end with ✓ TASK_COMPLETE.`);
+                if (visualFailureSummary) {
+                  console.log(`[${taskId}] UI visual verification issue(s): ${visualFailureSummary}`);
+                }
+                iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${[uiVerificationFailureNudge, scopedTargetSetNudge, repeatedVisualRepairNudge].filter(Boolean).join('\n\n')}\n\nFix the visible UI issues, verify again with the browser, and only then end with ✓ TASK_COMPLETE.`);
                 continue;
               }
               throw new Error('UI task claimed completion while visual verification still reported issues');
@@ -4415,9 +4440,8 @@ export class AgentForgeWorker extends EventEmitter {
             const incompleteScopedUiTargetsNudge = this._buildIncompleteScopedUiTargetsNudge(repoBaselines, scopeAwareUserMessage);
             if (incompleteScopedUiTargetsNudge) {
               nudgeCount++;
-              const repairBudget = consumeUiRepairNudge('completion missed scoped UI target', incompleteScopedUiTargetsNudge);
               if (nudgeCount < MAX_NUDGES) {
-                console.log(`[${taskId}] UI completion missed scoped target(s) — nudging (${nudgeCount}/${MAX_NUDGES}, total UI repairs ${repairBudget})`);
+                console.log(`[${taskId}] UI completion missed scoped target(s) — nudging (${nudgeCount}/${MAX_NUDGES}, total UI repairs ${uiRepairNudgeCount}/${UI_REPAIR_NUDGE_LIMIT})`);
                 iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${incompleteScopedUiTargetsNudge}\n\nDo not mark complete until every named target page has been addressed directly and visually verified.`);
                 continue;
               }
@@ -4641,9 +4665,15 @@ export class AgentForgeWorker extends EventEmitter {
               if (uiVerificationFailureNudge) {
                 nudgeCount++;
                 const repairBudget = consumeUiRepairNudge('publish visual verification warnings', uiVerificationFailureNudge);
+                const scopedTargetSetNudge = this._formatScopedUiTargetSetReminder(scopeAwareUserMessage);
+                const repeatedVisualRepairNudge = this._formatRepeatedVisualRepairNudge(uiRepairNudgeCount);
+                const visualFailureSummary = this._formatUiVerificationFailureLogSummary(uiVerificationFailureNudge);
                 if (nudgeCount < MAX_NUDGES) {
                   console.log(`[${taskId}] Publish evidence still had visual verification warnings — continuing (${nudgeCount}/${MAX_NUDGES}, total UI repairs ${repairBudget})`);
-                  iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${uiVerificationFailureNudge}\n\nContinue from the current repo state, fix the visible UI issues, verify again, then commit/push any additional changes before reporting delivery complete.`);
+                  if (visualFailureSummary) {
+                    console.log(`[${taskId}] UI visual verification issue(s): ${visualFailureSummary}`);
+                  }
+                  iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${[uiVerificationFailureNudge, scopedTargetSetNudge, repeatedVisualRepairNudge].filter(Boolean).join('\n\n')}\n\nContinue from the current repo state, fix the visible UI issues, verify again, then commit/push any additional changes before reporting delivery complete.`);
                   continue;
                 }
                 throw new Error('Publish task still had visual verification issues after repeated retries');
@@ -4682,9 +4712,8 @@ export class AgentForgeWorker extends EventEmitter {
               const incompleteScopedUiTargetsNudge = this._buildIncompleteScopedUiTargetsNudge(repoBaselines, scopeAwareUserMessage);
               if (incompleteScopedUiTargetsNudge) {
                 nudgeCount++;
-                const repairBudget = consumeUiRepairNudge('publish missed scoped UI target', incompleteScopedUiTargetsNudge);
                 if (nudgeCount < MAX_NUDGES) {
-                  console.log(`[${taskId}] Publish evidence missed scoped target(s) — continuing (${nudgeCount}/${MAX_NUDGES}, total UI repairs ${repairBudget})`);
+                  console.log(`[${taskId}] Publish evidence missed scoped target(s) — continuing (${nudgeCount}/${MAX_NUDGES}, total UI repairs ${uiRepairNudgeCount}/${UI_REPAIR_NUDGE_LIMIT})`);
                   iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${incompleteScopedUiTargetsNudge}\n\nContinue from the current repo state, address the missing target page(s), verify all edited target screens, then commit/push any additional changes before reporting delivery complete.`);
                   continue;
                 }
@@ -4780,12 +4809,18 @@ export class AgentForgeWorker extends EventEmitter {
                 ? this._restoreGeneratedScopedUiTargets(repoBaselines, scopeAwareUserMessage, { onlySlugs: visualFailureSlugs })
                 : []
             );
+            const scopedTargetSetNudge = this._formatScopedUiTargetSetReminder(scopeAwareUserMessage);
+            const repeatedVisualRepairNudge = this._formatRepeatedVisualRepairNudge(uiVerificationRetryCount);
+            const visualFailureSummary = this._formatUiVerificationFailureLogSummary(visualVerificationFailureNudge);
             nudgeCount = 0;
             console.log(`[${taskId}] UI task visual verification still reported visible issues — retrying (${uiVerificationRetryCount}/${UI_REPAIR_NUDGE_LIMIT}, total UI repairs ${repairBudget})`);
+            if (visualFailureSummary) {
+              console.log(`[${taskId}] UI visual verification issue(s): ${visualFailureSummary}`);
+            }
             const retryInstruction = generatedResetNudge
-              ? 'Rebuild the removed target page file(s) from already-inspected project context and comparable existing pages. Do not reuse the rejected generated page as the basis for the next attempt. Fix the visible issues reported by local browser verification, reopen each edited target screen locally after the final edit, and only then end with ✓ TASK_COMPLETE.'
+              ? 'Rebuild the removed target page file(s) from already-inspected project context and comparable existing pages. Do not reuse the rejected generated page as the basis for the next attempt. Address every requested target that is currently missing or changed in one coherent pass, fix the visible issues reported by local browser verification, reopen each edited target screen locally after the final edit, and only then end with ✓ TASK_COMPLETE.'
               : 'Continue from the current changed files and latest browser evidence. Fix the visible issues reported by the local browser verification, reopen each edited target screen locally after the final edit, and only then end with ✓ TASK_COMPLETE.';
-            iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${[visualVerificationFailureNudge, generatedResetNudge].filter(Boolean).join('\n\n')}\n\n${retryInstruction}`);
+            iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\n${[visualVerificationFailureNudge, generatedResetNudge, scopedTargetSetNudge, repeatedVisualRepairNudge].filter(Boolean).join('\n\n')}\n\n${retryInstruction}`);
           } else if (hasMissingLocalUiVerification) {
             uiVerificationRetryCount++;
             const uiVerificationFailureDetails = this._extractUiVerificationFailureDetails(output);
@@ -4800,12 +4835,14 @@ export class AgentForgeWorker extends EventEmitter {
                 ? this._restoreGeneratedScopedUiTargets(repoBaselines, scopeAwareUserMessage, { onlySlugs: visualFailureSlugs })
                 : []
             );
+            const scopedTargetSetNudge = this._formatScopedUiTargetSetReminder(scopeAwareUserMessage);
+            const repeatedVisualRepairNudge = this._formatRepeatedVisualRepairNudge(uiVerificationRetryCount);
             nudgeCount = 0;
             console.log(`[${taskId}] UI task missing local visual verification — retrying with local-app repair instruction (${uiVerificationRetryCount}/${UI_REPAIR_NUDGE_LIMIT}, total UI repairs ${repairBudget})`);
             const retryInstruction = generatedResetNudge
               ? 'Rebuild the removed target page file(s) from already-inspected project context and comparable existing pages. Do not reuse the rejected generated page as the basis for the next attempt.'
               : 'Continue from the current changed files and already-inspected project context. Do not restart from scratch, repeat initial delete/reset/setup steps, discard existing progress, or reread site indexes, shared/global CSS, header/footer partials, or unrelated reference pages unless a specific verification issue requires it.';
-            iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\nYour edits are not complete because the changed UI was not successfully loaded and inspected cleanly in its actual local app URL.${uiVerificationFailureDetails ? `\n\nSpecific verification issue(s):\n${uiVerificationFailureDetails}` : ''}${generatedResetNudge ? `\n\n${generatedResetNudge}` : ''}\n\n${retryInstruction} Do not use external sites, site indexes, listing indexes, shared style files, or reference pages as final verification for scoped UI edits. Start or repair the project's local dev/static server if needed, use the port the project actually declares, open the real localhost/127.0.0.1 URL for each edited target screen, inspect the changed screen, fix visible issues, and only then end with ✓ TASK_COMPLETE.`);
+            iterationMessage = withTaskContext(`The task is: "${userMessage}"\n\nYour edits are not complete because the changed UI was not successfully loaded and inspected cleanly in its actual local app URL.${uiVerificationFailureDetails ? `\n\nSpecific verification issue(s):\n${uiVerificationFailureDetails}` : ''}${[generatedResetNudge, scopedTargetSetNudge, repeatedVisualRepairNudge].filter(Boolean).map(text => `\n\n${text}`).join('')}\n\n${retryInstruction} Do not use external sites, site indexes, listing indexes, shared style files, or reference pages as final verification for scoped UI edits. Start or repair the project's local dev/static server if needed, use the port the project actually declares, open the real localhost/127.0.0.1 URL for each edited target screen, inspect the changed screen, fix visible issues, and only then end with ✓ TASK_COMPLETE.`);
           } else if (hasIncompleteTurn) {
             // openclaw reported an incomplete turn (payloads=0) after the agent used a tool.
             // This is a tool timeout, not a narration. Reset nudgeCount and give a targeted retry hint.