@hamak/ui-store-impl 0.9.4 → 0.9.6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -29,36 +29,43 @@ export class DataUpdater {
29
29
  */
30
30
  executeDelete(data, itinerary) {
31
31
  if (itinerary === undefined) {
32
- return;
32
+ return { deleted: false, reason: 'itinerary-not-provided' };
33
33
  }
34
34
  const { parent, value: step } = itinerary;
35
35
  const parentNode = navigate(data, parent);
36
- if (!(parentNode === undefined)) {
37
- if (isArray(parentNode)) {
38
- if (step.type === 'position') {
39
- parentNode.splice(step.position, 1);
40
- }
41
- else {
42
- // TODO log expected PositionStep
43
- }
36
+ if (parentNode === undefined) {
37
+ return { deleted: false, reason: 'parent-not-found' };
38
+ }
39
+ if (isArray(parentNode)) {
40
+ let position;
41
+ if (step.type === 'position') {
42
+ position = step.position;
44
43
  }
45
- else if (isObject(parentNode)) {
46
- if (step.type === 'property') {
47
- if (parentNode !== null) {
48
- delete parentNode[step.propertyName];
49
- }
50
- }
51
- else {
52
- // TODO log expected PropertyStep
53
- }
44
+ else if (step.type === 'lookup') {
45
+ position = parentNode.findIndex(element => element !== undefined
46
+ && element !== null
47
+ && step.keys.every(({ propertyName, propertyValue }) => element[propertyName] === propertyValue));
54
48
  }
55
49
  else {
56
- // TODO log expected object
50
+ return { deleted: false, reason: 'array-step-not-supported' };
57
51
  }
52
+ if (!Number.isInteger(position) || position < 0 || position >= parentNode.length) {
53
+ return { deleted: false, reason: 'target-not-found' };
54
+ }
55
+ parentNode.splice(position, 1);
56
+ return { deleted: true };
58
57
  }
59
- else {
60
- // TODO log Parent Node not found
58
+ if (isObject(parentNode)) {
59
+ if (step.type !== 'property') {
60
+ return { deleted: false, reason: 'object-step-not-supported' };
61
+ }
62
+ if (!Object.prototype.hasOwnProperty.call(parentNode, step.propertyName)) {
63
+ return { deleted: false, reason: 'target-not-found' };
64
+ }
65
+ delete parentNode[step.propertyName];
66
+ return { deleted: true };
61
67
  }
68
+ return { deleted: false, reason: 'parent-not-container' };
62
69
  }
63
70
  /**
64
71
  * Set a value at the specified itinerary
@@ -1,5 +1,12 @@
1
1
  import { Itinerary, StackElement } from '@hamak/shared-utils';
2
2
  import { UnitaryStructureNodeCommand, BatchUpdateStructureNodeCommand } from '../commands/structure-commands.js';
3
+ export type DeleteFailureReason = 'itinerary-not-provided' | 'parent-not-found' | 'parent-not-container' | 'array-step-not-supported' | 'object-step-not-supported' | 'target-not-found';
4
+ export type DeleteResult = {
5
+ deleted: true;
6
+ } | {
7
+ deleted: false;
8
+ reason: DeleteFailureReason;
9
+ };
3
10
  /**
4
11
  * DataUpdater class handles operations on data structures using itineraries
5
12
  */
@@ -7,7 +14,7 @@ export declare class DataUpdater {
7
14
  /**
8
15
  * Delete a value at the specified itinerary
9
16
  */
10
- executeDelete(data: any, itinerary: Itinerary | undefined): void;
17
+ executeDelete(data: any, itinerary: Itinerary | undefined): DeleteResult;
11
18
  /**
12
19
  * Set a value at the specified itinerary
13
20
  */
@@ -1 +1 @@
1
- {"version":3,"file":"data-updater.d.ts","sourceRoot":"","sources":["../../../src/fs/utils/data-updater.ts"],"names":[],"mappings":"AACA,OAAO,EACL,SAAS,EACT,YAAY,EAKb,MAAM,qBAAqB,CAAC;AAC7B,OAAO,EACL,2BAA2B,EAC3B,+BAA+B,EAChC,MAAM,gCAAgC,CAAC;AAyBxC;;GAEG;AACH,qBAAa,WAAW;IAEtB;;OAEG;IACI,aAAa,CAAC,IAAI,EAAE,GAAG,EAAE,SAAS,EAAE,SAAS,GAAG,SAAS;IA8BhE;;OAEG;IACI,UAAU,CAAC,IAAI,EAAE,GAAG,EAAE,SAAS,EAAE,SAAS,GAAG,SAAS,EAAE,KAAK,EAAE,GAAG,EAAE,iBAAiB,CAAC,EAAE,YAAY,CAAC,GAAG,CAAC;IA+BhH;;OAEG;IACI,UAAU,CAAC,IAAI,EAAE,GAAG,EAAE,SAAS,EAAE,SAAS,GAAG,SAAS,EAAE,KAAK,EAAE,GAAG,EAAE,iBAAiB,CAAC,EAAE,YAAY,CAAC,GAAG,CAAC;IAahH;;OAEG;IACI,aAAa,CAAC,IAAI,EAAE,GAAG,EAAE,SAAS,EAAE,SAAS,EAAE,KAAK,EAAE,GAAG,EAAE,iBAAiB,CAAC,EAAE,YAAY,CAAC,GAAG,CAAC;IAkBvG;;;;OAIG;IACI,sBAAsB,CAC3B,WAAW,EAAE,2BAA2B,EACxC,UAAU,EAAE,2BAA2B,GACtC,2BAA2B,GAAG,IAAI;IAqFrC;;;;OAIG;IACI,YAAY,CAAC,IAAI,EAAE,GAAG,EAAE,OAAO,EAAE,+BAA+B,GAAG,IAAI;CA4B/E"}
1
+ {"version":3,"file":"data-updater.d.ts","sourceRoot":"","sources":["../../../src/fs/utils/data-updater.ts"],"names":[],"mappings":"AACA,OAAO,EACL,SAAS,EACT,YAAY,EAKb,MAAM,qBAAqB,CAAC;AAC7B,OAAO,EACL,2BAA2B,EAC3B,+BAA+B,EAChC,MAAM,gCAAgC,CAAC;AAExC,MAAM,MAAM,mBAAmB,GAC3B,wBAAwB,GACxB,kBAAkB,GAClB,sBAAsB,GACtB,0BAA0B,GAC1B,2BAA2B,GAC3B,kBAAkB,CAAA;AAEtB,MAAM,MAAM,YAAY,GACpB;IAAE,OAAO,EAAE,IAAI,CAAA;CAAE,GACjB;IAAE,OAAO,EAAE,KAAK,CAAC;IAAC,MAAM,EAAE,mBAAmB,CAAA;CAAE,CAAA;AAyBnD;;GAEG;AACH,qBAAa,WAAW;IAEtB;;OAEG;IACI,aAAa,CAAC,IAAI,EAAE,GAAG,EAAE,SAAS,EAAE,SAAS,GAAG,SAAS,GAAG,YAAY;IAkD/E;;OAEG;IACI,UAAU,CAAC,IAAI,EAAE,GAAG,EAAE,SAAS,EAAE,SAAS,GAAG,SAAS,EAAE,KAAK,EAAE,GAAG,EAAE,iBAAiB,CAAC,EAAE,YAAY,CAAC,GAAG,CAAC;IA+BhH;;OAEG;IACI,UAAU,CAAC,IAAI,EAAE,GAAG,EAAE,SAAS,EAAE,SAAS,GAAG,SAAS,EAAE,KAAK,EAAE,GAAG,EAAE,iBAAiB,CAAC,EAAE,YAAY,CAAC,GAAG,CAAC;IAahH;;OAEG;IACI,aAAa,CAAC,IAAI,EAAE,GAAG,EAAE,SAAS,EAAE,SAAS,EAAE,KAAK,EAAE,GAAG,EAAE,iBAAiB,CAAC,EAAE,YAAY,CAAC,GAAG,CAAC;IAkBvG;;;;OAIG;IACI,sBAAsB,CAC3B,WAAW,EAAE,2BAA2B,EACxC,UAAU,EAAE,2BAA2B,GACtC,2BAA2B,GAAG,IAAI;IAqFrC;;;;OAIG;IACI,YAAY,CAAC,IAAI,EAAE,GAAG,EAAE,OAAO,EAAE,+BAA+B,GAAG,IAAI;CA4B/E"}
@@ -29,36 +29,43 @@ export class DataUpdater {
29
29
  */
30
30
  executeDelete(data, itinerary) {
31
31
  if (itinerary === undefined) {
32
- return;
32
+ return { deleted: false, reason: 'itinerary-not-provided' };
33
33
  }
34
34
  const { parent, value: step } = itinerary;
35
35
  const parentNode = navigate(data, parent);
36
- if (!(parentNode === undefined)) {
37
- if (isArray(parentNode)) {
38
- if (step.type === 'position') {
39
- parentNode.splice(step.position, 1);
40
- }
41
- else {
42
- // TODO log expected PositionStep
43
- }
36
+ if (parentNode === undefined) {
37
+ return { deleted: false, reason: 'parent-not-found' };
38
+ }
39
+ if (isArray(parentNode)) {
40
+ let position;
41
+ if (step.type === 'position') {
42
+ position = step.position;
44
43
  }
45
- else if (isObject(parentNode)) {
46
- if (step.type === 'property') {
47
- if (parentNode !== null) {
48
- delete parentNode[step.propertyName];
49
- }
50
- }
51
- else {
52
- // TODO log expected PropertyStep
53
- }
44
+ else if (step.type === 'lookup') {
45
+ position = parentNode.findIndex(element => element !== undefined
46
+ && element !== null
47
+ && step.keys.every(({ propertyName, propertyValue }) => element[propertyName] === propertyValue));
54
48
  }
55
49
  else {
56
- // TODO log expected object
50
+ return { deleted: false, reason: 'array-step-not-supported' };
57
51
  }
52
+ if (!Number.isInteger(position) || position < 0 || position >= parentNode.length) {
53
+ return { deleted: false, reason: 'target-not-found' };
54
+ }
55
+ parentNode.splice(position, 1);
56
+ return { deleted: true };
58
57
  }
59
- else {
60
- // TODO log Parent Node not found
58
+ if (isObject(parentNode)) {
59
+ if (step.type !== 'property') {
60
+ return { deleted: false, reason: 'object-step-not-supported' };
61
+ }
62
+ if (!Object.prototype.hasOwnProperty.call(parentNode, step.propertyName)) {
63
+ return { deleted: false, reason: 'target-not-found' };
64
+ }
65
+ delete parentNode[step.propertyName];
66
+ return { deleted: true };
61
67
  }
68
+ return { deleted: false, reason: 'parent-not-container' };
62
69
  }
63
70
  /**
64
71
  * Set a value at the specified itinerary
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@hamak/ui-store-impl",
3
- "version": "0.9.4",
3
+ "version": "0.9.6",
4
4
  "private": false,
5
5
  "type": "module",
6
6
  "description": "DEPRECATED: Use @hamak/ui-store instead",