@halsystems/red-bacnet 1.1.1 → 1.1.2

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## [1.1.2]
+### Change
+- WritePoint to not fail if point not found in points config, only raise error
+
 ## [1.1.1]
 ### Added
 - Unit test for BACnet string points

package/common/bacnet.js

@@ -288,6 +288,7 @@ module.exports = {
                             return value;
                         } catch (err) {
                             failedCount++;
+                            // if (readMethod < 1 && failedCount >= singleReadFailedRetry)
                             if (failedCount >= singleReadFailedRetry)
                                 throw err
                         }

package/common/job/read_point.js

@@ -221,7 +221,7 @@ module.exports = {
                 task: async () => {
                     return await smartReadProperty(
                         this.client, v.device, v.points, this.readMethod,
-                        this.maxConcurrentSinglePointRead, 5, this.concurrentTaskDelay
+                        this.maxConcurrentSinglePointRead, 10, this.concurrentTaskDelay
                     );
                 }
             }));

package/common/job/write_point.js

@@ -233,10 +233,14 @@ module.exports = {
             });
 
             if (missingPoints.length > 0) {
+                // do not fail writing, just log the missing points and remove them from writePoints
                 this.eventEmitter.emit(EVENT_ERROR, errMsg(
                     this.name, ERR_WRITE_POINT_NOT_FOUND, missingPoints
                 ))
-                return false
+
+                missingPoints.forEach(point => {
+                    delete this.writePointDetails[point];
+                });
             }
 
             if (priorityErrList.length > 0) {
@@ -304,4 +308,4 @@ module.exports = {
         }
 
     }
-}
+}

package/ext/node-bacstack/dist/lib/bvlc.js

@@ -46,6 +46,7 @@ const decode = (buffer, offset) => {
                 if (isValidIp && isValidPort && !isBroadcast && !isMulticast && !isZero) {
                     const ip = ipParts.join(".");
                     linkAddress = (port === 47808) ? ip : `${ip}:${port}`;
+                    // linkAddress = `${ip}:${port}`;
                 }
             }
             break;

package/ext/node-bacstack/dist/lib/transport.js

@@ -14,6 +14,7 @@ class Transport extends events_1.EventEmitter {
             this._server.on('message', (msg, rinfo) => {
                 // NOTE HAL modified
                 const port = rinfo.port || DEFAULT_BACNET_PORT;
+                // this.emit('message', msg, `${rinfo.address}:${port}`);
                 if (port === DEFAULT_BACNET_PORT)
                     this.emit('message', msg, rinfo.address);
                 else

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@halsystems/red-bacnet",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "description": "NodeRED BACnet IP client",
   "email": "open_source@halsystems.com.au",
   "repository": {