@hailer/mcp 0.1.8 → 0.1.9

package/dist/mcp/tools/app-scaffold.js

@@ -47,39 +47,7 @@ const logger_1 = require("../../lib/logger");
 const config_1 = require("../../config");
 const tool_helpers_1 = require("../utils/tool-helpers");
 const logger = (0, logger_1.createLogger)({ component: 'app-scaffold' });
-const scaffoldHailerAppDescription = `Scaffold new Hailer app from template - ONE SHOT SETUP
-
-⚠️ **MANDATORY: YOU MUST LOAD SKILL FIRST**
-**BEFORE calling this tool, you are REQUIRED to:**
-1. Load the skill: \`get_skill({ skillName: "scaffold-hailer-app-skill" })\`
-2. Read the setup guide and understand the process
-3. Review template options and troubleshooting tips
-**FAILURE TO LOAD THE SKILL FIRST IS AN ERROR**
-
-**Required Parameters**:
-- projectName: Project folder name
-- template: react-ts-style (recommended - includes Hailer theme), react-ts-example (with example code), react-ts (basic), or vanilla
-
-**Optional Parameters**:
-- description: App description for Hailer
-- autoCreateDevApp: (default: true) Automatically create dev app entry in Hailer
-- autoShareWithWorkspace: (default: true) Share app with entire workspace
-- autoStartDevServer: (default: true) Start dev server in background
-- autoSpawnBuilder: (default: false) Return instruction to spawn builder agent that implements the app UI
-
-**What This Does (One Shot)**:
-1. ✅ Scaffolds project from template
-2. ✅ Installs dependencies
-3. ✅ Creates dev app entry in Hailer with correct URL
-4. ✅ Shares app with workspace
-5. ✅ Updates manifest.json with app ID
-6. ✅ Starts dev server on port 3000
-7. ✅ App ready to open in Hailer!
-
-**Target Directory**:
-- Uses DEV_APPS_PATH from .env.local if set
-- Falls back to targetDirectory parameter
-- Falls back to current directory if neither set`;
+const scaffoldHailerAppDescription = `Scaffold new Hailer app from template`;
 exports.scaffoldHailerAppTool = {
     name: 'scaffold_hailer_app',
     group: tool_registry_1.ToolGroup.PLAYGROUND,
@@ -402,49 +370,7 @@ exports.scaffoldHailerAppTool = {
 // ============================================================================
 // PUBLISH HAILER APP TOOL
 // ============================================================================
-const publishHailerAppDescription = `Publish Hailer app to production - Uses official @hailer/app-sdk publish script
-
-**What it does:**
-1. Runs \`npm run publish-production\` (official SDK script)
-2. Authenticates with Hailer (uses session credentials or provided ones)
-3. Uploads to Hailer hosting
-4. Optionally publishes to marketplace (returns targetId)
-
-**Authentication:**
-- Uses session credentials from CLIENT_CONFIGS by default
-- Override with email/password parameters if needed
-
-**Optional Parameters**:
-- \`projectDirectory\` - Path to app (defaults to DEV_APPS_PATH)
-- \`publishToMarket\` - Set true to get targetId for marketplace
-- \`email\` - Override session email
-- \`password\` - Override session password
-
-**Prerequisites**:
-1. Production app entry exists (create_app with empty URL)
-2. \`public/manifest.json\` contains the production appId
-
-**Example:**
-\`\`\`javascript
-// Uses session credentials
-publish_hailer_app({
-  projectDirectory: "/path/to/app",
-  publishToMarket: true
-})
-
-// Or with explicit credentials
-publish_hailer_app({
-  projectDirectory: "/path/to/app",
-  email: "user@example.com",
-  password: "password",
-  publishToMarket: true
-})
-\`\`\`
-
-**Marketplace Flow:**
-1. Call publish_hailer_app with publishToMarket: true
-2. Get targetId from response
-3. Use targetId with publish_app for marketplace listing`;
+const publishHailerAppDescription = `Publish Hailer app to production`;
 exports.publishHailerAppTool = {
     name: 'publish_hailer_app',
     group: tool_registry_1.ToolGroup.PLAYGROUND,
@@ -459,6 +385,11 @@ exports.publishHailerAppTool = {
     async execute(args, context) {
         const path = await Promise.resolve().then(() => __importStar(require('path')));
         const fs = await Promise.resolve().then(() => __importStar(require('fs')));
+        logger.debug('Step 0: Starting publishHailerApp execute function', {
+            hasProjectDirectory: !!args.projectDirectory,
+            hasAppId: !!args.appId,
+            publishToMarket: args.publishToMarket
+        });
         // Use provided credentials or fall back to session credentials
         const email = args.email || context.email;
         const password = args.password || context.password;
@@ -472,16 +403,37 @@ exports.publishHailerAppTool = {
             };
         }
         // Debug: log credential availability (not the actual values)
-        logger.debug('publish_hailer_app credentials', {
+        logger.debug('Step 0.5: Credentials verified', {
             hasEmail: !!email,
             emailLength: email?.length,
             hasPassword: !!password,
             passwordLength: password?.length
         });
         try {
+            const { execSync } = await Promise.resolve().then(() => __importStar(require('child_process')));
+            // Step 1: Check if expect is installed
+            logger.debug('Step 1: Checking if expect is installed...');
+            try {
+                execSync('which expect', { encoding: 'utf-8', stdio: 'pipe' });
+                logger.debug('Step 1.5: expect command found');
+            }
+            catch {
+                logger.error('Step 1 ERROR: expect command not found');
+                return {
+                    content: [{
+                            type: "text",
+                            text: `❌ **\`expect\` Not Installed**\n\nThe \`expect\` command is required for automated app publishing.\n\n**How to fix:**\n\n**macOS:**\n\`\`\`bash\nbrew install expect\n\`\`\`\n\n**Ubuntu/Debian:**\n\`\`\`bash\nsudo apt-get install expect\n\`\`\`\n\n**RHEL/CentOS:**\n\`\`\`bash\nsudo yum install expect\n\`\`\`\n\n**After installation, try again.**`,
+                        }],
+                };
+            }
+            // Step 2: Determine project directory
+            logger.debug('Step 2: Checking project directory...');
             const projectDir = args.projectDirectory || config_1.environment.DEV_APPS_PATH || process.cwd();
-            // Check if directory exists
+            logger.debug('Step 2.5: Project directory resolved', { projectDir });
+            // Step 3: Check if directory exists
+            logger.debug('Step 3: Verifying project directory exists...');
             if (!fs.existsSync(projectDir)) {
+                logger.error('Step 3 ERROR: Project directory does not exist', { projectDir });
                 return {
                     content: [{
                             type: "text",
@@ -489,9 +441,12 @@ exports.publishHailerAppTool = {
                         }],
                 };
             }
-            // Check if package.json exists
+            logger.debug('Step 3.5: Project directory exists');
+            // Step 4: Check if package.json exists
+            logger.debug('Step 4: Checking package.json...');
             const packageJsonPath = path.join(projectDir, 'package.json');
             if (!fs.existsSync(packageJsonPath)) {
+                logger.error('Step 4 ERROR: package.json not found', { packageJsonPath });
                 return {
                     content: [{
                             type: "text",
@@ -499,19 +454,32 @@ exports.publishHailerAppTool = {
                         }],
                 };
             }
-            // Read manifest.json to get/verify appId
+            logger.debug('Step 4.5: package.json found');
+            // Step 5: Read manifest.json to get/verify appId
+            logger.debug('Step 5: Reading manifest.json...');
             const manifestPath = path.join(projectDir, 'public', 'manifest.json');
             let appId = args.appId;
             let appName = 'Unknown';
             if (fs.existsSync(manifestPath)) {
+                logger.debug('Step 5.5: manifest.json file found');
                 try {
+                    logger.debug('Step 5.7: Reading manifest file content...');
                     const manifestContent = fs.readFileSync(manifestPath, 'utf-8');
+                    logger.debug('Step 5.8: Parsing manifest JSON...');
                     const manifest = JSON.parse(manifestContent);
+                    logger.debug('Step 5.9: Manifest parsed successfully', {
+                        hasAppId: !!manifest.appId,
+                        hasName: !!manifest.name,
+                        hasVersion: !!manifest.version,
+                        hasVersionDescription: !!manifest.versionDescription
+                    });
                     if (!appId) {
                         appId = manifest.appId;
                     }
                     appName = manifest.name || appName;
+                    logger.debug('Step 5.95: Manifest data extracted', { appId, appName });
                     if (!appId) {
+                        logger.error('Step 5.97 ERROR: No appId found');
                         return {
                             content: [{
                                     type: "text",
@@ -519,9 +487,32 @@ exports.publishHailerAppTool = {
                                 }],
                         };
                     }
+                    // Step 6: Validate version fields are present and not empty
+                    logger.debug('Step 6: Validating version fields...');
+                    if (!manifest.version || manifest.version.trim() === '') {
+                        logger.error('Step 6 ERROR: version field missing or empty');
+                        return {
+                            content: [{
+                                    type: "text",
+                                    text: `❌ **Version Not Set**\n\nThe \`version\` field in \`manifest.json\` is missing or empty.\n\n**Steps to fix:**\nEdit \`public/manifest.json\` and add:\n\`\`\`json\n"version": "1.0.0",\n"versionDescription": "Initial release"\n\`\`\`\n\nThe SDK requires version fields for publishing.`,
+                                }],
+                        };
+                    }
+                    logger.debug('Step 6.5: version field OK', { version: manifest.version });
+                    if (!manifest.versionDescription || manifest.versionDescription.trim() === '') {
+                        logger.error('Step 6.7 ERROR: versionDescription field missing or empty');
+                        return {
+                            content: [{
+                                    type: "text",
+                                    text: `❌ **Version Description Not Set**\n\nThe \`versionDescription\` field in \`manifest.json\` is missing or empty.\n\n**Steps to fix:**\nEdit \`public/manifest.json\` and add:\n\`\`\`json\n"version": "${manifest.version}",\n"versionDescription": "Description of this version"\n\`\`\`\n\nThe SDK requires version fields for publishing.`,
+                                }],
+                        };
+                    }
+                    logger.debug('Step 6.9: versionDescription field OK', { versionDescription: manifest.versionDescription });
                 }
                 catch (error) {
                     const errorMessage = (0, tool_helpers_1.extractErrorMessage)(error);
+                    logger.error('Step 5 ERROR: Failed to parse manifest.json', { error: errorMessage });
                     return {
                         content: [{
                                 type: "text",
@@ -531,6 +522,7 @@ exports.publishHailerAppTool = {
                 }
             }
             else if (!appId) {
+                logger.error('Step 5.99 ERROR: Manifest not found and no appId provided');
                 return {
                     content: [{
                             type: "text",
@@ -538,10 +530,14 @@ exports.publishHailerAppTool = {
                         }],
                 };
             }
-            // Check if publish-production script exists
+            // Step 7: Check if publish-production script exists
+            logger.debug('Step 7: Checking publish-production script...');
             try {
+                logger.debug('Step 7.3: Reading package.json for script...');
                 const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf-8'));
+                logger.debug('Step 7.5: package.json parsed');
                 if (!packageJson.scripts?.['publish-production']) {
+                    logger.error('Step 7 ERROR: publish-production script not found');
                     return {
                         content: [{
                                 type: "text",
@@ -549,9 +545,11 @@ exports.publishHailerAppTool = {
                             }],
                     };
                 }
+                logger.debug('Step 7.8: publish-production script found');
             }
             catch (error) {
                 const errorMessage = (0, tool_helpers_1.extractErrorMessage)(error);
+                logger.error('Step 7 ERROR: Failed to parse package.json for scripts', { error: errorMessage });
                 return {
                     content: [{
                             type: "text",
@@ -559,25 +557,32 @@ exports.publishHailerAppTool = {
                         }],
                 };
             }
+            // Step 8: Prepare response and get ready to publish
+            logger.debug('Step 8: Preparing to run publish script...');
             let responseText = `🚀 **Publishing Hailer App**\n\n`;
             responseText += `**App Name:** ${appName}\n`;
             responseText += `**App ID:** \`${appId}\`\n`;
             responseText += `**Project:** ${projectDir}\n`;
             responseText += `**Marketplace:** ${publishToMarket ? 'Yes (will get targetId)' : 'No'}\n\n`;
-            // Run the SDK publish script using `expect` for interactive automation
+            logger.debug('Step 8.5: Response header prepared');
+            // Step 9: Run the SDK publish script using `expect` for interactive automation
             // Write expect script to temp file to avoid shell escaping issues
+            logger.debug('Step 9: Starting expect script execution process...');
+            const os = await Promise.resolve().then(() => __importStar(require('os')));
             const result = await new Promise((resolve) => {
-                const { execSync } = require('child_process');
-                const os = require('os');
                 // Create temp expect script file
+                logger.debug('Step 9.1: Creating temp directory and script path...');
                 const tmpDir = os.tmpdir();
                 const expectScriptPath = path.join(tmpDir, `hailer-publish-${Date.now()}.exp`);
+                logger.debug('Step 9.2: Expect script path resolved', { expectScriptPath });
                 // For Tcl, use braces {} for literal strings (no escaping needed except for braces)
                 // Escape only braces in the password
+                logger.debug('Step 9.3: Escaping password for expect script...');
                 const escapedPassword = password
                     .replace(/\\/g, '\\\\')
                     .replace(/\{/g, '\\{')
                     .replace(/\}/g, '\\}');
+                logger.debug('Step 9.4: Password escaped (length: ' + escapedPassword.length + ')');
                 const expectScript = `#!/usr/bin/expect -f
 set timeout 45
 log_user 1
@@ -620,8 +625,11 @@ exit $value
 `;
                 try {
                     // Write expect script to temp file
+                    logger.debug('Step 9.5: Writing expect script to file...');
                     fs.writeFileSync(expectScriptPath, expectScript, { mode: 0o755 });
+                    logger.debug('Step 9.6: Expect script written successfully', { fileSize: expectScript.length });
                     // Build environment
+                    logger.debug('Step 9.7: Building environment variables...');
                     const envVars = {
                         ...process.env,
                         EMAIL: email
@@ -629,43 +637,85 @@ exit $value
                     if (publishToMarket) {
                         envVars.MARKET = 'true';
                     }
+                    logger.debug('Step 9.8: Environment prepared', { hasEmail: !!email, publishToMarket });
+                    logger.debug('Step 9.9: Running expect script...', { projectDir, timeout: 60000 });
                     const output = execSync(`expect "${expectScriptPath}"`, {
                         cwd: projectDir,
                         encoding: 'utf-8',
-                        timeout: 120000,
+                        timeout: 60000,
                         maxBuffer: 10 * 1024 * 1024,
                         env: envVars
                     });
+                    logger.debug('Step 9.95: Expect script completed successfully', { outputLength: output.length });
                     // Clean up temp file
+                    logger.debug('Step 9.97: Cleaning up expect script...');
                     try {
                         fs.unlinkSync(expectScriptPath);
                     }
                     catch { }
+                    logger.debug('Step 9.98: Temp file cleaned');
                     // Check if manifest was updated with targetId
+                    logger.debug('Step 9.99: Checking for manifest update with targetId...');
                     let targetId;
                     try {
                         const updatedManifest = JSON.parse(fs.readFileSync(manifestPath, 'utf-8'));
                         targetId = updatedManifest.targetId;
+                        logger.debug('Step 9.991: Manifest checked', { hasTargetId: !!targetId });
                     }
                     catch {
+                        logger.debug('Step 9.992: Could not read updated manifest');
                         // Ignore
                     }
                     if (output.includes('Published successfully')) {
+                        logger.debug('Step 9.993: Success message found in output');
                         resolve({ success: true, output, targetId });
                     }
                     else {
+                        logger.debug('Step 9.994: No success message in output');
                         resolve({ success: false, output });
                     }
                 }
                 catch (error) {
+                    logger.error('Step 9 ERROR: Expect script execution failed', {
+                        errorCode: error.code,
+                        signal: error.signal,
+                        hasStdout: !!error.stdout,
+                        hasStderr: !!error.stderr,
+                        errorMessage: error.message
+                    });
                     // Clean up temp file
+                    logger.debug('Step 9.err.1: Cleaning up after error...');
                     try {
                         fs.unlinkSync(expectScriptPath);
                     }
                     catch { }
                     const output = error.stdout || error.stderr || error.message || String(error);
-                    // Even if exit code is non-zero, check if it actually succeeded
-                    if (output.includes('Published successfully')) {
+                    logger.debug('Step 9.err.2: Error output collected', { outputLength: output.length });
+                    // Check for specific error messages
+                    if (output.includes('not found') || output.includes('command not found')) {
+                        logger.debug('Step 9.err.3: expect command not found error detected');
+                        resolve({
+                            success: false,
+                            output: `ERROR: expect command not found. Try: apt-get install expect (Ubuntu) or brew install expect (macOS)\n\n${output}`
+                        });
+                    }
+                    else if (output.includes('TIMEOUT')) {
+                        logger.debug('Step 9.err.4: Timeout error detected');
+                        resolve({
+                            success: false,
+                            output: `ERROR: expect script timed out waiting for prompts. Check your internet connection and Hailer API status.\n\n${output}`
+                        });
+                    }
+                    else if (output.includes('INVALID PASSWORD')) {
+                        logger.debug('Step 9.err.5: Invalid password error detected');
+                        resolve({
+                            success: false,
+                            output: `ERROR: Invalid credentials provided. Check your email and password.\n\n${output}`
+                        });
+                    }
+                    else if (output.includes('Published successfully')) {
+                        logger.debug('Step 9.err.6: Success detected despite error code');
+                        // Even if exit code is non-zero, check if it actually succeeded
                         let targetId;
                         try {
                             const updatedManifest = JSON.parse(fs.readFileSync(manifestPath, 'utf-8'));
@@ -677,11 +727,14 @@ exit $value
                         resolve({ success: true, output, targetId });
                     }
                     else {
+                        logger.debug('Step 9.err.7: Generic error');
                         resolve({ success: false, output });
                     }
                 }
             });
+            logger.debug('Step 10: Result received from promise', { success: result.success });
             if (!result.success) {
+                logger.error('Step 10 ERROR: Publish failed', { outputLength: result.output.length });
                 return {
                     content: [{
                             type: "text",
@@ -689,6 +742,7 @@ exit $value
                         }],
                 };
             }
+            logger.debug('Step 10.5: Publish succeeded, building response...');
             responseText += `✅ **App Published Successfully!**\n\n`;
             if (result.targetId) {
                 responseText += `**Target ID:** \`${result.targetId}\`\n\n`;
@@ -722,6 +776,7 @@ exit $value
             responseText += `     member: "network_<workspace-id>" // or team_*, user_*\n`;
             responseText += `   })\n`;
             responseText += `   \`\`\`\n`;
+            logger.debug('Step 11: Publishing complete, returning success response');
             return {
                 content: [{
                         type: "text",
@@ -731,6 +786,10 @@ exit $value
         }
         catch (error) {
             const errorMessage = (0, tool_helpers_1.extractErrorMessage)(error);
+            logger.error('CRITICAL ERROR: Uncaught exception in publishHailerApp', {
+                errorMessage,
+                errorType: error instanceof Error ? error.constructor.name : typeof error
+            });
             return {
                 content: [{
                         type: "text",