@hadooppei/hwcode 1.0.12 → 1.0.15

package/.pi/dist/lib/knowledge/extractor.js

@@ -8,12 +8,14 @@ Persist only knowledge that is likely to be useful in future sessions:
 - reusable architecture, testing, debugging, deployment, or operational knowledge.
 Do not persist task summaries, guesses, temporary IDs, credentials, secrets, private data, or facts recoverable by simply reading the repository.
 Do not persist mutable inventory such as current cloud resources, names, availability, status, timestamps, or account snapshots. Preserve the discovery method or selection rule instead. If useful procedure is mixed with volatile facts, remove the volatile facts.
+Do not persist hypotheses, suspected causes, or statements marked as possible, pending validation, or unconfirmed. Omit them until direct evidence verifies them.
 Treat failed, unsupported, invalid, or corrected operations as negative evidence. Never present an operation as valid when the supplied evidence says it failed; use only a verified alternative or record an explicit warning. Never invent commands or parameters absent from successful evidence.
 Use storageHint "rule" only for one short imperative instruction of at most 240 characters. A rule must not contain incident narration, example resource names, IDs, timestamps, or evidence details. Use "topic" for multi-step SOPs and detailed experience.
 Relevant existing knowledge may be supplied. If a candidate has the same intent as an existing item, do not add a translated, renamed, or reformatted duplicate. Set targetId to that exact existing ID and action to "reinforce" when the existing content remains correct, or "revise" only when the delta explicitly proves a correction. Use targetId null only for genuinely new knowledge.
 Scope may be "global" only for an explicit user directive intended across projects; otherwise use "project".
 The prior validation context is only for checking facts and contradictions; do not persist it again unless the new delta independently reinforces it. Prefer accumulated workflow successfulSteps and failedApproaches over assistant narration.
 Each summary must be one complete sentence of at most 160 characters. Keep each topic body under 2200 characters. Escape line breaks and quotes inside JSON strings. Set durability to "stable" only after removing facts likely to change or be cheaply rediscovered. Return at most 3 candidates.
+The body must not repeat the title as a Markdown H1. The storage renderer supplies the H1. Replace any necessary example resource value with an obvious placeholder instead of a real project, namespace, image, network, or resource name.
 Return: {"candidates":[{"key":"stable semantic key","targetId":"existing-id or null","title":"...","summary":"one complete sentence","keywords":["..."],"scope":"global|project","body":"markdown body","evidence":["verified evidence"],"confidence":0.0,"storageHint":"rule|topic","action":"add|reinforce|revise","explicitUserDirective":false,"durability":"stable"}]}
 Return {"candidates":[]} when nothing meets the threshold.`;
 export function buildKnowledgeExtractionPrompt(projectRoot, delta, context = "", existing = []) {

package/.pi/dist/lib/knowledge/review-worker.js

@@ -104,6 +104,25 @@ function finishReview(task, outcome, detail) {
         reviewAttempts.delete(task.reviewKey);
     publishReviewStatus();
 }
+function deferReview(task, reason) {
+    clearTimeout(activeDeadlineTimer);
+    activeDeadlineTimer = undefined;
+    const attempts = reviewAttempts.get(task.reviewKey) ?? 1;
+    if (attempts <= 1)
+        reviewAttempts.delete(task.reviewKey);
+    else
+        reviewAttempts.set(task.reviewKey, attempts - 1);
+    if (!reviewStatus)
+        return;
+    reviewStatus.activeReview = undefined;
+    reviewStatus.lastDeferred = {
+        reviewKey: task.reviewKey,
+        sessionKey: task.sessionKey,
+        deferredAt: new Date().toISOString(),
+        reason: boundedError(reason),
+    };
+    publishReviewStatus();
+}
 function removeLeaderMetadata(token) {
     try {
         const current = JSON.parse(readFileSync(paths.knowledgeLeader, "utf8"));
@@ -355,6 +374,13 @@ function handleReviewResult(message) {
             queueMicrotask(() => void scanForReview());
     }
 }
+function handleReviewDeferred(message) {
+    const task = activeTask;
+    if (!task || message.requestId !== task.requestId || message.leaderToken !== leaderToken || !leaderServer)
+        return;
+    deferReview(task, message.reason);
+    activeTask = undefined;
+}
 const scanTimer = setInterval(() => { void scanForReview(); }, KNOWLEDGE_RUNTIME_DEFAULTS.review.intervalMs);
 scanTimer.unref();
 parentPort.on("message", (message) => {
@@ -373,6 +399,10 @@ parentPort.on("message", (message) => {
             scheduleElection(0);
         return;
     }
+    if (message.type === "review_deferred") {
+        handleReviewDeferred(message);
+        return;
+    }
     if (message.type === "review_result") {
         handleReviewResult(message);
         return;

package/.pi/dist/lib/knowledge/session-scanner.js

@@ -1,13 +1,17 @@
 import { createHash, randomUUID } from "node:crypto";
 import { readFileSync, readdirSync, statSync } from "node:fs";
-import { resolve } from "node:path";
+import { resolve, sep } from "node:path";
 import { buildContextEntries, parseSessionEntries, } from "@earendil-works/pi-coding-agent";
 import { KNOWLEDGE_RUNTIME_DEFAULTS } from "../runtime/defaults.js";
+import { findLatestWorkflowRoot } from "../working-directory.js";
 import { knowledgeDeltaDigest } from "./extractor.js";
 import { sanitizeKnowledgeText } from "./sanitize.js";
 import { projectKnowledgeKey } from "./store.js";
 const FAILURE_EVIDENCE_RE = /(?:\b(?:error|failed|failure|invalid|unsupported|mistyp(?:e|ed)|typo)\b|not supported|失败|错误|不支持|无效)/iu;
 const INJECTED_SKILL_RE = /<skill\b[^>]*>[\s\S]*?<\/skill>/giu;
+const SAFE_KNOWLEDGE_ID_RE = /^[a-z0-9][a-z0-9-]{0,79}$/u;
+const MAX_RECALL_QUERY_CHARS = 4_000;
+const MAX_LOADED_KNOWLEDGE_IDS = 8;
 function hash(value, length = 64) {
     return createHash("sha256").update(value).digest("hex").slice(0, length);
 }
@@ -97,16 +101,131 @@ function buildValidationContext(entries) {
     return selected.sort((left, right) => left.index - right.index).map((piece) => piece.text).join("\n\n")
         .slice(0, KNOWLEDGE_RUNTIME_DEFAULTS.review.maxPriorContextChars);
 }
+function messageRecord(entry) {
+    return entry.type === "message" && entry.message && typeof entry.message === "object"
+        ? entry.message
+        : undefined;
+}
+function loadedKnowledgeIds(entries) {
+    const ids = [];
+    for (const entry of entries) {
+        const content = messageRecord(entry)?.content;
+        if (!Array.isArray(content))
+            continue;
+        for (const item of content) {
+            if (!item || typeof item !== "object")
+                continue;
+            const call = item;
+            if (call.type !== "toolCall" || call.name !== "hwcode_knowledge_lookup"
+                || !call.arguments || typeof call.arguments !== "object")
+                continue;
+            const id = call.arguments.id;
+            if (typeof id !== "string" || !SAFE_KNOWLEDGE_ID_RE.test(id))
+                continue;
+            const existing = ids.indexOf(id);
+            if (existing >= 0)
+                ids.splice(existing, 1);
+            ids.push(id);
+        }
+    }
+    return ids.slice(-MAX_LOADED_KNOWLEDGE_IDS);
+}
+function compactRecallValue(value, maxChars = 600) {
+    return typeof value === "string" ? sanitizeKnowledgeText(value).replace(/\s+/gu, " ").trim().slice(0, maxChars) : "";
+}
+function workflowRecallLines(entry) {
+    if (entry.type !== "custom" || !entry.customType.startsWith("hwcode-workflow")
+        || !entry.data || typeof entry.data !== "object")
+        return [];
+    const data = entry.data;
+    const details = data.details && typeof data.details === "object" ? data.details : undefined;
+    const lines = [];
+    const request = compactRecallValue(details?.request ?? data.request, 800);
+    if (request)
+        lines.push(`Task objective: ${request}`);
+    const addSteps = (label, value, maxItems) => {
+        if (!Array.isArray(value))
+            return;
+        for (const raw of value.slice(-maxItems)) {
+            if (typeof raw === "string") {
+                const text = compactRecallValue(raw);
+                if (text)
+                    lines.push(`${label}: ${text}`);
+                continue;
+            }
+            if (!raw || typeof raw !== "object")
+                continue;
+            const step = raw;
+            const parts = [step.approach, step.intent, step.reason].map((item) => compactRecallValue(item, 320)).filter(Boolean);
+            if (typeof step.command === "string")
+                parts.push(step.command);
+            if (Array.isArray(step.args)) {
+                const operation = step.args.slice(0, 2).filter((item) => typeof item === "string")
+                    .map((item) => compactRecallValue(item, 100)).filter(Boolean).join(" ");
+                if (operation)
+                    parts.push(operation);
+            }
+            const text = [...new Set(parts)].join("; ");
+            if (text)
+                lines.push(`${label}: ${text}`);
+        }
+    };
+    addSteps("Verified success", details?.successfulSteps ?? data.successfulSteps, 12);
+    addSteps("Verified failure", details?.failedApproaches ?? data.failedApproaches, 8);
+    return lines;
+}
+function buildRecallQuery(entries, ids) {
+    const lines = [];
+    const workflows = entries.map(workflowRecallLines).filter((item) => item.length > 0);
+    const workflowLines = workflows.at(-1) ?? [];
+    lines.push(...workflowLines.filter((line) => line.startsWith("Task objective:")));
+    for (const entry of entries.slice().reverse()) {
+        const message = messageRecord(entry);
+        if (!message || message.role !== "user")
+            continue;
+        const text = compactRecallValue(textContent(message.content).replace(INJECTED_SKILL_RE, ""), 800);
+        if (text)
+            lines.push(`User request: ${text}`);
+        if (lines.filter((line) => line.startsWith("User request:")).length >= 2)
+            break;
+    }
+    for (const entry of entries.slice().reverse()) {
+        const message = messageRecord(entry);
+        if (!message || message.role !== "assistant")
+            continue;
+        const text = compactRecallValue(textContent(message.content), 1_000);
+        if (text) {
+            lines.push(`Latest conclusion: ${text}`);
+            break;
+        }
+    }
+    for (const id of ids)
+        lines.push(`Loaded knowledge: ${id}`);
+    lines.push(...workflowLines.filter((line) => line.startsWith("Verified failure:")));
+    lines.push(...workflowLines.filter((line) => line.startsWith("Verified success:")));
+    return lines.join("\n").slice(0, MAX_RECALL_QUERY_CHARS);
+}
 function projectRootForSession(header, branch) {
+    const sessionRoot = resolve(header.cwd);
+    const workflowRootValue = findLatestWorkflowRoot(branch);
+    const workflowRoot = workflowRootValue ? resolve(workflowRootValue) : undefined;
+    let workingDirectory = sessionRoot;
     for (const entry of branch.slice().reverse()) {
         if (entry.type !== "custom" || entry.customType !== "hwcode-working-directory"
             || !entry.data || typeof entry.data !== "object")
             continue;
         const cwd = entry.data.cwd;
-        if (typeof cwd === "string" && cwd)
-            return resolve(cwd);
+        if (typeof cwd !== "string" || !cwd)
+            continue;
+        workingDirectory = resolve(cwd);
+        break;
+    }
+    if (workflowRoot && (workingDirectory === workflowRoot || workingDirectory.startsWith(`${workflowRoot}${sep}`))) {
+        return workflowRoot;
     }
-    return resolve(header.cwd);
+    if (workingDirectory === sessionRoot || workingDirectory.startsWith(`${sessionRoot}${sep}`))
+        return sessionRoot;
+    return workingDirectory;
 }
 export function discoverSessionFiles(root) {
     const files = [];
@@ -164,10 +283,12 @@ export function readReviewTask(sessionFile, cursor, now = Date.now()) {
     if (pending.length === 0)
         return undefined;
     const delta = buildDelta(pending);
+    const loadedIds = loadedKnowledgeIds(pending);
+    const recallQuery = buildRecallQuery(pending, loadedIds);
     const context = cursorIndex >= 0 ? buildValidationContext(branch.slice(0, cursorIndex + 1)) : "";
     const firstEntryId = pending[0].id;
     const lastEntryId = pending[pending.length - 1].id;
-    const deltaDigest = knowledgeDeltaDigest(delta || `${firstEntryId}\0${lastEntryId}`);
+    const deltaDigest = knowledgeDeltaDigest(`${delta || `${firstEntryId}\0${lastEntryId}`}\0${recallQuery}\0${loadedIds.join("\0")}`);
     const sessionFileHash = hash(resolve(sessionFile), 16);
     const sessionKey = hash(header.id, 24);
     const reviewKey = hash(`${header.id}\0${firstEntryId}\0${lastEntryId}\0${deltaDigest}`);
@@ -175,7 +296,8 @@ export function readReviewTask(sessionFile, cursor, now = Date.now()) {
     return {
         requestId: randomUUID(), reviewKey, sessionId: header.id, sessionKey, sessionFileHash,
         projectRoot, projectKey: projectKnowledgeKey(projectRoot),
-        firstEntryId, lastEntryId, context, delta, deltaDigest, fileSize: stat.size, fileMtimeMs: stat.mtimeMs,
+        firstEntryId, lastEntryId, context, delta, recallQuery, loadedKnowledgeIds: loadedIds,
+        deltaDigest, fileSize: stat.size, fileMtimeMs: stat.mtimeMs,
     };
 }
 export function findNextReviewTask(sessionsRoot, reviews, now = Date.now()) {

package/.pi/dist/lib/knowledge/store.js

@@ -9,6 +9,12 @@ const STORAGE = KNOWLEDGE_RUNTIME_DEFAULTS.storage;
 const SAFE_ID_RE = /^[a-z0-9][a-z0-9-]{0,79}$/u;
 const SAFE_GENERATION_RE = /^[0-9TZ-]+-[a-f0-9]{12}$/u;
 const PROJECT_SCOPE_RE = /^project:[a-f0-9]{16}$/u;
+const UNVERIFIED_CLAIM_RE = /(?:待验证|尚未(?:验证|确认)|未经(?:验证|确认)|未(?:经)?证实|推测|猜测|疑似|可能是|可能由于|可能导致|或许|unverified|unconfirmed|speculat(?:e|ive|ion)|hypothes(?:is|ize)|suspect(?:ed|ion)?|possibly|probably)/iu;
+const VOLATILE_ARGUMENT_RE = /--(?:namespace|name|server_name|security_group_id|subnet_id|vpc_id|image_id|project_id)(?:\.\d+)?=(?!<[^>]+>|\$?\{)[^\s`"']+/iu;
+const DISTINCTIVE_COMMON_TERMS = new Set([
+    "cloud", "huawei", "huaweicloud", "hcloud", "topic", "rule", "sop", "project", "region", "create",
+    "deploy", "deployment", "service", "workflow", "cn", "south",
+]);
 export class KnowledgeCommitBusyError extends Error {
 }
 function emptyCatalog() {
@@ -120,9 +126,14 @@ function semanticDuplicateScore(candidate, entry) {
         return 0;
     const titleScore = containment(comparisonTerms(candidate.title), comparisonTerms(entry.title));
     const keywordScore = containment(comparisonTerms(candidate.keywords.join(" ")), comparisonTerms(entry.keywords.join(" ")));
-    if (titleScore < 0.8 || keywordScore < 0.5)
+    if (titleScore >= 0.8 && keywordScore >= 0.5)
+        return titleScore * 0.7 + keywordScore * 0.3;
+    const candidateTerms = comparisonTerms(`${candidate.title} ${candidate.keywords.join(" ")}`);
+    const entryTerms = comparisonTerms(`${entry.title} ${entry.keywords.join(" ")}`);
+    const distinctiveShared = [...candidateTerms].filter((term) => (entryTerms.has(term) && term.length >= 3 && !DISTINCTIVE_COMMON_TERMS.has(term))).length;
+    if (keywordScore < 0.5 || distinctiveShared < 3)
         return 0;
-    return titleScore * 0.7 + keywordScore * 0.3;
+    return keywordScore * 0.7 + Math.min(distinctiveShared / 6, 1) * 0.3;
 }
 function semanticDuplicateIndex(candidate, catalog) {
     let bestIndex = -1;
@@ -137,16 +148,22 @@ function semanticDuplicateIndex(candidate, catalog) {
     return bestIndex;
 }
 function unsupportedOperations(value) {
-    return [...value.matchAll(/\bOperation\s+([A-Za-z][A-Za-z0-9]+)\s+is not supported\b/gu)]
-        .map((match) => match[1].toLowerCase());
+    return [...value.matchAll(/\bOperation\s+([A-Za-z][A-Za-z0-9]+)\s+is not supported\b/gu)].map((match) => {
+        const suffix = value.slice(match.index + match[0].length, match.index + match[0].length + 500);
+        const service = /\bhcloud\s+([A-Za-z][A-Za-z0-9-]*)\s+--help\b/iu.exec(suffix)?.[1]?.toLowerCase();
+        return { operation: match[1].toLowerCase(), service };
+    });
 }
 function contradictsVerifiedFailures(body, validationText) {
     const normalizedBody = body.toLowerCase();
-    for (const operation of unsupportedOperations(validationText)) {
-        const index = normalizedBody.search(new RegExp(`\\b${operation}\\b`, "u"));
+    for (const unsupported of unsupportedOperations(validationText)) {
+        const operationExpression = unsupported.service
+            ? new RegExp(`\\b(?:hcloud\\s+)?${unsupported.service}\\b[^\\n]{0,120}\\b${unsupported.operation}\\b`, "u")
+            : new RegExp(`\\b${unsupported.operation}\\b`, "u");
+        const index = normalizedBody.search(operationExpression);
         if (index < 0)
             continue;
-        const context = normalizedBody.slice(Math.max(0, index - 80), index + operation.length + 80);
+        const context = normalizedBody.slice(Math.max(0, index - 80), index + 240);
         if (!/(?:not supported|unsupported|do not|don't|avoid|不支持|不要|避免)/u.test(context))
             return true;
     }
@@ -161,40 +178,77 @@ function asStringArray(value, maxItems) {
     return [...new Set(value.filter((item) => typeof item === "string")
             .map((item) => compactKnowledgeText(item, 240)).filter(Boolean))].slice(0, maxItems);
 }
-function normalizeCandidate(value, projectKey, validationText) {
+function withoutLeadingTitle(body) {
+    return body.replace(/^#\s+[^\n]*(?:\n+|$)/u, "").trim();
+}
+function containsVolatileDetail(body, projectRoot) {
+    const projectName = basename(resolve(projectRoot));
+    const escapedProjectName = projectName.replace(/[.*+?^${}()|[\]\\]/gu, "\\$&");
+    const namedProject = projectName.length >= 5
+        && new RegExp(`(?:项目|project)\\s*(?:[:：=]|is)?\\s*[\`'\"]?${escapedProjectName}(?![\\p{L}\\p{N}-])`, "iu").test(body);
+    return VOLATILE_ARGUMENT_RE.test(body)
+        || namedProject
+        || /\.hwcode\/cloud\/runs\//iu.test(body);
+}
+function normalizeCandidate(value, projectKey, projectRoot, validationText) {
     if (!value || typeof value !== "object")
-        return undefined;
+        return { reason: "invalid-schema" };
     const raw = value;
     if (typeof raw.key !== "string" || typeof raw.title !== "string" || typeof raw.summary !== "string"
         || typeof raw.body !== "string" || typeof raw.confidence !== "number")
-        return undefined;
+        return { reason: "invalid-schema" };
     if (raw.durability !== "stable")
-        return undefined;
+        return { reason: "unstable" };
     if (raw.confidence < KNOWLEDGE_RUNTIME_DEFAULTS.review.minimumConfidence)
-        return undefined;
+        return { reason: "low-confidence" };
+    if (raw.targetId !== undefined && raw.targetId !== null
+        && (typeof raw.targetId !== "string" || !SAFE_ID_RE.test(raw.targetId)))
+        return { reason: "unknown-target" };
     const explicitUserDirective = raw.explicitUserDirective === true;
     const scope = raw.scope === "global" && explicitUserDirective ? "global" : `project:${projectKey}`;
-    const body = compactKnowledgeText(raw.body, 20_000);
+    const body = withoutLeadingTitle(compactKnowledgeText(raw.body, 20_000));
     const evidence = asStringArray(raw.evidence, 8);
     if (!body || evidence.length === 0)
-        return undefined;
+        return { reason: "missing-body-or-evidence" };
+    const candidateClaims = `${raw.title}\n${raw.summary}\n${body}`;
+    if (!explicitUserDirective && UNVERIFIED_CLAIM_RE.test(candidateClaims))
+        return { reason: "unverified-claim" };
+    if (containsVolatileDetail(body, projectRoot))
+        return { reason: "volatile-detail" };
     if (contradictsVerifiedFailures(body, validationText))
-        return undefined;
+        return { reason: "contradicts-verified-failure" };
     const requestedTrack = raw.storageHint === "rule" ? "rule" : "topic";
     const ruleEligible = body.length <= STORAGE.maxRuleChars && body.split("\n").length <= STORAGE.maxRuleFileLines
         && body.split(/\n\s*\n/gu).length === 1
         && (explicitUserDirective || raw.confidence >= 0.9);
     const targetId = typeof raw.targetId === "string" && SAFE_ID_RE.test(raw.targetId) ? raw.targetId : undefined;
-    return {
-        key: compactKnowledgeText(raw.key, 160), targetId,
-        title: compactKnowledgeText(raw.title, STORAGE.maxTitleChars),
-        summary: compactKnowledgeSummary(raw.summary, STORAGE.maxSummaryChars),
-        keywords: asStringArray(raw.keywords, STORAGE.maxKeywordCount).map((keyword) => keyword.toLowerCase()),
-        scope, body, evidence, confidence: Math.min(1, raw.confidence),
-        storageHint: requestedTrack === "rule" && ruleEligible ? "rule" : "topic",
-        action: raw.action === "revise" ? "revise" : raw.action === "reinforce" ? "reinforce" : "add",
-        explicitUserDirective, durability: "stable",
-    };
+    return { candidate: {
+            key: compactKnowledgeText(raw.key, 160), targetId,
+            title: compactKnowledgeText(raw.title, STORAGE.maxTitleChars),
+            summary: compactKnowledgeSummary(raw.summary, STORAGE.maxSummaryChars),
+            keywords: asStringArray(raw.keywords, STORAGE.maxKeywordCount).map((keyword) => keyword.toLowerCase()),
+            scope, body, evidence, confidence: Math.min(1, raw.confidence),
+            storageHint: requestedTrack === "rule" && ruleEligible ? "rule" : "topic",
+            action: raw.action === "revise" ? "revise" : raw.action === "reinforce" ? "reinforce" : "add",
+            explicitUserDirective, durability: "stable",
+        } };
+}
+function recordSkip(result, reason) {
+    result.skipped++;
+    result.skippedReasons ??= {};
+    result.skippedReasons[reason] = (result.skippedReasons[reason] ?? 0) + 1;
+}
+function writeRejectedPending(directory, reason, value) {
+    let serialized;
+    try {
+        serialized = JSON.stringify(value);
+    }
+    catch {
+        serialized = String(value);
+    }
+    const candidate = sanitizeKnowledgeText(serialized).slice(0, 10_000);
+    const name = `${Date.now()}-rejected-${reason}-${randomUUID().slice(0, 8)}.json`;
+    atomicWrite(join(directory, "pending", name), `${JSON.stringify({ reason, candidate }, null, 2)}\n`);
 }
 function renderKnowledgeFile(candidate) {
     if (candidate.storageHint === "rule")
@@ -324,19 +378,23 @@ export function commitKnowledgeReview(values, task, leaderToken, home = homedir(
         copyCurrentContent(current, temporary, home);
         const catalog = structuredClone(current.catalog);
         const result = { saved: 0, updated: 0, pending: 0, skipped: 0 };
+        const rejected = [];
         for (const value of values.slice(0, KNOWLEDGE_RUNTIME_DEFAULTS.review.maxCandidates)) {
-            const candidate = normalizeCandidate(value, task.projectKey, `${task.context ?? ""}\n${task.delta}`);
-            if (!candidate) {
-                result.skipped++;
+            const normalized = normalizeCandidate(value, task.projectKey, task.projectRoot, `${task.context ?? ""}\n${task.delta}`);
+            if (!("candidate" in normalized)) {
+                recordSkip(result, normalized.reason);
+                rejected.push({ reason: normalized.reason, value });
                 continue;
             }
+            const candidate = normalized.candidate;
             const fingerprint = normalizedFingerprint(candidate);
             const hash = contentHash(candidate);
             const targetIndex = candidate.targetId
                 ? catalog.items.findIndex((item) => item.id === candidate.targetId && applicable(item, task.projectKey))
                 : -1;
             if (candidate.targetId && targetIndex < 0) {
-                result.skipped++;
+                recordSkip(result, "unknown-target");
+                rejected.push({ reason: "unknown-target", value });
                 continue;
             }
             let existingIndex = targetIndex >= 0
@@ -386,6 +444,11 @@ export function commitKnowledgeReview(values, task, leaderToken, home = homedir(
                 result.saved++;
             }
         }
+        if (result.skipped > 0 && result.saved === 0 && result.updated === 0 && result.pending === 0) {
+            for (const item of rejected)
+                writeRejectedPending(temporary, item.reason, item.value);
+            result.pending += rejected.length;
+        }
         catalog.updatedAt = new Date().toISOString();
         const manifest = {
             version: 3, generationId, createdAt: new Date().toISOString(), leaderToken, catalog,

package/.pi/dist/lib/runtime/session-state.js

@@ -0,0 +1,9 @@
+export function findLatestState(entries, codec) {
+    for (let index = entries.length - 1; index >= 0; index--) {
+        const entry = entries[index];
+        if (entry.type !== "custom" || entry.customType !== codec.customType)
+            continue;
+        return { found: true, value: codec.decode(entry.data) };
+    }
+    return { found: false };
+}

package/.pi/dist/lib/workflows/state.js

@@ -0,0 +1,159 @@
+import { findLatestState } from "../runtime/session-state.js";
+export const WORKFLOW_STATE_TYPE = "hwcode-workflow-state";
+export const WORKFLOW_EXTERNAL_AUDIT_TYPE = "hwcode-workflow-external-approval";
+function isCloudTemplateSource(value) {
+    if (!value || typeof value !== "object")
+        return false;
+    const data = value;
+    return typeof data.id === "string"
+        && typeof data.name === "string"
+        && typeof data.createdAt === "string"
+        && typeof data.updatedAt === "string";
+}
+function isCloudRunnerSummary(value) {
+    if (!value || typeof value !== "object")
+        return false;
+    const data = value;
+    return typeof data.id === "string"
+        && typeof data.name === "string"
+        && typeof data.vendor === "string"
+        && typeof data.region === "string"
+        && typeof data.host === "string"
+        && Number.isInteger(data.port)
+        && typeof data.user === "string"
+        && typeof data.remoteRoot === "string"
+        && typeof data.hostKeyFingerprint === "string"
+        && ["instance-role", "agency", "ssh-only"].includes(data.identityType);
+}
+function isTerraformRunState(value) {
+    if (!value || typeof value !== "object")
+        return false;
+    const data = value;
+    const summary = data.planSummary;
+    return typeof data.runId === "string"
+        && typeof data.runnerId === "string"
+        && ["synced", "validated", "planned", "applied", "failed"].includes(data.phase)
+        && typeof data.sourceDigest === "string"
+        && typeof data.remoteWorkspace === "string"
+        && typeof data.startedAt === "string"
+        && typeof data.updatedAt === "string"
+        && (data.planDigest === undefined || typeof data.planDigest === "string")
+        && (summary === undefined || (summary !== null && typeof summary === "object"
+            && Object.values(summary).every((entry) => Number.isInteger(entry))));
+}
+function isCloudDetails(value) {
+    if (!value || typeof value !== "object")
+        return false;
+    const data = value;
+    return typeof data.vendor === "string"
+        && typeof data.deployCurrentProject === "boolean"
+        && typeof data.request === "string"
+        && typeof data.allowNonDeleteChanges === "boolean"
+        && Array.isArray(data.failedApproaches)
+        && Array.isArray(data.successfulSteps)
+        && (data.resources === undefined || (Array.isArray(data.resources) && data.resources.every((resource) => {
+            if (!resource || typeof resource !== "object")
+                return false;
+            const entry = resource;
+            return typeof entry.id === "string" && typeof entry.type === "string" && typeof entry.region === "string"
+                && ["existing", "workflow-created"].includes(entry.ownership)
+                && ["active", "deleted"].includes(entry.status)
+                && typeof entry.updatedAt === "string";
+        })))
+        && typeof data.terminalFailure === "boolean"
+        && (data.artifactDirectory === undefined || typeof data.artifactDirectory === "string")
+        && (data.templateGuidance === undefined || typeof data.templateGuidance === "string")
+        && (data.terraformSourcePath === undefined || typeof data.terraformSourcePath === "string")
+        && (data.sourceTemplate === undefined || isCloudTemplateSource(data.sourceTemplate))
+        && (data.runner === undefined || isCloudRunnerSummary(data.runner))
+        && (data.runnerPreference === undefined || ["automatic", "deferred", "existing"].includes(data.runnerPreference))
+        && (data.terraformRun === undefined || isTerraformRunState(data.terraformRun));
+}
+export function decodeWorkflowState(value) {
+    if (!value || typeof value !== "object")
+        return undefined;
+    const data = value;
+    if (data.version === 2) {
+        if (!["active", "completed", "cancelled", "failed"].includes(data.status)
+            || !["vibe", "sdd", "cloud"].includes(data.mode)
+            || typeof data.root !== "string"
+            || typeof data.phase !== "string"
+            || typeof data.activatedAt !== "string"
+            || typeof data.updatedAt !== "string")
+            return undefined;
+        if (data.mode === "cloud" && !isCloudDetails(data.details))
+            return undefined;
+        if (data.mode === "sdd" && data.sdd !== undefined) {
+            const sdd = data.sdd;
+            if (!["discovery", "requirements", "design", "test-plan", "tasks", "tests", "implementation", "verification"].includes(sdd.phase)
+                || !Array.isArray(sdd.approvals))
+                return undefined;
+        }
+        return data;
+    }
+    return undefined;
+}
+export const WORKFLOW_STATE_CODEC = {
+    customType: WORKFLOW_STATE_TYPE,
+    decode: decodeWorkflowState,
+};
+export function restoreWorkflowState(entries) {
+    return findLatestState(entries, WORKFLOW_STATE_CODEC).value;
+}
+export function activeWorkflow(entries) {
+    const state = restoreWorkflowState(entries);
+    return state?.status === "active" ? state : undefined;
+}
+export function cloudDetails(state) {
+    return state.mode === "cloud" ? state.details : undefined;
+}
+export function createWorkflowState(mode, root, phase = "activated") {
+    const now = new Date().toISOString();
+    return {
+        version: 2,
+        status: "active",
+        mode,
+        root,
+        phase,
+        activatedAt: now,
+        updatedAt: now,
+        ...(mode === "sdd" ? { sdd: { phase: "discovery", approvals: [] } } : {}),
+    };
+}
+export function createCloudWorkflowState(root, vendor, deployCurrentProject, request, template, artifactDirectory) {
+    const now = new Date().toISOString();
+    return {
+        version: 2,
+        status: "active",
+        mode: "cloud",
+        root,
+        phase: "connected",
+        activatedAt: now,
+        updatedAt: now,
+        details: {
+            vendor,
+            deployCurrentProject,
+            request,
+            allowNonDeleteChanges: false,
+            failedApproaches: [],
+            successfulSteps: [],
+            resources: [],
+            terminalFailure: false,
+            ...(artifactDirectory ? { artifactDirectory } : {}),
+            ...(template ? {
+                templateGuidance: template.guidance,
+                sourceTemplate: template.source,
+            } : {}),
+        },
+    };
+}
+export function updateWorkflowState(state, changes) {
+    return { ...state, ...changes, version: 2, updatedAt: new Date().toISOString() };
+}
+export function workflowLabel(mode) {
+    if (mode === "vibe")
+        return "HWCode Vibe";
+    if (mode === "sdd")
+        return "HWCode SDD";
+    return "HWCode Cloud";
+}