@hadooppei/hwcode 1.0.10 → 1.0.12

package/.pi/extensions/knowledge.ts

@@ -8,7 +8,7 @@ import { Type } from "@earendil-works/pi-ai";
 import { defineTool, type ExtensionAPI, type ExtensionContext } from "@earendil-works/pi-coding-agent";
 
 import {
-  buildKnowledgeExtractionPrompt, KNOWLEDGE_EXTRACTION_SYSTEM_PROMPT,
+  buildKnowledgeExtractionPrompt, type ExistingKnowledgeContext, KNOWLEDGE_EXTRACTION_SYSTEM_PROMPT,
 } from "../lib/knowledge/extractor.ts";
 import { matchKnowledge } from "../lib/knowledge/matcher.ts";
 import { loadKnowledgeById, loadKnowledgeSnapshot, projectKnowledgeKey } from "../lib/knowledge/store.ts";
@@ -94,28 +94,48 @@ function workerEntryUrl(): URL {
 }
 
 async function runReview(message: Extract<KnowledgeWorkerOutput, { type: "review_request" }>): Promise<void> {
-  const ctx = runtime.context;
-  if (!ctx?.model || !ctx.modelRegistry.hasConfiguredAuth(ctx.model)) {
-    post({ type: "review_result", leaderToken: message.leaderToken, requestId: message.requestId, error: "no-configured-model" });
-    updateCapability();
-    return;
-  }
-  if (!ctx.isIdle() || ctx.hasPendingMessages()) {
-    post({ type: "review_result", leaderToken: message.leaderToken, requestId: message.requestId, error: "model-executor-is-busy" });
-    return;
-  }
-  const controller = new AbortController();
-  runtime.activeReview = { requestId: message.requestId, leaderToken: message.leaderToken, controller };
-  const timeout = setTimeout(() => controller.abort(), KNOWLEDGE_RUNTIME_DEFAULTS.review.modelTimeoutMs);
-  timeout.unref();
+  let timeout: NodeJS.Timeout | undefined;
   try {
+    const ctx = runtime.context;
+    if (!ctx?.model || !ctx.modelRegistry.hasConfiguredAuth(ctx.model)) throw new Error("no-configured-model");
+    if (!ctx.isIdle() || ctx.hasPendingMessages()) throw new Error("model-executor-is-busy");
+    const controller = new AbortController();
+    runtime.activeReview = { requestId: message.requestId, leaderToken: message.leaderToken, controller };
+    timeout = setTimeout(() => controller.abort(), KNOWLEDGE_RUNTIME_DEFAULTS.review.modelTimeoutMs);
+    timeout.unref();
+    const snapshot = loadKnowledgeSnapshot(message.task.projectKey);
+    const related: ExistingKnowledgeContext[] = matchKnowledge(
+      message.task.delta,
+      snapshot.catalog,
+      KNOWLEDGE_RUNTIME_DEFAULTS.review.maxExistingContextItems,
+    ).map((entry, index) => {
+      const reference: ExistingKnowledgeContext = {
+        id: entry.id,
+        title: entry.title,
+        summary: entry.summary,
+        keywords: entry.keywords,
+        track: entry.track,
+      };
+      if (index >= KNOWLEDGE_RUNTIME_DEFAULTS.review.maxExistingBodyItems) return reference;
+      const content = loadKnowledgeById(entry.id, message.task.projectKey)?.content
+        .slice(0, KNOWLEDGE_RUNTIME_DEFAULTS.review.maxExistingBodyChars);
+      return content ? { ...reference, content } : reference;
+    });
     const response = await ctx.modelRegistry.complete(
       ctx.model,
       {
         systemPrompt: KNOWLEDGE_EXTRACTION_SYSTEM_PROMPT,
         messages: [{
           role: "user",
-          content: [{ type: "text", text: buildKnowledgeExtractionPrompt(message.task.projectRoot, message.task.delta) }],
+          content: [{
+            type: "text",
+            text: buildKnowledgeExtractionPrompt(
+              message.task.projectRoot,
+              message.task.delta,
+              message.task.context,
+              related,
+            ),
+          }],
           timestamp: Date.now(),
         }],
       },
@@ -130,6 +150,7 @@ async function runReview(message: Extract<KnowledgeWorkerOutput, { type: "review
       type: "review_result", leaderToken: message.leaderToken, requestId: message.requestId,
       error: error instanceof Error ? error.message : String(error),
     });
+    try { updateCapability(); } catch { /* The worker lease will recover even if the extension context changed. */ }
   } finally {
     clearTimeout(timeout);
     if (runtime.activeReview?.requestId === message.requestId) runtime.activeReview = undefined;

package/.pi/lib/knowledge/extractor.ts

@@ -2,6 +2,15 @@ import { createHash } from "node:crypto";
 
 import { KNOWLEDGE_RUNTIME_DEFAULTS } from "../runtime/defaults.ts";
 
+export interface ExistingKnowledgeContext {
+  id: string;
+  title: string;
+  summary: string;
+  keywords: string[];
+  track: "rule" | "topic";
+  content?: string;
+}
+
 export const KNOWLEDGE_EXTRACTION_SYSTEM_PROMPT = `You are HWCode's background knowledge reviewer.
 Review only the supplied conversation delta. Return strict JSON and no markdown.
 Persist only knowledge that is likely to be useful in future sessions:
@@ -9,14 +18,32 @@ Persist only knowledge that is likely to be useful in future sessions:
 - verified engineering rules, successful procedures, or expensive failed approaches;
 - reusable architecture, testing, debugging, deployment, or operational knowledge.
 Do not persist task summaries, guesses, temporary IDs, credentials, secrets, private data, or facts recoverable by simply reading the repository.
-Use storageHint "rule" only for short, precise, high-value instructions. Use "topic" for multi-step SOPs and detailed experience.
-Use action "revise" only when the delta explicitly corrects prior knowledge; otherwise use "add" or "reinforce".
+Do not persist mutable inventory such as current cloud resources, names, availability, status, timestamps, or account snapshots. Preserve the discovery method or selection rule instead. If useful procedure is mixed with volatile facts, remove the volatile facts.
+Treat failed, unsupported, invalid, or corrected operations as negative evidence. Never present an operation as valid when the supplied evidence says it failed; use only a verified alternative or record an explicit warning. Never invent commands or parameters absent from successful evidence.
+Use storageHint "rule" only for one short imperative instruction of at most 240 characters. A rule must not contain incident narration, example resource names, IDs, timestamps, or evidence details. Use "topic" for multi-step SOPs and detailed experience.
+Relevant existing knowledge may be supplied. If a candidate has the same intent as an existing item, do not add a translated, renamed, or reformatted duplicate. Set targetId to that exact existing ID and action to "reinforce" when the existing content remains correct, or "revise" only when the delta explicitly proves a correction. Use targetId null only for genuinely new knowledge.
 Scope may be "global" only for an explicit user directive intended across projects; otherwise use "project".
-Return: {"candidates":[{"key":"stable semantic key","title":"...","summary":"...","keywords":["..."],"scope":"global|project","body":"markdown body","evidence":["verified evidence"],"confidence":0.0,"storageHint":"rule|topic","action":"add|reinforce|revise","explicitUserDirective":false}]}
+The prior validation context is only for checking facts and contradictions; do not persist it again unless the new delta independently reinforces it. Prefer accumulated workflow successfulSteps and failedApproaches over assistant narration.
+Each summary must be one complete sentence of at most 160 characters. Keep each topic body under 2200 characters. Escape line breaks and quotes inside JSON strings. Set durability to "stable" only after removing facts likely to change or be cheaply rediscovered. Return at most 3 candidates.
+Return: {"candidates":[{"key":"stable semantic key","targetId":"existing-id or null","title":"...","summary":"one complete sentence","keywords":["..."],"scope":"global|project","body":"markdown body","evidence":["verified evidence"],"confidence":0.0,"storageHint":"rule|topic","action":"add|reinforce|revise","explicitUserDirective":false,"durability":"stable"}]}
 Return {"candidates":[]} when nothing meets the threshold.`;
 
-export function buildKnowledgeExtractionPrompt(projectRoot: string, delta: string): string {
-  return `Project root: ${projectRoot}\n\n<conversation_delta>\n${delta}\n</conversation_delta>`;
+export function buildKnowledgeExtractionPrompt(
+  projectRoot: string,
+  delta: string,
+  context = "",
+  existing: ExistingKnowledgeContext[] = [],
+): string {
+  const related = existing.length > 0 ? JSON.stringify(existing) : "[]";
+  return [
+    `Project root: ${projectRoot}`,
+    "",
+    "<relevant_existing_knowledge>", related, "</relevant_existing_knowledge>",
+    "",
+    "<prior_validation_context>", context, "</prior_validation_context>",
+    "",
+    "<conversation_delta>", delta, "</conversation_delta>",
+  ].join("\n");
 }
 
 export function parseCandidateEnvelope(text: string): unknown[] {
@@ -25,9 +52,58 @@ export function parseCandidateEnvelope(text: string): unknown[] {
   const start = unfenced.indexOf("{");
   const end = unfenced.lastIndexOf("}");
   if (start < 0 || end <= start) throw new Error("Knowledge reviewer did not return a JSON object");
-  const parsed = JSON.parse(unfenced.slice(start, end + 1)) as { candidates?: unknown };
-  if (!Array.isArray(parsed.candidates)) throw new Error("Knowledge reviewer response is missing candidates[]");
-  return parsed.candidates.slice(0, KNOWLEDGE_RUNTIME_DEFAULTS.review.maxCandidates);
+  let strictError: unknown;
+  try {
+    const parsed = JSON.parse(unfenced.slice(start, end + 1)) as { candidates?: unknown };
+    if (!Array.isArray(parsed.candidates)) throw new Error("Knowledge reviewer response is missing candidates[]");
+    return parsed.candidates.slice(0, KNOWLEDGE_RUNTIME_DEFAULTS.review.maxCandidates);
+  } catch (error) {
+    strictError = error;
+  }
+
+  const arrayKey = /["']candidates["']\s*:/gu.exec(unfenced);
+  const arrayStart = arrayKey ? unfenced.indexOf("[", arrayKey.index + arrayKey[0].length) : -1;
+  if (arrayStart >= 0) {
+    const candidates: unknown[] = [];
+    let inString = false;
+    let escaped = false;
+    for (let index = arrayStart + 1; index < unfenced.length && candidates.length < KNOWLEDGE_RUNTIME_DEFAULTS.review.maxCandidates; index++) {
+      const character = unfenced[index];
+      if (inString) {
+        if (escaped) escaped = false;
+        else if (character === "\\") escaped = true;
+        else if (character === '"') inString = false;
+        continue;
+      }
+      if (character === '"') { inString = true; continue; }
+      if (character !== "{") continue;
+      const objectEnd = balancedObjectEnd(unfenced, index);
+      if (objectEnd < 0) break;
+      try { candidates.push(JSON.parse(unfenced.slice(index, objectEnd + 1))); } catch { /* Salvage other complete candidates. */ }
+      index = objectEnd;
+    }
+    if (candidates.length > 0) return candidates;
+  }
+  throw strictError;
+}
+
+function balancedObjectEnd(value: string, start: number): number {
+  let depth = 0;
+  let inString = false;
+  let escaped = false;
+  for (let index = start; index < value.length; index++) {
+    const character = value[index];
+    if (inString) {
+      if (escaped) escaped = false;
+      else if (character === "\\") escaped = true;
+      else if (character === '"') inString = false;
+      continue;
+    }
+    if (character === '"') { inString = true; continue; }
+    if (character === "{") depth++;
+    else if (character === "}" && --depth === 0) return index;
+  }
+  return -1;
 }
 
 export function knowledgeDeltaDigest(delta: string): string {

package/.pi/lib/knowledge/review-status.ts

@@ -0,0 +1,55 @@
+import { chmodSync, mkdirSync, readFileSync, renameSync, writeFileSync } from "node:fs";
+import { dirname } from "node:path";
+
+import { userRuntimePaths } from "../runtime/paths.ts";
+import type { PersistKnowledgeResult } from "./types.ts";
+
+export interface KnowledgeReviewStatus {
+  version: 1;
+  protocolVersion: 3;
+  state: "leader" | "stepped-down";
+  pid: number;
+  leaderToken: string;
+  electedAt: string;
+  updatedAt: string;
+  stepDownReason?: string;
+  lastScanAt?: string;
+  lastScanError?: { at: string; error: string };
+  activeReview?: {
+    reviewKey: string;
+    sessionKey: string;
+    sessionFileHash: string;
+    projectKey: string;
+    attempt: number;
+    startedAt: string;
+  };
+  lastReview?: {
+    reviewKey: string;
+    sessionKey: string;
+    attempt: number;
+    outcome: "saved" | "failed";
+    completedAt: string;
+    durationMs: number;
+    generationId?: string;
+    result?: PersistKnowledgeResult;
+    error?: string;
+  };
+}
+
+export function writeKnowledgeReviewStatus(status: KnowledgeReviewStatus, home: string): void {
+  const path = userRuntimePaths(home).knowledgeStatus;
+  mkdirSync(dirname(path), { recursive: true, mode: 0o700 });
+  const temporary = `${path}.${process.pid}.tmp`;
+  writeFileSync(temporary, `${JSON.stringify(status, null, 2)}\n`, { encoding: "utf8", mode: 0o600 });
+  renameSync(temporary, path);
+  chmodSync(path, 0o600);
+}
+
+export function readKnowledgeReviewStatus(home: string): KnowledgeReviewStatus | undefined {
+  try {
+    const parsed = JSON.parse(readFileSync(userRuntimePaths(home).knowledgeStatus, "utf8")) as KnowledgeReviewStatus;
+    return parsed.version === 1 && parsed.protocolVersion === 3 ? parsed : undefined;
+  } catch {
+    return undefined;
+  }
+}

package/.pi/lib/knowledge/review-worker.ts

@@ -7,9 +7,11 @@ import { parentPort, workerData } from "node:worker_threads";
 import { KNOWLEDGE_RUNTIME_DEFAULTS } from "../runtime/defaults.ts";
 import { userRuntimePaths } from "../runtime/paths.ts";
 import { parseCandidateEnvelope } from "./extractor.ts";
+import { type KnowledgeReviewStatus, writeKnowledgeReviewStatus } from "./review-status.ts";
+import { sanitizeKnowledgeText } from "./sanitize.ts";
 import { findNextReviewTask } from "./session-scanner.ts";
 import { commitKnowledgeReview, ensureKnowledgeDirectories, loadCurrentManifest } from "./store.ts";
-import type { KnowledgeReviewTask } from "./types.ts";
+import type { KnowledgeReviewTask, PersistKnowledgeResult } from "./types.ts";
 import type { CoordinatorBroadcast, KnowledgeWorkerInput, KnowledgeWorkerOutput } from "./worker-protocol.ts";
 
 if (!parentPort) throw new Error("Knowledge review worker requires a parent port");
@@ -25,6 +27,11 @@ let leaderToken = "";
 let standbySocket: Socket | undefined;
 let electionPending = false;
 let activeTask: KnowledgeReviewTask | undefined;
+let activeAttempt = 0;
+let activeStartedAt = 0;
+let activeDeadlineTimer: NodeJS.Timeout | undefined;
+let reviewStatus: KnowledgeReviewStatus | undefined;
+const reviewAttempts = new Map<string, number>();
 
 function send(message: KnowledgeWorkerOutput): void {
   parentPort!.postMessage(message);
@@ -36,13 +43,76 @@ function coordinatorPath(): string {
     : paths.knowledgeCoordinatorSocket;
 }
 
-function writeLeaderMetadata(): void {
+function writeLeaderMetadata(electedAt: string): void {
   writeFileSync(paths.knowledgeLeader, `${JSON.stringify({
-    protocolVersion: 3, leaderToken, pid: process.pid, electedAt: new Date().toISOString(),
+    protocolVersion: 3, leaderToken, pid: process.pid, electedAt,
   }, null, 2)}\n`, { encoding: "utf8", mode: 0o600 });
   chmodSync(paths.knowledgeLeader, 0o600);
 }
 
+function publishReviewStatus(): void {
+  if (!reviewStatus) return;
+  reviewStatus.updatedAt = new Date().toISOString();
+  try { writeKnowledgeReviewStatus(reviewStatus, home); } catch (error) {
+    send({ type: "review_failed", error: `Unable to write knowledge status: ${error instanceof Error ? error.message : String(error)}` });
+  }
+}
+
+function boundedError(error: unknown): string {
+  return sanitizeKnowledgeText(error instanceof Error ? error.message : String(error)).slice(0, 1_000);
+}
+
+function beginReview(task: KnowledgeReviewTask): void {
+  activeAttempt = (reviewAttempts.get(task.reviewKey) ?? 0) + 1;
+  reviewAttempts.set(task.reviewKey, activeAttempt);
+  activeStartedAt = Date.now();
+  clearTimeout(activeDeadlineTimer);
+  activeDeadlineTimer = setTimeout(() => {
+    if (activeTask?.requestId !== task.requestId) return;
+    const error = "knowledge-review-result-timeout";
+    finishReview(task, "failed", { error });
+    activeTask = undefined;
+    send({ type: "review_cancel", requestId: task.requestId, reason: error });
+    send({ type: "review_failed", requestId: task.requestId, error });
+  }, KNOWLEDGE_RUNTIME_DEFAULTS.review.modelTimeoutMs + 5_000);
+  activeDeadlineTimer.unref();
+  if (reviewStatus) {
+    reviewStatus.activeReview = {
+      reviewKey: task.reviewKey,
+      sessionKey: task.sessionKey,
+      sessionFileHash: task.sessionFileHash,
+      projectKey: task.projectKey,
+      attempt: activeAttempt,
+      startedAt: new Date(activeStartedAt).toISOString(),
+    };
+    publishReviewStatus();
+  }
+}
+
+function finishReview(
+  task: KnowledgeReviewTask,
+  outcome: "saved" | "failed",
+  detail: { generationId?: string; result?: PersistKnowledgeResult; error?: unknown },
+): void {
+  clearTimeout(activeDeadlineTimer);
+  activeDeadlineTimer = undefined;
+  if (!reviewStatus) return;
+  reviewStatus.activeReview = undefined;
+  reviewStatus.lastReview = {
+    reviewKey: task.reviewKey,
+    sessionKey: task.sessionKey,
+    attempt: activeAttempt,
+    outcome,
+    completedAt: new Date().toISOString(),
+    durationMs: Math.max(0, Date.now() - activeStartedAt),
+    generationId: detail.generationId,
+    result: detail.result,
+    error: detail.error === undefined ? undefined : boundedError(detail.error),
+  };
+  if (outcome === "saved") reviewAttempts.delete(task.reviewKey);
+  publishReviewStatus();
+}
+
 function removeLeaderMetadata(token: string): void {
   try {
     const current = JSON.parse(readFileSync(paths.knowledgeLeader, "utf8")) as { leaderToken?: string };
@@ -69,7 +139,17 @@ function scheduleElection(delay = Math.floor(Math.random() * 500)): void {
 
 function stepDown(reason: string): void {
   if (activeTask) send({ type: "review_cancel", requestId: activeTask.requestId, reason });
+  if (reviewStatus) {
+    reviewStatus.state = "stepped-down";
+    reviewStatus.stepDownReason = reason;
+    reviewStatus.activeReview = undefined;
+    publishReviewStatus();
+  }
   activeTask = undefined;
+  clearTimeout(activeDeadlineTimer);
+  activeDeadlineTimer = undefined;
+  activeAttempt = 0;
+  activeStartedAt = 0;
   const token = leaderToken;
   leaderToken = "";
   for (const socket of standbySockets) socket.destroy();
@@ -83,6 +163,7 @@ function stepDown(reason: string): void {
     }
   }
   if (token) removeLeaderMetadata(token);
+  reviewStatus = undefined;
 }
 
 function becomeStandby(socket: Socket): void {
@@ -147,6 +228,7 @@ function connectToLeader(probe = 0): void {
 function becomeLeader(server: Server): void {
   leaderServer = server;
   leaderToken = randomUUID();
+  const electedAt = new Date().toISOString();
   server.unref();
   server.on("connection", (socket) => {
     standbySockets.add(socket);
@@ -160,7 +242,11 @@ function becomeLeader(server: Server): void {
     stepDown("coordinator-server-failed");
     scheduleElection();
   });
-  writeLeaderMetadata();
+  writeLeaderMetadata(electedAt);
+  reviewStatus = {
+    version: 1, protocolVersion: 3, state: "leader", pid: process.pid, leaderToken, electedAt, updatedAt: electedAt,
+  };
+  publishReviewStatus();
   send({ type: "leadership", state: "leader", leaderToken });
   void scanForReview();
 }
@@ -186,14 +272,21 @@ function attemptElection(): void {
 
 async function scanForReview(): Promise<void> {
   if (!leaderServer || !leaderToken || activeTask || !sessionsRoot || !eligible) return;
+  if (reviewStatus) {
+    reviewStatus.lastScanAt = new Date().toISOString();
+    reviewStatus.lastScanError = undefined;
+    publishReviewStatus();
+  }
   try {
     const manifest = loadCurrentManifest(home);
     const task = findNextReviewTask(sessionsRoot, manifest.reviews);
     if (!task) return;
     activeTask = task;
+    beginReview(task);
     if (!task.delta) {
       const result = commitKnowledgeReview([], task, leaderToken, home);
       const generationId = loadCurrentManifest(home).generationId;
+      finishReview(task, "saved", { generationId, result });
       send({ type: "review_saved", requestId: task.requestId, generationId, result });
       if (generationId) {
         send({ type: "generation_changed", generationId });
@@ -205,8 +298,13 @@ async function scanForReview(): Promise<void> {
     }
     send({ type: "review_request", leaderToken, requestId: task.requestId, task });
   } catch (error) {
+    if (activeTask) finishReview(activeTask, "failed", { error });
+    else if (reviewStatus) {
+      reviewStatus.lastScanError = { at: new Date().toISOString(), error: boundedError(error) };
+      publishReviewStatus();
+    }
     activeTask = undefined;
-    send({ type: "review_failed", error: error instanceof Error ? error.message : String(error) });
+    send({ type: "review_failed", error: boundedError(error) });
   }
 }
 
@@ -218,6 +316,7 @@ function handleReviewResult(message: Extract<KnowledgeWorkerInput, { type: "revi
     if (message.error || message.raw === undefined) throw new Error(message.error || "Knowledge review returned no content");
     const result = commitKnowledgeReview(parseCandidateEnvelope(message.raw), task, leaderToken, home);
     const generationId = loadCurrentManifest(home).generationId;
+    finishReview(task, "saved", { generationId, result });
     send({ type: "review_saved", requestId: task.requestId, generationId, result });
     if (generationId) {
       send({ type: "generation_changed", generationId });
@@ -225,7 +324,8 @@ function handleReviewResult(message: Extract<KnowledgeWorkerInput, { type: "revi
     }
     committed = true;
   } catch (error) {
-    send({ type: "review_failed", requestId: task.requestId, error: error instanceof Error ? error.message : String(error) });
+    finishReview(task, "failed", { error });
+    send({ type: "review_failed", requestId: task.requestId, error: boundedError(error) });
   } finally {
     activeTask = undefined;
     if (committed) queueMicrotask(() => void scanForReview());

package/.pi/lib/knowledge/sanitize.ts

@@ -24,3 +24,23 @@ export function compactKnowledgeText(value: string, maxChars: number): string {
     .trim()
     .slice(0, maxChars);
 }
+
+export function compactKnowledgeSummary(value: string, maxChars: number): string {
+  const normalized = sanitizeKnowledgeText(value).replace(/\s+/gu, " ").trim();
+  if (normalized.length <= maxChars || maxChars <= 0) return normalized.slice(0, Math.max(0, maxChars));
+  if (maxChars === 1) return "…";
+  const limit = maxChars - 1;
+  const prefix = normalized.slice(0, limit);
+  const minimumBoundary = Math.floor(limit * 0.6);
+  const sentenceEnd = Math.max(
+    prefix.lastIndexOf("。"), prefix.lastIndexOf("！"), prefix.lastIndexOf("？"),
+    prefix.lastIndexOf("."), prefix.lastIndexOf("!"), prefix.lastIndexOf("?"),
+  );
+  if (sentenceEnd >= minimumBoundary) return prefix.slice(0, sentenceEnd + 1).trimEnd();
+  const next = normalized.charAt(limit);
+  if (/[A-Za-z0-9]/u.test(prefix.at(-1) ?? "") && /[A-Za-z0-9]/u.test(next)) {
+    const wordBoundary = Math.max(prefix.lastIndexOf(" "), prefix.lastIndexOf("-"), prefix.lastIndexOf("/"));
+    if (wordBoundary >= minimumBoundary) return `${prefix.slice(0, wordBoundary).trimEnd()}…`;
+  }
+  return `${prefix.trimEnd()}…`;
+}

package/.pi/lib/knowledge/session-scanner.ts

@@ -19,6 +19,9 @@ interface ReviewPiece {
   text: string;
 }
 
+const FAILURE_EVIDENCE_RE = /(?:\b(?:error|failed|failure|invalid|unsupported|mistyp(?:e|ed)|typo)\b|not supported|失败|错误|不支持|无效)/iu;
+const INJECTED_SKILL_RE = /<skill\b[^>]*>[\s\S]*?<\/skill>/giu;
+
 function hash(value: string, length = 64): string {
   return createHash("sha256").update(value).digest("hex").slice(0, length);
 }
@@ -35,20 +38,21 @@ function textContent(content: unknown): string {
 
 function reviewPiece(entry: SessionEntry, index: number): ReviewPiece | undefined {
   if (entry.type === "compaction" || entry.type === "branch_summary") {
-    return { index, priority: 1, category: "summary", text: `[summary]\n${sanitizeKnowledgeText(entry.summary).slice(0, 6_000)}` };
+    return { index, priority: 2, category: "summary", text: `[summary]\n${sanitizeKnowledgeText(entry.summary).slice(0, 6_000)}` };
   }
   if (entry.type === "custom" && entry.customType.startsWith("hwcode-workflow")) {
     return {
-      index, priority: 0, category: "workflow",
+      index, priority: 1, category: "workflow",
       text: `[workflow_state:${entry.customType}]\n${sanitizeKnowledgeText(JSON.stringify(entry.data ?? {})).slice(0, 6_000)}`,
     };
   }
   if (entry.type !== "message" || !entry.message || typeof entry.message !== "object") return undefined;
   const message = entry.message as unknown as Record<string, unknown>;
   const role = typeof message.role === "string" ? message.role : "message";
-  const content = sanitizeKnowledgeText(textContent(message.content));
+  const content = sanitizeKnowledgeText(textContent(message.content).replace(INJECTED_SKILL_RE, "[loaded skill omitted]"));
   if (!content) return undefined;
-  const priority = role === "user" ? 0 : role === "toolResult" ? 3 : 2;
+  const priority = role === "user" ? 0 : role === "toolResult" && FAILURE_EVIDENCE_RE.test(content) ? 2
+    : role === "toolResult" ? 4 : 3;
   const cap = role === "user" ? 8_000 : role === "toolResult" ? 1_500 : 4_000;
   const category = role === "user" ? "user" : role === "toolResult" ? "tool" : "assistant";
   return { index, priority, category, text: `[${role}]\n${content.slice(0, cap)}` };
@@ -61,14 +65,43 @@ function buildDelta(entries: SessionEntry[]): string {
     user: 14_000, workflow: 6_000, summary: 4_000, assistant: 8_000, tool: 4_000,
   };
   let remaining = KNOWLEDGE_RUNTIME_DEFAULTS.review.maxDeltaChars;
-  for (const piece of pieces.slice().sort((left, right) => left.priority - right.priority || left.index - right.index)) {
+  for (const piece of pieces.slice().sort((left, right) => {
+    if (left.priority !== right.priority) return left.priority - right.priority;
+    if (left.category === right.category && left.category !== "user") return right.index - left.index;
+    return left.index - right.index;
+  })) {
     if (remaining <= 0) break;
-    const text = piece.text.slice(0, Math.min(remaining, categoryRemaining[piece.category]));
+    const separatorCharacters = selected.length > 0 ? 2 : 0;
+    if (remaining <= separatorCharacters) break;
+    const text = piece.text.slice(0, Math.min(remaining - separatorCharacters, categoryRemaining[piece.category]));
     if (text) selected.push({ ...piece, text });
-    remaining -= text.length;
+    remaining -= text.length + separatorCharacters;
     categoryRemaining[piece.category] -= text.length;
   }
-  return selected.sort((left, right) => left.index - right.index).map((piece) => piece.text).join("\n\n");
+  return selected.sort((left, right) => left.index - right.index).map((piece) => piece.text).join("\n\n")
+    .slice(0, KNOWLEDGE_RUNTIME_DEFAULTS.review.maxDeltaChars);
+}
+
+function buildValidationContext(entries: SessionEntry[]): string {
+  const pieces = entries.map(reviewPiece).filter((piece): piece is ReviewPiece => Boolean(piece));
+  const latestWorkflow = pieces.filter((piece) => piece.category === "workflow").at(-1);
+  const evidence = pieces.filter((piece) => (
+    (piece.category === "tool" || piece.category === "assistant" || piece.category === "summary")
+    && FAILURE_EVIDENCE_RE.test(piece.text)
+  ));
+  if (latestWorkflow && !evidence.includes(latestWorkflow)) evidence.push(latestWorkflow);
+  let remaining = KNOWLEDGE_RUNTIME_DEFAULTS.review.maxPriorContextChars;
+  const selected: ReviewPiece[] = [];
+  for (const piece of evidence.slice().sort((left, right) => right.index - left.index)) {
+    if (remaining <= 0) break;
+    const separatorCharacters = selected.length > 0 ? 2 : 0;
+    if (remaining <= separatorCharacters) break;
+    const text = piece.text.slice(0, remaining - separatorCharacters);
+    if (text) selected.push({ ...piece, text });
+    remaining -= text.length + separatorCharacters;
+  }
+  return selected.sort((left, right) => left.index - right.index).map((piece) => piece.text).join("\n\n")
+    .slice(0, KNOWLEDGE_RUNTIME_DEFAULTS.review.maxPriorContextChars);
 }
 
 function projectRootForSession(header: SessionHeader, branch: SessionEntry[]): string {
@@ -120,6 +153,7 @@ export function readReviewTask(
   const pending = branch.slice(cursorIndex + 1);
   if (pending.length === 0) return undefined;
   const delta = buildDelta(pending);
+  const context = cursorIndex >= 0 ? buildValidationContext(branch.slice(0, cursorIndex + 1)) : "";
   const firstEntryId = pending[0].id;
   const lastEntryId = pending[pending.length - 1].id;
   const deltaDigest = knowledgeDeltaDigest(delta || `${firstEntryId}\0${lastEntryId}`);
@@ -130,7 +164,7 @@ export function readReviewTask(
   return {
     requestId: randomUUID(), reviewKey, sessionId: header.id, sessionKey, sessionFileHash,
     projectRoot, projectKey: projectKnowledgeKey(projectRoot),
-    firstEntryId, lastEntryId, delta, deltaDigest, fileSize: stat.size, fileMtimeMs: stat.mtimeMs,
+    firstEntryId, lastEntryId, context, delta, deltaDigest, fileSize: stat.size, fileMtimeMs: stat.mtimeMs,
   };
 }