@hachej/boring-feedback 0.4.2 → 0.4.3

package/dist/ui/session.d.ts

@@ -57,6 +57,8 @@ export interface SessionNote {
     readonly fallback?: string;
     /** The anchor's development source location (`src/settings/SaveBar.tsx:42`), when it has one. */
     readonly source?: string;
+    /** The `data-feedback-id` of the element, or else of its nearest marked ancestor, when the policy kept it: what a host viewer matches pins on. */
+    readonly feedbackId?: string;
     readonly from?: 'voice';
     /** Pinned while recording: its note is what was said there (empty until transcribed, or when nothing was). */
     readonly recorded?: true;
@@ -137,6 +139,10 @@ export interface FeedbackSession extends ExternalState<FeedbackSessionSnapshot>
     readonly start: (options?: SessionStartOptions) => void;
     /** From the review, back to picking with the notes kept (more notes before Send); otherwise like `start`. */
     readonly resume: (options?: SessionStartOptions) => void;
+    /** A trusted viewer's host-DOM proxy for an opaque frame pick. Uses the same root, privacy and anchor checks as page picking. */
+    readonly pick: (element: Element) => void;
+    /** A trusted viewer moved its proxy elements. Refreshes pin and bubble placement without changing the notes. */
+    readonly reposition: () => void;
     /** Done: closes feedback mode, transcribes and aligns voice, and leaves the draft for review. */
     readonly done: () => Promise<void>;
     /** ✕: discards everything (feedback mode or the attached draft). */

package/dist/ui/session.js

@@ -43,6 +43,24 @@ function readTranscription(answer) {
 const NAMED_KEYS = new Set(['Enter', 'Escape', 'Tab', 'ArrowUp', 'ArrowDown', 'ArrowLeft', 'ArrowRight', 'PageUp', 'PageDown', 'Home', 'End']);
 const MAX_ELEMENTS = 500;
 const MAX_TRAIL = 5000;
+/** The anchor's own `data-feedback-id`, or the one its path starts from (`[data-feedback-id="…"]`: its nearest marked ancestor). */
+function markedId(signals) {
+    if (signals === null || typeof signals !== 'object' || Array.isArray(signals))
+        return undefined;
+    const { feedbackId, path } = signals;
+    if (typeof feedbackId === 'string')
+        return feedbackId;
+    const base = Array.isArray(path) && typeof path[0] === 'string' ? /^\[data-feedback-id=(".*")\]$/.exec(path[0])?.[1] : undefined;
+    if (base === undefined)
+        return undefined;
+    try {
+        const value = JSON.parse(base);
+        return typeof value === 'string' ? value : undefined;
+    }
+    catch {
+        return undefined;
+    }
+}
 /** Point mode is on (or finishing): the host hides its panel while this is true and shows it again when it turns false. */
 export function isPointing(state) {
     return state.mode === 'point' && (state.phase === 'active' || state.phase === 'processing');
@@ -122,8 +140,9 @@ export function createFeedbackSession(options) {
             const signals = anchor?.['signals'];
             const found = signals !== null && typeof signals === 'object' && !Array.isArray(signals) ? signals.source : undefined;
             const source = typeof found === 'string' ? found : undefined;
+            const feedbackId = markedId(signals);
             return Object.freeze({ id: note.id, number: index + 1, text: note.text, label: labelOf(note), ...(anchor ? { fallback: String(anchor['fallback']) } : {}),
-                ...(source !== undefined ? { source } : {}), ...(note.from ? { from: note.from } : {}), ...(note.recorded ? { recorded: true } : {}) });
+                ...(source !== undefined ? { source } : {}), ...(feedbackId !== undefined ? { feedbackId } : {}), ...(note.from ? { from: note.from } : {}), ...(note.recorded ? { recorded: true } : {}) });
         });
         const open = bubble ? list.find(note => note.id === bubble.noteId) : undefined;
         const { bubble: _bubble, problem: _problem, hover: _hover, ...base } = { ...state.getSnapshot(), ...change };
@@ -729,6 +748,12 @@ export function createFeedbackSession(options) {
         subscribe: state.subscribe,
         start,
         resume,
+        pick: element => {
+            if (state.getSnapshot().using || pickRefusal(element, root) !== undefined)
+                return;
+            onPick(element);
+        },
+        reposition: () => publish(),
         done,
         discard,
         setBubbleText: text => { if (bubble) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hachej/boring-feedback",
-  "version": "0.4.2",
+  "version": "0.4.3",
   "license": "MIT",
   "private": false,
   "type": "module",
@@ -52,9 +52,9 @@
     }
   },
   "peerDependencies": {
-    "@hachej/boring-ui-kit": "^0.4.2",
-    "@hachej/boring-files": "^0.4.2",
-    "@hachej/boring-agent": "^0.4.2",
+    "@hachej/boring-ui-kit": "^0.4.3",
+    "@hachej/boring-files": "^0.4.3",
+    "@hachej/boring-agent": "^0.4.3",
     "@earendil-works/pi-durable": "~1.2.0",
     "@earendil-works/pi-ai": "~1.2.0",
     "@earendil-works/chord": "~1.2.0",