@h-rig/runtime 0.0.6-alpha.22 → 0.0.6-alpha.23

package/dist/src/control-plane/native/verifier.js

@@ -1775,6 +1775,57 @@ function flattenPaginatedArray(value) {
   }
   return value;
 }
+function parseConcatenatedJsonValues(value) {
+  const text = value.trim();
+  const docs = [];
+  let start = null;
+  let depth = 0;
+  let inString = false;
+  let escape = false;
+  for (let index = 0;index < text.length; index += 1) {
+    const char = text[index];
+    if (start === null) {
+      if (/\s/.test(char))
+        continue;
+      start = index;
+    }
+    if (inString) {
+      if (escape) {
+        escape = false;
+      } else if (char === "\\") {
+        escape = true;
+      } else if (char === '"') {
+        inString = false;
+      }
+      continue;
+    }
+    if (char === '"') {
+      inString = true;
+      continue;
+    }
+    if (char === "{" || char === "[") {
+      depth += 1;
+      continue;
+    }
+    if (char === "}" || char === "]") {
+      depth -= 1;
+      if (depth < 0)
+        return { value: docs, error: "unexpected JSON close delimiter" };
+      if (depth === 0 && start !== null) {
+        const segment = text.slice(start, index + 1);
+        try {
+          docs.push(JSON.parse(segment));
+        } catch (error) {
+          return { value: docs, error: error instanceof Error ? error.message : String(error) };
+        }
+        start = null;
+      }
+    }
+  }
+  if (inString || depth !== 0 || start !== null)
+    return { value: docs, error: "incomplete JSON stream" };
+  return { value: docs };
+}
 function parseJsonArray(value) {
   if (!value?.trim())
     return { value: [], error: "empty JSON output" };
@@ -1783,7 +1834,11 @@ function parseJsonArray(value) {
     const flattened = flattenPaginatedArray(parsed);
     return flattened ? { value: flattened } : { value: [], error: "JSON output was not an array" };
   } catch (error) {
-    return { value: [], error: error instanceof Error ? error.message : String(error) };
+    const streamed = parseConcatenatedJsonValues(value);
+    if (streamed.error)
+      return { value: [], error: error instanceof Error ? error.message : String(error) };
+    const flattened = streamed.value.flatMap((entry) => flattenPaginatedArray(entry) ?? []);
+    return flattened.length > 0 || streamed.value.length === 0 ? { value: flattened } : { value: [], error: "JSON output was not an array" };
   }
 }
 function parseGithubPrUrl(prUrl) {
@@ -1872,6 +1927,24 @@ function isStrictFiveOfFive(score) {
 function containsConflictingScoreText(input) {
   return parseGreptileScores(input).some((score) => !isStrictFiveOfFive(score));
 }
+function extractGreptileCommentBlock(input) {
+  const match = input.match(/<!--\s*greptile_comment\s*-->([\s\S]*?)<!--\s*\/greptile_comment\s*-->/i);
+  return match?.[1]?.trim() ?? null;
+}
+function extractGreptileBodyReviewedSha(input) {
+  const block = extractGreptileCommentBlock(input);
+  if (!block)
+    return null;
+  const commitLink = block.match(/\/commit\/([0-9a-f]{40})(?:\b|[^0-9a-f])/i);
+  return commitLink?.[1]?.toLowerCase() ?? null;
+}
+function isoAtOrAfter(value, floor) {
+  if (!value || !floor)
+    return false;
+  const valueMs = Date.parse(value);
+  const floorMs = Date.parse(floor);
+  return Number.isFinite(valueMs) && Number.isFinite(floorMs) && valueMs >= floorMs;
+}
 function greptileStatusVerdict(status) {
   const normalized = String(status ?? "").trim().toUpperCase().replace(/[\s-]+/g, "_");
   if (!normalized)
@@ -2246,9 +2319,18 @@ function commentAuthorLogin(comment) {
 }
 function collectGreptileSignals(evidence) {
   const signals = [];
+  const greptileBodyReviewedSha = extractGreptileBodyReviewedSha(evidence.body);
+  const trustedGreptileBody = Boolean(greptileBodyReviewedSha && isGreptileGithubLogin(evidence.bodyEditorLogin) && isoAtOrAfter(evidence.bodyLastEditedAt, evidence.headCommittedDate));
   const contextSources = [
     { source: "pr-title", body: evidence.title ?? "" },
-    { source: "pr-body", body: evidence.body }
+    {
+      source: "pr-body",
+      body: evidence.body,
+      trusted: trustedGreptileBody,
+      authorLogin: trustedGreptileBody ? evidence.bodyEditorLogin ?? null : null,
+      reviewedSha: greptileBodyReviewedSha,
+      verdict: trustedGreptileBody ? "completed" : null
+    }
   ];
   for (const context of contextSources) {
     if (!context.body.trim())
@@ -2260,7 +2342,10 @@ function collectGreptileSignals(evidence) {
       source: context.source,
       body: context.body,
       currentHeadSha: evidence.currentHeadSha,
-      trusted: false,
+      trusted: context.trusted === true,
+      authorLogin: context.authorLogin,
+      reviewedSha: context.reviewedSha,
+      verdict: context.verdict,
       blocker: contextBlocker,
       actionable: contextBlocker
     }));
@@ -2456,7 +2541,7 @@ function deriveGreptileEvidence(input) {
   const hasGreptileEvidence = trustedSignals.length > 0 || signals.some((signal) => /greptile/i.test(signal.body));
   const approved = fresh && completed && !blockers.length && !unresolvedComments.length && currentPendingApiSignals.length === 0 && (approvedByScore || approvedByExplicitMapping);
   const mapping = !hasGreptileEvidence ? "missing" : staleSignals.length > 0 && !approvingSignal ? "stale" : approvedByScore ? "score-5-of-5" : approvedByExplicitMapping ? "explicit-approved" : "unproven";
-  const source = approvingSignal?.source === "api" ? "api" : approvingSignal?.source === "github-review" ? "github-review" : approvingSignal?.source === "changed-file-comment" || approvingSignal?.source === "issue-comment" || approvingSignal?.source === "review-thread" ? "github-comment" : greptileReviews.length > 0 && greptileChecks.length > 0 ? "combined" : greptileReviews.length > 0 ? "github-review" : greptileChecks.length > 0 ? "github-check" : signals.some((signal) => signal.source === "pr-body" || signal.source === "pr-title") ? "pr-body" : "missing";
+  const source = approvingSignal?.source === "api" ? "api" : approvingSignal?.source === "github-review" ? "github-review" : approvingSignal?.source === "pr-body" || approvingSignal?.source === "pr-title" ? "pr-body" : approvingSignal?.source === "changed-file-comment" || approvingSignal?.source === "issue-comment" || approvingSignal?.source === "review-thread" ? "github-comment" : greptileReviews.length > 0 && greptileChecks.length > 0 ? "combined" : greptileReviews.length > 0 ? "github-review" : greptileChecks.length > 0 ? "github-check" : signals.some((signal) => signal.source === "pr-body" || signal.source === "pr-title") ? "pr-body" : "missing";
   return {
     source,
     currentHeadSha: input.currentHeadSha,
@@ -2477,17 +2562,48 @@ function isGreptileCheckDetail(check) {
   return isGreptileLabel(checkName(check)) || isGreptileGithubLogin(check.app?.slug) || isGreptileGithubLogin(check.app?.owner?.login) || isGreptileLabel(check.app?.name);
 }
 async function collectGreptileCheckDetails(input) {
-  const checkRunsRead = await runJsonArray(input.command, [
+  const checkRunsRead = await runJsonObject(input.command, [
     "api",
     `repos/${input.repoName}/commits/${input.headSha}/check-runs`,
-    "--paginate",
-    "--slurp",
-    "--jq",
-    "map(.check_runs // []) | add // []"
+    "-F",
+    "per_page=100"
   ], input.projectRoot);
-  const checkRuns = checkRunsRead.value.map(normalizeStatusCheck).filter((entry) => !!entry).filter(isGreptileCheckDetail);
+  const checkRuns = arrayField(checkRunsRead.value, "check_runs").map(normalizeStatusCheck).filter((entry) => !!entry).filter(isGreptileCheckDetail);
   return checkRunsRead.error ? { value: checkRuns, error: checkRunsRead.error } : { value: checkRuns };
 }
+async function collectPullRequestProvenance(input) {
+  const response = await runJsonObject(input.command, [
+    "api",
+    "graphql",
+    "-F",
+    `owner=${input.owner}`,
+    "-F",
+    `name=${input.name}`,
+    "-F",
+    `prNumber=${input.prNumber}`,
+    "-f",
+    "query=query($owner: String!, $name: String!, $prNumber: Int!) { repository(owner:$owner, name:$name) { pullRequest(number:$prNumber) { lastEditedAt editor { login } commits(last: 1) { nodes { commit { oid committedDate } } } } } }"
+  ], input.projectRoot);
+  if (response.error)
+    return { value: {}, error: response.error };
+  const data = response.value.data;
+  const repository = data?.repository;
+  const pullRequest = repository?.pullRequest;
+  if (!pullRequest)
+    return { value: {}, error: "GitHub pullRequest provenance response did not include a pullRequest object" };
+  const editor = pullRequest.editor;
+  const commits = pullRequest.commits;
+  const nodes = Array.isArray(commits?.nodes) ? commits.nodes : [];
+  const latestCommitNode = nodes[nodes.length - 1];
+  const latestCommit = latestCommitNode?.commit;
+  return {
+    value: {
+      bodyEditorLogin: typeof editor?.login === "string" ? editor.login : null,
+      bodyLastEditedAt: typeof pullRequest.lastEditedAt === "string" ? pullRequest.lastEditedAt : null,
+      headCommittedDate: typeof latestCommit?.committedDate === "string" ? latestCommit.committedDate : null
+    }
+  };
+}
 async function collectReviewThreads(input) {
   const reviewThreads = [];
   let afterCursor = null;
@@ -2565,11 +2681,19 @@ async function collectPrReviewEvidence(input) {
   const baseRefName = firstString(view, ["baseRefName"]);
   const statusCheckRollup = arrayField(view, "statusCheckRollup").map(normalizeStatusCheck).filter((entry) => !!entry);
   const reviews = arrayField(view, "reviews").map(normalizeReview).filter((entry) => !!entry);
-  const reviewCommentsRead = await runJsonArray(input.command, ["api", `repos/${parsed.repoName}/pulls/${parsed.prNumber}/comments`, "--paginate", "--slurp"], input.projectRoot);
+  const provenanceRead = await collectPullRequestProvenance({
+    command: input.command,
+    projectRoot: input.projectRoot,
+    owner: parsed.owner,
+    name: parsed.repo,
+    prNumber: parsed.prNumber
+  });
+  const provenance = provenanceRead.value;
+  const reviewCommentsRead = await runJsonArray(input.command, ["api", `repos/${parsed.repoName}/pulls/${parsed.prNumber}/comments`, "--paginate"], input.projectRoot);
   if (reviewCommentsRead.error)
     readErrors.push(reviewCommentsRead.error);
   const reviewComments = reviewCommentsRead.value.map(normalizeReviewComment).filter((entry) => !!entry);
-  const issueCommentsRead = await runJsonArray(input.command, ["api", `repos/${parsed.repoName}/issues/${parsed.prNumber}/comments`, "--paginate", "--slurp"], input.projectRoot);
+  const issueCommentsRead = await runJsonArray(input.command, ["api", `repos/${parsed.repoName}/issues/${parsed.prNumber}/comments`, "--paginate"], input.projectRoot);
   if (issueCommentsRead.error)
     readErrors.push(issueCommentsRead.error);
   const issueComments = issueCommentsRead.value.map(normalizeIssueComment).filter((entry) => !!entry).filter(relevantIssueComment);
@@ -2592,12 +2716,7 @@ async function collectPrReviewEvidence(input) {
       repoName: parsed.repoName,
       headSha
     });
-    if (checkDetailsRead.error)
-      readErrors.push(checkDetailsRead.error);
     greptileCheckDetails = checkDetailsRead.value;
-    if (!checkDetailsRead.error && greptileCheckDetails.length === 0) {
-      readErrors.push("Greptile check details could not be found for the current PR head");
-    }
   }
   const checksWithGreptileDetails = [...statusCheckRollup, ...greptileCheckDetails];
   const shouldCollectConfiguredGreptileApi = input.greptileApi?.enabled !== false;
@@ -2616,6 +2735,9 @@ async function collectPrReviewEvidence(input) {
   const evidenceBase = {
     title: firstString(view, ["title"]),
     body: firstString(view, ["body"]),
+    bodyEditorLogin: provenance.bodyEditorLogin ?? null,
+    bodyLastEditedAt: provenance.bodyLastEditedAt ?? null,
+    headCommittedDate: provenance.headCommittedDate ?? null,
     reviews,
     changedFileReviewComments: reviewComments,
     relevantIssueComments: issueComments,
@@ -2631,6 +2753,9 @@ async function collectPrReviewEvidence(input) {
     repoName: parsed.repoName,
     title: evidenceBase.title,
     body: evidenceBase.body,
+    bodyEditorLogin: evidenceBase.bodyEditorLogin,
+    bodyLastEditedAt: evidenceBase.bodyLastEditedAt,
+    headCommittedDate: evidenceBase.headCommittedDate,
     headSha,
     headRefName: firstString(view, ["headRefName"]),
     baseRefName,