@h-rig/bundle-default-lifecycle 0.0.6-alpha.157 → 0.0.6-alpha.159

package/dist/src/control-plane/task-verify.js

@@ -1,32 +1,101 @@
 // @bun
-// packages/bundle-default-lifecycle/src/control-plane/task-verify.ts
-import { currentTaskId } from "@rig/runtime/control-plane/native/task-state";
+// packages/bundle-default-lifecycle/src/control-plane/task-data.ts
+import { TASK_DATA_SERVICE_CAPABILITY } from "@rig/contracts";
+import { defineCapability } from "@rig/core/capability";
+import { requireInstalledCapability } from "@rig/core/capability-loaders";
+var TaskDataCap = defineCapability(TASK_DATA_SERVICE_CAPABILITY);
+function taskData() {
+  return requireInstalledCapability(TaskDataCap, "task-data capability unavailable: load @rig/task-sources-plugin (default bundle) before running the lifecycle.");
+}
+
+// packages/bundle-default-lifecycle/src/control-plane/verifier.ts
+import { existsSync as existsSync2, mkdirSync as mkdirSync2, writeFileSync as writeFileSync2 } from "fs";
+import { resolve as resolve2 } from "path";
+import { resolveRuntimeSecrets as resolveRuntimeSecrets2 } from "@rig/core/baked-secrets";
+
+// packages/bundle-default-lifecycle/src/control-plane/native/git-ops.ts
+import { existsSync, lstatSync, mkdirSync, readFileSync, unlinkSync, writeFileSync } from "fs";
+import { dirname, isAbsolute, resolve } from "path";
+import { loadDotEnvSecrets, resolveRuntimeSecrets } from "@rig/core/baked-secrets";
+import { loadRuntimeContext, loadRuntimeContextFromEnv } from "@rig/core/runtime-context";
+import { nowIso, runCapture as baseRunCapture } from "@rig/core/exec";
+import { resolveCheckoutRoot as resolveMonorepoRoot } from "@rig/core/checkout-root";
+import { getScopeRules } from "@rig/core/scope-rules";
+import { safePathSegment } from "@rig/core/safe-identifiers";
+var TASK_ARTIFACT_STAGE_FALLBACK = new Set([
+  "changed-files.txt",
+  "contract-changes.md",
+  "decision-log.md",
+  "git-state.txt",
+  "next-actions.md",
+  "pr-state.json",
+  "task-result.json",
+  "validation-summary.json"
+]);
+function readPrMetadata(projectRoot, taskId) {
+  const path = resolve(taskData().artifactDirForId(projectRoot, taskId), "pr-state.json");
+  if (!existsSync(path)) {
+    return [];
+  }
+  try {
+    const parsed = JSON.parse(readFileSync(path, "utf-8"));
+    if (!parsed || typeof parsed !== "object") {
+      return [];
+    }
+    if (parsed.prs && typeof parsed.prs === "object") {
+      return Object.values(parsed.prs).filter(isGitOpenPrResult);
+    }
+    return isGitOpenPrResult(parsed) ? [parsed] : [];
+  } catch {
+    return [];
+  }
+}
+function isGitOpenPrResult(value) {
+  if (!value || typeof value !== "object" || Array.isArray(value)) {
+    return false;
+  }
+  const record = value;
+  return typeof record.url === "string" && typeof record.branch === "string" && typeof record.base === "string" && (record.target === "project" || record.target === "monorepo") && typeof record.repoLabel === "string";
+}
 
 // packages/bundle-default-lifecycle/src/control-plane/verifier.ts
-import { existsSync, mkdirSync, writeFileSync } from "fs";
-import { resolve } from "path";
-import { resolveRuntimeSecrets } from "@rig/runtime/control-plane/runtime/baked-secrets";
-import { readPrMetadata } from "@rig/runtime/control-plane/native/git-ops";
-import { loadRuntimeContextFromEnv } from "@rig/runtime/control-plane/runtime/context";
-import { readConfiguredTaskSourceTask } from "@rig/runtime/control-plane/tasks/source-lifecycle";
-import { artifactDirForId, lookupTask, readTaskConfig } from "@rig/runtime/control-plane/native/task-state";
-import { nowIso, resolveHarnessPaths, runCapture } from "@rig/runtime/control-plane/native/utils";
-import {
-  collectPrReviewEvidence,
-  evaluateStrictPrMergeGate,
-  parseGreptileScore,
-  stripHtml
-} from "@rig/pr-review-plugin";
+import { loadRuntimeContextFromEnv as loadRuntimeContextFromEnv2 } from "@rig/core/runtime-context";
+import { nowIso as nowIso2, runCapture } from "@rig/core/exec";
+import { resolveHarnessPaths } from "@rig/core/harness-paths";
+
+// packages/bundle-default-lifecycle/src/control-plane/pr-merge-gate-cap.ts
+import { PR_MERGE_GATE } from "@rig/contracts";
+import { defineCapability as defineCapability2 } from "@rig/core/capability";
+import { resolvePluginHost } from "@rig/core/project-plugins";
+var PrMergeGateCap = defineCapability2(PR_MERGE_GATE);
+async function resolvePrMergeGateService(projectRoot) {
+  const { host } = await resolvePluginHost(projectRoot);
+  return PrMergeGateCap.require(host);
+}
+
+// packages/bundle-default-lifecycle/src/control-plane/verifier.ts
+var mergeGateHolder = null;
+async function ensureMergeGate(projectRoot) {
+  mergeGateHolder = await resolvePrMergeGateService(projectRoot);
+  return mergeGateHolder;
+}
+function mg() {
+  if (!mergeGateHolder) {
+    throw new Error("PR merge-gate capability not resolved (verifyTask must run first).");
+  }
+  return mergeGateHolder;
+}
 async function verifyTask(options) {
+  await ensureMergeGate(options.projectRoot);
   const paths = resolveHarnessPaths(options.projectRoot);
   const taskId = options.taskId;
-  const normalizedTaskId = lookupTask(options.projectRoot, taskId);
-  const artifactDir = artifactDirForId(options.projectRoot, taskId);
-  mkdirSync(artifactDir, { recursive: true });
-  const validationSummaryPath = resolve(artifactDir, "validation-summary.json");
-  const reviewFeedbackPath = resolve(artifactDir, "review-feedback.md");
-  const reviewStatePath = resolve(artifactDir, "review-state.json");
-  const greptileRawPath = resolve(artifactDir, "review-greptile-raw.json");
+  const normalizedTaskId = taskData().lookupTask(options.projectRoot, taskId);
+  const artifactDir = taskData().artifactDirForId(options.projectRoot, taskId);
+  mkdirSync2(artifactDir, { recursive: true });
+  const validationSummaryPath = resolve2(artifactDir, "validation-summary.json");
+  const reviewFeedbackPath = resolve2(artifactDir, "review-feedback.md");
+  const reviewStatePath = resolve2(artifactDir, "review-state.json");
+  const greptileRawPath = resolve2(artifactDir, "review-greptile-raw.json");
   const prStates = readPrMetadata(options.projectRoot, taskId);
   const prState = prStates[0] || null;
   const localReasons = [];
@@ -38,7 +107,7 @@ async function verifyTask(options) {
   if (!normalizedTaskId && !await hasConfiguredSourceTask(options.projectRoot, taskId)) {
     localReasons.push(`[Task Config] Unknown task id '${taskId}' in task-config or configured task source.`);
   }
-  if (!existsSync(validationSummaryPath)) {
+  if (!existsSync2(validationSummaryPath)) {
     localReasons.push(`[Artifact Quality] validation-summary.json not found at ${validationSummaryPath}.`);
   } else {
     const summary = await parseValidationSummary(validationSummaryPath);
@@ -47,13 +116,13 @@ async function verifyTask(options) {
     }
   }
   for (const file of ["task-result.json", "decision-log.md", "next-actions.md", "changed-files.txt"]) {
-    const requiredPath = resolve(artifactDir, file);
-    if (!existsSync(requiredPath)) {
+    const requiredPath = resolve2(artifactDir, file);
+    if (!existsSync2(requiredPath)) {
       localReasons.push(`[Artifact Quality] Missing required artifact file: ${requiredPath}`);
     }
   }
-  const taskResultPath = resolve(artifactDir, "task-result.json");
-  if (existsSync(taskResultPath)) {
+  const taskResultPath = resolve2(artifactDir, "task-result.json");
+  if (existsSync2(taskResultPath)) {
     const taskResult = await readJsonFile(taskResultPath);
     const artifactStatus = typeof taskResult?.status === "string" ? taskResult.status.trim().toLowerCase() : "";
     if (artifactStatus === "partial") {
@@ -66,8 +135,8 @@ async function verifyTask(options) {
       localReasons.push("[Artifact Quality] task-result.json next actions indicate remaining implementation scope.");
     }
   }
-  const nextActionsPath = resolve(artifactDir, "next-actions.md");
-  if (existsSync(nextActionsPath)) {
+  const nextActionsPath = resolve2(artifactDir, "next-actions.md");
+  if (existsSync2(nextActionsPath)) {
     const nextActionsContent = await Bun.file(nextActionsPath).text();
     if (nextActionsContent.includes("TODO: Replace this scaffold") || nextActionsContent.includes("bd-<downstream-task-id>")) {
       localReasons.push("[Artifact Quality] next-actions.md still contains scaffold placeholder text. Replace with real recommendations.");
@@ -98,7 +167,7 @@ async function verifyTask(options) {
       aiReasons.push(`[AI Review] Required mode needs a completed Greptile approval; current verdict is ${ai.verdict}.`);
     }
     if (persistArtifacts && ai.rawResponse) {
-      writeFileSync(greptileRawPath, `${ai.rawResponse}
+      writeFileSync2(greptileRawPath, `${ai.rawResponse}
 `, "utf-8");
     }
   } else if (!options.skipAiReview && reviewMode === "off") {
@@ -220,15 +289,15 @@ function nextActionsIndicateRemainingScope(content) {
   return /^\s*- \[ \]/m.test(normalized) || /\b(remaining scope|still need|needs? to be implemented|not yet implemented|not implemented|follow[- ]?up required|blocked by|blocker:)\b/i.test(lower);
 }
 async function hasConfiguredSourceTask(projectRoot, taskId) {
-  return readConfiguredTaskSourceTask(projectRoot, taskId).then((result) => result.task !== null).catch(() => false);
+  return taskData().readConfiguredTaskSourceTask(projectRoot, taskId).then((result) => result.task !== null).catch(() => false);
 }
 function resolveGithubSourceIssueId(projectRoot, taskId) {
-  const fromRuntime = loadRuntimeContextFromEnv()?.sourceTask?.sourceIssueId;
+  const fromRuntime = loadRuntimeContextFromEnv2()?.sourceTask?.sourceIssueId;
   if (typeof fromRuntime === "string" && isGithubSourceIssueId(fromRuntime)) {
     return fromRuntime;
   }
   try {
-    const taskConfig = readTaskConfig(projectRoot);
+    const taskConfig = taskData().readTaskConfig(projectRoot);
     const entry = taskConfig[taskId];
     const sourceIssueId = typeof entry?.sourceIssueId === "string" ? entry.sourceIssueId : typeof entry?.source_issue_id === "string" ? entry.source_issue_id : null;
     if (sourceIssueId && isGithubSourceIssueId(sourceIssueId)) {
@@ -299,14 +368,15 @@ function loadGithubPullRequestCloseoutSnapshot(projectRoot, prState) {
       "--json",
       "state,isDraft,mergeable,mergeStateStatus,reviewDecision,title,body,statusCheckRollup"
     ]);
+    const isDraft = booleanField(view, "isDraft");
     return {
-      state: stringField(view, "state"),
-      isDraft: booleanField(view, "isDraft"),
-      mergeable: stringField(view, "mergeable"),
-      mergeStateStatus: stringField(view, "mergeStateStatus"),
-      reviewDecision: stringField(view, "reviewDecision"),
-      title: stringField(view, "title"),
-      body: stringField(view, "body"),
+      ...objectField("state", stringField(view, "state")),
+      ...isDraft !== undefined ? { isDraft } : {},
+      ...objectField("mergeable", stringField(view, "mergeable")),
+      ...objectField("mergeStateStatus", stringField(view, "mergeStateStatus")),
+      ...objectField("reviewDecision", stringField(view, "reviewDecision")),
+      ...objectField("title", stringField(view, "title")),
+      ...objectField("body", stringField(view, "body")),
       statusCheckRollup: statusCheckRollupField(view, "statusCheckRollup"),
       reviewThreads: loadGithubReviewThreads(projectRoot, repoName, prNumber)
     };
@@ -381,6 +451,9 @@ function stringField(record, key) {
   const value = record[key];
   return typeof value === "string" ? value : undefined;
 }
+function objectField(key, value) {
+  return value === undefined ? {} : { [key]: value };
+}
 function booleanField(record, key) {
   const value = record[key];
   return typeof value === "boolean" ? value : undefined;
@@ -437,7 +510,7 @@ function isAcceptedValidationSummary(summary) {
   return summary.status === "skipped" && summary.total === 0 && summary.failed === 0;
 }
 async function loadReviewMode(reviewProfilePath, fallback) {
-  const parsed = existsSync(reviewProfilePath) ? await readJsonFile(reviewProfilePath) : null;
+  const parsed = existsSync2(reviewProfilePath) ? await readJsonFile(reviewProfilePath) : null;
   const mode = parsed?.mode;
   if (mode === "off" || mode === "advisory" || mode === "required") {
     return mode;
@@ -448,7 +521,7 @@ async function loadReviewMode(reviewProfilePath, fallback) {
   return "advisory";
 }
 async function loadReviewProvider(reviewProfilePath, fallback) {
-  const parsed = existsSync(reviewProfilePath) ? await readJsonFile(reviewProfilePath) : null;
+  const parsed = existsSync2(reviewProfilePath) ? await readJsonFile(reviewProfilePath) : null;
   const provider = parsed?.provider;
   if (typeof provider === "string" && provider.trim().length > 0) {
     return provider;
@@ -471,7 +544,7 @@ function resolveRepoSlug(projectRoot) {
 async function runGreptileReview(options) {
   const reasons = [];
   const warnings = [];
-  const secrets = resolveRuntimeSecrets(process.env);
+  const secrets = resolveRuntimeSecrets2(process.env);
   const apiKey = secrets.GREPTILE_API_KEY || "";
   const apiBase = secrets.GREPTILE_API_BASE || "https://api.greptile.com/mcp";
   const remote = secrets.GREPTILE_REMOTE || "github";
@@ -607,7 +680,7 @@ function writeFeedbackFile(options) {
   if (options.aiRawFeedback) {
     lines.push("## Raw Reviewer Feedback", "", "```text", options.aiRawFeedback, "```", "");
   }
-  writeFileSync(options.output, `${lines.join(`
+  writeFileSync2(options.output, `${lines.join(`
 `)}
 `, "utf-8");
 }
@@ -622,9 +695,9 @@ function writeReviewStateFile(options) {
     local_reasons: options.localReasons,
     ai_reasons: options.aiReasons,
     ai_warnings: options.aiWarnings,
-    updated_at: nowIso()
+    updated_at: nowIso2()
   };
-  writeFileSync(options.output, `${JSON.stringify(payload, null, 2)}
+  writeFileSync2(options.output, `${JSON.stringify(payload, null, 2)}
 `, "utf-8");
 }
 async function runGreptileReviewForPr(options) {
@@ -649,7 +722,6 @@ async function runGreptileReviewForPr(options) {
       taskId: options.taskId,
       prState: options.prState,
       reviewMode: options.reviewMode,
-      infrastructureError: undefined,
       pollAttempts: options.pollAttempts,
       pollIntervalMs: options.pollIntervalMs
     });
@@ -777,7 +849,7 @@ async function runGreptileReviewForPr(options) {
   });
   const actionableComments = filterActionableGreptileComments(commentsPayload.comments || []);
   const reviewBody = reviewDetails.codeReview?.body || "";
-  const score = parseGreptileScore(reviewBody);
+  const score = mg().parseGreptileScore(reviewBody);
   const feedback = [
     `## ${options.prState.repoLabel || repoName} PR Review`,
     "",
@@ -785,7 +857,7 @@ async function runGreptileReviewForPr(options) {
     `- Review ID: ${selectedReview.id}`,
     `- Status: ${selectedReview.status}`,
     "",
-    reviewBody ? stripHtml(reviewBody).trim() : "Greptile completed without summary body."
+    reviewBody ? mg().stripHtml(reviewBody).trim() : "Greptile completed without summary body."
   ].filter(Boolean).join(`
 `);
   if (actionableComments.length > 0) {
@@ -806,7 +878,7 @@ async function runGreptileReviewForPr(options) {
       }
     };
   }
-  const blockerScanBody = stripHtml(reviewBody).replace(/\b(?:no|without|zero)\s+blockers?\b/gi, " ").replace(/\bno\s+changes\s+requested\b/gi, " ");
+  const blockerScanBody = mg().stripHtml(reviewBody).replace(/\b(?:no|without|zero)\s+blockers?\b/gi, " ").replace(/\bno\s+changes\s+requested\b/gi, " ");
   if (/not safe(?: to merge)?|unsafe(?: to merge)?|do not merge|cannot merge|blockers?|must fix|changes requested|please fix|needs? fix|fix this|address this|\breject(?:ed|ion)?\b|\bskip(?:ped)?\b|status\s*:\s*(?:reject(?:ed)?|skip(?:ped)?|failed)/i.test(blockerScanBody)) {
     reasons.push(`[AI Review] ${repoName}#${prNumber} summary indicates the PR is not safe to merge.`);
     return {
@@ -854,7 +926,7 @@ async function runGreptileReviewForPr(options) {
         status: selectedReview.status
       }]
     });
-    strictGate = evaluateStrictPrMergeGate(strictEvidence);
+    strictGate = mg().evaluateGate(strictEvidence);
   } catch (error) {
     reasons.push(`[AI Review] Strict Greptile evidence collection failed for ${repoName}#${prNumber}: ${error instanceof Error ? error.message : String(error)}`);
     return {
@@ -981,7 +1053,7 @@ async function runGithubGreptileFallbackReviewForPr(options) {
     fallbackReview?.html_url ? `- Review: ${fallbackReview.html_url}` : "",
     fallbackReview?.state ? `- Status: ${fallbackReview.state}` : "",
     "",
-    fallbackReview?.body?.trim() ? stripHtml(fallbackReview.body).trim() : "Greptile MCP was unavailable, so verification used GitHub review threads instead."
+    fallbackReview?.body?.trim() ? mg().stripHtml(fallbackReview.body).trim() : "Greptile MCP was unavailable, so verification used GitHub review threads instead."
   ].filter(Boolean).join(`
 `);
   const warnings = buildGithubGreptileFallbackWarnings(options);
@@ -1004,7 +1076,7 @@ async function runGithubGreptileFallbackReviewForPr(options) {
       taskId: options.taskId,
       prUrl
     });
-    strictGate = evaluateStrictPrMergeGate(strictEvidence);
+    strictGate = mg().evaluateGate(strictEvidence);
   } catch (error) {
     return {
       verdict: "REJECT",
@@ -1229,7 +1301,7 @@ function loadGithubPullRequestState(projectRoot, repoName, prNumber) {
   ]);
   return {
     state: response.state || "",
-    merged: response.merged,
+    ...response.merged !== undefined ? { merged: response.merged } : {},
     merged_at: response.merged_at ?? null
   };
 }
@@ -1258,7 +1330,7 @@ function runGhJson(projectRoot, args) {
   }
 }
 async function collectStrictPrEvidenceForVerifier(input) {
-  return collectPrReviewEvidence({
+  return mg().collectEvidence({
     projectRoot: input.projectRoot,
     prUrl: input.prUrl,
     taskId: input.taskId,
@@ -1423,7 +1495,7 @@ function filterActionableGithubGreptileThreads(threads) {
 }
 function resolvePrRepoRoot(projectRoot, prState) {
   const runtimeWorkspace = process.env.RIG_TASK_WORKSPACE?.trim();
-  if (prState.target === "monorepo" && runtimeWorkspace && existsSync(resolve(runtimeWorkspace, ".git"))) {
+  if (prState.target === "monorepo" && runtimeWorkspace && existsSync2(resolve2(runtimeWorkspace, ".git"))) {
     return runtimeWorkspace;
   }
   const paths = resolveHarnessPaths(projectRoot);
@@ -1437,7 +1509,7 @@ function isCommitAncestorOfPrHead(projectRoot, prState, reviewedCommit, headComm
   return runCapture(["git", "-C", repoRoot, "merge-base", "--is-ancestor", reviewedCommit, headCommit], projectRoot).exitCode === 0;
 }
 function summarizeComment(input) {
-  const text = stripHtml(input).replace(/\s+/g, " ").trim();
+  const text = mg().stripHtml(input).replace(/\s+/g, " ").trim();
   return text.length > 160 ? `${text.slice(0, 157)}...` : text;
 }
 function asGreptileInfrastructureWarning(reason) {
@@ -1455,7 +1527,7 @@ function isAiReviewApproved(input) {
 
 // packages/bundle-default-lifecycle/src/control-plane/task-verify.ts
 async function taskVerify(projectRoot, taskId) {
-  const activeTask = taskId || currentTaskId(projectRoot);
+  const activeTask = taskId || taskData().currentTaskId(projectRoot);
   if (!activeTask) {
     throw new Error("No active task.");
   }

package/dist/src/control-plane/verifier.d.ts

@@ -1,4 +1,3 @@
-import { parseGreptileScore } from "@rig/pr-review-plugin";
 export type VerifyOutcome = {
     approved: boolean;
     localReasons: string[];
@@ -104,7 +103,7 @@ declare function shouldPreferGithubGreptileFallback(prState: {
 declare function pickRelevantGithubGreptileReview(reviews: GithubPullRequestReview[], expectedHeadSha: string): GithubPullRequestReview | null;
 declare function pickLatestGithubGreptileReview(reviews: GithubPullRequestReview[]): GithubPullRequestReview | null;
 export declare function evaluatePullRequestCiChecks(checks: GithubStatusCheckRollupItem[], repoName: string, prNumber: number, options?: {
-    mergeStateStatus?: string;
+    mergeStateStatus?: string | undefined;
 }): {
     verdict: "APPROVE" | "REJECT" | "SKIP";
     reasons: string[];
@@ -125,7 +124,6 @@ export declare const __testOnly: {
     filterActionableGithubGreptileThreads: typeof filterActionableGithubGreptileThreads;
     isGithubGreptileCheckApproved: typeof isGithubGreptileCheckApproved;
     isAiReviewApproved: typeof isAiReviewApproved;
-    parseGreptileScore: typeof parseGreptileScore;
     pickLatestGithubGreptileReview: typeof pickLatestGithubGreptileReview;
     pickRelevantGithubGreptileReview: typeof pickRelevantGithubGreptileReview;
     resolveGreptileRequestTimeoutMs: typeof resolveGreptileRequestTimeoutMs;