@gusnips/react 0.9.2 → 0.9.3

package/README.md

@@ -34,9 +34,11 @@ token when you use it, so the losers of that race each invalidate the winner —
 signed out in the middle of a load that was working. Three separate codebases arrived at
 single-flight refresh independently. This is that.
 
-**A refresh that never reached the server is not a "no".** Dropping a packet tells you nothing
-about whether a session is good. So `refresh()` answers `{ token, reachedAuth }`, and only a real
-refusal signs anyone out. Before that split, a Wi-Fi blip logged people out mid-load.
+**Only auth ANSWERING is a "no".** Dropping a packet tells you nothing about whether a session is
+good, and neither does a 500 — that is auth failing, not auth answering. So `refresh()` answers
+`{ token, reachedAuth }`, and only a real refusal signs anyone out. Before that split, a Wi-Fi
+blip logged people out mid-load; without the second half, one bad minute at the auth server signs
+out everybody whose token happened to need refreshing.
 
 **A sign-out has a fail-safe timer.** Awaiting `signOut()` before redirecting covers a rejection,
 not a hang — and a hang leaves someone signed out in name only: every request 401ing, nothing
@@ -63,8 +65,9 @@ Supabase email links have two complete patterns. Keep either one, never half of
   implicit `#access_token` or a PKCE `?code`; it does not consume `token_hash`.
 
 Recovery and invite links continue to the new-password screen after the session opens. A callback
-must also tell a used or expired link apart from a request that never reached GoTrue: the first
-needs a new link, while the second can retry the same one.
+must also tell a used or expired link apart from a request that never landed — or one that landed
+and came back 5xx: the first needs a new link, and the other two can retry the same one, because
+the hash was never spent.
 
 There is also a deadline on every request, which none of the codebases this came from had. A
 request with no timeout is a spinner with no end.

package/dist/supabase-session.d.ts

@@ -19,9 +19,10 @@ export interface SupabaseSessionAuth {
 /**
  * Connects a Supabase auth client to {@link SessionAdapter}.
  *
- * The distinction this preserves is the one that decides whether anybody is signed out: a
- * retryable fetch error never reached GoTrue and says nothing about the session; any other auth
- * error is an answer. A thrown network error stays on the first side of that line too.
+ * The distinction this preserves is the one that decides whether anybody is signed out: only
+ * auth ANSWERING proves a session is gone. A fetch that never landed says nothing about it, and
+ * neither does a 5xx, which is auth failing rather than auth answering. A thrown network error
+ * stays on that side of the line too.
  */
 export declare function createSupabaseSessionAdapter(auth: SupabaseSessionAuth): SessionAdapter;
 export {};

package/dist/supabase-session.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"supabase-session.d.ts","sourceRoot":"","sources":["../src/supabase-session.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAEtD,UAAU,qBAAqB;IAC7B,IAAI,EAAE;QAAE,OAAO,EAAE;YAAE,YAAY,EAAE,MAAM,CAAA;SAAE,GAAG,IAAI,CAAA;KAAE,CAAC;CACpD;AAED,8FAA8F;AAC9F,MAAM,WAAW,mBAAmB;IAClC,UAAU,IAAI,OAAO,CAAC,qBAAqB,CAAC,CAAC;IAC7C,cAAc,IAAI,OAAO,CAAC,qBAAqB,GAAG;QAAE,KAAK,EAAE,OAAO,CAAA;KAAE,CAAC,CAAC;IACtE,OAAO,IAAI,OAAO,CAAC;QAAE,KAAK,EAAE,OAAO,CAAA;KAAE,CAAC,CAAC;CACxC;AAcD;;;;;;GAMG;AACH,wBAAgB,4BAA4B,CAAC,IAAI,EAAE,mBAAmB,GAAG,cAAc,CAsBtF"}
+{"version":3,"file":"supabase-session.d.ts","sourceRoot":"","sources":["../src/supabase-session.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAEtD,UAAU,qBAAqB;IAC7B,IAAI,EAAE;QAAE,OAAO,EAAE;YAAE,YAAY,EAAE,MAAM,CAAA;SAAE,GAAG,IAAI,CAAA;KAAE,CAAC;CACpD;AAED,8FAA8F;AAC9F,MAAM,WAAW,mBAAmB;IAClC,UAAU,IAAI,OAAO,CAAC,qBAAqB,CAAC,CAAC;IAC7C,cAAc,IAAI,OAAO,CAAC,qBAAqB,GAAG;QAAE,KAAK,EAAE,OAAO,CAAA;KAAE,CAAC,CAAC;IACtE,OAAO,IAAI,OAAO,CAAC;QAAE,KAAK,EAAE,OAAO,CAAA;KAAE,CAAC,CAAC;CACxC;AAsBD;;;;;;;GAOG;AACH,wBAAgB,4BAA4B,CAAC,IAAI,EAAE,mBAAmB,GAAG,cAAc,CAsBtF"}

package/dist/supabase-session.js

@@ -2,6 +2,15 @@ import { isAuthError, isAuthRetryableFetchError } from "@supabase/supabase-js";
 function reachedAuth(error) {
     if (!isAuthError(error) || isAuthRetryableFetchError(error))
         return false;
+    // A 5xx is auth failing, not auth answering — and the vendor's predicate above cannot be
+    // relied on to say so, because it reads a list it owns and has already changed: at auth-js
+    // 2.91 it covered 502, 503 and 504, and at 2.108 it covers 500 through 530. Code leaning on
+    // it alone is right at whichever version happens to be installed, which is not the same as
+    // being right. Without this clause one bad minute at GoTrue signs out everybody whose token
+    // happened to need refreshing. Measured across the fleet: four backends answered 401 to
+    // their own auth provider's 500 for exactly this reason.
+    if ((error.status ?? 0) >= 500)
+        return false;
     // Newer clients name a refresh that reached GoTrue but was deliberately discarded because the
     // local session changed mid-flight. That race is a no-op, not proof that either session died.
     return error.name !== "AuthRefreshDiscardedError";
@@ -9,9 +18,10 @@ function reachedAuth(error) {
 /**
  * Connects a Supabase auth client to {@link SessionAdapter}.
  *
- * The distinction this preserves is the one that decides whether anybody is signed out: a
- * retryable fetch error never reached GoTrue and says nothing about the session; any other auth
- * error is an answer. A thrown network error stays on the first side of that line too.
+ * The distinction this preserves is the one that decides whether anybody is signed out: only
+ * auth ANSWERING proves a session is gone. A fetch that never landed says nothing about it, and
+ * neither does a 5xx, which is auth failing rather than auth answering. A thrown network error
+ * stays on that side of the line too.
  */
 export function createSupabaseSessionAdapter(auth) {
     return {

package/dist/supabase-session.js.map

@@ -1 +1 @@
-{"version":3,"file":"supabase-session.js","sourceRoot":"","sources":["../src/supabase-session.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAAE,yBAAyB,EAAuB,MAAM,uBAAuB,CAAC;AAmBpG,SAAS,WAAW,CAAC,KAAc;IACjC,IAAI,CAAC,WAAW,CAAC,KAAK,CAAC,IAAI,yBAAyB,CAAC,KAAK,CAAC;QAAE,OAAO,KAAK,CAAC;IAC1E,8FAA8F;IAC9F,8FAA8F;IAC9F,OAAO,KAAK,CAAC,IAAI,KAAK,2BAA2B,CAAC;AACpD,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,4BAA4B,CAAC,IAAyB;IACpE,OAAO;QACL,QAAQ,EAAE,KAAK,IAAI,EAAE;YACnB,MAAM,EAAE,IAAI,EAAE,GAAG,MAAM,IAAI,CAAC,UAAU,EAAE,CAAC;YACzC,OAAO,IAAI,CAAC,OAAO,EAAE,YAAY,IAAI,IAAI,CAAC;QAC5C,CAAC;QACD,OAAO,EAAE,KAAK,IAAI,EAAE;YAClB,IAAI,CAAC;gBACH,MAAM,EAAE,IAAI,EAAE,KAAK,EAAE,GAAG,MAAM,IAAI,CAAC,cAAc,EAAE,CAAC;gBACpD,OAAO;oBACL,KAAK,EAAE,IAAI,CAAC,OAAO,EAAE,YAAY,IAAI,IAAI;oBACzC,WAAW,EAAE,KAAK,KAAK,IAAI,IAAI,WAAW,CAAC,KAAK,CAAC;iBAClD,CAAC;YACJ,CAAC;YAAC,OAAO,KAAK,EAAE,CAAC;gBACf,OAAO,EAAE,KAAK,EAAE,IAAI,EAAE,WAAW,EAAE,WAAW,CAAC,KAAK,CAAC,EAAE,CAAC;YAC1D,CAAC;QACH,CAAC;QACD,OAAO,EAAE,KAAK,IAAI,EAAE;YAClB,MAAM,EAAE,KAAK,EAAE,GAAG,MAAM,IAAI,CAAC,OAAO,EAAE,CAAC;YACvC,IAAI,KAAK;gBAAE,MAAM,KAAK,CAAC;QACzB,CAAC;KACF,CAAC;AACJ,CAAC"}
+{"version":3,"file":"supabase-session.js","sourceRoot":"","sources":["../src/supabase-session.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAAE,yBAAyB,EAAuB,MAAM,uBAAuB,CAAC;AAmBpG,SAAS,WAAW,CAAC,KAAc;IACjC,IAAI,CAAC,WAAW,CAAC,KAAK,CAAC,IAAI,yBAAyB,CAAC,KAAK,CAAC;QAAE,OAAO,KAAK,CAAC;IAC1E,yFAAyF;IACzF,2FAA2F;IAC3F,4FAA4F;IAC5F,2FAA2F;IAC3F,4FAA4F;IAC5F,wFAAwF;IACxF,yDAAyD;IACzD,IAAI,CAAC,KAAK,CAAC,MAAM,IAAI,CAAC,CAAC,IAAI,GAAG;QAAE,OAAO,KAAK,CAAC;IAC7C,8FAA8F;IAC9F,8FAA8F;IAC9F,OAAO,KAAK,CAAC,IAAI,KAAK,2BAA2B,CAAC;AACpD,CAAC;AAED;;;;;;;GAOG;AACH,MAAM,UAAU,4BAA4B,CAAC,IAAyB;IACpE,OAAO;QACL,QAAQ,EAAE,KAAK,IAAI,EAAE;YACnB,MAAM,EAAE,IAAI,EAAE,GAAG,MAAM,IAAI,CAAC,UAAU,EAAE,CAAC;YACzC,OAAO,IAAI,CAAC,OAAO,EAAE,YAAY,IAAI,IAAI,CAAC;QAC5C,CAAC;QACD,OAAO,EAAE,KAAK,IAAI,EAAE;YAClB,IAAI,CAAC;gBACH,MAAM,EAAE,IAAI,EAAE,KAAK,EAAE,GAAG,MAAM,IAAI,CAAC,cAAc,EAAE,CAAC;gBACpD,OAAO;oBACL,KAAK,EAAE,IAAI,CAAC,OAAO,EAAE,YAAY,IAAI,IAAI;oBACzC,WAAW,EAAE,KAAK,KAAK,IAAI,IAAI,WAAW,CAAC,KAAK,CAAC;iBAClD,CAAC;YACJ,CAAC;YAAC,OAAO,KAAK,EAAE,CAAC;gBACf,OAAO,EAAE,KAAK,EAAE,IAAI,EAAE,WAAW,EAAE,WAAW,CAAC,KAAK,CAAC,EAAE,CAAC;YAC1D,CAAC;QACH,CAAC;QACD,OAAO,EAAE,KAAK,IAAI,EAAE;YAClB,MAAM,EAAE,KAAK,EAAE,GAAG,MAAM,IAAI,CAAC,OAAO,EAAE,CAAC;YACvC,IAAI,KAAK;gBAAE,MAAM,KAAK,CAAC;QACzB,CAAC;KACF,CAAC;AACJ,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gusnips/react",
-  "version": "0.9.2",
+  "version": "0.9.3",
   "description": "The headless runtime under a Vite + React SPA: typed fetch client with single-flight refresh, auth store, query defaults, route guards, error boundary, stale-tab recovery, i18n bootstrap.",
   "type": "module",
   "license": "MIT",

package/src/supabase-session.test.ts

@@ -67,6 +67,20 @@ describe("createSupabaseSessionAdapter", () => {
     await expect(thrown.refresh()).resolves.toEqual({ token: null, reachedAuth: true });
   });
 
+  it("keeps the session when auth answers with a failure of its own", async () => {
+    // `isAuthRetryableFetchError` says false for this one — it is an API error, not a fetch
+    // failure — so what holds the session is the status clause beside it. A 5xx is auth
+    // failing, never auth answering, and reading it as an answer signs the person out.
+    const outage = new AuthApiError("Internal Server Error", 500, undefined);
+    const adapter = createSupabaseSessionAdapter(
+      auth({
+        refreshSession: async () => ({ data: { session: null }, error: outage }),
+      }),
+    );
+
+    await expect(adapter.refresh()).resolves.toEqual({ token: null, reachedAuth: false });
+  });
+
   it("does not kill a session whose rotated refresh was discarded after a local race", async () => {
     const adapter = createSupabaseSessionAdapter(
       auth({

package/src/supabase-session.ts

@@ -19,6 +19,14 @@ type _SupabaseAuthFitsAdapter = Satisfied<
 
 function reachedAuth(error: unknown): boolean {
   if (!isAuthError(error) || isAuthRetryableFetchError(error)) return false;
+  // A 5xx is auth failing, not auth answering — and the vendor's predicate above cannot be
+  // relied on to say so, because it reads a list it owns and has already changed: at auth-js
+  // 2.91 it covered 502, 503 and 504, and at 2.108 it covers 500 through 530. Code leaning on
+  // it alone is right at whichever version happens to be installed, which is not the same as
+  // being right. Without this clause one bad minute at GoTrue signs out everybody whose token
+  // happened to need refreshing. Measured across the fleet: four backends answered 401 to
+  // their own auth provider's 500 for exactly this reason.
+  if ((error.status ?? 0) >= 500) return false;
   // Newer clients name a refresh that reached GoTrue but was deliberately discarded because the
   // local session changed mid-flight. That race is a no-op, not proof that either session died.
   return error.name !== "AuthRefreshDiscardedError";
@@ -27,9 +35,10 @@ function reachedAuth(error: unknown): boolean {
 /**
  * Connects a Supabase auth client to {@link SessionAdapter}.
  *
- * The distinction this preserves is the one that decides whether anybody is signed out: a
- * retryable fetch error never reached GoTrue and says nothing about the session; any other auth
- * error is an answer. A thrown network error stays on the first side of that line too.
+ * The distinction this preserves is the one that decides whether anybody is signed out: only
+ * auth ANSWERING proves a session is gone. A fetch that never landed says nothing about it, and
+ * neither does a 5xx, which is auth failing rather than auth answering. A thrown network error
+ * stays on that side of the line too.
  */
 export function createSupabaseSessionAdapter(auth: SupabaseSessionAuth): SessionAdapter {
   return {