@guiie/buda-mcp 1.5.1 → 1.5.3

package/CHANGELOG.md

@@ -11,6 +11,67 @@ This project uses [Semantic Versioning](https://semver.org/).
 
 ---
 
+## [1.5.3] – 2026-04-11
+
+### Security
+
+- **Upstream API errors no longer forwarded to MCP clients** — `BudaClient.handleResponse` now logs the full Buda API error detail (status, path, message) to `process.stderr` as structured JSON and returns only a generic message to the MCP caller (e.g. `"Buda API error 404 on /path."`). Previously, raw upstream error messages including potential internal details were forwarded directly to clients.
+
+- **Audit log transport field corrected for HTTP** — nine destructive tool handlers (`place_order`, `cancel_order`, `cancel_all_orders`, `cancel_order_by_client_id`, `place_batch_orders`, `create_withdrawal`, `lightning_withdrawal`, `create_receive_address`, `quote_remittance`, `accept_remittance_quote`) now correctly log `transport: "http"` when invoked via the HTTP server. Previously their `register()` functions defaulted to `"stdio"`, making all HTTP audit events appear as stdio traffic.
+
+- **HTTP security headers via `helmet`** — Express HTTP server now applies `helmet()` as the first middleware, adding `X-Content-Type-Options`, `X-Frame-Options`, `Referrer-Policy`, `X-DNS-Prefetch-Control`, `X-Download-Options`, and removing `X-Powered-By`.
+
+- **Request body size limit** — `express.json()` now enforces an explicit `limit: "10kb"` on the `/mcp` endpoint, reducing the memory/CPU surface for oversized body attacks in combination with the existing rate limiter.
+
+- **Rate limiting extended to `/health` and `/.well-known/mcp/server-card.json`** — a `staticRateLimiter` (60 req/min) now protects these endpoints, which previously had no throttling. Sufficient for all legitimate uptime monitors and Smithery discovery.
+
+- **`trust proxy` topology documented** — added inline comment to `app.set("trust proxy", 1)` explaining the single-hop assumption (Railway), the impact on `req.ip` and `express-rate-limit` client IP detection, and the action required if an additional proxy layer is added.
+
+### Pending (manual)
+
+- **CI binary pinning** — `publish.yml` should pin `mcp-publisher` to a fixed version with SHA256 verification instead of downloading `releases/latest`. Target version: `v1.5.0`, SHA256: `79bbb73ba048c5906034f73ef6286d7763bd53cf368ea0b358fc593ed360cbd5`. See `PUBLISH_CHECKLIST.md` for the exact step.
+
+### Added
+
+- `helmet` dependency (v8.x) — HTTP security headers middleware.
+
+---
+
+## [1.5.2] – 2026-04-11
+
+### Security
+
+- **Trust proxy configured for Railway** — added `app.set("trust proxy", 1)` to Express before any middleware. Without this, `express-rate-limit` saw the proxy IP for every request instead of the real client IP, making per-IP rate limiting effectively useless in the Railway deployment.
+
+- **Constant-time bearer token comparison** — `mcpAuthMiddleware` now uses `crypto.timingSafeEqual` via a new `safeTokenEqual()` helper (exported from `src/utils.ts`) instead of plain string equality, eliminating the theoretical timing side-channel on the `MCP_AUTH_TOKEN` comparison.
+
+- **PORT and MCP_RATE_LIMIT startup validation** — both environment variables are now parsed through a new `parseEnvInt(raw, fallback, min, max, name)` helper that throws a descriptive error and exits on `NaN` or out-of-range values, preventing silent misconfigurations (e.g. `MCP_RATE_LIMIT=abc` previously resolved to `NaN` and could disable the rate limiter).
+
+- **MCP_AUTH_TOKEN entropy warning** — server now emits a `console.warn` at startup if `MCP_AUTH_TOKEN` is set but shorter than 32 characters, nudging operators toward adequately random secrets.
+
+- **Dead man's switch fully isolated to stdio transport** — `renew_cancel_timer` and `disarm_cancel_timer` now also return `TRANSPORT_NOT_SUPPORTED` on HTTP transport (previously only `schedule_cancel_all` was blocked). An attacker with HTTP access could previously disarm or renew a timer armed via the stdio process, since both share the same module-level `timers` Map.
+
+- **Input validation in `compare_markets`** — `base_currency` is now validated with `validateCurrency()` before fetching tickers, consistent with all other tools that accept a currency parameter. Arbitrary-length strings no longer reach the cache or API.
+
+- **BOLT-11 invoice regex strengthened** — regex updated from `/^ln(bc|tb|bcrt)\d/i` to `/^ln(bc|tb|bcrt)\d*[munp]?1[a-z0-9]{20,}$/i`. The new pattern requires the bech32 separator `1`, at least 20 characters of bech32 data after it, and anchors at `$` — rejecting malformed strings that happen to start with the right prefix.
+
+- **API path redaction from error responses** — removed the `path` field from all `BudaApiError` catch blocks across 31 tool handlers. The field was included in MCP tool responses, leaking internal API endpoint patterns (e.g. `/currencies/BTC/withdrawals`) to clients. The `path` property still exists on `BudaApiError` for internal use in audit logs.
+
+- **Structured audit logging for destructive operations** — new `src/audit.ts` module with `logAudit(event: AuditEvent)` writes newline-delimited JSON to `process.stderr` for all 11 handlers with financial side-effects: `place_order`, `cancel_order`, `cancel_all_orders`, `cancel_order_by_client_id`, `place_batch_orders`, `create_withdrawal`, `lightning_withdrawal`, `create_receive_address`, `quote_remittance`, `accept_remittance_quote`, `schedule_cancel_all`. Audit events include `ts`, `tool`, `transport`, `args_summary` (sanitized — never includes `confirmation_token`, `invoice`, or `address`), `success`, and `error_code`. Each handler exposes an optional `transport` parameter (default `"stdio"`) for future HTTP-aware logging.
+
+### Added
+
+- **`safeTokenEqual(a, b)` utility** — exported from `src/utils.ts`; constant-time string comparison using `crypto.timingSafeEqual`. Usable by any future code that compares secrets.
+- **`parseEnvInt(raw, fallback, min, max, name)` utility** — exported from `src/utils.ts`; safe environment variable integer parsing with range validation. Used for `PORT` and `MCP_RATE_LIMIT` at startup.
+- **`handleCompareMarkets` exported handler** — `compare_markets.ts` logic extracted from the inline registration closure into a named, exported function for unit testability.
+
+### Tests
+
+- **+28 unit tests** covering all new security behaviors: `safeTokenEqual` (5 cases), `parseEnvInt` (6 cases), `handleCompareMarkets` validateCurrency guard (4 cases), improved BOLT-11 regex (3 cases), DMS HTTP transport guard for renew and disarm (4 cases), `logAudit` output format and secret redaction (3 cases), audit integration with `handlePlaceOrder` (1 case), `path` field absence in error responses (2 cases).
+- **Updated 3 existing test fixtures** — replaced placeholder invoice string `"lnbc1000u1ptest..."` (which contained dots — invalid bech32) with a well-formed test value that satisfies the improved BOLT-11 regex.
+
+---
+
 ## [1.5.1] – 2026-04-11
 
 ### Security

package/PUBLISH_CHECKLIST.md

@@ -1,6 +1,6 @@
-# Publish Checklist — buda-mcp v1.5.1
+# Publish Checklist — buda-mcp v1.5.3
 
-Steps to publish `v1.5.1` to npm, the MCP registry, and notify community directories.
+Steps to publish `v1.5.3` to npm, the MCP registry, and notify community directories.
 
 ---
 
@@ -8,7 +8,7 @@ Steps to publish `v1.5.1` to npm, the MCP registry, and notify community directo
 
 ```bash
 # Confirm version
-node -e "console.log(require('./package.json').version)"  # should print 1.5.1
+node -e "console.log(require('./package.json').version)"  # should print 1.5.3
 
 # Build and test
 npm run build
@@ -37,9 +37,9 @@ Verify: https://www.npmjs.com/package/@guiie/buda-mcp
 
 ## 3. GitHub release
 
-Tag and release already created via `gh release create v1.5.1`. Verify at:
+Tag and release already created via `gh release create v1.5.3`. Verify at:
 
-https://github.com/gtorreal/buda-mcp/releases/tag/v1.5.1
+https://github.com/gtorreal/buda-mcp/releases/tag/v1.5.3
 
 ---
 
@@ -64,20 +64,18 @@ Verify: https://smithery.ai/server/@guiie/buda-mcp
 **Email/message template:**
 
 ```
-Subject: [Update] buda-mcp v1.5.1 — Security hardening release
+Subject: [Update] buda-mcp v1.5.3 — Security hardening (third pass)
 
 Hi mcp.so team,
 
-I've released v1.5.1 of buda-mcp (@guiie/buda-mcp on npm).
+I've released v1.5.3 of buda-mcp (@guiie/buda-mcp on npm).
 
 Key changes (security hardening, no new tools):
-- HTTP startup guard: server exits if credentials are set without MCP_AUTH_TOKEN
-- Rate limiting: 120 req/min per IP on /mcp (configurable via MCP_RATE_LIMIT)
-- Crypto address validation in create_withdrawal (BTC, ETH, USDC, USDT, LTC, BCH, XRP)
-- BOLT-11 invoice format validation in lightning_withdrawal
-- Dead man's switch blocked on HTTP transport (process restarts drop timers)
-- place_batch_orders: optional max_notional spending cap
-- 156 unit tests (was 136)
+- Upstream API errors no longer forwarded to MCP clients (generic messages only, detail logged server-side)
+- Audit log transport field corrected for HTTP (9 handlers previously showed "stdio" for HTTP traffic)
+- HTTP security headers via helmet (X-Content-Type-Options, X-Frame-Options, Referrer-Policy, etc.)
+- Request body size limit enforced (10kb) on /mcp endpoint
+- Rate limiting extended to /health and /.well-known/mcp/server-card.json endpoints
 
 Links:
 - npm: https://www.npmjs.com/package/@guiie/buda-mcp
@@ -96,24 +94,23 @@ Thank you!
 **Message template:**
 
 ```
-Subject: [Update] buda-mcp v1.5.1
+Subject: [Update] buda-mcp v1.5.3
 
 Hi Glama team,
 
-buda-mcp has been updated to v1.5.1.
+buda-mcp has been updated to v1.5.3.
 
 Package: @guiie/buda-mcp (npm)
 Registry: io.github.gtorreal/buda-mcp (MCP Registry)
-Version: 1.5.1
+Version: 1.5.3
 
-Changes (security hardening):
-- HTTP startup guard for missing MCP_AUTH_TOKEN
-- Rate limiting on /mcp (120 req/min per IP)
-- Crypto address format validation in create_withdrawal
-- BOLT-11 invoice validation in lightning_withdrawal
-- Dead man's switch blocked on HTTP transport
-- place_batch_orders: optional max_notional cap
-- 156 unit tests
+Changes (security hardening, third pass):
+- Upstream API errors no longer forwarded to MCP clients
+- Audit log transport field corrected for HTTP (9 handlers)
+- HTTP security headers via helmet
+- Request body size limit (10kb) on /mcp endpoint
+- Rate limiting on /health and server-card endpoints
+- 184 unit tests
 
 Quick start:
   npx @guiie/buda-mcp
@@ -128,22 +125,45 @@ Thank you!
 
 ## 8. Post-publish verification
 
-- [ ] `npx @guiie/buda-mcp@1.5.1` starts successfully
-- [ ] `npm info @guiie/buda-mcp version` returns `1.5.1`
-- [ ] GitHub release tag `v1.5.1` is visible
-- [ ] MCP Registry entry reflects v1.5.1
+- [ ] `npx @guiie/buda-mcp@1.5.3` starts successfully
+- [ ] `npm info @guiie/buda-mcp version` returns `1.5.3`
+- [ ] GitHub release tag `v1.5.3` is visible
+- [ ] MCP Registry entry reflects v1.5.3
 - [ ] Smithery server card lists all tools
-- [ ] `GET /health` returns `"version":"1.5.1"` on Railway deployment
-- [ ] HTTP server exits if `BUDA_API_KEY` set but `MCP_AUTH_TOKEN` is absent
-- [ ] `create_withdrawal` rejects a truncated BTC address with `INVALID_ADDRESS`
-- [ ] `lightning_withdrawal` rejects a non-BOLT11 string with `INVALID_INVOICE`
-- [ ] `place_batch_orders` with `max_notional` rejects over-cap batch before API call
-- [ ] `schedule_cancel_all` via HTTP returns `TRANSPORT_NOT_SUPPORTED`
+- [ ] `GET /health` returns `"version":"1.5.3"` on Railway deployment
+- [ ] `GET /health` responds with `X-Content-Type-Options: nosniff` header (helmet active)
+- [ ] `GET /health` rate-limited at 60 req/min
+- [ ] Error responses from the MCP server show generic message (not raw Buda API detail)
+- [ ] Audit log shows `"transport":"http"` for HTTP-triggered destructive tools
+- [ ] Pending: manually apply CI binary pinning to `publish.yml` (see CHANGELOG v1.5.3)
 - [ ] mcp.so listing updated
 - [ ] Glama.ai listing updated
 
 ---
 
+---
+
+## 9. Pending manual fix — CI binary pinning
+
+Edit `.github/workflows/publish.yml`, replace the `Install mcp-publisher` step with:
+
+```yaml
+- name: Install mcp-publisher
+  env:
+    MCP_PUBLISHER_VERSION: "v1.5.0"
+    MCP_PUBLISHER_SHA256: "79bbb73ba048c5906034f73ef6286d7763bd53cf368ea0b358fc593ed360cbd5"
+  run: |
+    curl -fsSL "https://github.com/modelcontextprotocol/registry/releases/download/${MCP_PUBLISHER_VERSION}/mcp-publisher_linux_amd64.tar.gz" \
+      -o mcp-publisher.tar.gz
+    echo "${MCP_PUBLISHER_SHA256}  mcp-publisher.tar.gz" | sha256sum --check
+    tar xz -f mcp-publisher.tar.gz mcp-publisher
+    sudo mv mcp-publisher /usr/local/bin/
+```
+
+SHA256 verified against GitHub release `v1.5.0` on 2026-04-11. Update both values when bumping `mcp-publisher`.
+
+---
+
 ## ARCHIVED: previous checklists
 
-See git tags `v1.5.0`, `v1.4.0`, `v1.4.1`, `v1.4.2` for previous release notes and verification steps.
+See git tags `v1.5.0`, `v1.5.1`, `v1.4.0`, `v1.4.1`, `v1.4.2` for previous release notes and verification steps.

package/dist/audit.d.ts

@@ -0,0 +1,21 @@
+/**
+ * Structured audit logging for destructive MCP tool calls.
+ *
+ * Writes newline-delimited JSON to stderr so it never pollutes the stdio MCP transport
+ * and is captured by Railway / any log aggregator attached to the process.
+ *
+ * Rules for args_summary:
+ *   - Include: market_id, currency, price_type, type, amount ranges
+ *   - NEVER include: confirmation_token, invoice, address, bank_account_id
+ */
+export interface AuditEvent {
+    ts: string;
+    tool: string;
+    transport: "http" | "stdio";
+    ip?: string;
+    args_summary: Record<string, unknown>;
+    success: boolean;
+    error_code?: string | number;
+}
+export declare function logAudit(event: AuditEvent): void;
+//# sourceMappingURL=audit.d.ts.map

package/dist/audit.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"audit.d.ts","sourceRoot":"","sources":["../src/audit.ts"],"names":[],"mappings":"AAAA;;;;;;;;;GASG;AAEH,MAAM,WAAW,UAAU;IACzB,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;IACb,SAAS,EAAE,MAAM,GAAG,OAAO,CAAC;IAC5B,EAAE,CAAC,EAAE,MAAM,CAAC;IACZ,YAAY,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;IACtC,OAAO,EAAE,OAAO,CAAC;IACjB,UAAU,CAAC,EAAE,MAAM,GAAG,MAAM,CAAC;CAC9B;AAED,wBAAgB,QAAQ,CAAC,KAAK,EAAE,UAAU,GAAG,IAAI,CAEhD"}

package/dist/audit.js

@@ -0,0 +1,14 @@
+/**
+ * Structured audit logging for destructive MCP tool calls.
+ *
+ * Writes newline-delimited JSON to stderr so it never pollutes the stdio MCP transport
+ * and is captured by Railway / any log aggregator attached to the process.
+ *
+ * Rules for args_summary:
+ *   - Include: market_id, currency, price_type, type, amount ranges
+ *   - NEVER include: confirmation_token, invoice, address, bank_account_id
+ */
+export function logAudit(event) {
+    process.stderr.write(JSON.stringify({ audit: true, ...event }) + "\n");
+}
+//# sourceMappingURL=audit.js.map

package/dist/client.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"client.d.ts","sourceRoot":"","sources":["../src/client.ts"],"names":[],"mappings":"AAKA,qBAAa,YAAa,SAAQ,KAAK;aAEnB,MAAM,EAAE,MAAM;aACd,IAAI,EAAE,MAAM;aAEZ,YAAY,CAAC,EAAE,MAAM;gBAHrB,MAAM,EAAE,MAAM,EACd,IAAI,EAAE,MAAM,EAC5B,OAAO,EAAE,MAAM,EACC,YAAY,CAAC,EAAE,MAAM,YAAA;CAKxC;AAED,qBAAa,UAAU;IACrB,OAAO,CAAC,QAAQ,CAAC,OAAO,CAAS;IACjC,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAqB;IAC5C,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAqB;gBAG7C,OAAO,GAAE,MAAiB,EAC1B,MAAM,CAAC,EAAE,MAAM,EACf,SAAS,CAAC,EAAE,MAAM;IAOpB,OAAO,IAAI,OAAO;IAIlB,OAAO,CAAC,aAAa,CAAK;IAE1B,OAAO,CAAC,KAAK;IAIb,OAAO,CAAC,IAAI;IASZ,OAAO,CAAC,WAAW;IAWnB;;;;OAIG;IACH,OAAO,CAAC,iBAAiB;IAOzB;;;;OAIG;YACW,cAAc;YA2Bd,cAAc;IActB,GAAG,CAAC,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,MAAM,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,MAAM,CAAC,GAAG,OAAO,CAAC,CAAC,CAAC;IAoB1E,IAAI,CAAC,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,GAAG,OAAO,CAAC,CAAC,CAAC;IAmBnD,GAAG,CAAC,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,GAAG,OAAO,CAAC,CAAC,CAAC;IAmBlD,MAAM,CAAC,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,MAAM,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,MAAM,CAAC,GAAG,OAAO,CAAC,CAAC,CAAC;CAmBpF"}
+{"version":3,"file":"client.d.ts","sourceRoot":"","sources":["../src/client.ts"],"names":[],"mappings":"AAKA,qBAAa,YAAa,SAAQ,KAAK;aAEnB,MAAM,EAAE,MAAM;aACd,IAAI,EAAE,MAAM;aAEZ,YAAY,CAAC,EAAE,MAAM;gBAHrB,MAAM,EAAE,MAAM,EACd,IAAI,EAAE,MAAM,EAC5B,OAAO,EAAE,MAAM,EACC,YAAY,CAAC,EAAE,MAAM,YAAA;CAKxC;AAED,qBAAa,UAAU;IACrB,OAAO,CAAC,QAAQ,CAAC,OAAO,CAAS;IACjC,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAqB;IAC5C,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAqB;gBAG7C,OAAO,GAAE,MAAiB,EAC1B,MAAM,CAAC,EAAE,MAAM,EACf,SAAS,CAAC,EAAE,MAAM;IAOpB,OAAO,IAAI,OAAO;IAIlB,OAAO,CAAC,aAAa,CAAK;IAE1B,OAAO,CAAC,KAAK;IAIb,OAAO,CAAC,IAAI;IASZ,OAAO,CAAC,WAAW;IAWnB;;;;OAIG;IACH,OAAO,CAAC,iBAAiB;IAOzB;;;;OAIG;YACW,cAAc;YA2Bd,cAAc;IAsBtB,GAAG,CAAC,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,MAAM,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,MAAM,CAAC,GAAG,OAAO,CAAC,CAAC,CAAC;IAoB1E,IAAI,CAAC,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,GAAG,OAAO,CAAC,CAAC,CAAC;IAmBnD,GAAG,CAAC,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,GAAG,OAAO,CAAC,CAAC,CAAC;IAmBlD,MAAM,CAAC,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,MAAM,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,MAAM,CAAC,GAAG,OAAO,CAAC,CAAC,CAAC;CAmBpF"}

package/dist/client.js

@@ -90,7 +90,12 @@ export class BudaClient {
             catch {
                 // ignore parse error, use statusText
             }
-            throw new BudaApiError(response.status, path, `Buda API ${response.status}: ${detail}`);
+            // Log full upstream detail server-side only — never forward to MCP caller
+            process.stderr.write(JSON.stringify({ buda_api_error: true, status: response.status, path, detail }) + "\n");
+            const clientMsg = response.status === 429
+                ? `Rate limit exceeded on ${path}. Retry later.`
+                : `Buda API error ${response.status} on ${path}.`;
+            throw new BudaApiError(response.status, path, clientMsg);
         }
         return response.json();
     }

package/dist/http.js

@@ -1,9 +1,11 @@
 import express from "express";
+import helmet from "helmet";
 import rateLimit from "express-rate-limit";
 import { McpServer, ResourceTemplate } from "@modelcontextprotocol/sdk/server/mcp.js";
 import { StreamableHTTPServerTransport } from "@modelcontextprotocol/sdk/server/streamableHttp.js";
 import { BudaClient } from "./client.js";
 import { MemoryCache, CACHE_TTL } from "./cache.js";
+import { safeTokenEqual, parseEnvInt } from "./utils.js";
 import { VERSION } from "./version.js";
 import { validateMarketId } from "./validation.js";
 import * as markets from "./tools/markets.js";
@@ -41,7 +43,14 @@ import * as cancelOrderByClientId from "./tools/cancel_order_by_client_id.js";
 import * as batchOrders from "./tools/batch_orders.js";
 import * as lightning from "./tools/lightning.js";
 import { handleMarketSummary } from "./tools/market_summary.js";
-const PORT = parseInt(process.env.PORT ?? "3000", 10);
+let PORT;
+try {
+    PORT = parseEnvInt(process.env.PORT, 3000, 1, 65535, "PORT");
+}
+catch (err) {
+    console.error(err instanceof Error ? err.message : String(err));
+    process.exit(1);
+}
 const client = new BudaClient(undefined, process.env.BUDA_API_KEY, process.env.BUDA_API_SECRET);
 const authEnabled = client.hasAuth();
 // Schemas for the Smithery server-card — assembled from the same definitions used in register().
@@ -119,22 +128,22 @@ function createServer() {
     if (authEnabled) {
         balances.register(server, client);
         orders.register(server, client);
-        placeOrder.register(server, client);
-        cancelOrder.register(server, client);
+        placeOrder.register(server, client, "http");
+        cancelOrder.register(server, client, "http");
         deadMansSwitch.register(server, client, "http");
         account.register(server, client);
         balance.register(server, client);
         orderLookup.register(server, client);
         networkFees.register(server, client);
         deposits.register(server, client);
-        withdrawals.register(server, client);
-        receiveAddresses.register(server, client);
-        remittances.register(server, client);
+        withdrawals.register(server, client, "http");
+        receiveAddresses.register(server, client, "http");
+        remittances.register(server, client, "http");
         remittanceRecipients.register(server, client);
-        cancelAllOrders.register(server, client);
-        cancelOrderByClientId.register(server, client);
-        batchOrders.register(server, client);
-        lightning.register(server, client);
+        cancelAllOrders.register(server, client, "http");
+        cancelOrderByClientId.register(server, client, "http");
+        batchOrders.register(server, client, "http");
+        lightning.register(server, client, "http");
     }
     // MCP Resources
     server.resource("buda-markets", "buda://markets", async (uri) => {
@@ -187,7 +196,12 @@ function createServer() {
     return server;
 }
 const app = express();
-app.use(express.json());
+app.use(helmet());
+// trust proxy: 1 = trust exactly one hop (Railway's reverse proxy).
+// If Cloudflare or another proxy is added in front, increment this value.
+// Affects: req.ip and express-rate-limit client IP detection.
+app.set("trust proxy", 1);
+app.use(express.json({ limit: "10kb" }));
 const MCP_AUTH_TOKEN = process.env.MCP_AUTH_TOKEN;
 if (authEnabled && !MCP_AUTH_TOKEN) {
     console.error("[buda-mcp] FATAL: BUDA_API_KEY/BUDA_API_SECRET are set but MCP_AUTH_TOKEN is not.\n" +
@@ -195,27 +209,45 @@ if (authEnabled && !MCP_AUTH_TOKEN) {
         "  Set MCP_AUTH_TOKEN to a long random secret, or run in stdio mode instead.");
     process.exit(1);
 }
+if (MCP_AUTH_TOKEN && MCP_AUTH_TOKEN.length < 32) {
+    console.warn("[buda-mcp] WARNING: MCP_AUTH_TOKEN has fewer than 32 characters. Use a longer random secret.");
+}
+let rateLimitMax;
+try {
+    rateLimitMax = parseEnvInt(process.env.MCP_RATE_LIMIT, 120, 1, 10_000, "MCP_RATE_LIMIT");
+}
+catch (err) {
+    console.error(err instanceof Error ? err.message : String(err));
+    process.exit(1);
+}
 const mcpRateLimiter = rateLimit({
     windowMs: 60_000,
-    max: parseInt(process.env.MCP_RATE_LIMIT ?? "120", 10),
+    max: rateLimitMax,
     standardHeaders: true,
     legacyHeaders: false,
     message: { error: "Too many requests. Retry after 60 seconds.", code: "RATE_LIMITED" },
 });
+const staticRateLimiter = rateLimit({
+    windowMs: 60_000,
+    max: 60,
+    standardHeaders: true,
+    legacyHeaders: false,
+    message: { error: "Too many requests.", code: "RATE_LIMITED" },
+});
 function mcpAuthMiddleware(req, res, next) {
     if (!MCP_AUTH_TOKEN) {
         next();
         return;
     }
     const auth = req.headers.authorization ?? "";
-    if (auth !== `Bearer ${MCP_AUTH_TOKEN}`) {
+    if (!safeTokenEqual(auth, `Bearer ${MCP_AUTH_TOKEN}`)) {
         res.status(401).json({ error: "Unauthorized" });
         return;
     }
     next();
 }
 // Health check for Railway / uptime monitors
-app.get("/health", (_req, res) => {
+app.get("/health", staticRateLimiter, (_req, res) => {
     res.json({
         status: "ok",
         server: "buda-mcp",
@@ -225,7 +257,7 @@ app.get("/health", (_req, res) => {
 });
 // Smithery static server card — assembled programmatically from tool definitions.
 // Adding a new tool only requires exporting its toolSchema; this handler needs no changes.
-app.get("/.well-known/mcp/server-card.json", (_req, res) => {
+app.get("/.well-known/mcp/server-card.json", staticRateLimiter, (_req, res) => {
     res.json({
         serverInfo: { name: "buda-mcp", version: VERSION },
         authentication: { required: authEnabled },

package/dist/tools/account.js

@@ -35,7 +35,7 @@ export async function handleGetAccountInfo(client) {
     }
     catch (err) {
         const msg = err instanceof BudaApiError
-            ? { error: err.message, code: err.status, path: err.path }
+            ? { error: err.message, code: err.status }
             : { error: String(err), code: "UNKNOWN" };
         return {
             content: [{ type: "text", text: JSON.stringify(msg) }],

package/dist/tools/arbitrage.js

@@ -118,7 +118,7 @@ export async function handleArbitrageOpportunities({ base_currency, threshold_pc
     }
     catch (err) {
         const msg = err instanceof BudaApiError
-            ? { error: err.message, code: err.status, path: err.path }
+            ? { error: err.message, code: err.status }
             : { error: String(err), code: "UNKNOWN" };
         return {
             content: [{ type: "text", text: JSON.stringify(msg) }],

package/dist/tools/balance.js

@@ -56,7 +56,7 @@ export async function handleGetBalance(args, client) {
     }
     catch (err) {
         const msg = err instanceof BudaApiError
-            ? { error: err.message, code: err.status, path: err.path }
+            ? { error: err.message, code: err.status }
             : { error: String(err), code: "UNKNOWN" };
         return {
             content: [{ type: "text", text: JSON.stringify(msg) }],

package/dist/tools/balances.js

@@ -39,7 +39,7 @@ export function register(server, client) {
         }
         catch (err) {
             const msg = err instanceof BudaApiError
-                ? { error: err.message, code: err.status, path: err.path }
+                ? { error: err.message, code: err.status }
                 : { error: String(err), code: "UNKNOWN" };
             return {
                 content: [{ type: "text", text: JSON.stringify(msg) }],

package/dist/tools/banks.js

@@ -52,7 +52,7 @@ export async function handleGetAvailableBanks(args, client, cache) {
             };
         }
         const msg = err instanceof BudaApiError
-            ? { error: err.message, code: err.status, path: err.path }
+            ? { error: err.message, code: err.status }
             : { error: String(err), code: "UNKNOWN" };
         return {
             content: [{ type: "text", text: JSON.stringify(msg) }],

package/dist/tools/batch_orders.d.ts

@@ -70,13 +70,13 @@ type BatchOrdersArgs = {
     max_notional?: number;
     confirmation_token: string;
 };
-export declare function handlePlaceBatchOrders(args: BatchOrdersArgs, client: BudaClient): Promise<{
+export declare function handlePlaceBatchOrders(args: BatchOrdersArgs, client: BudaClient, transport?: "http" | "stdio"): Promise<{
     content: Array<{
         type: "text";
         text: string;
     }>;
     isError?: boolean;
 }>;
-export declare function register(server: McpServer, client: BudaClient): void;
+export declare function register(server: McpServer, client: BudaClient, transport?: "http" | "stdio"): void;
 export {};
 //# sourceMappingURL=batch_orders.d.ts.map

package/dist/tools/batch_orders.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"batch_orders.d.ts","sourceRoot":"","sources":["../../src/tools/batch_orders.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,MAAM,yCAAyC,CAAC;AACpE,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AACxB,OAAO,EAAE,UAAU,EAAgB,MAAM,cAAc,CAAC;AAIxD,eAAO,MAAM,UAAU;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;CA0CtB,CAAC;AAEF,QAAA,MAAM,UAAU;;;;;;;;;;;;iBAMd,CAAC;AAEH,KAAK,gBAAgB,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,UAAU,CAAC,CAAC;AAWnD,KAAK,eAAe,GAAG;IACrB,MAAM,EAAE,gBAAgB,EAAE,CAAC;IAC3B,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,kBAAkB,EAAE,MAAM,CAAC;CAC5B,CAAC;AAEF,wBAAsB,sBAAsB,CAC1C,IAAI,EAAE,eAAe,EACrB,MAAM,EAAE,UAAU,GACjB,OAAO,CAAC;IAAE,OAAO,EAAE,KAAK,CAAC;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,IAAI,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IAAC,OAAO,CAAC,EAAE,OAAO,CAAA;CAAE,CAAC,CAkIhF;AAED,wBAAgB,QAAQ,CAAC,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,UAAU,GAAG,IAAI,CA2BpE"}
+{"version":3,"file":"batch_orders.d.ts","sourceRoot":"","sources":["../../src/tools/batch_orders.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,MAAM,yCAAyC,CAAC;AACpE,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AACxB,OAAO,EAAE,UAAU,EAAgB,MAAM,cAAc,CAAC;AAKxD,eAAO,MAAM,UAAU;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;CA0CtB,CAAC;AAEF,QAAA,MAAM,UAAU;;;;;;;;;;;;iBAMd,CAAC;AAEH,KAAK,gBAAgB,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,UAAU,CAAC,CAAC;AAWnD,KAAK,eAAe,GAAG;IACrB,MAAM,EAAE,gBAAgB,EAAE,CAAC;IAC3B,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,kBAAkB,EAAE,MAAM,CAAC;CAC5B,CAAC;AAEF,wBAAsB,sBAAsB,CAC1C,IAAI,EAAE,eAAe,EACrB,MAAM,EAAE,UAAU,EAClB,SAAS,GAAE,MAAM,GAAG,OAAiB,GACpC,OAAO,CAAC;IAAE,OAAO,EAAE,KAAK,CAAC;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,IAAI,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IAAC,OAAO,CAAC,EAAE,OAAO,CAAA;CAAE,CAAC,CA2IhF;AAED,wBAAgB,QAAQ,CACtB,MAAM,EAAE,SAAS,EACjB,MAAM,EAAE,UAAU,EAClB,SAAS,GAAE,MAAM,GAAG,OAAiB,GACpC,IAAI,CA2BN"}

package/dist/tools/batch_orders.js

@@ -1,6 +1,7 @@
 import { z } from "zod";
 import { BudaApiError } from "../client.js";
 import { validateMarketId } from "../validation.js";
+import { logAudit } from "../audit.js";
 export const toolSchema = {
     name: "place_batch_orders",
     description: "Place multiple orders sequentially on Buda.com (up to 20). " +
@@ -48,7 +49,7 @@ const orderShape = z.object({
     amount: z.number().positive(),
     limit_price: z.number().positive().optional(),
 });
-export async function handlePlaceBatchOrders(args, client) {
+export async function handlePlaceBatchOrders(args, client, transport = "stdio") {
     const { orders, max_notional, confirmation_token } = args;
     if (confirmation_token !== "CONFIRM") {
         return {
@@ -161,12 +162,21 @@ export async function handlePlaceBatchOrders(args, client) {
     if (failed > 0 && succeeded > 0) {
         response.warning = "Some orders failed. Already-placed orders were NOT rolled back.";
     }
+    const isError = failed > 0 && succeeded === 0 ? true : undefined;
+    logAudit({
+        ts: new Date().toISOString(),
+        tool: "place_batch_orders",
+        transport,
+        args_summary: { order_count: orders.length, succeeded, failed },
+        success: !isError,
+        error_code: isError ? "PARTIAL_OR_FULL_FAILURE" : undefined,
+    });
     return {
         content: [{ type: "text", text: JSON.stringify(response, null, 2) }],
-        isError: failed > 0 && succeeded === 0 ? true : undefined,
+        isError,
     };
 }
-export function register(server, client) {
+export function register(server, client, transport = "stdio") {
     server.tool(toolSchema.name, toolSchema.description, {
         orders: z
             .array(orderShape)
@@ -183,6 +193,6 @@ export function register(server, client) {
         confirmation_token: z
             .string()
             .describe("Safety confirmation. Must equal exactly 'CONFIRM' (case-sensitive) to execute."),
-    }, (args) => handlePlaceBatchOrders(args, client));
+    }, (args) => handlePlaceBatchOrders(args, client, transport));
 }
 //# sourceMappingURL=batch_orders.js.map

package/dist/tools/cancel_all_orders.d.ts

@@ -22,13 +22,13 @@ type CancelAllOrdersArgs = {
     market_id: string;
     confirmation_token: string;
 };
-export declare function handleCancelAllOrders(args: CancelAllOrdersArgs, client: BudaClient): Promise<{
+export declare function handleCancelAllOrders(args: CancelAllOrdersArgs, client: BudaClient, transport?: "http" | "stdio"): Promise<{
     content: Array<{
         type: "text";
         text: string;
     }>;
     isError?: boolean;
 }>;
-export declare function register(server: McpServer, client: BudaClient): void;
+export declare function register(server: McpServer, client: BudaClient, transport?: "http" | "stdio"): void;
 export {};
 //# sourceMappingURL=cancel_all_orders.d.ts.map

package/dist/tools/cancel_all_orders.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"cancel_all_orders.d.ts","sourceRoot":"","sources":["../../src/tools/cancel_all_orders.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,MAAM,yCAAyC,CAAC;AAEpE,OAAO,EAAE,UAAU,EAAgB,MAAM,cAAc,CAAC;AAIxD,eAAO,MAAM,UAAU;;;;;;;;;;;;;;;;;CAuBtB,CAAC;AAEF,KAAK,mBAAmB,GAAG;IACzB,SAAS,EAAE,MAAM,CAAC;IAClB,kBAAkB,EAAE,MAAM,CAAC;CAC5B,CAAC;AAEF,wBAAsB,qBAAqB,CACzC,IAAI,EAAE,mBAAmB,EACzB,MAAM,EAAE,UAAU,GACjB,OAAO,CAAC;IAAE,OAAO,EAAE,KAAK,CAAC;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,IAAI,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IAAC,OAAO,CAAC,EAAE,OAAO,CAAA;CAAE,CAAC,CAyDhF;AAED,wBAAgB,QAAQ,CAAC,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,UAAU,GAAG,IAAI,CAkBpE"}
+{"version":3,"file":"cancel_all_orders.d.ts","sourceRoot":"","sources":["../../src/tools/cancel_all_orders.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,MAAM,yCAAyC,CAAC;AAEpE,OAAO,EAAE,UAAU,EAAgB,MAAM,cAAc,CAAC;AAKxD,eAAO,MAAM,UAAU;;;;;;;;;;;;;;;;;CAuBtB,CAAC;AAEF,KAAK,mBAAmB,GAAG;IACzB,SAAS,EAAE,MAAM,CAAC;IAClB,kBAAkB,EAAE,MAAM,CAAC;CAC5B,CAAC;AAEF,wBAAsB,qBAAqB,CACzC,IAAI,EAAE,mBAAmB,EACzB,MAAM,EAAE,UAAU,EAClB,SAAS,GAAE,MAAM,GAAG,OAAiB,GACpC,OAAO,CAAC;IAAE,OAAO,EAAE,KAAK,CAAC;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,IAAI,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IAAC,OAAO,CAAC,EAAE,OAAO,CAAA;CAAE,CAAC,CAqDhF;AAED,wBAAgB,QAAQ,CACtB,MAAM,EAAE,SAAS,EACjB,MAAM,EAAE,UAAU,EAClB,SAAS,GAAE,MAAM,GAAG,OAAiB,GACpC,IAAI,CAkBN"}

package/dist/tools/cancel_all_orders.js

@@ -1,6 +1,7 @@
 import { z } from "zod";
 import { BudaApiError } from "../client.js";
 import { validateMarketId } from "../validation.js";
+import { logAudit } from "../audit.js";
 export const toolSchema = {
     name: "cancel_all_orders",
     description: "Cancel all open orders on Buda.com, optionally filtered by a specific market. " +
@@ -23,7 +24,7 @@ export const toolSchema = {
         required: ["market_id", "confirmation_token"],
     },
 };
-export async function handleCancelAllOrders(args, client) {
+export async function handleCancelAllOrders(args, client, transport = "stdio") {
     const { market_id, confirmation_token } = args;
     if (confirmation_token !== "CONFIRM") {
         return {
@@ -55,26 +56,22 @@ export async function handleCancelAllOrders(args, client) {
     try {
         const params = market_id !== "*" ? { market_id: market_id.toLowerCase() } : undefined;
         const data = await client.delete(`/orders`, params);
-        return {
-            content: [
-                {
-                    type: "text",
-                    text: JSON.stringify({ canceled_count: data.canceled_count, market_id }),
-                },
-            ],
+        const result = {
+            content: [{ type: "text", text: JSON.stringify({ canceled_count: data.canceled_count, market_id }) }],
         };
+        logAudit({ ts: new Date().toISOString(), tool: "cancel_all_orders", transport, args_summary: { market_id }, success: true });
+        return result;
     }
     catch (err) {
         const msg = err instanceof BudaApiError
-            ? { error: err.message, code: err.status, path: err.path }
+            ? { error: err.message, code: err.status }
             : { error: String(err), code: "UNKNOWN" };
-        return {
-            content: [{ type: "text", text: JSON.stringify(msg) }],
-            isError: true,
-        };
+        const result = { content: [{ type: "text", text: JSON.stringify(msg) }], isError: true };
+        logAudit({ ts: new Date().toISOString(), tool: "cancel_all_orders", transport, args_summary: { market_id }, success: false, error_code: msg.code });
+        return result;
     }
 }
-export function register(server, client) {
+export function register(server, client, transport = "stdio") {
     server.tool(toolSchema.name, toolSchema.description, {
         market_id: z
             .string()
@@ -84,6 +81,6 @@ export function register(server, client) {
             .string()
             .describe("Safety confirmation. Must equal exactly 'CONFIRM' (case-sensitive) to execute. " +
             "Any other value will reject the request without canceling."),
-    }, (args) => handleCancelAllOrders(args, client));
+    }, (args) => handleCancelAllOrders(args, client, transport));
 }
 //# sourceMappingURL=cancel_all_orders.js.map