@guiie/buda-mcp 1.4.0 → 1.4.1

package/CHANGELOG.md

@@ -7,6 +7,16 @@ This project uses [Semantic Versioning](https://semver.org/).
 
 ---
 
+## [1.4.1] – 2026-04-11
+
+### Fixed
+
+- **`simulate_order`**: `taker_fee` returned by Buda API is already expressed as a percentage (`0.8` = 0.8%), not a decimal. Dividing by 100 before use gives correct fee calculations. Previously this caused fee_amount and total_cost to be ~100× too large.
+- Integration test (`test/run-all.ts`): added live checks for all 5 v1.4.0 tools; fixed field name `candles_available` (was `candles_used`).
+- Unit test mocks: updated `taker_fee` mock values from `"0.008"`/`"0.005"` to `"0.8"`/`"0.5"` to match the real Buda API format.
+
+---
+
 ## [1.4.0] – 2026-04-11
 
 ### Added

package/dist/tools/simulate_order.js

@@ -67,7 +67,7 @@ export async function handleSimulateOrder(args, client, cache) {
             };
         }
         const mid = (minAsk + maxBid) / 2;
-        const takerFeeRate = parseFloat(market.taker_fee);
+        const takerFeeRate = parseFloat(market.taker_fee) / 100;
         const orderTypeAssumed = price !== undefined ? "limit" : "market";
         let estimatedFillPrice;
         if (orderTypeAssumed === "market") {

package/marketplace/gemini-tools.json

@@ -306,6 +306,93 @@
         },
         "required": ["market_id"]
       }
+    },
+    {
+      "name": "get_balances",
+      "description": "Returns all currency balances for the authenticated Buda.com account as flat typed objects. Each currency entry includes total amount, available amount (not frozen), frozen amount, and pending withdrawal amount — all as floats with separate _currency fields. Requires BUDA_API_KEY and BUDA_API_SECRET. Auth-gated. Example: 'How much BTC do I have available to trade right now?'",
+      "parameters": {
+        "type": "OBJECT",
+        "properties": {},
+        "required": []
+      }
+    },
+    {
+      "name": "get_orders",
+      "description": "Returns orders for a given Buda.com market as flat typed objects. All monetary amounts are floats with separate _currency fields (e.g. amount + amount_currency). Filterable by state: pending, active, traded, canceled, canceled_and_traded. Supports pagination via per and page. Requires BUDA_API_KEY and BUDA_API_SECRET. Auth-gated. Example: 'Show my open limit orders on BTC-CLP.'",
+      "parameters": {
+        "type": "OBJECT",
+        "properties": {
+          "market_id": {
+            "type": "STRING",
+            "description": "Market identifier (e.g. 'BTC-CLP', 'ETH-BTC'). Case-insensitive."
+          },
+          "state": {
+            "type": "STRING",
+            "description": "Filter by order state: 'pending', 'active', 'traded', 'canceled', 'canceled_and_traded'. Omit to return all orders."
+          },
+          "per": {
+            "type": "INTEGER",
+            "description": "Results per page (default: 20, max: 300)."
+          },
+          "page": {
+            "type": "INTEGER",
+            "description": "Page number (default: 1)."
+          }
+        },
+        "required": ["market_id"]
+      }
+    },
+    {
+      "name": "place_order",
+      "description": "Places a limit or market order on Buda.com. IMPORTANT: Requires confirmation_token='CONFIRM' to execute — any other value rejects without placing an order, preventing accidental execution. Requires BUDA_API_KEY and BUDA_API_SECRET. Auth-gated. WARNING: Only use on locally-run instances — never on a publicly exposed server.",
+      "parameters": {
+        "type": "OBJECT",
+        "properties": {
+          "market_id": {
+            "type": "STRING",
+            "description": "Market identifier (e.g. 'BTC-CLP', 'ETH-BTC'). Case-insensitive."
+          },
+          "type": {
+            "type": "STRING",
+            "description": "Order side: 'Bid' to buy, 'Ask' to sell."
+          },
+          "price_type": {
+            "type": "STRING",
+            "description": "Order type: 'limit' places at a specific price, 'market' executes immediately at best available price."
+          },
+          "amount": {
+            "type": "NUMBER",
+            "description": "Order size in the market's base currency (e.g. BTC amount for BTC-CLP)."
+          },
+          "limit_price": {
+            "type": "NUMBER",
+            "description": "Limit price in quote currency. Required when price_type is 'limit'. For Bid orders: highest price you will pay. For Ask orders: lowest price you will accept."
+          },
+          "confirmation_token": {
+            "type": "STRING",
+            "description": "Safety confirmation. Must equal exactly 'CONFIRM' (case-sensitive) to place the order. Any other value rejects the request."
+          }
+        },
+        "required": ["market_id", "type", "price_type", "amount", "confirmation_token"]
+      }
+    },
+    {
+      "name": "cancel_order",
+      "description": "Cancels an open order by numeric ID on Buda.com. IMPORTANT: Requires confirmation_token='CONFIRM' to execute — any other value rejects without cancelling. Requires BUDA_API_KEY and BUDA_API_SECRET. Auth-gated.",
+      "parameters": {
+        "type": "OBJECT",
+        "properties": {
+          "order_id": {
+            "type": "INTEGER",
+            "description": "The numeric ID of the order to cancel."
+          },
+          "confirmation_token": {
+            "type": "STRING",
+            "description": "Safety confirmation. Must equal exactly 'CONFIRM' (case-sensitive) to cancel the order. Any other value rejects the request."
+          }
+        },
+        "required": ["order_id", "confirmation_token"]
+      }
     }
   ]
 }

package/marketplace/openapi.yaml

@@ -14,7 +14,7 @@ info:
     stdio server. Deploy locally with mcp-proxy:
       mcp-proxy --port 8000 -- npx -y @guiie/buda-mcp
     Or point `servers[0].url` at your hosted instance.
-  version: 1.3.0
+  version: 1.4.0
   contact:
     url: https://github.com/gtorreal/buda-mcp
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@guiie/buda-mcp",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "mcpName": "io.github.gtorreal/buda-mcp",
   "description": "MCP server for Buda.com's public cryptocurrency exchange API (Chile, Colombia, Peru)",
   "type": "module",

package/server.json

@@ -6,12 +6,12 @@
     "url": "https://github.com/gtorreal/buda-mcp",
     "source": "github"
   },
-  "version": "1.4.0",
+  "version": "1.4.1",
   "packages": [
     {
       "registryType": "npm",
       "identifier": "@guiie/buda-mcp",
-      "version": "1.4.0",
+      "version": "1.4.1",
       "transport": {
         "type": "stdio"
       }

package/src/tools/simulate_order.ts

@@ -99,7 +99,7 @@ export async function handleSimulateOrder(
     }
 
     const mid = (minAsk + maxBid) / 2;
-    const takerFeeRate = parseFloat(market.taker_fee);
+    const takerFeeRate = parseFloat(market.taker_fee) / 100;
     const orderTypeAssumed = price !== undefined ? "limit" : "market";
 
     let estimatedFillPrice: number;

package/test/run-all.ts

@@ -18,6 +18,12 @@ try {
 }
 
 import { BudaClient } from "../src/client.js";
+import { MemoryCache } from "../src/cache.js";
+import { handleSimulateOrder } from "../src/tools/simulate_order.js";
+import { handleCalculatePositionSize } from "../src/tools/calculate_position_size.js";
+import { handleMarketSentiment } from "../src/tools/market_sentiment.js";
+import { handleTechnicalIndicators } from "../src/tools/technical_indicators.js";
+import { handleScheduleCancelAll, handleDisarmCancelTimer } from "../src/tools/dead_mans_switch.js";
 import type {
   MarketsResponse,
   TickerResponse,
@@ -225,6 +231,167 @@ try {
   failures++;
 }
 
+// ----------------------------------------------------------------
+// 9. simulate_order
+// ----------------------------------------------------------------
+section(`simulate_order — ${TEST_MARKET} market buy`);
+{
+  const cache = new MemoryCache();
+  try {
+    const result = await handleSimulateOrder(
+      { market_id: TEST_MARKET, side: "buy", amount: 0.001 },
+      client,
+      cache,
+    );
+    if (result.isError) throw new Error(result.content[0].text);
+    const parsed = JSON.parse(result.content[0].text) as {
+      simulation: boolean;
+      estimated_fill_price: number;
+      fee_amount: number;
+      fee_rate_pct: number;
+      total_cost: number;
+      slippage_vs_mid_pct: number;
+      order_type_assumed: string;
+    };
+    if (parsed.simulation !== true) throw new Error("simulation flag must be true");
+    pass("simulation: true", "✓");
+    pass("order_type_assumed", parsed.order_type_assumed);
+    pass("estimated_fill_price", `${parsed.estimated_fill_price.toLocaleString()} CLP`);
+    pass("fee_rate_pct", `${parsed.fee_rate_pct}%`);
+    pass("fee_amount", `${parsed.fee_amount.toFixed(2)} CLP`);
+    pass("total_cost", `${parsed.total_cost.toFixed(2)} CLP`);
+    pass("slippage_vs_mid_pct", `${parsed.slippage_vs_mid_pct}%`);
+  } catch (err) {
+    fail("simulate_order", err);
+    failures++;
+  }
+}
+
+// ----------------------------------------------------------------
+// 10. calculate_position_size
+// ----------------------------------------------------------------
+section(`calculate_position_size — ${TEST_MARKET}`);
+{
+  // Fetch live ticker to use real entry/stop prices
+  try {
+    const tickerData = await client.get<TickerResponse>(
+      `/markets/${TEST_MARKET.toLowerCase()}/ticker`,
+    );
+    const lastPrice = parseFloat(tickerData.ticker.last_price[0]);
+    const entryPrice = lastPrice;
+    const stopLossPrice = parseFloat((lastPrice * 0.97).toFixed(0)); // 3% below entry
+
+    const result = handleCalculatePositionSize({
+      market_id: TEST_MARKET,
+      capital: 1_000_000,
+      risk_pct: 2,
+      entry_price: entryPrice,
+      stop_loss_price: stopLossPrice,
+    });
+    if (result.isError) throw new Error(result.content[0].text);
+    const parsed = JSON.parse(result.content[0].text) as {
+      side: string;
+      units: number;
+      capital_at_risk: number;
+      position_value: number;
+      fee_impact: number;
+      fee_currency: string;
+    };
+    pass("side", parsed.side);
+    pass("units", `${parsed.units} BTC`);
+    pass("capital_at_risk", `${parsed.capital_at_risk.toLocaleString()} CLP`);
+    pass("position_value", `${parsed.position_value.toLocaleString()} CLP`);
+    pass("fee_impact", `${parsed.fee_impact.toFixed(2)} ${parsed.fee_currency}`);
+  } catch (err) {
+    fail("calculate_position_size", err);
+    failures++;
+  }
+}
+
+// ----------------------------------------------------------------
+// 11. get_market_sentiment
+// ----------------------------------------------------------------
+section(`get_market_sentiment — ${TEST_MARKET}`);
+{
+  const cache = new MemoryCache();
+  try {
+    const result = await handleMarketSentiment({ market_id: TEST_MARKET }, client, cache);
+    if (result.isError) throw new Error(result.content[0].text);
+    const parsed = JSON.parse(result.content[0].text) as {
+      score: number;
+      label: string;
+      component_breakdown: {
+        price_variation_24h_pct: number;
+        volume_ratio: number;
+        spread_pct: number;
+      };
+      disclaimer: string;
+    };
+    if (!["bearish", "neutral", "bullish"].includes(parsed.label)) {
+      throw new Error(`unexpected label: ${parsed.label}`);
+    }
+    if (typeof parsed.score !== "number" || parsed.score < -100 || parsed.score > 100) {
+      throw new Error(`score out of range: ${parsed.score}`);
+    }
+    pass("score", String(parsed.score));
+    pass("label", parsed.label);
+    pass("price_variation_24h_pct", `${parsed.component_breakdown.price_variation_24h_pct}%`);
+    pass("volume_ratio", String(parsed.component_breakdown.volume_ratio));
+    pass("spread_pct", `${parsed.component_breakdown.spread_pct}%`);
+    pass("disclaimer", parsed.disclaimer.length > 0 ? "present" : "MISSING");
+  } catch (err) {
+    fail("get_market_sentiment", err);
+    failures++;
+  }
+}
+
+// ----------------------------------------------------------------
+// 12. get_technical_indicators
+// ----------------------------------------------------------------
+section(`get_technical_indicators — ${TEST_MARKET} (1h, limit 1000)`);
+{
+  try {
+    const result = await handleTechnicalIndicators(
+      { market_id: TEST_MARKET, period: "1h", limit: 1000 },
+      client,
+    );
+    if (result.isError) throw new Error(result.content[0].text);
+    const parsed = JSON.parse(result.content[0].text) as {
+      candles_used?: number;
+      candles_available?: number;
+      warning?: string;
+      indicators: {
+        rsi: number | null;
+        macd: { line: number; signal: number; histogram: number } | null;
+        bollinger_bands: { upper: number; mid: number; lower: number } | null;
+        sma_20: number;
+        sma_50: number;
+      } | null;
+      signals: { rsi_signal: string; macd_signal: string; bb_signal: string };
+      disclaimer: string;
+    };
+
+    if (parsed.warning === "insufficient_data") {
+      pass("warning", `insufficient_data (${parsed.candles_available} candles available, need 50)`);
+    } else {
+      pass("candles_used", String(parsed.candles_used));
+      if (!parsed.indicators) throw new Error("indicators is null without a warning");
+      pass("rsi", String(parsed.indicators.rsi));
+      pass("rsi_signal", parsed.signals.rsi_signal);
+      pass("macd_histogram", String(parsed.indicators.macd?.histogram));
+      pass("macd_signal", parsed.signals.macd_signal);
+      pass("bb_upper", String(parsed.indicators.bollinger_bands?.upper));
+      pass("bb_signal", parsed.signals.bb_signal);
+      pass("sma_20", String(parsed.indicators.sma_20));
+      pass("sma_50", String(parsed.indicators.sma_50));
+      pass("disclaimer", parsed.disclaimer.length > 0 ? "present" : "MISSING");
+    }
+  } catch (err) {
+    fail("get_technical_indicators", err);
+    failures++;
+  }
+}
+
 // ----------------------------------------------------------------
 // Auth tools: get_balances, get_orders, place_order, cancel_order
 // ----------------------------------------------------------------
@@ -263,6 +430,34 @@ if (!client.hasAuth()) {
   // cancel_order — confirmation guard test (must reject without CONFIRM)
   console.log("  Skipping: cancel_order live execution (destructive — requires confirmation_token=CONFIRM)");
   pass("cancel_order guard", "confirmation_token check enforced at tool layer (code-audited)");
+
+  // schedule_cancel_all — arm then immediately disarm (non-destructive)
+  try {
+    const armResult = await handleScheduleCancelAll(
+      { market_id: TEST_MARKET, ttl_seconds: 300, confirmation_token: "CONFIRM" },
+      client,
+    );
+    if (armResult.isError) throw new Error(armResult.content[0].text);
+    const armed = JSON.parse(armResult.content[0].text) as {
+      active: boolean;
+      expires_at: string;
+      ttl_seconds: number;
+      warning: string;
+    };
+    if (!armed.active) throw new Error("active should be true after CONFIRM");
+    pass("schedule_cancel_all active", armed.active ? "true" : "false");
+    pass("schedule_cancel_all expires_at", armed.expires_at);
+    pass("schedule_cancel_all warning", armed.warning.length > 0 ? "present" : "MISSING");
+
+    // Immediately disarm so no orders are cancelled
+    const disarmResult = handleDisarmCancelTimer({ market_id: TEST_MARKET });
+    if (disarmResult.isError) throw new Error(disarmResult.content[0].text);
+    const disarmed = JSON.parse(disarmResult.content[0].text) as { disarmed: boolean };
+    pass("disarm_cancel_timer", disarmed.disarmed ? "timer cleared ✓" : "FAILED to disarm");
+  } catch (err) {
+    fail("schedule_cancel_all / disarm_cancel_timer", err);
+    failures++;
+  }
 }
 
 // ----------------------------------------------------------------
@@ -271,6 +466,8 @@ if (!client.hasAuth()) {
 section("Summary");
 if (failures === 0) {
   console.log("  All tools returned valid data from the live Buda API.");
+  console.log("  Coverage: simulate_order, calculate_position_size, get_market_sentiment,");
+  console.log("            get_technical_indicators, schedule_cancel_all/disarm (auth-gated if credentials set).");
 } else {
   console.error(`  ${failures} tool(s) failed. See errors above.`);
   process.exit(1);

package/test/unit.ts

@@ -666,7 +666,7 @@ await test("handleMarketSummary returns correct liquidity_rating from mocked API
 
 section("i. simulate_order");
 
-function makeMockFetchForSimulate(takerFee = "0.008"): typeof fetch {
+function makeMockFetchForSimulate(takerFee = "0.8"): typeof fetch {
   const mockTicker = {
     ticker: {
       market_id: "BTC-CLP",
@@ -720,7 +720,7 @@ await test("market buy: estimated_fill_price = min_ask, simulation: true", async
     assertEqual(parsed.simulation, true, "simulation flag must be true");
     assertEqual(parsed.estimated_fill_price, 65100000, "market buy fills at min_ask");
     assertEqual(parsed.order_type_assumed, "market", "order_type_assumed should be market");
-    assertEqual(parsed.fee_rate_pct, 0.8, "fee rate should be 0.8% for crypto");
+    assertEqual(parsed.fee_rate_pct, 0.8, "fee_rate_pct should be 0.8 for crypto (0.8% taker fee)");
   } finally {
     globalThis.fetch = savedFetch;
   }
@@ -758,14 +758,14 @@ await test("limit order: order_type_assumed = 'limit'", async () => {
 
 await test("stablecoin market uses 0.5% fee", async () => {
   const savedFetch = globalThis.fetch;
-  globalThis.fetch = makeMockFetchForSimulate("0.005");
+  globalThis.fetch = makeMockFetchForSimulate("0.5");
   try {
     const client = new BudaClient("https://www.buda.com/api/v2");
     const cache = new MemoryCache();
     const result = await handleSimulateOrder({ market_id: "BTC-CLP", side: "buy", amount: 1 }, client, cache);
     assert(!result.isError, "should not be an error");
     const parsed = JSON.parse(result.content[0].text) as { fee_rate_pct: number };
-    assertEqual(parsed.fee_rate_pct, 0.5, "fee_rate_pct should be 0.5 for stablecoin");
+    assertEqual(parsed.fee_rate_pct, 0.5, "fee_rate_pct should be 0.5 for stablecoin (0.5% taker fee)");
   } finally {
     globalThis.fetch = savedFetch;
   }