@guardian/commercial-core 0.34.1 → 0.37.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -57,7 +57,7 @@ export declare class EventTimer {
57
57
  * by EventTimer so they need to be concatenated to EventTimer's private events array.
58
58
  */
59
59
  get events(): Event[];
60
- constructor();
60
+ private constructor();
61
61
  /**
62
62
  * Creates a new performance mark
63
63
  * For slot events also ensures each TYPE of event event is marked only once for 'first'
@@ -96,9 +96,13 @@ class EventTimer {
96
96
  ? [
97
97
  ...this._events,
98
98
  ...EventTimer._externallyDefinedEventNames
99
- .filter((eventName) => window.performance.getEntriesByName(eventName)
100
- .length)
101
- .map((eventName) => new Event(eventName, window.performance.getEntriesByName(eventName)[0])),
99
+ .map((eventName) => {
100
+ const entry = window.performance.getEntriesByName(eventName)[0];
101
+ return entry
102
+ ? new Event(eventName, entry)
103
+ : undefined;
104
+ })
105
+ .filter((entry) => entry instanceof Event),
102
106
  ]
103
107
  : this._events;
104
108
  }
@@ -137,13 +141,11 @@ class EventTimer {
137
141
  mark(name) {
138
142
  const longName = `gu.commercial.${name}`;
139
143
  if (typeof window.performance !== 'undefined' &&
140
- 'mark' in window.performance) {
141
- window.performance.mark(longName);
142
- // Most recent mark with this name is the event we just created.
143
- const mark = window.performance
144
- .getEntriesByName(longName, 'mark')
145
- .slice(-1)[0];
146
- if (typeof mark !== 'undefined') {
144
+ 'mark' in window.performance &&
145
+ typeof window.performance.mark === 'function') {
146
+ const mark = window.performance.mark(longName);
147
+ // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- browser support is patchy
148
+ if (typeof mark?.startTime === 'number') {
147
149
  this._events.push(new Event(name, mark));
148
150
  }
149
151
  }
@@ -6,6 +6,7 @@ export declare type AdSize = Readonly<{
6
6
  }>;
7
7
  export declare type SizeKeys = 'billboard' | 'leaderboard' | 'mpu' | 'halfPage' | 'portrait' | 'skyscraper' | 'mobilesticky' | 'fluid' | 'outOfPage' | 'googleCard' | 'video' | 'outstreamDesktop' | 'outstreamGoogleDesktop' | 'outstreamMobile' | 'merchandisingHighAdFeature' | 'merchandisingHigh' | 'merchandising' | 'inlineMerchandising' | 'fabric' | 'empty' | '970x250' | '728x90' | '300x250' | '300x600' | '300x1050' | '160x600';
8
8
  export declare const adSizes: Record<SizeKeys, AdSize>;
9
+ export declare const getAdSize: (size: SizeKeys) => AdSize;
9
10
  export declare const _: {
10
- getAdSize: (width: number, height: number) => AdSize;
11
+ createAdSize: (width: number, height: number) => AdSize;
11
12
  };
@@ -1,7 +1,7 @@
1
1
  "use strict";
2
2
  Object.defineProperty(exports, "__esModule", { value: true });
3
- exports._ = exports.adSizes = void 0;
4
- const getAdSize = (width, height) => {
3
+ exports._ = exports.getAdSize = exports.adSizes = void 0;
4
+ const createAdSize = (width, height) => {
5
5
  const toString = () => width === 0 && height === 0 ? 'fluid' : `${width},${height}`;
6
6
  return Object.freeze({
7
7
  width,
@@ -11,28 +11,28 @@ const getAdSize = (width, height) => {
11
11
  };
12
12
  const adSizesPartial = {
13
13
  // standard ad sizes
14
- billboard: getAdSize(970, 250),
15
- leaderboard: getAdSize(728, 90),
16
- mpu: getAdSize(300, 250),
17
- halfPage: getAdSize(300, 600),
18
- portrait: getAdSize(300, 1050),
19
- skyscraper: getAdSize(160, 600),
20
- mobilesticky: getAdSize(320, 50),
14
+ billboard: createAdSize(970, 250),
15
+ leaderboard: createAdSize(728, 90),
16
+ mpu: createAdSize(300, 250),
17
+ halfPage: createAdSize(300, 600),
18
+ portrait: createAdSize(300, 1050),
19
+ skyscraper: createAdSize(160, 600),
20
+ mobilesticky: createAdSize(320, 50),
21
21
  // dfp proprietary ad sizes
22
- fluid: getAdSize(0, 0),
23
- outOfPage: getAdSize(1, 1),
24
- googleCard: getAdSize(300, 274),
22
+ fluid: createAdSize(0, 0),
23
+ outOfPage: createAdSize(1, 1),
24
+ googleCard: createAdSize(300, 274),
25
25
  // guardian proprietary ad sizes
26
- video: getAdSize(620, 1),
27
- outstreamDesktop: getAdSize(620, 350),
28
- outstreamGoogleDesktop: getAdSize(550, 310),
29
- outstreamMobile: getAdSize(300, 197),
30
- merchandisingHighAdFeature: getAdSize(88, 89),
31
- merchandisingHigh: getAdSize(88, 87),
32
- merchandising: getAdSize(88, 88),
33
- inlineMerchandising: getAdSize(88, 85),
34
- fabric: getAdSize(88, 71),
35
- empty: getAdSize(2, 2),
26
+ video: createAdSize(620, 1),
27
+ outstreamDesktop: createAdSize(620, 350),
28
+ outstreamGoogleDesktop: createAdSize(550, 310),
29
+ outstreamMobile: createAdSize(300, 197),
30
+ merchandisingHighAdFeature: createAdSize(88, 89),
31
+ merchandisingHigh: createAdSize(88, 87),
32
+ merchandising: createAdSize(88, 88),
33
+ inlineMerchandising: createAdSize(88, 85),
34
+ fabric: createAdSize(88, 71),
35
+ empty: createAdSize(2, 2),
36
36
  };
37
37
  exports.adSizes = {
38
38
  ...adSizesPartial,
@@ -43,5 +43,7 @@ exports.adSizes = {
43
43
  '300x1050': adSizesPartial.portrait,
44
44
  '160x600': adSizesPartial.skyscraper,
45
45
  };
46
+ const getAdSize = (size) => exports.adSizes[size];
47
+ exports.getAdSize = getAdSize;
46
48
  // Export for testing
47
- exports._ = { getAdSize };
49
+ exports._ = { createAdSize };
@@ -7,7 +7,7 @@ export { remarketing } from './third-party-tags/remarketing';
7
7
  export { EventTimer } from './EventTimer';
8
8
  export { sendCommercialMetrics } from './sendCommercialMetrics';
9
9
  export type { ThirdPartyTag } from './types';
10
- export { adSizes } from './ad-sizes';
10
+ export { adSizes, getAdSize } from './ad-sizes';
11
11
  export type { SizeKeys, AdSizeString, AdSize } from './ad-sizes';
12
12
  export { isAdBlockInUse } from './detectAdBlocker';
13
13
  export { clearPermutiveSegments, getPermutiveSegments, getPermutivePFPSegments, } from './permutive';
package/dist/cjs/index.js CHANGED
@@ -20,7 +20,7 @@ var __importStar = (this && this.__importStar) || function (mod) {
20
20
  return result;
21
21
  };
22
22
  Object.defineProperty(exports, "__esModule", { value: true });
23
- exports.constants = exports.disabledAds = exports.buildAdsConfigWithConsent = exports.getPermutivePFPSegments = exports.getPermutiveSegments = exports.clearPermutiveSegments = exports.isAdBlockInUse = exports.adSizes = exports.sendCommercialMetrics = exports.EventTimer = exports.remarketing = exports.inizio = exports.twitter = exports.fbPixel = exports.permutive = exports.ias = void 0;
23
+ exports.constants = exports.disabledAds = exports.buildAdsConfigWithConsent = exports.getPermutivePFPSegments = exports.getPermutiveSegments = exports.clearPermutiveSegments = exports.isAdBlockInUse = exports.getAdSize = exports.adSizes = exports.sendCommercialMetrics = exports.EventTimer = exports.remarketing = exports.inizio = exports.twitter = exports.fbPixel = exports.permutive = exports.ias = void 0;
24
24
  var ias_1 = require("./third-party-tags/ias");
25
25
  Object.defineProperty(exports, "ias", { enumerable: true, get: function () { return ias_1.ias; } });
26
26
  var permutive_1 = require("./third-party-tags/permutive");
@@ -39,6 +39,7 @@ var sendCommercialMetrics_1 = require("./sendCommercialMetrics");
39
39
  Object.defineProperty(exports, "sendCommercialMetrics", { enumerable: true, get: function () { return sendCommercialMetrics_1.sendCommercialMetrics; } });
40
40
  var ad_sizes_1 = require("./ad-sizes");
41
41
  Object.defineProperty(exports, "adSizes", { enumerable: true, get: function () { return ad_sizes_1.adSizes; } });
42
+ Object.defineProperty(exports, "getAdSize", { enumerable: true, get: function () { return ad_sizes_1.getAdSize; } });
42
43
  var detectAdBlocker_1 = require("./detectAdBlocker");
43
44
  Object.defineProperty(exports, "isAdBlockInUse", { enumerable: true, get: function () { return detectAdBlocker_1.isAdBlockInUse; } });
44
45
  var permutive_2 = require("./permutive");
@@ -58,12 +58,13 @@ export declare type ContentTargeting = {
58
58
  */
59
59
  vl: null | typeof videoLengths[number];
60
60
  };
61
- export declare const getContentTargeting: ({ eligibleForDCR, path, renderingPlatform, section, sensitive, videoLength, }: {
61
+ declare type Content = {
62
62
  eligibleForDCR: boolean;
63
63
  path: SharedTargeting['url'];
64
64
  renderingPlatform: ContentTargeting['rp'];
65
65
  section: ContentTargeting['s'];
66
66
  sensitive: boolean;
67
- videoLength?: number | undefined;
68
- }) => ContentTargeting;
67
+ videoLength?: number;
68
+ };
69
+ export declare const getContentTargeting: ({ eligibleForDCR, path, renderingPlatform, section, sensitive, videoLength, }: Content) => ContentTargeting;
69
70
  export {};
@@ -28,7 +28,6 @@ const getUrlKeywords = (url) => {
28
28
  .slice(-1)[0];
29
29
  return (0, libs_1.isString)(lastSegment) ? lastSegment.split('-').filter(Boolean) : [];
30
30
  };
31
- /* -- Targeting -- */
32
31
  const getContentTargeting = ({ eligibleForDCR, path, renderingPlatform, section, sensitive, videoLength, }) => {
33
32
  return {
34
33
  dcre: eligibleForDCR ? 't' : 'f',
@@ -92,7 +92,18 @@ export declare type SessionTargeting = {
92
92
  };
93
93
  export declare type AllParticipations = {
94
94
  clientSideParticipations: Participations;
95
- serverSideParticipations: Record<string, 'control' | 'variant'>;
95
+ serverSideParticipations: {
96
+ [key: `${string}Control`]: 'control';
97
+ [key: `${string}Variant`]: 'variant';
98
+ };
96
99
  };
97
- export declare const getSessionTargeting: (referrer: string, participations: AllParticipations, targeting: Omit<SessionTargeting, 'ab' | 'ref'>) => SessionTargeting;
100
+ declare type Session = {
101
+ adTest: SessionTargeting['at'];
102
+ countryCode: CountryCode;
103
+ isSignedIn: boolean;
104
+ pageViewId: SessionTargeting['pv'];
105
+ participations: AllParticipations;
106
+ referrer: string;
107
+ };
108
+ export declare const getSessionTargeting: ({ adTest, countryCode, isSignedIn, pageViewId, participations, referrer, }: Session) => SessionTargeting;
98
109
  export {};
@@ -49,10 +49,12 @@ const experimentsTargeting = ({ clientSideParticipations, serverSideParticipatio
49
49
  }
50
50
  return [...clientSideExperiment, ...serverSideExperiments];
51
51
  };
52
- /* -- Targeting -- */
53
- const getSessionTargeting = (referrer, participations, targeting) => ({
54
- ref: getReferrer(referrer),
52
+ const getSessionTargeting = ({ adTest, countryCode, isSignedIn, pageViewId, participations, referrer, }) => ({
55
53
  ab: experimentsTargeting(participations),
56
- ...targeting,
54
+ at: adTest,
55
+ cc: countryCode,
56
+ pv: pageViewId,
57
+ ref: getReferrer(referrer),
58
+ si: isSignedIn ? 't' : 'f',
57
59
  });
58
60
  exports.getSessionTargeting = getSessionTargeting;
@@ -57,7 +57,7 @@ export declare class EventTimer {
57
57
  * by EventTimer so they need to be concatenated to EventTimer's private events array.
58
58
  */
59
59
  get events(): Event[];
60
- constructor();
60
+ private constructor();
61
61
  /**
62
62
  * Creates a new performance mark
63
63
  * For slot events also ensures each TYPE of event event is marked only once for 'first'
@@ -93,9 +93,13 @@ export class EventTimer {
93
93
  ? [
94
94
  ...this._events,
95
95
  ...EventTimer._externallyDefinedEventNames
96
- .filter((eventName) => window.performance.getEntriesByName(eventName)
97
- .length)
98
- .map((eventName) => new Event(eventName, window.performance.getEntriesByName(eventName)[0])),
96
+ .map((eventName) => {
97
+ const entry = window.performance.getEntriesByName(eventName)[0];
98
+ return entry
99
+ ? new Event(eventName, entry)
100
+ : undefined;
101
+ })
102
+ .filter((entry) => entry instanceof Event),
99
103
  ]
100
104
  : this._events;
101
105
  }
@@ -134,13 +138,11 @@ export class EventTimer {
134
138
  mark(name) {
135
139
  const longName = `gu.commercial.${name}`;
136
140
  if (typeof window.performance !== 'undefined' &&
137
- 'mark' in window.performance) {
138
- window.performance.mark(longName);
139
- // Most recent mark with this name is the event we just created.
140
- const mark = window.performance
141
- .getEntriesByName(longName, 'mark')
142
- .slice(-1)[0];
143
- if (typeof mark !== 'undefined') {
141
+ 'mark' in window.performance &&
142
+ typeof window.performance.mark === 'function') {
143
+ const mark = window.performance.mark(longName);
144
+ // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- browser support is patchy
145
+ if (typeof mark?.startTime === 'number') {
144
146
  this._events.push(new Event(name, mark));
145
147
  }
146
148
  }
@@ -6,6 +6,7 @@ export declare type AdSize = Readonly<{
6
6
  }>;
7
7
  export declare type SizeKeys = 'billboard' | 'leaderboard' | 'mpu' | 'halfPage' | 'portrait' | 'skyscraper' | 'mobilesticky' | 'fluid' | 'outOfPage' | 'googleCard' | 'video' | 'outstreamDesktop' | 'outstreamGoogleDesktop' | 'outstreamMobile' | 'merchandisingHighAdFeature' | 'merchandisingHigh' | 'merchandising' | 'inlineMerchandising' | 'fabric' | 'empty' | '970x250' | '728x90' | '300x250' | '300x600' | '300x1050' | '160x600';
8
8
  export declare const adSizes: Record<SizeKeys, AdSize>;
9
+ export declare const getAdSize: (size: SizeKeys) => AdSize;
9
10
  export declare const _: {
10
- getAdSize: (width: number, height: number) => AdSize;
11
+ createAdSize: (width: number, height: number) => AdSize;
11
12
  };
@@ -1,4 +1,4 @@
1
- const getAdSize = (width, height) => {
1
+ const createAdSize = (width, height) => {
2
2
  const toString = () => width === 0 && height === 0 ? 'fluid' : `${width},${height}`;
3
3
  return Object.freeze({
4
4
  width,
@@ -8,28 +8,28 @@ const getAdSize = (width, height) => {
8
8
  };
9
9
  const adSizesPartial = {
10
10
  // standard ad sizes
11
- billboard: getAdSize(970, 250),
12
- leaderboard: getAdSize(728, 90),
13
- mpu: getAdSize(300, 250),
14
- halfPage: getAdSize(300, 600),
15
- portrait: getAdSize(300, 1050),
16
- skyscraper: getAdSize(160, 600),
17
- mobilesticky: getAdSize(320, 50),
11
+ billboard: createAdSize(970, 250),
12
+ leaderboard: createAdSize(728, 90),
13
+ mpu: createAdSize(300, 250),
14
+ halfPage: createAdSize(300, 600),
15
+ portrait: createAdSize(300, 1050),
16
+ skyscraper: createAdSize(160, 600),
17
+ mobilesticky: createAdSize(320, 50),
18
18
  // dfp proprietary ad sizes
19
- fluid: getAdSize(0, 0),
20
- outOfPage: getAdSize(1, 1),
21
- googleCard: getAdSize(300, 274),
19
+ fluid: createAdSize(0, 0),
20
+ outOfPage: createAdSize(1, 1),
21
+ googleCard: createAdSize(300, 274),
22
22
  // guardian proprietary ad sizes
23
- video: getAdSize(620, 1),
24
- outstreamDesktop: getAdSize(620, 350),
25
- outstreamGoogleDesktop: getAdSize(550, 310),
26
- outstreamMobile: getAdSize(300, 197),
27
- merchandisingHighAdFeature: getAdSize(88, 89),
28
- merchandisingHigh: getAdSize(88, 87),
29
- merchandising: getAdSize(88, 88),
30
- inlineMerchandising: getAdSize(88, 85),
31
- fabric: getAdSize(88, 71),
32
- empty: getAdSize(2, 2),
23
+ video: createAdSize(620, 1),
24
+ outstreamDesktop: createAdSize(620, 350),
25
+ outstreamGoogleDesktop: createAdSize(550, 310),
26
+ outstreamMobile: createAdSize(300, 197),
27
+ merchandisingHighAdFeature: createAdSize(88, 89),
28
+ merchandisingHigh: createAdSize(88, 87),
29
+ merchandising: createAdSize(88, 88),
30
+ inlineMerchandising: createAdSize(88, 85),
31
+ fabric: createAdSize(88, 71),
32
+ empty: createAdSize(2, 2),
33
33
  };
34
34
  export const adSizes = {
35
35
  ...adSizesPartial,
@@ -40,5 +40,6 @@ export const adSizes = {
40
40
  '300x1050': adSizesPartial.portrait,
41
41
  '160x600': adSizesPartial.skyscraper,
42
42
  };
43
+ export const getAdSize = (size) => adSizes[size];
43
44
  // Export for testing
44
- export const _ = { getAdSize };
45
+ export const _ = { createAdSize };
@@ -7,7 +7,7 @@ export { remarketing } from './third-party-tags/remarketing';
7
7
  export { EventTimer } from './EventTimer';
8
8
  export { sendCommercialMetrics } from './sendCommercialMetrics';
9
9
  export type { ThirdPartyTag } from './types';
10
- export { adSizes } from './ad-sizes';
10
+ export { adSizes, getAdSize } from './ad-sizes';
11
11
  export type { SizeKeys, AdSizeString, AdSize } from './ad-sizes';
12
12
  export { isAdBlockInUse } from './detectAdBlocker';
13
13
  export { clearPermutiveSegments, getPermutiveSegments, getPermutivePFPSegments, } from './permutive';
package/dist/esm/index.js CHANGED
@@ -7,7 +7,7 @@ export { inizio } from './third-party-tags/inizio';
7
7
  export { remarketing } from './third-party-tags/remarketing';
8
8
  export { EventTimer } from './EventTimer';
9
9
  export { sendCommercialMetrics } from './sendCommercialMetrics';
10
- export { adSizes } from './ad-sizes';
10
+ export { adSizes, getAdSize } from './ad-sizes';
11
11
  export { isAdBlockInUse } from './detectAdBlocker';
12
12
  export { clearPermutiveSegments, getPermutiveSegments, getPermutivePFPSegments, } from './permutive';
13
13
  export { buildAdsConfigWithConsent, disabledAds } from './ad-targeting-youtube';
@@ -58,12 +58,13 @@ export declare type ContentTargeting = {
58
58
  */
59
59
  vl: null | typeof videoLengths[number];
60
60
  };
61
- export declare const getContentTargeting: ({ eligibleForDCR, path, renderingPlatform, section, sensitive, videoLength, }: {
61
+ declare type Content = {
62
62
  eligibleForDCR: boolean;
63
63
  path: SharedTargeting['url'];
64
64
  renderingPlatform: ContentTargeting['rp'];
65
65
  section: ContentTargeting['s'];
66
66
  sensitive: boolean;
67
- videoLength?: number | undefined;
68
- }) => ContentTargeting;
67
+ videoLength?: number;
68
+ };
69
+ export declare const getContentTargeting: ({ eligibleForDCR, path, renderingPlatform, section, sensitive, videoLength, }: Content) => ContentTargeting;
69
70
  export {};
@@ -25,7 +25,6 @@ const getUrlKeywords = (url) => {
25
25
  .slice(-1)[0];
26
26
  return isString(lastSegment) ? lastSegment.split('-').filter(Boolean) : [];
27
27
  };
28
- /* -- Targeting -- */
29
28
  export const getContentTargeting = ({ eligibleForDCR, path, renderingPlatform, section, sensitive, videoLength, }) => {
30
29
  return {
31
30
  dcre: eligibleForDCR ? 't' : 'f',
@@ -92,7 +92,18 @@ export declare type SessionTargeting = {
92
92
  };
93
93
  export declare type AllParticipations = {
94
94
  clientSideParticipations: Participations;
95
- serverSideParticipations: Record<string, 'control' | 'variant'>;
95
+ serverSideParticipations: {
96
+ [key: `${string}Control`]: 'control';
97
+ [key: `${string}Variant`]: 'variant';
98
+ };
96
99
  };
97
- export declare const getSessionTargeting: (referrer: string, participations: AllParticipations, targeting: Omit<SessionTargeting, 'ab' | 'ref'>) => SessionTargeting;
100
+ declare type Session = {
101
+ adTest: SessionTargeting['at'];
102
+ countryCode: CountryCode;
103
+ isSignedIn: boolean;
104
+ pageViewId: SessionTargeting['pv'];
105
+ participations: AllParticipations;
106
+ referrer: string;
107
+ };
108
+ export declare const getSessionTargeting: ({ adTest, countryCode, isSignedIn, pageViewId, participations, referrer, }: Session) => SessionTargeting;
98
109
  export {};
@@ -46,9 +46,11 @@ const experimentsTargeting = ({ clientSideParticipations, serverSideParticipatio
46
46
  }
47
47
  return [...clientSideExperiment, ...serverSideExperiments];
48
48
  };
49
- /* -- Targeting -- */
50
- export const getSessionTargeting = (referrer, participations, targeting) => ({
51
- ref: getReferrer(referrer),
49
+ export const getSessionTargeting = ({ adTest, countryCode, isSignedIn, pageViewId, participations, referrer, }) => ({
52
50
  ab: experimentsTargeting(participations),
53
- ...targeting,
51
+ at: adTest,
52
+ cc: countryCode,
53
+ pv: pageViewId,
54
+ ref: getReferrer(referrer),
55
+ si: isSignedIn ? 't' : 'f',
54
56
  });
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@guardian/commercial-core",
3
- "version": "0.34.1",
3
+ "version": "0.37.1",
4
4
  "description": "Guardian advertising business logic",
5
5
  "homepage": "https://github.com/guardian/commercial-core#readme",
6
6
  "bugs": {