@guanlin4924/devflow-pi 0.1.83 → 0.1.86

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@guanlin4924/devflow-pi",
-  "version": "0.1.83",
+  "version": "0.1.86",
   "type": "module",
   "description": "Devflow 专项研发 Pi，基于固定版本 OMP Runtime 组装研发状态机、代码智能、设计、实现与质量门禁。",
   "license": "UNLICENSED",

package/plugins/devflow-core/extensions/devflow-core.ts

@@ -923,6 +923,12 @@ function compactStep(value: unknown): Record<string, unknown> | null {
   };
 }
 
+function selectedWorkflowStep(snapshot: Record<string, unknown>): Record<string, unknown> | null {
+  return snapshot.action === "run_parallel_window"
+    ? compactStep(snapshot.next_step) ?? compactStep(snapshot.current_step)
+    : compactStep(snapshot.current_step) ?? compactStep(snapshot.next_step);
+}
+
 /**
  * The approval prompt is session-local, while the completed step outputs are
  * durable. After a rollover, compaction, or runtime restart the in-memory
@@ -968,7 +974,7 @@ export function workflowResumeDisposition(snapshot: Record<string, unknown>): Wo
 
   const feature = typeof snapshot.current_feature === "string" ? snapshot.current_feature : "";
   const revision = snapshot.revision;
-  const selectedStep = compactStep(snapshot.next_step) ?? compactStep(snapshot.current_step);
+  const selectedStep = selectedWorkflowStep(snapshot);
   const stepId = typeof selectedStep?.id === "string" ? selectedStep.id : "";
   if (!feature || !stepId || typeof revision !== "number" || !Number.isInteger(revision)) return "idle";
 
@@ -985,7 +991,7 @@ export function workflowResumeDisposition(snapshot: Record<string, unknown>): Wo
 }
 
 function workflowDirective(snapshot: Record<string, unknown>, source: "start" | "approval", requirementDraft?: string): string {
-  const selectedStep = compactStep(snapshot.next_step) ?? compactStep(snapshot.current_step);
+  const selectedStep = selectedWorkflowStep(snapshot);
   const envelope = {
     source,
     action: snapshot.action,
@@ -1037,7 +1043,7 @@ function projectInitializationDirective(summary: string): string {
 
 function explainWorkflowSnapshot(snapshot: Record<string, unknown> | null): string {
   if (!snapshot) return "Devflow 当前没有可解释的工作流状态。可使用 /devflow start <功能名> 创建新功能。";
-  const step = compactStep(snapshot.next_step) ?? compactStep(snapshot.current_step);
+  const step = selectedWorkflowStep(snapshot);
   const lines = [
     `功能：${String(snapshot.current_feature ?? "未开始")}`,
     `阶段：${workflowPhaseName(snapshot.current_phase)}`,
@@ -2045,7 +2051,7 @@ export default function devflowCore(pi: ExtensionAPI) {
     snapshot: Record<string, unknown>,
   ): Promise<WorkflowResumeDisposition> {
     const disposition = workflowResumeDisposition(snapshot);
-    const stepId = String((compactStep(snapshot.next_step) ?? compactStep(snapshot.current_step))?.id ?? "当前步骤");
+    const stepId = String(selectedWorkflowStep(snapshot)?.id ?? "当前步骤");
     if (disposition === "execute") {
       setControlState(ctx, executingState(`恢复并执行 ${stepId}`));
       ctx.ui.notify(`Devflow 已恢复到 ${stepId}，当前步骤产物尚未完成，正在继续执行。`, "info");
@@ -2598,7 +2604,7 @@ export default function devflowCore(pi: ExtensionAPI) {
         }
         const revision = typeof inspected.snapshot.revision === "number" ? inspected.snapshot.revision : undefined;
         const checkpoint = inspected.snapshot.status === "waiting_checkpoint";
-        const step = compactStep(inspected.snapshot.next_step) ?? compactStep(inspected.snapshot.current_step);
+        const step = selectedWorkflowStep(inspected.snapshot);
         const stepId = typeof step?.id === "string" ? step.id : undefined;
         if (revision === undefined || (!checkpoint && !stepId)) {
           ctx.ui.notify("当前状态缺少可确认的 revision 或步骤，拒绝推进。", "error");
@@ -3971,7 +3977,7 @@ export default function devflowCore(pi: ExtensionAPI) {
         const revision = plan?.expected_revision;
         if (!inspected.result.ok || !plan || plan.classification !== "safe_repairable" || typeof revision !== "number") {
           const status = typeof inspected.snapshot?.status === "string" ? inspected.snapshot.status : "unknown";
-          const step = compactStep(inspected.snapshot?.next_step) ?? compactStep(inspected.snapshot?.current_step);
+          const step = inspected.snapshot ? selectedWorkflowStep(inspected.snapshot) : null;
           const stepId = typeof step?.id === "string" ? step.id : "当前步骤";
           if (inspected.result.ok && status === "in_progress") {
             ctx.ui.notify(`控制面状态一致，无需恢复。当前步骤是 ${stepId}；请审查当前产物后明确回复“批准执行”或提出修改意见。`, "info");

package/plugins/devflow-core/skills/workflow-orchestrator/scripts/execution_contract.rb

@@ -15,6 +15,12 @@ POLICY = {
   "requirement-baseline" => { "checkers" => %w[requirement-graph-check business-closure-check slice-independence-check acceptance-coverage-check change-impact-check], "agents" => [], "budget" => 0, "allowed_graph_delta" => %w[requirement rule boundary slice acceptance] },
   "api-contract" => { "checkers" => %w[requirement-graph-check contract-coverage-check api-test-schema-check change-impact-check], "agents" => [], "budget" => 0, "allowed_graph_delta" => %w[api] },
   "architecture-feasibility" => { "checkers" => %w[requirement-graph-check change-impact-check], "agents" => [], "budget" => 0, "allowed_graph_delta" => %w[workload_shape workload_constraint decision risk metric read_model] },
+  "backend-tech-spec" => { "checkers" => %w[requirement-graph-check change-impact-check], "agents" => ["implementation-worker"], "budget" => 1, "allowed_graph_delta" => %w[decision risk] },
+  "api-call-guide" => { "checkers" => %w[requirement-graph-check contract-coverage-check], "agents" => ["implementation-worker"], "budget" => 1, "allowed_graph_delta" => %w[api decision] },
+  "ui-spec" => { "checkers" => %w[requirement-graph-check change-impact-check], "agents" => ["implementation-worker"], "budget" => 1, "allowed_graph_delta" => %w[decision risk] },
+  "feature-breakdown" => { "checkers" => %w[requirement-graph-check], "agents" => ["implementation-worker"], "budget" => 1, "allowed_graph_delta" => %w[requirement rule] },
+  "frontend-tech-spec" => { "checkers" => %w[requirement-graph-check change-impact-check], "agents" => ["implementation-worker"], "budget" => 1, "allowed_graph_delta" => %w[decision risk] },
+  "api-supplement" => { "checkers" => %w[requirement-graph-check contract-coverage-check], "agents" => ["implementation-worker"], "budget" => 1, "allowed_graph_delta" => %w[api decision] },
   "integration-verify" => { "checkers" => %w[requirement-graph-check slice-independence-check contract-coverage-check change-impact-check cross-track-consistency-check business-claim-reference-check business-cross-model-check], "agents" => ["verification-runner"], "budget" => 1, "allowed_graph_delta" => %w[requirement risk decision] },
   "acceptance-test-design" => { "checkers" => %w[requirement-graph-check contract-coverage-check acceptance-coverage-check api-test-matrix-check test-coverage-check test-obligation-check change-impact-check], "agents" => [], "budget" => 0, "allowed_graph_delta" => %w[test_case] },
   "change-plan" => { "checkers" => %w[requirement-graph-check slice-independence-check contract-coverage-check api-test-matrix-check test-coverage-check test-obligation-check test-task-binding-check change-impact-check], "agents" => [], "budget" => 0, "allowed_graph_delta" => %w[acceptance] },
@@ -45,6 +51,27 @@ def interpolate(value, state)
   value.gsub("{feature}", state.fetch("current_feature").to_s).gsub("{phase}", state.fetch("current_phase").to_s)
 end
 
+def render_execution_contract_markdown(contract)
+  lines = [
+    "# Execution Contract",
+    "",
+    "> Core-generated derived view. The immutable contract JSON under `.planning/contracts/` is authoritative.",
+    "",
+    "- Contract ID: `#{contract.fetch("contract_id")}`",
+    "- Feature: `#{contract.fetch("feature")}`",
+    "- Step: `#{contract.fetch("step")}`",
+    "- STATE revision: `#{contract.fetch("state_revision")}`",
+    "- Requirement graph revision: `#{contract.fetch("graph_revision")}`",
+    "- Frozen hash: `#{contract.fetch("frozen_hash")}`",
+    "",
+    "## Allowed paths",
+    "",
+  ]
+  lines.concat(Array(contract["allowed_paths"]).map { |path| "- `#{path}`" })
+  lines.concat(["", "## Allowed agents", "", *Array(contract["allowed_agents"]).map { |agent| "- `#{agent}`" }, "", "## Checkers", "", *Array(contract["checker_ids"]).map { |checker| "- `#{checker}`" }, "", "## Allowed tools", "", *Array(contract["allowed_tools"]).map { |tool| "- `#{tool}`" }, ""])
+  lines.join("\n")
+end
+
 root = Dir.pwd
 lock = %w[create inspect].include?(command) ? DevflowControlIO.acquire_project_lock(root) : nil
 begin
@@ -92,6 +119,7 @@ begin
     raise ArgumentError, "--write is required" unless options[:write]
     destination = File.join(root, ".planning/contracts", options[:feature], "#{contract_id}.json")
     DevflowControlIO.atomic_write(destination, JSON.pretty_generate(frozen) + "\n")
+    DevflowControlIO.atomic_write(File.join(root, ".planning/execution-contract.md"), render_execution_contract_markdown(frozen) + "\n")
     audit = File.join(root, ".planning/contracts", options[:feature], "control-events.jsonl")
     existing = File.exist?(audit) ? File.read(audit) : ""
     DevflowControlIO.atomic_write(audit, existing + JSON.generate({ "event" => "execution_contract_frozen", "contract_id" => contract_id, "state_revision" => state["revision"], "graph_revision" => graph["revision"], "frozen_hash" => frozen["frozen_hash"] }) + "\n")

package/plugins/devflow-core/skills/workflow-orchestrator/scripts/inspect_state.rb

@@ -212,6 +212,10 @@ def track_boundary(state, pending_ids, completed_ids)
 end
 
 def active_parallel_window(workflow, state, root, step_by_id, completed_ids, pending_ids, artifact_by_path)
+  # A failed/unsupported parallel dispatch may be explicitly converted to the
+  # declared serial fallback. Keep the join topology in the workflow, but do
+  # not re-enter the same parallel window on every inspection.
+  return nil if state["parallel_execution_mode"].to_s == "serial_fallback"
   Array(workflow["parallel_windows"]).each do |window|
     after_step = window["after_step"]
     branch_map = window["branches"].is_a?(Hash) ? window["branches"] : {}

package/plugins/devflow-core/skills/workflow-orchestrator/scripts/parallel_run.rb

@@ -206,7 +206,7 @@ if $PROGRAM_NAME == __FILE__
   begin
   options = { action: nil, feature: nil, state_revision: nil, run_revision: nil, branch_id: nil, status: nil, workflow_window: nil, branches: [], state_path: ".planning/STATE.md", json: false }
   OptionParser.new do |opts|
-    opts.on("--action ACTION", %w[inspect prepare update retry rebase]) { |value| options[:action] = value }
+    opts.on("--action ACTION", %w[inspect prepare update retry rebase serial-fallback]) { |value| options[:action] = value }
     opts.on("--feature FEATURE") { |value| options[:feature] = value }
     opts.on("--state-revision REV", Integer) { |value| options[:state_revision] = value }
     opts.on("--run-revision REV", Integer) { |value| options[:run_revision] = value }
@@ -214,6 +214,8 @@ if $PROGRAM_NAME == __FILE__
     opts.on("--status STATUS") { |value| options[:status] = value }
     opts.on("--workflow-window NAME") { |value| options[:workflow_window] = value }
     opts.on("--state PATH") { |value| options[:state_path] = value }
+    opts.on("--step STEP") { |value| options[:serial_step] = value }
+    opts.on("--expected-state-revision REV", Integer) { |value| options[:expected_state_revision] = value }
     opts.on("--branch STEP:TRACK", "Register a branch as workflow_step:track") do |value|
       workflow_step, track = value.split(":", 2)
       raise ArgumentError, "--branch must be WORKFLOW_STEP:TRACK" if workflow_step.to_s.empty? || track.to_s.empty?
@@ -233,7 +235,55 @@ if $PROGRAM_NAME == __FILE__
              ParallelRun.update_branch(root: Dir.pwd, feature: options[:feature], branch_id: options[:branch_id], expected_revision: options[:run_revision], status: options[:status])
            when "retry"
              ParallelRun.retry_branch(root: Dir.pwd, feature: options[:feature], branch_id: options[:branch_id], expected_revision: options[:run_revision])
-           when "rebase"
+  when "serial-fallback"
+    root = Dir.pwd
+    feature = ParallelRun.safe_feature(options[:feature])
+    lock = DevflowControlIO.acquire_project_lock(root)
+    begin
+      record = ParallelRun.load(root, feature) || raise(ArgumentError, "parallel run not found")
+      state_path, = DevflowControlIO.resolve_control_path(root, options[:state_path], :state)
+      state_text = File.read(state_path)
+      front = state_text.match(/\A---\n(.*?)\n---\n/m)&.[](1)
+      raise ArgumentError, "STATE.md has no YAML front matter" unless front
+      state = YAML.safe_load(front, permitted_classes: [], aliases: false)
+      raise ArgumentError, "STATE feature mismatch" unless state["current_feature"].to_s == feature
+      raise ArgumentError, "STATE does not reference this parallel run" unless state["parallel_run_ref"].to_s == record["run_id"].to_s
+      actual_revision = Integer(state.fetch("revision"))
+      if options[:expected_state_revision] && actual_revision != options[:expected_state_revision]
+        raise ArgumentError, "STATE revision conflict"
+      end
+      branches = Array(record["branches"])
+      raise ArgumentError, "serial fallback is only safe before any branch succeeds or runs" if branches.any? { |branch| %w[running succeeded].include?(branch["status"].to_s) }
+      workflow_path, = DevflowControlIO.resolve_control_path(root, state.fetch("workflow_config"), :workflow)
+      workflow = YAML.safe_load(File.read(workflow_path), permitted_classes: [], aliases: false)
+      policy = Array(workflow["parallel_windows"]).find { |window| window.is_a?(Hash) && window["id"].to_s == record["workflow_window"].to_s }&.dig("execution_policy", "serial_fallback_order")
+      order = Array(policy).map(&:to_s)
+      selected = options[:serial_step].to_s
+      selected = order.find do |step_id|
+        branch = branches.find { |item| item["workflow_step"].to_s == step_id }
+        branch && branch["status"].to_s == "pending"
+      end if selected.empty?
+      raise ArgumentError, "serial fallback has no pending branch" if selected.to_s.empty?
+      raise ArgumentError, "serial fallback step is not a pending branch" unless branches.any? { |branch| branch["workflow_step"].to_s == selected && branch["status"].to_s == "pending" }
+
+      state.delete("parallel_run_ref")
+      state["parallel_execution_mode"] = "serial_fallback"
+      state["current_step"] = selected
+      state["revision"] = actual_revision + 1
+      state["state_updated_at"] = Date.today.to_s
+      body = state_text.sub(/\A---\n.*?\n---\n/m, "---\n#{state.to_yaml.sub(/\A---\n/, "")}---\n")
+      DevflowControlIO.atomic_write(state_path, body)
+      record["status"] = "abandoned_serial_fallback"
+      record["abandoned_at"] = Time.now.utc.iso8601
+      record["abandon_reason"] = "no child Agent lifecycle started; converted to declared serial_fallback_order"
+      record["serial_fallback_step"] = selected
+      record["updated_at"] = Time.now.utc.iso8601
+      ParallelRun.write(root, feature, record)
+      result = { "ok" => true, "state_revision" => state["revision"], "serial_step" => selected, "run" => record }
+    ensure
+      DevflowControlIO.release_lock(lock)
+    end
+  when "rebase"
              raise ArgumentError, "--state-revision is required" if options[:state_revision].nil?
              ParallelRun.rebase_state_revision(root: Dir.pwd, feature: options[:feature], state_revision: options[:state_revision])
                .then { |run| run ? { "ok" => true, "run" => run } : { "ok" => false, "reason" => "parallel_run_not_found" } }

package/plugins/devflow-core/skills/workflow-orchestrator/scripts/validate_state.rb

@@ -175,7 +175,13 @@ unless %w[prepared claimed consumed superseded failed].include?(status)
       return nil
     end
 
-    YAML.safe_load(File.read(path), permitted_classes: [], aliases: false)
+    raw = File.read(path)
+    if code == "workflow_config"
+      WorkflowGateContract.duplicate_yaml_keys(raw).each do |key_path|
+        issues << issue("error", "duplicate_workflow_yaml_key", "Workflow contains a duplicate YAML mapping key", path: key_path)
+      end
+    end
+    YAML.safe_load(raw, permitted_classes: [], aliases: false)
   rescue Psych::SyntaxError => e
     issues << issue("error", "invalid_#{code}", e.message, path: path)
     nil

package/plugins/devflow-core/skills/workflow-orchestrator/scripts/workflow_gate_contract.rb

@@ -14,6 +14,31 @@ module WorkflowGateContract
 
   module_function
 
+  # Psych silently keeps the last value for duplicate mapping keys. Detect
+  # duplicates before loading a workflow so a checker declaration can never be
+  # overwritten without a gate failure.
+  def duplicate_yaml_keys(yaml)
+    duplicates = []
+    walk = lambda do |node, path|
+      return unless node
+      if node.is_a?(Psych::Nodes::Mapping)
+        seen = {}
+        children = node.children
+        children.each_slice(2) do |key_node, value_node|
+          key = key_node.respond_to?(:value) ? key_node.value.to_s : key_node.to_s
+          key_path = path.empty? ? key : "#{path}.#{key}"
+          duplicates << key_path if seen.key?(key)
+          seen[key] = true
+          walk.call(value_node, key_path)
+        end
+      elsif node.respond_to?(:children)
+        Array(node.children).each { |child| walk.call(child, path) }
+      end
+    end
+    Psych.parse_stream(yaml).children.each { |document| walk.call(document.root, "") }
+    duplicates.uniq
+  end
+
   def validate(workflow)
     errors = []
     unless workflow.is_a?(Hash)
@@ -139,7 +164,11 @@ if $PROGRAM_NAME == __FILE__
     opts.on("--json") { options[:json] = true }
   end.parse!
   raise ArgumentError, "--workflow is required" unless options[:workflow]
-  result = WorkflowGateContract.validate(YAML.safe_load(File.read(options[:workflow]), permitted_classes: [], aliases: false))
+  raw = File.read(options[:workflow])
+  duplicate_errors = WorkflowGateContract.duplicate_yaml_keys(raw).map do |path|
+    WorkflowGateContract.error("DUPLICATE_YAML_KEY", "workflow contains a duplicate YAML mapping key", path: path)
+  end
+  result = duplicate_errors + WorkflowGateContract.validate(YAML.safe_load(raw, permitted_classes: [], aliases: false))
   puts(options[:json] ? JSON.generate(result) : YAML.dump(result))
   rescue StandardError => e
     warn e.message

package/plugins/devflow-core/skills/workflow-orchestrator/templates/feature-development.yaml

@@ -70,10 +70,7 @@ governance:
       - api-test-matrix-check
       - test-coverage-check
       - acceptance-test-results-check
-      - change-impact-check
-    run-acceptance-tests:
       - acceptance-coverage-check
-      - acceptance-test-results-check
       - change-impact-check
 
 artifact_registry:

package/src/constants.ts

@@ -1,5 +1,5 @@
 export const PRODUCT_NAME = "Devflow Pi";
-export const PRODUCT_VERSION = "0.1.83";
+export const PRODUCT_VERSION = "0.1.86";
 export const PROJECT_SCHEMA_VERSION = 1;
 export const OMP_RUNTIME_VERSION = "17.2.7";