@guanlin4924/devflow-pi 0.1.20 → 0.1.21

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@guanlin4924/devflow-pi",
-  "version": "0.1.20",
+  "version": "0.1.21",
   "type": "module",
   "description": "Devflow 专项研发 Pi，基于固定版本 OMP Runtime 组装研发状态机、代码智能、设计、实现与质量门禁。",
   "license": "UNLICENSED",

package/plugins/devflow-core/extensions/devflow-core.ts

@@ -512,12 +512,21 @@ function assertRuntimeProjectBoundary(cwd: string): void {
       if (!canonical.startsWith(`${resolvedCwd}${path.sep}`)) {
         throw new Error(`Devflow control path escapes project boundary: ${canonical}`);
       }
+      if (lstatSync(target).isDirectory()) assertNoSymlinkDescendantsSync(target);
     } catch (error) {
       if ((error as NodeJS.ErrnoException).code !== "ENOENT") throw error;
     }
   }
 }
 
+function assertNoSymlinkDescendantsSync(target: string): void {
+  for (const entry of readdirSync(target, { withFileTypes: true })) {
+    const child = path.join(target, entry.name);
+    if (entry.isSymbolicLink()) throw new Error(`Refusing symlinked Devflow control path: ${child}`);
+    if (entry.isDirectory()) assertNoSymlinkDescendantsSync(child);
+  }
+}
+
 function safeControlPath(cwd: string, raw: string | undefined, kind: "state" | "workflow"): string | undefined {
   if (raw === undefined) return undefined;
   if (path.isAbsolute(raw)) throw new Error(`${kind} path must be project-relative`);
@@ -2271,7 +2280,7 @@ export default function devflowCore(pi: ExtensionAPI) {
   pi.registerTool({
     name: "devflow_skill_script",
     label: "Devflow Skill Script",
-    description: "Run an allowlisted deterministic script bundled with a Devflow skill without relying on a .skills filesystem path.",
+    description: "Run an allowlisted deterministic script bundled with a Devflow skill. project-context-validate is a final initialization gate: call it only after all manifest outputs and current-run markers are written.",
     parameters: z.object({
       script: z.enum([
         "project-context-validate",

package/plugins/devflow-core/skills/workflow-project-context/SKILL.md

@@ -72,6 +72,18 @@ This skill combines three patterns:
 
 Load bundled resources only when needed:
 
+**Internal resource URL rule (mandatory):** `skill://` URLs identify one exact
+resource. Never pass a `skill://` URL to Glob or Grep and never append `*`,
+`**`, or other wildcard syntax to it. First choose a concrete template name
+from the inventory below, then use Read with the complete URL. A generated
+project file such as `.context/spec/frontend/index.md` is an output and is not
+the same thing as a source template under `assets/`.
+
+Available depth templates:
+
+- frontend: `api-client`, `case-editor`, `components`, `directory-structure`, `forms`, `routing`, `state`, `testing`
+- backend: `directory-structure`, `engine`, `errors`, `locator`, `model`, `repository`, `router`, `scheduler`, `schema`, `service`, `testing`
+
 - Read `assets/project-initialization-template.md` before writing `PROJECT.md`.
 - Read `assets/codebase-navigation-template.md` before writing each codebase navigation file.
 - Read `assets/navigation-index-template.md` before writing `.planning/navigation/INDEX.md`.
@@ -806,6 +818,11 @@ Check:
 - `STATE.md` includes completion statuses and next action for each codebase.
 - Generated files include an initialization quality summary.
 
+Run **only after every manifest-declared output has been written and all four
+current-run status markers have been added**. This is a final gate, not a
+planning or progress check. Do not call it while the preceding steps are still
+describing or planning file updates.
+
 Run:
 
 ```text

package/src/constants.ts

@@ -1,5 +1,5 @@
 export const PRODUCT_NAME = "Devflow Pi";
-export const PRODUCT_VERSION = "0.1.0";
+export const PRODUCT_VERSION = "0.1.21";
 export const PROJECT_SCHEMA_VERSION = 1;
 export const OMP_RUNTIME_VERSION = "17.2.7";
 

package/src/doctor.ts

@@ -48,8 +48,12 @@ export async function runHostDoctor(project: ProjectContext): Promise<HostDoctor
   const sdkManifest = ompSdkManifestPath();
   let installedVersion = "missing";
   if (await exists(sdkManifest)) {
-    const parsed = JSON.parse(await readFile(sdkManifest, "utf8")) as { version?: string };
-    installedVersion = parsed.version || "unknown";
+    try {
+      const parsed = JSON.parse(await readFile(sdkManifest, "utf8")) as { version?: unknown };
+      installedVersion = typeof parsed.version === "string" && parsed.version ? parsed.version : "unknown";
+    } catch {
+      installedVersion = "invalid manifest";
+    }
   }
   add("omp-sdk", installedVersion === OMP_RUNTIME_VERSION, installedVersion);
   add("agent-dir", true, devflowAgentDir());

package/src/project-context.ts

@@ -1,5 +1,5 @@
 import { randomUUID } from "node:crypto";
-import { access, lstat, mkdir, readFile, realpath, rename, writeFile } from "node:fs/promises";
+import { access, lstat, mkdir, readFile, realpath, readdir, rename, writeFile } from "node:fs/promises";
 import path from "node:path";
 
 import { PROJECT_SCHEMA_VERSION } from "./constants.ts";
@@ -26,6 +26,15 @@ const CONTROL_BOUNDARY_PATHS = [
   ".planning/artifacts",
 ];
 
+async function assertNoSymlinkDescendants(target: string): Promise<void> {
+  const entries = await readdir(target, { withFileTypes: true }).catch(() => []);
+  for (const entry of entries) {
+    const child = path.join(target, entry.name);
+    if (entry.isSymbolicLink()) throw new Error(`Refusing symlinked Devflow control path: ${child}`);
+    if (entry.isDirectory()) await assertNoSymlinkDescendants(child);
+  }
+}
+
 async function exists(target: string): Promise<boolean> {
   try {
     await access(target);
@@ -112,6 +121,7 @@ export async function assertPlanningBoundary(root: string): Promise<string> {
       if (!canonicalTarget.startsWith(`${canonicalRoot}${path.sep}`)) {
         throw new Error(`Devflow control path escapes project boundary: ${canonicalTarget}`);
       }
+      if (targetStat.isDirectory()) await assertNoSymlinkDescendants(target);
     }
   }
   return planningRoot;

package/src/runtime.ts

@@ -16,6 +16,12 @@ export interface RuntimeOptions {
   approvalMode?: "write" | "yolo";
 }
 
+const TOOL_CALL_SAFETY_PROMPT = `Devflow tool-call rules:
+- Read always requires a non-empty string path; never call Read with {} or omit path.
+- skill:// URLs identify one exact packaged resource. Never use Glob or Grep with a skill:// URL or wildcard; choose an exact resource and use Read.
+- A generated project path such as .context/spec/frontend/index.md is not automatically a packaged skill template path.
+- The project-context validator is a final gate. Do not run project-context-validate while files are still being planned or written.`;
+
 const MANAGED_SETTINGS: Record<string, unknown> = {
   modelRoleStorage: "user",
   disabledProviders: ["claude", "codex", "cursor", "gemini", "github", "opencode"],
@@ -135,6 +141,7 @@ export async function createEmbeddedRuntime(project: ProjectContext, options: Ru
     hasUI: options.hasUI ?? true,
     enableMCP: options.enableMCP ?? false,
     enableLsp: options.enableLsp ?? true,
+    appendSystemPrompt: TOOL_CALL_SAFETY_PROMPT,
   });
   return { omp, runtime, sessionDir };
 }

package/src/usage-stats.ts

@@ -153,13 +153,11 @@ export async function aggregateUsageReport(
   const perSession: Record<string, UsageTotals> = {};
   const perSkill: Record<string, UsageTotals> = {};
   const files = await jsonlFiles(sessionRoot);
-  totals.sessionFiles = files.length;
 
   for (const file of files) {
     const session = sessionLabel(sessionRoot, file);
     if (range.session && range.session !== "all" && range.session !== session) continue;
-    const sessionTotals = (perSession[session] ??= emptyUsage());
-    sessionTotals.sessionFiles = 1;
+    let sessionTotals: UsageTotals | undefined;
     let currentModel = "unknown";
     const content = await readFile(file, "utf8").catch(() => "");
     for (const line of content.split("\n")) {
@@ -181,6 +179,8 @@ export async function aggregateUsageReport(
       if (!usage) continue;
       const model = currentModel;
       if (range.models?.length && !range.models.includes(model)) continue;
+      sessionTotals ??= (perSession[session] ??= { ...emptyUsage(), sessionFiles: 1 });
+      totals.sessionFiles = Math.max(totals.sessionFiles, Object.keys(perSession).length);
       const modelTotals = (perModel[model] ??= emptyUsage());
       addUsage(totals, usage);
       addUsage(sessionTotals, usage);