@guanghechen/observable 6.0.1 → 6.0.3

package/CHANGELOG.md

@@ -3,6 +3,37 @@
 All notable changes to this project will be documented in this file. See
 [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [6.0.3](https://github.com/guanghechen/sora/compare/@guanghechen/observable@6.0.2...@guanghechen/observable@6.0.3) (2024-03-10)
+
+### Performance Improvements
+
+- 🎨 add @guanghechen/monitor back
+  ([4c75f05](https://github.com/guanghechen/sora/commit/4c75f05441f57eb2428c086aea20c733f4a730c5))
+- 🎨 format codes
+  ([a953c67](https://github.com/guanghechen/sora/commit/a953c67ba19389b6b14bc829361d9ca406c24059))
+
+# Change Log
+
+All notable changes to this project will be documented in this file. See
+[Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+
+## [6.0.2](https://github.com/guanghechen/sora/compare/@guanghechen/observable@6.0.1...@guanghechen/observable@6.0.2) (2024-03-09)
+
+### Bug Fixes
+
+- 🐛 notify current value to subscriber even the observable has been disposed
+  ([235d145](https://github.com/guanghechen/sora/commit/235d145c7f159f66a4a1f407e7156e601d85f1e4))
+
+### Performance Improvements
+
+- :art: format codes
+  ([177eb54](https://github.com/guanghechen/sora/commit/177eb5407fe9209269541a327d42084901a63090))
+
+# Change Log
+
+All notable changes to this project will be documented in this file. See
+[Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+
 ## 6.0.1 (2024-03-09)
 
 ### Performance Improvements

package/lib/cjs/index.cjs

@@ -52,8 +52,11 @@ class Observable extends disposable.BatchDisposable {
                 continue;
             batcher.run(() => item.subscriber.dispose());
         }
+        for (const item of this._subscribers)
+            item.inactive = true;
         this._subscribers.length = 0;
-        batcher.summary();
+        batcher.summary('[observable] Encountered errors while disposing.');
+        batcher.cleanup();
     }
     getSnapshot() {
         return this._value;
@@ -76,12 +79,13 @@ class Observable extends disposable.BatchDisposable {
     subscribe(subscriber) {
         if (subscriber.disposed)
             return noopUnsubscribable;
+        const prevValue = this._lastNotifiedValue;
+        const value = this._value;
         if (this.disposed) {
+            subscriber.next(value, prevValue);
             subscriber.dispose();
             return noopUnsubscribable;
         }
-        const prevValue = this._lastNotifiedValue;
-        const value = this._value;
         this._flush();
         const item = { subscriber, inactive: false };
         this._subscribers.push(item);
@@ -134,7 +138,8 @@ class Observable extends disposable.BatchDisposable {
                 continue;
             batcher.run(() => subscriber.subscriber.next(value, prevValue));
         }
-        batcher.summary();
+        batcher.summary('[observable] Encountered errors while notifying subscribers.');
+        batcher.cleanup();
     }
 }
 
@@ -181,13 +186,12 @@ class Ticker extends Observable {
         }
         if (observable.disposed)
             return noopUnobservable;
-        const subscriber = new Subscriber({
-            onNext: () => this.tick(),
-            onDispose: () => unsubscribable.unsubscribe(),
-        });
+        const subscriber = new Subscriber({ onNext: () => this.tick() });
         const unsubscribable = observable.subscribe(subscriber);
+        const disposable$1 = new disposable.Disposable(() => unsubscribable.unsubscribe());
         this.registerDisposable(subscriber);
-        return { unobserve: () => unsubscribable.unsubscribe() };
+        this.registerDisposable(disposable$1);
+        return { unobserve: () => disposable$1.dispose() };
     }
 }
 

package/lib/esm/index.mjs

@@ -1,4 +1,4 @@
-import { BatchDisposable, SafeBatchHandler } from '@guanghechen/disposable';
+import { BatchDisposable, SafeBatchHandler, Disposable } from '@guanghechen/disposable';
 export * from '@guanghechen/observable.types';
 
 const noop = (..._args) => { };
@@ -50,8 +50,11 @@ class Observable extends BatchDisposable {
                 continue;
             batcher.run(() => item.subscriber.dispose());
         }
+        for (const item of this._subscribers)
+            item.inactive = true;
         this._subscribers.length = 0;
-        batcher.summary();
+        batcher.summary('[observable] Encountered errors while disposing.');
+        batcher.cleanup();
     }
     getSnapshot() {
         return this._value;
@@ -74,12 +77,13 @@ class Observable extends BatchDisposable {
     subscribe(subscriber) {
         if (subscriber.disposed)
             return noopUnsubscribable;
+        const prevValue = this._lastNotifiedValue;
+        const value = this._value;
         if (this.disposed) {
+            subscriber.next(value, prevValue);
             subscriber.dispose();
             return noopUnsubscribable;
         }
-        const prevValue = this._lastNotifiedValue;
-        const value = this._value;
         this._flush();
         const item = { subscriber, inactive: false };
         this._subscribers.push(item);
@@ -132,7 +136,8 @@ class Observable extends BatchDisposable {
                 continue;
             batcher.run(() => subscriber.subscriber.next(value, prevValue));
         }
-        batcher.summary();
+        batcher.summary('[observable] Encountered errors while notifying subscribers.');
+        batcher.cleanup();
     }
 }
 
@@ -179,13 +184,12 @@ class Ticker extends Observable {
         }
         if (observable.disposed)
             return noopUnobservable;
-        const subscriber = new Subscriber({
-            onNext: () => this.tick(),
-            onDispose: () => unsubscribable.unsubscribe(),
-        });
+        const subscriber = new Subscriber({ onNext: () => this.tick() });
         const unsubscribable = observable.subscribe(subscriber);
+        const disposable = new Disposable(() => unsubscribable.unsubscribe());
         this.registerDisposable(subscriber);
-        return { unobserve: () => unsubscribable.unsubscribe() };
+        this.registerDisposable(disposable);
+        return { unobserve: () => disposable.dispose() };
     }
 }
 

package/package.json

@@ -1,16 +1,16 @@
 {
   "name": "@guanghechen/observable",
-  "version": "6.0.1",
+  "version": "6.0.3",
   "author": {
     "name": "guanghechen",
     "url": "https://github.com/guanghechen/"
   },
   "repository": {
     "type": "git",
-    "url": "https://github.com/guanghechen/sora/tree/@guanghechen/observable@6.0.0",
+    "url": "https://github.com/guanghechen/sora/tree/@guanghechen/observable@6.0.2",
     "directory": "packages/observable"
   },
-  "homepage": "https://github.com/guanghechen/sora/tree/@guanghechen/observable@6.0.0/packages/observable#readme",
+  "homepage": "https://github.com/guanghechen/sora/tree/@guanghechen/observable@6.0.2/packages/observable#readme",
   "keywords": [
     "observable"
   ],
@@ -34,9 +34,9 @@
     "README.md"
   ],
   "dependencies": {
-    "@guanghechen/disposable": "^1.0.0-alpha.3",
+    "@guanghechen/disposable": "^1.0.0-alpha.4",
     "@guanghechen/error.types": "^1.0.1",
     "@guanghechen/observable.types": "^6.0.1"
   },
-  "gitHead": "8f4595ed8e3b21ac509a16aeb52cbb686636d9f0"
+  "gitHead": "edc5a1b997fac81f96f1ba03200a13b829b3e91d"
 }