@guanghechen/commander 3.2.0 → 3.3.0

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Change Log
 
+## 3.3.0
+
+### Minor Changes
+
+- Apply code review fixes:
+  - Fix `#getCommandPath` to return full command path (e.g., "cli sub" instead of just "sub")
+  - Remove unused `#parseLongOption` and `#parseShortOption` dead code
+  - Improve `--no-{option}` help description to "Negate --{option}"
+  - Document short option negative value limitation in spec
+
 ## 3.2.0
 
 ### Minor Changes

package/README.md

@@ -124,7 +124,6 @@ const root = new Command({
 })
 
 const clone = new Command({
-  name: 'clone',
   description: 'Clone a repository',
 })
   .argument({ name: 'url', kind: 'required', description: 'Repository URL' })
@@ -134,8 +133,6 @@ const clone = new Command({
   })
 
 const commit = new Command({
-  name: 'commit',
-  aliases: ['ci'],
   description: 'Record changes to the repository',
 })
   .option({ long: 'message', short: 'm', type: 'string', required: true, description: 'Commit message' })
@@ -144,7 +141,7 @@ const commit = new Command({
     console.log(`Committing: ${opts['message']}`)
   })
 
-root.subcommand(clone).subcommand(commit)
+root.subcommand('clone', clone).subcommand('commit', commit).subcommand('ci', commit)
 
 root.run({ argv: process.argv.slice(2), envs: process.env })
 ```
@@ -161,7 +158,7 @@ const root = new Command({
 })
 
 // Add completion subcommand
-root.subcommand(new CompletionCommand(root))
+root.subcommand('completion', new CompletionCommand(root))
 
 // Generate completion scripts:
 // mycli completion --bash > ~/.local/share/bash-completion/completions/mycli

package/lib/cjs/index.cjs

@@ -68,6 +68,8 @@ class Command {
     #description;
     #version;
     #helpSubcommandEnabled;
+    #reporter;
+    #parent;
     #options = [];
     #arguments = [];
     #subcommands = [];
@@ -77,6 +79,7 @@ class Command {
         this.#description = config.description;
         this.#version = config.version;
         this.#helpSubcommandEnabled = config.help ?? false;
+        this.#reporter = config.reporter;
     }
     get name() {
         return this.#name;
@@ -87,6 +90,9 @@ class Command {
     get version() {
         return this.#version;
     }
+    get parent() {
+        return this.#parent;
+    }
     get options() {
         return [...this.#options];
     }
@@ -112,12 +118,16 @@ class Command {
         if (this.#helpSubcommandEnabled && name === 'help') {
             throw new CommanderError('ConfigurationError', '"help" is a reserved subcommand name when help subcommand is enabled', this.#getCommandPath());
         }
+        if (cmd.#parent && cmd.#parent !== this) {
+            throw new CommanderError('ConfigurationError', `command "${cmd.#name}" already has a parent`, this.#getCommandPath());
+        }
         const existing = this.#subcommands.find(e => e.command === cmd);
         if (existing) {
             existing.aliases.push(name);
         }
         else {
             cmd.#name = name;
+            cmd.#parent = this;
             this.#subcommands.push({ name, aliases: [], command: cmd });
         }
         return this;
@@ -128,28 +138,34 @@ class Command {
             const processedArgv = this.#processHelpSubcommand(argv);
             const { chain, remaining } = this.#routeChain(processedArgv);
             const leafCommand = chain[chain.length - 1];
+            const rootCommand = chain[0];
+            const includeRootVersion = chain.length === 1;
+            this.#validateMergedShortOptions(chain, includeRootVersion);
             const { optionTokens, restArgs } = this.#splitAtDoubleDash(remaining);
-            const leafOptions = leafCommand.#getMergedOptions();
+            const leafOptions = leafCommand.#getMergedOptions(leafCommand === rootCommand);
             const hasUserHelp = leafCommand.#options.some(o => o.long === 'help');
             const hasUserVersion = leafCommand.#options.some(o => o.long === 'version');
             if (!hasUserHelp && leafCommand.#hasHelpFlag(optionTokens, leafOptions)) {
                 console.log(leafCommand.formatHelp());
                 return;
             }
-            if (!hasUserVersion && leafCommand.#hasVersionFlag(optionTokens, leafOptions)) {
-                console.log(leafCommand.version ?? 'unknown');
-                return;
+            if (!hasUserVersion && leafCommand === rootCommand) {
+                if (leafCommand.#hasVersionFlag(optionTokens, leafOptions)) {
+                    console.log(leafCommand.version ?? 'unknown');
+                    return;
+                }
             }
-            const optsMap = this.#shiftChain(chain, optionTokens);
+            const { optsMap, positionalArgs } = this.#shiftChain(chain, optionTokens, includeRootVersion);
             const ctx = {
                 cmd: leafCommand,
                 envs,
-                reporter: reporter ?? new DefaultReporter(),
+                reporter: reporter ?? this.#reporter ?? new DefaultReporter(),
                 argv,
             };
             this.#applyChain(chain, optsMap, ctx);
             const mergedOpts = this.#mergeOpts(chain, optsMap);
-            const { args, rawArgs } = leafCommand.#parseArguments(restArgs);
+            const allArgs = [...positionalArgs, ...restArgs];
+            const { args, rawArgs } = leafCommand.#parseArguments(allArgs);
             const actionParams = { ctx, opts: mergedOpts, args, rawArgs };
             if (leafCommand.#action) {
                 try {
@@ -182,72 +198,23 @@ class Command {
         }
     }
     parse(argv) {
-        const allOptions = this.#getMergedOptions();
-        const opts = {};
-        const rawArgs = [];
-        for (const opt of allOptions) {
-            if (opt.default !== undefined) {
-                opts[opt.long] = opt.default;
-            }
-            else if (opt.type === 'boolean') {
-                opts[opt.long] = false;
-            }
-            else if (opt.type === 'string[]' || opt.type === 'number[]') {
-                opts[opt.long] = [];
-            }
-        }
-        let remaining = [...argv];
-        const resolverOptions = allOptions.filter(o => o.resolver);
-        for (const opt of resolverOptions) {
-            const result = opt.resolver(remaining);
-            opts[opt.long] = result.value;
-            remaining = result.remaining;
-        }
-        const { optionByLong, optionByShort, booleanOptions } = this.#buildOptionMaps(allOptions, true);
-        remaining = this.#normalizeArgv(remaining, booleanOptions);
-        let i = 0;
-        while (i < remaining.length) {
-            const token = remaining[i];
-            if (token === '--') {
-                rawArgs.push(...remaining.slice(i + 1));
-                break;
-            }
-            if (token.startsWith('--')) {
-                i = this.#parseLongOption(remaining, i, optionByLong, opts);
-                continue;
-            }
-            if (token.startsWith('-') && token.length > 1) {
-                i = this.#parseShortOption(remaining, i, optionByShort, opts);
-                continue;
-            }
-            rawArgs.push(token);
-            i += 1;
-        }
-        for (const opt of allOptions) {
-            if (opt.required && opts[opt.long] === undefined) {
-                throw new CommanderError('MissingRequired', `missing required option "--${opt.long}" for command "${this.#getCommandPath()}"`, this.#getCommandPath());
-            }
-        }
-        for (const opt of allOptions) {
-            if (opt.choices && opts[opt.long] !== undefined) {
-                const value = opts[opt.long];
-                const values = Array.isArray(value) ? value : [value];
-                const choices = opt.choices;
-                for (const v of values) {
-                    if (!choices.includes(v)) {
-                        throw new CommanderError('InvalidChoice', `invalid value "${v}" for option "--${opt.long}". Allowed: ${opt.choices.join(', ')}`, this.#getCommandPath());
-                    }
-                }
-            }
-        }
-        const { args } = this.#parseArguments(rawArgs);
-        return { opts, args, rawArgs };
+        const processedArgv = this.#processHelpSubcommand(argv);
+        const { chain, remaining } = this.#routeChain(processedArgv);
+        const leafCommand = chain[chain.length - 1];
+        const includeRootVersion = chain.length === 1;
+        this.#validateMergedShortOptions(chain, includeRootVersion);
+        const { optionTokens, restArgs } = this.#splitAtDoubleDash(remaining);
+        const { optsMap, positionalArgs } = this.#shiftChain(chain, optionTokens, includeRootVersion);
+        const mergedOpts = this.#mergeOpts(chain, optsMap);
+        const allArgs = [...positionalArgs, ...restArgs];
+        const { args, rawArgs } = leafCommand.#parseArguments(allArgs);
+        return { opts: mergedOpts, args, rawArgs };
     }
     shift(tokens) {
         return this.#shiftWithShadowed(tokens, new Set());
     }
-    #shiftWithShadowed(tokens, shadowed) {
-        const allDirectOptions = this.#getMergedOptions();
+    #shiftWithShadowed(tokens, shadowed, includeVersion = !this.#parent) {
+        const allDirectOptions = this.#getMergedOptions(includeVersion);
         const directOptions = allDirectOptions.filter(o => !shadowed.has(o.long));
         const opts = {};
         for (const opt of directOptions) {
@@ -364,7 +331,7 @@ class Command {
                 if (effectiveType === 'boolean') {
                     optLines.push({
                         sig: `    --no-${opt.long}`,
-                        desc: opt.description,
+                        desc: `Negate --${opt.long}`,
                     });
                 }
             }
@@ -427,11 +394,11 @@ class Command {
         };
     }
     #processHelpSubcommand(argv) {
-        if (!this.#helpSubcommandEnabled || this.#subcommands.length === 0)
+        if (!this.#helpSubcommandEnabled)
             return argv;
         if (argv.length < 1 || argv[0] !== 'help')
             return argv;
-        if (argv.length === 1) {
+        if (argv.length === 1 || this.#subcommands.length === 0) {
             return ['--help'];
         }
         const subName = argv[1];
@@ -468,30 +435,34 @@ class Command {
             restArgs: tokens.slice(ddIdx + 1),
         };
     }
-    #shiftChain(chain, tokens) {
+    #shiftChain(chain, tokens, includeRootVersion) {
         const optsMap = new Map();
         let remaining = [...tokens];
+        const rootCommand = chain[0];
         const shadowed = new Set();
         for (let i = chain.length - 1; i >= 0; i--) {
             const cmd = chain[i];
-            const result = cmd.#shiftWithShadowed(remaining, shadowed);
+            const includeVersion = cmd === rootCommand && includeRootVersion;
+            const result = cmd.#shiftWithShadowed(remaining, shadowed, includeVersion);
             optsMap.set(cmd, result.opts);
             remaining = result.remaining;
             for (const opt of cmd.#options) {
                 shadowed.add(opt.long);
             }
         }
-        if (remaining.length > 0) {
-            const leafCommand = chain[chain.length - 1];
-            const firstToken = remaining[0];
-            if (firstToken.startsWith('-')) {
-                throw new CommanderError('UnknownOption', `unknown option "${firstToken}" for command "${leafCommand.#getCommandPath()}"`, leafCommand.#getCommandPath());
-            }
-            else {
-                throw new CommanderError('UnexpectedArgument', `unexpected argument "${firstToken}". Positional arguments must come after "--"`, leafCommand.#getCommandPath());
+        const positionalArgs = [];
+        for (const token of remaining) {
+            if (token.startsWith('-')) {
+                const leafCommand = chain[chain.length - 1];
+                if (!token.startsWith('--') && token.length > 2) {
+                    const flag = token[1];
+                    throw new CommanderError('UnknownOption', `unknown option "-${flag}" for command "${leafCommand.#getCommandPath()}"`, leafCommand.#getCommandPath());
+                }
+                throw new CommanderError('UnknownOption', `unknown option "${token}" for command "${leafCommand.#getCommandPath()}"`, leafCommand.#getCommandPath());
             }
+            positionalArgs.push(token);
         }
-        return optsMap;
+        return { optsMap, positionalArgs };
     }
     #applyChain(chain, optsMap, ctx) {
         for (const cmd of chain) {
@@ -510,82 +481,6 @@ class Command {
         }
         return merged;
     }
-    #parseLongOption(argv, idx, optionByLong, opts) {
-        const token = argv[idx];
-        const eqIdx = token.indexOf('=');
-        let optName;
-        let inlineValue;
-        if (eqIdx !== -1) {
-            optName = token.slice(2, eqIdx);
-            inlineValue = token.slice(eqIdx + 1);
-        }
-        else {
-            optName = token.slice(2);
-        }
-        const opt = optionByLong.get(optName);
-        if (!opt) {
-            throw new CommanderError('UnknownOption', `unknown option "--${optName}" for command "${this.#getCommandPath()}"`, this.#getCommandPath());
-        }
-        if (opt.type === 'boolean') {
-            if (inlineValue !== undefined) {
-                if (inlineValue === 'true') {
-                    opts[optName] = true;
-                }
-                else if (inlineValue === 'false') {
-                    opts[optName] = false;
-                }
-                else {
-                    throw new CommanderError('InvalidBooleanValue', `invalid value "${inlineValue}" for boolean option "--${optName}". Use "true" or "false"`, this.#getCommandPath());
-                }
-            }
-            else {
-                opts[optName] = true;
-            }
-            return idx + 1;
-        }
-        let value;
-        let nextIdx = idx;
-        if (inlineValue !== undefined) {
-            value = inlineValue;
-        }
-        else if (idx + 1 < argv.length) {
-            value = argv[idx + 1];
-            nextIdx += 1;
-        }
-        else {
-            throw new CommanderError('MissingValue', `option "--${optName}" requires a value`, this.#getCommandPath());
-        }
-        this.#applyValue(opt, value, opts);
-        return nextIdx + 1;
-    }
-    #parseShortOption(argv, idx, optionByShort, opts) {
-        const token = argv[idx];
-        if (token.includes('=')) {
-            throw new CommanderError('UnsupportedShortSyntax', `"-${token.slice(1)}" is not supported. Use "-${token[1]} ${token.slice(3)}" instead`, this.#getCommandPath());
-        }
-        const flags = token.slice(1);
-        for (let j = 0; j < flags.length; j++) {
-            const flag = flags[j];
-            const opt = optionByShort.get(flag);
-            if (!opt) {
-                throw new CommanderError('UnknownOption', `unknown option "-${flag}" for command "${this.#getCommandPath()}"`, this.#getCommandPath());
-            }
-            if (opt.type === 'boolean') {
-                opts[opt.long] = true;
-                continue;
-            }
-            if (j < flags.length - 1) {
-                throw new CommanderError('UnsupportedShortSyntax', `"-${flags}" is not supported. Use "-${flags.slice(0, j + 1)} ${flags.slice(j + 1)}" or separate options`, this.#getCommandPath());
-            }
-            if (idx + 1 < argv.length && !argv[idx + 1].startsWith('-')) {
-                const value = argv[idx + 1];
-                this.#applyValue(opt, value, opts);
-                return idx + 2;
-            }
-            throw new CommanderError('MissingValue', `option "-${flag}" requires a value`, this.#getCommandPath());
-        }
-        return idx + 1;
-    }
     #applyValue(opt, rawValue, opts) {
         const type = opt.type ?? 'string';
         let parsedValue = rawValue;
@@ -618,14 +513,14 @@ class Command {
             opts[opt.long] = parsedValue;
         }
     }
-    #getMergedOptions() {
+    #getMergedOptions(includeVersion = !this.#parent) {
         const optionMap = new Map();
         const hasUserHelp = this.#options.some(o => o.long === 'help');
         const hasUserVersion = this.#options.some(o => o.long === 'version');
         if (!hasUserHelp) {
             optionMap.set('help', BUILTIN_HELP_OPTION);
         }
-        if (!hasUserVersion) {
+        if (!hasUserVersion && includeVersion) {
             optionMap.set('version', BUILTIN_VERSION_OPTION);
         }
         for (const opt of this.#options) {
@@ -633,6 +528,26 @@ class Command {
         }
         return Array.from(optionMap.values());
     }
+    #validateMergedShortOptions(chain, includeRootVersion) {
+        const mergedByLong = new Map();
+        const rootCommand = chain[0];
+        for (const cmd of chain) {
+            const includeVersion = cmd === rootCommand && includeRootVersion;
+            for (const opt of cmd.#getMergedOptions(includeVersion)) {
+                mergedByLong.set(opt.long, opt);
+            }
+        }
+        const shortMap = new Map();
+        for (const opt of mergedByLong.values()) {
+            if (!opt.short)
+                continue;
+            const existingLong = shortMap.get(opt.short);
+            if (existingLong && existingLong !== opt.long) {
+                throw new CommanderError('OptionConflict', `short option "-${opt.short}" conflicts with "--${existingLong}"`, this.#getCommandPath());
+            }
+            shortMap.set(opt.short, opt.long);
+        }
+    }
     #validateOptionConfig(opt) {
         if (opt.long.startsWith('no-')) {
             throw new CommanderError('ConfigurationError', `option long name cannot start with "no-": "${opt.long}"`, this.#getCommandPath());
@@ -823,7 +738,15 @@ class Command {
         return result;
     }
     #getCommandPath() {
-        return this.#name;
+        const parts = [];
+        let current = this;
+        while (current) {
+            if (current.#name) {
+                parts.unshift(current.#name);
+            }
+            current = current.#parent;
+        }
+        return parts.join(' ') || this.#name;
     }
     #tryConsumeLongOption(tokens, idx, optionByLong, opts) {
         const token = tokens[idx];

package/lib/esm/index.mjs

@@ -46,6 +46,8 @@ class Command {
     #description;
     #version;
     #helpSubcommandEnabled;
+    #reporter;
+    #parent;
     #options = [];
     #arguments = [];
     #subcommands = [];
@@ -55,6 +57,7 @@ class Command {
         this.#description = config.description;
         this.#version = config.version;
         this.#helpSubcommandEnabled = config.help ?? false;
+        this.#reporter = config.reporter;
     }
     get name() {
         return this.#name;
@@ -65,6 +68,9 @@ class Command {
     get version() {
         return this.#version;
     }
+    get parent() {
+        return this.#parent;
+    }
     get options() {
         return [...this.#options];
     }
@@ -90,12 +96,16 @@ class Command {
         if (this.#helpSubcommandEnabled && name === 'help') {
             throw new CommanderError('ConfigurationError', '"help" is a reserved subcommand name when help subcommand is enabled', this.#getCommandPath());
         }
+        if (cmd.#parent && cmd.#parent !== this) {
+            throw new CommanderError('ConfigurationError', `command "${cmd.#name}" already has a parent`, this.#getCommandPath());
+        }
         const existing = this.#subcommands.find(e => e.command === cmd);
         if (existing) {
             existing.aliases.push(name);
         }
         else {
             cmd.#name = name;
+            cmd.#parent = this;
             this.#subcommands.push({ name, aliases: [], command: cmd });
         }
         return this;
@@ -106,28 +116,34 @@ class Command {
             const processedArgv = this.#processHelpSubcommand(argv);
             const { chain, remaining } = this.#routeChain(processedArgv);
             const leafCommand = chain[chain.length - 1];
+            const rootCommand = chain[0];
+            const includeRootVersion = chain.length === 1;
+            this.#validateMergedShortOptions(chain, includeRootVersion);
             const { optionTokens, restArgs } = this.#splitAtDoubleDash(remaining);
-            const leafOptions = leafCommand.#getMergedOptions();
+            const leafOptions = leafCommand.#getMergedOptions(leafCommand === rootCommand);
             const hasUserHelp = leafCommand.#options.some(o => o.long === 'help');
             const hasUserVersion = leafCommand.#options.some(o => o.long === 'version');
             if (!hasUserHelp && leafCommand.#hasHelpFlag(optionTokens, leafOptions)) {
                 console.log(leafCommand.formatHelp());
                 return;
             }
-            if (!hasUserVersion && leafCommand.#hasVersionFlag(optionTokens, leafOptions)) {
-                console.log(leafCommand.version ?? 'unknown');
-                return;
+            if (!hasUserVersion && leafCommand === rootCommand) {
+                if (leafCommand.#hasVersionFlag(optionTokens, leafOptions)) {
+                    console.log(leafCommand.version ?? 'unknown');
+                    return;
+                }
             }
-            const optsMap = this.#shiftChain(chain, optionTokens);
+            const { optsMap, positionalArgs } = this.#shiftChain(chain, optionTokens, includeRootVersion);
             const ctx = {
                 cmd: leafCommand,
                 envs,
-                reporter: reporter ?? new DefaultReporter(),
+                reporter: reporter ?? this.#reporter ?? new DefaultReporter(),
                 argv,
             };
             this.#applyChain(chain, optsMap, ctx);
             const mergedOpts = this.#mergeOpts(chain, optsMap);
-            const { args, rawArgs } = leafCommand.#parseArguments(restArgs);
+            const allArgs = [...positionalArgs, ...restArgs];
+            const { args, rawArgs } = leafCommand.#parseArguments(allArgs);
             const actionParams = { ctx, opts: mergedOpts, args, rawArgs };
             if (leafCommand.#action) {
                 try {
@@ -160,72 +176,23 @@ class Command {
         }
     }
     parse(argv) {
-        const allOptions = this.#getMergedOptions();
-        const opts = {};
-        const rawArgs = [];
-        for (const opt of allOptions) {
-            if (opt.default !== undefined) {
-                opts[opt.long] = opt.default;
-            }
-            else if (opt.type === 'boolean') {
-                opts[opt.long] = false;
-            }
-            else if (opt.type === 'string[]' || opt.type === 'number[]') {
-                opts[opt.long] = [];
-            }
-        }
-        let remaining = [...argv];
-        const resolverOptions = allOptions.filter(o => o.resolver);
-        for (const opt of resolverOptions) {
-            const result = opt.resolver(remaining);
-            opts[opt.long] = result.value;
-            remaining = result.remaining;
-        }
-        const { optionByLong, optionByShort, booleanOptions } = this.#buildOptionMaps(allOptions, true);
-        remaining = this.#normalizeArgv(remaining, booleanOptions);
-        let i = 0;
-        while (i < remaining.length) {
-            const token = remaining[i];
-            if (token === '--') {
-                rawArgs.push(...remaining.slice(i + 1));
-                break;
-            }
-            if (token.startsWith('--')) {
-                i = this.#parseLongOption(remaining, i, optionByLong, opts);
-                continue;
-            }
-            if (token.startsWith('-') && token.length > 1) {
-                i = this.#parseShortOption(remaining, i, optionByShort, opts);
-                continue;
-            }
-            rawArgs.push(token);
-            i += 1;
-        }
-        for (const opt of allOptions) {
-            if (opt.required && opts[opt.long] === undefined) {
-                throw new CommanderError('MissingRequired', `missing required option "--${opt.long}" for command "${this.#getCommandPath()}"`, this.#getCommandPath());
-            }
-        }
-        for (const opt of allOptions) {
-            if (opt.choices && opts[opt.long] !== undefined) {
-                const value = opts[opt.long];
-                const values = Array.isArray(value) ? value : [value];
-                const choices = opt.choices;
-                for (const v of values) {
-                    if (!choices.includes(v)) {
-                        throw new CommanderError('InvalidChoice', `invalid value "${v}" for option "--${opt.long}". Allowed: ${opt.choices.join(', ')}`, this.#getCommandPath());
-                    }
-                }
-            }
-        }
-        const { args } = this.#parseArguments(rawArgs);
-        return { opts, args, rawArgs };
+        const processedArgv = this.#processHelpSubcommand(argv);
+        const { chain, remaining } = this.#routeChain(processedArgv);
+        const leafCommand = chain[chain.length - 1];
+        const includeRootVersion = chain.length === 1;
+        this.#validateMergedShortOptions(chain, includeRootVersion);
+        const { optionTokens, restArgs } = this.#splitAtDoubleDash(remaining);
+        const { optsMap, positionalArgs } = this.#shiftChain(chain, optionTokens, includeRootVersion);
+        const mergedOpts = this.#mergeOpts(chain, optsMap);
+        const allArgs = [...positionalArgs, ...restArgs];
+        const { args, rawArgs } = leafCommand.#parseArguments(allArgs);
+        return { opts: mergedOpts, args, rawArgs };
     }
     shift(tokens) {
         return this.#shiftWithShadowed(tokens, new Set());
     }
-    #shiftWithShadowed(tokens, shadowed) {
-        const allDirectOptions = this.#getMergedOptions();
+    #shiftWithShadowed(tokens, shadowed, includeVersion = !this.#parent) {
+        const allDirectOptions = this.#getMergedOptions(includeVersion);
         const directOptions = allDirectOptions.filter(o => !shadowed.has(o.long));
         const opts = {};
         for (const opt of directOptions) {
@@ -342,7 +309,7 @@ class Command {
                 if (effectiveType === 'boolean') {
                     optLines.push({
                         sig: `    --no-${opt.long}`,
-                        desc: opt.description,
+                        desc: `Negate --${opt.long}`,
                     });
                 }
             }
@@ -405,11 +372,11 @@ class Command {
         };
     }
     #processHelpSubcommand(argv) {
-        if (!this.#helpSubcommandEnabled || this.#subcommands.length === 0)
+        if (!this.#helpSubcommandEnabled)
             return argv;
         if (argv.length < 1 || argv[0] !== 'help')
             return argv;
-        if (argv.length === 1) {
+        if (argv.length === 1 || this.#subcommands.length === 0) {
             return ['--help'];
         }
         const subName = argv[1];
@@ -446,30 +413,34 @@ class Command {
             restArgs: tokens.slice(ddIdx + 1),
         };
     }
-    #shiftChain(chain, tokens) {
+    #shiftChain(chain, tokens, includeRootVersion) {
         const optsMap = new Map();
         let remaining = [...tokens];
+        const rootCommand = chain[0];
         const shadowed = new Set();
         for (let i = chain.length - 1; i >= 0; i--) {
             const cmd = chain[i];
-            const result = cmd.#shiftWithShadowed(remaining, shadowed);
+            const includeVersion = cmd === rootCommand && includeRootVersion;
+            const result = cmd.#shiftWithShadowed(remaining, shadowed, includeVersion);
             optsMap.set(cmd, result.opts);
             remaining = result.remaining;
             for (const opt of cmd.#options) {
                 shadowed.add(opt.long);
             }
         }
-        if (remaining.length > 0) {
-            const leafCommand = chain[chain.length - 1];
-            const firstToken = remaining[0];
-            if (firstToken.startsWith('-')) {
-                throw new CommanderError('UnknownOption', `unknown option "${firstToken}" for command "${leafCommand.#getCommandPath()}"`, leafCommand.#getCommandPath());
-            }
-            else {
-                throw new CommanderError('UnexpectedArgument', `unexpected argument "${firstToken}". Positional arguments must come after "--"`, leafCommand.#getCommandPath());
+        const positionalArgs = [];
+        for (const token of remaining) {
+            if (token.startsWith('-')) {
+                const leafCommand = chain[chain.length - 1];
+                if (!token.startsWith('--') && token.length > 2) {
+                    const flag = token[1];
+                    throw new CommanderError('UnknownOption', `unknown option "-${flag}" for command "${leafCommand.#getCommandPath()}"`, leafCommand.#getCommandPath());
+                }
+                throw new CommanderError('UnknownOption', `unknown option "${token}" for command "${leafCommand.#getCommandPath()}"`, leafCommand.#getCommandPath());
             }
+            positionalArgs.push(token);
         }
-        return optsMap;
+        return { optsMap, positionalArgs };
     }
     #applyChain(chain, optsMap, ctx) {
         for (const cmd of chain) {
@@ -488,82 +459,6 @@ class Command {
         }
         return merged;
     }
-    #parseLongOption(argv, idx, optionByLong, opts) {
-        const token = argv[idx];
-        const eqIdx = token.indexOf('=');
-        let optName;
-        let inlineValue;
-        if (eqIdx !== -1) {
-            optName = token.slice(2, eqIdx);
-            inlineValue = token.slice(eqIdx + 1);
-        }
-        else {
-            optName = token.slice(2);
-        }
-        const opt = optionByLong.get(optName);
-        if (!opt) {
-            throw new CommanderError('UnknownOption', `unknown option "--${optName}" for command "${this.#getCommandPath()}"`, this.#getCommandPath());
-        }
-        if (opt.type === 'boolean') {
-            if (inlineValue !== undefined) {
-                if (inlineValue === 'true') {
-                    opts[optName] = true;
-                }
-                else if (inlineValue === 'false') {
-                    opts[optName] = false;
-                }
-                else {
-                    throw new CommanderError('InvalidBooleanValue', `invalid value "${inlineValue}" for boolean option "--${optName}". Use "true" or "false"`, this.#getCommandPath());
-                }
-            }
-            else {
-                opts[optName] = true;
-            }
-            return idx + 1;
-        }
-        let value;
-        let nextIdx = idx;
-        if (inlineValue !== undefined) {
-            value = inlineValue;
-        }
-        else if (idx + 1 < argv.length) {
-            value = argv[idx + 1];
-            nextIdx += 1;
-        }
-        else {
-            throw new CommanderError('MissingValue', `option "--${optName}" requires a value`, this.#getCommandPath());
-        }
-        this.#applyValue(opt, value, opts);
-        return nextIdx + 1;
-    }
-    #parseShortOption(argv, idx, optionByShort, opts) {
-        const token = argv[idx];
-        if (token.includes('=')) {
-            throw new CommanderError('UnsupportedShortSyntax', `"-${token.slice(1)}" is not supported. Use "-${token[1]} ${token.slice(3)}" instead`, this.#getCommandPath());
-        }
-        const flags = token.slice(1);
-        for (let j = 0; j < flags.length; j++) {
-            const flag = flags[j];
-            const opt = optionByShort.get(flag);
-            if (!opt) {
-                throw new CommanderError('UnknownOption', `unknown option "-${flag}" for command "${this.#getCommandPath()}"`, this.#getCommandPath());
-            }
-            if (opt.type === 'boolean') {
-                opts[opt.long] = true;
-                continue;
-            }
-            if (j < flags.length - 1) {
-                throw new CommanderError('UnsupportedShortSyntax', `"-${flags}" is not supported. Use "-${flags.slice(0, j + 1)} ${flags.slice(j + 1)}" or separate options`, this.#getCommandPath());
-            }
-            if (idx + 1 < argv.length && !argv[idx + 1].startsWith('-')) {
-                const value = argv[idx + 1];
-                this.#applyValue(opt, value, opts);
-                return idx + 2;
-            }
-            throw new CommanderError('MissingValue', `option "-${flag}" requires a value`, this.#getCommandPath());
-        }
-        return idx + 1;
-    }
     #applyValue(opt, rawValue, opts) {
         const type = opt.type ?? 'string';
         let parsedValue = rawValue;
@@ -596,14 +491,14 @@ class Command {
             opts[opt.long] = parsedValue;
         }
     }
-    #getMergedOptions() {
+    #getMergedOptions(includeVersion = !this.#parent) {
         const optionMap = new Map();
         const hasUserHelp = this.#options.some(o => o.long === 'help');
         const hasUserVersion = this.#options.some(o => o.long === 'version');
         if (!hasUserHelp) {
             optionMap.set('help', BUILTIN_HELP_OPTION);
         }
-        if (!hasUserVersion) {
+        if (!hasUserVersion && includeVersion) {
             optionMap.set('version', BUILTIN_VERSION_OPTION);
         }
         for (const opt of this.#options) {
@@ -611,6 +506,26 @@ class Command {
         }
         return Array.from(optionMap.values());
     }
+    #validateMergedShortOptions(chain, includeRootVersion) {
+        const mergedByLong = new Map();
+        const rootCommand = chain[0];
+        for (const cmd of chain) {
+            const includeVersion = cmd === rootCommand && includeRootVersion;
+            for (const opt of cmd.#getMergedOptions(includeVersion)) {
+                mergedByLong.set(opt.long, opt);
+            }
+        }
+        const shortMap = new Map();
+        for (const opt of mergedByLong.values()) {
+            if (!opt.short)
+                continue;
+            const existingLong = shortMap.get(opt.short);
+            if (existingLong && existingLong !== opt.long) {
+                throw new CommanderError('OptionConflict', `short option "-${opt.short}" conflicts with "--${existingLong}"`, this.#getCommandPath());
+            }
+            shortMap.set(opt.short, opt.long);
+        }
+    }
     #validateOptionConfig(opt) {
         if (opt.long.startsWith('no-')) {
             throw new CommanderError('ConfigurationError', `option long name cannot start with "no-": "${opt.long}"`, this.#getCommandPath());
@@ -801,7 +716,15 @@ class Command {
         return result;
     }
     #getCommandPath() {
-        return this.#name;
+        const parts = [];
+        let current = this;
+        while (current) {
+            if (current.#name) {
+                parts.unshift(current.#name);
+            }
+            current = current.#parent;
+        }
+        return parts.join(' ') || this.#name;
     }
     #tryConsumeLongOption(tokens, idx, optionByLong, opts) {
         const token = tokens[idx];

package/lib/types/index.d.ts

@@ -72,16 +72,19 @@ interface ICommandConfig {
     name?: string;
     /** Command description */
     description: string;
-    /** Version (only effective for root command) */
+    /** Version (only effective for built-in root --version) */
     version?: string;
     /** Enable built-in "help" subcommand (only effective when command has subcommands) */
     help?: boolean;
+    /** Default reporter for this command (can be overridden by run params) */
+    reporter?: IReporter;
 }
 /** Forward declaration for Command class */
 interface ICommand {
     readonly name: string;
     readonly description: string;
     readonly version: string | undefined;
+    readonly parent?: ICommand;
     readonly options: IOption[];
     readonly arguments: IArgument[];
 }
@@ -115,7 +118,7 @@ interface IRunParams {
     argv: string[];
     /** Environment variables (usually process.env) */
     envs: Record<string, string | undefined>;
-    /** Optional reporter for logging (defaults to console reporter) */
+    /** Optional reporter override (defaults to command's reporter or console reporter) */
     reporter?: IReporter;
 }
 /** parse() method result */
@@ -191,6 +194,7 @@ declare class Command implements ICommand {
     get name(): string;
     get description(): string;
     get version(): string | undefined;
+    get parent(): Command | undefined;
     get options(): IOption[];
     get arguments(): IArgument[];
     option(opt: IOption): this;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@guanghechen/commander",
-  "version": "3.2.0",
+  "version": "3.3.0",
   "description": "A minimal, type-safe command-line interface builder with fluent API",
   "author": {
     "name": "guanghechen",