@gtvmbh/eslint-config 1.0.7 → 1.1.0

package/.github/workflows/npm-publish.yml

@@ -11,20 +11,20 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
       - run: npm test
 
   publish-npm:
     needs: build
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
           registry-url: https://registry.npmjs.org
           scope: 'gtvmbh'
       - run: npm publish --access public

package/examples/.eslintrc-javascript.js

@@ -8,8 +8,7 @@ module.exports = {
     'jasmine': true
   },
   extends: [
-    '@gtvmbh/eslint-config
-    '@gtvmbh/eslint-config/eslint-config-jsdoc'
+    '@gtvmbh/eslint-config'
   ],
   ignorePatterns: [
     '.eslintrc.js'

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gtvmbh/eslint-config",
-  "version": "1.0.7",
+  "version": "1.1.0",
   "description": "ESLint configurations for various project types developed by Gesellschaft für Technische Visualistik",
   "main": "index.js",
   "scripts": {
@@ -10,6 +10,9 @@
     "type": "git",
     "url": "https://github.com/GesellschaftFuerTechnischeVisualistik/gtv-linter-config.git"
   },
+  "engines": {
+    "node": ">=16.0.0 <=18.x.x"
+  },
   "keywords": [
     "eslint",
     "eslintconfig"
@@ -17,9 +20,8 @@
   "author": "Gesellschaft für Technische Visualistik mbH",
   "license": "MIT",
   "peerDependencies": {
-    "eslint": ">=7",
-    "eslint-plugin-jsdoc": ">=30",
-    "@typescript-eslint/eslint-plugin": ">=3",
-    "@typescript-eslint/parser": ">=3"
+    "eslint": "^8.47.0",
+    "@typescript-eslint/eslint-plugin": "^6.4.1",
+    "@typescript-eslint/parser": "^6.4.1"
   }
 }

package/src/default.js

@@ -1,7 +1,6 @@
 module.exports = {
   extends: [
     'eslint:recommended',
-    '@gtvmbh/eslint-config/eslint-config-jsdoc'
   ],
   rules: {
     'no-extra-parens': ['warn', 'all', { 'nestedBinaryExpressions': false }],
@@ -55,7 +54,7 @@ module.exports = {
     'no-param-reassign': 'error',
     'no-proto': 'error',
     'no-restricted-properties': 'off',
-    'no-return-assign': ['error', 'always'],
+    'no-return-assign': ['error', 'except-parens'],
     'no-return-await': 'warn',
     'no-script-url': 'error',
     'no-self-compare': 'error',
@@ -114,7 +113,7 @@ module.exports = {
     'id-blacklist': 'off',
     'id-length': 'off',
     'id-match': 'off',
-    'implicit-arrow-linebreak': 'off',
+    'implicit-arrow-linebreak': ["error", "beside"],
     'indent': ["error", 2, { "SwitchCase": 1 }],
     'jsx-quotes': ['error', 'prefer-double'],
     'key-spacing': ['error', {
@@ -129,10 +128,10 @@ module.exports = {
     'max-depth': 'off',
     'max-len': 'off',
     'max-lines': ['warn', {
-      'max': 300, 'skipComments': true
+      'max': 400, 'skipComments': true
     }],
     'max-lines-per-function': ['warn', {
-      'max': 80
+      'max': 100
     }],
     'max-nested-callbacks': ['warn', 3],
     'max-params': ['warn', 5],

package/src/typescript.js

@@ -9,6 +9,9 @@ module.exports = {
     '@gtvmbh/eslint-config'
   ],
   rules: {
+
+    'no-shadow': 'off',
+    '@typescript-eslint/no-shadow': 'error',
     
     // Require that member overloads be consecutive
     '@typescript-eslint/adjacent-overload-signatures': 'error',
@@ -48,7 +51,7 @@ module.exports = {
     '@typescript-eslint/member-delimiter-style': 'error',
     
     // Require a consistent member declaration order
-    '@typescript-eslint/member-ordering': 'error',
+    '@typescript-eslint/member-ordering': 'warn',
     
     // Enforces using a particular method signature syntax.
     '@typescript-eslint/method-signature-style': 'warn', //anscheinend ist 'property' besser, weesschne,
@@ -132,7 +135,7 @@ module.exports = {
     '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
     
     // Prevents conditionals where the type is always truthy or always falsy
-    '@typescript-eslint/no-unnecessary-condition': 'warn',
+    '@typescript-eslint/no-unnecessary-condition': 'off',
     
     // Warns when a namespace qualifier is unnecessary
     '@typescript-eslint/no-unnecessary-qualifier': 'warn',
@@ -155,9 +158,6 @@ module.exports = {
     // Disallows returning any from a function
     '@typescript-eslint/no-unsafe-return': 'warn',
     
-    // Disallow unused variables and arguments
-    '@typescript-eslint/no-unused-vars-experimental': 'warn', // aber lieber über compiler (siehe beschreibung)?,
-    
     // Disallows the use of require statements except in import statements
     '@typescript-eslint/no-var-requires': 'error',
     
@@ -201,10 +201,10 @@ module.exports = {
     '@typescript-eslint/prefer-ts-expect-error': 'off', // cool aber TS >= 3.9,
     
     // Requires any function or method that returns a Promise to be marked async
-    '@typescript-eslint/promise-function-async': 'error',
+    '@typescript-eslint/promise-function-async': ['error', { checkArrowFunctions: false, checkFunctionExpressions: false }],
     
     // Requires Array#sort calls to always provide a compareFunction
-    '@typescript-eslint/require-array-sort-compare': 'warn',
+    '@typescript-eslint/require-array-sort-compare': ['warn', { 'ignoreStringArrays': true }],
     
     // When adding two variables, operands must both be of type number or of type string
     '@typescript-eslint/restrict-plus-operands': 'error',
@@ -228,7 +228,7 @@ module.exports = {
     '@typescript-eslint/typedef': 'off', // compiler noImplicitAny
     
     // Enforces unbound methods are called with their expected scope
-    '@typescript-eslint/unbound-method': ['error', {'ignoreStatic':true}],
+    '@typescript-eslint/unbound-method': ['warn', {'ignoreStatic': true}],
     
     // Warns for any two overloads that could be unified into one by using a union or an optional/rest parameter
     '@typescript-eslint/unified-signatures': 'warn',
@@ -290,7 +290,7 @@ module.exports = {
     
     // Disallow empty functions
     'no-empty-function': 'off',
-    '@typescript-eslint/no-empty-function': 'error',
+    '@typescript-eslint/no-empty-function': 'off',
     
     // Disallow unnecessary parentheses
     'no-extra-parens': 'off',
@@ -310,11 +310,11 @@ module.exports = {
     
     // Disallow unused expressions
     'no-unused-expressions': 'off',
-    '@typescript-eslint/no-unused-expressions': 'warn',
+    '@typescript-eslint/no-unused-expressions': ['error', { allowShortCircuit: true, allowTernary: true }],
     
     // Disallow unused variables
     'no-unused-vars': 'off',
-    '@typescript-eslint/no-unused-vars': 'warn',
+    '@typescript-eslint/no-unused-vars': 'error',
     
     // Disallow the use of variables before they are defined
     'no-use-before-define': 'off',

package/src/vidala.js

@@ -1,5 +1,5 @@
 module.exports = {
   rules: {
-    'no-restricted-imports': ['error', { 'paths': ['ViDaLa'] }]
+    'no-restricted-imports': ['error', { 'patterns': ['ViDaLa/*'] }]
   }
 };

package/eslint-config-jsdoc.js

@@ -1 +0,0 @@
-module.exports = require('./src/jsdoc');

package/src/jsdoc.js

@@ -1,8 +0,0 @@
-module.exports = {
-  plugins: [
-    'jsdoc'
-  ],
-  rules: {
-    'jsdoc/newline-after-description': 'warn'
-  }
-};