@gtkx/codegen 1.0.0-rc.1 → 1.0.0-rc.2

package/src/store/gi/record-field-accessor.ts

@@ -1,24 +1,18 @@
 import { toCamelIdentifier } from "@gtkx/utils";
-import { tStruct } from "../../analysis/descriptor.js";
-import { isInlineCallbackRef, renderDescriptor } from "../../analysis/descriptor-render.js";
-import { renderTsType } from "../../analysis/ts-type.js";
 import type { GirField } from "../../gir/field.js";
 import type { FieldSlot } from "../../gir/size.js";
-import type { GirType } from "../../gir/type.js";
 import type { TypeId } from "../../gir/type-id.js";
+import type { GirType } from "../../gir/type.js";
 import type { ModuleContext } from "../../writer/context.js";
+import { isInlineCallbackRef, renderDescriptor } from "../../analysis/descriptor-render.js";
+import { tStruct } from "../../analysis/descriptor.js";
+import { renderTsType } from "../../analysis/ts-type.js";
 import { renderJsDoc } from "../../writer/doc.js";
 import { indent, renderBlock } from "../../writer/emit.js";
-import { refIsClassStruct } from "./class-struct-record.js";
+import { isClassStructRef } from "./class-struct-record.js";
 import { bitMask, computeRecordFieldSlots, mergeBitfield, type RecordFieldSlot } from "./record-layout.js";
 import { wrapReturnValue } from "./return-wrap.js";
 
-export const isEmittableField = (context: ModuleContext, field: GirField): field is GirField & { type: TypeId } =>
-    !field.private &&
-    field.type !== undefined &&
-    !isInlineCallbackRef(context.library, field.type) &&
-    !refIsClassStruct(context, field.type);
-
 type FieldWriteSpec = {
     descriptor: string;
     slot: FieldSlot;
@@ -26,25 +20,101 @@ type FieldWriteSpec = {
     valueExpr: string;
 };
 
-export const emitFieldWrite = (context: ModuleContext, spec: FieldWriteSpec): string => {
+type AdmittedField = {
+    field: GirField & { type: TypeId };
+    jsName: string;
+};
+
+type RecordFieldEntry = {
+    jsName: string;
+    tsType: string;
+    writable: boolean;
+    doc: string | undefined;
+};
+
+type InlineFieldVisit = {
+    jsName: string;
+    descriptor: string;
+    offset: number;
+    slot: FieldSlot;
+    type: TypeId;
+};
+
+type InlineFieldVisitors = {
+    leaf: (visit: InlineFieldVisit) => void;
+    nested: (jsName: string, nested: GirField[], offset: number) => void;
+};
+
+type ElementWriteOptions = {
+    fields: GirField[];
+    baseOffset: number;
+    valuePath: string;
+    out: string[];
+};
+
+type StructArrayTarget = {
+    field: GirField;
+    jsName: string;
+    slot: FieldSlot;
+    siblingFields: GirField[];
+};
+
+type StructArrayAccessorOptions = {
+    context: ModuleContext;
+    jsName: string;
+    tsType: string;
+    elementDescriptor: string;
+    offset: number;
+    lengthExpr: string;
+    elementSize: number;
+    elementFields: GirField[];
+};
+
+type StructArrayResolution = {
+    fieldType: TypeId;
+    elementFields: GirField[];
+    lengthExpr: string;
+    elementSize: number;
+};
+
+type StructArrayElements = {
+    arrayType: Extract<GirType, { kind: "carray" }>;
+    elementFields: GirField[];
+};
+
+type AccessorOptions = {
+    context: ModuleContext;
+    jsName: string;
+    tsType: string;
+    descriptor: string;
+    slot: FieldSlot;
+    fieldType: TypeId;
+};
+
+const isEmittableField = (context: ModuleContext, field: GirField): field is GirField & { type: TypeId } =>
+    !field.private &&
+    field.type !== undefined &&
+    !isInlineCallbackRef(context.library, field.type) &&
+    !isClassStructRef(context, field.type);
+
+const emitFieldWrite = (context: ModuleContext, spec: FieldWriteSpec): string => {
     const { descriptor, slot, targetExpr, valueExpr } = spec;
     context.addRuntimeImport("write");
+
     if (slot.bitWidth === undefined) {
-        return `write(${targetExpr}, ${descriptor}, ${slot.byteOffset}, ${valueExpr});`;
+        return `write(${targetExpr}, ${descriptor}, ${String(slot.byteOffset)}, ${valueExpr});`;
     }
+
     context.addRuntimeImport("read");
+
     const merged = mergeBitfield(
-        `(read(${targetExpr}, ${descriptor}, ${slot.byteOffset}) as number)`,
+        `(read(${targetExpr}, ${descriptor}, ${String(slot.byteOffset)}) as number)`,
         valueExpr,
         bitMask(slot.bitWidth),
         slot.bitOffset ?? 0,
     );
-    return `write(${targetExpr}, ${descriptor}, ${slot.byteOffset}, ${merged});`;
-};
 
-type AdmittedField = {
-    field: GirField & { type: TypeId };
-    jsName: string;
+    return `write(${targetExpr}, ${descriptor}, ${String(slot.byteOffset)}, ${merged});`;
 };
 
 const admitField = (
@@ -53,28 +123,39 @@ const admitField = (
     claimedNames: Set<string>,
 ): AdmittedField | undefined => {
     const { field } = slot;
-    if (!field.readable && !field.writable) return undefined;
-    if (!isEmittableField(context, field)) return undefined;
+
+    if (!field.readable && !field.writable) {
+        return undefined;
+    }
+
+    if (!isEmittableField(context, field)) {
+        return undefined;
+    }
+
     const jsName = toCamelIdentifier(field.name);
-    if (claimedNames.has(jsName)) return undefined;
-    if (jsName === "constructor") return undefined;
-    return { field, jsName };
-};
 
-export type RecordFieldEntry = {
-    jsName: string;
-    tsType: string;
-    writable: boolean;
-    doc: string | undefined;
+    if (claimedNames.has(jsName)) {
+        return undefined;
+    }
+
+    if (jsName === "constructor") {
+        return undefined;
+    }
+
+    return { field, jsName };
 };
 
-export const resolveRecordFieldEntry = (
+const resolveRecordFieldEntry = (
     context: ModuleContext,
     slot: RecordFieldSlot,
     claimedNames: Set<string>,
 ): RecordFieldEntry | undefined => {
     const admitted = admitField(context, slot, claimedNames);
-    if (admitted === undefined) return undefined;
+
+    if (admitted === undefined) {
+        return undefined;
+    }
+
     return {
         jsName: admitted.jsName,
         tsType: renderTsType(context, admitted.field.type, false),
@@ -83,27 +164,38 @@ export const resolveRecordFieldEntry = (
     };
 };
 
-export const renderRecordFieldAccessor = (
+const renderRecordFieldAccessor = (
     context: ModuleContext,
     slot: RecordFieldSlot,
     claimedNames: Set<string>,
     siblingFields: GirField[],
 ): string | undefined => {
     const admitted = admitField(context, slot, claimedNames);
-    if (admitted === undefined) return undefined;
+
+    if (admitted === undefined) {
+        return undefined;
+    }
+
     const { field, jsName } = admitted;
     const doc = renderJsDoc(field.doc);
-
     const structArray = renderStructArrayAccessor(context, { field, jsName, slot: slot.slot, siblingFields });
-    if (structArray !== undefined) return `${doc}${structArray}`;
+
+    if (structArray !== undefined) {
+        return `${doc}${structArray}`;
+    }
 
     if (!isAccessorEligibleType(context, field.type)) {
         const tsType = renderTsType(context, field.type, false);
+
         return `${doc}declare ${jsName}: ${tsType};`;
     }
 
-    const descriptor = context.hoistDescriptor(renderDescriptor(context, field.type, "none"));
+    // A record field whose C type is the record itself rather than a pointer to it holds the value
+    // in place, so its own address is the value and no word may be loaded out of it.
+    const isInline = resolveInlineStructFields(context, field.type, field.cType) !== undefined;
+    const descriptor = context.hoistDescriptor(renderDescriptor(context, field.type, "none", { isInline }));
     const tsType = renderTsType(context, field.type, false);
+
     const accessorOptions: AccessorOptions = {
         context,
         jsName,
@@ -112,33 +204,45 @@ export const renderRecordFieldAccessor = (
         slot: slot.slot,
         fieldType: field.type,
     };
+
     const blocks: string[] = [getterBlock(accessorOptions)];
+
     if (field.writable) {
         blocks.push(setterBlock(accessorOptions));
     }
+
     return `${doc}${blocks.join("\n\n")}`;
 };
 
 const isAccessorEligibleType = (context: ModuleContext, ref: TypeId): boolean => {
-    const type = context.library.typeOf(ref);
-    if (type === undefined) return true;
+    const type = context.library.typeFor(ref);
+
+    if (type === undefined) {
+        return true;
+    }
+
     switch (type.kind) {
-        case "primitive":
+        case "primitive": {
             return type.category !== "void" && type.category !== "unichar";
+        }
         case "class":
         case "interface":
         case "record":
         case "enum":
-        case "alias":
+        case "alias": {
             return true;
-        case "callback":
-            return context.library.nameOf(ref) !== undefined;
-        case "carray":
+        }
+        case "callback": {
+            return context.library.nameFor(ref) !== undefined;
+        }
+        case "carray": {
             return type.fixedSize !== undefined;
+        }
         case "list":
         case "hashtable":
-        case "varargs":
+        case "varargs": {
             return false;
+        }
     }
 };
 
@@ -147,12 +251,28 @@ const resolveInlineStructFields = (
     ref: TypeId | undefined,
     occurrenceCType: string | undefined,
 ): GirField[] | undefined => {
-    if (ref === undefined) return undefined;
-    if (occurrenceCType?.endsWith("*") === true) return undefined;
-    const type = context.library.typeOf(ref);
-    if (type?.kind !== "record") return undefined;
-    if (type.value.cType?.endsWith("*") === true) return undefined;
-    if (type.value.fields.length === 0) return undefined;
+    if (ref === undefined) {
+        return undefined;
+    }
+
+    if (occurrenceCType?.endsWith("*") === true) {
+        return undefined;
+    }
+
+    const type = context.library.typeFor(ref);
+
+    if (type?.kind !== "record") {
+        return undefined;
+    }
+
+    if (type.value.cType?.endsWith("*") === true) {
+        return undefined;
+    }
+
+    if (type.value.fields.length === 0) {
+        return undefined;
+    }
+
     return type.value.fields;
 };
 
@@ -160,24 +280,51 @@ const arrayLengthExpression = (
     arrayRef: Extract<GirType, { kind: "carray" }>,
     siblingFields: GirField[],
 ): string | undefined => {
-    if (arrayRef.fixedSize !== undefined) return String(arrayRef.fixedSize);
-    if (arrayRef.lengthParameterIndex === undefined) return undefined;
+    if (arrayRef.fixedSize !== undefined) {
+        return String(arrayRef.fixedSize);
+    }
+
+    if (arrayRef.lengthParameterIndex === undefined) {
+        return undefined;
+    }
+
     const lengthField = siblingFields.filter((field) => !field.private)[arrayRef.lengthParameterIndex];
-    if (lengthField === undefined) return undefined;
+
+    if (lengthField === undefined) {
+        return undefined;
+    }
+
     return `this.${toCamelIdentifier(lengthField.name)}`;
 };
 
-type InlineFieldVisit = {
-    jsName: string;
-    descriptor: string;
-    offset: number;
-    slot: FieldSlot;
-    type: TypeId;
-};
+const visitInlineStructSlot = (
+    context: ModuleContext,
+    entry: RecordFieldSlot,
+    baseOffset: number,
+    visitors: InlineFieldVisitors,
+): void => {
+    const { field, slot } = entry;
 
-type InlineFieldVisitors = {
-    leaf: (visit: InlineFieldVisit) => void;
-    nested: (jsName: string, nested: GirField[], offset: number) => void;
+    if (field.private || field.type === undefined || isInlineCallbackRef(context.library, field.type)) {
+        return;
+    }
+
+    const jsName = toCamelIdentifier(field.name);
+    const offset = baseOffset + slot.byteOffset;
+    const nested = resolveInlineStructFields(context, field.type, field.cType);
+
+    if (nested !== undefined) {
+        visitors.nested(jsName, nested, offset);
+
+        return;
+    }
+
+    if (!isAccessorEligibleType(context, field.type)) {
+        return;
+    }
+
+    const descriptor = context.hoistDescriptor(renderDescriptor(context, field.type, "none"));
+    visitors.leaf({ jsName, descriptor, offset, slot, type: field.type });
 };
 
 const visitInlineStructFields = (
@@ -187,70 +334,67 @@ const visitInlineStructFields = (
     visitors: InlineFieldVisitors,
 ): void => {
     const { slots } = computeRecordFieldSlots(context, fields);
-    for (const { field, slot } of slots) {
-        if (field.private || field.type === undefined || isInlineCallbackRef(context.library, field.type)) {
-            continue;
-        }
-        const jsName = toCamelIdentifier(field.name);
-        const offset = baseOffset + slot.byteOffset;
-        const nested = resolveInlineStructFields(context, field.type, field.cType);
-        if (nested !== undefined) {
-            visitors.nested(jsName, nested, offset);
-            continue;
-        }
-        if (!isAccessorEligibleType(context, field.type)) continue;
-        const descriptor = context.hoistDescriptor(renderDescriptor(context, field.type, "none"));
-        visitors.leaf({ jsName, descriptor, offset, slot, type: field.type });
+
+    for (const entry of slots) {
+        visitInlineStructSlot(context, entry, baseOffset, visitors);
     }
 };
 
+const elementAccessExpr = (descriptor: string, offset: number): string =>
+    `read(__array, ${descriptor}, __base + ${String(offset)})`;
+
+const renderElementReadEntry = (context: ModuleContext, visit: InlineFieldVisit): string => {
+    const { jsName, descriptor, offset, slot, type } = visit;
+    const access = elementAccessExpr(descriptor, offset);
+
+    if (slot.bitWidth === undefined) {
+        return `${jsName}: ${access} as ${renderTsType(context, type, false)}`;
+    }
+
+    const shift = slot.bitOffset ?? 0;
+
+    return `${jsName}: (((${access} as number) >>> ${String(shift)}) & ${String(bitMask(slot.bitWidth))})`;
+};
+
 const renderElementReadObject = (context: ModuleContext, fields: GirField[], baseOffset: number): string => {
     const entries: string[] = [];
+
     visitInlineStructFields(context, fields, baseOffset, {
-        leaf: ({ jsName, descriptor, offset, slot, type }) => {
-            if (slot.bitWidth === undefined) {
-                entries.push(
-                    `${jsName}: read(__array, ${descriptor}, __base + ${offset}) as ${renderTsType(context, type, false)}`,
-                );
-                return;
-            }
-            const shift = slot.bitOffset ?? 0;
-            entries.push(
-                `${jsName}: (((read(__array, ${descriptor}, __base + ${offset}) as number) >>> ${shift}) & ${bitMask(slot.bitWidth)})`,
-            );
+        leaf: (visit) => {
+            entries.push(renderElementReadEntry(context, visit));
         },
         nested: (jsName, nested, offset) => {
             entries.push(`${jsName}: ${renderElementReadObject(context, nested, offset)}`);
         },
     });
+
     return `{ ${entries.join(", ")} }`;
 };
 
-type ElementWriteOptions = {
-    fields: GirField[];
-    baseOffset: number;
-    valuePath: string;
-    out: string[];
+const renderElementWriteStatement = (visit: InlineFieldVisit, valuePath: string): string => {
+    const { jsName, descriptor, offset, slot } = visit;
+    const valueExpr = `${valuePath}.${jsName}`;
+
+    if (slot.bitWidth === undefined) {
+        return `write(__array, ${descriptor}, __base + ${String(offset)}, ${valueExpr});`;
+    }
+
+    const merged = mergeBitfield(
+        `(${elementAccessExpr(descriptor, offset)} as number)`,
+        valueExpr,
+        bitMask(slot.bitWidth),
+        slot.bitOffset ?? 0,
+    );
+
+    return `write(__array, ${descriptor}, __base + ${String(offset)}, ${merged});`;
 };
 
 const appendElementWriteStatements = (context: ModuleContext, options: ElementWriteOptions): void => {
     const { fields, baseOffset, valuePath, out } = options;
+
     visitInlineStructFields(context, fields, baseOffset, {
-        leaf: ({ jsName, descriptor, offset, slot }) => {
-            const valueExpr = `${valuePath}.${jsName}`;
-            if (slot.bitWidth === undefined) {
-                out.push(`write(__array, ${descriptor}, __base + ${offset}, ${valueExpr});`);
-                return;
-            }
-            const mask = bitMask(slot.bitWidth);
-            const shift = slot.bitOffset ?? 0;
-            const merged = mergeBitfield(
-                `(read(__array, ${descriptor}, __base + ${offset}) as number)`,
-                valueExpr,
-                mask,
-                shift,
-            );
-            out.push(`write(__array, ${descriptor}, __base + ${offset}, ${merged});`);
+        leaf: (visit) => {
+            out.push(renderElementWriteStatement(visit, valuePath));
         },
         nested: (jsName, nested, offset) => {
             appendElementWriteStatements(context, {
@@ -263,83 +407,141 @@ const appendElementWriteStatements = (context: ModuleContext, options: ElementWr
     });
 };
 
-type StructArrayTarget = {
-    field: GirField;
-    jsName: string;
-    slot: FieldSlot;
-    siblingFields: GirField[];
-};
-
-type StructArrayAccessorOptions = {
-    context: ModuleContext;
-    jsName: string;
-    tsType: string;
-    elementDescriptor: string;
-    offset: number;
-    lengthExpr: string;
-    elementSize: number;
-    elementFields: GirField[];
-};
-
 const structArrayGetterBlock = (options: StructArrayAccessorOptions): string => {
     const { context, jsName, tsType, elementDescriptor, offset, lengthExpr, elementSize, elementFields } = options;
     const element = renderElementReadObject(context, elementFields, 0);
-    const loop = [`const __base = __index * ${elementSize};`, `__result.push(${element});`].join("\n");
+    const loop = [`const __base = __index * ${String(elementSize)};`, `__result.push(${element});`].join("\n");
+    const handleType = "ReturnType<typeof getHandle>";
+
     const body = [
-        `const __array = read(getHandle(this), ${elementDescriptor}, ${offset}) as ReturnType<typeof getHandle>;`,
+        `const __array = read(getHandle(this), ${elementDescriptor}, ${String(offset)}) as ${handleType};`,
         `const __result: ${tsType} = [];`,
         `for (let __index = 0; __index < ${lengthExpr}; __index++) {`,
         indent(loop, 1),
         "}",
         "return __result;",
     ].join("\n");
+
     return renderBlock(`get ${jsName}(): ${tsType}`, body);
 };
 
-const structArraySetterBlock = (options: StructArrayAccessorOptions): string => {
-    const { context, jsName, tsType, elementDescriptor, offset, elementSize, elementFields } = options;
+const structArraySetterStatements = (context: ModuleContext, options: StructArrayAccessorOptions): string => {
+    const { elementDescriptor, offset, elementSize, elementFields } = options;
     const writes: string[] = [];
+
     appendElementWriteStatements(context, {
         fields: elementFields,
         baseOffset: 0,
         valuePath: "__element",
         out: writes,
     });
-    const loop = [`const __base = __index * ${elementSize};`, ...writes].join("\n");
-    const body = [
+
+    const loop = [`const __base = __index * ${String(elementSize)};`, ...writes].join("\n");
+
+    return [
         `const __descriptor = ${elementDescriptor};`,
-        `const __array = read(getHandle(this), __descriptor, ${offset}) as ReturnType<typeof getHandle>;`,
-        `for (const [__index, __element] of __value.entries()) {`,
+        `const __array = read(getHandle(this), __descriptor, ${String(offset)}) as ReturnType<typeof getHandle>;`,
+        "for (const [__index, __element] of __value.entries()) {",
         indent(loop, 1),
         "}",
-        `write(getHandle(this), __descriptor, ${offset}, __array);`,
+        `write(getHandle(this), __descriptor, ${String(offset)}, __array);`,
     ].join("\n");
-    return renderBlock(`set ${jsName}(__value: ${tsType})`, body);
 };
 
-const renderStructArrayAccessor = (context: ModuleContext, target: StructArrayTarget): string | undefined => {
-    const { field, jsName, slot, siblingFields } = target;
-    if (field.type === undefined || slot.bitWidth !== undefined) return undefined;
-    const arrayType = context.library.typeOf(field.type);
-    if (arrayType?.kind !== "carray") return undefined;
-    const elementType = context.library.typeOf(arrayType.element);
-    if (elementType?.kind === "record" && elementType.value.glibGetType !== undefined) return undefined;
+const structArraySetterBlock = (options: StructArrayAccessorOptions): string =>
+    renderBlock(
+        `set ${options.jsName}(__value: ${options.tsType})`,
+        structArraySetterStatements(options.context, options),
+    );
+
+const resolveStructArrayElements = (context: ModuleContext, fieldType: TypeId): StructArrayElements | undefined => {
+    const arrayType = context.library.typeFor(fieldType);
+
+    if (arrayType?.kind !== "carray") {
+        return undefined;
+    }
+
+    const elementType = context.library.typeFor(arrayType.element);
+
+    if (elementType?.kind === "record" && elementType.value.glibGetType !== undefined) {
+        return undefined;
+    }
+
     const elementFields = resolveInlineStructFields(context, arrayType.element, arrayType.elementCType);
-    if (elementFields === undefined) return undefined;
-    const lengthExpr = arrayLengthExpression(arrayType, siblingFields);
-    if (lengthExpr === undefined) return undefined;
-    const elementSize = computeRecordFieldSlots(context, elementFields).size;
-    if (elementSize === 0) return undefined;
 
+    if (elementFields === undefined) {
+        return undefined;
+    }
+
+    return { arrayType, elementFields };
+};
+
+const resolveStructArrayShape = (
+    context: ModuleContext,
+    elements: StructArrayElements,
+    siblingFields: GirField[],
+): { lengthExpr: string; elementSize: number } | undefined => {
+    const lengthExpr = arrayLengthExpression(elements.arrayType, siblingFields);
+
+    if (lengthExpr === undefined) {
+        return undefined;
+    }
+
+    const elementSize = computeRecordFieldSlots(context, elements.elementFields).size;
+
+    if (elementSize === 0) {
+        return undefined;
+    }
+
+    return { lengthExpr, elementSize };
+};
+
+const resolveStructArray = (context: ModuleContext, target: StructArrayTarget): StructArrayResolution | undefined => {
+    const { field, slot, siblingFields } = target;
+
+    if (field.type === undefined || slot.bitWidth !== undefined) {
+        return undefined;
+    }
+
+    const elements = resolveStructArrayElements(context, field.type);
+
+    if (elements === undefined) {
+        return undefined;
+    }
+
+    const shape = resolveStructArrayShape(context, elements, siblingFields);
+
+    if (shape === undefined) {
+        return undefined;
+    }
+
+    return {
+        fieldType: field.type,
+        elementFields: elements.elementFields,
+        lengthExpr: shape.lengthExpr,
+        elementSize: shape.elementSize,
+    };
+};
+
+const renderStructArrayAccessor = (context: ModuleContext, target: StructArrayTarget): string | undefined => {
+    const resolution = resolveStructArray(context, target);
+
+    if (resolution === undefined) {
+        return undefined;
+    }
+
+    const { field, jsName, slot } = target;
+    const { fieldType, elementFields, lengthExpr, elementSize } = resolution;
     context.addRuntimeImport("read");
     context.addRuntimeImport("getHandle");
     context.addRuntimeImport("t");
+
     const options: StructArrayAccessorOptions = {
         context,
         jsName,
-        tsType: renderTsType(context, field.type, false),
+        tsType: renderTsType(context, fieldType, false),
         elementDescriptor: tStruct("borrowed", {
-            size: `${lengthExpr} * ${elementSize}`,
+            size: `${lengthExpr} * ${String(elementSize)}`,
             wrapperClass: undefined,
             callerAllocated: false,
         }),
@@ -348,47 +550,58 @@ const renderStructArrayAccessor = (context: ModuleContext, target: StructArrayTa
         elementSize,
         elementFields,
     };
+
     const blocks: string[] = [];
-    if (field.readable) blocks.push(structArrayGetterBlock(options));
+
+    if (field.readable) {
+        blocks.push(structArrayGetterBlock(options));
+    }
+
     if (field.writable) {
         context.addRuntimeImport("write");
         blocks.push(structArraySetterBlock(options));
     }
-    return blocks.length === 0 ? undefined : blocks.join("\n\n");
-};
 
-type AccessorOptions = {
-    context: ModuleContext;
-    jsName: string;
-    tsType: string;
-    descriptor: string;
-    slot: FieldSlot;
-    fieldType: TypeId;
+    return blocks.length === 0 ? undefined : blocks.join("\n\n");
 };
 
 const getterBlock = (options: AccessorOptions): string => {
     const { context, jsName, tsType, descriptor, slot, fieldType } = options;
     context.addRuntimeImport("read");
     context.addRuntimeImport("getHandle");
+
     if (slot.bitWidth === undefined) {
-        const valueExpression = `read(getHandle(this), ${descriptor}, ${slot.byteOffset})`;
+        const valueExpression = `read(getHandle(this), ${descriptor}, ${String(slot.byteOffset)})`;
+
         const wrapped = wrapReturnValue(context, {
             ref: fieldType,
             nullable: false,
             valueExpression,
         });
+
         const body = `return ${wrapped};`;
+
         return renderBlock(`get ${jsName}(): ${tsType}`, body);
     }
+
     const mask = bitMask(slot.bitWidth);
     const shift = slot.bitOffset ?? 0;
-    const body = `const __unit = read(getHandle(this), ${descriptor}, ${slot.byteOffset}) as number;\nreturn (((__unit >>> ${shift}) & ${mask}) >>> 0) as ${tsType};`;
+    const readUnit = `const __unit = read(getHandle(this), ${descriptor}, ${String(slot.byteOffset)}) as number;`;
+    const body = `${readUnit}\nreturn (((__unit >>> ${String(shift)}) & ${String(mask)}) >>> 0) as ${tsType};`;
+
     return renderBlock(`get ${jsName}(): ${tsType}`, body);
 };
 
-const setterBlock = (options: AccessorOptions): string => {
-    const { context, jsName, tsType, descriptor, slot } = options;
+const setterBody = (context: ModuleContext, descriptor: string, slot: FieldSlot): string => {
     context.addRuntimeImport("getHandle");
-    const body = emitFieldWrite(context, { descriptor, slot, targetExpr: "getHandle(this)", valueExpr: "value" });
-    return renderBlock(`set ${jsName}(value: ${tsType})`, body);
+
+    return emitFieldWrite(context, { descriptor, slot, targetExpr: "getHandle(this)", valueExpr: "value" });
 };
+
+const setterBlock = (options: AccessorOptions): string =>
+    renderBlock(
+        `set ${options.jsName}(value: ${options.tsType})`,
+        setterBody(options.context, options.descriptor, options.slot),
+    );
+
+export { isEmittableField, emitFieldWrite, resolveRecordFieldEntry, renderRecordFieldAccessor, type RecordFieldEntry };