@grunnverk/kodrdriv 1.5.1 → 1.5.2

package/WORKSPACE-EXCLUSION-FIX.md

@@ -0,0 +1,99 @@
+# Workspace Exclusion Fix
+
+## Problem
+
+The `check_development` MCP prompt was incorrectly identifying test directories and documentation directories as packages that needed to be checked. This resulted in false positives for packages like:
+
+- `kodrdriv-docs` (in `doc/` or `docs/`)
+- `@test/external-unlink-test` (in `test-*/`)
+- `@test/app` (in `test-*/`)
+- `test-project` (in `test-*/`)
+
+These directories should be excluded from workspace scanning as they are not real packages that need development readiness checks.
+
+## Root Cause
+
+Two functions were calling `scanForPackageJsonFiles` without passing exclusion patterns:
+
+1. **`check-development.ts`** - The `executeCheckDevelopment` function
+2. **`shared.ts`** - The `discoverTreePackages` function (used by all tree tools)
+
+The `workspace.ts` resource already had the correct exclusion logic, but it wasn't being used consistently across all tools.
+
+## Solution
+
+Added the same exclusion pattern logic to both files:
+
+### Default Exclusion Patterns
+
+```typescript
+const DEFAULT_EXCLUDE_SUBPROJECTS = [
+    'doc/',
+    'docs/',
+    'test-*/',
+];
+```
+
+### Implementation
+
+Both files now:
+
+1. Load the kodrdriv config to get custom exclusions (if any)
+2. Build a comprehensive list of exclusion patterns:
+   - Standard build artifacts: `node_modules/`, `dist/`, `build/`, `.git/`
+   - Subproject exclusions from config or defaults
+3. Pass these patterns to `scanForPackageJsonFiles`
+
+### Files Modified
+
+- **`src/mcp/tools/check-development.ts`**
+  - Added `loadConfig` import
+  - Added `DEFAULT_EXCLUDE_SUBPROJECTS` constant
+  - Modified `executeCheckDevelopment` to load config and build exclusion patterns
+  
+- **`src/mcp/tools/shared.ts`**
+  - Added `loadConfig` import
+  - Added `DEFAULT_EXCLUDE_SUBPROJECTS` constant
+  - Modified `discoverTreePackages` to load config and build exclusion patterns
+
+## Configuration
+
+Users can customize exclusions in their `.kodrdrivrc.json`:
+
+```json
+{
+  "workspace": {
+    "excludeSubprojects": [
+      "doc/",
+      "docs/",
+      "test-*/",
+      "examples/",
+      "custom-test-dir/"
+    ]
+  }
+}
+```
+
+## Impact
+
+This fix affects:
+
+- **`check_development` prompt** - Now correctly ignores test/doc directories
+- **All tree tools** - `tree_commit`, `tree_publish`, `tree_link`, etc. now use consistent exclusions
+- **Workspace resource** - Already had correct behavior, now consistent with tools
+
+## Testing
+
+All precommit checks pass:
+- ✅ Linting
+- ✅ TypeScript compilation
+- ✅ Unit tests (1055 tests passed)
+- ✅ MCP compliance tests
+
+## Related Files
+
+The exclusion pattern logic is now consistent across:
+- `src/mcp/resources/workspace.ts` (original implementation)
+- `src/mcp/resources/tree-graph.ts` (already using exclusions)
+- `src/mcp/tools/check-development.ts` (fixed)
+- `src/mcp/tools/shared.ts` (fixed)

package/dist/constants.js

@@ -1,7 +1,7 @@
 import os from 'os';
 import path from 'path';
 
-/** Version string populated at build time with git and system information */ const VERSION = '1.5.1 (HEAD/5728d3e T:v1.5.1 2026-01-27 23:31:39 -0800) linux x64 v24.13.0';
+/** Version string populated at build time with git and system information */ const VERSION = '1.5.2 (HEAD/fe55baf T:v1.5.2 2026-01-28 00:30:31 -0800) linux x64 v24.13.0';
 /** The program name used in CLI help and error messages */ const PROGRAM_NAME = 'kodrdriv';
 const DEFAULT_OVERRIDES = false;
 const DATE_FORMAT_YEAR_MONTH_DAY_HOURS_MINUTES_SECONDS_MILLISECONDS = 'YYYY-MM-DD-HHmmss.SSS';

package/dist/mcp-server.js

@@ -13915,7 +13915,7 @@ import path2 from "path";
 // src/constants.ts
 import os from "os";
 import path from "path";
-var VERSION = "1.5.1 (HEAD/5728d3e T:v1.5.1 2026-01-27 23:31:39 -0800) linux x64 v24.13.0";
+var VERSION = "1.5.2 (HEAD/fe55baf T:v1.5.2 2026-01-28 00:30:31 -0800) linux x64 v24.13.0";
 var PROGRAM_NAME = "kodrdriv";
 var DATE_FORMAT_YEAR_MONTH_DAY_HOURS_MINUTES_SECONDS_MILLISECONDS = "YYYY-MM-DD-HHmmss.SSS";
 var DEFAULT_OUTPUT_DIRECTORY = "output/kodrdriv";
@@ -14144,6 +14144,36 @@ function installLogCapture() {
 // src/mcp/tools/shared.ts
 import { scanForPackageJsonFiles, buildDependencyGraph, topologicalSort } from "@grunnverk/tree-core";
 import { setLogger as setTreeExecutionLogger } from "@grunnverk/tree-execution";
+
+// src/utils/config.ts
+import fs2 from "fs/promises";
+import path3 from "path";
+var CONFIG_FILES = [".kodrdrivrc.json", ".kodrdrivrc", "kodrdriv.config.json"];
+async function loadConfig(cwd = process.cwd()) {
+  const logger2 = getLogger();
+  for (const filename of CONFIG_FILES) {
+    const configPath = path3.join(cwd, filename);
+    try {
+      const content = await fs2.readFile(configPath, "utf-8");
+      const config2 = JSON.parse(content);
+      logger2.verbose(`Loaded configuration from ${configPath}`);
+      return config2;
+    } catch (error48) {
+      if (error48.code !== "ENOENT") {
+        logger2.warn(`CONFIG_LOAD_FAILED: Failed to load configuration file | Path: ${configPath} | Error: ${error48.message} | Action: Using defaults`);
+      }
+    }
+  }
+  logger2.verbose("No configuration file found, using defaults");
+  return null;
+}
+
+// src/mcp/tools/shared.ts
+var DEFAULT_EXCLUDE_SUBPROJECTS = [
+  "doc/",
+  "docs/",
+  "test-*/"
+];
 function configureTreeExecutionLogger() {
   const coreLogger = getCoreLogger();
   setTreeExecutionLogger({
@@ -14204,7 +14234,17 @@ function setupPackageFocusCallback(config2, context) {
 }
 async function discoverTreePackages(directory, packages, startFrom) {
   try {
-    const packageJsonPaths = await scanForPackageJsonFiles(directory);
+    const config2 = await loadConfig(directory);
+    const excludeSubprojects = config2?.workspace?.excludeSubprojects ?? DEFAULT_EXCLUDE_SUBPROJECTS;
+    const excludedPatterns = [
+      "**/node_modules/**",
+      "**/dist/**",
+      "**/build/**",
+      "**/.git/**",
+      // Add subproject exclusions
+      ...excludeSubprojects.map((pattern) => `**/${pattern}**`)
+    ];
+    const packageJsonPaths = await scanForPackageJsonFiles(directory, excludedPatterns);
     if (packageJsonPaths.length === 0) {
       return null;
     }
@@ -15020,13 +15060,28 @@ import { formatErrorForMCP as formatErrorForMCP2, getLogger as getCoreLogger3, i
 import { scanForPackageJsonFiles as scanForPackageJsonFiles2 } from "@grunnverk/tree-core";
 import { getGitStatusSummary, getLinkedDependencies, run } from "@grunnverk/git-tools";
 import { readFile } from "fs/promises";
-import * as path3 from "path";
+import * as path4 from "path";
+var DEFAULT_EXCLUDE_SUBPROJECTS2 = [
+  "doc/",
+  "docs/",
+  "test-*/"
+];
 async function executeCheckDevelopment(args, _context) {
   const directory = args.directory || process.cwd();
   const { getLogs, remove } = installLogCapture();
   try {
     const logger2 = getCoreLogger3();
-    const packageJsonFiles = await scanForPackageJsonFiles2(directory);
+    const config2 = await loadConfig(directory);
+    const excludeSubprojects = config2?.workspace?.excludeSubprojects ?? DEFAULT_EXCLUDE_SUBPROJECTS2;
+    const excludedPatterns = [
+      "**/node_modules/**",
+      "**/dist/**",
+      "**/build/**",
+      "**/.git/**",
+      // Add subproject exclusions
+      ...excludeSubprojects.map((pattern) => `**/${pattern}**`)
+    ];
+    const packageJsonFiles = await scanForPackageJsonFiles2(directory, excludedPatterns);
     const isTree = packageJsonFiles.length > 1;
     logger2.info(`Checking development readiness for ${isTree ? "tree" : "single package"} in ${directory}`);
     const checks = {
@@ -15035,12 +15090,12 @@ async function executeCheckDevelopment(args, _context) {
       devVersion: { passed: true, issues: [] },
       linkStatus: { passed: true, issues: [] }
     };
-    const packagesToCheck = isTree ? packageJsonFiles : [path3.join(directory, "package.json")];
+    const packagesToCheck = isTree ? packageJsonFiles : [path4.join(directory, "package.json")];
     for (const pkgJsonPath of packagesToCheck) {
-      const pkgDir = path3.dirname(pkgJsonPath);
+      const pkgDir = path4.dirname(pkgJsonPath);
       const pkgJsonContent = await readFile(pkgJsonPath, "utf-8");
       const pkgJson = JSON.parse(pkgJsonContent);
-      const pkgName = pkgJson.name || path3.basename(pkgDir);
+      const pkgName = pkgJson.name || path4.basename(pkgDir);
       try {
         const gitStatus = await getGitStatusSummary(pkgDir);
         if (gitStatus.branch === "main" || gitStatus.branch === "master") {
@@ -15731,32 +15786,7 @@ async function readStatusResource(uri) {
 
 // src/mcp/resources/workspace.ts
 import { buildDependencyGraph as buildDependencyGraph2, scanForPackageJsonFiles as scanForPackageJsonFiles3 } from "@grunnverk/tree-core";
-
-// src/utils/config.ts
-import fs2 from "fs/promises";
-import path4 from "path";
-var CONFIG_FILES = [".kodrdrivrc.json", ".kodrdrivrc", "kodrdriv.config.json"];
-async function loadConfig(cwd = process.cwd()) {
-  const logger2 = getLogger();
-  for (const filename of CONFIG_FILES) {
-    const configPath = path4.join(cwd, filename);
-    try {
-      const content = await fs2.readFile(configPath, "utf-8");
-      const config2 = JSON.parse(content);
-      logger2.verbose(`Loaded configuration from ${configPath}`);
-      return config2;
-    } catch (error48) {
-      if (error48.code !== "ENOENT") {
-        logger2.warn(`CONFIG_LOAD_FAILED: Failed to load configuration file | Path: ${configPath} | Error: ${error48.message} | Action: Using defaults`);
-      }
-    }
-  }
-  logger2.verbose("No configuration file found, using defaults");
-  return null;
-}
-
-// src/mcp/resources/workspace.ts
-var DEFAULT_EXCLUDE_SUBPROJECTS = [
+var DEFAULT_EXCLUDE_SUBPROJECTS3 = [
   "doc/",
   "docs/",
   "test-*/"
@@ -15765,7 +15795,7 @@ async function readWorkspaceResource(uri) {
   const root = uri.path || process.cwd();
   try {
     const config2 = await loadConfig(root);
-    const excludeSubprojects = config2?.workspace?.excludeSubprojects ?? DEFAULT_EXCLUDE_SUBPROJECTS;
+    const excludeSubprojects = config2?.workspace?.excludeSubprojects ?? DEFAULT_EXCLUDE_SUBPROJECTS3;
     const excludedPatterns = [
       "**/node_modules/**",
       "**/dist/**",
@@ -15801,7 +15831,7 @@ async function readWorkspaceResource(uri) {
 
 // src/mcp/resources/tree-graph.ts
 import { buildDependencyGraph as buildDependencyGraph3, scanForPackageJsonFiles as scanForPackageJsonFiles4 } from "@grunnverk/tree-core";
-var DEFAULT_EXCLUDE_SUBPROJECTS2 = [
+var DEFAULT_EXCLUDE_SUBPROJECTS4 = [
   "doc/",
   "docs/",
   "test-*/"
@@ -15810,7 +15840,7 @@ async function readTreeGraphResource(uri) {
   const root = uri.path || process.cwd();
   try {
     const config2 = await loadConfig(root);
-    const excludeSubprojects = config2?.workspace?.excludeSubprojects ?? DEFAULT_EXCLUDE_SUBPROJECTS2;
+    const excludeSubprojects = config2?.workspace?.excludeSubprojects ?? DEFAULT_EXCLUDE_SUBPROJECTS4;
     const excludedPatterns = [
       "**/node_modules/**",
       "**/dist/**",
@@ -15857,7 +15887,7 @@ async function readTreeGraphResource(uri) {
 import { parsePackageJson, scanForPackageJsonFiles as scanForPackageJsonFiles5 } from "@grunnverk/tree-core";
 import { resolve } from "node:path";
 import { existsSync } from "node:fs";
-var DEFAULT_EXCLUDE_SUBPROJECTS3 = [
+var DEFAULT_EXCLUDE_SUBPROJECTS5 = [
   "doc/",
   "docs/",
   "test-*/"
@@ -15874,7 +15904,7 @@ async function readPackageResource(uri) {
     } else {
       const cwd = process.cwd();
       const config2 = await loadConfig(cwd);
-      const excludeSubprojects = config2?.workspace?.excludeSubprojects ?? DEFAULT_EXCLUDE_SUBPROJECTS3;
+      const excludeSubprojects = config2?.workspace?.excludeSubprojects ?? DEFAULT_EXCLUDE_SUBPROJECTS5;
       const excludedPatterns = [
         "**/node_modules/**",
         "**/dist/**",